Re: [ovs-dev] [PATCH v2 09/11] dpctl: Refactor opt_dpif_open().

2018-08-01 Thread Darrell Ball
On Wed, Aug 1, 2018 at 9:53 PM, Darrell Ball wrote: > Thanks for the patch Yi-hung > > This patch does not seem to fit with this series somehow; it seems more > related > to flushing conntrack by zone and tuple ? > My apologies; after I reached the details of patch 10, I see why you wanted to

Re: [ovs-dev] [PATCH 10/11] dpctl: Implement dpctl commands for conntrack per zone limit

2018-08-01 Thread Darrell Ball
Thanks for the patch Yi-hung On Wed, Aug 1, 2018 at 3:46 PM, Yi-Hung Wei wrote: > This patch implments the following three commands on dpctl so that > users can use ovs-dpctl or ovs-appctl to set, delete, and get the > per zone limit. > > For example, > Do these commands need a ‘zone’

Re: [ovs-dev] [PATCH v2 03/11] datapath: compat: Introduce static key support

2018-08-01 Thread Darrell Ball
Thanks for the patch Yi-hung On 8/1/18, 5:42 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yi-Hung Wei" wrote: This is a feature that is needed for a follow up patch in ovs kernel datapath. It is usually implied that patch in a series is needed by a subsequent patch in the same

Re: [ovs-dev] [PATCH v2 02/11] datapath: compat: Backports nf_conncount

2018-08-01 Thread Darrell Ball
Thanks for the patch Yi-hung On 8/1/18, 5:42 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yi-Hung Wei" wrote: This patch backports the nf_conncount backend that counts the number of connections matching an arbitrary key. The following patch will use the feature to support

Re: [ovs-dev] [PATCH v2 00/11] conntrack zone limitation

2018-08-01 Thread Darrell Ball
Thanks for the series Yi-hung I will help review it. I have a few general queries initially. Darrell On 8/1/18, 5:41 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yi-Hung Wei" wrote: This patch series implements connection tracking zone limitation to limit the maximum number of

Re: [ovs-dev] [PATCH v2 09/11] dpctl: Refactor opt_dpif_open().

2018-08-01 Thread Darrell Ball
Thanks for the patch Yi-hung This patch does not seem to fit with this series somehow; it seems more related to flushing conntrack by zone and tuple ? I had a generic change in my queue. I think it is more straightforward, since it keeps opt_dpif_open() simple and improves the error handling and

[ovs-dev] [patch v1] dpctl: Simplify dpctl_flush_conntrack.

2018-08-01 Thread Darrell Ball
The function dpctl_flush_conntrack() and other such functions with multiple optional arguments can be simplified by introducing a new function to check whether a valid datapath name is supplied as an argument to the functions. opt_dpif_open() can also make use of this new function to allow it to

[ovs-dev] Spende von $ 4,800,000.00!

2018-08-01 Thread Gloria Adelaida Elias Mejia
Hallo, Sie haben eine Spende von $ 4,800,000.00, ich habe die America Lotterie im Wert von $ 40 Millionen gewonnen und ich gebe einen Teil davon an fünf glückliche Menschen und Wohltätigkeitseinrichtungen zum Gedenken an meine verstorbene Frau, die an Krebs starb. Spendenreferenznummer: BBIB /

[ovs-dev] Spende von $ 4,800,000.00!

2018-08-01 Thread Gloria Adelaida Elias Mejia
Hallo, Sie haben eine Spende von $ 4,800,000.00, ich habe die America Lotterie im Wert von $ 40 Millionen gewonnen und ich gebe einen Teil davon an fünf glückliche Menschen und Wohltätigkeitseinrichtungen zum Gedenken an meine verstorbene Frau, die an Krebs starb. Spendenreferenznummer: BBIB /

Re: [ovs-dev] [ovs-dev, v2, 10 of 11] dpctl: Implement dpctl commands for conntrack per zone limit

2018-08-01 Thread 0-day Robot
Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 115 characters long (recommended limit is 79) #331 FILE: lib/dpctl.man:277:

[ovs-dev] [PATCH v2 11/11] system-traffic: Add conntrack per zoen limit test case

2018-08-01 Thread Yi-Hung Wei
Signed-off-by: Yi-Hung Wei --- tests/system-traffic.at | 75 + 1 file changed, 75 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index cbd954257ae8..1e6bf1e75565 100644 --- a/tests/system-traffic.at +++

[ovs-dev] [PATCH v2 09/11] dpctl: Refactor opt_dpif_open().

2018-08-01 Thread Yi-Hung Wei
Make opt_dpif_open() to support mulitple optional arguments. It will be useful for the following patches. Signed-off-by: Yi-Hung Wei --- lib/dpctl.c | 85 - 1 file changed, 44 insertions(+), 41 deletions(-) diff --git a/lib/dpctl.c

[ovs-dev] [PATCH v2 10/11] dpctl: Implement dpctl commands for conntrack per zone limit

2018-08-01 Thread Yi-Hung Wei
This patch implments the following three commands on dpctl so that users can use ovs-dpctl or ovs-appctl to set, delete, and get the per zone limit. For example, $ ovs-appctl dpctl/ct-set-limits default=10 zone=0,limit=5 zone=1,limit=3 $ ovs-appctl dpct/ct-del-limits zone=0 $ ovs-appctl

[ovs-dev] [PATCH v2 08/11] dpif-netlink: Implement conntrack zone limiit

2018-08-01 Thread Yi-Hung Wei
This patch provides the implementation of conntrack zone limit in dpif-netlink. It basically utilizes the netlink API to communicate with OVS kernel module to set, delete, and get conntrack zone limit. Signed-off-by: Yi-Hung Wei --- lib/dpif-netlink.c | 202

[ovs-dev] [PATCH v2 07/11] ct-dpif: Helper functions for conntrack zone limit

2018-08-01 Thread Yi-Hung Wei
This patch implments some helper function for conntrack zone limit. It will be useful for the following patches. Signed-off-by: Yi-Hung Wei --- lib/ct-dpif.c | 32 lib/ct-dpif.h | 4 2 files changed, 36 insertions(+) diff --git a/lib/ct-dpif.c

[ovs-dev] [PATCH v2 06/11] dpif: Support conntrack zone limit.

2018-08-01 Thread Yi-Hung Wei
This patch defines the dpif interface to support conntrack per zone limit. Basically, OVS users can use this interface to set, delete, and get the conntrack per zone limit for various dpif interfaces. The following patch will make use of the proposed interface to implement the feature.

[ovs-dev] [PATCH v2 05/11] datapath: conntrack: Support conntrack zone limit

2018-08-01 Thread Yi-Hung Wei
Upstream commit: commit 11efd5cb04a184eea4f57b68ea63463158d1 Author: Yi-Hung Wei Date: Thu May 24 17:56:43 2018 -0700 openvswitch: Support conntrack zone limit Currently, nf_conntrack_max is used to limit the maximum number of conntrack entries in the conntrack

[ovs-dev] [PATCH v2 04/11] datapath: Add conntrack limit netlink definition

2018-08-01 Thread Yi-Hung Wei
Upstream commit: commit 5972be6b2495c6bffbf97517fd1c070eef78 Author: Yi-Hung Wei Date: Thu May 24 17:56:42 2018 -0700 openvswitch: Add conntrack limit netlink definition Define netlink messages and attributes to support user kernel communication that uses the

[ovs-dev] [PATCH v2 03/11] datapath: compat: Introduce static key support

2018-08-01 Thread Yi-Hung Wei
This is a feature that is needed for a follow up patch in ovs kernel datapath. Signed-off-by: Yi-Hung Wei --- acinclude.m4 | 3 + datapath/linux/Modules.mk| 1 + datapath/linux/compat/include/linux/static_key.h | 70

[ovs-dev] [PATCH v2 02/11] datapath: compat: Backports nf_conncount

2018-08-01 Thread Yi-Hung Wei
This patch backports the nf_conncount backend that counts the number of connections matching an arbitrary key. The following patch will use the feature to support connection tracking zone limit in ovs kernel datapath. This backport is based on an upstream net-next commit 5c789e131cbb

[ovs-dev] [PATCH v2 01/11] compat: Backport nf_ct_netns_{get, put}()

2018-08-01 Thread Yi-Hung Wei
This patch backports nf_ct_netns_get/put() in order to support a feature in the follow up patch. nf_ct_netns_{get,put} were first introduced in upstream net-next commit ecb2421b5ddf ("netfilter: add and use nf_ct_netns_get/put") in kernel v4.10, and then updated in commmit 7e35ec0e8044

[ovs-dev] [PATCH v2 00/11] conntrack zone limitation

2018-08-01 Thread Yi-Hung Wei
This patch series implements connection tracking zone limitation to limit the maximum number of conntrack entries in the conntrack table for every zone. This feature aims to resolve a problem that if one of the VM/container under attack that abuses the usage the conntrack entries, it may block

Re: [ovs-dev] [PATCH v4 9/9] Documentation: OVN RBAC and IPsec tutorial

2018-08-01 Thread Qiuyu Xiao
Thanks Ben! I made a few comments below. Other than that, all looks pretty good! -Qiuyu On Wed, Aug 1, 2018 at 10:03 AM, Ben Pfaff wrote: > On Tue, Jul 31, 2018 at 02:08:54PM -0700, Qiuyu Xiao wrote: >> This patch adds step-by-step guide for configuring OVN Role-Based Access >> Control and

Re: [ovs-dev] [ovs-dev, 08 of 11] dpif-netlink: Implement conntrack zone limiit

2018-08-01 Thread 0-day Robot
Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: ^ lib/dpif-netlink.c:147:13: error: 'dpif_netlink_flow_get_stats' used but never

Re: [ovs-dev] [PATCH v6 1/2] rhel: support kmod build against multiple 7.2 kernels, rhel6

2018-08-01 Thread Yi-Hung Wei
On Wed, Aug 1, 2018 at 4:00 PM, Martin Xu wrote: > This patch extends commit 89dd5819cf18 (rhel: support kmod-openvswitch > build against multiple kernels, rhel6) to support building kmod RPMs > with multiple minor revisions within 3.10.0-327 kernels. It was > discovered for RHEL 7.2 that 41.3

Re: [ovs-dev] [PATCH v6 2/2] rhel: bug fix kmod spec file, rhel6

2018-08-01 Thread Yi-Hung Wei
On Wed, Aug 1, 2018 at 4:00 PM, Martin Xu wrote: > This patch fixes a scenario not working for RHEL7.3 in commit 89dd5819cf18. > When multiple versions passed into the kversion for the spec file, the > variable is used as is for the kernel module paths for command > weak-modules --add-modules.

Re: [ovs-dev] [PATCH v5] rhel: support kmod build against multiple 7.2 kernels, rhel6

2018-08-01 Thread Martin Xu
Thanks for the review. I've separated them into two patches in v6. Martin On Wed, Aug 1, 2018 at 3:48 PM, Yi-Hung Wei wrote: > On Wed, Aug 1, 2018 at 2:26 PM, Martin Xu wrote: > > This patch extends commit 89dd5819cf18 (rhel: support kmod-openvswitch > > build against multiple kernels, rhel6)

[ovs-dev] [PATCH v6 2/2] rhel: bug fix kmod spec file, rhel6

2018-08-01 Thread Martin Xu
This patch fixes a scenario not working for RHEL7.3 in commit 89dd5819cf18. When multiple versions passed into the kversion for the spec file, the variable is used as is for the kernel module paths for command weak-modules --add-modules. Then the modules cannot be found. Fixes: 89dd5819cf18

[ovs-dev] [PATCH v6 1/2] rhel: support kmod build against multiple 7.2 kernels, rhel6

2018-08-01 Thread Martin Xu
This patch extends commit 89dd5819cf18 (rhel: support kmod-openvswitch build against multiple kernels, rhel6) to support building kmod RPMs with multiple minor revisions within 3.10.0-327 kernels. It was discovered for RHEL 7.2 that 41.3 minor revision introduced backward incompatible changes.

[ovs-dev] [PATCH 10/11] dpctl: Implement dpctl commands for conntrack per zone limit

2018-08-01 Thread Yi-Hung Wei
This patch implments the following three commands on dpctl so that users can use ovs-dpctl or ovs-appctl to set, delete, and get the per zone limit. For example, $ ovs-appctl dpctl/ct-set-limits default=10 zone=0,limit=5 zone=1,limit=3 $ ovs-appctl dpct/ct-del-limits zone=0 $ ovs-appctl

[ovs-dev] [PATCH 11/11] system-traffic: Add conntrack per zoen limit test case

2018-08-01 Thread Yi-Hung Wei
Signed-off-by: Yi-Hung Wei --- tests/system-traffic.at | 75 + 1 file changed, 75 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index cbd954257ae8..1e6bf1e75565 100644 --- a/tests/system-traffic.at +++

[ovs-dev] [PATCH 08/11] dpif-netlink: Implement conntrack zone limiit

2018-08-01 Thread Yi-Hung Wei
This patch provides the implementation of conntrack zone limit in dpif-netlink. It basically utilizes the netlink API to communicate with OVS kernel module to set, delete, and get conntrack zone limit. Signed-off-by: Yi-Hung Wei --- lib/dpif-netlink.c | 201

[ovs-dev] [PATCH 09/11] dpctl: Refactor opt_dpif_open().

2018-08-01 Thread Yi-Hung Wei
Make opt_dpif_open() to support mulitple optional arguments. It will be useful for the following patches. Signed-off-by: Yi-Hung Wei --- lib/dpctl.c | 85 - 1 file changed, 44 insertions(+), 41 deletions(-) diff --git a/lib/dpctl.c

[ovs-dev] [PATCH 06/11] dpif: Support conntrack zone limit.

2018-08-01 Thread Yi-Hung Wei
This patch defines the dpif interface to support conntrack per zone limit. Basically, OVS users can use this interface to set, delete, and get the conntrack per zone limit for various dpif interfaces. The following patch will make use of the proposed interface to implement the feature.

[ovs-dev] [PATCH 07/11] ct-dpif: Helper functions for conntrack zone limit

2018-08-01 Thread Yi-Hung Wei
This patch implments some helper function for conntrack zone limit. It will be useful for the following patches. Signed-off-by: Yi-Hung Wei --- lib/ct-dpif.c | 32 lib/ct-dpif.h | 4 2 files changed, 36 insertions(+) diff --git a/lib/ct-dpif.c

[ovs-dev] [PATCH 04/11] datapath: Add conntrack limit netlink definition

2018-08-01 Thread Yi-Hung Wei
Upstream commit: commit 5972be6b2495c6bffbf97517fd1c070eef78 Author: Yi-Hung Wei Date: Thu May 24 17:56:42 2018 -0700 openvswitch: Add conntrack limit netlink definition Define netlink messages and attributes to support user kernel communication that uses the

[ovs-dev] [PATCH 03/11] datapath: compat: Introduce static key support

2018-08-01 Thread Yi-Hung Wei
This is a feature that is needed for a follow up patch in ovs kernel datapath. Signed-off-by: Yi-Hung Wei --- acinclude.m4 | 3 + datapath/linux/Modules.mk| 1 + datapath/linux/compat/include/linux/static_key.h | 70

[ovs-dev] [PATCH 02/11] datapath: compat: Backports nf_conncount

2018-08-01 Thread Yi-Hung Wei
This patch backports the nf_conncount backend that counts the number of connections matching an arbitrary key. The following patch will use the feature to support connection tracking zone limit in ovs kernel datapath. This backport is based on an upstream net-next commit 5c789e131cbb

[ovs-dev] [PATCH 01/11] compat: Backport nf_ct_netns_{get,put}()

2018-08-01 Thread Yi-Hung Wei
This patch backports nf_ct_netns_get/put() in order to support a feature in the follow up patch. nf_ct_netns_{get,put} were first introduced in upstream net-next commit ecb2421b5ddf ("netfilter: add and use nf_ct_netns_get/put") in kernel v4.10, and then updated in commmit 7e35ec0e8044

[ovs-dev] [PATCH 00/11] conntrack zone limitation

2018-08-01 Thread Yi-Hung Wei
This patch series implements connection tracking zone limitation to limit the maximum number of conntrack entries in the conntrack table for every zone. This feature aims to resolve a problem that if one of the VM/container under attack that abuses the usage the conntrack entries, it may block

Re: [ovs-dev] [PATCH v5] rhel: support kmod build against multiple 7.2 kernels, rhel6

2018-08-01 Thread Yi-Hung Wei
On Wed, Aug 1, 2018 at 2:26 PM, Martin Xu wrote: > This patch extends commit 89dd5819cf18 (rhel: support kmod-openvswitch > build against multiple kernels, rhel6) to support building kmod RPMs > with multiple minor revisions within 3.10.0-327 kernels. It was > discovered for RHEL 7.2 that 41.3

Re: [ovs-dev] [ovs-dev, v4] rhel: support kmod build against multiple 7.2 kernels, rhel6

2018-08-01 Thread 0-day Robot
Bleep bloop. Greetings Martin Xu, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #136 FILE:

Re: [ovs-dev] [PATCH] utilities: don't use a bashism to check that datapath exists

2018-08-01 Thread Martin Xu
Thanks for fixing this. Martin On Wed, Aug 1, 2018 at 8:48 AM, Timothy Redaelli wrote: > [[ ]] syntax is not supported, at least, by dash that Debian, Ubuntu and > other > linux distributions may use instead of bash. > > This commit uses, instead, a POSIX way that is compatible with any POSIX

[ovs-dev] [PATCH v5] rhel: support kmod build against multiple 7.2 kernels, rhel6

2018-08-01 Thread Martin Xu
This patch extends commit 89dd5819cf18 (rhel: support kmod-openvswitch build against multiple kernels, rhel6) to support building kmod RPMs with multiple minor revisions within 3.10.0-327 kernels. It was discovered for RHEL 7.2 that 41.3 minor revision introduced backward incompatible changes.

Re: [ovs-dev] [ovs-dev, v3] rhel: support kmod build against multiple 7.2 kernels, rhel6

2018-08-01 Thread 0-day Robot
Bleep bloop. Greetings Martin Xu, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #136 FILE:

[ovs-dev] [PATCH v4] rhel: support kmod build against multiple 7.2 kernels, rhel6

2018-08-01 Thread Martin Xu
This patch extends commit 89dd5819cf18 (rhel: support kmod-openvswitch build against multiple kernels, rhel6) to support building kmod RPMs with multiple minor revisions within 3.10.0-327 kernels. It was discovered for RHEL 7.2 that 41.3 minor revision introduced backward incompatible changes.

[ovs-dev] [PATCH v3] rhel: support kmod build against multiple 7.2 kernels, rhel6

2018-08-01 Thread Martin Xu
This patch extends commit 89dd5819cf18 (rhel: support kmod-openvswitch build against multiple kernels, rhel6) to support building kmod RPMs with multiple minor revisions within 3.10.0-327 kernels. It was discovered for RHEL 7.2 that 41.3 minor revision introduced backward incompatible changes.

[ovs-dev] [PATCH 1/6] system-dpdk: update test suite for non-phy testing

2018-08-01 Thread Aaron Conole
This allows a system that doesn't have a dedicated DPDK nic to execute some DPDK tests. In this fashion, tests that operate on virtual ports (such as dpdkvhostuserclient) can be executed in a wider set of environments. Signed-off-by: Aaron Conole --- tests/system-dpdk-macros.at | 18

[ovs-dev] [PATCH 3/6] system-dpdk: Allow running the dpdk tests from a VM

2018-08-01 Thread Aaron Conole
Some VM configurations result in CPU flags that cause warnings to be issued by the DPDK libraries. When these warnings are issued, the tests will fail. This commit adds the unreliable tsc warning to the list of ignored warnings. Signed-off-by: Aaron Conole --- tests/system-dpdk.at | 3 +++ 1

[ovs-dev] [PATCH 2/6] system-dpdk: skip all tests if there are no hugepages

2018-08-01 Thread Aaron Conole
From: Bala Sankaran A failure is quite harsh in this scenario. It's better to simply skip all the tests and let the user look at the logs to understand the missing hugepages. Signed-off-by: Bala Sankaran Co-authored-by: Aaron Conole Signed-off-by: Aaron Conole ---

[ovs-dev] [RFC 6/6] system-dpdk: Connect two namespaces via virtio

2018-08-01 Thread Aaron Conole
From: Bala Sankaran This adds a new test to the 'check-dpdk' subsystem that will exercise allocations, PMDs, and the vhost-user code path. Signed-off-by: Bala Sankaran Co-authored-by: Aaron Conole Signed-off-by: Aaron Conole --- NOTE: This currently is broken, and needs some help to fix.

[ovs-dev] [PATCH 5/6] system-dpdk: Convert /tmp to use OVS_RUNDIR

2018-08-01 Thread Aaron Conole
From: Bala Sankaran When multiple users run the DPDK testsuite ther dependence on /tmp will cause conflicts. Use the RUNDIR as a dynamic path to overcome this. NOTE: This still doesn't solve the dependency on /var/run that DPDK requires. Signed-off-by: Bala Sankaran Co-authored-by: Aaron

[ovs-dev] [PATCH 4/6] system-dpdk: Use a different character marker for sed commands

2018-08-01 Thread Aaron Conole
The default marker for sed commands according to the manual is /, but this is inconvenient when working with paths. The solution is either to escape all instances of / or use sed's \cREGEXc feature. Signed-off-by: Aaron Conole --- tests/system-dpdk.at | 14 +++--- 1 file changed, 7

[ovs-dev] [PATCH 0/6] system-dpdk: add support to ping two namespaces

2018-08-01 Thread Aaron Conole
This allows system-dpdk test suite to ping two namespaces via a pair of dpdkvhostuserclient ports, using testpmd as a forwarding agent. Currently, the final patch in the series (which adds the test) isn't reliable enough yet, so it is still RFC. Submitted for early feedback. Aaron Conole (3):

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix typo in registered command

2018-08-01 Thread Alin Gabriel Serdean
> On 25 Jul 2018, at 00:31, Ben Pfaff wrote: > > On Mon, Jul 23, 2018 at 05:45:30PM +0300, Alin Gabriel Serdean wrote: >> Also split line at 79 characters. >> >> Found by inspection. >> >> Signed-off-by: Alin Gabriel Serdean > > Acked-by: Ben Pfaff Applied on master and branch-2.10

Re: [ovs-dev] [PATCH] Add opterr and optopt to Windows headers

2018-08-01 Thread Alin Gabriel Serdean
> On 1 Aug 2018, at 20:17, Ben Pfaff wrote: > > On Wed, Aug 01, 2018 at 04:01:36PM +0300, aserd...@ovn.org > wrote: >>> -Mesaj original- >>> De la: ovs-dev-boun...@openvswitch.org >> boun...@openvswitch.org> În numele Ben Pfaff >>> Trimis: Tuesday, July 31,

[ovs-dev] [PATCH] tests: Test for ovs-ofctl snoop command

2018-08-01 Thread Ashish Varma
Added test for snoop command to check for the initial handshake messages when a bridge connects to a controller via 'unix' connection method. Signed-off-by: Ashish Varma --- tests/ovs-ofctl.at | 28 1 file changed, 28 insertions(+) diff --git a/tests/ovs-ofctl.at

[ovs-dev] Elementos de Puntuación y Ortografía.

2018-08-01 Thread Redacción de documentos ejecutivos
Nuevas Disposiciones RAE (Real Academia Española) Redacción de documentos ejecutivos y técnicos para profesionales Agosto 21 Introducción: Su desarrollo brinda herramientas para la comprensión de aspectos gramaticales del español necesarios para la redacción de textos coherentes,

Re: [ovs-dev] [ovs-discuss] ovsdb-server core dump and ovsdb corruption using raft cluster

2018-08-01 Thread Guru Shetty
I was able to reproduce it. I will work with Ben to get this fixed. On 26 July 2018 at 23:14, Girish Moodalbail wrote: > Hello Ben, > > Sorry, got distracted with something else at work. I am still able to > reproduce the issue, and this is what I have and what I did > (if you need the core,

Re: [ovs-dev] [PATCH v4 5/9] debian and rhel: Create IPsec package.

2018-08-01 Thread Ben Pfaff
Those sound to me like reasonable ways to test. Thank you. On Tue, Jul 31, 2018 at 04:13:44PM -0700, Qiuyu Xiao wrote: > The debian packaging is the same as the packaging we previously had. > For debian package, I tested it by installing it in ubuntu 16.04 with > 'dpkg -i'. For rpm package, I

Re: [ovs-dev] [PATCH v4 7/9] ovs-pki: generate x.509 v3 certificate

2018-08-01 Thread Ben Pfaff
On Tue, Jul 31, 2018 at 02:08:52PM -0700, Qiuyu Xiao wrote: > This patch modifies ovs-pki to generate x.509 version 3 certificate. > Compared with the x.509 v1 certificate generated by ovs-pki, version 3 > certificate adds subjectAltName field and sets its value the same as > common name (CN). The

Re: [ovs-dev] [PATCH] Add opterr and optopt to Windows headers

2018-08-01 Thread Ben Pfaff
On Wed, Aug 01, 2018 at 04:01:36PM +0300, aserd...@ovn.org wrote: > > -Mesaj original- > > De la: ovs-dev-boun...@openvswitch.org > boun...@openvswitch.org> În numele Ben Pfaff > > Trimis: Tuesday, July 31, 2018 7:37 PM > > Către: Alin Gabriel Serdean > > Cc: d...@openvswitch.org > >

Re: [ovs-dev] [ACL Meters 4/7] ovn: Add Meter and Meter_Band tables to the NB and SB databases.

2018-08-01 Thread Ben Pfaff
On Wed, Aug 01, 2018 at 02:21:51PM +0200, Simon Horman wrote: > On Sun, Jul 29, 2018 at 11:46:35PM -0700, Justin Pettit wrote: > > Add support for configuring meters through the Meter and Meter_Band > > tables in the Northbound database. This commit also has ovn-northd > > sync those tables

Re: [ovs-dev] [PATCH v4 9/9] Documentation: OVN RBAC and IPsec tutorial

2018-08-01 Thread Ben Pfaff
On Wed, Aug 01, 2018 at 10:03:38AM -0700, Ben Pfaff wrote: > On Tue, Jul 31, 2018 at 02:08:54PM -0700, Qiuyu Xiao wrote: > > This patch adds step-by-step guide for configuring OVN Role-Based Access > > Control and IPsec. > > > > Signed-off-by: Qiuyu Xiao > > You wrote a lot of documentation,

Re: [ovs-dev] [PATCH v4 9/9] Documentation: OVN RBAC and IPsec tutorial

2018-08-01 Thread Ben Pfaff
On Tue, Jul 31, 2018 at 02:08:54PM -0700, Qiuyu Xiao wrote: > This patch adds step-by-step guide for configuring OVN Role-Based Access > Control and IPsec. > > Signed-off-by: Qiuyu Xiao You wrote a lot of documentation, and it's really good! Thank you. I spent some time working to make it

Re: [ovs-dev] [PATCH v2] rhel: support kmod build against multiple 7.2 kernels, rhel6

2018-08-01 Thread Yi-Hung Wei
On Tue, Jul 31, 2018 at 11:59 PM, Martin Xu wrote: > This patch extends commit 89dd5819cf18 (rhel: support kmod-openvswitch > build against multiple kernels, rhel6) to support building kmod RPMs > with multiple minor revisions within 3.10.0-327 kernels. It was > discovered for RHEL 7.2 that 41.3

Re: [ovs-dev] [PATCH] ovs-vtep: Pass log level arguments to underlying utils.

2018-08-01 Thread Ilya Maximets
On 01.08.2018 18:54, Ilya Maximets wrote: > Control utils should be called with the same verbose level > at least to manage output to system logs. For example, to > disable unwanted syslog messages in unit tests or to enable > higher debug levels if needed. > New arguments added before

[ovs-dev] [PATCH] ovs-vtep: Pass log level arguments to underlying utils.

2018-08-01 Thread Ilya Maximets
Control utils should be called with the same verbose level at least to manage output to system logs. For example, to disable unwanted syslog messages in unit tests or to enable higher debug levels if needed. New arguments added before '-vconsole:off' because it's still incovinient to have console

[ovs-dev] [PATCH] utilities: don't use a bashism to check that datapath exists

2018-08-01 Thread Timothy Redaelli
[[ ]] syntax is not supported, at least, by dash that Debian, Ubuntu and other linux distributions may use instead of bash. This commit uses, instead, a POSIX way that is compatible with any POSIX shell (bash, dash, busybox sh, etc). CC: Martin Xu Fixes: 9763d17fbd05 ("utilities: check datapath

Re: [ovs-dev] The “overlay” mode issue while setting up OVS with DPDK

2018-08-01 Thread Sandeep Adapala
Hello Guru, After much trouble I was finally able to finish the task. Thanks for all the help. Here is what I did. Regards, Sandeep On Thu, Jul 26, 2018 at 2:14 PM, Sandeep Adapala wrote: > thanks a lot Guru you have been great help let me try this. > > On Thu, Jul 26, 2018 at 2:03 PM, Guru

Re: [ovs-dev] [PATCH 5/5] netdev: Clean up class initialization.

2018-08-01 Thread Ian Stokes
On 7/12/2018 10:55 PM, Ben Pfaff wrote: The macros are hard to read. This makes it a little more readable. Thanks for this Ben, one minor comment below. Signed-off-by: Ben Pfaff --- configure.ac | 1 + lib/netdev-dpdk.c | 235 --

[ovs-dev] [PATCH v2 9/9] tests: Disable syslog for ovsdb-tool.

2018-08-01 Thread Ilya Maximets
This is the only place where ovsdb-tool produces some logs. Also, it does not support '--timeout' option thus we can't just add it to the utils list. Let's add syslog option inplace. Signed-off-by: Ilya Maximets --- tests/ovsdb-cluster.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[ovs-dev] [PATCH v2 8/9] tests: Reorder logging args for ovn-sbctl in a subshell.

2018-08-01 Thread Ilya Maximets
'--log-file' should go after '-v' arguments to avoid unwanted 'opened log file' messages. Execution is in a subshell and not covered by aliases. Signed-off-by: Ilya Maximets --- tests/ovsdb-cluster.at | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH v2 7/9] tests: Disable syslog for test utils.

2018-08-01 Thread Ilya Maximets
This disables syslog logging for: * ovs-testcontroller * test-netflow * test-ovsdb * test-sflow * test-unixctl (for cases where it's not needed) Signed-off-by: Ilya Maximets --- tests/bridge.at | 3 ++- tests/ofproto-dpif.at | 32

[ovs-dev] [PATCH v2 6/9] tests: Drop full logging for ovs-ofctl.

2018-08-01 Thread Ilya Maximets
'-v' option removed. Found no reason to have fully verbose output from these ovs-ofctl calls. Signed-off-by: Ilya Maximets --- tests/ofproto.at | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/ofproto.at b/tests/ofproto.at index d6c6e9a..f57c15b 100644

[ovs-dev] [PATCH v2 5/9] tests: Enable only file logging by vlog/set appctl.

2018-08-01 Thread Ilya Maximets
Logs enabled by 'appctl vlog/set' are commonly only used for 'check_logs' at the end of the test. No need to enable any other logs except for file. Patch made automatically by sed replace. Signed-off-by: Ilya Maximets --- tests/dpif-netdev.at | 10 ++-- tests/learn.at

[ovs-dev] [PATCH v2 4/9] tests: Disable syslog for daemons.

2018-08-01 Thread Ilya Maximets
We can not just make an alias for deamons because many of them has logging options in their command lines. Let's handle them one by one. Additionally, it's a good chance to wrap all the very long lines for better readability. Signed-off-by: Ilya Maximets --- tests/ofproto-macros.at | 10

[ovs-dev] [PATCH v2 3/9] tests: Disable syslog by default for control utils.

2018-08-01 Thread Ilya Maximets
syslog messages from unit tests are not useful and only litter the system logs on build / test machines. Signed-off-by: Ilya Maximets --- tests/ofproto-macros.at | 2 +- tests/ovs-macros.at | 6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/ofproto-macros.at

[ovs-dev] [PATCH v2 2/9] tests: Set default timeout for utils in subshell.

2018-08-01 Thread Ilya Maximets
Aliases are not inheritable. To add a default options for utils executed in subshell we may try to catch them here and append options explicitly. There are still few cases with utils invocation in subshell inside the functions that we can not track this way, but they are not very frequent.

[ovs-dev] [PATCH v2 1/9] tests: Simplify the setting of aliases.

2018-08-01 Thread Ilya Maximets
There is no need to create a separate function for each alias. This will simplify adding new default options and utils. Signed-off-by: Ilya Maximets --- tests/ovs-macros.at | 35 +-- 1 file changed, 5 insertions(+), 30 deletions(-) diff --git

[ovs-dev] [PATCH v2 0/9] tests: Clean up syslog.

2018-08-01 Thread Ilya Maximets
Each run of the testsuite produces millions lines in a system log. This is completely unnecessary and makes it difficult to use system logs on test / build servers. This series is aimed to disable most of the syslog messages. There are still few logs that requires significant changes in tests or

Re: [ovs-dev] [PATCH 1/9] tests: Simplify the setting of aliases.

2018-08-01 Thread Ilya Maximets
On 01.08.2018 16:34, Aaron Conole wrote: > Hi Ilya, > > Ilya Maximets writes: > >> There is no need to create a separate function for each alias. >> This will simplify adding new default options and utils. >> >> Signed-off-by: Ilya Maximets >> --- >> tests/ovs-macros.at | 35

Re: [ovs-dev] [PATCH] utilities: Run ovsdb-server pre-startup DB steps as root

2018-08-01 Thread Aaron Conole
Ben Pfaff writes: > I don't understand the conclusion in this thread. Does anyone want me > to apply some patch? Or should I stay tuned for further discussion? Stay tuned for the exciting conclusion, please :) > Thanks, > > Ben. ___ dev mailing

Re: [ovs-dev] [PATCH 1/9] tests: Simplify the setting of aliases.

2018-08-01 Thread Aaron Conole
Hi Ilya, Ilya Maximets writes: > There is no need to create a separate function for each alias. > This will simplify adding new default options and utils. > > Signed-off-by: Ilya Maximets > --- > tests/ovs-macros.at | 35 +-- > 1 file changed, 5 insertions(+),

[ovs-dev] [PATCH 9/9] tests: Disable syslog for ovsdb-tool.

2018-08-01 Thread Ilya Maximets
This is the only place where ovsdb-tool produces some logs. Also, it does not support '--timeout' option thus we can't just add it to the utils list. Let's add syslog option inplace. Signed-off-by: Ilya Maximets --- tests/ovsdb-cluster.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[ovs-dev] [PATCH 8/9] tests: Reorder logging args for ovn-sbctl in a subshell.

2018-08-01 Thread Ilya Maximets
'--log-file' should go after '-v' arguments to avoid unwanted 'opened log file' messages. Execution is in a subshell and not covered by aliases. Signed-off-by: Ilya Maximets --- tests/ovsdb-cluster.at | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH 7/9] tests: Disable syslog for test utils.

2018-08-01 Thread Ilya Maximets
This disables syslog logging for: * ovs-testcontroller * test-netflow * test-ovsdb * test-sflow * test-unixctl (for cases where it's not needed) Signed-off-by: Ilya Maximets --- tests/bridge.at | 3 ++- tests/ofproto-dpif.at | 32

[ovs-dev] [PATCH 5/9] tests: Enable only file logging by vlog/set appctl.

2018-08-01 Thread Ilya Maximets
Logs enabled by 'appctl vlog/set' are commonly only used for 'check_logs' at the end of the test. No need to enable any other logs except for file. Patch made automatically by sed replace. Signed-off-by: Ilya Maximets --- tests/dpif-netdev.at | 10 ++-- tests/learn.at

[ovs-dev] [PATCH 6/9] tests: Drop full logging for ovs-ofctl.

2018-08-01 Thread Ilya Maximets
'-v' option removed. Found no reason to have fully verbose output from these ovs-ofctl calls. Signed-off-by: Ilya Maximets --- tests/ofproto.at | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/ofproto.at b/tests/ofproto.at index d6c6e9a..f57c15b 100644

[ovs-dev] [PATCH 4/9] tests: Disable syslog for daemons.

2018-08-01 Thread Ilya Maximets
We can not just make an alias for deamons because many of them has logging options in their command lines. Let's handle them one by one. Additionally, it's a good chance to wrap all the very long lines for better readability. Signed-off-by: Ilya Maximets --- tests/ofproto-macros.at | 10

[ovs-dev] [PATCH 3/9] tests: Disable syslog by default for control utils.

2018-08-01 Thread Ilya Maximets
syslog messages from unit tests are not useful and only litter the system logs on build / test machines. Signed-off-by: Ilya Maximets --- tests/ofproto-macros.at | 2 +- tests/ovs-macros.at | 6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/ofproto-macros.at

[ovs-dev] [PATCH 2/9] tests: Set default timeout for utils in subshell.

2018-08-01 Thread Ilya Maximets
Aliases are not inheritable. To add a default options for utils executed in subshell we may try to catch them here and append options explicitly. There are still few cases with utils invocation in subshell inside the functions that we can not track this way, but they are not very frequent.

[ovs-dev] [PATCH 1/9] tests: Simplify the setting of aliases.

2018-08-01 Thread Ilya Maximets
There is no need to create a separate function for each alias. This will simplify adding new default options and utils. Signed-off-by: Ilya Maximets --- tests/ovs-macros.at | 35 +-- 1 file changed, 5 insertions(+), 30 deletions(-) diff --git

[ovs-dev] [PATCH 0/9] tests: Clean up syslog.

2018-08-01 Thread Ilya Maximets
Each run of the testsuite produces millions lines in a system log. This is completely unnecessary and makes it difficult to use system logs on test / build servers. This series is aimed to disable most of the syslog messages. There are still few logs that requires significant changes in tests or

Re: [ovs-dev] [PATCH V2 0/4] Enable set/match of tos/ttl for IP tunnels on TC data-path

2018-08-01 Thread Or Gerlitz
On Wed, Aug 1, 2018 at 2:29 PM, Simon Horman wrote: > Hi Or, > > On 1 August 2018 at 13:21, Or Gerlitz wrote: >> >> On Wed, Aug 1, 2018 at 2:07 PM, Simon Horman >> wrote: >> > On 1 August 2018 at 11:31, Simon Horman >> > wrote: >> >> >> >> Thanks Or, Thanks Ben, >> >> >> >> On 1 August 2018 at

Re: [ovs-dev] [PATCH] Add opterr and optopt to Windows headers

2018-08-01 Thread aserdean
> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Tuesday, July 31, 2018 7:37 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] Add opterr and optopt to Windows headers > > On

Re: [ovs-dev] [ACL Meters 4/7] ovn: Add Meter and Meter_Band tables to the NB and SB databases.

2018-08-01 Thread Simon Horman
On Sun, Jul 29, 2018 at 11:46:35PM -0700, Justin Pettit wrote: > Add support for configuring meters through the Meter and Meter_Band > tables in the Northbound database. This commit also has ovn-northd > sync those tables between the Northbound and Southbound databases. > > Add support for

[ovs-dev] [PATCH v7 3/4] Document the flows for redirecting VLAN packets

2018-08-01 Thread vkommadi
From: venkata anil We have added new flows for using vlans instead of tunnels for redirecting VLAN packets to a gateway chassis. This patch documents these flows in ovn-northd.8.xml and ovn-architecture.7.xml. Signed-off-by: Venkata Anil --- v6->v7: * Rebased v5->v6: * Rebased v4->v5: *

[ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

2018-08-01 Thread vkommadi
From: venkata anil Previous patches in the series doesn't address issue 1 explained in [1] i.e 1) removal of router gateway port MAC address on external switches after expiring of aging time. 2) then external switches unable to learn the gateway MAC as reply packets carry router internal

[ovs-dev] [PATCH v7 2/4] Send gateway port ARP through router internal ports

2018-08-01 Thread vkommadi
From: venkata anil External switches should learn the distributed gateway port MAC address as they have to forward the packet tagged with tenant vlan network but with this MAC as destination MAC address. So router has to send ARP reply and gARP for this MAC address through router internal patch

  1   2   >