[ovs-dev] 答复: 答复: [bug] ovs crash when call xlate_normal_flood

2018-08-02 Thread Linhaifeng
Sorry . send wrong message. Pls igore. The problem is ousr code had 'use-after-free' -邮件原件- 发件人: Linhaifeng 发送时间: 2018年8月3日 13:55 收件人: 'Ben Pfaff' 抄送: d...@openvswitch.org 主题: 答复: [ovs-dev] 答复: [bug] ovs crash when call xlate_normal_flood Some PMD add to ovs dpdk aslo have linux if

[ovs-dev] 答复: 答复: [bug] ovs crash when call xlate_normal_flood

2018-08-02 Thread Linhaifeng
Some PMD add to ovs dpdk aslo have linux if interface . Linux if interface would notice ovs to reconfig and would fail too when failed to add. -邮件原件- 发件人: Ben Pfaff [mailto:b...@ovn.org] 发送时间: 2018年7月11日 5:08 收件人: Linhaifeng 抄送: d...@openvswitch.org 主题: Re: [ovs-dev] 答复: [bug] ovs

[ovs-dev] [patch v2] dpctl: Simplify dpctl_flush_conntrack.

2018-08-02 Thread Darrell Ball
The function dpctl_flush_conntrack() and other such functions with multiple optional arguments can be simplified by introducing a new function to check whether a valid datapath name is supplied as an argument to the functions. opt_dpif_open() can also make use of this new function to allow it to

Re: [ovs-dev] ofproto-dpif: Add logging when sending out an in_port

2018-08-02 Thread 0-day Robot
Bleep bloop. Greetings Zak Whittington, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: patch fragment without header at line 7: @@ -5092,6 +5094,8 @@

[ovs-dev] Problem in using ovs in raspberry pi - regd.

2018-08-02 Thread Viswanath Muthukumaraswamy Sathananth
Hi, I am trying to implement a real test bed to check the interaction between switches and controllers. Raspberry Pi 3b+ act as switches with OVS version 2.5.5 running on them. Two such Raspberry Pis connected to a RYU controller running on Windows 10 Machine wirelessly. One Raspberry Pi

[ovs-dev] [PATCH] ofproto-dpif: Add logging when sending out an in_port

2018-08-02 Thread Zak Whittington
This patch adds a log message to warn when sending out an in_port. VMware-BZ: #2158607 Signed-off-by: Zak Whittington --- ofproto/ofproto-dpif-xlate.c | 4 1 file changed, 4 insertions(+) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index 01f1faf..93fbee5

Re: [ovs-dev] [PATCH] json: Use unnamed embedded union.

2018-08-02 Thread Flavio Leitner
On Thu, Aug 02, 2018 at 06:44:10PM -0300, Flavio Leitner wrote: > Otherwise the code does not build. > > Fixes: fa37affad362 ("Embrace anonymous unions.") > Signed-off-by: Flavio Leitner This needs to go in branch-2.10 as well. -- Flavio ___ dev

[ovs-dev] [PATCH] json: Use unnamed embedded union.

2018-08-02 Thread Flavio Leitner
Otherwise the code does not build. Fixes: fa37affad362 ("Embrace anonymous unions.") Signed-off-by: Flavio Leitner --- python/ovs/_json.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/python/ovs/_json.c b/python/ovs/_json.c index 7067ce26a..8b8402025

Re: [ovs-dev] [PATCH 10/11] dpctl: Implement dpctl commands for conntrack per zone limit

2018-08-02 Thread Yi-Hung Wei
On Wed, Aug 1, 2018 at 10:37 PM, Darrell Ball wrote: > On Wed, Aug 1, 2018 at 3:46 PM, Yi-Hung Wei wrote: > > Do these commands need a ‘zone’ keyword > > eg) ct-set-zone-limits > >> >> $ ovs-appctl dpctl/ct-set-limits default=10 zone=0,limit=5 zone=1,limit=3 I think I am fine either way. I can

Re: [ovs-dev] [PATCH v2 03/11] datapath: compat: Introduce static key support

2018-08-02 Thread Yi-Hung Wei
On Wed, Aug 1, 2018 at 10:08 PM, Darrell Ball wrote: > Thanks for the patch Yi-hung > > On 8/1/18, 5:42 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yi-Hung > Wei" > wrote: > > This is a feature that is needed for a follow up patch > in ovs kernel datapath. > > It is usually

Re: [ovs-dev] [PATCH v2 02/11] datapath: compat: Backports nf_conncount

2018-08-02 Thread Yi-Hung Wei
> On 8/1/18, 5:42 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yi-Hung > Wei" > wrote: > > This patch backports the nf_conncount backend that counts the number > of connections matching an arbitrary key. The following patch will > use the feature to support connection tracking

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

2018-08-02 Thread Mark Michelson
On 08/01/2018 08:16 AM, vkomm...@redhat.com wrote: From: venkata anil Previous patches in the series doesn't address issue 1 explained in [1] i.e 1) removal of router gateway port MAC address on external switches after expiring of aging time. 2) then external switches unable to learn the

Re: [ovs-dev] [PATCH v4 0/9] IPsec support for tunneling

2018-08-02 Thread Qiuyu Xiao
Thanks for the review! I will start to work on the v5 patch. -Qiuyu On Thu, Aug 2, 2018 at 11:47 AM, Ben Pfaff wrote: > On Tue, Jul 31, 2018 at 02:08:45PM -0700, Qiuyu Xiao wrote: >> This patch series reintroduce IPsec support for OVS tunneling and enable OVN >> to >> use IPsec tunnels. GRE,

Re: [ovs-dev] [PATCH v2 2/2] ovn: Modify restart_controller in ovn-ctl to use --restart

2018-08-02 Thread Ben Pfaff
On Tue, Jul 31, 2018 at 10:27:59AM +0200, Jakub Sitnicki wrote: > On Mon, 30 Jul 2018 09:47:45 -0400 > Mark Michelson wrote: > > > The --restart flag allows for uninterrupted packet flowage when exiting > > ovn-controller. This patch modifies the restart_controller argument to > > ovn-ctl to use

Re: [ovs-dev] [PATCH v4 8/9] OVN: native support for tunnel encryption

2018-08-02 Thread Qiuyu Xiao
Yes, it makes sense. I will add this to the next revision. Thanks, Qiuyu On Thu, Aug 2, 2018 at 11:31 AM, Ben Pfaff wrote: > On Tue, Jul 31, 2018 at 02:08:53PM -0700, Qiuyu Xiao wrote: >> This patch adds IPsec support for OVN tunnel. Basically, OVN offers a >> binary option to its user for

Re: [ovs-dev] [PATCH] AUTHORS: Update email address for Jakub Sitnicki.

2018-08-02 Thread Ben Pfaff
On Thu, Aug 02, 2018 at 11:48:26AM -0400, Aaron Conole wrote: > Jakub Sitnicki writes: > > > Signed-off-by: Jakub Sitnicki > > --- > > > > The j...@redhat.com address will be valid only until August 4th. > > :'( > > With sadness: > > Acked-by: Aaron Conole Jakub, I'm sorry to see you go.

Re: [ovs-dev] [PATCH v7] ovn: Allow for automatic dynamic updates of IPAM

2018-08-02 Thread Ben Pfaff
On Thu, Aug 02, 2018 at 08:52:56AM -0400, Mark Michelson wrote: > OVN offers a method of IP address management that allows for an IPv4 subnet or > IPv6 prefix to be specified on a logical switch. Then by specifying a > switch port's address as "dynamic" or " dynamic", OVN will > automatically

Re: [ovs-dev] [PATCH v4 0/9] IPsec support for tunneling

2018-08-02 Thread Ben Pfaff
On Tue, Jul 31, 2018 at 02:08:45PM -0700, Qiuyu Xiao wrote: > This patch series reintroduce IPsec support for OVS tunneling and enable OVN > to > use IPsec tunnels. GRE, VXLAN, GENEVE, and STT IPsec tunnels are supported. > StrongSwan and LibreSwan IKE daemons are supported. Thanks a lot for

Re: [ovs-dev] [PATCH v4 9/9] Documentation: OVN RBAC and IPsec tutorial

2018-08-02 Thread Ben Pfaff
On Tue, Jul 31, 2018 at 02:08:54PM -0700, Qiuyu Xiao wrote: > This patch adds step-by-step guide for configuring OVN Role-Based Access > Control and IPsec. > > Signed-off-by: Qiuyu Xiao Here are my suggestions for this patch (really for this one, this time). I'll look forward to v5 of this

Re: [ovs-dev] [PATCH v4 9/9] Documentation: OVN RBAC and IPsec tutorial

2018-08-02 Thread Ben Pfaff
Thanks for the comments. Can you integrate my suggestions and your comments for v5? Thanks, Ben. On Wed, Aug 01, 2018 at 05:28:02PM -0700, Qiuyu Xiao wrote: > Thanks Ben! I made a few comments below. Other than that, all looks pretty > good! > > -Qiuyu > > On Wed, Aug 1, 2018 at 10:03 AM,

Re: [ovs-dev] [PATCH v4 8/9] OVN: native support for tunnel encryption

2018-08-02 Thread Ben Pfaff
On Tue, Jul 31, 2018 at 02:08:53PM -0700, Qiuyu Xiao wrote: > This patch adds IPsec support for OVN tunnel. Basically, OVN offers a > binary option to its user for encryption configuration. If the IPsec > option is turned on, all tunnels will be encrypted. Otherwise, no tunnel > will be encrypted.

Re: [ovs-dev] [PATCH] tests: Test for ovs-ofctl snoop command

2018-08-02 Thread Ashish Varma
Thanks for the review. I will try to use OVS_WAIT_UNTIL (or something similar) On Thu, Aug 2, 2018 at 7:33 AM, Ilya Maximets wrote: > Hello. Thanks for the patch. > I'm not much familiar with that functionality thus someone > else should review the sanity of this patch, but I have few >

[ovs-dev] [PATCH] ofproto-dpif-upcall: Fix for flow limit issue in revalidator

2018-08-02 Thread Vishal Deep Ajmera
When the revalidator thread takes a long time to dump data path flows (e.g. due to busy CPU), it reduces the maximum limit for new flows that can be added. This results in more upcalls for packets which do not find data path flows and temporarily reduces overall throughput. When the situation

[ovs-dev] US $15.5million Cash Payment/Home Delivery. From Nat West Bank London UK.

2018-08-02 Thread ahmed idris via dev
Nat West Bank London, United Kingdom. (Offshore Office) Attention: I am contacting you by email from our offshore office, where a contract payment of $15.5million United States dollars only emerged on your name as a legitimate beneficiary of the fund. I am the manager, over seeing the release

Re: [ovs-dev] [PATCH] utilities: Run ovsdb-server pre-startup DB steps as root

2018-08-02 Thread Timothy Redaelli
On Thu, Aug 2, 2018 at 4:58 PM, Timothy Redaelli wrote: [...] > > diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in > index c3b76ec94..33776aac7 100644 > --- a/utilities/ovs-lib.in > +++ b/utilities/ovs-lib.in > @@ -389,7 +389,10 @@ move_ip_routes () { > > ovsdb_tool () { > if [

[ovs-dev] Word para Ejecutivos

2018-08-02 Thread Redacción de textos a nivel profesional
Correcta Utilización de WORD para ejecutivos Agosto 23 Introducción: Se conocerán distintas herramientas de edición de texto, gráficos, figuras, inserción de imágenes, tablas y utilización de plantillas. Se hará una revisión de todas las opciones que ofrece Microsoft Word para la

Re: [ovs-dev] [PATCH] utilities: Run ovsdb-server pre-startup DB steps as root

2018-08-02 Thread Timothy Redaelli
On Fri, Jul 27, 2018 at 8:16 PM, Aaron Conole wrote: > Markos Chandras writes: [...] > > Is it possible that the provided diff can fix most of the issue (rather > than needing the corrective block in ovs-ctl)? If so, I'd advocate for > the smaller change instead. I need to double check it on

Re: [ovs-dev] [PATCH] AUTHORS: Update email address for Jakub Sitnicki.

2018-08-02 Thread Aaron Conole
Jakub Sitnicki writes: > Signed-off-by: Jakub Sitnicki > --- > > The j...@redhat.com address will be valid only until August 4th. :'( With sadness: Acked-by: Aaron Conole > AUTHORS.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/AUTHORS.rst b/AUTHORS.rst >

Re: [ovs-dev] [PATCH] tests: Test for ovs-ofctl snoop command

2018-08-02 Thread Ilya Maximets
Hello. Thanks for the patch. I'm not much familiar with that functionality thus someone else should review the sanity of this patch, but I have few comments about testing itself. See inline. Best regard, Ilya Maximets. > Added test for snoop command to check for the initial handshake messages >

Re: [ovs-dev] netlink-notifier: support blacklist

2018-08-02 Thread 0-day Robot
Bleep bloop. Greetings Haifeng Lin, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Remove Gerrit Change-Id's before submitting upstream. 9: Change-Id:

[ovs-dev] [PATCH] netlink-notifier: support blacklist

2018-08-02 Thread Haifeng Lin
in dpdk ovs mode some ether not need rtnetlink notifier so we can use blacklist remove ethernet from rtnetlink notifier Change-Id: I34121a4c44bfb2fcfe8799130762474bbfe5c015 Signed-off-by: Haifeng Lin --- lib/netdev-dpdk.c | 3 ++ lib/netlink-notifier.c | 5 ++- lib/rtnetlink.c|

Re: [ovs-dev] [PATCH v6] ovn: Allow for automatic dynamic updates of IPAM

2018-08-02 Thread Mark Michelson
On 08/02/2018 08:48 AM, Jakub Sitnicki wrote: Hi Mark, On Thu, 2 Aug 2018 08:18:12 -0400 Mark Michelson wrote: OVN offers a method of IP address management that allows for an IPv4 subnet or IPv6 prefix to be specified on a logical switch. Then by specifying a switch port's address as

[ovs-dev] [PATCH v7] ovn: Allow for automatic dynamic updates of IPAM

2018-08-02 Thread Mark Michelson
OVN offers a method of IP address management that allows for an IPv4 subnet or IPv6 prefix to be specified on a logical switch. Then by specifying a switch port's address as "dynamic" or " dynamic", OVN will automatically assign addresses to the switch port. While this works great for initial

Re: [ovs-dev] [PATCH v6] ovn: Allow for automatic dynamic updates of IPAM

2018-08-02 Thread Jakub Sitnicki
Hi Mark, On Thu, 2 Aug 2018 08:18:12 -0400 Mark Michelson wrote: > OVN offers a method of IP address management that allows for an IPv4 > subnet or IPv6 prefix to be specified on a logical switch. Then by > specifying a switch port's address as "dynamic" or " > dynamic", OVN will automatically

[ovs-dev] [PATCH v6] ovn: Allow for automatic dynamic updates of IPAM

2018-08-02 Thread Mark Michelson
OVN offers a method of IP address management that allows for an IPv4 subnet or IPv6 prefix to be specified on a logical switch. Then by specifying a switch port's address as "dynamic" or " dynamic", OVN will automatically assign addresses to the switch port. While this works great for initial

Re: [ovs-dev] [PATCH V2 0/4] Enable set/match of tos/ttl for IP tunnels on TC data-path

2018-08-02 Thread Simon Horman
On Wed, Aug 01, 2018 at 04:28:03PM +0300, Or Gerlitz wrote: > On Wed, Aug 1, 2018 at 2:29 PM, Simon Horman > wrote: > > Hi Or, > > > > On 1 August 2018 at 13:21, Or Gerlitz wrote: > >> > >> On Wed, Aug 1, 2018 at 2:07 PM, Simon Horman > >> wrote: > >> > On 1 August 2018 at 11:31, Simon Horman

Re: [ovs-dev] [PATCH] ovn: Fix typos in "ovn -- Address Set generation..." test.

2018-08-02 Thread Simon Horman
On Wed, Aug 01, 2018 at 11:56:09AM +0200, Simon Horman wrote: > On Tue, Jul 31, 2018 at 12:45:41PM -0700, Ben Pfaff wrote: > > These caused the test to fail. > > > > CC: Jakub Sitnicki > > Fixes: 984c7d5ea8fe ("ovn-northd: Propagate dynamic addresses to port group > > address sets.") > >

Re: [ovs-dev] [PATCH 5/5] netdev: Clean up class initialization.

2018-08-02 Thread Chandran, Sugesh
Hi Ian/Ben , Please find my comments below. Regards _Sugesh > -Original Message- > From: Stokes, Ian > Sent: Wednesday, August 1, 2018 3:24 PM > To: Ben Pfaff ; d...@openvswitch.org > Cc: Chandran, Sugesh > Subject: Re: [ovs-dev] [PATCH 5/5] netdev: Clean up class initialization. > >

[ovs-dev] 答复: [ovs-discuss] a question about ovs crash relationship with learn action

2018-08-02 Thread wangyunjian
This patch has problem. But when the cache has XC_LEARN entry,the cache can't be executed multiple times in xlate_push_stats. The ofm's match->flow in XC_LEARN entry may use-after-free. >-邮件原件- >发件人: Ben Pfaff [mailto:b...@ovn.org] >发送时间: 2018年7月11日 5:00 >收件人: wangyunjian >抄送:

[ovs-dev] [PATCH] AUTHORS: Update email address for Jakub Sitnicki.

2018-08-02 Thread Jakub Sitnicki
Signed-off-by: Jakub Sitnicki --- The j...@redhat.com address will be valid only until August 4th. AUTHORS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AUTHORS.rst b/AUTHORS.rst index 25ee39d75..f3ac8e32b 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -161,7 +161,7 @@