In current IDL index code it doesn't updated index when handling
"update2" messages, which is the default case. The consequence
is that when a row is updated, the index is not updated accordingly,
and even worse, it causes crash when calling ovsdb_idl_destroy().
It can be easily reproduced by the
> On Jul 16, 2018, at 4:39 PM, Darrell Ball wrote:
>
> void
> ct_dpif_entry_uninit(struct ct_dpif_entry *entry)
> {
> diff --git a/lib/ct-dpif.h b/lib/ct-dpif.h
> index f886ab9..2ff7e26 100644
> --- a/lib/ct-dpif.h
> +++ b/lib/ct-dpif.h
> @@ -204,6 +204,15 @@ int ct_dpif_get_nconns(struct dpif
Hi Darrell,
Thanks for the review. Will do.
Best,
Yifeng
On Fri, Aug 10, 2018 at 3:12 PM, Darrell Ball wrote:
> Thanks Yifeng
>
> Thanks for switching to use ‘packet-out’.
> Patches 4-8 seem like they can be part of the same patch, since they are
> closely related.
> As discussed, none of the
Thanks for the review. I will send a v2 patch with your suggestions.
On Tue, Aug 7, 2018 at 4:06 PM, Ben Pfaff wrote:
> On Mon, Aug 06, 2018 at 05:21:37PM -0700, Ashish Varma wrote:
> > Even though there are no runtime management commands supported by
> > ovs-testcontroller, the '--unixctl'
Thanks Yifeng
Thanks for switching to use ‘packet-out’.
Patches 4-8 seem like they can be part of the same patch, since they are
closely related.
As discussed, none of the tests pass for Userspace datapath, so maybe you want
to check them out or just disable them for now
I tested with “Linux
Greetings,
I am contacting you for an opportunity to invest in any profitable business in
your country.
We also offer a quick loan at low interest rate, please reply on my private
e-mail: hsbcpeterw...@gmail.com
Sincerely: Peter Wong
This
Hi Aaron,
Thanks for the feedback!
On Fri, Aug 10, 2018 at 12:03 PM, Aaron Conole wrote:
>
> Ben Pfaff writes:
>
> > On Thu, Aug 09, 2018 at 06:31:31PM -0400, Aaron Conole wrote:
> >> Ben Pfaff writes:
> >>
> >> > On Thu, Aug 09, 2018 at 12:40:39PM -0700, Ansis Atteka wrote:
> >> >> On Tue, 7
Acked-by: Mark Michelson
Looks like you may have fixed an existing bug or two with this series, too.
On 08/07/2018 07:37 AM, nusid...@redhat.com wrote:
From: Numan Siddique
Python IDL library is lacking the functionality to connect to the
clustered db servers by providing multiple remotes
Hello My Dear,
How are you doing today?I know that this message will come to you as a
surprise as we have never meet or seen each other before,I am
Barrister John Philips,The late Thomas Rhode retained my services
during his lifetime.I therefore write to inform you that my deceased
client, listed
This also makes a start at a testsuite for checkpatch.
CC: Aaron Conole
Signed-off-by: Ben Pfaff
---
v1->v2: Fix case where there's no committer and add test for it.
v2->v3: Fix my misconceptions about "git log" patch formatting.
tests/automake.mk | 1 +
tests/checkpatch.at | 158
I am using openvswitch in userspace.
Below are my setup:
Ubuntu 16.04.5 LTS
Openswitch-2.5.5
Namespace h1 - Host 1
Namespace h2 - Host 2
Created bridge s1 with option datapath_tye=netdev
Added ports eth1 and eth2 to the bridge
I can ping between h1 and h2. I can see the flows being installed
On Fri, Aug 10, 2018 at 03:13:18PM -0400, Aaron Conole wrote:
> Aaron Conole writes:
>
> > Ben Pfaff writes:
> >
> >> This also makes a start at a testsuite for checkpatch.
> >>
> >> CC: Aaron Conole
> >> Signed-off-by: Ben Pfaff
> >> ---
> >
> > I think it's close, but I still get this sort
On Fri, Aug 10, 2018 at 03:09:18PM -0400, Aaron Conole wrote:
> Ben Pfaff writes:
>
> > This also makes a start at a testsuite for checkpatch.
> >
> > CC: Aaron Conole
> > Signed-off-by: Ben Pfaff
> > ---
>
> I think it's close, but I still get this sort of error:
>
> 03:07:46 aconole
This also makes a start at a testsuite for checkpatch.
CC: Aaron Conole
Signed-off-by: Ben Pfaff
---
v1->v2: Fix case where there's no committer and add test for it.
tests/automake.mk | 1 +
tests/checkpatch.at | 139
Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9424#c4
Signed-off-by: Ben Pfaff
---
lib/ofp-group.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ofp-group.c b/lib/ofp-group.c
index f6e5242f5244..62cab725efb5 100644
--- a/lib/ofp-group.c
+++
Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9788
Fixes: 7333c3b1ce02 ("ofp-port: Fix buffer overread parsing Intel custom
statistics.")
Signed-off-by: Ben Pfaff
---
lib/ofp-port.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ofp-port.c
On Fri, Aug 10, 2018 at 11:02 AM, Ben Pfaff wrote:
> On Fri, Aug 10, 2018 at 01:52:43PM -0400, Mark Michelson wrote:
> > A topic that's come up from time to time for a while now is splitting OVN
> > out of the OVS source and into a separate project. Based on discussions
> in
> > recent OVN IRC
Aaron Conole writes:
> Ben Pfaff writes:
>
>> This also makes a start at a testsuite for checkpatch.
>>
>> CC: Aaron Conole
>> Signed-off-by: Ben Pfaff
>> ---
>
> I think it's close, but I still get this sort of error:
>
> 03:07:46 aconole {ipsec_selinux} ~/git/ovs$ ./utilities/checkpatch.py
Ben Pfaff writes:
> This also makes a start at a testsuite for checkpatch.
>
> CC: Aaron Conole
> Signed-off-by: Ben Pfaff
> ---
I think it's close, but I still get this sort of error:
03:07:46 aconole {ipsec_selinux} ~/git/ovs$ ./utilities/checkpatch.py -1
== Checking fa10857dafcc
Ben Pfaff writes:
> On Thu, Aug 09, 2018 at 06:31:31PM -0400, Aaron Conole wrote:
>> Ben Pfaff writes:
>>
>> > On Thu, Aug 09, 2018 at 12:40:39PM -0700, Ansis Atteka wrote:
>> >> On Tue, 7 Aug 2018 at 09:43, Qiuyu Xiao wrote:
>> >> >
>> >> > Added rules and files to create debian and rpm
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Committer None needs to sign off.
Lines checked: 268, Warnings: 0, Errors: 1
Please check
On Fri, Aug 10, 2018 at 05:52:54PM +0200, Timothy Redaelli wrote:
> On Fri, 10 Aug 2018 10:13:23 -0500
> Terry Wilson wrote:
>
> > Signed-off-by: Terry Wilson
>
> Acked-by: Timothy Redaelli
Applied to master. Does this need backporting?
___
dev
On Thu, Aug 09, 2018 at 09:16:16PM -0300, Flavio Leitner wrote:
> On Thu, Aug 09, 2018 at 11:50:38AM +0200, Timothy Redaelli wrote:
> > On Wed, 8 Aug 2018 13:49:12 -0300
> > Flavio Leitner wrote:
> >
> > > Actually, we also have dependencies in the systemd service
> > > to the network service:
>
On Fri, Aug 10, 2018 at 02:02:51PM +0200, Maxime Coquelin wrote:
>
>
> On 08/09/2018 08:01 PM, Timothy Redaelli wrote:
> >Currently, 1024-bit RSA keys are generated for OVS tests, are suggested in
> >ovn-architecture manpage examples and are used to generate the RSA keys
> >inside
> >the
On Fri, Aug 10, 2018 at 01:37:19PM +0100, Ian Stokes wrote:
> Hi Ben,
>
> The following changes since commit a4c3463d024e51a0d2089b9fba50d8d90c7c668c:
>
> ofproto-dpif-xlate: Improve log message. (2018-08-09 15:57:30 -0700)
>
> are available in the git repository at:
>
>
On Fri, Aug 10, 2018 at 01:37:42PM +0100, Ian Stokes wrote:
> Hi Ben,
>
> The following changes since commit 05ae838b2057fd2c55cdca87228f34741b046b79:
>
> netdev-dpdk: Use hex for PCI vendor ID. (2018-08-08 22:12:19 +0100)
>
> are available in the git repository at:
>
>
On Fri, Aug 10, 2018 at 01:37:52PM +0100, Ian Stokes wrote:
> Hi Ben,
>
> The following changes since commit a90ff16cad22afd4cea6dfd9f0b93f93988842cb:
>
> netdev-dpdk: Use hex for PCI vendor ID. (2018-08-08 22:12:58 +0100)
>
> are available in the git repository at:
>
>
On Fri, Aug 10, 2018 at 01:37:33PM +0100, Ian Stokes wrote:
> Hi Ben,
>
> The following changes since commit 553d3f1549385a009f703b86aa76d9896fa8da27:
>
> ofp-port: Fix buffer overread parsing Intel custom statistics. (2018-08-08
> 22:06:46 +0100)
>
> are available in the git repository at:
>
This also makes a start at a testsuite for checkpatch.
CC: Aaron Conole
Signed-off-by: Ben Pfaff
---
tests/automake.mk | 1 +
tests/checkpatch.at | 128
tests/testsuite.at | 1 +
utilities/checkpatch.py | 56
On Fri, Aug 10, 2018 at 01:52:43PM -0400, Mark Michelson wrote:
> A topic that's come up from time to time for a while now is splitting OVN
> out of the OVS source and into a separate project. Based on discussions in
> recent OVN IRC meetings, it seems like this will start actually happening
>
Hi folks,
A topic that's come up from time to time for a while now is splitting
OVN out of the OVS source and into a separate project. Based on
discussions in recent OVN IRC meetings, it seems like this will start
actually happening sometime soon.
Before starting in-depth technical
On Wed, Aug 8, 2018 at 2:12 PM, Darrell Ball wrote:
> Ben
>
> If you apply this, I have one line to delete inline.
>
> Darrell
>
> On Wed, Aug 8, 2018 at 2:09 PM, Darrell Ball wrote:
>
>> By making opt_dpif_open() more general, it can be used effectively
>> by all potential callers and avoids
By making opt_dpif_open() more general, it can be used effectively
by all potential callers and avoids trying to open potentially bogus
datapaths provided by the user. Also, the error handling is improved by
reducing bogus errors and having more specific real errors.
Signed-off-by: Darrell Ball
On Fri, 10 Aug 2018 10:13:23 -0500
Terry Wilson wrote:
> Signed-off-by: Terry Wilson
Acked-by: Timothy Redaelli
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Signed-off-by: Terry Wilson
---
python/setup.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/python/setup.py b/python/setup.py
index 0e86834..b52657d 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -63,7 +63,8 @@ setup_args = dict(
On Fri, Aug 3, 2018 at 5:43 PM, Stefano Brivio wrote:
> On Fri, 3 Aug 2018 16:01:08 -0700
> Ben Pfaff wrote:
>
> > I think that a simple mechanism for fairness is fine. The direction
> > of extensibility that makes me anxious is how to decide what matters
> > for fairness. So far, we've
Bleep bloop. Greetings Ian Stokes, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Too many signoffs; are you missing Co-authored-by lines?
Lines checked: 101, Warnings: 0,
Hi Gavi,
On 10 August 2018 at 10:30, Gavi Teitz wrote:
> Continuing work done on improving visibility of a flow's offloaded
> state via dpctl, which was begun in commit d63ca5329ff9 ("dpctl:
> Properly reflect a rule's offloaded to HW state").
>
> The first commit addresses the initialization
Hi Ben,
The following changes since commit 05ae838b2057fd2c55cdca87228f34741b046b79:
netdev-dpdk: Use hex for PCI vendor ID. (2018-08-08 22:12:19 +0100)
are available in the git repository at:
https://github.com/istokes/ovs dpdk_merge_2_8
for you to fetch changes up to
Hi Ben,
The following changes since commit a90ff16cad22afd4cea6dfd9f0b93f93988842cb:
netdev-dpdk: Use hex for PCI vendor ID. (2018-08-08 22:12:58 +0100)
are available in the git repository at:
https://github.com/istokes/ovs dpdk_merge_2_7
for you to fetch changes up to
Hi Ben,
The following changes since commit 553d3f1549385a009f703b86aa76d9896fa8da27:
ofp-port: Fix buffer overread parsing Intel custom statistics.
(2018-08-08 22:06:46 +0100)
are available in the git repository at:
https://github.com/istokes/ovs dpdk_merge_2_10
for you to fetch
Hi Ben,
The following changes since commit a4c3463d024e51a0d2089b9fba50d8d90c7c668c:
ofproto-dpif-xlate: Improve log message. (2018-08-09 15:57:30 -0700)
are available in the git repository at:
https://github.com/istokes/ovs dpdk_merge
for you to fetch changes up to
On 08/09/2018 08:01 PM, Timothy Redaelli wrote:
Currently, 1024-bit RSA keys are generated for OVS tests, are suggested in
ovn-architecture manpage examples and are used to generate the RSA keys inside
the sandbox (make sandbox), but OpenSSL documentation suggests to use at least
2048-bit
> This patch backports the commit from the latest OVS master to OVS-2.8.
>
> Configuring flow control at ixgbe netdev-init is throwing error in port
> start.
> For eg: without this fix, user cannot configure flow control on ixgbe dpdk
> port as below,
>
> "
> ovs-vsctl add-port br0 dpdk0 --
> dpdk-init is now a string. Add description of 'true' and 'try'.
>
> Fixes: 3e52fa5644cd ("dpdk: reflect status and version in the database")
> Cc: acon...@redhat.com
> Signed-off-by: Kevin Traynor
Thanks Kevin,
Will add this to today's pull request and backport to 2.10 also.
Ian
45 matches
Mail list logo
