On Mon, Dec 10, 2018 at 3:53 PM Ben Pfaff wrote:
> On Mon, Nov 26, 2018 at 08:48:37AM -0800, Darrell Ball wrote:
> > Ephemeral port fallback is being done for DNAT and the code could be hit
> in
> > some special cases and testing configurations. Also good packets are
> > expected to be
On Mon, Dec 10, 2018 at 5:22 PM Ben Pfaff wrote:
> On Mon, Dec 10, 2018 at 03:47:17PM -0800, Ben Pfaff wrote:
> > On Sun, Dec 02, 2018 at 09:17:16PM -0800, Darrell Ball wrote:
> > > Remove the exporting of the main internal conntrack datastructure.
> > > These are made static. Also stop passing
On Mon, Dec 10, 2018 at 5:50 PM Ben Pfaff wrote:
> On Mon, Nov 19, 2018 at 11:09:24AM -0800, Darrell Ball wrote:
> > Signed-off-by: Darrell Ball
>
> Please write 1ull as 1ULL because in some fonts the former is almost
> unreadable.
>
Makes sense
>
> Thanks,
>
> Ben.
>
On Mon, Dec 10, 2018 at 5:48 PM Ben Pfaff wrote:
> On Mon, Nov 19, 2018 at 11:09:21AM -0800, Darrell Ball wrote:
> > Acked-by: Justin Pettit
> > Signed-off-by: Darrell Ball
>
> Thanks for adding the documentation comment to parse_ipv6_ext_hdrs().
> Please update the documentation comment to
On Mon, Dec 10, 2018 at 5:42 PM Ben Pfaff wrote:
> On Mon, Nov 26, 2018 at 08:48:39AM -0800, Darrell Ball wrote:
> > The user should only reference a conntrack entry by the forward
> > direction context, as per 'conntrack_flush()', enforce this by
> > checking for 'default' conn_type. The
On Mon, Dec 10, 2018 at 5:39 PM Ben Pfaff wrote:
> On Mon, Nov 26, 2018 at 08:48:38AM -0800, Darrell Ball wrote:
> > When fallback to ephemeral ports triggers to find a NAT translation,
> > it may happen that the full address range is not explored; i.e. if
> > all ephemeral ports are being used
On Mon, Nov 19, 2018 at 11:09:24AM -0800, Darrell Ball wrote:
> Signed-off-by: Darrell Ball
Please write 1ull as 1ULL because in some fonts the former is almost
unreadable.
Thanks,
Ben.
___
dev mailing list
d...@openvswitch.org
On Mon, Nov 19, 2018 at 11:09:21AM -0800, Darrell Ball wrote:
> Acked-by: Justin Pettit
> Signed-off-by: Darrell Ball
Thanks for adding the documentation comment to parse_ipv6_ext_hdrs().
Please update the documentation comment to describe the return value.
I don't see anything that sets
On Mon, Dec 10, 2018 at 03:47:17PM -0800, Ben Pfaff wrote:
> On Sun, Dec 02, 2018 at 09:17:16PM -0800, Darrell Ball wrote:
> > Remove the exporting of the main internal conntrack datastructure.
> > These are made static. Also stop passing around a pointer parameter
> > to all the internal
Thanks for the feedback. Would revert back shortly with replies and few
questions followed by the v2 patch.
On Mon, Dec 10, 2018 at 1:54 PM Ben Pfaff wrote:
> On Wed, Nov 28, 2018 at 10:30:07AM -0800, Ashish Varma wrote:
> > OVS supports Nicira version of Flow Monitor feature which allows an
>
This commit adds support for DPDK v18.11, it includes the following
changes.
1. Enable compilation and linkage with dpdk 18.11.0
The following dpdk commits which were introduced after dpdk 17.11.x
require OVS updates to accommodate to the dpdk changes.
- ce17edde ("ethdev: introduce Rx
On Mon, Nov 26, 2018 at 08:48:37AM -0800, Darrell Ball wrote:
> Ephemeral port fallback is being done for DNAT and the code could be hit in
> some special cases and testing configurations. Also good packets are
> expected to be persistently dropped in this case, which is not a common
> user goal.
On Sun, Dec 02, 2018 at 09:17:16PM -0800, Darrell Ball wrote:
> Remove the exporting of the main internal conntrack datastructure.
> These are made static. Also stop passing around a pointer parameter
> to all the internal datastructures; only one or two is used
> for a given code path and these
On Mon, Dec 10, 2018 at 03:34:05PM -0800, Ben Pfaff wrote:
> Do you think you could post a v3 with Aaron's comments accounted for?
Oh, never mind, I see v3.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Do you think you could post a v3 with Aaron's comments accounted for?
Thanks,
Ben.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Nov 28, 2018 at 10:30:07AM -0800, Ashish Varma wrote:
> OVS supports Nicira version of Flow Monitor feature which allows an OpenFlow
> controller to keep track of any changes in the flow table. (The changes can
> done by the controller itself or by any other controller connected to OVS.)
>
On Thu, Nov 22, 2018 at 04:37:57PM +0100, David Marchand wrote:
> As far as RPMs are concerned, system-id.conf file is declared as being
> owned by openvswitch.
> At the first ovs startup, ovs-ctl creates this file if none exists without
> ensuring this.
>
> We end up with an inconsistency:
> $
On Tue, Dec 04, 2018 at 10:34:43AM -0200, Flavio Leitner wrote:
> On Tue, Nov 20, 2018 at 07:40:50PM +0100, Timothy Redaelli wrote:
> > Since commit bc4fd439586f ("rhel: Ship ovs shared libraries, fedora")
> > openvswitch-devel RPM package includes both static and shared library.
> > This is
On Wed, Dec 05, 2018 at 07:10:13PM +, Gregory Smith wrote:
> See RFC 2131, section 4.3.2. When handling a DHCPREQUEST message, the
> server should validate that the client's requested IP matches the
> offered IP. If not, the server should reply with a DHCPNAK. The client's
> requested IP is
On Fri, Nov 30, 2018 at 01:17:39PM +0100, Bhargava Shastry wrote:
> Hi all,
>
> oss-fuzz corpus (test inputs synthesized by the fuzzer) comprises two
> classes of inputs: crashing and non-crashing-but-new-coverage-yielding.
>
> At the moment, Open vSwitch performs regression testing using
>
The variable equivalent to RHEL's 'SYSTEMCTL_SKIP_REDIRECT=yes' on SLES
12 is 'SYSTEMD_NO_WRAP=yes'
VMware-BZ: #2245358
Signed-off-by: Martin Xu
CC: Markos Chandras
CC: Ansis Atteka
CC: Ben Pfaff
---
rhel/etc_init.d_openvswitch | 1 +
1 file changed, 1 insertion(+)
diff --git
On Wed, Dec 05, 2018 at 10:55:44AM -0800, Greg Rose wrote:
> Pull in recent Linux upstream kernel updates for openvswitch core.
>
> Travis build is here:
> https://travis-ci.org/gvrose8192/ovs-experimental/builds/463951223
It looks like this series is fully acked. Greg, would you mind
reposting
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Scott Cheloha needs to sign off.
WARNING: Unexpected sign-offs from developers who
On Wed, Dec 5, 2018 at 10:56 AM Greg Rose wrote:
>
> From: Colin Ian King
>
> Upstream commit:
> commit 43d0e96022ae3c66743c01bba6c18a3afec7b578
> Author: Colin Ian King
> Date: Tue Nov 27 14:37:17 2018 +
>
> openvswitch: fix spelling mistake "execeeds" -> "exceeds"
>
>
From: Scott Cheloha
The daemon tests used files a lot when shell variables were easier to use
and easier to understand. This commit changes that.
The tests created empty databases that aren't really needed anymore. This
commit changes them to use the ovsdb-server --no-db option instead.
The
On Thu, Dec 06, 2018 at 03:58:34PM +0200, Alin Gabriel Serdean wrote:
>
>
> > On 29 Oct 2018, at 18:25, Ben Pfaff wrote:
> >
> > The daemon tests used files a lot when shell variables were easier to use
> > and easier to understand. This commit changes that.
> >
> > The tests created empty
On 10.12.2018 20:25, Ben Pfaff wrote:
> On Fri, Dec 07, 2018 at 06:15:29PM +0300, Ilya Maximets wrote:
>>> Whoops, looks like you dropped the list. No problem. I've re-added it.
>>>
>>> Scott Cheloha writes:
>>>
On Thu, Nov 29, 2018 at 01:15:24PM -0500, Aaron Conole wrote:
> Scott
On Wed, Dec 5, 2018 at 10:56 AM Greg Rose wrote:
>
> From: YueHaibing
>
> Upstream commit:
> commit eddf11e18dff0e8671e06ce54e64cfc843303ab9
> Author: YueHaibing
> Date: Wed Sep 26 17:15:38 2018 +0800
>
> net: ovs: fix return type of ndo_start_xmit function
>
> The method
On Wed, Dec 5, 2018 at 10:56 AM Greg Rose wrote:
>
> From: Pieter Jansen van Vuuren
>
> Upstream commit:
> commit 256c87c17c53e60882a43dcf3e98f3bf859eaf6f
> Author: Pieter Jansen van Vuuren
> Date: Tue Jun 26 21:39:36 2018 -0700
>
> net: check tunnel option type in tunnel
On Wed, Dec 5, 2018 at 10:56 AM Greg Rose wrote:
>
> From: Kees Cook
>
> Upstream commit:
> commit 6396bb221514d2876fd6dc0aa2a1f240d99b37bb
> Author: Kees Cook
> Date: Tue Jun 12 14:03:40 2018 -0700
>
> treewide: kzalloc() -> kcalloc()
>
> The kzalloc() function has a
On Mon, Dec 10, 2018 at 08:05:20PM +0300, Ilya Maximets wrote:
> FreeBSD 12 supports 'pthread_rwlock_tryrdlock' without 'pthread'
> library. Let's add check for more rare function.
> OTOH, Travis-CI environment supports 'pthread_rwlockattr_destroy',
> but does not support
On Mon, Dec 10, 2018 at 08:05:21PM +0300, Ilya Maximets wrote:
> 'redzone' not supported in new versions of jemalloc
> (since jemalloc 5.0.0).
>
> Signed-off-by: Ilya Maximets
Applied to master, thanks!
___
dev mailing list
d...@openvswitch.org
On Mon, Dec 10, 2018 at 08:17:53PM +0300, Ilya Maximets wrote:
> This patch replaces most of direct accesses to the dp_packet_batch
> internal components by appropriate APIs.
>
> Signed-off-by: Ilya Maximets
I looked over this one and didn't see a problem, but, Ian, I'll leave it
to you because
Reported-by: Ilya Maximets
Signed-off-by: Ben Pfaff
---
tests/odp.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/odp.at b/tests/odp.at
index 178877dc811f..96b4b47dc45a 100644
--- a/tests/odp.at
+++ b/tests/odp.at
@@ -188,7 +188,7 @@ sed -n
Obviously this version is screwed up because I accidentally squashed two
unrelated patches. I'll post v3.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
The daemon tests used files a lot when shell variables were easier to use
and easier to understand. This commit changes that.
The tests created empty databases that aren't really needed anymore. This
commit changes them to use the ovsdb-server --no-db option instead.
The tests had a lot of
On Fri, Dec 07, 2018 at 06:15:29PM +0300, Ilya Maximets wrote:
> > Whoops, looks like you dropped the list. No problem. I've re-added it.
> >
> > Scott Cheloha writes:
> >
> >> On Thu, Nov 29, 2018 at 01:15:24PM -0500, Aaron Conole wrote:
> >>> Scott Cheloha writes:
> >>>
> >>> > On Thu,
This patch replaces most of direct accesses to the dp_packet_batch
internal components by appropriate APIs.
Signed-off-by: Ilya Maximets
---
lib/dpif.c | 2 +-
lib/netdev-bsd.c | 11 +--
lib/netdev-dummy.c | 5 ++---
lib/odp-execute.c | 2 +-
This fixes build with clang on FreeBSD:
lib/ovs-thread.c:266:13: error:
calling function 'pthread_cond_wait' requires holding mutex \
'mutex->lock' exclusively [-Werror,-Wthread-safety-analysis]
error = pthread_cond_wait(cond, >lock);
^
Fixes: 97be153858b4 ("clang:
There are no users of these functions.
This change fixes clang build on FreeBSD:
lib/ovs-thread.c:158:1: error: \
mutex 'mutex' is still held at the end of function \
[-Werror,-Wthread-safety-analysis]
XPTHREAD_FUNC1(pthread_mutex_lock, pthread_mutex_t *);
^
'redzone' not supported in new versions of jemalloc
(since jemalloc 5.0.0).
Signed-off-by: Ilya Maximets
---
tests/atlocal.in | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/atlocal.in b/tests/atlocal.in
index e186fc555..388f79ed8 100644
--- a/tests/atlocal.in
+++
FreeBSD 12 supports 'pthread_rwlock_tryrdlock' without 'pthread'
library. Let's add check for more rare function.
OTOH, Travis-CI environment supports 'pthread_rwlockattr_destroy',
but does not support 'pthread_rwlock_tryrdlock' without 'pthread'.
So, both checks needed.
Signed-off-by: Ilya
Found while trying to build on FreeBSD-12-rc3.
Ilya Maximets (4):
configure.ac: More enhanced check for pthread library.
tests: Remove redzone flag for FreeBSD 12+.
ovs-thread: Drop xpthread_meutex_{un}lock finctions.
ovs-thread: Add thread safety annotation to cond_wait.
configure.ac
I mean that the seq_wait() call should cause ovsrcu_synchronize() to
wake up immediately when it can return. If it doesn't, something is
wrong.
On Mon, Dec 10, 2018 at 07:30:09AM +, Lilijun (Jerry, Cloud Networking)
wrote:
> Hi Ben,
>
> Do you mean that there some threads in in
44 matches
Mail list logo
