DPDK 18.11 builds using the more modern meson build system no more
provide the -ldpdk linker script. Instead it is expected to use
pkgconfig for linker options as well.
This change will set DPDK_LIB from pkg-config (if pkg-config was
available) and since that already carries the whole-archive
DPDK 18.11 can be built using the more modern meson build system.
In that case it no more provides the -ldpdk linker script. Instead
it is expected to use pkgconfig for linker options as well.
FYI here a build log on Ubuntu 19.04 with the three patches applied:
CDN links are much faster in average. https://www.kernel.org/
links shows usually less than 10 MB/s, while https://cdn.kernel.org/
could give up to 200 MB/s and usually shows speeds much higher than
10 MB/s. Also, 'xz' archives are 30-50 MB smaller than gzip ones.
It takes a bit more time to
> > Currently OVS supports all ARP protocol fields as OXM match fields to
> > implement the relevant ARP procedures for IPv4. This includes support
> > for matching copying and setting ARP fields. In IPv6 ARP has been
> > replaced by ICMPv6 neighbor discovery (ND) procedures, neighbor
> >
Thanks Vishal
Yes, it needs to go back to 2.6; I will be doing some backport patches soon.
Darrell
On 2/1/19, 8:57 PM, "ovs-dev-boun...@openvswitch.org on behalf of Vishal Deep
Ajmera" wrote:
>
> 'conn_key_extract()' in userspace conntrack is including L2
> (Ethernet) pad bytes
> On Oct 29, 2018, at 3:57 PM, Ben Pfaff wrote:
>
> Until now, connmgr has handled active and passive OpenFlow connections in
> quite different ways. Any active connection, whether it was currently
> connected or not, was always maintained as an ofconn. Whenever such a
> connection
> On Jan 17, 2019, at 4:20 PM, Ben Pfaff wrote:
>
> ONF abandoned the OpenFlow specification, so that OpenFlow 1.6 will never
> be completed. It did not contain much in the way of useful features, so
> remove what support Open vSwitch already had.
>
> Signed-off-by: Ben Pfaff
Acked-by:
Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
fatal: sha1 information is lacking or useless (lib/conntrack.c).
Repository lacks necessary blobs
On Tue, Jan 29, 2019 at 04:09:55PM +0300, Ilya Maximets wrote:
> Current version of 'skiplist_delete' uses data comparator to check
> if the node that we're removing exists on current level. i.e. our
> node 'x' is the next of update[i] on the level i.
> But it's enough to just check pointers for
'conn_key_extract()' in userspace conntrack is including L2
(Ethernet) pad bytes for both L3 and L4 sizes. One problem is
any packet with non-zero L2 padding can incorrectly fail L4
checksum validation.
This patch fixes conn_key_extract() by ignoring L2 pad bytes.
Fixes: a489b16854b5
The new api will be used in a subsequent patch.
Signed-off-by: Darrell Ball
---
v4: Added function header comments to the new and existing APIs (Ben).
v2: Added patch to series.
lib/dp-packet.h | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/lib/dp-packet.h
On Tue, Jan 29, 2019 at 02:18:24PM +0300, Ilya Maximets wrote:
> On 28.01.2019 20:48, Ilya Maximets wrote:
> > On 25.01.2019 23:22, Ben Pfaff wrote:
> >> This member was write-only: it was initialized and never used later on.
> >>
> >> Thanks to Esteban Rodriguez Betancourt for the
> >> following
On Wed, Jan 30, 2019 at 05:10:38PM +0300, Ilya Maximets wrote:
> On 28.01.2019 8:49, Li RongQing wrote:
> > state_s should be freed always before exit parse_ct_state
> >
>
> Fixes: b4293a336d8d ("conntrack: Move ct_state parsing to lib/flow.c")
>
> > Signed-off-by: Li RongQing
>
> LGTM,
>
On Mon, Feb 04, 2019 at 04:02:15PM -0800, Darrell Ball wrote:
> There are a few cases where struct 'conn_key' padding may be unspecified
> according to the C standard. Practically, it seems implementations don't
> have issue, but it is better to be safe. The code paths modified are not
> hot
On Mon, Feb 04, 2019 at 03:34:34PM -0800, Ashish Varma wrote:
> Added the check for NULL in "next_ct_states" argument passed to the
> "ofproto_trace()" function. Under normal scenario, this is non-NULL. A NULL
> "next_ct_states" argument is passed from the "upcall_xlate()" function on
>
There are a few cases where struct 'conn_key' padding may be unspecified
according to the C standard. Practically, it seems implementations don't
have issue, but it is better to be safe. The code paths modified are not
hot ones. Fix this by doing a memcpy in these cases in lieu of a
structure
On Fri, Feb 01, 2019 at 04:23:07AM +, Lilijun (Jerry, Cloud Networking)
wrote:
> Currently, when insert/delete/lookup the shash list struct ofproto‘s
> port_by_name, we have no lock to protect this list. This list was used lots
> of other functions.
>
> Is there something race issues?
Thanks for the fix. I am wondering if we can output some useful information
in 'struct ds' for this case?
On Mon, Feb 4, 2019 at 3:45 PM Ashish Varma
wrote:
> Added the check for NULL in "next_ct_states" argument passed to the
> "ofproto_trace()" function. Under normal scenario, this is
On Thu, Jan 31, 2019 at 03:49:39PM -0800, Ashish Varma wrote:
> OVS supports Nicira version of Flow Monitor feature which allows an OpenFlow
> controller to keep track of any changes in the flow table. (The changes can
> done by the controller itself or by any other controller connected to OVS.)
>
Added the check for NULL in "next_ct_states" argument passed to the
"ofproto_trace()" function. Under normal scenario, this is non-NULL. A NULL
"next_ct_states" argument is passed from the "upcall_xlate()" function on
encountering XLATE_RECURSION_TOO_DEEP or XLATE_TOO_MANY_RESUBMITS error.
Thanks Ben!!
On 2/4/2019 1:49 PM, Ben Pfaff wrote:
I applied this series to master and backported as far as branch-2.6.
(It did not apply cleanly to branch-2.5.)
___
dev mailing list
d...@openvswitch.org
Doesn't apply cleanly. Would you mind manually backporting and posting
the patch?
On Fri, Feb 01, 2019 at 11:59:37AM +0100, Daniel Alvarez Sanchez wrote:
> We have hit this issue as well on 2.9, would it be possible to backport it?
>
> On Mon, Oct 8, 2018 at 7:17 PM Ben Pfaff wrote:
> >
> > On
Done.
On Mon, Feb 04, 2019 at 01:40:33PM -0800, Yifeng Sun wrote:
> Thanks Ben, please backport to 2.11 if possible.
>
> On Mon, Feb 4, 2019 at 1:36 PM Ben Pfaff wrote:
>
> > On Fri, Feb 01, 2019 at 11:11:45AM -0800, Yi-Hung Wei wrote:
> > > On Fri, Feb 1, 2019 at 10:02 AM Yifeng Sun
> >
I applied this series to master and backported as far as branch-2.6.
(It did not apply cleanly to branch-2.5.)
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Thanks Yifeng (and Greg). I applied this to master and branch-2.11.
On Tue, Jan 29, 2019 at 04:53:37PM -0800, Yifeng Sun wrote:
> Thanks Greg for reviewing, I ran the tests locally and there is no issue.
>
> Ben, could you backport this patch to 2.11 if you can? thanks!
>
> Yifeng
>
> On Tue,
On Thu, Jan 31, 2019 at 03:10:00PM -0800, Yifeng Sun wrote:
> Kmod tests 122 and 123 failed and kernel reports a "Duplicate key of
> type 6" error. Further debugging reveals that nl_attr_find__() should
> start looking for OVS_KEY_ATTR_ETHERTYPE from offset returned by
> a previous called
Thanks Ben, please backport to 2.11 if possible.
On Mon, Feb 4, 2019 at 1:36 PM Ben Pfaff wrote:
> On Fri, Feb 01, 2019 at 11:11:45AM -0800, Yi-Hung Wei wrote:
> > On Fri, Feb 1, 2019 at 10:02 AM Yifeng Sun
> wrote:
> > >
> > > Test "flow resume with geneve tun_metadata" failed because there
On Fri, Feb 01, 2019 at 11:11:45AM -0800, Yi-Hung Wei wrote:
> On Fri, Feb 1, 2019 at 10:02 AM Yifeng Sun wrote:
> >
> > Test "flow resume with geneve tun_metadata" failed because there is
> > no controller running to handle the continuation message. A previous
> > commit deleted the line that
On Mon, Jan 28, 2019 at 11:41:06AM +, Vishal Deep Ajmera wrote:
> Currently OVS supports all ARP protocol fields as OXM match fields to
> implement the relevant ARP procedures for IPv4. This includes support
> for matching copying and setting ARP fields. In IPv6 ARP has been
> replaced by
On Fri, Feb 01, 2019 at 03:56:04PM -0800, Yifeng Sun wrote:
> `encap = nl_msg_start_nested(key, OVS_KEY_ATTR_ENCAP)` ensures that
> key->size >= (encap + NLA_HDRLEN), so the `if` statement is safe.
>
> Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11306
> Signed-off-by:
On Fri, Feb 01, 2019 at 04:44:26PM -0800, Yifeng Sun wrote:
> Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12557
> Signed-off-by: Yifeng Sun
I'm not enthusiastic about the CONST_CASTs here, but it solves the
problem and I don't expect them to cause a real problem of their
On 2/4/19, 12:24 PM, "Ben Pfaff" wrote:
On Mon, Feb 04, 2019 at 07:52:18PM +, Darrell Ball wrote:
>
>
> On 2/4/19, 11:15 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben
Pfaff" wrote:
>
> On Sun, Feb 03, 2019 at 02:15:27PM -0800, Darrell Ball wrote:
On Mon, Feb 04, 2019 at 11:50:22AM -0500, Aaron Conole wrote:
> Hyong Youb Kim via dev writes:
>
> > From: Hyong Youb Kim
> >
> > Run ovs-tcpdump without --span, and it throws the following
> > exception. Define mirror_select_all to avoid the error.
> >
> > Traceback (most recent call last):
>
On Mon, Feb 04, 2019 at 07:52:18PM +, Darrell Ball wrote:
>
>
> On 2/4/19, 11:15 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben
> Pfaff" wrote:
>
> On Sun, Feb 03, 2019 at 02:15:27PM -0800, Darrell Ball wrote:
> > There are a few cases where padding may be undefined
On Wed, Jan 30, 2019 at 11:08:32AM +0100, Christian Ehrhardt wrote:
> Include the locally provided pkg.m4 before calling the
> PKG_PROG_PKG_CONFIG macro.
>
> Signed-off-by: Christian Ehrhardt
> ---
> configure.ac | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configure.ac
From: Gregory Rose
Date: Mon, 4 Feb 2019 11:41:29 -0800
>
> On 2/3/2019 1:12 AM, Eli Britstein wrote:
>> Declare ovs key structures using macros as a pre-step towards to
>> enable retrieving fields information, as a work done in proposed
>> commit in the OVS tree
From: Yi-Hung Wei
Date: Mon, 4 Feb 2019 10:47:18 -0800
> For example, to see how 'struct ovs_key_ipv6' is defined, now we need
> to trace how OVS_KEY_IPV6_FIELDS is defined, and how OVS_KEY_FIELD_ARR
> and OVS_KEY_FIELD defined. I think it makes the header file to be
> more complicated.
I
> DPDK 18.11 builds using the more modern meson build system no more provide
> the -ldpdk linker script. Instead it is expected to use pkgconfig for
> linker options as well.
>
> This change will set DPDK_LIB from pkg-config (if pkg-config was
> available) and since that already carries the
On 2/4/19, 11:23 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff"
wrote:
On Mon, Jan 28, 2019 at 10:49:03AM -0800, Darrell Ball wrote:
> The new api will be used in a subsequent patch.
>
> Signed-off-by: Darrell Ball
I think that this could use some
On 2/4/19, 11:15 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff"
wrote:
On Sun, Feb 03, 2019 at 02:15:27PM -0800, Darrell Ball wrote:
> There are a few cases where padding may be undefined according to
> the C standard. Practically, it seems implementations don't
IMPRENTA DE MARKETING AL MÁS BAJO COSTO
( https://www.fineart.com.ar/cuadernos-promo/ )
CUADERNOS PERSONALIZADOS
* Tus acciones de MKT mucho más duraderas.
* 100% de usabilidad de tus clientes.
* Publicitá tu empresa todos los días del año.
* Amplio retorno de la
On 2/3/2019 1:12 AM, Eli Britstein wrote:
Declare ovs key structures using macros as a pre-step towards to
enable retrieving fields information, as a work done in proposed
commit in the OVS tree https://patchwork.ozlabs.org/patch/1023406/
("odp-util: Do not rewrite fields with the same values
On Sat, Feb 02, 2019 at 12:27:51AM +0530, nusid...@redhat.com wrote:
> From: Yi-Hung Wei
>
> The patch address vswitchd crash when it receives NXT_RESUME with geneve
> tunnel metadata. The crash is due to segmentation fault with the
> following stack trace, and it is observed only in kernel
On Mon, Feb 04, 2019 at 10:20:31PM +0530, nusid...@redhat.com wrote:
> From: Numan Siddique
>
> On a chassis when ovs-vswitchd crashes for some reason, the BFD status doesn't
> get updated in the ovs db. ovn-controller will be reading the old BFD status
> even though ovs-vswitchd is crashed.
On Tue, Jan 29, 2019 at 04:00:46PM +0200, Eli Britstein wrote:
> DPDK 18.11 uses libverbs and libmlx5 when MLX5 PMD is enabled.
>
> This commit makes OVS to link to libverbs and libmlx5 when MLX5 PMD is
> enabled on DPDK.
>
> Signed-off-by: Eli Britstein
> Reviewed-by: Shahaf Shuler
>
On Mon, Jan 28, 2019 at 10:49:03AM -0800, Darrell Ball wrote:
> The new api will be used in a subsequent patch.
>
> Signed-off-by: Darrell Ball
I think that this could use some comments on the functions, because "L3
size" (and L4 size) is ambiguous: does it refer to the size of the L3
header,
On Sun, Feb 03, 2019 at 02:15:27PM -0800, Darrell Ball wrote:
> There are a few cases where padding may be undefined according to
> the C standard. Practically, it seems implementations don't have issue,
> but it is better to be safe. The code paths modified are not hot ones.
>
> Found by
On Sun, Feb 3, 2019 at 1:13 AM Eli Britstein wrote:
>
> Declare ovs key structures using macros as a pre-step towards to
> enable retrieving fields information, as a work done in proposed
> commit in the OVS tree https://patchwork.ozlabs.org/patch/1023406/
> ("odp-util: Do not rewrite fields with
Cursos esenciales - Webinar Interactivo – Jueves 21 de Febrero
Recuperación de cartera vencida
Este webinar interactivo está diseñado para brindar a las empresas estrategias
y técnicas para desarrollar mejores procedimientos
de recuperación de cartera dentro del marco legar pertinente y en una
> There are two reasons:
> 1. OVS provides same default itself.
> 2. socket-mem is not necessary with dynamic memory model in DPDK 18.11.
>
> Signed-off-by: Ilya Maximets
Thanks Ilya, pushed to master and 2.11.
Ian
___
dev mailing list
On 2/4/19, 8:53 AM, "ovs-dev-boun...@openvswitch.org on behalf of Aaron
Conole" wrote:
Darrell Ball writes:
> There are a few cases where padding may be undefined according to
> the C standard. Practically, it seems implementations don't have issue,
> but it is better
On Thu, Jan 31, 2019 at 11:35:41PM -0800, Darrell Ball wrote:
> The call to inet_ntop() in repl_ftp_v6_addr() is 1 short to handle
> the maximum possible V6 address size for v4 mapping case.
>
> Found by inspection.
>
> Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.")
>
Darrell Ball writes:
> There are a few cases where padding may be undefined according to
> the C standard. Practically, it seems implementations don't have issue,
> but it is better to be safe. The code paths modified are not hot ones.
>
> Found by inspection.
>
> Signed-off-by: Darrell Ball
>
From: Numan Siddique
On a chassis when ovs-vswitchd crashes for some reason, the BFD status doesn't
get updated in the ovs db. ovn-controller will be reading the old BFD status
even though ovs-vswitchd is crashed. This results in the chassiredirect port
claim flapping between the master chassis
Hyong Youb Kim via dev writes:
> From: Hyong Youb Kim
>
> Run ovs-tcpdump without --span, and it throws the following
> exception. Define mirror_select_all to avoid the error.
>
> Traceback (most recent call last):
> File "/usr/local/bin/ovs-tcpdump", line 488, in
> main()
> File
Darrell Ball writes:
> There are a few cases where padding may be undefined according to
> the C standard. Practically, it seems implementations don't have issue,
> but it is better to be safe. The code paths modified are not hot ones.
> Found by inspection.
Better to be safe how? What do
Need to retouch your photos? Deep etching or masking for your photos?
We are the studio who can do those service for your photos.
Please send photos to start
Thanks,
Stacy
Ingolsdtadt
Nettetal
___
dev mailing list
In netdev_dpdk_add_rte_flow_offload function different rte_flow_item are
created as part of the pattern matching.
For most of them, there is a check whether the wildcards are not zero.
In case of zero, nothing is being done with the rte_flow_item.
Befor the wildcard check, and regardless of the
On 04.02.2019 18:50, Asaf Penso wrote:
>
>
> Regards,
> Asaf Penso
>
>> -Original Message-
>> From: Ilya Maximets
>> Sent: Monday, February 4, 2019 5:41 PM
>> To: Asaf Penso ; ovs-dev@openvswitch.org
>> Cc: Roni Bar Yanai ; Stokes, Ian
>>
>> Subject: Re: [ovs-dev] netdev-dpdk: Memset
Cursos escenciales - Webinar Interactivo – Viernes 22 de Febrero
Bases de datos y tablas dinámicas en Excel
Nuestro curso está diseñado para enseñarte a importar o construir bases de
datos correctamente estructuradas para la creación
de tablas dinámicas y todas las herramientas que la
Regards,
Asaf Penso
> -Original Message-
> From: Ilya Maximets
> Sent: Monday, February 4, 2019 5:41 PM
> To: Asaf Penso ; ovs-dev@openvswitch.org
> Cc: Roni Bar Yanai ; Stokes, Ian
>
> Subject: Re: [ovs-dev] netdev-dpdk: Memset rte_flow_item on a need basis.
>
> On 04.02.2019
On 04.02.2019 18:08, Asaf Penso wrote:
>
>
> Regards,
> Asaf Penso
>
>> -Original Message-
>> From: Ilya Maximets
>> Sent: Monday, February 4, 2019 4:14 PM
>> To: Asaf Penso ; ovs-dev@openvswitch.org
>> Cc: Roni Bar Yanai ; Stokes, Ian
>>
>> Subject: Re: [ovs-dev] netdev-dpdk: Memset
Acked-by: Mark Michelson
On 2/4/19 5:31 AM, nusid...@redhat.com wrote:
From: Numan Siddique
On a chassis when ovs-vswitchd crashes for some reason, the BFD status doesn't
get updated in the ovs db. ovn-controller will be reading the old BFD status
even though ovs-vswitchd is crashed. This
Regards,
Asaf Penso
> -Original Message-
> From: Ilya Maximets
> Sent: Monday, February 4, 2019 4:14 PM
> To: Asaf Penso ; ovs-dev@openvswitch.org
> Cc: Roni Bar Yanai ; Stokes, Ian
>
> Subject: Re: [ovs-dev] netdev-dpdk: Memset rte_flow_item on a need basis.
>
> On 04.02.2019
On 04.02.2019 15:50, Asaf Penso wrote:
> In netdev_dpdk_add_rte_flow_offload function different rte_flow_item are
> created as part of the pattern matching.
>
> For most of them, there is a check whether the wildcards are not zero.
> In case of zero, nothing is being done with the rte_flow_item.
On Mon, Feb 4, 2019 at 6:52 PM Ilya Maximets wrote:
> On 04.02.2019 13:39, nusid...@redhat.com wrote:
> > From: Numan Siddique
> >
> > On a chassis when ovs-vswitchd crashes for some reason, the BFD status
> doesn't
> > get updated in the ovs db. ovn-controller will be reading the old BFD
>
Any thoughts on this?
Best regards, Ilya Maximets.
On 12.11.2018 12:28, Ilya Maximets wrote:
> * Dropped 'is_all_zero' function, which is equal to 'is_all_zeros'
> from util.h .
> * util.h added to includes. Includes re-sorted within their blocks.
> (it's hard to figure out where to put new
On Mon, Feb 4, 2019 at 11:00 AM Simon Horman wrote:
>
>
>
> On Sun, 3 Feb 2019 at 12:03, Roi Dayan wrote:
>>
>> On Fri, Feb 1, 2019 at 4:05 PM Simon Horman
>> wrote:
>> >
>> > Thanks Roi,
>> >
>> > On Thu, 31 Jan 2019 at 15:52, Roi Dayan wrote:
>> >
>> > >
>> > >
>> > > On 31/01/2019 15:32,
On 04.02.2019 13:39, nusid...@redhat.com wrote:
> From: Numan Siddique
>
> On a chassis when ovs-vswitchd crashes for some reason, the BFD status doesn't
> get updated in the ovs db. ovn-controller will be reading the old BFD status
> even though ovs-vswitchd is crashed. This results in the
In netdev_dpdk_add_rte_flow_offload function different rte_flow_item are
created as part of the pattern matching.
For most of them, there is a check whether the wildcards are not zero.
In case of zero, nothing is being done with the rte_flow_item.
Befor the wildcard check, and regardless of the
From: Numan Siddique
On a chassis when ovs-vswitchd crashes for some reason, the BFD status doesn't
get updated in the ovs db. ovn-controller will be reading the old BFD status
even though ovs-vswitchd is crashed. This results in the chassiredirect port
claim flapping between the master chassis
From: Numan Siddique
On a chassis when ovs-vswitchd crashes for some reason, the BFD status doesn't
get updated in the ovs db. ovn-controller will be reading the old BFD status
even though ovs-vswitchd is crashed. This results in the chassiredirect port
claim flapping between the master chassis
On Sun, 3 Feb 2019 at 12:03, Roi Dayan wrote:
> On Fri, Feb 1, 2019 at 4:05 PM Simon Horman
> wrote:
> >
> > Thanks Roi,
> >
> > On Thu, 31 Jan 2019 at 15:52, Roi Dayan wrote:
> >
> > >
> > >
> > > On 31/01/2019 15:32, Roi Dayan wrote:
> > > >
> > > > On 31/01/2019 11:58, Simon Horman wrote:
>
73 matches
Mail list logo
