Re: [ovs-dev] [PATCH v3 9/9] ofproto-dpif-xlate: Translate timeout policy in ct action

2019-08-13 Thread Darrell Ball
On Tue, Aug 13, 2019 at 8:03 PM Darrell Ball wrote: > Thanks for the patch > > few more comments > > On Mon, Aug 12, 2019 at 5:57 PM Yi-Hung Wei wrote: > >> This patch derives the timeout policy based on ct zone from the >> internal data structure that we maintain on dpif layer. >> >> It also

Re: [ovs-dev] [PATCH v3 9/9] ofproto-dpif-xlate: Translate timeout policy in ct action

2019-08-13 Thread Darrell Ball
Thanks for the patch few more comments On Mon, Aug 12, 2019 at 5:57 PM Yi-Hung Wei wrote: > This patch derives the timeout policy based on ct zone from the > internal data structure that we maintain on dpif layer. > > It also adds a system traffic test to verify the zone-based conntrack >

Re: [ovs-dev] [PATCH v3 6/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-08-13 Thread Darrell Ball
Thanks for the patch Some high level comments: 1/ The ct_tp_kill_list code is still in common code I think we discussed moving that to the dpif backer code ct_timeout_policy_unref() is adding to this deferred kill list which is not needed for userspace datapath. 2/

Re: [ovs-dev] [PATCH 2/4] ovsdb-idl.c: Allows retry even when using a single remote.

2019-08-13 Thread aginwala
On Tue, Aug 13, 2019 at 7:07 PM aginwala wrote: > Thanks for the fixes. Found a bug in current code which breaks both nbctl > with local socket and daemon mode on follower nodes. Also nbctl daemon mode > always tries to connect to leader node by default which also failed to > connect. > e.g.

Re: [ovs-dev] [PATCH v4 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-13 Thread 0-day Robot
Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./ovs/include -I ./ovs/include -I ./ovs/lib

[ovs-dev] [PATCH v4 4/4 ovn] OVN: Vlan backed DVR N-S, redirect packet via localnet port

2019-08-13 Thread Ankur Sharma
Background: With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added support for E-W workflow for vlan backed DVRs. This series enables N-S workflow for vlan backed DVRs. Key difference between E-W and N-S traffic flow is that N-S flow requires a gateway chassis. A gateway chassis will be

[ovs-dev] [PATCH v4 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-13 Thread Ankur Sharma
With 795d7f24ce0e2ed5454e193a059451d237289542 we have added support for E-W routing on vlan backed networks by replacing router port macs with chassis macs. This replacement of router port mac need NOT be done on gateway chassis for following reasons: a. For N-S traffic, gateway chassis will

[ovs-dev] [PATCH v4 0/4 ovn] OVN: Vlan backed DVR, enable N-S packet flow

2019-08-13 Thread Ankur Sharma
Problem Description: Redirection to chassisredirect ports happens only via tunnel encapsulation. As a result, same cannot be leveraged upon for vlan backed environments. This series addresses the issue by allowing redirection to happen without encapsulation. Design: === a. High level design

[ovs-dev] [PATCH v4 2/4 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-13 Thread Ankur Sharma
Background: With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added support for E-W workflow for vlan backed DVRs. This series enables N-S workflow for vlan backed DVRs. Key difference between E-W and N-S traffic flow is that N-S flow requires a gateway chassis. A gateway chassis will be

[ovs-dev] [PATCH v4 3/4 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-13 Thread Ankur Sharma
Background: With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added support for E-W workflow for vlan backed DVRs. This series enables N-S workflow for vlan backed DVRs. Key difference between E-W and N-S traffic flow is that N-S flow requires a gateway chassis. A gateway chassis will be

Re: [ovs-dev] [PATCH v3 9/9] ofproto-dpif-xlate: Translate timeout policy in ct action

2019-08-13 Thread Darrell Ball
On Tue, Aug 13, 2019 at 2:33 PM Yi-Hung Wei wrote: > On Tue, Aug 13, 2019 at 11:43 AM Darrell Ball wrote: > > Sure, circling back to this part > > > > yep, it is the Linux In-tree kernel module rather than OVS tree module > > > > dball@ubuntu:~/ovs$ modinfo openvswitch > > filename: >

Re: [ovs-dev] [PATCH v3 9/9] ofproto-dpif-xlate: Translate timeout policy in ct action

2019-08-13 Thread Yi-Hung Wei
On Tue, Aug 13, 2019 at 2:33 PM Yi-Hung Wei wrote: > > On Tue, Aug 13, 2019 at 11:43 AM Darrell Ball wrote: > > btw, similarly > > make 'check-kernel' fails for the same reasons. > > > > Ostensibly, I would have expected 5.0 to be ok. > > I can dig more on this part later if you wish. > > The ct

Re: [ovs-dev] [PATCH v3 9/9] ofproto-dpif-xlate: Translate timeout policy in ct action

2019-08-13 Thread Yi-Hung Wei
On Tue, Aug 13, 2019 at 11:43 AM Darrell Ball wrote: > Sure, circling back to this part > > yep, it is the Linux In-tree kernel module rather than OVS tree module > > dball@ubuntu:~/ovs$ modinfo openvswitch > filename: >

Re: [ovs-dev] [PATCH v3 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-13 Thread Yi-Hung Wei
On Tue, Aug 13, 2019 at 4:25 AM wrote: > > --- > > Documentation/faq/releases.rst | 3 +- > > datapath-windows/include/OvsDpInterfaceCtExt.h | 114 + > > datapath-windows/ovsext/Netlink/NetlinkProto.h | 8 +- > > include/windows/automake.mk

Re: [ovs-dev] [PATCH v3] datapath: compat: Backports bugfixes for nf_conncount

2019-08-13 Thread Yi-Hung Wei
On Wed, Aug 7, 2019 at 3:25 PM Yifeng Sun wrote: > > This patch backports several critical bug fixes related to > locking and data consistency in nf_conncount code. > > This backport is based on the following upstream net-next upstream commits. > a007232 ("netfilter: nf_conncount: fix argument

[ovs-dev] (no subject)

2019-08-13 Thread Mr Azim
-- Hallo, Ich bin Azim Hashim Premji, ein indischer Wirtschaftsmagnat, Investor und Philanthrop. Ich bin der Vorsitzende von Wipro Limited. Ich gab 25 Prozent meines persönlichen Vermögens für wohltätige Zwecke ab. Und ich habe auch versprochen, den Rest von 25% dieses Jahr 2018 an

Re: [ovs-dev] [PATCH 4/4] raft.c: Stale leader should disconnect from cluster.

2019-08-13 Thread Han Zhou
On Tue, Aug 13, 2019 at 9:23 AM Han Zhou wrote: > > From: Han Zhou > > As mentioned in RAFT paper, section 6.2: > > Leaders: A server might be in the leader state, but if it isn’t the current > leader, it could be needlessly delaying client requests. For example, suppose a > leader is

Re: [ovs-dev] [PATCH v3 9/9] ofproto-dpif-xlate: Translate timeout policy in ct action

2019-08-13 Thread Darrell Ball
On Tue, Aug 13, 2019 at 11:01 AM Yi-Hung Wei wrote: > On Mon, Aug 12, 2019 at 7:35 PM Darrell Ball wrote: > > > > Thanks for the patch > > > > Not a full review; I just did a quick run of the test using a more > recent kernel version > > > > dball@ubuntu:~/ovs$ uname -r > > 5.0.0-23-generic > >

Re: [ovs-dev] [PATCH v3 9/9] ofproto-dpif-xlate: Translate timeout policy in ct action

2019-08-13 Thread Yi-Hung Wei
On Mon, Aug 12, 2019 at 7:35 PM Darrell Ball wrote: > > Thanks for the patch > > Not a full review; I just did a quick run of the test using a more recent > kernel version > > dball@ubuntu:~/ovs$ uname -r > 5.0.0-23-generic > dball@ubuntu:~/ovs$ lsb_release -a > No LSB modules are available. >

Re: [ovs-dev] [PATCH ovn 3/4] Fix "make rpm-fedora"

2019-08-13 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 108 characters long (recommended limit is 79) #270 FILE:

Re: [ovs-dev] [PATCH ovn 2/4] Build OVN using external OVS directory

2019-08-13 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #141 FILE:

Re: [ovs-dev] [PATCH ovn 1/4] Add support for using OVN specific rundirs

2019-08-13 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 99 characters long (recommended limit is 79) #650 FILE:

Re: [ovs-dev] [PATCH] dpif-netdev: Add core id in the PMD thread name.

2019-08-13 Thread Eelco Chaudron
On 13 Aug 2019, at 18:37, Ilya Maximets wrote: This is highly useful to see on which core PMD is running by only looking at the thread name. Thread Id still allows to distinguish different threads running on the same core over the time: |dpif_netdev(pmd-c10/id:53)|DBG|Creating 2.

Re: [ovs-dev] [PATCH] tnl-neigh: Use outgoing ofproto version.

2019-08-13 Thread Flavio Leitner via dev
On Tue, Aug 13, 2019 at 01:34:04PM -0300, Flavio Leitner via dev wrote: > When a packet needs to be encapsulated in userspace, the endpoint > address needs to be resolved to fill in the headers. If it is not, > then currently OvS sends either a Neighbor Solicitation (IPv6) > or an ARP Query (IPv4)

[ovs-dev] [PATCH] dpif-netdev: Add core id in the PMD thread name.

2019-08-13 Thread Ilya Maximets
This is highly useful to see on which core PMD is running by only looking at the thread name. Thread Id still allows to distinguish different threads running on the same core over the time: |dpif_netdev(pmd-c10/id:53)|DBG|Creating 2. subtable <...> |dpif_netdev(pmd-c10/id:53)|DBG|flow_add:

[ovs-dev] [PATCH] tnl-neigh: Use outgoing ofproto version.

2019-08-13 Thread Flavio Leitner via dev
When a packet needs to be encapsulated in userspace, the endpoint address needs to be resolved to fill in the headers. If it is not, then currently OvS sends either a Neighbor Solicitation (IPv6) or an ARP Query (IPv4) to resolve it. The problem is that the NS/ARP packet will go through the flow

[ovs-dev] [PATCH ovn 4/4] rhel: Run ovn services with the 'openvswitch' user

2019-08-13 Thread nusiddiq
From: Numan Siddique This patch could have created a new user 'ovn' for ovn services instead of using 'openvswitch' user. But this would require some amount of work and proper testing since the new user 'ovn' should be part of 'openvswitch' group (to access /var/run/openvswitch/db.sock.). If ovs

[ovs-dev] [PATCH ovn 3/4] Fix "make rpm-fedora"

2019-08-13 Thread nusiddiq
From: Numan Siddique "make rpm-fedora" is broken and this patch fixes it. Previous patch in this series supported building OVN from external OVS sources. Before running "make rpm-fedora", it is expected that the developer has run "make dist" in the OVS source folder to generate the

[ovs-dev] [PATCH ovn 2/4] Build OVN using external OVS directory

2019-08-13 Thread nusiddiq
From: Numan Siddique With this patch we have to configure OVN to refer to external OVS source/build directory instead of the ovs subtree. The new configuration options added are: * --with-ovs-source=/path/to/ovs/source/dir * --with-ovs-build=/path/to/ovs/build/dir Before configuring OVN,

[ovs-dev] [PATCH ovn 1/4] Add support for using OVN specific rundirs

2019-08-13 Thread nusiddiq
From: Numan Siddique Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). The commit [1] changed the package name from openvswitch to ovn, but it didn't take into the account the effects of it. When "make install" is run ovn-ctl utility is copied to /usr/local/share/ovn/scripts

[ovs-dev] [PATCH ovn 0/4] External OVS source support and separate run dir for OVN

2019-08-13 Thread nusiddiq
From: Numan Siddique This patch series adds support for building OVN from external OVS sources. The first patch adds support to run OVN services using separate directores - Default run time dir - /usr/local/var/run/ovm - Default log dir - /usr/loca/var/log/ovn - Default db dir -

[ovs-dev] [PATCH 4/4] raft.c: Stale leader should disconnect from cluster.

2019-08-13 Thread Han Zhou
From: Han Zhou As mentioned in RAFT paper, section 6.2: Leaders: A server might be in the leader state, but if it isn’t the current leader, it could be needlessly delaying client requests. For example, suppose a leader is partitioned from the rest of the cluster, but it can still communicate

[ovs-dev] [PATCH 3/4] raft.c: Set candidate_retrying if no leader elected since last election.

2019-08-13 Thread Han Zhou
From: Han Zhou candiate_retrying is used to determine if the current node is disconnected from the cluster when the node is in candiate role. However, a node can flap between candidate and follower role before a leader is elected when majority of the cluster is down, so is_connected() will flap,

[ovs-dev] [PATCH 2/4] ovsdb-idl.c: Allows retry even when using a single remote.

2019-08-13 Thread Han Zhou
From: Han Zhou When clustered mode is used, the client needs to retry connecting to new servers when certain failures happen. Today it is allowed to retry new connection only if multiple remotes are used, which prevents using LB VIP with clustered nodes. This patch makes sure the retry logic

[ovs-dev] [PATCH 1/4] raft.c: Move raft_reset_ping_timer() out of the loop.

2019-08-13 Thread Han Zhou
From: Han Zhou Fixes: commit 5a9b53a5 ("ovsdb raft: Fix duplicated transaction execution when leader failover.") Signed-off-by: Han Zhou --- ovsdb/raft.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovsdb/raft.c b/ovsdb/raft.c index c60ef41..1c38b3b 100644 ---

[ovs-dev] [PATCH 3/3] dpdk: Use ovs-numa provided functions to manage thread affinity.

2019-08-13 Thread Ilya Maximets
This allows to decrease code duplication and avoid using Linux-specific functions (this might be useful in the future if we'll try to allow running OvS+DPDK on FreeBSD). Signed-off-by: Ilya Maximets --- lib/dpdk.c | 27 --- 1 file changed, 12 insertions(+), 15

[ovs-dev] [PATCH 2/3] dpif-netdev-perf: Fix TSC frequency for non-DPDK case.

2019-08-13 Thread Ilya Maximets
Unlike 'rte_get_tsc_cycles()' which doesn't need any specific initialization, 'rte_get_tsc_hz()' could be used only after successfull call to 'rte_eal_init()'. 'rte_eal_init()' estimates the TSC frequency for later use by 'rte_get_tsc_hz()'. Fairly said, we're not allowed to use

[ovs-dev] [PATCH 1/3] ovs-numa: Add dump based thread affinity functions.

2019-08-13 Thread Ilya Maximets
New functions to get and set CPU affinity using CPU dumps. This will abstract OS specific implementation details from the cross-platform code. Signed-off-by: Ilya Maximets --- lib/ovs-numa.c | 74 +- lib/ovs-numa.h | 2 ++ 2 files changed, 75

[ovs-dev] [PATCH 0/3] Fix TSC frequency if DPDK is not available.

2019-08-13 Thread Ilya Maximets
Ilya Maximets (3): ovs-numa: Add dump based thread affinity functions. dpif-netdev-perf: Fix TSC frequency for non-DPDK case. dpdk: Use ovs-numa provided functions to manage thread affinity. lib/dpdk-stub.c| 6 lib/dpdk.c | 33 ++- lib/dpdk.h

Re: [ovs-dev] [PATCH] Do RCU synchronization at fixed interval in PMD main loop.

2019-08-13 Thread Ilya Maximets
On 07.08.2019 17:21, Nitin Katiyar wrote: > Each PMD updates the global sequence number for RCU synchronization > purpose with other OVS threads. This is done at every 1025th iteration > in PMD main loop. > > If the PMD thread is responsible for polling large number of queues > that are carrying

[ovs-dev] Крутой способ поиска постоянных клиентов -- инфо внутри

2019-08-13 Thread Батыр via dev
Передайте это сообщение начальнику по продажам --- Если вашей фирме нужна свежая база данных потенциальных клиентов для обзвона или рассылки, закажите базу данных по этому адресу http://bzonl.info/db/ -- А также приглашаем воспользоваться предложением

Re: [ovs-dev] [PATCH v2 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-13 Thread aserdean
> -Original Message- > From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Justin Pettit > Sent: Tuesday, August 6, 2019 8:28 AM > To: Yi-Hung Wei > Cc: ovs dev ; Alin Gabriel Serdean > > Subject: Re: [ovs-dev] [PATCH v2 4/9] ct-dpif, dpif-netlink: Add

Re: [ovs-dev] [PATCH v3 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-13 Thread aserdean
> -Original Message- > From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Yi-Hung Wei > Sent: Tuesday, August 13, 2019 3:52 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH v3 4/9] ct-dpif, dpif-netlink: Add conntrack > timeout policy support > > This

Re: [ovs-dev] [PATCH v2 ovn] Add support for using OVN specific rundirs

2019-08-13 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 99 characters long (recommended limit is 79) #635 FILE:

[ovs-dev] [PATCH] Improve MPLSoGRE performance by reducing EMC hash collisions.

2019-08-13 Thread Nitin Katiyar
When a packet is received, the RSS hash is calculated if it is not already available. The Exact Match Cache (EMC) entry is then looked up using this RSS hash. When a MPLSoGRE encapsulated packet is received, the GRE header is popped, the RSS hash is invalidated and the packet is recirculated for

[ovs-dev] [PATCH v2 ovn] Add support for using OVN specific rundirs

2019-08-13 Thread nusiddiq
From: Numan Siddique Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). The commit [1] changed the package name from openvswitch to ovn, but it didn't take into the account the effects of it. When "make install" is run ovn-ctl utility is copied to /usr/local/share/ovn/scripts

Re: [ovs-dev] [PATCH] [windows][wmi] Switch from internal port to all ports defined

2019-08-13 Thread aserdean
Thanks! Applied on master and backported back until branch-2.10. Alin. From: Anand Kumar Sent: Thursday, August 1, 2019 5:41 AM To: Alin Serdean ; d...@openvswitch.org Cc: Danting Liu Subject: Re: [ovs-dev] [PATCH] [windows][wmi] Switch from internal port to all ports defined

Re: [ovs-dev] [PATCH v5] Avoid dp_hash recirculation for balance-tcp bond selection mode

2019-08-13 Thread Vishal Deep Ajmera
> > Hi, > > why not a static function in the header file? So it gets inlined. > > Regards, > -- > Matteo Croce > per aspera ad upstream Thanks Matteo for looking into this patch-set. Yes I agree. I will address your suggestion in the next revision. Warm Regards, Vishal