Re: [ovs-dev] [RFC PATCH ovn] Disable conjunction

2019-09-26 Thread Numan Siddique
On Fri, Sep 27, 2019 at 11:56 AM Han Zhou wrote: > > Thanks Numan. It looks good to me. Is there a reason why this is RFC? > Yes. I actually was thinking another way to disable conjunction. I will submit that patch and we can discuss further. Thanks Numan > > On Wed, Sep 25, 2019 at 1:48 AM

Re: [ovs-dev] [RFC PATCH ovn] Disable conjunction

2019-09-26 Thread Han Zhou
Thanks Numan. It looks good to me. Is there a reason why this is RFC? On Wed, Sep 25, 2019 at 1:48 AM wrote: > From: Numan Siddique > > The commit 298701dbc996("Exclude inport and outport symbol tables from > conjunction") > was earlier added to disable conjunction for inport and outport symbol

Re: [ovs-dev] [PATCH ovn v3] Learn the mac binding only if required

2019-09-26 Thread Han Zhou
On Tue, Sep 24, 2019 at 1:39 PM wrote: > diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml > index 6115e84b5..c98db48d2 100644 > --- a/ovn-architecture.7.xml > +++ b/ovn-architecture.7.xml > @@ -970,6 +970,24 @@ > this temporary use.) > > > + > +

[ovs-dev] [PATCH ovn v1] vagrant: Port Vagrantfile to build and test OVN

2019-09-26 Thread Flavio Fernandes
Revisit Vagrantfile for OVN, so these distros can be used to build OVN and run its tests: - centos7 - debian-8 - fedora-29 Vagrant box fedora/23-cloud-base is not working anymore, so it got bumped to fedora-29. This patch assumes that OVS source is located on same directory where this OVN s

Re: [ovs-dev] [PATCH v2] odp-util: calc checksum of ip hdr for tunnel encap

2019-09-26 Thread 0-day Robot
Bleep bloop. Greetings Martin Zhang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has non-spaces leading whitespace #40 FILE: lib/odp-util.c:1527: memset(i

[ovs-dev] [PATCH v2] odp-util: calc checksum of ip hdr for tunnel encap

2019-09-26 Thread martinbj2008
From: Martin Zhang Signed-off-by: Martin Zhang V2: fix compile warning Signed-off-by: Martin Zhang --- lib/odp-util.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/odp-util.c b/lib/odp-util.c index fe59a56..29ffd6d 100644 --- a/lib/odp-util.c +++ b/lib/od

Re: [ovs-dev] [PATCH v5 9/9] ofproto-dpif-xlate: Translate timeout policy in ct action

2019-09-26 Thread Justin Pettit
> On Sep 25, 2019, at 4:34 PM, Yi-Hung Wei wrote: > > Thanks Justin for the review. The proposed diff looks good to me. Thanks. I pushed the series to master. --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailma

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Add static IP multicast flood configuration

2019-09-26 Thread Mark Michelson
Looks good to me Acked-by: Mark Michelson On 9/24/19 4:02 AM, Dumitru Ceara wrote: Add the following new configuration options to the Logical_Switch_Port:options column in the OVN Northbound database: - mcast_flood: if set to 'true' all incoming IP multicast traffic (except IP multicast re

Re: [ovs-dev] [PATCH v2] Modify release document for OVN.

2019-09-26 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (Documentation/internals/release-process.rst). Rep

Re: [ovs-dev] dpdk-latest rebase

2019-09-26 Thread Stokes, Ian
On 9/26/2019 1:09 PM, David Marchand wrote: On Thu, Sep 26, 2019 at 11:41 AM Ilya Maximets wrote: On 26.09.2019 12:08, Stokes, Ian wrote: Hi all, the dpdk-latest branch has been lagging behind ovs master for a bit. Now that the OVS 2.12 release is out it seems timely to rebase it on> top

[ovs-dev] [PATCHv5] netdev-afxdp: Add need_wakeup supprt.

2019-09-26 Thread William Tu
The patch adds support for using need_wakeup flag in AF_XDP rings. A new option, use_need_wakeup, is added. When this option is used, it means that OVS has to explicitly wake up the kernel RX, using poll() syscall and wake up TX, using sendto() syscall. This feature improves the performance by avoi

[ovs-dev] [PATCH v2] Modify release document for OVN.

2019-09-26 Thread Mark Michelson
This is an RFC to discuss the modified release cycle of OVN compared to OVS. The document is mostly unchanged, with two exceptions: * The release cycle for OVN is modified to be 3 months instead of 6. * The version numbering for OVN is modified to use the year and month of the release instead of

[ovs-dev] [PATCHv3] fatal-signal: Catch SIGSEGV and print backtrace.

2019-09-26 Thread William Tu
The patch catches the SIGSEGV signal and prints the backtrace using libunwind at the monitor daemon. This makes debugging easier when there is no debug symbol package or gdb installed on production systems. The patch works when the ovs-vswitchd compiles even without debug symbol (no -g option), be

Re: [ovs-dev] [PATCH] netdev-afxdp: Detect numa node id.

2019-09-26 Thread William Tu
On Thu, Sep 26, 2019 at 02:18:15PM +0200, Eelco Chaudron wrote: > > > On 13 Sep 2019, at 19:15, William Tu wrote: > > >The patch detects the numa node id from the name of the netdev, > >by reading the '/sys/class/net//device/numa_node'. > >If not available, ex: virtual device, or any error happe

Re: [ovs-dev] [PATCH ovn 1/4] configure: Improve checks for OVS source and build directories.

2019-09-26 Thread Ben Pfaff
On Thu, Sep 26, 2019 at 12:07:52PM +0530, Numan Siddique wrote: > On Thu, Sep 26, 2019 at 12:04 AM Ben Pfaff wrote: > > > Until now, "configure" was willing to accept anything as the OVS source > > and build directory, but obviously only an actual OVS source or build > > directory will actually w

Re: [ovs-dev] [PATCH v4] Require Python 3 and remove support for Python 2.

2019-09-26 Thread 0-day Robot
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Ben Pfaff needs to sign off. WARNING: Line is 89 characters long (recommended limit

Re: [ovs-dev] [PATCH v3] Require Python 3 and remove support for Python 2.

2019-09-26 Thread Ben Pfaff
On Thu, Sep 26, 2019 at 11:39:22AM +0530, Numan Siddique wrote: > On Thu, Sep 26, 2019 at 1:18 AM Numan Siddique wrote: > > > > > > > On Thu, Sep 26, 2019, 12:12 AM Ben Pfaff wrote: > > > >> Numan, please (re-)review this when you have time. > >> > > > > Sure. I will do it tomorrow > > > > This

Re: [ovs-dev] [PATCH 3/3] debug: print mbuf extra info.

2019-09-26 Thread Ben Pfaff
On Thu, Sep 26, 2019 at 11:59:14AM -0400, Aaron Conole wrote: > Flavio Leitner writes: > > > Signed-off-by: Flavio Leitner > > --- > > lib/netdev-dpdk.c | 18 ++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > > index cfbd9a9e5..

Re: [ovs-dev] DDLog after one week

2019-09-26 Thread Leonid Ryzhyk via dev
> > > Q: Why doesn't the ddlog compiler generate Out_IP_Multicast and only > > > "input IP_Multicast" in OVN_Southbound.dl. > > > A: For every table to which ovn-northd-ddlog needs to write we need to > > > update northd/automake.mk. Could we make this more robust or is it > > > fine to keep addin

Re: [ovs-dev] [PATCH 3/3] debug: print mbuf extra info.

2019-09-26 Thread Aaron Conole
Flavio Leitner writes: > Signed-off-by: Flavio Leitner > --- > lib/netdev-dpdk.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index cfbd9a9e5..7965bf57a 100644 > --- a/lib/netdev-dpdk.c > +++ b/lib/netdev-dpdk.c > @@ -2294,

Re: [ovs-dev] [PATCHv2] fatal-signal: Catch SIGSEGV and print backtrace.

2019-09-26 Thread William Tu
On Wed, Sep 25, 2019 at 4:58 PM 0-day Robot wrote: > > Bleep bloop. Greetings William Tu, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > build: > /bin/sh ./libtool --tag=CC --m

Re: [ovs-dev] [PATCH] travis: Drop -MD related workaround for sparse.

2019-09-26 Thread Ilya Maximets
On 26.09.2019 13:33, Stokes, Ian wrote: On 9/26/2019 10:34 AM, Ilya Maximets wrote: The issue was fixed in upstream sparse by the following commit: d90c0838c101 ("cgcc: fix wrong processing of -MD & -MMD") This patch is required to fix our travis build. Signed-off-by: Ilya Maximets --- Thi

Re: [ovs-dev] [branch-2.12 PATCH] netdev-dpdk: Fix padding info comment.

2019-09-26 Thread Stokes, Ian
On 9/6/2019 2:20 PM, Ilya Maximets wrote: On 05.09.2019 16:21, Kevin Traynor wrote: The comment was incorrectly updated. Fix it to the correct value of 32 pad bytes. /* --- cacheline 5 boundary (320 bytes) --- */ union { struct { struct netdev_stats stats; /*

Re: [ovs-dev] [PATCH ovs V1 0/2] Introduce dpdkvdpa netdev

2019-09-26 Thread Eelco Chaudron
Hi Noa, Did not review the patchset yet, but it would be good to at least include some documentation around use cases, and maybe an example to be used for testing? Cheers, Eelco On 15 Sep 2019, at 7:37, Noa Ezra wrote: Introduce dpdkvdpa netdev allowing HW offloads over VirtIO network de

Re: [ovs-dev] [PATCH] netdev-afxdp: Detect numa node id.

2019-09-26 Thread Eelco Chaudron
On 13 Sep 2019, at 19:15, William Tu wrote: The patch detects the numa node id from the name of the netdev, by reading the '/sys/class/net//device/numa_node'. If not available, ex: virtual device, or any error happens, return numa id 0. See comments below, but I think the main problem that s

Re: [ovs-dev] dpdk-latest rebase

2019-09-26 Thread David Marchand
On Thu, Sep 26, 2019 at 11:41 AM Ilya Maximets wrote: > > On 26.09.2019 12:08, Stokes, Ian wrote: > > Hi all, > > > > the dpdk-latest branch has been lagging behind ovs master for a bit. > > Now that the OVS 2.12 release is out it seems timely to rebase it on> top > > of OVS master and push, note

[ovs-dev] CONTACT, JP Morgan Chase Bank NY USA for your funds transfer US$16.5million Dollars deposited this morning,

2019-09-26 Thread Dr.JOHN DAVIDSON Dir IMF Benin.
ATTN,DEAR CONTACT,JP Morgan Chase Bank NY USA for your funds transfer US$16.5million Dollars deposited this morning, Director, MS.Linda B. Bammann The Bank is waiting to hear from you before transfer release to your bank. This is to avoid any hitch problems. CONTACT this bank once to receive your t

Re: [ovs-dev] [PATCH] travis: Drop -MD related workaround for sparse.

2019-09-26 Thread Stokes, Ian
On 9/26/2019 10:34 AM, Ilya Maximets wrote: The issue was fixed in upstream sparse by the following commit: d90c0838c101 ("cgcc: fix wrong processing of -MD & -MMD") This patch is required to fix our travis build. Signed-off-by: Ilya Maximets --- This should be applied to master and backpo

Re: [ovs-dev] [PATCH v3] netdev-dpdk: add support for the RTE_ETH_EVENT_INTR_RESET event

2019-09-26 Thread Ilya Maximets
On 24.09.2019 16:15, Eelco Chaudron wrote: On 12 Sep 2019, at 12:24, Ilya Maximets wrote: On 12.09.2019 13:19, Ilya Maximets wrote: On 12.09.2019 13:07, Eelco Chaudron wrote: On 12 Sep 2019, at 10:39, Ilya Maximets wrote: On 11.09.2019 16:20, Eelco Chaudron wrote: Currently, OVS does n

Re: [ovs-dev] [PATCH branch-2.10] dpdk: Use DPDK 17.11.6 release.

2019-09-26 Thread Stokes, Ian
On 9/26/2019 10:55 AM, Ilya Maximets wrote: On 26.09.2019 12:46, Kevin Traynor wrote: On 26/09/2019 09:44, Stokes, Ian wrote: On 9/25/2019 10:50 PM, Ben Pfaff wrote: It looks like these DPDK version update patches have been overlooked. Ilya, Ian, do you want to look at them? Hi Ben, sur

Re: [ovs-dev] [PATCH branch-2.10] dpdk: Use DPDK 17.11.6 release.

2019-09-26 Thread Ilya Maximets
On 26.09.2019 12:46, Kevin Traynor wrote: On 26/09/2019 09:44, Stokes, Ian wrote: On 9/25/2019 10:50 PM, Ben Pfaff wrote: It looks like these DPDK version update patches have been overlooked. Ilya, Ian, do you want to look at them? Hi Ben, sure I can look at them, I had worked with Lukasz

Re: [ovs-dev] [PATCH branch-2.10] dpdk: Use DPDK 17.11.6 release.

2019-09-26 Thread Stokes, Ian
On 9/26/2019 10:46 AM, Kevin Traynor wrote: On 26/09/2019 09:44, Stokes, Ian wrote: On 9/25/2019 10:50 PM, Ben Pfaff wrote: It looks like these DPDK version update patches have been overlooked. Ilya, Ian, do you want to look at them? Hi Ben, sure I can look at them, I had worked with L

[ovs-dev] My name is Victoria Franci

2019-09-26 Thread francis_victoria555--- via dev
Hello, My name is Victoria Francis, from France. Can you help me transfer my money. l lost My husband two years ago and the family members are after me and my two kids, just because of the legacy he left for us in a Bank, Please help us secure this legacy and have it transferred, The inheritance

Re: [ovs-dev] [PATCH branch-2.10] dpdk: Use DPDK 17.11.6 release.

2019-09-26 Thread Kevin Traynor
On 26/09/2019 09:44, Stokes, Ian wrote: > > > On 9/25/2019 10:50 PM, Ben Pfaff wrote: >> It looks like these DPDK version update patches have been overlooked. >> Ilya, Ian, do you want to look at them? > > Hi Ben, > > sure I can look at them, > > I had worked with Lukasz to validate this so wa

Re: [ovs-dev] dpdk-latest rebase

2019-09-26 Thread Ilya Maximets
On 26.09.2019 12:08, Stokes, Ian wrote: Hi all, the dpdk-latest branch has been lagging behind ovs master for a bit. Now that the OVS 2.12 release is out it seems timely to rebase it on> top of OVS master and push, note as before this will be a force push> on the dpdk-latest branch as the reba

[ovs-dev] [PATCH] travis: Drop -MD related workaround for sparse.

2019-09-26 Thread Ilya Maximets
The issue was fixed in upstream sparse by the following commit: d90c0838c101 ("cgcc: fix wrong processing of -MD & -MMD") This patch is required to fix our travis build. Signed-off-by: Ilya Maximets --- This should be applied to master and backported to 2.12. .travis/linux-prepare.sh | 5

Re: [ovs-dev] dpdk-latest rebase

2019-09-26 Thread David Marchand
On Thu, Sep 26, 2019 at 11:14 AM Eelco Chaudron wrote: > On 26 Sep 2019, at 11:08, Stokes, Ian wrote: > > > Hi all, > > > > the dpdk-latest branch has been lagging behind ovs master for a bit. > > Now that the OVS 2.12 release is out it seems timely to rebase it on > > top of OVS master and push,

Re: [ovs-dev] [PATCH 1/2] cgcc: gendeps for -MM, -MD & -MMD too

2019-09-26 Thread Ilya Maximets
On Wed, Apr 24, 2019 at 04:12:32PM +0300, Ilya Maximets wrote: On 20.02.2019 16:34, Luc Van Oostenryck wrote: > These flags must set '$gendeps', just like a plain '-M' do, > since they implies '-M'. > > Signed-off-by: Luc Van Oostenryck > --- Hi. Unlike simple '-M', '-MD' and '-MMD' doesn't

Re: [ovs-dev] dpdk-latest rebase

2019-09-26 Thread Eelco Chaudron
On 26 Sep 2019, at 11:08, Stokes, Ian wrote: Hi all, the dpdk-latest branch has been lagging behind ovs master for a bit. Now that the OVS 2.12 release is out it seems timely to rebase it on top of OVS master and push, note as before this will be a force push on the dpdk-latest branch as

[ovs-dev] dpdk-latest rebase

2019-09-26 Thread Stokes, Ian
Hi all, the dpdk-latest branch has been lagging behind ovs master for a bit. Now that the OVS 2.12 release is out it seems timely to rebase it on top of OVS master and push, note as before this will be a force push on the dpdk-latest branch as the rebase on master will change the commit histor

Re: [ovs-dev] [PATCH] dpdk: Remove unneeded log message copy.

2019-09-26 Thread Stokes, Ian
On 9/25/2019 6:30 PM, Stokes, Ian wrote: On 9/6/2019 3:18 PM, David Marchand wrote: On Fri, Sep 6, 2019 at 3:24 PM Ilya Maximets wrote: On 06.09.2019 14:26, David Marchand wrote: No need to duplicate and null-terminate the passed buffer. We can directly give it to the vlog subsystem usi

Re: [ovs-dev] DDLog after one week

2019-09-26 Thread Dumitru Ceara
On Thu, Sep 26, 2019 at 5:15 AM Leonid Ryzhyk wrote: > > Hi Dimitru, > > > Looking at IGMP I'm quite happy with the end result in DDlog. It > > really allowed me to focus on the feature specific logic and spared me > > the code complexity of custom hashtables and IDL lookups to implement > > stabl

Re: [ovs-dev] [PATCH branch-2.10] dpdk: Use DPDK 17.11.6 release.

2019-09-26 Thread Stokes, Ian
On 9/25/2019 10:50 PM, Ben Pfaff wrote: It looks like these DPDK version update patches have been overlooked. Ilya, Ian, do you want to look at them? Hi Ben, sure I can look at them, I had worked with Lukasz to validate this so was waiting for an ACK from someone outside Intel. Below lo