Hi Ben:
I have tried, this patch works! Thank you!
One question: should "simap_destroy(>tnl_backers)" be within the
close brace ?
Timo
Re: [PATCH 2/2] ofproto: Do not delete datapath flows on exit by default
On Wed, Feb 26, 2020 at 04:40:25PM +0800, txfh2007 wrote:
> Hi Ben:
>
When a leader handles install_snapshot reply, the next_index for
the follower should be log_start instead of log_end, because there
can be new entries added in leader's log after initiating the
install_snapshot procedure. Also, it should send all the accumulated
entries to follower in the
When a follower needs to "catch up", leader can send N entries in
a single append_request instead of only one entry by each message.
The function raft_send_append_request() already supports this, so
this patch just calculate the correct "n" and use it.
Signed-off-by: Han Zhou
---
ovsdb/raft.c
Signed-off-by: Han Zhou
---
ovsdb/raft-rpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ovsdb/raft-rpc.c b/ovsdb/raft-rpc.c
index 18c83fe..dd14d81 100644
--- a/ovsdb/raft-rpc.c
+++ b/ovsdb/raft-rpc.c
@@ -544,8 +544,8 @@ raft_format_install_snapshot_request(
When a server doesn't see a leader yet, e.g. during leader re-election,
if a transaction comes from a client, it will cause 100% CPU busy loop.
With debug log enabled it is like:
2020-02-28T04:04:35.631Z|00059|poll_loop|DBG|wakeup due to 0-ms timeout at
../ovsdb/trigger.c:164
When a node becomes leader, it sends out heartbeat to all followers
and then sends out another append-request for a non-op command
execution to all followers again immediately. This causes 2
continously append-requests sent out to each followers, and the first
heartbeat append-request is
If there is never a leader known by the current server, it's status
should be "disconnected" to the cluster. Without this patch, when
a server in cluster is restarted, before it successfully connecting
back to the cluster it will appear as connected, which is wrong.
Signed-off-by: Han Zhou
---
When "schema" field is found in read_db(), there can be two cases:
1. There is a schema change in clustered DB and the "schema" is the new one.
2. There is a install_snapshot RPC happened, which caused log compaction on the
server and the next log is just the snapshot, which always constains
On Fri, Feb 28, 2020 at 3:21 PM Ben Pfaff wrote:
>
> On Tue, Feb 25, 2020 at 11:59:06AM -0800, William Tu wrote:
> > Currently ovs-bugtool does not work due to Python2 deprecated.
> > When moving to Python3, a couple of things are broken in ovs-bugtool,
> > ex: import libraries issues such as
Hi Ben,
Thanks for the patch. I can confirm that when applying the patch, tunnel ports
are no longer deleted when ovs-vswitchd exits.
I ran a test with a VXLAN tunnel between 2 VMs. The vxlan_sys_4789 interface is
not deleted after stopping the OVS daemons.
When I ping one VM from the other,
On Sun, Feb 16, 2020 at 05:46:52PM +0200, George Moudatsakis wrote:
> I am trying to implement an application in ONOS controller and i need to
> monitor the packets in the OvS i am "controlling", in real time.
>
> Not all the packets are received on the controller because some other
>
On Tue, Feb 18, 2020 at 04:13:04PM +0800, taoyunxi...@cmss.chinamobile.com
wrote:
> >ovsdb_idl_txn_commit() can be simplified if uuids are specified, because
> >it's no longer necessary to specify named-uuids or to call
> >substitute_uuids().
>
> We have try to work on this , but it is
On Tue, Feb 18, 2020 at 03:24:25PM +0800, Tao YunXiang wrote:
> Commit a529e3cd1f (ovsdb-server: Allow OVSDB clients to specify the
> UUID for inserted rows) solves ovsdb-client specifing the UUID for
> insert operation. OVSDB now can support directly using uuid to identify
> a row. But for
On Tue, Feb 25, 2020 at 08:30:12AM +0100, Damijan Skvarc wrote:
> Hi Ben and thanks for letting me know about "x" prefix nomenclature, I
> was not aware about it. Thanks also for suggesting more appropriate
> function name, it much more descriptive. I am sending V2 patch
You're welcome. Thanks
On Tue, Feb 25, 2020 at 11:59:06AM -0800, William Tu wrote:
> Currently ovs-bugtool does not work due to Python2 deprecated.
> When moving to Python3, a couple of things are broken in ovs-bugtool,
> ex: import libraries issues such as StringIO and commands.
> Also there are some bytes to string
On Wed, Feb 26, 2020 at 04:40:25PM +0800, txfh2007 wrote:
> Hi Ben:
>
> I have read your patch about "not delete datapath flow when daemon exit".
> I think this patch is really important, It can be used during upgrading
> without effecting existing traffic. I have test in my env, and found
Applied, thanks.
On Fri, Feb 28, 2020 at 02:43:44PM -0500, Mark Michelson wrote:
> Yes, thank you Ben.
>
> On 2/28/20 2:22 PM, Ben Pfaff wrote:
> > Does this need a backport to OVS 2.12?
> >
> > On Thu, Feb 27, 2020 at 04:27:33PM -0500, Mark Michelson wrote:
> > > I've merged the change to
If the ovsdb-server reply to "monitor_cond_since" requests has
"found" == false then ovsdb_idl_db_parse_monitor_reply() calls
ovsdb_idl_db_clear() which iterates through all tables and
unconditionally sets table->cond_changed to false.
However, if the client had already set a new condition for
The kernel needs to be at least 4.19-rc7 to include the commit
9d2f67e43b73 ("net/packet: fix packet drop as of virtio gso")
otherwise the TSO packets are dropped when using raw sockets.
Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
Reported-by: Yi Yang (杨燚)-云服务集团
The patches I linked below have been merged. Thanks!
I was initially hesitant to release because of this bug that was
reported yesterday: https://bugzilla.redhat.com/show_bug.cgi?id=1808125
However, Dumitru has a fix on the way for it, and the fix will be in OVS
code, not OVN. So we can cut
Signed-off-by: Mark Michelson
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 9b36bfd17..4d38f1b55 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+OVN v20.03.1 - xx xxx
Signed-off-by: Mark Michelson
---
NEWS | 2 +-
debian/changelog | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index f3242a70f..9b36bfd17 100644
--- a/NEWS
+++ b/NEWS
@@ -1,4 +1,4 @@
-OVN v20.03.0 - xx xxx
+OVN v20.03.0 - 28 Feb 2020
On 2/28/20 5:40 AM, Damijan Skvarc wrote:
Hi Mark
and thanks you made review of suggested patch.
just a few words of myself...
I don't work professionally on this project, I started to look into this
code in my free hours just to satisfy my curiosity about how other
people work. I am
Yes, thank you Ben.
On 2/28/20 2:22 PM, Ben Pfaff wrote:
Does this need a backport to OVS 2.12?
On Thu, Feb 27, 2020 at 04:27:33PM -0500, Mark Michelson wrote:
I've merged the change to master and branch-20.03.
On 2/27/20 2:37 PM, Numan Siddique wrote:
On Thu, Feb 27, 2020 at 4:04 PM
Does this need a backport to OVS 2.12?
On Thu, Feb 27, 2020 at 04:27:33PM -0500, Mark Michelson wrote:
> I've merged the change to master and branch-20.03.
>
> On 2/27/20 2:37 PM, Numan Siddique wrote:
> > On Thu, Feb 27, 2020 at 4:04 PM Lorenzo Bianconi
> > wrote:
> > >
> > > ovn-controller
On Thu, Feb 27, 2020 at 10:15:59AM +0100, Dumitru Ceara wrote:
> Skip IGMP entries learned for local multicast groups when generating
> logical flows. We still allow ovn-controller to learn them as
> it might be useful information for administrators to see that hosts
> register for the groups even
Applied, thanks for the reminder.
On Wed, Feb 26, 2020 at 05:11:07PM +0100, Maciej Jozefczyk wrote:
> Hello,
>
> Can I ask you to verify this patch and apply it on branch-2.12, please?
> We recently are having issues with Openstack gates because this patch is
> missing in branch-2.12
>
> Thanks
On Fri, Feb 28, 2020 at 10:59:40AM -0800, Gregory Rose wrote:
> On 2/28/2020 10:54 AM, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff
> > ---
> > vswitchd/ovs-vswitchd.8.in | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/vswitchd/ovs-vswitchd.8.in
On 2/28/2020 10:54 AM, Ben Pfaff wrote:
Signed-off-by: Ben Pfaff
---
vswitchd/ovs-vswitchd.8.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vswitchd/ovs-vswitchd.8.in b/vswitchd/ovs-vswitchd.8.in
index ac66ed7bb300..0ad8bd2bc4ff 100644
--- a/vswitchd/ovs-vswitchd.8.in
Signed-off-by: Ben Pfaff
---
vswitchd/ovs-vswitchd.8.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vswitchd/ovs-vswitchd.8.in b/vswitchd/ovs-vswitchd.8.in
index ac66ed7bb300..0ad8bd2bc4ff 100644
--- a/vswitchd/ovs-vswitchd.8.in
+++ b/vswitchd/ovs-vswitchd.8.in
@@ -107,7
Hello,
I would like to know if you are interested in acquiring F5 Networks Users
Contact List.
Information fields: Names, Title, Email, Phone, Company Name, Company URL,
Company physical address, SIC Code, Industry and Specialty (Revenue and
Employee).
Let me know if you are interested
Hi Yi Yang,
This is the bug fix required to make veth TSO work in OvS:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9d2f67e43b73e8af7438be219b66a5de0cfa8bd9
commit 9d2f67e43b73e8af7438be219b66a5de0cfa8bd9
Author: Jianfeng Tan
Date: Sat Sep 29 15:41:27 2018
On 2/28/2020 9:42 AM, David Ahern wrote:
On 2/28/20 10:21 AM, Gregory Rose wrote:
On 2/27/2020 4:39 PM, Yi-Hung Wei wrote:
On Wed, Feb 26, 2020 at 9:42 AM Greg Rose wrote:
Changes for in kernel generated netlink attribute parsing functions
require our out of tree driver to use the deprecated
On 2/28/20 10:21 AM, Gregory Rose wrote:
>
> On 2/27/2020 4:39 PM, Yi-Hung Wei wrote:
>> On Wed, Feb 26, 2020 at 9:42 AM Greg Rose wrote:
>>> Changes for in kernel generated netlink attribute parsing functions
>>> require our out of tree driver to use the deprecated forms of those
>>> functions.
On Fri, Feb 28, 2020 at 5:53 PM Numan Siddique wrote:
>
> On Thu, Feb 27, 2020 at 6:46 PM Frode Nordahl
> wrote:
> >
> > There is a pattern among CMSes to create a `localnet` port
> > binding without any chassis affiliation.
> >
> > It is then up to the user to configure chassis with external
>
On 2/27/2020 4:39 PM, Yi-Hung Wei wrote:
On Wed, Feb 26, 2020 at 9:42 AM Greg Rose wrote:
Changes for in kernel generated netlink attribute parsing functions
require our out of tree driver to use the deprecated forms of those
functions. Otherwise the message parsing will return -EINVAL
The admin can choose whether or not to delete flows from datapaths when
they stop ovs-vswitchd. The goal of not deleting flows it to allow
existing traffic to continue being forwarded until ovs-vswitchd is
restarted. Until now, regardless of this choice, ovs-vswitchd has
always deleted tunnel
On 2/27/2020 4:39 PM, Yi-Hung Wei wrote:
On Wed, Feb 26, 2020 at 9:42 AM Greg Rose wrote:
Since this commit in the Linux upstream kernel:
'commit 9b9a3f20cbe0 ("kbuild: split final module linking out into
Makefile.modfinal")'
The openvswitch kernel module fails to build against the upstream
On 2/27/2020 4:38 PM, Yi-Hung Wei wrote:
On Wed, Feb 26, 2020 at 9:42 AM Greg Rose wrote:
The FIELD_SIZEOF macro is removed in Linux kernel release 5.5 but
is still needed in our out of tree kernel module for compatibility
with older kernels.
Signed-off-by: Greg Rose
---
On 2/27/2020 4:05 PM, Yi-Hung Wei wrote:
On Wed, Feb 26, 2020 at 9:41 AM Greg Rose wrote:
The policy field of the genl_ops structure has been removed in recent
kernels.
Signed-off-by: Greg Rose
---
acinclude.m4 | 3 +++
datapath/conntrack.c | 8
datapath/datapath.c |
On 2/27/2020 3:54 PM, Yi-Hung Wei wrote:
On Wed, Feb 26, 2020 at 9:41 AM Greg Rose wrote:
Since Linux kernel release 5.1 the fragments field of the inet_frag_queue
structure is removed and now only the rb_fragments structure with an
rb_node pointer is used for both ipv4 and ipv6. In addition,
On Thu, Feb 27, 2020 at 6:46 PM Frode Nordahl
wrote:
>
> There is a pattern among CMSes to create a `localnet` port
> binding without any chassis affiliation.
>
> It is then up to the user to configure chassis with external
> connectivity by adding a mapping under the
>
From: Numan Siddique
Due to some timing issues, ovn-controller logs the warning message -
"handle service check: Service monitor not found". This can happen
if the service monitor is created in SB DB before the port for
the service is bound. This patch adds this warning message to the
WHITELIST
On Fri, Feb 28, 2020 at 2:08 AM Mark Michelson wrote:
>
> Acked-by: Mark Michelson
Thanks Dumitru and Mark.
I applied this patch to master and branch-20.03
Thanks
Numan
>
> On 2/27/20 10:54 AM, Dumitru Ceara wrote:
> > It can happen that all ports on which IGMP/MLD join reports were
> >
On Fri, Feb 28, 2020 at 4:11 PM Damijan Skvarc wrote:
>
> Hi Mark
>
> and thanks you made review of suggested patch.
>
> just a few words of myself...
> I don't work professionally on this project, I started to look into this
> code in my free hours just to satisfy my curiosity about how other
On 2/28/20 5:09 PM, Stokes, Ian wrote:
> Hi Ilya,
>
> Sure, I was just rebasing today, have a travis test running at the moment,
> was waiting for it to complete before force pushing.
Right in time.)
>
> If you've run travis already then feel free to push away. Alternatively I can
> do it
Hi Ilya,
Sure, I was just rebasing today, have a travis test running at the moment, was
waiting for it to complete before force pushing.
If you've run travis already then feel free to push away. Alternatively I can
do it once it completes.
Regards
Ian
> -Original Message-
> From:
Hi Ian,
Our dpdk-latest branch is really outdated now and fails travis builds
due to kernel module building issues that are fixed on master a long
time ago. I rebased it locally -- we only need one patch on top of
current master that enables dpdk master branch -- and could force-push
to
On 2/18/20 2:49 PM, Eli Britstein wrote:
> Follow up to commit eb540c0f5fc8 ("flow: Fix parsing l3_ofs with partial
> offloading") that fixed the issue, add a unit-test for it.
>
> Signed-off-by: Eli Britstein
> Reviewed-by: Roi Dayan
> ---
> tests/dpif-netdev.at | 77
>
On 2/26/20 5:46 AM, Yanqin Wei wrote:
> Some partial offloading test cases are failing inconsistently. The root
> cause is that dummy netdev is assigned with "linux_tc" offloading API.
> dpif-netdev - partial hw offload - dummy
> dpif-netdev - partial hw offload - dummy-pmd
> dpif-netdev - partial
On 2/14/20 2:03 PM, Flavio Leitner wrote:
> This patchset disables unsupported offload features for vhost
> device such as UFO and ECN.
>
> Then it includes UDP checksum offload as a must have to enable
> userspace TSO, but leave SCTP as optional. Only a few drivers
> support SCTP checksum
Hi All,
There has been a request to use the next OVS-DPDK meeting (Wed March 4th
@ 17:00 UTC, call details below) to present/discuss about Hw offload
capabilities and OVS integration with DPDK rte_flow API.
Perhaps some design discussion now can save time coding/reworking later.
Would request
On Sun, Feb 23, 2020 at 08:45:16AM +, Yi Yang (杨燚)-云服务集团 wrote:
> Hi, Flavio
>
> Just let you know, your TSO support patch does need higher kernel version, it
> will be great if you can add document to tell users which kernel version is
> minimal requirement. I can confirm it can work after
On 2/27/20 5:12 PM, Yanqin Wei wrote:
> Read/write concurrency of pvector library is implemented by a temp vector
> and RCU protection. Considering performance reason, insertion does not
> follow this scheme.
> In insertion function, a thread fence ensures size incrementation is done
> after new
On Fri, Feb 28, 2020, 3:13 AM Mark Michelson wrote:
> *sigh*
>
> Acked-by: Mark Michelson
>
Thanks. I applied this patch to master and branch-20.03
Thanks
Numan
> :(
>
> On 2/25/20 10:50 AM, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > This patch reverts the below patches which
Hi Mark
and thanks you made review of suggested patch.
just a few words of myself...
I don't work professionally on this project, I started to look into this
code in my free hours just to satisfy my curiosity about how other people
work. I am following a couple of other projects just to learn
Hello all,
On Thu, Feb 27, 2020 at 10:51 PM Mark Michelson wrote:
[ snip ]
> If there are any other patches that I've missed, please let me know. I
> still plan to tag the release tomorrow.
While mostly cosmetic it would be great to have
https://patchwork.ozlabs.org/patch/1245848/ as I
On 2/27/20 10:00 AM, Eli Britstein wrote:
>
> On 2/26/2020 2:31 PM, Ilya Maximets wrote:
>> On 2/26/20 1:05 PM, Eli Britstein wrote:
>>> On 2/24/2020 1:06 PM, Ilya Maximets wrote:
On 2/23/20 3:32 PM, Eli Britstein wrote:
> On 2/21/2020 4:54 PM, Ilya Maximets wrote:
>> If the
On 2/27/20 8:52 PM, William Tu wrote:
> On Thu, Feb 27, 2020 at 11:10 AM William Tu wrote:
>>
>> On Thu, Feb 27, 2020 at 9:54 AM Ilya Maximets wrote:
>>>
>>> On 2/27/20 6:51 PM, William Tu wrote:
On Thu, Feb 27, 2020 at 9:42 AM Ilya Maximets wrote:
>
> On 2/27/20 6:30 PM, William
59 matches
Mail list logo
