Bleep bloop. Greetings Tao YunXiang, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#34 FILE: utilities/ovn-nbctl.c:607:
qos-del
We can delete qos by specify ls and more parameters.
If CMS want to delete it exactly, it must specify detailed "match" field.
It's not an easy way, also maybe deleted by mistake.
This change adds a way to specify ls and uuid, which is optional.
You can still use the previous method to delete.
Attention,
Kindly Find Attached Files And Send Your Documents Back To Us. Apply With Us On
Our 5% Interest Rate,
We Offer for all categories. Personal, Home, Debt Consolidation And Business
Loans. Even thou you are blacklisted or under debt review.
Legal Registration No. : 2014/238085/07
Hi, folks
As I said, TPACKET_V3 does have kernel implementation issue, I tried to fix it
in Linux kernel 5.5.9, here is my test data with tpacket_v3 and tso enabled. On
my low end server, my goal is to reach 16Gbps at least, I still have another
idea to improve it.
[yangyi@localhost
Bleep bloop. Greetings Usman Ansari, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: corrupt patch at line 17
error: could not build fake ancestor
hint: Use 'git am
On Wed, Mar 18, 2020 at 05:32:03PM -0700, Usman Ansari wrote:
> Suggested-by: Ben Pfaff
>
> Coverity reports a false positive below:
> Incorrect expression, Assign_where_compare_meant: use of "="
> where "==" may have been intended.
> Fixed it by rewriting '(NODE = NULL)' as '((NODE = NULL),
Suggested-by: Ben Pfaff
Coverity reports a false positive below:
Incorrect expression, Assign_where_compare_meant: use of "="
where "==" may have been intended.
Fixed it by rewriting '(NODE = NULL)' as '((NODE = NULL), false)'.
"make check" passes for this change
Coverity reports 80 errors
William, that can't fix Ilya's concern, we can fix thread-safe issues if most
of code in lib/netdev-linux.c is not thread-safe, we also have to consider how
we can fix scalability issue, obviously it isn't scalable that one ovs-vswitchd
thread handles all the such interfaces, this is
Buen día
El cupo del curso está por llenarse y quise aprovechar la oportunidad de
hacerte una última invitación:
•Nombre: Taller de Relaciones Laborales para mandos medios.
(Supervisión efectiva para mandos medios bajo la normatividad laboral vigente)
•¿Cuándo?: Miércoles 25
On Wed, Mar 18, 2020 at 6:22 AM Yi Yang (杨燚)-云服务集团 wrote:
>
> Ilya, raw socket for the interface type of which is "system" has been set to
> non-block mode, can you explain which syscall will lead to sleep? Yes, pmd
> thread will consume CPU resource even if it has nothing to do, but all the
>
On Wed, Mar 18, 2020 at 8:23 AM Timothy Redaelli wrote:
>
> Currently ovs-bugtool tool doesn't start on Python3.
> This commit fixes ovs-bugtool to make it works on Python.3
>
> Reported-at: https://bugzilla.redhat.com/1809241
> Reported-by: Flavio Leitner
> Signed-off-by: Timothy Redaelli
>
On Wed, Mar 18, 2020 at 8:36 AM Ben Pfaff wrote:
>
> On Wed, Mar 18, 2020 at 08:34:16AM -0700, William Tu wrote:
> > On Wed, Mar 18, 2020 at 7:59 AM Ilya Maximets wrote:
> > >
> > > On 3/18/20 12:31 AM, William Tu wrote:
> > > > Coverity CID 279497 reports "Operands don't affect result".
> > > >
I am only sending patch for the macro, for other I will send additional
patch(s)
On Wed, Mar 18, 2020 at 12:33 PM Usman Ansari wrote:
> Will resubmit the patch.
>
> Coverity says 80 bugs fixed from this change.
>
> On Wed, Mar 18, 2020 at 12:19 PM William Tu wrote:
>
> > On Wed, Mar 18, 2020
Will resubmit the patch.
Coverity says 80 bugs fixed from this change.
On Wed, Mar 18, 2020 at 12:19 PM William Tu wrote:
> On Wed, Mar 18, 2020 at 11:55 AM Ben Pfaff wrote:
> >
> > On Wed, Mar 18, 2020 at 11:43:29AM -0700, Usman Ansari wrote:
> > > From Ben Pfaff b...@ovn.org
> > >
> > >
> >
Consulta
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Mar 18, 2020 at 11:55 AM Ben Pfaff wrote:
>
> On Wed, Mar 18, 2020 at 11:43:29AM -0700, Usman Ansari wrote:
> > From Ben Pfaff b...@ovn.org
> >
> >
> > Coverity reports incorrect expression for HMAP_FOR_EACH_WITH_HASH macro
> > This patch fixes this issue
> > "make check" passes for this
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 83 characters long (recommended limit is 79)
#218 FILE: ovn-nb.xml:2160:
Ben,
I have verified your change to the macro and sending the patch.
Thanks.
On 3/17/20, 8:33 PM, "dev on behalf of William Tu"
wrote:
On Tue, Mar 17, 2020 at 5:39 PM Ben Pfaff wrote:
>
> On Tue, Mar 17, 2020 at 05:00:42PM -0700, William Tu wrote:
> > Hi,
> >
> >
On Wed, Mar 18, 2020 at 11:43:29AM -0700, Usman Ansari wrote:
> From Ben Pfaff b...@ovn.org
>
>
> Coverity reports incorrect expression for HMAP_FOR_EACH_WITH_HASH macro
> This patch fixes this issue
> "make check" passes for this change
> Coverity reports 80 errors resolved
>
> Signed-off-by:
Suggested-by: Han Zhou
Signed-off-by: Ben Pfaff
---
ovn-architecture.7.xml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml
index a69f4af7d1c5..b88bba5a1be9 100644
--- a/ovn-architecture.7.xml
+++ b/ovn-architecture.7.xml
@@
Also, reduce redundancy.
Suggested-by: Han Zhou
Signed-off-by: Ben Pfaff
---
ovn-architecture.7.xml | 29 +++--
1 file changed, 11 insertions(+), 18 deletions(-)
diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml
index b88bba5a1be9..a250cb38d811 100644
---
Signed-off-by: Ben Pfaff
---
ovn-architecture.7.xml | 10 +-
ovn-nb.xml | 6 +++---
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml
index a250cb38d811..533ae716d11d 100644
--- a/ovn-architecture.7.xml
+++
The documentation was scattered across two places. This brings it
together. It also documents the two solutions for physical VLAN MTU
issues in a unified way.
Signed-off-by: Ben Pfaff
---
ovn-architecture.7.xml | 110 +--
ovn-nb.xml | 166
v1->v2: Fix problems pointed out by Numan and Han.
Ben Pfaff (7):
xml2nroff: Properly support .
ovn-architecture: Flip network diagrams.
ovn-nb: Better document distributed gateway ports.
ovn-architecture: Correct documentation of localnet ports.
ovn-architecture: Don't imply the wrong
Their LSes can have multiple additional LSPs, not just one.
Suggested-by: Han Zhou
Signed-off-by: Ben Pfaff
---
ovn-architecture.7.xml | 29 -
1 file changed, 20 insertions(+), 9 deletions(-)
diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml
index
uses .SU but xml2nroff didn't define .SU.
Signed-off-by: Ben Pfaff
---
build-aux/xml2nroff | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/build-aux/xml2nroff b/build-aux/xml2nroff
index bd4e87928e4f..764ace9b19ba 100755
--- a/build-aux/xml2nroff
+++
Most network diagrams show end-hosts at the bottom ("south").
Signed-off-by: Ben Pfaff
---
ovn-architecture.7.xml | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml
index 415c895e497f..d32978a9d5be 100644
On Mon, Mar 16, 2020 at 02:57:25PM +0530, Numan Siddique wrote:
> On Sat, Mar 14, 2020 at 4:03 AM Ben Pfaff wrote:
> >
> > The documentation of distributed gateway ports was in two places: one
> > place for the main documentation, another for the options. This puts
> > it all in one place to
>From Ben Pfaff b...@ovn.org
Coverity reports incorrect expression for HMAP_FOR_EACH_WITH_HASH macro
This patch fixes this issue
"make check" passes for this change
Coverity reports 80 errors resolved
Signed-off-by: Usman Ansari
---
include/openvswitch/hmap.h
1 file changed, 1 insertion(+),
On Fri, Mar 13, 2020 at 05:13:02PM -0700, Han Zhou wrote:
> On Fri, Mar 13, 2020 at 3:33 PM Ben Pfaff wrote:
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > ovn-architecture.7.xml | 14 +++---
> > ovn-nb.xml | 6 +++---
> > 2 files changed, 10 insertions(+), 10 deletions(-)
>
On Wed, Mar 18, 2020 at 05:31:23PM +0100, Daniel Alvarez Sanchez wrote:
> On Tue, Mar 17, 2020 at 6:57 PM Ben Pfaff wrote:
>
> > On Tue, Mar 17, 2020 at 06:22:07PM +0100, Daniel Alvarez wrote:
> > > The current version of the documentation is still using the
> > > Open vSwitch logo and includes
Consulta
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Mar 17, 2020 at 6:57 PM Ben Pfaff wrote:
> On Tue, Mar 17, 2020 at 06:22:07PM +0100, Daniel Alvarez wrote:
> > The current version of the documentation is still using the
> > Open vSwitch logo and includes some references to OVS that
> > should be changed by OVN.
> >
> > Signed-off-by:
On Wed, Mar 18, 2020 at 04:53:27PM +0100, Ilya Maximets wrote:
> On 3/18/20 4:36 PM, Ben Pfaff wrote:
> > On Wed, Mar 18, 2020 at 08:34:16AM -0700, William Tu wrote:
> >> On Wed, Mar 18, 2020 at 7:59 AM Ilya Maximets wrote:
> >>>
> >>> On 3/18/20 12:31 AM, William Tu wrote:
> Coverity CID
On 3/18/20 4:36 PM, Ben Pfaff wrote:
> On Wed, Mar 18, 2020 at 08:34:16AM -0700, William Tu wrote:
>> On Wed, Mar 18, 2020 at 7:59 AM Ilya Maximets wrote:
>>>
>>> On 3/18/20 12:31 AM, William Tu wrote:
Coverity CID 279497 reports "Operands don't affect result".
Because flow->ct_state is
I guess it's a bug.
Have you posted the code you tested? Please post a v6 that includes the
test that fails.
On Wed, Mar 18, 2020 at 11:03:45PM +0800, Timo_Liu wrote:
>
Hi Ben:
When using both --id and --row_uuid, I have found the specified uuid only
worked for table whose "is_root"
On Wed, Mar 18, 2020 at 08:34:16AM -0700, William Tu wrote:
> On Wed, Mar 18, 2020 at 7:59 AM Ilya Maximets wrote:
> >
> > On 3/18/20 12:31 AM, William Tu wrote:
> > > Coverity CID 279497 reports "Operands don't affect result".
> > > Because flow->ct_state is uint8_t and
On Wed, Mar 18, 2020 at 7:59 AM Ilya Maximets wrote:
>
> On 3/18/20 12:31 AM, William Tu wrote:
> > Coverity CID 279497 reports "Operands don't affect result".
> > Because flow->ct_state is uint8_t and DP_NETDEV_CS_UNSUPPORTED_MASK
> > is '0xff00'. So remove the statement.
> >
> > Cc: Usman
On Wed, Mar 18, 2020 at 02:57:53PM +0100, Ilya Maximets wrote:
> On 3/5/20 12:28 PM, Dumitru Ceara wrote:
> > When a new conntrack zone is entered, the ct_state field is zeroed in
> > order to avoid using state information from different zones.
...
> Regarding the issue. I've spent some time
On Wed, Mar 18, 2020 at 01:49:48PM +0100, Ilya Maximets wrote:
> On 3/18/20 12:12 AM, William Tu wrote:
> > Coverity CID 279957 reports NULL pointer derefence when
> > 'conn' is NULL and calling ct_print_conn_info.
> >
> > Cc: Usman Ansari
> > Signed-off-by: William Tu
> > ---
> >
Currently ovs-bugtool tool doesn't start on Python3.
This commit fixes ovs-bugtool to make it works on Python.3
Reported-at: https://bugzilla.redhat.com/1809241
Reported-by: Flavio Leitner
Signed-off-by: Timothy Redaelli
---
utilities/bugtool/ovs-bugtool.in | 27 +--
1
Hi Ben:
When using both --id and --row_uuid, I have found the specified uuid only
worked for table whose "is_root" flag is true. For non root table, such as
mirror table, when we execute table create with --id and --row_uuid，the json
transaction includes two ops: insert mirror table
On 3/18/20 12:31 AM, William Tu wrote:
> Coverity CID 279497 reports "Operands don't affect result".
> Because flow->ct_state is uint8_t and DP_NETDEV_CS_UNSUPPORTED_MASK
> is '0xff00'. So remove the statement.
>
> Cc: Usman Ansari
> Signed-off-by: William Tu
> ---
> lib/dpif-netdev.c | 4
On 3/17/2020 4:31 PM, William Tu wrote:
Coverity CID 279274 reports leaking previously allocated
'error' buffer when 'return xasprintf("input too big");'.
Cc: Usman Ansari
Signed-off-by: William Tu
---
lib/ofp-actions.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On 3/17/2020 4:31 PM, William Tu wrote:
Coverity CID 279497 reports "Operands don't affect result".
Because flow->ct_state is uint8_t and DP_NETDEV_CS_UNSUPPORTED_MASK
is '0xff00'. So remove the statement.
Cc: Usman Ansari
Signed-off-by: William Tu
---
lib/dpif-netdev.c | 4
1
Introduce logical flows in ovn router pipeline in order to parse dhcpv6
advertise/reply from IPv6 prefix delegation router.
Do not overwrite ipv6_ra_pd_list info in options column of SB port_binding
table written by ovn-controller
Introduce ipv6_prefix column in NB Logical_router_port table to
Introduce IPv6 Prefix delegation state machine according to RFC 3633
https://tools.ietf.org/html/rfc3633.
Add handle_dhcpv6_reply controller action to parse advertise/reply from
IPv6 delegation server.
Introduce logical flows in ovn router pipeline in order to parse dhcpv6
advertise/reply from
Introduce IPv6 Prefix delegation state machine according to RFC 3633
https://tools.ietf.org/html/rfc3633.
Add handle_dhcpv6_reply controller action to parse advertise/reply from
IPv6 delegation server. Advertise/reply are parsed running respectively:
- pinctrl_parse_dhcv6_advt
-
On 3/5/20 12:28 PM, Dumitru Ceara wrote:
> When a new conntrack zone is entered, the ct_state field is zeroed in
> order to avoid using state information from different zones.
>
> One such scenario is when a packet is double NATed. Assuming two zones
> and 3 flows performing the following actions
Ilya, raw socket for the interface type of which is "system" has been set to
non-block mode, can you explain which syscall will lead to sleep? Yes, pmd
thread will consume CPU resource even if it has nothing to do, but all the
type=dpdk ports are handled by pmd thread, here we just let system
On 3/18/20 12:12 AM, William Tu wrote:
> Coverity CID 279957 reports NULL pointer derefence when
> 'conn' is NULL and calling ct_print_conn_info.
>
> Cc: Usman Ansari
> Signed-off-by: William Tu
> ---
> lib/conntrack.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On 3/18/20 10:02 AM, yang_y...@163.com wrote:
> From: Yi Yang
>
> We can avoid high system call overhead by using TPACKET_V3
> and using DPDK-like poll to receive and send packets (Note: send
> still needs to call sendto to trigger final packet transmission).
>
> From Linux kernel 3.10 on,
From: Yi Yang
We can avoid high system call overhead by using TPACKET_V3
and using DPDK-like poll to receive and send packets (Note: send
still needs to call sendto to trigger final packet transmission).
>From Linux kernel 3.10 on, TPACKET_V3 has been supported,
so all the Linux kernels current
53 matches
Mail list logo
