Re: [ovs-dev] Does anybody know how we can work around NORMAL action limitation about vlan?

2021-08-05 Thread Numan Siddique
On Thu, Aug 5, 2021 at 6:26 PM Yi Yang (杨燚)-云服务集团 wrote: > > Hi, folks > > > > I’m changing Openstack Neutron to use openflow-based pipeline to implement > qrouter and floating IP, everything is ok when two VMs (which are in two > different compute nodes and two subnets but same network, so

[ovs-dev] Does anybody know how we can work around NORMAL action limitation about vlan?

2021-08-05 Thread 杨燚
Hi, folks I’m changing Openstack Neutron to use openflow-based pipeline to implement qrouter and floating IP, everything is ok when two VMs (which are in two different compute nodes and two subnets but same network, so vlan tag is same), but NORMAL action will drop packets if they are on

[ovs-dev] [PATCH] netlink-socket: Log extack error messages in netlink transactions.

2021-08-05 Thread Paolo Valerio
During a netlink transaction, in case of replies of type NLMSG_ERROR, the current behavior includes the translation of the error number received into a string that describes the error code. Netlink replies may carry a more descriptive error message, and although it is possible to read those

Re: [ovs-dev] [PATCH ovn 2/2] ovn-sb: Fix documentation errors in Port_Binding table

2021-08-05 Thread Numan Siddique
On Thu, Aug 5, 2021 at 9:09 AM Mark Gray wrote: > > * The "mac" column may also contain IP addresses. > * Logical router ports and logical switch ports must not > share names. > > Signed-off-by: Mark Gray Thanks for fixing the documentation errors. As this patch is independent of the first

Re: [ovs-dev] [PATCH ovn 1/2] lflow: Refactor OpenFlow hairpin flows

2021-08-05 Thread Numan Siddique
On Thu, Aug 5, 2021 at 9:09 AM Mark Gray wrote: > > Currently, ovn-controller generates N x V OpenFlow > hairpin flows where: > > N = number of datapaths > V = number of LB VIPs > > In a scale setup with 120 nodes, 15k VIPs, and 3 Protocols, > this can generate 5.4M OpenFlows in the

Re: [ovs-dev] [PATCH ovn] northd: do not configure ECMP routes with wrong next-hop

2021-08-05 Thread Numan Siddique
On Mon, Aug 2, 2021 at 6:59 AM Lorenzo Bianconi wrote: > > Check if the nexthop is reachable using router interfaces configuring > ECMP routes. DDlog northd implementation is already checking the > condition above. > > https://bugzilla.redhat.com/show_bug.cgi?id=1978796 > > Signed-off-by: Lorenzo

Re: [ovs-dev] [PATCH] ovsdb: transaction-forward: Fix initialization of the 'sent' hmap node.

2021-08-05 Thread Ilya Maximets
On 8/5/21 4:30 PM, Mark Gray wrote: > On 05/08/2021 13:57, Ilya Maximets wrote: >> 'sent_node' is initialized to all zeroes by xzalloc(), but >> HMAP_NODE_NULL is not all zeroes. hmap_node_is_null() is used >> to detect if the node is valid, but it will fail and cause >> segmentation fault on

Re: [ovs-dev] [PATCH v5 2/2] dpctl: dpif: allow viewing and configuring dp cache sizes

2021-08-05 Thread Paolo Valerio
Eelco Chaudron writes: > This patch adds a general way of viewing/configuring datapath > cache sizes. With an implementation for the netlink interface. > > The ovs-dpctl/ovs-appctl show commands will display the > current cache sizes configured: > > ovs-dpctl show > system@ovs-system: >

Re: [ovs-dev] [PATCH v5 1/2] dpctl: dpif: add kernel datapath cache hit output

2021-08-05 Thread Paolo Valerio
Eelco Chaudron writes: > This patch adds cache usage statistics to the output: > > $ ovs-dpctl show > system@ovs-system: > lookups: hit:24 missed:71 lost:0 > flows: 0 > masks: hit:334 total:0 hit/pkt:3.52 > cache: hit:4 hit rate:4.21% > port 0: ovs-system (internal) > port 1:

[ovs-dev] ovn-21.09 Soft Freeze

2021-08-05 Thread Mark Michelson
Hello, I was having a look at the calendar and realized that tomorrow (6 August) is our scheduled soft freeze date for OVN 21.09. Since I did a poor job of notifying people about this, I think it is OK for us to extend the soft freeze by one week. So soft freeze for OVN 21.09 will be 13

Re: [ovs-dev] [PATCH ovn] system-test: Fix "2 LSs IGMP and MLD"

2021-08-05 Thread Numan Siddique
On Thu, Aug 5, 2021 at 11:15 AM Mark Gray wrote: > > On 04/08/2021 10:30, Xavier Simonart wrote: > > When ADD_NAMESPACES or ADD_VETH were executed with variables > > within the arguments (e.g. ADD_NAMESPACES(sw1-p$i)), the macros were > > not expanded properly, resulting in bad on_exit calls. > >

[ovs-dev] [ovn] Need advice for multiple routing tables support in LR

2021-08-05 Thread Vladislav Odintsov
Hi, I’m trying to implement multiple routing tables support for Logical Routers and met some difficulties, need help/advice. How I see it can be used by administrators: 1. In LRP’s options field is added key route_table with the routing table’s name - any string. 2. When adding new logical

Re: [ovs-dev] [PATCH ovn v2 1/2] ovn-northd: Match outport for lflows in ROUTER_IN_LARGER_PKTS.

2021-08-05 Thread Lorenzo Bianconi
> The commit 1c9e46ab5 removed the outport match from the lflows, which > leads to a problem for gateway routers that have multiple ports > configured with different MTUs. For example, R0 has port P1, P2 and P3. > P2 and P3 both have gateway_mtu configured: P2 mtu = 1400, P3 mtu = 1500. > Below

Re: [ovs-dev] [PATCH v6 2/2] Minimize the number of time calls in time_poll()

2021-08-05 Thread Gaëtan Rivet
On Thu, Aug 5, 2021, at 15:53, anton.iva...@cambridgegreys.com wrote: > From: Anton Ivanov > > time_poll() makes an excessive number of time_msec() calls > which incur a performance penalty. > > 1. Avoid time_msec() call for timeout calculation when time_poll() > is asked to skip poll() > > 2.

Re: [ovs-dev] [PATCH v6 1/2] Optimize the poll loop for poll_immediate_wake()

2021-08-05 Thread Gaëtan Rivet
On Thu, Aug 5, 2021, at 15:53, anton.iva...@cambridgegreys.com wrote: > From: Anton Ivanov > > If we are not obtaining any useful information out of the poll(), > such as is a fd busy or not, we do not need to do a poll() if > an immediate_wake() has been requested. > > This cuts out all the

Re: [ovs-dev] [PATCH v7 ovn 3/3] northd: add check_pkt_larger lflows for ingress traffic

2021-08-05 Thread Han Zhou
On Wed, Aug 4, 2021 at 1:30 AM Lorenzo Bianconi wrote: > > [...] > > > > I think REGBIT_EGRESS_LOOPBACK check is required so that the injected icmp4 > > packet generated from ovn-controller is skipped in this stage. > > Otherwise there will > > be recursion of the packet. > > > > @Lorenzo

Re: [ovs-dev] [PATCH v4 1/2] ovs-save: Save igmp flows in ofp_parse syntax

2021-08-05 Thread Salvatore Daniele
Good point, OVS is unable to parse them. I don't see anywhere in the OVS code that relies on these fields being printed. I could replace them with the default 'tp_src/dst' in this workaround, so as not to break any scripts. That being said, I am not sure how these fields would currently even end

Re: [ovs-dev] [PATCH ovn] ovn-northd: Multiple distributed gateway port support.

2021-08-05 Thread Han Zhou
On Tue, Aug 3, 2021 at 10:59 AM Numan Siddique wrote: > > On Tue, Aug 3, 2021 at 1:55 PM Han Zhou wrote: > > > > On Tue, Aug 3, 2021 at 10:14 AM Numan Siddique wrote: > > > > > > On Thu, Jul 29, 2021 at 4:03 AM Han Zhou wrote: > > > > > > > > From: Ankur Sharma > > > > > > > > By default, OVN

Re: [ovs-dev] [PATCH ovn v3 1/2] system-ovn.at: Fix flaky "load-balancing" test.

2021-08-05 Thread Numan Siddique
On Thu, Aug 5, 2021 at 10:55 AM Mark Gray wrote: > > On 04/08/2021 09:59, Xavier Simonart wrote: > > When running load-balancing test, tcpdump is executed in background. > > When the backround tcpdump stops, it sends to stderr a message > > (such as number of packets captured) which might be

Re: [ovs-dev] [PATCH ovn 2/2] controller: ipv6_pd: properly update ipv6_ra_pd_list pb option in sb db

2021-08-05 Thread Mark Gray
On 28/07/2021 18:58, Lorenzo Bianconi wrote: > Clear ipv6_ra_pd_list option in port_binding option column in order to > properly update IPv6 prefix info. > > https://bugzilla.redhat.com/show_bug.cgi?id=1983862 > > Fixes: e3a398e914 ("controller: Add ipv6 prefix delegation state machine") >

Re: [ovs-dev] [PATCH ovn 1/2] controller: add ipv6_pd debug messages

2021-08-05 Thread Mark Gray
On 28/07/2021 18:58, Lorenzo Bianconi wrote: > Introduce some log messages in IPv6 Prefix delegation processing useful > for debugging > > Signed-off-by: Lorenzo Bianconi > --- > controller/pinctrl.c | 25 - > 1 file changed, 24 insertions(+), 1 deletion(-) > > diff

[ovs-dev] [PATCH ovn v2 2/2] ovn-northd: Multiple distributed gateway port support.

2021-08-05 Thread Han Zhou
From: Ankur Sharma By default, OVN support only one DGP (distributed gateway port) per logical router. While a single DGP port suffices for most of the North South connectivity, there are requirements where a logical router could be connected to multiple external networks and based on routing

[ovs-dev] [PATCH ovn v2 1/2] ovn-northd: Match outport for lflows in ROUTER_IN_LARGER_PKTS.

2021-08-05 Thread Han Zhou
The commit 1c9e46ab5 removed the outport match from the lflows, which leads to a problem for gateway routers that have multiple ports configured with different MTUs. For example, R0 has port P1, P2 and P3. P2 and P3 both have gateway_mtu configured: P2 mtu = 1400, P3 mtu = 1500. Below lflows are

[ovs-dev] [PATCH ovn v2 0/2] Multiple distributed gateway port support.

2021-08-05 Thread Han Zhou
V2: - Converted to a series and added patch-1 that fixes a problem of an upstream commit, which was found during rebasing. - Rebased on upstream. - Addressed comments of V1 from Numan. Ankur Sharma (1): ovn-northd: Multiple distributed gateway port support. Han Zhou (1): ovn-northd: Match

Re: [ovs-dev] [PATCH ovn] system-test: Fix "2 LSs IGMP and MLD"

2021-08-05 Thread Mark Gray
On 04/08/2021 10:30, Xavier Simonart wrote: > When ADD_NAMESPACES or ADD_VETH were executed with variables > within the arguments (e.g. ADD_NAMESPACES(sw1-p$i)), the macros were > not expanded properly, resulting in bad on_exit calls. > This caused multiples tests (e.g. 2 LSs IGMP and MLD) to be

Re: [ovs-dev] [PATCH ovn v3 2/2] system-ovn.at: Fix flaky "load-balancing" test (all servers targetted).

2021-08-05 Thread Mark Gray
On 04/08/2021 10:01, Xavier Simonart wrote: > This test sends requests to LB and checks that each server receives at > least one request. However, even if 20 requests are sent to 3 servers, > there was a possibility that one server did not get any request (0.3%). Could you add a link to a failing

Re: [ovs-dev] [PATCH ovn v3 1/2] system-ovn.at: Fix flaky "load-balancing" test.

2021-08-05 Thread Mark Gray
On 04/08/2021 09:59, Xavier Simonart wrote: > When running load-balancing test, tcpdump is executed in background. > When the backround tcpdump stops, it sends to stderr a message > (such as number of packets captured) which might be catched by the > following command (wget) causing the test to

[ovs-dev] [RFC PATCH ovn 6/6] binding: Consider plugging of ports on CMS request

2021-08-05 Thread Frode Nordahl
When OVN is linked with an appropriate plugging implementation, CMS can request OVN to plug individual lports into the local Open vSwitch instance. The port and instance record will be maintained during the lifetime of the lport and it will be removed on release of lport. TODO: The functions

[ovs-dev] [RFC PATCH ovn 5/6] controller: Add port by interfaces index

2021-08-05 Thread Frode Nordahl
To be able to effectively remove ports previously plugged by us we need to look up ports by interface records. Signed-off-by: Frode Nordahl --- controller/ovn-controller.c | 13 + 1 file changed, 13 insertions(+) diff --git a/controller/ovn-controller.c

[ovs-dev] [RFC PATCH ovn 4/6] lib: Add infrastructure for plugging providers

2021-08-05 Thread Frode Nordahl
This module contains the infrastructure for registering and instantiating plugging classes which may be hosted inside or outside the core OVN repository. The data structures and functions for interacting with these plugging classes also live here. Signed-off-by: Frode Nordahl ---

[ovs-dev] [RFC PATCH ovn 2/6] lib: Move OVS port functions to ovsport module

2021-08-05 Thread Frode Nordahl
Up until now the controller patch module has been the only consumer of functions to maintain OVS ports and interfaces. With the introduction of infrastructure for plugging providers these functions will also be consumed by the controller binding module. As such we introduce a new module called

[ovs-dev] [RFC PATCH ovn 3/6] patch: Consume ovsport functions

2021-08-05 Thread Frode Nordahl
Make use of the common functions for maintaining OVS ports. Signed-off-by: Frode Nordahl --- controller/patch.c | 39 ++- 1 file changed, 6 insertions(+), 33 deletions(-) diff --git a/controller/patch.c b/controller/patch.c index a661025da..b26e93e53 100644

[ovs-dev] [RFC PATCH ovn 1/6] ovn-sb: Add plugged_by column to Port_Binding.

2021-08-05 Thread Frode Nordahl
ovn-northd will fill this column with UUID of Chassis referenced in Logical_Switch_Port options:requested-chassis when options:plug-type is defined. Signed-off-by: Frode Nordahl --- northd/ovn-northd.c | 31 +++ ovn-nb.xml | 38

[ovs-dev] [RFC PATCH ovn 0/6] Introduce infrastructure for plugging providers

2021-08-05 Thread Frode Nordahl
This RFC series is in response to the discussion in a previous RFC patch [0]. Further work is detailed in TODOs in some of the commit messages as well as completing unit- and functional- tests and extending the build system to allow adding external plug library at build time. Please have a look

Re: [ovs-dev] [PATCH] ovsdb: transaction-forward: Fix initialization of the 'sent' hmap node.

2021-08-05 Thread Mark Gray
On 05/08/2021 13:57, Ilya Maximets wrote: > 'sent_node' is initialized to all zeroes by xzalloc(), but > HMAP_NODE_NULL is not all zeroes. hmap_node_is_null() is used > to detect if the node is valid, but it will fail and cause > segmentation fault on attempt to remove the non-existent node >

[ovs-dev] [PATCH v6 1/2] Optimize the poll loop for poll_immediate_wake()

2021-08-05 Thread anton . ivanov
From: Anton Ivanov If we are not obtaining any useful information out of the poll(), such as is a fd busy or not, we do not need to do a poll() if an immediate_wake() has been requested. This cuts out all the pollfd hash additions, forming the poll arguments and the actual poll() after a call

[ovs-dev] [PATCH v6 2/2] Minimize the number of time calls in time_poll()

2021-08-05 Thread anton . ivanov
From: Anton Ivanov time_poll() makes an excessive number of time_msec() calls which incur a performance penalty. 1. Avoid time_msec() call for timeout calculation when time_poll() is asked to skip poll() 2. Reuse the time_msec() result from deadline calculation for last_wakeup and timeout

[ovs-dev] [PATCH ovn 2/2] ovn-sb: Fix documentation errors in Port_Binding table

2021-08-05 Thread Mark Gray
* The "mac" column may also contain IP addresses. * Logical router ports and logical switch ports must not share names. Signed-off-by: Mark Gray --- ovn-sb.xml | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/ovn-sb.xml b/ovn-sb.xml index

[ovs-dev] [PATCH ovn 1/2] lflow: Refactor OpenFlow hairpin flows

2021-08-05 Thread Mark Gray
Currently, ovn-controller generates N x V OpenFlow hairpin flows where: N = number of datapaths V = number of LB VIPs In a scale setup with 120 nodes, 15k VIPs, and 3 Protocols, this can generate 5.4M OpenFlows in the OFTABLE_CT_SNAT_FOR_VIP table with the following form: table=70,

[ovs-dev] [PATCH] ovsdb: transaction-forward: Fix initialization of the 'sent' hmap node.

2021-08-05 Thread Ilya Maximets
'sent_node' is initialized to all zeroes by xzalloc(), but HMAP_NODE_NULL is not all zeroes. hmap_node_is_null() is used to detect if the node is valid, but it will fail and cause segmentation fault on attempt to remove the non-existent node from the hash map. This can happen if client

Re: [ovs-dev] [PATCH] acinclude: Don't set AVX512-related configuration via CFLAGS.

2021-08-05 Thread Ilya Maximets
On 8/4/21 1:53 PM, Ferriter, Cian wrote: > >> -Original Message- >> From: Ilya Maximets >> Sent: Tuesday 3 August 2021 18:37 >> To: ovs-dev@openvswitch.org; Stokes, Ian >> Cc: Flavio Leitner ; Amber, Kumar >> ; Ferriter, Cian >> ; Van Haaren, Harry ; >> Ilya Maximets >> >> Subject:

Re: [ovs-dev] is vxlan well supported by ovn ?

2021-08-05 Thread longguang.yue
Hi, do you know any infomations about integrating ovs/ovn with evpn/frr. Thanks. At 2021-06-25 00:32:46, "Ihar Hrachyshka" wrote: >It is supported but with a number of limitations. Specifically, the >number of switches, and ports per switch, is limited to 2^11 when >VXLAN is

Re: [ovs-dev] [PATCH] Documentation: Cleanup PMD information.

2021-08-05 Thread Adrian Moreno
On 7/22/21 3:25 PM, Kevin Traynor wrote: > The 'Port/Rx Queue Assigment to PMD Threads' section has > expanded over time and now includes info about stats/commands, > manual pinning and different options for OVS assigning Rxqs to > PMDs. > > Split them into different sections with sub-headings