Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Peng He needs to sign off.
ERROR: Co-author Mike Pattrick needs to sign off.
From: Peng He
ipf_postprocess will emit packets into the datapath pipeline ignoring
the conntrack context, this might casuse weird issues when a packet
batch has less space to hold all the fragments belonging to single
packet.
Given the below ruleest and consider sending a 64K ICMP packet which
Flavio Leitner writes:
> On Wed, Nov 10, 2021 at 11:46:55AM +0100, Paolo Valerio wrote:
>> In case of native tunnel with bfd enabled, if the MAC address of the
>> remote end's interface changes (e.g. because it got rebooted, and the
>> MAC address is allocated dynamically), the BFD session will
In case of native tunnel with bfd enabled, if the MAC address of the
remote end's interface changes (e.g. because it got rebooted, and the
MAC address is allocated dynamically), the BFD session will never be
re-established.
This happens because the local tunnel neigh entry doesn't get updated,
This is a minor issue but visible e.g. when you try to flush the neigh
cache while the ARP flow is still present in the datapath, triggering
the revalidation of the datapath flows which subsequently
refreshes/adds the entry in the cache.
Signed-off-by: Paolo Valerio
Acked-by: Flavio Leitner
---
with the command is now possible to change the aging time of the
cache entries.
For the existing entries the aging time is updated only if the
current expiration is greater than the new one. In any case, the next
refresh will set it to the new value.
This is intended mostly for debugging
Expires is modified in different threads (revalidator, pmd-rx, bfd-tx).
It's better to use atomics for such potentially parallel write.
Signed-off-by: Paolo Valerio
Acked-by: Flavio Leitner
---
v2:
- modified commit description
- added _MS suffix to NEIGH_ENTRY_DEFAULT_IDLE_TIME
- renamed local
v3:
- added _S suffix to NEIGH_ENTRY_MAX_AGING_TIME (patch #2)
- Added Reported-at tag (patch #4)
v2:
- rebased against master
- turned 'ageing' -> 'aging'
- further details of v1 -> v2 respin has been added
to each patch
The series is composed of the following patches:
#1: Expires is
l3redirect_port was removed in 15348b7b8; remove references to it from
comments.
There is a comment in build_gateway_redirect_flows_for_lrouter() that
supersedes the one removed below.
Signed-off-by: James Troup
---
northd/northd.c | 11 ++-
1 file changed, 2 insertions(+), 9
On Fri, Nov 26, 2021 at 7:41 AM Dumitru Ceara wrote:
>
> On 11/23/21 18:37, Vladislav Odintsov wrote:
> > OVN requested-tnl-key VXLAN checks affect tunnel_key in
> > datapath_binding record only on datapath tunnel key assigning.
> > If a dp tnl key was already assigned and VXLAN-enabled chassis
>
On Fri, Nov 26, 2021 at 11:16 AM Dumitru Ceara wrote:
>
> There are various costs (e.g., not being able to perform hardware
> offload in some cases) when using check_pkt_larger() so the CMS
> can now limit the impact by bypassing the packet length checks for
> specific types of traffic (e.g.,
Currently, ovs-ofctl and other associated tools will validate the size
of flow actions. However, there are some code paths that do not validate
the size correctly.
When adding more than 1000 logical switch ports to an OVS bridge in OVN,
OVN will happily create a flow with potentially unlimited
Hi Dumitru, Numan,
I’ve sent a corresponding patch to openvswitch with my findings.
It’d be great if you can take a look on it.
Thanks.
https://patchwork.ozlabs.org/project/openvswitch/patch/20211126205942.9354-1-odiv...@gmail.com/
Regards,
Vladislav Odintsov
> On 21 Sep 2021, at 14:43,
In patch [1] rpl_nf_conntrack_in was backported as static inline
function without do..while loop handling NF_REPEAT error.
In patch [2] rpl_nf_conntrack_in backported function was removed
from compat/include/net/netfilter/nf_conntrack_core.h as an unused.
As a result the do..while loop around
In Tap PMD, file descriptors for rxq and txq are paired by dup(2) [1].
Here, rxq and txq are created for the number of PMD threads +1 each. One
additional fd will be created for keepalive [2]. For example, if the
number of PMD threads is 4, the number of fd is 5 for rxq, 5 for txq, and
1 for
There are various costs (e.g., not being able to perform hardware
offload in some cases) when using check_pkt_larger() so the CMS
can now limit the impact by bypassing the packet length checks for
specific types of traffic (e.g., TCP).
Reported-at:
On Fri, Nov 26, 2021 at 8:22 AM Dumitru Ceara wrote:
>
> On 11/10/21 15:34, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1983111
> > Fixes: dd94f1266ca4("northd: MAC learning: Add logical flows for fdb.")
> > Signed-off-by: Numan
On Fri, Nov 26, 2021 at 8:11 AM Dumitru Ceara wrote:
>
> On 11/9/21 11:11, Frode Nordahl wrote:
> > The Logical Router Port gateway_mtu option is currently only
> > documented together with implementation details in the ovn-northd
> > documentation.
> >
> > As this is CMS API we ought to document
On 11/10/21 15:34, num...@ovn.org wrote:
> From: Numan Siddique
>
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1983111
> Fixes: dd94f1266ca4("northd: MAC learning: Add logical flows for fdb.")
> Signed-off-by: Numan Siddique
> ---
Hi Numan,
This patch needs a minor rebase; with
On 11/9/21 11:11, Frode Nordahl wrote:
> The Logical Router Port gateway_mtu option is currently only
> documented together with implementation details in the ovn-northd
> documentation.
>
> As this is CMS API we ought to document this as part of the OVN
> Northbound Database as well.
>
>
On 11/8/21 10:38, Frode Nordahl wrote:
> The first test case of adding localport without a
> requested-chassis option is invalid as this would make the
> chassis do claim/release thrashing leading to a unpredictable
> test results.
>
> Create the localport in NB DB prior to creating the ports on
On 11/23/21 18:37, Vladislav Odintsov wrote:
> OVN requested-tnl-key VXLAN checks affect tunnel_key in
> datapath_binding record only on datapath tunnel key assigning.
> If a dp tnl key was already assigned and VXLAN-enabled chassis
> is added after that, the value would never be changed.
>
> The
Rows that refer to rows that were inserted in the current IDL run should
only be reparsed if they don't get deleted (become orphan) in the current
IDL run.
Fixes: 7b8aeadd60c8 ("ovsdb-idl: Re-parse backrefs of inserted rows only once.")
Reported-by: Ilya Maximets
Signed-off-by: Dumitru Ceara
On 03/11/2021 16:52, Suneetha Kalahasthi wrote:
FAQ is updated to reflect the latest DPDK for OVS branch 2.13 and 2.14
Signed-off-by: Suneetha Kalahasthi
---
Documentation/faq/releases.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/faq/releases.rst
On 03/11/2021 16:54, Suneetha Kalahasthi wrote:
FAQ is updated to reflect the latest DPDK for OVS branch 2.13 and 2.14
Signed-off-by: Suneetha Kalahasthi
---
Documentation/faq/releases.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/faq/releases.rst
On 03/11/2021 16:57, Suneetha Kalahasthi wrote:
FAQ is updated to reflect the latest DPDK for OVS branch 2.13 and 2.14
Signed-off-by: Suneetha Kalahasthi
---
Documentation/faq/releases.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/faq/releases.rst
On 23/11/2021 09:20, Suneetha Kalahasthi wrote:
Modify ci linux build script to use the latest DPDK stable release 19.11.10.
Modify Documentation to use the latest DPDK stable release 19.11.10.
Update NEWS file to reflect the latest DPDK stable release 19.11.10.
FAQ is updated to reflect the
On 23/11/2021 09:11, Suneetha Kalahasthi wrote:
Modify ci linux build script to use the latest DPDK stable release 19.11.10.
Modify Documentation to use the latest DPDK stable release 19.11.10.
Update NEWS file to reflect the latest DPDK stable release 19.11.10.
FAQ is updated to reflect the
On 11/21/21 00:12, Terry Wilson wrote:
> Add support for monitor_cond_since / update3 to python-ovs to
> allow more efficient reconnections when connecting to clustered
> OVSDB servers.
>
> Signed-off-by: Terry Wilson
> ---
Hi Terry,
Overall the changes look ok to me. I just have a couple of
Hi, folks
Recently we found some weird issues, ovs-vswitchd will crash occasionally when
ovs-ofctl add-br with protocol option if version of ovs command line tools in
neutron agent (which is packaged as k8s pod) is different from the one on the
host, or openflows in br-int can’t work as
30 matches
Mail list logo
