Wed, Jun 08, 2022 at 04:58:27PM CEST, k...@kernel.org wrote:
>On Wed, 8 Jun 2022 10:27:15 +0200 Jiri Pirko wrote:
>> Wed, Jun 08, 2022 at 06:39:55AM CEST, k...@kernel.org wrote:
>> >Netdev reference helpers have a dev_ prefix for historic
>> >reasons. Renaming the old helpers would be too much
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski :
On Tue, 7 Jun 2022 00:11:40 +0200 you wrote:
> If packet headers changed, the cached nfct is no longer relevant
> for the packet and attempt to re-use it leads to the incorrect packet
> classification.
>
> This issue
In our profile, the conntrack is the main reason for performance drop.
And when need related functions like lb and acl, we have to carefully check
if other unrelated flows are affected like this patch for multicast traffic
On Wed, 8 Jun 2022 16:58:08 -0600 David Ahern wrote:
> On 6/8/22 8:58 AM, Jakub Kicinski wrote:
> > IMO to encourage use of the track-capable API we could keep their names
> > short and call the legacy functions __netdev_hold() as I mentioned or
> > maybe netdev_hold_notrack().
>
> I like that
> pod -> pod (directly to the other Pod IP) shouldn't go through any load
balancer related flows though, right?
It didn't match the final vip and ct_lb action. But when the lb rule
exists, it will first send all packets to conntrack and lead recirculation
with ovs clone and it hurts the
Hi Ivan,
>-Original Message-
>From: Ivan Malov
>Sent: Wednesday, June 8, 2022 10:02 PM
>To: Eli Britstein
>Cc: d...@openvswitch.org; Andrew Rybchenko
>; Ilya Maximets ;
>Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL)
>; Stephen Hemminger
>; David Marchand
>; Gaetan Rivet ; Maxime
Hi Eli,
On Wed, 8 Jun 2022, Eli Britstein wrote:
Hi Ivan,
-Original Message-
From: Ivan Malov
Sent: Wednesday, June 8, 2022 5:46 PM
To: Eli Britstein
Cc: d...@openvswitch.org; Andrew Rybchenko
; Ilya Maximets ;
Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL)
; Stephen Hemminger
;
On Thu, 2022-06-09 at 00:41 +0800, 刘梦馨 wrote:
> > Could you tell roughly how many packets were sent in a single test?
> > Was
> the latency measured for all the UDP packets in average?
>
> Let me describe my test method more clearly. In fact, we only tested
> pod-to-pod performance *not*
lic121 writes:
> If lldp didn't change, we are not supposed to trigger backer
> revalidation.
> Without this patch, bridge_reconfigure() always trigger udpif
> revalidator because of lldp.
>
> Signed-off-by: lic121
> Signed-off-by: Eelco Chaudron
> Co-authored-by: Eelco Chaudron
> ---
LGTM,
lic121 writes:
> lldp_create() malloc memory for lldp->lldpd->g_hardware. lldp_unref
> is supposed to free the memory regardless of hw->h_flags.
>
> Signed-off-by: lic121
> Acked-by: Eelco Chaudron
> ---
> lib/lldp/lldpd.c | 10 +++---
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
>
> Could you tell roughly how many packets were sent in a single test? Was
the latency measured for all the UDP packets in average?
Let me describe my test method more clearly. In fact, we only tested
pod-to-pod performance *not* pod-to-service and then do profile with
flamegraph and find the
On Wed, Jun 8, 2022 at 8:08 AM Numan Siddique wrote:
>
> On Wed, Jun 8, 2022 at 6:34 AM 刘梦馨 wrote:
> >
> > Just give some input about eBPF/XDP support.
> >
> > We used to use OVN L2 LB to replace kube-proxy in Kubernetes, but found
> > that
> > the L2 LB will use conntrack and ovs clone which
Hi Ivan,
>-Original Message-
>From: Ivan Malov
>Sent: Wednesday, June 8, 2022 5:46 PM
>To: Eli Britstein
>Cc: d...@openvswitch.org; Andrew Rybchenko
>; Ilya Maximets ;
>Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL)
>; Stephen Hemminger
>; David Marchand
>; Gaetan Rivet ; Maxime
Sorry, should have included changelog for this revision.
===
v14: introduce clear_tracked_data for activated_ports
v14: don't modify activated_ports node data inside handler
v14: remove unnecessary I-P input dependency
v14: make get_activated_ports track if any new entries were added to a
list
References: <20220608150339.87756-1-svc.ovs-commun...@vmware.com>
Bleep bloop. Greetings ldejing, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters
On Wed, Jun 8, 2022 at 6:34 AM 刘梦馨 wrote:
>
> Just give some input about eBPF/XDP support.
>
> We used to use OVN L2 LB to replace kube-proxy in Kubernetes, but found
> that
> the L2 LB will use conntrack and ovs clone which hurts performance badly.
> The latency
> for 1byte udp packet jumps from
On Wed, Jun 8, 2022 at 1:19 AM Han Zhou wrote:
>
> On Tue, Jun 7, 2022 at 8:20 AM Dumitru Ceara wrote:
> >
> > In large scale scenarios this option hugely reduces the size of the
> > Southbound database positively affecting end to end performance. In
> > such scenarios there's no real reason to
From: ldejing
In this patch, mainly finished some remaining work of previous
patch(53b75e91) about ipv6 conntrack. Tftp with alg mainly
parse the tftp packet (IPv4/IPv6) and create the related
connection. Ftp with alg mainly fixed some bugs in the
IPv4/IPv6. Additionally, this patch includes
Wed, Jun 08, 2022 at 06:39:55AM CEST, k...@kernel.org wrote:
>Netdev reference helpers have a dev_ prefix for historic
>reasons. Renaming the old helpers would be too much churn
Hmm, I think it would be great to eventually rename the rest too in
order to maintain unique prefix for netdev things.
On Wed, 8 Jun 2022 10:27:15 +0200 Jiri Pirko wrote:
> Wed, Jun 08, 2022 at 06:39:55AM CEST, k...@kernel.org wrote:
> >Netdev reference helpers have a dev_ prefix for historic
> >reasons. Renaming the old helpers would be too much churn
>
> Hmm, I think it would be great to eventually rename the
Hi Eli,
On Wed, 8 Jun 2022, Eli Britstein wrote:
Hi Ivan,
-Original Message-
From: Ivan Malov
Sent: Tuesday, June 7, 2022 11:56 PM
To: Eli Britstein
Cc: d...@openvswitch.org; Andrew Rybchenko
; Ilya Maximets ;
Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL)
; Stephen Hemminger
;
Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 135 characters long (recommended limit is 79)
#28 FILE: utilities/ovn-ctl:46:
When checking if ovsdb-server is running, ensure that the binary
we are going to run matches the one actually running with the the
pid that was in our pidfile.
Signed-off-by: Terry Wilson
---
utilities/ovn-ctl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovn-ctl
Since pids can be re-used, it is necessary to check that the
process that is running with a pid matches the one that we expect.
This adds the ability to optionally pass a 'binary' argument to
pidfile_is_running, and if it is passed to match the binary against
/proc/$pid/exe.
Signed-off-by: Terry
On 6/3/22 17:15, Mike Pattrick wrote:
From: Flavio Leitner
This helps to identify when it is about the flags or
the packet itself.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
lib/conntrack.c | 8
lib/dp-packet.c
Just give some input about eBPF/XDP support.
We used to use OVN L2 LB to replace kube-proxy in Kubernetes, but found
that
the L2 LB will use conntrack and ovs clone which hurts performance badly.
The latency
for 1byte udp packet jumps from 18.5us to 25.7us and bandwidth drop from
6Mb/s to
From: Jan Scheurich
Today dpif-netdev considers PMD threads on a non-local NUMA node for automatic
assignment of the rxqs of a port only if there are no local,non-isolated PMDs.
On typical servers with both physical ports on one NUMA node, this often
leaves the PMDs on the other NUMA node
On 6/3/22 17:15, Mike Pattrick wrote:
From: Flavio Leitner
Rename to better represent their flags.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
lib/conntrack.c| 4 ++--
lib/dp-packet.h| 14 +++---
lib/ipf.c |
On 6/3/22 17:15, Mike Pattrick wrote:
From: Flavio Leitner
Rename to dp_packet_ol_tcp_seg, because that is less
redundant and allows other protocols.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
lib/dp-packet.h| 2 +-
Hi Kevin,
Thanks for your feedback. Please find my response inline.
I will be uploading a new version v4 of the patch with comments addressed.
Regards,
Anurag
> -Original Message-
> From: Kevin Traynor
> Sent: Friday, June 3, 2022 9:36 PM
> To: Anurag Agarwal ;
On 6/3/22 17:15, Mike Pattrick wrote:
From: Flavio Leitner
Currently 'p' and 'b' and used for packets, so use
a convention that struct dp_packet is 'p' and
struct dp_packet_batch is 'b'.
Some comments needed new formatting to not pass the
80 column.
Some variables were using 'p' or 'b'
On 6/3/22 17:15, Mike Pattrick wrote:
From: Flavio Leitner
The name correlates better with the flag names.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
lib/conntrack.c| 8
lib/dp-packet.h| 28
On 6/3/22 17:15, Mike Pattrick wrote:
From: Flavio Leitner
Use the 'NETDEV_OFFLOAD_' prefix in the flags to indicate
we are talking about hardware offloading capabilities.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
lib/netdev-dpdk.c
On 6/3/22 17:15, Mike Pattrick wrote:
From: Flavio Leitner
It seems csum is more common and shorter.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
lib/dp-packet.h | 72 +--
lib/netdev-dpdk.c
On 5/31/22 11:33, Mohammad Heib wrote:
> currently ovn ci only has one test case with the option
> ovn-monitor-all enabled, this patch will add one more
> execution with option ovn-monitor-all=true for each test case that
> are wrapped by OVN_FOR_EACH_NORTHD macro.
>
> This will more or less
On 6 Jun 2022, at 9:18, Roi Dayan wrote:
> On 2022-06-03 11:58 AM, Eelco Chaudron wrote:
>> This patch will properly initialize offload, as it requires the
>> setting to be enabled before starting ovs-vswitchd (or do a
>> restart once configured).
>>
>> Signed-off-by: Eelco Chaudron
>> ---
Hi Ivan,
>-Original Message-
>From: Ivan Malov
>Sent: Tuesday, June 7, 2022 11:56 PM
>To: Eli Britstein
>Cc: d...@openvswitch.org; Andrew Rybchenko
>; Ilya Maximets ;
>Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL)
>; Stephen Hemminger
>; David Marchand
>; Gaetan Rivet ; Maxime
On Mon, May 30, 2022 at 5:46 PM wrote:
>
> From: Numan Siddique
>
> XDP program - ovn_xdp.c added in this RFC patch series implements basic
port
> security and drops any packet if the port security check fails.
> There are still few TODOs in the port security checks. Like
> - Make ovn xdp
38 matches
Mail list logo
