From: ldejing
This patch implemented meter action, currently, meter only support drop
method and only support one band. The overall implementation is, when a
packet comes in, it will first lookup meter according to the meter id,
then get the band->rates and delta time since last access the same
When multiple chassis are fighting for the same port (requested-chassis
is not set, e.g. for gateway ports), they may produce an unreasonable
number of chassis field updates in a very short time frame (hundreds of
updates in several seconds). This puts unnecessary load on OVN as well
as any db
This function will later be used to handle port binding updates for
postponed (throttled) bindings.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c | 250 ++-
1 file changed, 130 insertions(+), 120 deletions(-)
diff --git a/controller/binding.c
Bleep bloop. Greetings Ihar Hrachyshka, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch' to see the
When multiple chassis are fighting for the same port (requested-chassis
is not set, e.g. for gateway ports), they may produce an unreasonable
number of chassis field updates in a very short time frame (hundreds of
updates in several seconds). This puts unnecessary load on OVN as well
as any db
This function will later be used to handle port binding updates for
postponed (throttled) bindings.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c | 248 ++-
1 file changed, 129 insertions(+), 119 deletions(-)
diff --git a/controller/binding.c
On 7/11/22 20:12, Ilya Maximets wrote:
> On 7/7/22 19:42, Frode Nordahl wrote:
>> diff --git a/debian/control b/debian/control
>> new file mode 100644
>> index 0..7a79d1ff0
>> --- /dev/null
>> +++ b/debian/control
>> @@ -0,0 +1,298 @@
>> +Source: openvswitch
>> +Section: net
>> +Priority:
On Wed, Jul 6, 2022 at 11:00 PM David Marchand
wrote:
>
> On Fri, Jul 1, 2022 at 5:58 AM Mike Pattrick wrote:
> >
> > From: Flavio Leitner
> >
> > Now that there is a segmentation in software as a fall back in
> > case a netdev doesn't support TCP segmentation offloading (TSO),
> > enable it by
Hello,
Maxime, Ilya, your opinion will probably help.
On Wed, Jul 6, 2022 at 10:59 PM David Marchand
wrote:
> > @@ -5088,19 +5117,22 @@ netdev_dpdk_vhost_client_reconfigure(struct netdev
> > *netdev)
> > goto unlock;
> > }
> >
> > +vhost_unsup_flags = 1ULL <<
Thanks Dumitru,
Acked-by: Mark Michelson
Since this is such a small thing. I've gone ahead and merged this to
main, branch-22.03, branch-22.06, branch-21.12.
On 7/11/22 07:30, Dumitru Ceara wrote:
Reported-by: Lucas Alvares Gomes
Signed-off-by: Dumitru Ceara
---
ovn-nb.xml | 8 +++-
Paolo Valerio writes:
> From: Ilya Maximets
>
> This could save some costly key comparison miss, especially in the
> case there are many expired connections waiting for the sweeper to
> evict them.
>
> Signed-off-by: Ilya Maximets
> Signed-off-by: Paolo Valerio
> ---
Acked-by: Aaron Conole
Paolo Valerio writes:
> From: Gaetan Rivet
>
> A lock is taken during conn_lookup() to check whether a connection is
> expired before returning it. This lock can have some contention.
>
> Even though this lock ensures a consistent sequence of writes, it does
> not imply a specific order. A
Paolo Valerio writes:
> From: Gaetan Rivet
>
> This patch aims to replace the expiration lists as, due to the way
> they are used, besides being a source of contention, they have a known
> issue when used with non-default policies for different zones that
> could lead to retaining expired
Paolo Valerio writes:
> From: Gaetan Rivet
>
> Multiple lookups are done to stored timeout policies, each time blocking
> the global 'ct_lock'. This is usually not necessary and it should be
> acceptable to get policy updates slightly delayed (by one RCU sync
> at most). Using a CMAP reduces
Paolo Valerio writes:
> From: Gaetan Rivet
>
> Change the data structure from hmap to cmap for zone limits.
> As they are shared amongst multiple conntrack users, multiple
> readers want to check the current zone limit state before progressing in
> their processing. Using a CMAP allows doing
On Fri, Jul 8, 2022 at 2:45 AM Ales Musil wrote:
>
> When the lrp-set-gateway-chassis was followed by chained
> command (--) the command tried to parse -- as priority
> when the priority was not specified.
>
> Check if the command argument count is actually 4
> instead of checking argv[3].
>
>
On Mon, Jul 11, 2022 at 1:45 PM Dumitru Ceara wrote:
>
> On 7/11/22 19:55, Numan Siddique wrote:
> > On Mon, Jul 11, 2022 at 6:16 AM Ales Musil wrote:
> >>
> >> Hi Igor,
> >>
> >> thank you for the patch. Yeah I was not quick enough to reply on the PR :)
> >>
> >> Acked-by: Ales Musil
> >
> >
On 7/11/22 20:27, Ilya Maximets wrote:
> On 7/7/22 19:42, Frode Nordahl wrote:
>> The recipe for inserting authors from AUTHORS.rst is wrong.
>>
>> Fixes: 3deca69b08f2 ("doc: Convert AUTHORS to rST")
>> Signed-off-by: Frode Nordahl
>> ---
>> debian/automake.mk | 4 ++--
>> 1 file changed, 2
On 7/11/22 19:55, Numan Siddique wrote:
> On Mon, Jul 11, 2022 at 6:16 AM Ales Musil wrote:
>>
>> Hi Igor,
>>
>> thank you for the patch. Yeah I was not quick enough to reply on the PR :)
>>
>> Acked-by: Ales Musil
>
> Thanks for the patch.
>
> Can you please split this patch into 2 patches.
>
Hi Kevin,
Responses inline.
> > > +static struct user_mempool_config *user_mempools = NULL; static int
> > > +n_user_mempools;
> >
> > Should we consider restricting n_user_mempools to some max value ?
> >
>
> We could do. There is no issue with having many values, it just might not
> make
On 7/7/22 19:42, Frode Nordahl wrote:
> The recipe for inserting authors from AUTHORS.rst is wrong.
>
> Fixes: 3deca69b08f2 ("doc: Convert AUTHORS to rST")
> Signed-off-by: Frode Nordahl
> ---
> debian/automake.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
On Mon, Jul 11, 2022 at 6:16 AM Ales Musil wrote:
>
> Hi Igor,
>
> thank you for the patch. Yeah I was not quick enough to reply on the PR :)
>
> Acked-by: Ales Musil
Thanks for the patch.
Can you please split this patch into 2 patches.
Patch 1 to fix the memory leak in utilities/ovn-dbctl.c
On Fri, Jul 8, 2022 at 10:18 PM Pai G, Sunil wrote:
>
> Hi Kevin,
>
Hi Sunil,
thanks for reviewing the patches.
> Thanks for the patch.
> LGTM in general, couple of minor comments/thoughts inline.
>
>
>
> > +struct user_mempool_config {
> > +int adj_mtu;
> > +int socket_id;
> > +};
>
On 7/9/2022 12:31 AM, David Marchand wrote:
On Fri, Jul 8, 2022 at 10:09 PM Greg Rose wrote:
diff --git a/Documentation/internals/contributing/backporting-patches.rst
b/Documentation/internals/contributing/backporting-patches.rst
index 162e9d209..8370c954d 100644
---
On Mon, Jul 11, 2022 at 4:35 AM Dumitru Ceara wrote:
>
> On 7/11/22 11:23, Igor Zhukov wrote:
> > From: Igor Zhukov
> >
> > Signed-off-by: Igor Zhukov
> > Acked-by: Dumitru Ceara
> > ---
Thanks for the fix. I applied this patch to the main branch. I also
added your name to the AUTHORS.rst
On 7/9/2022 12:27 AM, David Marchand wrote:
On Fri, Jul 8, 2022 at 10:10 PM Greg Rose wrote:
Since the openvswitch project inception it has had support for building
a Linux kernel module to support the OVS kernel datapath. Since Linux
kernel release 5.8 support for newer kernels has been
On 7/9/2022 12:23 AM, David Marchand wrote:
On Fri, Jul 8, 2022 at 10:05 PM Greg Rose wrote:
The OVS kernel module is no longer supported as of OVS 2.18
Signed-off-by: Greg Rose
This leaves behind some reference in the documentation.
WDYT of:
diff --git
On 7/9/2022 12:20 AM, David Marchand wrote:
On Fri, Jul 8, 2022 at 10:11 PM Greg Rose wrote:
Update the necessary make and configure files to remove the Linux
datapath and then remove the datapath.
Move datapath/linux/compat/include/linux/openvswitch.h to
include/linux/openvswitch.h
On 7/9/2022 12:09 AM, David Marchand wrote:
On Fri, Jul 8, 2022 at 10:29 PM Gregory Rose wrote:
On 7/8/2022 1:03 PM, Greg Rose wrote:
Remove references to the Linux datapath from auxiliary files and
utilities since it is no longer supported.
Signed-off-by: Greg Rose
---
On 7/9/2022 12:02 AM, David Marchand wrote:
On Fri, Jul 8, 2022 at 10:04 PM Greg Rose wrote:
Remove the kernel driver specification for RHEL 6.x, 7.x, 8.x and Fedora.
Signed-off-by: Greg Rose
---
Documentation/intro/install/rhel.rst | 18
Vagrantfile |
On 7/8/2022 11:26 PM, David Marchand wrote:
On Fri, Jul 8, 2022 at 10:06 PM Greg Rose wrote:
Remove kernel based github workflows since the OVS kernel driver is
no longer supported since Release 2.18
I won't comment on the debian parts, those are handled by Frode series.
This patch
Bleep bloop. Greetings Paolo Valerio, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
Bleep bloop. Greetings Paolo Valerio, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
Bleep bloop. Greetings Paolo Valerio, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
Bleep bloop. Greetings Paolo Valerio, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
From: Ilya Maximets
This could save some costly key comparison miss, especially in the
case there are many expired connections waiting for the sweeper to
evict them.
Signed-off-by: Ilya Maximets
Signed-off-by: Paolo Valerio
---
lib/conntrack.c |7 +--
1 file changed, 5 insertions(+),
From: Gaetan Rivet
A lock is taken during conn_lookup() to check whether a connection is
expired before returning it. This lock can have some contention.
Even though this lock ensures a consistent sequence of writes, it does
not imply a specific order. A ct_clean thread taking the lock first
From: Gaetan Rivet
This patch aims to replace the expiration lists as, due to the way
they are used, besides being a source of contention, they have a known
issue when used with non-default policies for different zones that
could lead to retaining expired connections potentially for a long
time.
From: Gaetan Rivet
Multiple lookups are done to stored timeout policies, each time blocking
the global 'ct_lock'. This is usually not necessary and it should be
acceptable to get policy updates slightly delayed (by one RCU sync
at most). Using a CMAP reduces multiple lock taking and releasing in
From: Gaetan Rivet
Change the data structure from hmap to cmap for zone limits.
As they are shared amongst multiple conntrack users, multiple
readers want to check the current zone limit state before progressing in
their processing. Using a CMAP allows doing lookups without taking the
global
This series aims to address the issues present in the previous versions.
The end result is a different approach, using different data structure,
but it solves the multiple issues observed in v4 and the problems that
affected the baseline.
The tests (similar to the ones previously performed by
On Wed, Jun 29, 2022 at 3:06 PM Mark Michelson wrote:
>
> Wow, nice improvement, Ihar!
>
> Acked-by: Mark Michelson
Thanks. I applied this patch to the main branch.
Numan
>
> On 6/29/22 12:47, Ihar Hrachyshka wrote:
> > Signed-off-by: Ihar Hrachyshka
> > ---
> > controller/binding.c | 63
Bleep bloop. Greetings Kevin Sprague, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line has trailing whitespace
#656 FILE: utilities/usdt-scripts/watch_flows.bt:83:
During normal operations, it is useful to understand when a particular flow
gets removed from the system. This can be useful when debugging performance
issues tied to ofproto flow changes, trying to determine deployed traffic
patterns, or while debugging dynamic systems where ports come and go.
On 7/1/22 17:45, Ilya Maximets wrote:
> On 7/1/22 17:31, Dumitru Ceara wrote:
>> On 7/1/22 01:34, Ilya Maximets wrote:
>>> Conversion of the database data into JSON object, serialization
>>> and destruction of that object are the most heavy operations
>>> during the database compaction. If these
On 7/1/22 01:34, Ilya Maximets wrote:
> Conversion of the database data into JSON object, serialization
> and destruction of that object are the most heavy operations
> during the database compaction. If these operations are moved
> to a separate thread, the main thread can continue processing
>
On 7/1/22 17:36, Dumitru Ceara wrote:
> On 7/1/22 17:32, Ilya Maximets wrote:
>>> This doesn't look right, we can have:
>>>
>>> datum = ovsdb_datum_default(TYPE); /* refcnt = 1 */
>>> ovsdb_datum_clone(datum, clone);/* refcnt = 2 */
>>> datum2 = ovsdb_datum_default(TYPE); /* refcnt = 1 */
>>
On Fri, Jul 8, 2022 at 9:22 AM Ihar Hrachyshka wrote:
>
> On Thu, Jul 7, 2022 at 4:39 PM Numan Siddique wrote:
> >
> > On Fri, Jul 1, 2022 at 1:52 PM Mark Michelson wrote:
> > >
> > > Looks good to me. Thanks, Ihar.
> > >
> > > Acked-by: Mark Michelson
> > >
> > > On 6/24/22 18:35, Ihar
> -Original Message-
> From: Ilya Maximets
> Sent: Monday 11 July 2022 10:48
> To: Finn, Emma ; Eelco Chaudron
>
> Cc: i.maxim...@ovn.org; d...@openvswitch.org; Van Haaren, Harry
> ; Amber, Kumar ;
> Stokes, Ian
> Subject: Re: [v8 00/10] Actions Infrastructure + Optimizations
>
> On
Hi Mike,
Thanks for reworking the tests.
One minor nit inline, otherwise patch LGTM,
> -Original Message-
> From: Phelan, Michael
> Sent: Monday, July 11, 2022 7:19 PM
> To: d...@openvswitch.org
> Cc: Stokes, Ian ; acon...@redhat.com;
> i.maxim...@ovn.org; maxime.coque...@redhat.com;
This adds 8 new unit tests to the 'check-dpdk' subsystem that will
test Maximum Transmission Unit (MTU) functionality.
Signed-off-by: Michael Phelan
Signed-off-by: Sunil Pai G
Co-authored-by: Sunil Pai G
---
v3:
- Capitalize first letter in comments.
- Add [] in AT_CHECK commands.
-
On Wed, Jun 29, 2022 at 11:31 AM Timothy Redaelli wrote:
>
> On Python 3.12, distutils will be removed and it's currently (3.10+)
> deprecated (see PEP 632).
>
> Since the suggested and simplest replacement is setuptools, this commit
> replaces distutils to use setuptools instead.
>
> setuptools
On 7/11/22 13:31, Xavier Simonart wrote:
> Hi Han
>
> Thanks for your review.
>
> Let me try to understand your two main concerns and the proper way to fix
> it.
> 1) We only try once to write pb->chassis. If the commit fails, pb->chassis
> is not written. As commit fails, we will recompute, but
Hi Han
Thanks for your review.
Let me try to understand your two main concerns and the proper way to fix
it.
1) We only try once to write pb->chassis. If the commit fails, pb->chassis
is not written. As commit fails, we will recompute, but as the
update_required flag is not set anymore, we might
Reported-by: Lucas Alvares Gomes
Signed-off-by: Dumitru Ceara
---
ovn-nb.xml | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/ovn-nb.xml b/ovn-nb.xml
index 22b7e8779..e26afd83c 100644
--- a/ovn-nb.xml
+++ b/ovn-nb.xml
@@ -603,6 +603,7 @@
Determines whether
Bleep bloop. Greetings Igor Zhukov, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#34 FILE: .ci/linux-build.sh:31:
Hi Igor,
thank you for the patch. Yeah I was not quick enough to reply on the PR :)
Acked-by: Ales Musil
On Mon, Jul 11, 2022 at 1:10 PM Igor Zhukov wrote:
> From: Igor Zhukov
>
> Also fix typo in comments
>
> Also fix memory leak in utilities/ovn-dbctl.c
>
> Also add "-g" to CFLAGS to
From: Igor Zhukov
Also fix typo in comments
Also fix memory leak in utilities/ovn-dbctl.c
Also add "-g" to CFLAGS to forbid autotools from adding "-g -O2" (temporary
solution)
Signed-off-by: Igor Zhukov
Acked-by: Dumitru Ceara
Submitted-at: https://github.com/ovn-org/ovn/pull/139
---
On 11 Jul 2022, at 12:03, Simon Horman wrote:
> On Mon, Jul 11, 2022 at 12:02:12PM +0200, Ilya Maximets wrote:
>> On 7/11/22 11:00, Simon Horman wrote:
>>> On Fri, Jul 08, 2022 at 12:18:21PM +0200, Eelco Chaudron wrote:
On 8 Jul 2022, at 11:55, Jianbo Liu wrote:
> Fow now,
On Mon, Jul 11, 2022 at 12:02:12PM +0200, Ilya Maximets wrote:
> On 7/11/22 11:00, Simon Horman wrote:
> > On Fri, Jul 08, 2022 at 12:18:21PM +0200, Eelco Chaudron wrote:
> >>
> >> On 8 Jul 2022, at 11:55, Jianbo Liu wrote:
> >>
> >>> Fow now, add introduction and the limitation of meter offload.
On 7/11/22 11:00, Simon Horman wrote:
> On Fri, Jul 08, 2022 at 12:18:21PM +0200, Eelco Chaudron wrote:
>>
>> On 8 Jul 2022, at 11:55, Jianbo Liu wrote:
>>
>>> Fow now, add introduction and the limitation of meter offload.
>>
>> Note to whoever commits this patch, can you change the “Fow” above to
You're welcome!
I sent this patch via `git send-email`
:)
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 7/11/22 11:44, Finn, Emma wrote:
>
>
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Friday 8 July 2022 10:53
>> To: Finn, Emma
>> Cc: d...@openvswitch.org; Van Haaren, Harry
>> ; Amber, Kumar ;
>> Stokes, Ian ; i.maxim...@ovn.org
>> Subject: Re: [v8 00/10] Actions
> -Original Message-
> From: Eelco Chaudron
> Sent: Friday 8 July 2022 10:53
> To: Finn, Emma
> Cc: d...@openvswitch.org; Van Haaren, Harry
> ; Amber, Kumar ;
> Stokes, Ian ; i.maxim...@ovn.org
> Subject: Re: [v8 00/10] Actions Infrastructure + Optimizations
>
>
>
> On 7 Jul 2022,
Hi Sunil,
Thanks for taking the time to review, I have left some comments inline.
> -Original Message-
> From: Pai G, Sunil
> Sent: Saturday 9 July 2022 09:50
> To: Phelan, Michael ; d...@openvswitch.org
> Cc: maxime.coque...@redhat.com; i.maxim...@ovn.org
> Subject: RE: [ovs-dev] [PATCH
On 7/11/22 11:23, Igor Zhukov wrote:
> From: Igor Zhukov
>
> Signed-off-by: Igor Zhukov
> Acked-by: Dumitru Ceara
> ---
This patch looks good to me and it applies fine.
Thanks!
___
dev mailing list
d...@openvswitch.org
From: Igor Zhukov
Signed-off-by: Igor Zhukov
Acked-by: Dumitru Ceara
---
tests/system-ovn.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index 1cabf1f31..4a8fdede8 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@
On Fri, Jul 08, 2022 at 12:18:21PM +0200, Eelco Chaudron wrote:
>
> On 8 Jul 2022, at 11:55, Jianbo Liu wrote:
>
> > Fow now, add introduction and the limitation of meter offload.
>
> Note to whoever commits this patch, can you change the “Fow” above to “For”
Thanks everyone. I'd be happy to
On Mon, Jul 11, 2022 at 8:51 AM Han Zhou wrote:
>
>
>
> On Fri, Jul 1, 2022 at 3:19 AM Ales Musil wrote:
> >
> > Hi,
> >
> > as promised I have more results from testing. The results are available
> on the BZ comment 6 [0].
> >
> > So about the scenario, there were two traffic types being
On Fri, Jul 1, 2022 at 3:19 AM Ales Musil wrote:
>
> Hi,
>
> as promised I have more results from testing. The results are available
on the BZ comment 6 [0].
>
> So about the scenario, there were two traffic types being sent. The
document has TCP latency and throughput, UPD throughput.
> The
On Fri, Jul 8, 2022 at 2:39 AM Ales Musil wrote:
>
> The ovn-controller had a race condition over MAC
> binding table with other controllers. When multiple
> controllers received GARP from single source usually
> the one who was able to win the race put it into SB.
> The others got transaction
71 matches
Mail list logo
