Re: [ovs-dev] [PATCH v2 01/16] slab: Remove __malloc attribute from realloc functions

2022-09-28 Thread Vlastimil Babka
On 9/28/22 19:13, Kees Cook wrote: On Wed, Sep 28, 2022 at 09:26:15AM +0200, Geert Uytterhoeven wrote: Hi Kees, On Fri, Sep 23, 2022 at 10:35 PM Kees Cook wrote: The __malloc attribute should not be applied to "realloc" functions, as the returned pointer may alias the storage of the prior

Re: [ovs-dev] [PATCH ovn v3] northd: Use separate SNAT for already-DNATted traffic.

2022-09-28 Thread Numan Siddique
On Tue, Sep 27, 2022 at 3:02 PM Mark Michelson wrote: > > Commit 4deac4509abbedd6ffaecf27eed01ddefccea40a introduced functionality > in ovn-northd to use a single zone for SNAT and DNAT when possible. It > accounts for certain situations, such as hairpinned traffic, where we > still need a

Re: [ovs-dev] [PATCH v2 01/16] slab: Remove __malloc attribute from realloc functions

2022-09-28 Thread Geert Uytterhoeven
Hi Kees, On Fri, Sep 23, 2022 at 10:35 PM Kees Cook wrote: > The __malloc attribute should not be applied to "realloc" functions, as > the returned pointer may alias the storage of the prior pointer. Instead > of splitting __malloc from __alloc_size, which would be a huge amount of > churn, just

Re: [ovs-dev] [PATCH v2 01/16] slab: Remove __malloc attribute from realloc functions

2022-09-28 Thread Kees Cook
On Wed, Sep 28, 2022 at 09:26:15AM +0200, Geert Uytterhoeven wrote: > Hi Kees, > > On Fri, Sep 23, 2022 at 10:35 PM Kees Cook wrote: > > The __malloc attribute should not be applied to "realloc" functions, as > > the returned pointer may alias the storage of the prior pointer. Instead > > of

Re: [ovs-dev] [ovs-build] |fail| pw1682469 [ovs-dev, dpdk-latest] netdev-dpdk: Report device bus specific information.

2022-09-28 Thread David Marchand
Hello Michael, On Mon, Sep 26, 2022 at 12:07 PM wrote: > > Test-Label: intel-ovs-compilation > Test-Status: fail > http://patchwork.ozlabs.org/api/patches/1682469/ > > AVX-512_compilation: failed > DPLCS Test: fail > DPIF Test: fail > MFEX Test: fail > Errors in DPCLS test: > git-pw patch apply

Re: [ovs-dev] [PATCH v2 01/16] slab: Remove __malloc attribute from realloc functions

2022-09-28 Thread Vlastimil Babka
On 9/28/22 09:26, Geert Uytterhoeven wrote: Hi Kees, On Fri, Sep 23, 2022 at 10:35 PM Kees Cook wrote: The __malloc attribute should not be applied to "realloc" functions, as the returned pointer may alias the storage of the prior pointer. Instead of splitting __malloc from __alloc_size,

[ovs-dev] [PATCH v2 ovn] northd: do not centralize FIP traffic if redirect-type is set to fixed

2022-09-28 Thread Lorenzo Bianconi
Keep FIP traffic distributed and do not centralize it even if the CMS sets redirect-type option to bridged for distributed gateway port. Tested-by: Jianlin Shi Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2007120 Signed-off-by: Lorenzo Bianconi --- Changes since v1: - add unit-test

[ovs-dev] [PATCH ovn v2] ovs: Bump submodule to newer version and add related test

2022-09-28 Thread Xavier Simonart
Specifically for: 02f31a1262fc ("ovsdb-idl: Preserve references for rows deleted in same IDL run as their insertion.") A OVN test case reproducing the bug (issue when port_binding is added/deleted within the same IDL) is also added. Reported-at:

[ovs-dev] [PATCH ovn] ovs: Bump submodule to newer version and add related test

2022-09-28 Thread Xavier Simonart
Specifically for: 360f5b0e197d ("ovsdb-idl: Preserve references for rows deleted in same IDL as their insertion.") A OVN test case reproducing the bug (issue when port_binding is added/deleted within the same IDL) is also added. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2126450

Re: [ovs-dev] [OVN v7] OVN - Add Support for Remote Port Mirroring

2022-09-28 Thread 0-day Robot
Bleep bloop. Greetings Abhiram R N, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #2029 FILE: utilities/ovn-nbctl.c:275:

[ovs-dev] [OVN v7] OVN - Add Support for Remote Port Mirroring

2022-09-28 Thread Abhiram R N
Added changes in ovn-nbctl, ovn-sbctl, northd and in ovn-controller. While Mirror creation just creates the mirror, the lsp-attach-mirror triggers the sequence to create Mirror in OVS DB on compute node. OVS already supports Port Mirroring. Note: This is targeted to mirror to destinations

Re: [ovs-dev] [RFC PATCH ovn 0/5] Add OVN component templates.

2022-09-28 Thread Dumitru Ceara
On 9/23/22 18:18, Han Zhou wrote: > On Fri, Sep 23, 2022 at 8:10 AM Dumitru Ceara wrote: >> >> On 9/22/22 19:55, Han Zhou wrote: >>> On Thu, Sep 22, 2022 at 10:38 AM Han Zhou wrote: On Thu, Sep 22, 2022 at 1:00 AM Dumitru Ceara > wrote: > > Hi Han, > > On

Re: [ovs-dev] [PATCH ovn] northd: do not centralize FIP traffic if redirect-type is set to fixed

2022-09-28 Thread Lorenzo Bianconi
On Sep 20, Mark Michelson wrote: > Hi Lorenzo, Hi Mark, thx for reviewing the patch. > > I have a couple of comments below. In addition, please add a test for this > scenario to the testsuite. > > On 9/19/22 09:22, Lorenzo Bianconi wrote: > > Keep FIP traffic distributed and do not centralize

Re: [ovs-dev] [PATCH] vconn: Allow ECONNREFUSED in refuse connection test

2022-09-28 Thread Eelco Chaudron
On 27 Sep 2022, at 18:04, Mike Pattrick wrote: > The "tcp vconn - refuse connection" test may fail due to a Connection > Refused error. The network stack returns ECONNREFUSED on a reset > connection in SYN_SENT state and EPIPE or ECONNRESET in all other > cases. > >

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: allow sample when no in_port

2022-09-28 Thread Eelco Chaudron
On 27 Sep 2022, at 17:32, Adrian Moreno wrote: > OVN can (and indeed does) set in_port to OFPP_NONE during > the pipeline evaluation. If a sample action follows, it > will be incorrectly skipped. > > Per-flow sampling version of: > f0a9000ca ofproto: Fix ipfix not always sampling on egress. I

Re: [ovs-dev] [PATCH ovn branch-22.03] github: ovn-kubernetes: Update go, kube and libovsdb versions.

2022-09-28 Thread Dumitru Ceara
On 9/26/22 12:59, Dumitru Ceara wrote: > With this they'll match the current upstream ovn-kubernetes code. > > (cherry picked from commit 4a5e20ee58cd012eb52a94ee1c97fe225e4e91f2) > Signed-off-by: Dumitru Ceara > --- > Backporting this patch to the LTS too. Otherwise we can't run ovnkube >

Re: [ovs-dev] [PATCH] controller: Fix first ping from lsp to external through snat failing

2022-09-28 Thread Dumitru Ceara
On 9/27/22 17:16, Xavier Simonart wrote: > Fixes: b89b96e1a16 ("fix potential segmentation violation when removing > ports") > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2130045 > > Signed-off-by: Xavier Simonart > --- Thanks for the quick fix Xavier! I applied this to the main