Re: [ovs-dev] [PATCH v24 1/8] compat: Add psample and tc sample action defines for older kernels

2023-03-14 Thread Chris Mi via dev
On 3/14/2023 4:53 PM, Eelco Chaudron wrote: On 1 Mar 2023, at 8:22, Chris Mi wrote: Update kernel UAPI to support psample and the tc sample action. Signed-off-by: Chris Mi Reviewed-by: Roi Dayan Acked-by: Eelco Chaudron --- include/linux/automake.mk| 4 ++-

Re: [ovs-dev] [PATCH v24 0/8] Add offload support for sFlow

2023-03-14 Thread Chris Mi via dev
On 3/10/2023 10:02 PM, Eelco Chaudron wrote: On 10 Mar 2023, at 13:11, Eelco Chaudron wrote: On 1 Mar 2023, at 8:22, Chris Mi wrote: This patch set adds offload support for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets

[ovs-dev] [PATCH v9] netdev-offload-tc: del ufid mapping if device not exist

2023-03-14 Thread Faicker Mo
The device may be deleted and added with ifindex changed. The tc rules on the device will be deleted if the device is deleted. The func tc_del_filter will fail when flow del. The mapping of ufid to tc will not be deleted. The traffic will trigger the same flow(with same ufid) to put to tc on the

Re: [ovs-dev] Proposal: Move dceara/ovn-heater to ovn-org/ovn-heater?

2023-03-14 Thread Frode Nordahl
Hello, Ben, As part of preparing to move ovn-heater to ovn-org, we thought it would be fun to add a logo. We made one [0] based on your original work as well as third party work under a different license, and while IANAL, I think this means we need to ask your permission to license your original

Re: [ovs-dev] [PATCH v8] netdev-offload-tc: del ufid mapping if device not exist

2023-03-14 Thread Ilya Maximets
On 3/14/23 09:04, Eelco Chaudron wrote: > > > On 14 Mar 2023, at 7:50, Faicker Mo wrote: > >> The error message when test failed, >> >> >>> 2023-03-14T02:41:16.010Z|00077|unixctl|DBG|received request >>> revalidator/purge[], id=0 >>>

Re: [ovs-dev] [PATCH v3] dpdk: Allow retaining CAP_SYS_RAWIO privileges

2023-03-14 Thread Flavio Leitner
On Tue, Mar 14, 2023 at 10:46:02AM -0400, Aaron Conole wrote: > Flavio Leitner writes: > > > On Wed, Mar 08, 2023 at 05:37:11PM -0500, Aaron Conole wrote: > >> Open vSwitch generally tries to let the underlying operating system > >> managed the low level details of hardware, for example DMA

Re: [ovs-dev] [PATCH 1/1] tc: translate mirror/stolen to mirred

2023-03-14 Thread Ilya Maximets
On 3/14/23 12:15, Simon Horman wrote: > On Mon, Mar 13, 2023 at 09:34:30PM +0100, Ilya Maximets wrote: >> On 3/13/23 11:27, Roi Dayan wrote: >>> From: Oz Shlomo >>> >>> Currently jumping over a output-to-port action is translated to tc >>> mirror action and stolen control action. >>> However, the

Re: [ovs-dev] [PATCH ovn v2] northd: Ignore remote chassis when computing the supported feature set.

2023-03-14 Thread Numan Siddique
On Thu, Mar 9, 2023 at 9:21 AM Dumitru Ceara wrote: > > On 3/8/23 15:48, Ales Musil wrote: > > On Wed, Mar 8, 2023 at 3:44 PM Dumitru Ceara wrote: > > > >> Chassis in remote AZs are not programmed by the local ovn-northd. So we > >> don't need to take into account their supported feature set

Re: [ovs-dev] [PATCH 1/2] datapath: allow metering in non-initial user namespace

2023-03-14 Thread 0-day Robot
Bleep bloop. Greetings Michael Weiß, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the

Re: [ovs-dev] [PATCH 2/2] datapath: allow conntrack in non-initial user namespace

2023-03-14 Thread 0-day Robot
Bleep bloop. Greetings Michael Weiß, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH 1/2] datapath: allow metering in non-initial user namespace

2023-03-14 Thread Ilya Maximets
On 3/14/23 16:35, Michael Weiß wrote: > Upstream commit: > commit 8039371847174ff37dc3d02e83cd789dbb6140b0 > Author: Michael Weiß > Date: Fri Sep 23 15:38:19 2022 +0200 > > net: openvswitch: allow metering in non-initial user namespace > > The Netlink interface for

[ovs-dev] [PATCH 1/2] datapath: allow metering in non-initial user namespace

2023-03-14 Thread Michael Weiß
Upstream commit: commit 8039371847174ff37dc3d02e83cd789dbb6140b0 Author: Michael Weiß Date: Fri Sep 23 15:38:19 2022 +0200 net: openvswitch: allow metering in non-initial user namespace The Netlink interface for metering was restricted to global CAP_NET_ADMIN by using

[ovs-dev] [PATCH 2/2] datapath: allow conntrack in non-initial user namespace

2023-03-14 Thread Michael Weiß
Upstream commit: commit 59cd7377660a76780bfdd9fd26da058bcca5320d Author: Michael Weiß Date: Fri Sep 23 15:38:20 2022 +0200 net: openvswitch: allow conntrack in non-initial user namespace Similar to the previous commit, the Netlink interface of the OVS conntrack module

Re: [ovs-dev] [PATCH ovn 0/4] Add automation to automatically build containers

2023-03-14 Thread Simon Horman
On Tue, Mar 14, 2023 at 04:12:53PM +0100, Ales Musil wrote: > On Tue, Mar 14, 2023 at 3:44 PM Simon Horman > wrote: > > > On Tue, Mar 14, 2023 at 11:53:20AM +0100, Ales Musil wrote: > > > In order to use the containers in CI add job > > > that will build the containers once every week. > > > > >

Re: [ovs-dev] [PATCH ovn 0/4] Add automation to automatically build containers

2023-03-14 Thread Ales Musil
On Tue, Mar 14, 2023 at 3:44 PM Simon Horman wrote: > On Tue, Mar 14, 2023 at 11:53:20AM +0100, Ales Musil wrote: > > In order to use the containers in CI add job > > that will build the containers once every week. > > > > The job will automatically build for arm64 > > and x86_64. > > I am

Re: [ovs-dev] [PATCH v3] dpdk: Allow retaining CAP_SYS_RAWIO privileges

2023-03-14 Thread Aaron Conole
Flavio Leitner writes: > On Wed, Mar 08, 2023 at 05:37:11PM -0500, Aaron Conole wrote: >> Open vSwitch generally tries to let the underlying operating system >> managed the low level details of hardware, for example DMA mapping, >> bus arbitration, etc. However, when using DPDK, the underlying

Re: [ovs-dev] [PATCH ovn 0/4] Add automation to automatically build containers

2023-03-14 Thread Simon Horman
On Tue, Mar 14, 2023 at 11:53:20AM +0100, Ales Musil wrote: > In order to use the containers in CI add job > that will build the containers once every week. > > The job will automatically build for arm64 > and x86_64. I am seeing a number of workflow job failures with this patchset applied:

[ovs-dev] [PATCH v4] lib, ovsdb, ovs-vsctl, vtep-ctl: Fix multiple Coverity defects

2023-03-14 Thread James Raphael Tiovalen
This commit addresses several high and medium-impact Coverity defects by fixing several possible null-pointer dereferences and potentially uninitialized variables. Some variables and structs would always be initialized by the code flow and some pointers would never be null, and thus, some

Re: [ovs-dev] [PATCH v2] OpenFlow: Add extn to set conntrack entries limit per zone.

2023-03-14 Thread Simon Horman
On Tue, Mar 14, 2023 at 10:51:55AM +, Naveen Yerramneni wrote: > Add OpenFlow extn to set conntrack entries limit per zone. > > Signed-off-by: Naveen Yerramneni Hi Naveen, There were 4 postings of this patchset yesterday, and one so far today. Please consider allowing 24h between postings

Re: [ovs-dev] [PATCH v3] dpdk: Allow retaining CAP_SYS_RAWIO privileges

2023-03-14 Thread Flavio Leitner
On Wed, Mar 08, 2023 at 05:37:11PM -0500, Aaron Conole wrote: > Open vSwitch generally tries to let the underlying operating system > managed the low level details of hardware, for example DMA mapping, > bus arbitration, etc. However, when using DPDK, the underlying > operating system yields

Re: [ovs-dev] [PATCH ovn 0/4] Add automation to automatically build containers

2023-03-14 Thread Ales Musil
On Tue, Mar 14, 2023 at 12:15 PM Dumitru Ceara wrote: > Hi Ales, > > I added some more people explicitly in CC for visibility. > Hi Dumitru, thank you for the feedback. > On 3/14/23 11:53, Ales Musil wrote: > > In order to use the containers in CI add job > > that will build the containers

Re: [ovs-dev] [PATCH ovn 0/4] Add automation to automatically build containers

2023-03-14 Thread Dumitru Ceara
Hi Ales, I added some more people explicitly in CC for visibility. On 3/14/23 11:53, Ales Musil wrote: > In order to use the containers in CI add job > that will build the containers once every week. > > The job will automatically build for arm64 > and x86_64. > > Ales Musil (4): > CI: Add

Re: [ovs-dev] [PATCH 1/1] tc: translate mirror/stolen to mirred

2023-03-14 Thread Simon Horman
On Mon, Mar 13, 2023 at 09:34:30PM +0100, Ilya Maximets wrote: > On 3/13/23 11:27, Roi Dayan wrote: > > From: Oz Shlomo > > > > Currently jumping over a output-to-port action is translated to tc > > mirror action and stolen control action. > > However, the tc control action is not propagated to

Re: [ovs-dev] [PATCH v2] OpenFlow: Add extn to set conntrack entries limit per zone.

2023-03-14 Thread 0-day Robot
References: <20230314105155.12571-1-naveen.yerramn...@nutanix.com> Bleep bloop. Greetings Naveen Yerramneni, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has

Re: [ovs-dev] [PATCH 1/1] tc: Fix cleaning chains

2023-03-14 Thread Simon Horman
On Mon, Mar 13, 2023 at 07:47:14PM +0200, Roi Dayan wrote: > > > On 13/03/2023 14:16, Simon Horman wrote: > > On Mon, Mar 13, 2023 at 12:31:49PM +0200, Roi Dayan wrote: > >> > >> > >> On 13/03/2023 11:01, Eelco Chaudron wrote: > >>> > >>> > >>> On 13 Mar 2023, at 9:38, Roi Dayan wrote: > >>> >

Re: [ovs-dev] [PATCH ovn 4/4] CI: Add automation for building the containers

2023-03-14 Thread 0-day Robot
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #63 FILE:

Re: [ovs-dev] [PATCH ovn 3/4] CI: Add argument for the py-requirements path

2023-03-14 Thread 0-day Robot
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has non-spaces leading whitespace #31 FILE: utilities/containers/Makefile:9:

Re: [ovs-dev] [PATCH v3] lib, ovsdb, ovs-vsctl, vtep-ctl: Fix multiple Coverity defects

2023-03-14 Thread 0-day Robot
Bleep bloop. Greetings James Raphael Tiovalen, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #634 FILE: lib/sflow_agent.c:169:

[ovs-dev] [PATCH ovn 2/4] CI: Use the latest Fedora as base image

2023-03-14 Thread Ales Musil
Rather than pining the version use the latest tag. Signed-off-by: Ales Musil --- utilities/containers/fedora/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/containers/fedora/Dockerfile b/utilities/containers/fedora/Dockerfile index d24bf1232..4212e2d76

[ovs-dev] [PATCH ovn 3/4] CI: Add argument for the py-requirements path

2023-03-14 Thread Ales Musil
In order to build the container from different working directory we need to properly specify the path to py-requirements.txt. Add ARG into the Dockerfile and into Makefile which allows us to specify the path. Signed-off-by: Ales Musil --- utilities/containers/Makefile | 5 -

[ovs-dev] [PATCH ovn 4/4] CI: Add automation for building the containers

2023-03-14 Thread Ales Musil
In order to use the containers in CI build the containers regularly so everything is up to date. Currently, there is only Fedora container, but it can be extended as needed. Signed-off-by: Ales Musil --- The testing job is available here:

[ovs-dev] [PATCH ovn 1/4] CI: Add missing packages to the container

2023-03-14 Thread Ales Musil
Add missing jemalloc, kmod and scapy packages. Install scapy through pip, because the python3-scapy package has a lot of dependencies that would increase the overall size of the image by ~800 MB. Signed-off-by: Ales Musil --- utilities/containers/fedora/Dockerfile | 2 ++

[ovs-dev] [PATCH ovn 0/4] Add automation to automatically build containers

2023-03-14 Thread Ales Musil
In order to use the containers in CI add job that will build the containers once every week. The job will automatically build for arm64 and x86_64. Ales Musil (4): CI: Add missing packages to the container CI: Use the latest Fedora as base image CI: Add argument for the py-requirements

[ovs-dev] [PATCH v2] OpenFlow: Add extn to set conntrack entries limit per zone.

2023-03-14 Thread Naveen Yerramneni
Add OpenFlow extn to set conntrack entries limit per zone. Signed-off-by: Naveen Yerramneni --- Notes: v1 -> v2 - Fix memory leak and added logs NEWS | 2 ++ include/openflow/nicira-ext.h | 10 ++ include/openvswitch/ofp-msgs.h | 4

[ovs-dev] [PATCH v3] lib, ovsdb, ovs-vsctl, vtep-ctl: Fix multiple Coverity defects

2023-03-14 Thread James Raphael Tiovalen
This commit addresses several high and medium-impact Coverity defects by fixing several possible null-pointer dereferences and potentially uninitialized variables. Some variables and structs would always be initialized by the code flow and some pointers would never be null, and thus, some

Re: [ovs-dev] [PATCH ovn v3] northd: Make the use of common zone in NAT configurable

2023-03-14 Thread Ales Musil
On Tue, Mar 14, 2023 at 11:29 AM Simon Horman wrote: > On Mon, Mar 13, 2023 at 03:29:19PM +0100, Ales Musil wrote: > > On Mon, Mar 13, 2023 at 1:08 PM Simon Horman > > wrote: > > > On Mon, Mar 13, 2023 at 08:20:32AM +0100, Ales Musil wrote: > > > > On Fri, Mar 10, 2023 at 2:25 PM Simon Horman <

Re: [ovs-dev] [PATCH v2] lib, ovsdb, ovs-vsctl, vtep-ctl: Fix multiple Coverity defects

2023-03-14 Thread 0-day Robot
Bleep bloop. Greetings James Raphael Tiovalen, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #628 FILE: lib/sflow_agent.c:163:

Re: [ovs-dev] [PATCH ovn v3] northd: Make the use of common zone in NAT configurable

2023-03-14 Thread Simon Horman
On Mon, Mar 13, 2023 at 03:29:19PM +0100, Ales Musil wrote: > On Mon, Mar 13, 2023 at 1:08 PM Simon Horman > wrote: > > On Mon, Mar 13, 2023 at 08:20:32AM +0100, Ales Musil wrote: > > > On Fri, Mar 10, 2023 at 2:25 PM Simon Horman > > > wrote: > > > > On Thu, Mar 09, 2023 at 07:16:04AM +0100,

[ovs-dev] [PATCH v2] lib, ovsdb, ovs-vsctl, vtep-ctl: Fix multiple Coverity defects

2023-03-14 Thread James Raphael Tiovalen
This commit addresses several high and medium-impact Coverity defects by fixing several possible null-pointer dereferences and potentially uninitialized variables. Some variables and structs would always be initialized by the code flow and some pointers would never be null, and thus, some

Re: [ovs-dev] [PATCH] lib, ovsdb, ovs-vsctl, vtep-ctl: Fix multiple Coverity defects

2023-03-14 Thread 0-day Robot
Bleep bloop. Greetings James Raphael Tiovalen, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 83 characters long (recommended limit is 79) #231 FILE:

[ovs-dev] [PATCH] lib, ovsdb, ovs-vsctl, vtep-ctl: Fix multiple Coverity defects

2023-03-14 Thread James Raphael Tiovalen
This commit addresses several high and medium-impact Coverity defects by fixing several possible null-pointer dereferences and potentially uninitialized variables. Some variables and structs would always be initialized by the code flow and some pointers would never be null, and thus, some

Re: [ovs-dev] [PATCH v24 2/8] ovs-kmod-ctl: Load kernel module psample

2023-03-14 Thread Eelco Chaudron
On 1 Mar 2023, at 8:22, Chris Mi wrote: > Load kernel module psample to receive sampled packets from TC. > Before removing kernel module psample, remove act_sample first. > > Signed-off-by: Chris Mi > Reviewed-by: Roi Dayan > Acked-by: Eelco Chaudron > --- Changes still look good! Add

Re: [ovs-dev] [PATCH v24 1/8] compat: Add psample and tc sample action defines for older kernels

2023-03-14 Thread Eelco Chaudron
On 1 Mar 2023, at 8:22, Chris Mi wrote: > Update kernel UAPI to support psample and the tc sample action. > > Signed-off-by: Chris Mi > Reviewed-by: Roi Dayan > Acked-by: Eelco Chaudron > --- > include/linux/automake.mk| 4 ++- > include/linux/psample.h | 62

Re: [ovs-dev] [PATCH v8] netdev-offload-tc: del ufid mapping if device not exist

2023-03-14 Thread Eelco Chaudron
On 14 Mar 2023, at 7:50, Faicker Mo wrote: > The error message when test failed, > > >> 2023-03-14T02:41:16.010Z|00077|unixctl|DBG|received request >> revalidator/purge[], id=0 >> 2023-03-14T02:41:16.021Z|1|dpif(revalidator6)|WARN|system@ovs-system: >> failed to flow_get (No such file or

[ovs-dev] [PATCH v8 5/5] userspace: Add SRv6 tunnel support.

2023-03-14 Thread Nobuhiro MIKI
SRv6 (Segment Routing IPv6) tunnel vport is responsible for encapsulation and decapsulation the inner packets with IPv6 header and an extended header called SRH (Segment Routing Header). See spec in: https://datatracker.ietf.org/doc/html/rfc8754 This patch implements SRv6 tunneling in userspace

[ovs-dev] [PATCH v8 3/5] flow: Support rt_hdr in parse_ipv6_ext_hdrs__().

2023-03-14 Thread Nobuhiro MIKI
Checks whether IPPROTO_ROUTING exists in the IPv6 extension headers. If it exists, the first address is retrieved. Signed-off-by: Nobuhiro MIKI --- lib/conntrack.c | 4 +++- lib/flow.c | 26 -- lib/flow.h | 3 ++- lib/ipf.c | 12

[ovs-dev] [PATCH v8 4/5] odp: Add SRv6 tunnel actions.

2023-03-14 Thread Nobuhiro MIKI
Add the corresponding ODP actions and tests in this patch before implementing SRv6 tunnel in userspace datapath. Signed-off-by: Nobuhiro MIKI --- include/linux/openvswitch.h | 1 + lib/odp-util.c | 56 lib/packets.h| 11

[ovs-dev] [PATCH v8 2/5] tnl-ports: Support multiple nw_protos.

2023-03-14 Thread Nobuhiro MIKI
In some tunnels, inner packet needs to support both IPv4 and IPv6. Therefore, this patch improves to allow two protocols to be tied together in one tunneling. Signed-off-by: Nobuhiro MIKI --- lib/tnl-ports.c | 67 + 1 file changed, 45

[ovs-dev] [PATCH v8 0/5] userspace: Add SRv6 tunnel support.

2023-03-14 Thread Nobuhiro MIKI
v8: * Split the patch into multiple patches. * Fix docs and NEWS to point to version 3.2. * Move tests from tests/system-userspace-traffic.at to tests/system-traffic.at. v7: * fix flake8 error v6: * add tests that show interoperability between OVS and native kernel's implementation in

[ovs-dev] [PATCH v8 1/5] tests: Define new ADD_VETH_NS macro.

2023-03-14 Thread Nobuhiro MIKI
The new ADD_VETH_NS macro creates two netns and connects them with a veth pair. We can use it for testing in a generic purpose. e.g. ADD_VETH_NS([ns1], [p1], [1.1.1.1/24], [ns2], [p2], [1.1.1.2/24]) Signed-off-by: Nobuhiro MIKI --- tests/system-common-macros.at | 16 1 file

Re: [ovs-dev] [PATCH v8] netdev-offload-tc: del ufid mapping if device not exist

2023-03-14 Thread Faicker Mo
The error message when test failed, > 2023-03-14T02:41:16.010Z|00077|unixctl|DBG|received request > revalidator/purge[], id=0 > 2023-03-14T02:41:16.021Z|1|dpif(revalidator6)|WARN|system@ovs-system: > failed to flow_get (No such file or directory) >