Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-21 Thread Eelco Chaudron
On 21 Feb 2024, at 17:45, Adrian Moreno wrote: > On 2/21/24 16:42, Eelco Chaudron wrote: >> >> >> On 21 Feb 2024, at 16:03, Adrian Moreno wrote: >> >>> On 2/21/24 15:49, Aaron Conole wrote: Adrian Moreno writes: > On 2/20/24 19:06, Aaron Conole wrote: >> Eelco Chaudron

Re: [ovs-dev] [PATCH 0/3] Fix ignoring of IPv6 'local_ip' for native tunnels.

2024-02-21 Thread Ilya Maximets
On 2/20/24 23:35, Ilya Maximets wrote: > The whole patch set is needed for a two-line fix in the third patch, > more precisely, for the ability to test these two lines. > > First patch in the set is not necessary, but it makes a second patch > a little cleaner. > > The second patch is a rebased

Re: [ovs-dev] [PATCH] ovs-thread: Log pthread failures.

2024-02-21 Thread Ilya Maximets
On 2/21/24 15:34, Eelco Chaudron wrote: > > > On 15 Feb 2024, at 13:00, Ilya Maximets wrote: > >> Currently, failures of pthread_* functions are printed to stderr >> only and then OVS aborts. These error messages are hard to find >> and may be even just lost. >> >> Use VLOG_ABORT() instead.

Re: [ovs-dev] [RFC 3/7] selftests: openvswitch: use non-graceful kills when needed

2024-02-21 Thread Aaron Conole
Adrian Moreno writes: > On 2/16/24 16:28, Aaron Conole wrote: >> Normally a spawned process under OVS is given a SIGTERM when the test >> ends as part of cleanup. However, in case the process is still lingering >> for some reason, we also send a SIGKILL to force it down faster. >>

Re: [ovs-dev] [PATCH v2] bond: Reset stats when deleting post recirc rule.

2024-02-21 Thread Ilya Maximets
On 2/20/24 07:50, Adrian Moreno wrote: > In order to properly balance bond traffic, ofproto/bond periodically > reads usage statistics of the post-recirculation rules (which are added > to a hidden internal table). > > To do that, each "struct bond_entry" (which represents a hash within a > bond)

Re: [ovs-dev] [PATCH] Userspace: Software fallback for UDP encapsulated TCP segmentation.

2024-02-21 Thread Mike Pattrick
On Tue, Feb 20, 2024 at 11:09 PM Mike Pattrick wrote: > > When sending packets that are flagged as requiring segmentation to an > interface that doens't support this feature, send the packet to the TSO > software fallback instead of dropping it. > > Signed-off-by: Mike Pattrick Recheck-request:

[ovs-dev] [PATCH v3] userspace: Allow UDP zero checksum with IPv6 tunnels.

2024-02-21 Thread Mike Pattrick
This patch adopts the proposed RFC 6935 by allowing null UDP checksums even if the tunnel protocol is IPv6. This is already supported by Linux through the udp6zerocsumtx tunnel option. It is disabled by default and IPv6 tunnels are flagged as requiring a checksum, but this patch enables the user

Re: [ovs-dev] [PATCH v1] ovs-tcpdump: Cleanup mirror failed with twice fatal signals

2024-02-21 Thread Ilya Maximets
On 2/21/24 15:27, Aaron Conole wrote: > Daniel Ding writes: > >> After running ovs-tcpdump and inputs multiple CTRL+C, the program will >> raise the following exception. >> >> Error in atexit._run_exitfuncs: >> Traceback (most recent call last): >> File "/usr/bin/ovs-tcpdump", line 421, in

Re: [ovs-dev] [RFC 3/7] selftests: openvswitch: use non-graceful kills when needed

2024-02-21 Thread Adrian Moreno
On 2/16/24 16:28, Aaron Conole wrote: Normally a spawned process under OVS is given a SIGTERM when the test ends as part of cleanup. However, in case the process is still lingering for some reason, we also send a SIGKILL to force it down faster. Signed-off-by: Aaron Conole ---

Re: [ovs-dev] [PATCH v2] userspace: Allow UDP zero checksum with IPv6 tunnels.

2024-02-21 Thread 0-day Robot
Bleep bloop. Greetings Mike Pattrick, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the

[ovs-dev] [PATCH v2] userspace: Allow UDP zero checksum with IPv6 tunnels.

2024-02-21 Thread Mike Pattrick
This patch adopts the proposed RFC 6935 by allowing null UDP checksums even if the tunnel protocol is IPv6. This is already supported by Linux through the udp6zerocsumtx tunnel option. It is disabled by default and IPv6 tunnels are flagged as requiring a checksum, but this patch enables the user

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-21 Thread Adrian Moreno
On 2/21/24 16:42, Eelco Chaudron wrote: On 21 Feb 2024, at 16:03, Adrian Moreno wrote: On 2/21/24 15:49, Aaron Conole wrote: Adrian Moreno writes: On 2/20/24 19:06, Aaron Conole wrote: Eelco Chaudron writes: On 19 Feb 2024, at 19:57, Aaron Conole wrote: Eelco Chaudron writes:

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-21 Thread Eelco Chaudron
On 21 Feb 2024, at 16:03, Adrian Moreno wrote: > On 2/21/24 15:49, Aaron Conole wrote: >> Adrian Moreno writes: >> >>> On 2/20/24 19:06, Aaron Conole wrote: Eelco Chaudron writes: > On 19 Feb 2024, at 19:57, Aaron Conole wrote: > >> Eelco Chaudron writes: >> >>>

Re: [ovs-dev] [PATCH 3/3] ofproto-dpif-xlate: Fix ignoring IPv6 local_ip for native tunnels.

2024-02-21 Thread Eelco Chaudron
On 20 Feb 2024, at 23:35, Ilya Maximets wrote: > Local IP is taken into account only in case of IPv4 address, IPv6 > source is not checked. That leads to source being ignored during the > route lookup and ultimately packets encapsulated with a source IP > found during a route lookup, which is

Re: [ovs-dev] [PATCH 2/3] netdev-dummy: Add local route entries for IP addresses.

2024-02-21 Thread Eelco Chaudron
On 20 Feb 2024, at 23:35, Ilya Maximets wrote: > From: Ihar Hrachyshka > > To mimic what kernel routing subsystem does [1], add a local route > entry for every dummy IP address. This helps with OVN testing multiple > chassis on a single host and allows to run better unit tests for > userspace

Re: [ovs-dev] [PATCH 1/3] tests: Move the non-local port as tunnel endpoint test.

2024-02-21 Thread Eelco Chaudron
On 20 Feb 2024, at 23:35, Ilya Maximets wrote: > It's not a system test as it runs with dummy datapath and ports > and it has nothing to do with layer 3 tunnels. > > It should be with other userspace tunnel tests. > > While moving also making it a little nicer visually and less error > prone

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-21 Thread Adrian Moreno
On 2/21/24 15:49, Aaron Conole wrote: Adrian Moreno writes: On 2/20/24 19:06, Aaron Conole wrote: Eelco Chaudron writes: On 19 Feb 2024, at 19:57, Aaron Conole wrote: Eelco Chaudron writes: On 12 Feb 2024, at 15:15, Aaron Conole wrote: Aaron Conole writes: Eelco Chaudron

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-21 Thread Aaron Conole
Adrian Moreno writes: > On 2/20/24 19:06, Aaron Conole wrote: >> Eelco Chaudron writes: >> >>> On 19 Feb 2024, at 19:57, Aaron Conole wrote: >>> Eelco Chaudron writes: > On 12 Feb 2024, at 15:15, Aaron Conole wrote: > >> Aaron Conole writes: >> >>> Eelco

Re: [ovs-dev] [PATCH] ovs-thread: Log pthread failures.

2024-02-21 Thread Eelco Chaudron
On 15 Feb 2024, at 13:00, Ilya Maximets wrote: > Currently, failures of pthread_* functions are printed to stderr > only and then OVS aborts. These error messages are hard to find > and may be even just lost. > > Use VLOG_ABORT() instead. It will do the same thing, but will try > to log the

Re: [ovs-dev] [PATCH v1] ovs-tcpdump: Cleanup mirror failed with twice fatal signals

2024-02-21 Thread Aaron Conole
Daniel Ding writes: > After running ovs-tcpdump and inputs multiple CTRL+C, the program will > raise the following exception. > > Error in atexit._run_exitfuncs: > Traceback (most recent call last): > File "/usr/bin/ovs-tcpdump", line 421, in cleanup_mirror > ovsdb = OVSDB(db_sock) >

Re: [ovs-dev] [PATCH] userspace: Allow UDP zero checksum with IPv6 tunnels.

2024-02-21 Thread Aaron Conole
Mike Pattrick writes: > On Tue, Feb 20, 2024 at 8:56 PM Mike Pattrick wrote: >> >> This patch adopts the proposed RFC 6935 by allowing null UDP checksums >> even if the tunnel protocol is IPv6. This is already supported by Linux >> through the udp6zerocsumtx tunnel option. It is disabled by

Re: [ovs-dev] [PATCH] userspace: Allow UDP zero checksum with IPv6 tunnels.

2024-02-21 Thread Aaron Conole
Mike Pattrick writes: > This patch adopts the proposed RFC 6935 by allowing null UDP checksums > even if the tunnel protocol is IPv6. This is already supported by Linux > through the udp6zerocsumtx tunnel option. It is disabled by default and > IPv6 tunnels are flagged as requiring a checksum,

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-21 Thread Adrian Moreno
On 2/20/24 19:06, Aaron Conole wrote: Eelco Chaudron writes: On 19 Feb 2024, at 19:57, Aaron Conole wrote: Eelco Chaudron writes: On 12 Feb 2024, at 15:15, Aaron Conole wrote: Aaron Conole writes: Eelco Chaudron writes: On 2 Feb 2024, at 11:31, Adrian Moreno wrote: On 2/1/24

Re: [ovs-dev] [PATCH v3 2/2] conntrack: Handle persistent selection for IP addresses.

2024-02-21 Thread Simon Horman
On Mon, Feb 19, 2024 at 01:27:23PM +, Simon Horman wrote: > On Fri, Feb 16, 2024 at 06:19:14PM +0100, Paolo Valerio wrote: > > The patch, when 'persistent' flag is specified, makes the IP selection > > in a range persistent across reboots. > > > > Signed-off-by: Paolo Valerio > > Acked-by:

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-21 Thread Eelco Chaudron
On 20 Feb 2024, at 19:10, Adrian Moreno wrote: > On 2/20/24 13:43, Eelco Chaudron wrote: >> >> >> On 19 Feb 2024, at 19:57, Aaron Conole wrote: >> >>> Eelco Chaudron writes: >>> On 12 Feb 2024, at 15:15, Aaron Conole wrote: > Aaron Conole writes: > >> Eelco Chaudron