Re: [ovs-dev] [PATCH 1/5] Documentation: Extend copyright to 2024.

2024-02-27 Thread Eelco Chaudron
On 27 Feb 2024, at 16:36, Simon Horman wrote: > IANAL, but I think we can extend the copyright attached > to documentation to cover the current year: we are still > actively working on the documentation. > > Signed-off-by: Simon Horman > --- > Documentation/conf.py | 2 +- > 1 file changed,

Re: [ovs-dev] [PATCH ovn v2] ci: Update crun in GitHub actions runner.

2024-02-27 Thread Mohammad Heib
Hi Dumitru, Thank you for your review :) i was confused because the fix mentioned Docker as well, but you are right the default is runc so we don't have to update the ovn-k workflow. addressed in v3 thanks On

Re: [ovs-dev] [PATCH ovn] northd: Don't create fair Sb meters for ACLs with logging disabled.

2024-02-27 Thread Ales Musil
On Tue, Feb 27, 2024 at 5:04 PM Ilya Maximets wrote: > If the ACL.log is false for a fair meter, but ACL.meter is set in the > Northbound database, northd will create a unique meter for this ACL in > a Southbound database, even though it will never be used. > > Normal ovn-nbctl acl-add command

[ovs-dev] [PATCH ovn v3] ci: Update crun in GitHub actions runner.

2024-02-27 Thread Mohammad Heib
There are some issues with older crun and newer kernel combination [0]. Unfortunately Ubuntu 22.04 falls into this category and the jobs will often time fail. Temoprarily use newer crun from git that has the fix [1]. [0] https://github.com/containers/crun/pull/1309 [1]

Re: [ovs-dev] [PATCH v28 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2024-02-27 Thread Chris Mi via dev
Hi Eelco, I did a rebase and pushed to github. Nothing changed, but the actions always reported the following failure: -1000 packets transmitted, 1000 received, 0% packet loss, time 0ms +744 packets transmitted, 744 received, 0% packet loss, time 0ms I can't reproduce the failure locally.

Re: [ovs-dev] [PATCH ovn v3] OVN-SB: Exposes igmp group protocol version through IGMP table.

2024-02-27 Thread Ales Musil
On Mon, Feb 26, 2024 at 2:11 PM Mohammad Heib wrote: > Expose the igmp/mld group protocol version through the > IGMP_GROUP table in SBDB. > > This patch can be used by ovn consumer for debuggability purposes, user > now can match between the protocol version used in the OVN logical > switches

Re: [ovs-dev] [PATCH v28 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2024-02-27 Thread Chris Mi via dev
On 2/28/2024 9:20 AM, Chris Mi via dev wrote: On 2/27/2024 6:54 PM, Eelco Chaudron wrote: On 9 Jan 2024, at 11:40, Eelco Chaudron wrote: On 9 Jan 2024, at 10:22, Chris Mi wrote: Hi Roi and Eelco, Sorry for the late reply. We are still busy with other task. So maybe we'll have to

Re: [ovs-dev] [PATCH v28 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2024-02-27 Thread Chris Mi via dev
On 2/27/2024 6:54 PM, Eelco Chaudron wrote: On 9 Jan 2024, at 11:40, Eelco Chaudron wrote: On 9 Jan 2024, at 10:22, Chris Mi wrote: Hi Roi and Eelco, Sorry for the late reply. We are still busy with other task. So maybe we'll have to postpone it. Thanks for the update and I guess we

[ovs-dev] [PATCH ovn v3] ovn-ctl: Add ssl-ciphers and protocols support.

2024-02-27 Thread amginwal
From: Aliasgar Ginwala Setting up OVN on new kernel bumps openssl version. Since OVS PKI infrastructure that generated older ssl certs based on old openssl version, raft fails with error 2024-02-27T19:28:39.673Z|00022|stream_ssl|WARN|SSL_connect: error:1416F086:SSL

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Add ssl-ciphers and protocols support.

2024-02-27 Thread aginwala
Rebased to main to fix the merge conflict and sent v2 On Tue, Feb 27, 2024 at 1:59 PM 0-day Robot wrote: > Bleep bloop. Greetings aginwala aginwala, I am a robot and I have tried > out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the

[ovs-dev] [PATCH ovn v2] ovn-ctl: Add ssl-ciphers and protocols support.

2024-02-27 Thread amginwal
From: Aliasgar Ginwala Signed-off-by: Aliasgar Ginwala --- ovs | 2 +- utilities/ovn-ctl | 25 +++-- 2 files changed, 24 insertions(+), 3 deletions(-) diff --git a/ovs b/ovs index fe55ce37a..ec1d73016 16 --- a/ovs +++ b/ovs @@ -1 +1 @@ -Subproject commit

Re: [ovs-dev] [PATCH ovn v2] ci: Update crun in GitHub actions runner.

2024-02-27 Thread Dumitru Ceara
On 2/27/24 17:28, Mohammad Heib wrote: > There are some issues with older crun and newer kernel > combination [0]. Unfortunately Ubuntu 22.04 falls into this > category and the jobs will often time fail. Temoprarily use > newer crun from git that has the fix [1]. > > [0]

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Add ssl-ciphers and protocols support.

2024-02-27 Thread 0-day Robot
Bleep bloop. Greetings aginwala aginwala, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see

[ovs-dev] [PATCH ovn] ovn-ctl: Add ssl-ciphers and protocols support.

2024-02-27 Thread amginwal
From: Aliasgar Ginwala Setting up OVN on new kernel bumps openssl version. Since OVS PKI infrastructure that generated older ssl certs based on old openssl version, raft fails with error 2024-02-27T19:28:39.673Z|00022|stream_ssl|WARN|SSL_connect: error:1416F086:SSL

Re: [ovs-dev] [PATCH v2] github: Update versions of action dependencies (Node.js 20).

2024-02-27 Thread Ilya Maximets
On 1/29/24 20:24, Ilya Maximets wrote: > On 1/26/24 17:00, Eelco Chaudron wrote: >> >> >> On 26 Jan 2024, at 15:38, Ilya Maximets wrote: >> >>> checkout@v3, cache@v3 and setup-python@v4 are using outdated Node.js 16 >>> which is now deprecated in GHA [1], so these actions will stop working >>>

Re: [ovs-dev] [PATCH v5 1/2] util: Support checking for kernel versions.

2024-02-27 Thread Mike Pattrick
On Mon, Feb 26, 2024 at 4:22 AM Felix Huettner via dev wrote: > > Extract checking for a given kernel version to a separate function. > It will be used also in the next patch. > > Signed-off-by: Felix Huettner > --- > v4->v5: > - fix wrong ifdef that broke on macos > - fix

[ovs-dev] [RFC] bridge: Retry tunnel port addition for conflict.

2024-02-27 Thread Han Zhou
For kernel datapath, when a new tunnel port is created in the same transaction in which an old tunnel port with the same tunnel configuration is deleted, the new tunnel port creation will fail and left in an error state. This can be easily reproduced in OVN by triggering a chassis deletion and

Re: [ovs-dev] [PATCH ovn] northd: Don't create fair Sb meters for ACLs with logging disabled.

2024-02-27 Thread Ilya Maximets
On 2/27/24 17:05, Ilya Maximets wrote: > If the ACL.log is false for a fair meter, but ACL.meter is set in the > Northbound database, northd will create a unique meter for this ACL in > a Southbound database, even though it will never be used. > > Normal ovn-nbctl acl-add command can't create

Re: [ovs-dev] [PATCH ovn] northd: Don't create fair Sb meters for ACLs with logging disabled.

2024-02-27 Thread Mark Michelson
Thanks, Ilya. Acked-by: Mark Michelson On 2/27/24 11:05, Ilya Maximets wrote: If the ACL.log is false for a fair meter, but ACL.meter is set in the Northbound database, northd will create a unique meter for this ACL in a Southbound database, even though it will never be used. Normal

Re: [ovs-dev] [PATCH OVN] DHCP Relay Agent support for overlay subnets

2024-02-27 Thread Numan Siddique
On Mon, Feb 26, 2024, 11:41 AM Naveen Yerramneni < naveen.yerramn...@nutanix.com> wrote: > > > > On 24-Jan-2024, at 6:30 PM, Naveen Yerramneni < > naveen.yerramn...@nutanix.com> wrote: > > > > > > > >> On 24-Jan-2024, at 8:59 AM, Numan Siddique wrote: > >> > >> On Tue, Jan 23, 2024 at 8:02 PM

Re: [ovs-dev] [PATCH 5/5] Documentation: Update links to upstream Kernel documentation.

2024-02-27 Thread Mike Pattrick
On Tue, Feb 27, 2024 at 10:37 AM Simon Horman wrote: > > This updates links to several upstream Kernel documents. > > 1. Lore is now the canonical archive for the netdev mailing list > > 2. net-next is now maintained by the netdev team, >of which David Miller is currently a member, >

Re: [ovs-dev] [PATCH 4/5] Documentatoin: Update Pacemaker link.

2024-02-27 Thread Mike Pattrick
On Tue, Feb 27, 2024 at 10:36 AM Simon Horman wrote: > > Update link to OCF Resource Agents documentation as the existing link > is broken. Also, use HTTPS. > > Broken link flagged by make check-docs > > Signed-off-by: Simon Horman Acked-by: Mike Pattrick

Re: [ovs-dev] [PATCH 3/5] Documentation: Anuket project updates.

2024-02-27 Thread Mike Pattrick
On Tue, Feb 27, 2024 at 10:36 AM Simon Horman wrote: > > The Anuket was formed by a merger of OPNFV and CNTT [1]. > > Also, VswitchPerf, aka vsperf, formerly an OPNFV project, > has been renamed ViNePerf [2]. > > Update links and documentation accordingly. > > The old links were broken, this was

Re: [ovs-dev] [PATCH 2/5] Documentation: Correct spelling errors.

2024-02-27 Thread Mike Pattrick
On Tue, Feb 27, 2024 at 10:37 AM Simon Horman wrote: > > Correct spelling errors in .rst files flagged by codespell. > > Signed-off-by: Simon Horman > --- These look correct to me. Acked-by: Mike Pattrick ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 1/5] Documentation: Extend copyright to 2024.

2024-02-27 Thread Mike Pattrick
On Tue, Feb 27, 2024 at 10:36 AM Simon Horman wrote: > > IANAL, but I think we can extend the copyright attached > to documentation to cover the current year: we are still > actively working on the documentation. > > Signed-off-by: Simon Horman Acked-by: Mike Pattrick I wonder if it's valid

[ovs-dev] [PATCH ovn] ci: Update crun in GitHub actions runer.

2024-02-27 Thread Mohammad Heib
There are some issues with older crun and newer kernel combination [0]. Unfortunately Ubuntu 22.04 falls into this category and the jobs will often time fail. Temoprarily use newer crun from git that has the fix [1]. [0] https://github.com/containers/crun/pull/1309 [1]

[ovs-dev] [PATCH ovn v2] ci: Update crun in GitHub actions runner.

2024-02-27 Thread Mohammad Heib
There are some issues with older crun and newer kernel combination [0]. Unfortunately Ubuntu 22.04 falls into this category and the jobs will often time fail. Temoprarily use newer crun from git that has the fix [1]. [0] https://github.com/containers/crun/pull/1309 [1]

Re: [ovs-dev] [PATCH v2] conntrack: Fix flush not flushing all elements.

2024-02-27 Thread Mike Pattrick
On Mon, Feb 26, 2024 at 5:50 AM Xavier Simonart wrote: > > On netdev datapath, when a ct element was cleaned, the cmap > could be shrinked, potentially causing some elements to be skipped > in the flush iteration. > > Fixes: 967bb5c5cd90 ("conntrack: Add rcu support.") > Signed-off-by: Xavier

[ovs-dev] [PATCH ovn] ci: Update crun in GitHub actions runer.

2024-02-27 Thread Mohammad Heib
There are some issues with older crun and newer kernel combination [0]. Unfortunately Ubuntu 22.04 falls into this category and the jobs will often time fail. Temoprarily use newer crun from git that has the fix [1]. [0] https://github.com/containers/crun/pull/1309 [1]

Re: [ovs-dev] [PATCH 5/5] Documentation: Update links to upstream Kernel documentation.

2024-02-27 Thread 0-day Robot
Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 86 characters long (recommended limit is 79) #60 FILE:

Re: [ovs-dev] [PATCH 4/5] Documentatoin: Update Pacemaker link.

2024-02-27 Thread 0-day Robot
Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 88 characters long (recommended limit is 79) #25 FILE:

[ovs-dev] [PATCH ovn] northd: Don't create fair Sb meters for ACLs with logging disabled.

2024-02-27 Thread Ilya Maximets
If the ACL.log is false for a fair meter, but ACL.meter is set in the Northbound database, northd will create a unique meter for this ACL in a Southbound database, even though it will never be used. Normal ovn-nbctl acl-add command can't create such a record, but it is possible with a plain

Re: [ovs-dev] [PATCH ovn] controller: ofctrl: Use index for meter lookups.

2024-02-27 Thread Mark Michelson
On 2/27/24 05:32, Ilya Maximets wrote: On 2/27/24 07:51, Han Zhou wrote: On Mon, Feb 26, 2024 at 9:44 AM Ilya Maximets mailto:i.maxim...@ovn.org>> wrote: Currently, ovn-controller attempts to sync all the meters on each ofctrl_put() call.  And the complexity of this logic is quadratic

[ovs-dev] [PATCH 2/5] Documentation: Correct spelling errors.

2024-02-27 Thread Simon Horman
Correct spelling errors in .rst files flagged by codespell. Signed-off-by: Simon Horman --- Documentation/howto/sflow.rst | 2 +- Documentation/howto/tc-offload.rst| 4 ++-- Documentation/intro/install/afxdp.rst | 2 +-

[ovs-dev] [PATCH 0/5] Documentation: Copyright, hyperlink and spelling corrections.

2024-02-27 Thread Simon Horman
* Update copyright to cover up to 2024 * Fix broken or otherwise out of date hyperlinks * Spelling corrections --- Simon Horman (5): Documentation: Extend copyright to 2024. Documentation: Correct spelling errors. Documentation: Anuket project updates. Documentatoin:

[ovs-dev] [PATCH 5/5] Documentation: Update links to upstream Kernel documentation.

2024-02-27 Thread Simon Horman
This updates links to several upstream Kernel documents. 1. Lore is now the canonical archive for the netdev mailing list 2. net-next is now maintained by the netdev team, of which David Miller is currently a member, rather than only by David. Also, use HTTPS rather than HTTP. 3. The

[ovs-dev] [PATCH 4/5] Documentatoin: Update Pacemaker link.

2024-02-27 Thread Simon Horman
Update link to OCF Resource Agents documentation as the existing link is broken. Also, use HTTPS. Broken link flagged by make check-docs Signed-off-by: Simon Horman --- Documentation/topics/integration.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH 1/5] Documentation: Extend copyright to 2024.

2024-02-27 Thread Simon Horman
IANAL, but I think we can extend the copyright attached to documentation to cover the current year: we are still actively working on the documentation. Signed-off-by: Simon Horman --- Documentation/conf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/conf.py

[ovs-dev] [PATCH 3/5] Documentation: Anuket project updates.

2024-02-27 Thread Simon Horman
The Anuket was formed by a merger of OPNFV and CNTT [1]. Also, VswitchPerf, aka vsperf, formerly an OPNFV project, has been renamed ViNePerf [2]. Update links and documentation accordingly. The old links were broken, this was flagged by make check-docs [1]

Re: [ovs-dev] [PATCH v28 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2024-02-27 Thread Eelco Chaudron
On 9 Jan 2024, at 11:40, Eelco Chaudron wrote: > On 9 Jan 2024, at 10:22, Chris Mi wrote: > >> Hi Roi and Eelco, >> >> Sorry for the late reply. We are still busy with other task. So maybe we'll >> have to postpone it. > > Thanks for the update and I guess we are too late for the upcoming

[ovs-dev] [PATCH ovn 1/2] tests: Move ovn interconnection tests to ovn-ic.at.

2024-02-27 Thread Mohammad Heib
Move ovn-ic tests that exist in ovn.at to ovn-ic.at. Signed-off-by: Mohammad Heib --- tests/ovn-ic.at | 687 tests/ovn.at| 686 --- 2 files changed, 687 insertions(+), 686 deletions(-) diff --git

[ovs-dev] [PATCH ovn 2/2] tests: Use sync command in ovn-ic tests.

2024-02-27 Thread Mohammad Heib
Use the sync commands in the ovn-ic unit tests and remove lines that wait for IC-SB to sync with IC-NB. Signed-off-by: Mohammad Heib --- tests/ovn-ic.at | 178 1 file changed, 72 insertions(+), 106 deletions(-) diff --git a/tests/ovn-ic.at

Re: [ovs-dev] [PATCH ovn] controller: ofctrl: Use index for meter lookups.

2024-02-27 Thread Ilya Maximets
On 2/27/24 07:51, Han Zhou wrote: > > > On Mon, Feb 26, 2024 at 9:44 AM Ilya Maximets > wrote: >> >> Currently, ovn-controller attempts to sync all the meters on each >> ofctrl_put() call.  And the complexity of this logic is quadratic >> because for each desired

[ovs-dev] OVN technical community meeting - March 19th (was February 19th)

2024-02-27 Thread Dumitru Ceara
On 2/22/24 18:21, Han Zhou wrote: > On Tue, Feb 20, 2024 at 7:58 AM Dumitru Ceara wrote: [...] >> As usual, this is the link to the recording of the meeting: >> https://youtu.be/QjKV64EWxZ0 >> >> Notes: >> > https://docs.google.com/document/d/1dG4GwcYOSs4uArPGtOoaP5tH4KCto-GH_C3tIXSnZZ8 >> >>