On 2/28/2024 9:20 AM, Chris Mi via dev wrote:
On 2/27/2024 6:54 PM, Eelco Chaudron wrote:
On 9 Jan 2024, at 11:40, Eelco Chaudron wrote:
On 9 Jan 2024, at 10:22, Chris Mi wrote:
Hi Roi and Eelco,
Sorry for the late reply. We are still busy with other task. So
maybe we'll have to postpone it.
Thanks for the update and I guess we are too late for the upcoming
release unless you can submit it this week.
Now that 3.3 has been released, do you have an idea when you can
submit a new revision? This so we have time to review before the next
release?
I'm working on it now. Hopefully I can submit a new revision this week.
But I can't reproduce the memory leak Ilya found. Not sure if I miss
anything. Do you have any idea?
Anyway, I found something wrong. Maybe we should introduce
offload_sample_uninit() to free sample->userspace_actions if something
wrong happens.
I attached a possible fix, could you please review it?
Thanks,
Chris
Thanks,
Chris
//Eelco
FYI, We got an inquiry from Jim Michelson (Nvidia) directly about the
status.
Regards,
Chris
On 1/9/2024 4:52 PM, Roi Dayan wrote:
On 02/11/2023 15:24, Eelco Chaudron wrote:
On 3 Oct 2023, at 17:03, Eelco Chaudron wrote:
On 19 Jun 2023, at 12:18, Chris Mi wrote:
On 6/19/2023 6:04 PM, Eelco Chaudron wrote:
On 19 Jun 2023, at 7:05, Chris Mi wrote:
Add three sFlow offload test cases:
3: offloads - sflow with sampling=1 - offloads enabled ok
4: offloads - sflow with sampling=2 - offloads enabled ok
5: offloads - ping over vxlan tunnel with sflow -
offloads enabled ok
Signed-off-by: Chris Mi<c...@nvidia.com>
Reviewed-by: Roi Dayan<r...@nvidia.com>
Acked-by: Eelco Chaudron<echau...@redhat.com>
Thanks for making all the suggested changes to this series.
This is my final ack, which should conclude the series :)
Acked-by: Eelco Chaudron<echau...@redhat.com>
//Eelco
Sorry for missing your Acked-by for previous patches :(
And thanks a lot for acking this patchset. That's so great :)
Hi Chris,
Any update on this patchset? It has some open questions/comments
from Ilya, and it would be nice to get the patch in before the
next release.
Cheers,
Eelco
Hi Roi,
As Chris does not seem to reply, do you have any update on this?
Thanks,
Eelco
Hi Eelco,
I don't have an update on this patchset. I'll try to ping Chris
about it.
Thanks,
Roi
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c
index 2c86e8102..61374ced5 100644
--- a/lib/netdev-offload-tc.c
+++ b/lib/netdev-offload-tc.c
@@ -2197,6 +2197,12 @@ parse_sample_actions_attribute(const struct nlattr
*actions,
return err;
}
+static void
+offload_sample_uninit(struct offload_sample *sample)
+{
+ free(sample->userspace_actions);
+}
+
static void
offload_sample_init(struct offload_sample *sample,
const struct nlattr *next_actions,
@@ -2239,13 +2245,15 @@ parse_sample_action(struct tc_flower *flower, struct
tc_action *tc_action,
} else if (nl_attr_type(nla) == OVS_SAMPLE_ATTR_PROBABILITY) {
rate = UINT32_MAX / nl_attr_get_u32(nla);
} else {
- return EINVAL;
+ ret = EINVAL;
+ goto err_out;
}
}
/* This check makes sure both attributes above were present and valid. */
if (!rate || ret) {
- return EINVAL;
+ ret = EINVAL;
+ goto err_out;
}
sgid = sgid_alloc(&sample);
@@ -2260,6 +2268,10 @@ parse_sample_action(struct tc_flower *flower, struct
tc_action *tc_action,
flower->action_count++;
return 0;
+
+err_out:
+ offload_sample_uninit(&sample);
+ return ret;
}
static int
@@ -2281,6 +2293,7 @@ parse_userspace_action(struct tc_flower *flower, struct
tc_action *tc_action,
* only offload userspace actions for sFlow. */
err = parse_userspace_attributes(userspace_action, &sample);
if (err) {
+ offload_sample_uninit(&sample);
return err;
}
sample.action = (struct nlattr *) userspace_action;
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
