On 3/22/24 17:36, Mike Pattrick wrote:
> On Fri, Mar 22, 2024 at 10:41 AM Ilya Maximets wrote:
>>
>> Recirculation involves re-parsing the packet from scratch and that
>> process is not aware of multiple header levels nor the inner/outer
>> offsets. So, it overwrites offsets with new ones from
On 3/20/24 03:54, Daniel Ding wrote:
> After running ovs-tcpdump and inputs multiple CTRL+C, the program will
> raise the following exception.
>
> Error in atexit._run_exitfuncs:
> Traceback (most recent call last):
> File "/usr/bin/ovs-tcpdump", line 421, in cleanup_mirror
> ovsdb =
On 3/21/24 14:16, Mike Pattrick wrote:
> In v4.0, LibreSwan changed a default paths that had been hardcoded in
> ovs-monitor-ipsec, breaking some uses of this script. This patch adds
> support for both old and newer versions by auto detecting the version
> of LibreSwan and then choosing the
On 3/21/24 14:28, Aaron Conole wrote:
> Ilya Maximets writes:
>
>> Currently, ovs-vswitchd is subscribed to all the routing changes in the
>> kernel. On each change, it marks the internal routing table cache as
>> invalid, then resets it and dumps all the routes from the kernel from
>> scratch.
On 3/22/24 09:19, Jun Wang wrote:
> Fixing the issue of incorrect outer UDP checksum in packets sent by
> E810 or X710.We disable RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM,but also
> disable all the dependent offloads like
> RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO and
> RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO.
>
>
On 3/22/24 14:40, Aaron Conole wrote:
> Open vSwitch supports the ability to invoke a controller action by way
> of a sample action with a specified meter. In the normal case, this
> sample action is transparently generated during xlate processing. However,
> when executing via a continuation,
On 3/12/24 11:02, Paolo Valerio wrote:
> In the flush tuple code path, while populating the conn_key,
> reverse_icmp_type() gets called for both icmp and icmpv6 cases,
> while, depending on the proto, its respective helper should be
> called, instead.
Thanks for the fix!
Some minor nits below.
On 3/13/24 12:08, Paolo Valerio wrote:
> Recent kernels introduced a mechanism that allows to evict colliding
> entries in a closing state whereas they were previously considered as
> parts of a non-recoverable clash.
> This new behavior makes "conntrack - SNAT with port range with
> exhaustion
Open vSwitch is originally intended to switch at layer 2, only dealing with
Ethernet frames. With the introduction of l3 tunnels support, it crossed
into the realm of needing to care a bit about some routing details when
making forwarding decisions. If an oversized packet would need to be
On 3/21/24 19:15, Dumitru Ceara wrote:
Most of the steps were inaccurate. Instead, use latest Ubuntu, use
OVS from the submodule inside the OVN repo.
Signed-off-by: Dumitru Ceara
---
utilities/docker/Makefile | 4 ++--
utilities/docker/debian/Dockerfile | 2 +-
I had a look through all the patches. For the entire series:
Acked-by: Mark Michelson
I also have a question on patch 6 if you don't mind having a look there.
On 3/21/24 19:15, Dumitru Ceara wrote:
Some of these have been missed when:
- splitting from OVS
- moving to using OVS as a submodule
On 3/22/24 15:42, Ilya Maximets wrote:
> Recirculation involves re-parsing the packet from scratch and that
> process is not aware of multiple header levels nor the inner/outer
> offsets. So, it overwrites offsets with new ones from the outermost
> headers and sets offloading flags that change
On Fri, Mar 22, 2024 at 10:41 AM Ilya Maximets wrote:
>
> Recirculation involves re-parsing the packet from scratch and that
> process is not aware of multiple header levels nor the inner/outer
> offsets. So, it overwrites offsets with new ones from the outermost
> headers and sets offloading
The Kernel datapath is no longer present in the primary development
branch of the OVS tree. Update documentation to more clearly reflect
this.
Documentation relating to the kernel datapath in the OVS tree can
be removed once 2.17 is EOL.
Also, update wording of affected text as there is more
Recently OVS adopted a policy of using the inclusive naming word list v1
[1, 2]. And in keeping with this policy it is intended to rename the
primary development branch from master to main [3].
In order to help facilitate this change allow Appveyor to run
on the main as well as master branch. It
Recirculation involves re-parsing the packet from scratch and that
process is not aware of multiple header levels nor the inner/outer
offsets. So, it overwrites offsets with new ones from the outermost
headers and sets offloading flags that change their meaning when
the packet is marked for
On 22 Mar 2024, at 14:54, Eric Garver wrote:
> Exercise the drop action in the datapath. This specific tests triggers
> an xlate_error.
>
> For the kernel datapath skb drop reasons can then be seen while this
> test runs.
>
> # perf trace -e skb:kfree_skb --filter="reason >= 0x3"
>
On 23 Feb 2024, at 2:26, Ilya Maximets wrote:
> This change attempts to track the actual available stack and force
> recircuation if the flow translation logic is about to overflow it.
Thanks Ilya, for taking a stab at this!
> Unlike the recursion depth counter, this approach allows to track
Exercise the drop action in the datapath. This specific tests triggers
an xlate_error.
For the kernel datapath skb drop reasons can then be seen while this
test runs.
# perf trace -e skb:kfree_skb --filter="reason >= 0x3"
0.000 ping/1275884 skb:kfree_skb(skbaddr: 0x8acd76546000, \
The next commit will convert a dp feature from bool to atomic_bool. As
such we have to add support to the macros and functions. We must pass by
reference instead of pass by value because all the atomic operations
require a reference.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
Kernel support has been added for this action. As such, we need to probe
the datapath for support.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 ++-
lib/dpif.h | 2 +-
ofproto/ofproto-dpif.c
Verify that the explicit drop action is re-probed if the hw-offload flag
is changed.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
tests/system-offloads-traffic.at | 12
1 file changed, 12 insertions(+)
diff --git a/tests/system-offloads-traffic.at
v13:
- use macros strip_ptype and strip_eth in test
v12:
- new patch to verify re-probe
- don't mention hw offload in the probe
- changed log message to not mention HW offload
v11:
- move netdev and flow API check to lib
- tweaked log message
- use atomic store instead of cmpx
-
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h |
This avoids copying the support struct onto the stack.
Acked-by: Eelco Chaudron
Signed-off-by: Eric Garver
---
ofproto/ofproto-dpif.c | 59 +-
1 file changed, 29 insertions(+), 30 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
On Thu, Mar 21, 2024 at 06:23:43PM +0100, Ilya Maximets wrote:
> On 3/21/24 11:03, Simon Horman wrote:
> > The Kernel datapath is no longer present in the primary development
> > branch of the OVS tree. Remove references to this in the documentation.
> >
> > Signed-off-by: Simon Horman
> > ---
>
Open vSwitch supports the ability to invoke a controller action by way
of a sample action with a specified meter. In the normal case, this
sample action is transparently generated during xlate processing. However,
when executing via a continuation, the logic to generate the sample
action when
On 3/22/24 00:15, Dumitru Ceara wrote:
> As Ilya commented in the review of the V1 of this series [0] the
> statement that "all the TODO items listed in it have been addressed"
> is indeed "a bold statement". However quite a few don't seem
> applicable anymore.
>
> [0]
On 15 Mar 2024, at 11:04, LIU Yulong wrote:
> A potential race condition happened with the following 3 threads:
> * PMD thread replaced the old_ukey and transitioned the state to
> UKEY_DELETED.
> * RCU thread is freeing the old_ukey mutex.
> * While the revalidator thread is trying to lock
Hi Mark,
Thanks for your feedback.
Em seg., 18 de mar. de 2024 às 11:53, Mark Michelson
escreveu:
> Hi Roberto,
>
> I have some concerns about this patch. Let's use the test case you added
> as an example network. Let's bind the vms and DGPs to hypervisors:
>
> * vm1 and lr1-ts1 are bound to
On Thu, Mar 21, 2024 at 01:32:39PM +0100, Ilya Maximets wrote:
> CC: ovs-discuss for visibility.
>
> It seems like this change will affect ovn-fake-multinode project
> and ovn-heater as they are cloning 'master' branch by default.
> Also the OVN project itself is cloning OVS master branch in one
On 15 Mar 2024, at 20:55, Eric Garver wrote:
> Verify that the explicit drop action is re-probed if the hw-offload flag
> is changed.
>
> Signed-off-by: Eric Garver
Thanks for adding this additional test. With the one small change in 5/6, the
series looks good to me.
Acked-by: Eelco
On 15 Mar 2024, at 20:55, Eric Garver wrote:
> Exercise the drop action in the datapath. This specific tests triggers
> an xlate_error.
>
> For the kernel datapath skb drop reasons can then be seen while this
> test runs.
>
> # perf trace -e skb:kfree_skb --filter="reason >= 0x3"
>
On 15 Mar 2024, at 20:55, Eric Garver wrote:
> Kernel support has been added for this action. As such, we need to probe
> the datapath for support.
>
> Signed-off-by: Eric Garver
Thanks for following up. This change looks good to me.
Acked-by: Eelco Chaudron
Fixing the issue of incorrect outer UDP checksum in packets sent by
E810 or X710.We disable RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM,but also
disable all the dependent offloads like
RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO and
RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO.
Fixes: 084c8087292c ("userspace: Support VXLAN
On 3/22/24 00:15, Dumitru Ceara wrote:
> As Ilya commented in the review of the V1 of this series [0] the
> statement that "all the TODO items listed in it have been addressed"
> is indeed "a bold statement". However quite a few don't seem
> applicable anymore.
>
> [0]
On 3/22/24 00:15, Dumitru Ceara wrote:
> Remove openvswitch related left overs.
> Remove documentation about installation on older RHEL versions. RHEL 6.x
> will reach the end of its ELS, Extended Life Cycle Support on July 1st:
>
>
Bleep bloop. Greetings Jun Wang, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject, ': ', is over 70 characters, i.e., 71.
Subject: netdev-dpdk: Disable outer
Fixing the issue of incorrect outer UDP checksum in packets sent by E810 or
X710.
We disable RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM,but also disable all the dependent
offloads like RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO and
RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO.
Fixes: 084c8087292c ("userspace: Support VXLAN
39 matches
Mail list logo
