Re: [ovs-dev] [PATCH net-next 1/3] selftests: openvswitch: add interface support
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (tools/testing/selftests/net/openvswitch/openvswitch.sh). error: could not build fake ancestor hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 selftests: openvswitch: add interface support When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] Pass localnet traffic through CT when a LB is configured.
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Co-author Dumitru Ceara needs to sign off. WARNING: Line is 83 characters long (recommended limit is 79) #87 FILE: northd/northd.c:5965: S_SWITCH_IN_PRE_ACL, S_SWITCH_OUT_PRE_ACL, Lines checked: 186, Warnings: 1, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net] selftests: openvswitch: adjust datapath NL message declaration
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (tools/testing/selftests/net/openvswitch/ovs-dpctl.py). error: could not build fake ancestor hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 selftests: openvswitch: adjust datapath NL message declaration When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v10] utilities/ofctl: add-meters for save and restore
Bleep bloop. Greetings Wan Junjie, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #195 FILE: lib/ofp-meter.c:871: error = parse_ofp_meter_mod_str(&(*mms)[*n_mms], ds_cstr(), command, Lines checked: 714, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v9] utilities/ofctl: add-meters for save and restore
Bleep bloop. Greetings Wan Junjie, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #195 FILE: lib/ofp-meter.c:871: error = parse_ofp_meter_mod_str(&(*mms)[*n_mms], ds_cstr(), command, Lines checked: 702, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v8] utilities/ofctl: add-meters for save and restore
Bleep bloop. Greetings Wan Junjie, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #195 FILE: lib/ofp-meter.c:871: error = parse_ofp_meter_mod_str(&(*mms)[*n_mms], ds_cstr(), command, Lines checked: 702, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v7] utilities/ofctl: add-meters for save and restore
Bleep bloop. Greetings Wan Junjie, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #195 FILE: lib/ofp-meter.c:871: error = parse_ofp_meter_mod_str(&(*mms)[*n_mms], ds_cstr(), command, Lines checked: 702, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v6] utilities/ofctl: add-meters for save and restore
Bleep bloop. Greetings Wan Junjie, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #195 FILE: lib/ofp-meter.c:871: error = parse_ofp_meter_mod_str(&(*mms)[*n_mms], ds_cstr(), command, Lines checked: 702, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 2/2] * netdev-dpdk: Add support for userspace port-based ingress packet-per-second policing.
Bleep bloop. Greetings lin huang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #119 FILE: lib/netdev-dpdk.c:3564: /* rte_meter requires bytes so convert kbits rate and burst to bytes. */ Lines checked: 395, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 1/2] * netdev-dpdk: Add support for userspace port-based egress packet-per-second policing.
Bleep bloop. Greetings lin huang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #384 FILE: vswitchd/vswitch.xml:4898: type='{"type": "integer", "minInteger": 0, "maxInteger": 4294967}'> WARNING: Line is 81 characters long (recommended limit is 79) #389 FILE: vswitchd/vswitch.xml:4903: type='{"type": "integer", "minInteger": 0, "maxInteger": 4294967}'> Lines checked: 399, Warnings: 2, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] ovsdb-cs: fix 'cs_db' lock flag not free error.
Bleep bloop. Greetings 汪翰林, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 12 error: could not build fake ancestor hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 ovsdb-cs: fix 'cs_db' lock flag not free error. When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] ovsdb-cs: fix 'cs_db' lock flag not free error.
Bleep bloop. Greetings 汪翰林, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 12 error: could not build fake ancestor hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 ovsdb-cs: fix 'cs_db' lock flag not free error. When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH branch-3.1 2/2] Prepare for 3.1.2.
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH branch-3.1 1/2] Set release date for 3.1.1.
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 Set release date for 3.1.1. When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v1 2/2] netdev-dpdk: add netdev-dpdk ingress pkts policer.
Bleep bloop. Greetings lin huang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #78 FILE: lib/netdev-dpdk.c:2400: struct rte_mbuf **pkts, int pkt_cnt, bool should_steal) WARNING: Line is 81 characters long (recommended limit is 79) #245 FILE: lib/netdev-dpdk.c:4618: return ovsrcu_get(struct ingress_pkts_policer *, >ingress_pkts_policer); Lines checked: 254, Warnings: 2, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 21.12 ovn] controller: lflow: do not use tcp as default IP protocol for ct_snat_to_vip action
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 controller: lflow: do not use tcp as default IP protocol for ct_snat_to_vip action When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 22.03 ovn] controller: lflow: do not use tcp as default IP protocol for ct_snat_to_vip action
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 controller: lflow: do not use tcp as default IP protocol for ct_snat_to_vip action When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 22.06 ovn] controller: lflow: do not use tcp as default IP protocol for ct_snat_to_vip action
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 controller: lflow: do not use tcp as default IP protocol for ct_snat_to_vip action When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 22.09 ovn] controller: lflow: do not use tcp as default IP protocol for ct_snat_to_vip action
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 controller: lflow: do not use tcp as default IP protocol for ct_snat_to_vip action When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 22.12 ovn] controller: lflow: do not use tcp as default IP protocol for ct_snat_to_vip action
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 controller: lflow: do not use tcp as default IP protocol for ct_snat_to_vip action When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2] conntrack-tp: Fix clang warning.
Bleep bloop. Greetings lin huang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Lin Huang needs to sign off. Lines checked: 37, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v2 branch-22.12 2/2] northd: Drop packets for LBs with no backends
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Dumitru Ceara Lines checked: 105, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH dpdk-latest v3 6/6] netdev-dpdk-offload: Add support for meter action
References: <20230330112057.14242-7-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Simon Horman Lines checked: 50, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH dpdk-latest v3 5/6] netdev-dpdk: add meter algorithms
References: <20230330112057.14242-6-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Simon Horman Lines checked: 99, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH dpdk-latest v3 4/6] netdev-offload-dpdk: Implement meter offload API for DPDK
References: <20230330112057.14242-5-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Simon Horman Lines checked: 406, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH dpdk-latest v3 3/6] dpif-netdev: Offloading meter with DPDK
References: <20230330112057.14242-4-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Simon Horman Lines checked: 70, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH dpdk-latest v3 2/6] netdev-offload: Let meter offload API can be used with DPDK
References: <20230330112057.14242-3-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Simon Horman Lines checked: 313, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH dpdk-latest v3 1/6] netdev-offload-dpdk: use flow transfer proxy
References: <20230330112057.14242-2-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Simon Horman Lines checked: 148, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v4] db-ctl-base: Partially revert b8bf410a5
Bleep bloop. Greetings Daniel Alvarez Sanchez, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: "Fixes" tag is malformed. Use the following format: git log -1 --pretty=format:"Fixes: %h (\"%s\")" --abbrev=12 COMMIT_REF 14: Fixes: b8bf410a5 ("db-ctl-base: Use partial map/set updates for last add/set commands") Lines checked: 138, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v3] db-ctl-base: Partially revert b8bf410a5
Bleep bloop. Greetings Daniel Alvarez Sanchez, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 119 error: could not build fake ancestor hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 db-ctl-base: Partially revert b8bf410a5 When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2] db-ctl-base: Partially revert b8bf410a5
Bleep bloop. Greetings Daniel Alvarez Sanchez, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 118 error: could not build fake ancestor hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 db-ctl-base: Partially revert b8bf410a5 When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v3 2/2] Add fake multinode system tests.
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 83 characters long (recommended limit is 79) #101 FILE: .github/workflows/ovn-fake-multinode-tests.yml:183: sudo podman exec -it ovn-chassis-1 cat /var/log/ovn/ovn-controller.log || : Lines checked: 515, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v3 1/2] CI: Add a couple of periodic jobs using ovn-fake-multinode.
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 88 characters long (recommended limit is 79) #47 FILE: .github/workflows/ovn-fake-multinode-tests.yml:9: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }} WARNING: Line is 84 characters long (recommended limit is 79) #91 FILE: .github/workflows/ovn-fake-multinode-tests.yml:53: sudo podman save ovn/ovn-multi-node:latest > /tmp/_output/ovn_main_image.tar WARNING: Line is 84 characters long (recommended limit is 79) #107 FILE: .github/workflows/ovn-fake-multinode-tests.yml:69: sudo podman save ovn/ovn-multi-node:22.03 > /tmp/_output/ovn_22_03_image.tar WARNING: Line is 129 characters long (recommended limit is 79) #144 FILE: .github/workflows/ovn-fake-multinode-tests.yml:106: run: sudo eatmydata apt-get remove --auto-remove -y aspnetcore-* dotnet-* libmono-* mono-* msbuild php-* php7* ghc-* zulu-* Lines checked: 205, Warnings: 4, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn branch-22.12] northd: Drop packets for LBs with no backends
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Dumitru Ceara Lines checked: 105, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] Typo fix in the ovn-nbctl man page.
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 275 characters long (recommended limit is 79) #30 FILE: utilities/ovn-nbctl.8.xml:1154: [--may-exist] [--stateless] [--gateway-port=GATEWAY_PORT] lr-nat-add router type external_ip logical_ip [logical_port external_mac] Lines checked: 37, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn branch-23.03] northd: Use generic ct.est flows for LR LBs
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Dumitru Ceara WARNING: Line is 81 characters long (recommended limit is 79) #442 FILE: northd/ovn-northd.8.xml:3370: ip ip.dst == VIP P Lines checked: 1308, Warnings: 2, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v2] northd, arp_proxy: response ARP at localnet lsp
Bleep bloop. Greetings Enrique Llorente Pastora, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 155 characters long (recommended limit is 79) #154 FILE: p-set-addresses:10573: NETNS_DAEMONIZE([ext1], [tcpdump -l -nn -e -i ext1 'ether dst 0a:58:a9:fe:01:01 and icmp' > ext1-icmp.pcap 2>ext1-tcpdump.stderr], [ext1-icmp-tcpdump.pid]) Lines checked: 173, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] northd, arp_proxy: response ARP at localnet lsp
Bleep bloop. Greetings Enrique Llorente, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 155 characters long (recommended limit is 79) #152 FILE: p-set-addresses:10573: NETNS_DAEMONIZE([ext1], [tcpdump -l -nn -e -i ext1 'ether dst 0a:58:a9:fe:01:01 and icmp' > ext1-icmp.pcap 2>ext1-tcpdump.stderr], [ext1-icmp-tcpdump.pid]) Lines checked: 171, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v2 3/3] expr: Combine OR sub-expressions into supersets.
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 93 characters long (recommended limit is 79) #1300 FILE: p-set-addresses:17522: # priority=2001,ip,metadata=0x1,nw_src=10.6.0.6 actions=conjunction(2,1/2),conjunction(3,1/2) WARNING: Line is 93 characters long (recommended limit is 79) #1301 FILE: p-set-addresses:17523: # priority=2001,ip,metadata=0x1,nw_src=10.4.0.4 actions=conjunction(2,1/2),conjunction(3,1/2) WARNING: Line is 93 characters long (recommended limit is 79) #1302 FILE: p-set-addresses:17524: # priority=2001,ip,metadata=0x1,nw_src=10.5.0.5 actions=conjunction(2,1/2),conjunction(3,1/2) WARNING: Line is 93 characters long (recommended limit is 79) #1368 FILE: p-set-addresses:17586: # priority=2001,ip,metadata=0x1,nw_dst=10.9.0.9 actions=conjunction(4,1/2),conjunction(6,1/2) WARNING: Line is 112 characters long (recommended limit is 79) #1370 FILE: p-set-addresses:17588: # priority=2001,ip,metadata=0x1,nw_src=10.5.0.5 actions=conjunction(4,2/2),conjunction(5,2/2),conjunction(6,2/2) WARNING: Line is 112 characters long (recommended limit is 79) #1371 FILE: p-set-addresses:17589: # priority=2001,ip,metadata=0x1,nw_src=10.4.0.4 actions=conjunction(4,2/2),conjunction(5,2/2),conjunction(6,2/2) WARNING: Line is 112 characters long (recommended limit is 79) #1372 FILE: p-set-addresses:17590: # priority=2001,ip,metadata=0x1,nw_src=10.6.0.6 actions=conjunction(4,2/2),conjunction(5,2/2),conjunction(6,2/2) WARNING: Line is 93 characters long (recommended limit is 79) #1400 FILE: p-set-addresses:17607: # priority=2001,ip,metadata=0x1,nw_dst=10.9.0.9 actions=conjunction(7,1/2),conjunction(8,1/2) WARNING: Line is 112 characters long (recommended limit is 79) #1402 FILE: p-set-addresses:17609: # priority=2001,ip,metadata=0x1,nw_src=10.5.0.5 actions=conjunction(7,2/2),conjunction(8,2/2),conjunction(9,2/2) WARNING: Line is 112 characters long (recommended limit is 79) #1403 FILE: p-set-addresses:17610: # priority=2001,ip,metadata=0x1,nw_src=10.6.0.6 actions=conjunction(7,2/2),conjunction(8,2/2),conjunction(9,2/2) WARNING: Line is 112 characters long (recommended limit is 79) #1404 FILE: p-set-addresses:17611: # priority=2001,ip,metadata=0x1,nw_src=10.4.0.4 actions=conjunction(7,2/2),conjunction(8,2/2),conjunction(9,2/2) WARNING: Line is 95 characters long (recommended limit is 79) #1420 FILE: p-set-addresses:17627: # priority=2001,ip,metadata=0x1,nw_dst=10.9.0.9 actions=conjunction(10,1/2),conjunction(11,1/2) WARNING: Line is 95 characters long (recommended limit is 79) #1421 FILE: p-set-addresses:17628: # priority=2001,ip,metadata=0x1,nw_src=10.5.0.5 actions=conjunction(10,2/2),conjunction(11,2/2) WARNING: Line is 95 characters long (recommended limit is 79) #1422 FILE: p-set-addresses:17629: # priority=2001,ip,metadata=0x1,nw_src=10.6.0.6 actions=conjunction(10,2/2),conjunction(11,2/2) WARNING: Line is 95 characters long (recommended limit is 79) #1423 FILE: p-set-addresses:17630: # priority=2001,ip,metadata=0x1,nw_src=10.4.0.4 actions=conjunction(10,2/2),conjunction(11,2/2) WARNING: Line is 80 characters long (recommended limit is 79) #1432 FILE: p-set-addresses:19443: AT_CHECK([ovs-ofctl dump-flows br-int | grep "10.1.2.10/31"], [0], [ignore]) WARNING: Line is 92 characters long (recommended limit is 79) #1450 FILE: p-set-addresses:31516: lsp-set-addresses lsp${i}-${j} "aa:aa:aa:00:0$i:0$j 192.$i.$i.$((($j + 1) * 4))" WARNING: Line is 82 characters long (recommended limit is 79) #1459 FILE: p-set-addresses:31548: AT_CHECK([test $(ovs-ofctl dump-flows br-int table=44 | grep 192. | wc -l) == 10]) Lines checked: 1466, Warnings: 18, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v2] northd: add router broadcast option to logical switch
Bleep bloop. Greetings Felix Hüttner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Felix Hüttner needs to sign off. WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Felix Huettner Lines checked: 179, Warnings: 1, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn 1/6] controller, northd: move inactivity probe configuration to lib/
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Vladislav Odintsov needs to sign off. Lines checked: 172, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Fix documentation typo
Bleep bloop. Greetings Roberto Bartzen Acosta, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 23 error: could not build fake ancestor hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 ovn-nbctl: Fix documentation typo When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] backtrace: Replace usage of libunwind with libc backtrace
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #205 FILE: lib/backtrace.h:38: * /lib64/libovsdb-3.1.so.0(ovsdb_txn_propose_commit_block+0x8d) [0x7fc5db563a8d] Lines checked: 628, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v2 2/2] Add fake multinode system tests.
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 83 characters long (recommended limit is 79) #101 FILE: .github/workflows/ovn-fake-multinode-tests.yml:185: sudo podman exec -it ovn-chassis-1 cat /var/log/ovn/ovn-controller.log || : Lines checked: 515, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v2 1/2] CI: Add a couple of jobs using ovn-fake-multinode.
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 88 characters long (recommended limit is 79) #45 FILE: .github/workflows/ovn-fake-multinode-tests.yml:11: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }} WARNING: Line is 84 characters long (recommended limit is 79) #89 FILE: .github/workflows/ovn-fake-multinode-tests.yml:55: sudo podman save ovn/ovn-multi-node:latest > /tmp/_output/ovn_main_image.tar WARNING: Line is 84 characters long (recommended limit is 79) #105 FILE: .github/workflows/ovn-fake-multinode-tests.yml:71: sudo podman save ovn/ovn-multi-node:22.03 > /tmp/_output/ovn_22_03_image.tar WARNING: Line is 129 characters long (recommended limit is 79) #142 FILE: .github/workflows/ovn-fake-multinode-tests.yml:108: run: sudo eatmydata apt-get remove --auto-remove -y aspnetcore-* dotnet-* libmono-* mono-* msbuild php-* php7* ghc-* zulu-* Lines checked: 203, Warnings: 4, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 1/2] datapath: allow metering in non-initial user namespace
Bleep bloop. Greetings Michael Weiß, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 datapath: allow metering in non-initial user namespace When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 2/2] datapath: allow conntrack in non-initial user namespace
Bleep bloop. Greetings Michael Weiß, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2] OpenFlow: Add extn to set conntrack entries limit per zone.
References: <20230314105155.12571-1-naveen.yerramn...@nutanix.com> Bleep bloop. Greetings Naveen Yerramneni, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has non-spaces leading whitespace WARNING: Line has trailing whitespace #157 FILE: ofproto/ofproto-dpif.c:5641: WARNING: Line has trailing whitespace #158 FILE: ofproto/ofproto-dpif.c:5642: ct_dpif_free_zone_limits(_limits); Lines checked: 344, Warnings: 3, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn 4/4] CI: Add automation for building the containers
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #63 FILE: .github/workflows/containers.yaml:41: dockerfiles: ${{ env.CONTAINERS_PATH }}/${{ matrix.distro }}/Dockerfile WARNING: Line is 88 characters long (recommended limit is 79) #76 FILE: .github/workflows/containers.yaml:54: run: echo "Image pushed to ${{ steps.push-to-registry.outputs.registry-paths }}" Lines checked: 80, Warnings: 2, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn 3/4] CI: Add argument for the py-requirements path
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has non-spaces leading whitespace #31 FILE: utilities/containers/Makefile:9: $(CONTAINER_CMD) build --no-cache --rm -t $(IMAGE_NAME) \ WARNING: Line has non-spaces leading whitespace #32 FILE: utilities/containers/Makefile:10: -f $(DISTRO)/Dockerfile . --build-arg=CONTAINERS_PATH=$(CONTAINERS_PATH) Lines checked: 57, Warnings: 2, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v3] lib, ovsdb, ovs-vsctl, vtep-ctl: Fix multiple Coverity defects
Bleep bloop. Greetings James Raphael Tiovalen, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #634 FILE: lib/sflow_agent.c:169: else { ERROR: Inappropriate bracing around statement #670 FILE: lib/sflow_agent.c:223: else { ERROR: Inappropriate bracing around statement #713 FILE: lib/sflow_agent.c:274: else { Lines checked: 1690, Warnings: 0, Errors: 3 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2] lib, ovsdb, ovs-vsctl, vtep-ctl: Fix multiple Coverity defects
Bleep bloop. Greetings James Raphael Tiovalen, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #628 FILE: lib/sflow_agent.c:163: for (r = agent->receivers; r != NULL; prev = r, r = r->nxt); ERROR: Inappropriate bracing around statement #629 FILE: lib/sflow_agent.c:164: if (prev) { prev->nxt = rcv; } ERROR: Inappropriate bracing around statement #661 FILE: lib/sflow_agent.c:214: if (prev) { prev->nxt = newsm; } ERROR: Inappropriate bracing around statement #677 FILE: lib/sflow_agent.c:230: if (test == NULL) { sfl_agent_jumpTableAdd(agent, newsm); } ERROR: Inappropriate bracing around statement #698 FILE: lib/sflow_agent.c:259: if (prev) { prev->nxt = newpl; } WARNING: Line has trailing whitespace #960 FILE: ovsdb/ovsdb-client.c:1237: const struct ovsdb_column *version_column = Lines checked: 1674, Warnings: 1, Errors: 5 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] lib, ovsdb, ovs-vsctl, vtep-ctl: Fix multiple Coverity defects
>ifaces, iface_cfg->name); WARNING: Line is 87 characters long (recommended limit is 79) #1455 FILE: utilities/ovs-vsctl.c:874: /* Log as an error because this violates the database's WARNING: Line is 80 characters long (recommended limit is 79) #1456 FILE: utilities/ovs-vsctl.c:875: * uniqueness constraints, so the database server WARNING: Line is 85 characters long (recommended limit is 79) #1458 FILE: utilities/ovs-vsctl.c:877: VLOG_ERR("%s: database contains duplicate interface " WARNING: Line is 84 characters long (recommended limit is 79) #1492 FILE: utilities/ovs-vsctl.c:918: ctl_fatal("%s because an interface named %s already exists", msg, name); WARNING: Line is 83 characters long (recommended limit is 79) #1511 FILE: utilities/ovs-vsctl.c:977: if (iface && iface->port->bridge && !strcmp(name, iface->port->bridge->name)) { WARNING: Line is 80 characters long (recommended limit is 79) #1550 FILE: vtep/vtep-ctl.c:255: ctl_fatal("value %s on -t or --timeout is invalid", optarg); WARNING: Line is 82 characters long (recommended limit is 79) #1590 FILE: vtep/vtep-ctl.c:1085: * uniqueness constraints, so the database server shouldn't WARNING: Line is 84 characters long (recommended limit is 79) #1610 FILE: vtep/vtep-ctl.c:1099: vlan = xasprintf("%"PRId64, port_cfg->key_vlan_bindings[k]); Lines checked: 1648, Warnings: 28, Errors: 7 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] OpenFlow: Add extn to set conntrack entries limit per zone.
References: <20230313162258.60973-1-naveen.yerramn...@nutanix.com> Bleep bloop. Greetings Naveen Yerramneni, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author naveen.yerramneni needs to sign off. WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Naveen Yerramneni Lines checked: 335, Warnings: 1, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v5] utilities/ofctl: add-meters for save and restore
Bleep bloop. Greetings Wan Junjie, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #194 FILE: lib/ofp-meter.c:871: error = parse_ofp_meter_mod_str(&(*mms)[*n_mms], ds_cstr(), command, Lines checked: 691, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 6/6] netdev-dpdk-offload: Add support for meter action
References: <20230309130252.356289-7-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Jin Liu , Simon Horman Lines checked: 49, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 5/6] netdev-dpdk: add meter algorithms
References: <20230309130252.356289-6-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Jin Liu , Simon Horman Lines checked: 98, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 4/6] netdev-offload-dpdk: Implement meter offload API for DPDK
References: <20230309130252.356289-5-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Jin Liu , Simon Horman Lines checked: 410, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 3/6] dpif-netdev: Offloading meter with DPDK
References: <20230309130252.356289-4-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Jin Liu , Simon Horman Lines checked: 69, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 2/6] netdev-offload: Add DPDK meter offload API
References: <20230309130252.356289-3-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Jin Liu , Simon Horman Lines checked: 224, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 1/6] netdev-offload-dpdk: use flow transfer proxy
References: <20230309130252.356289-2-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Jin Liu , Simon Horman Lines checked: 147, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] northd: Use generic ct.est flows for LR LBs
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #438 FILE: northd/ovn-northd.8.xml:3380: ip ip.dst == VIP P Lines checked: 1304, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v3] dpdk: Allow retaining CAP_SYS_RAWIO privileges
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 98 characters long (recommended limit is 79) #113 FILE: lib/daemon-unix.c:839: VLOG_WARN("No driver requires Linux capability CAP_SYS_RAWIO, disabling it."); Lines checked: 415, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v4 7/7] ci: Replace clang jemalloc suite with system-test-userspace
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #28 FILE: .github/workflows/test.yml:50: - { compiler: gcc, testsuite: system-test-userspace, test_range: "-100" } WARNING: Line is 84 characters long (recommended limit is 79) #29 FILE: .github/workflows/test.yml:51: - { compiler: gcc, testsuite: system-test-userspace, test_range: "101-200" } WARNING: Line is 81 characters long (recommended limit is 79) #30 FILE: .github/workflows/test.yml:52: - { compiler: gcc, testsuite: system-test-userspace, test_range: "201-" } Lines checked: 37, Warnings: 3, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v6] ofproto-dpif-upcall: Wait for valid hw flow stats before applying min-revalidate-pps
Bleep bloop. Greetings Eelco Chaudron, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 ofproto-dpif-upcall: Wait for valid hw flow stats before applying min-revalidate-pps When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn branch-22.12] northd: Fix missig "); " from LB flows
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: "Fixes" tag is malformed. Use the following format: git log -1 --pretty=format:"Fixes: %h (\"%s\")" --abbrev=12 COMMIT_REF 11: Fixes: cd600de6 ("northd: Add flag for CT related.") Lines checked: 100, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] dpctl: Fix flush-conntrack with datapath as argument
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #28 FILE: lib/dpctl.c:1722: if (dp_arg_exists(argc, argv) ) { Lines checked: 58, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v2 2/3] ovn-util: Optimize is_dynamic_lsp_address.
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #52 FILE: lib/ovn-util.c:123: /* Either "dynamic ::" or "dynamic x.x.x.x ::". */ Lines checked: 71, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 ovn] northd: drop ct.inv packets in post snat and lb_aff_learn stages
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (tests/ovn.at). error: could not build fake ancestor hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 northd: drop ct.inv packets in post snat and lb_aff_learn stages When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v3 8/8] ci: Replace clang jemalloc suite with system-test-userspace
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #28 FILE: .github/workflows/test.yml:50: - { compiler: gcc, testsuite: system-test-userspace, test_range: "-100" } WARNING: Line is 84 characters long (recommended limit is 79) #29 FILE: .github/workflows/test.yml:51: - { compiler: gcc, testsuite: system-test-userspace, test_range: "101-200" } WARNING: Line is 81 characters long (recommended limit is 79) #30 FILE: .github/workflows/test.yml:52: - { compiler: gcc, testsuite: system-test-userspace, test_range: "201-" } Lines checked: 37, Warnings: 3, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v23 3/8] netdev-offload-tc: Introduce group ID management API
Bleep bloop. Greetings Chris Mi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #68 FILE: lib/netdev-offload-tc.c:140: if (node->sflow.tunnel) ERROR: Inappropriate bracing around statement #70 FILE: lib/netdev-offload-tc.c:142: if (node->sflow.action) ERROR: Inappropriate bracing around statement #72 FILE: lib/netdev-offload-tc.c:144: if (node->sflow.actions) ERROR: Inappropriate bracing around statement #74 FILE: lib/netdev-offload-tc.c:146: if (node->sflow.userdata) WARNING: Line is 81 characters long (recommended limit is 79) #95 FILE: lib/netdev-offload-tc.c:167: offload_sflow_equal(const struct offload_sflow *a, const struct offload_sflow *b) Lines checked: 308, Warnings: 1, Errors: 4 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn 2/3] ovn-util: Optimize is_dynamic_lsp_address.
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #52 FILE: lib/ovn-util.c:123: /* "dynamic x.x.x.x ::" */ WARNING: Comment with 'xxx' marker #59 FILE: lib/ovn-util.c:130: /* "dynamic ::" */ Lines checked: 78, Warnings: 2, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 ovn 1/2] northd: move defrag router pipeline stage forward
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 101 characters long (recommended limit is 79) #69 FILE: northd/northd.c:326: * | | (>= IP_INPUT)| | | E | NEXT_HOP_IPV6 (>= POST_DEFRAG ) | Lines checked: 1324, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 2/2] WIP
Bleep bloop. Greetings Paolo Valerio, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 1/2] cli: add option to display the version from Cargo.toml.
Bleep bloop. Greetings Paolo Valerio, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (src/cli/cli.rs). error: could not build fake ancestor hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 cli: add option to display the version from Cargo.toml. When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] ovs-dpctl: Add new command dpctl/ct-sweep-next-run.
Bleep bloop. Greetings Paolo Valerio, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 ovs-dpctl: Add new command dpctl/ct-sweep-next-run. When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] northd: add router broadcast option to logical switch
Bleep bloop. Greetings Felix Hüttner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Felix Hüttner needs to sign off. WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Felix Huettner WARNING: Line is 92 characters long (recommended limit is 79) #69 FILE: northd/northd.c:8968: if (!smap_get_bool(>nbs->other_config, "broadcast-arps-to-all-routers", true)) { Lines checked: 247, Warnings: 2, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] northd: fix comments on functions
Bleep bloop. Greetings Felix Hüttner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Felix Hüttner needs to sign off. WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Felix Huettner WARNING: Line is 80 characters long (recommended limit is 79) #49 FILE: northd/northd.c:8339: /* Ingress table 25/26: Destination lookup for unknown MACs (priority 0). */ Lines checked: 161, Warnings: 2, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [RFC] dpdk: Allow retaining cap_sys_rawio privileges
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 103 characters long (recommended limit is 79) #112 FILE: lib/daemon-unix.c:838: VLOG_WARN("hw port access requested, but no userspace ioport support. Dropping."); Lines checked: 390, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn 1/2] northd: move defrag router pipeline stage forward
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 101 characters long (recommended limit is 79) #69 FILE: northd/northd.c:326: * | | (>= IP_INPUT)| | | E | NEXT_HOP_IPV6 (>= POST_DEFRAG ) | Lines checked: 1324, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v2 7/7] ci: Replace clang jemalloc suite with system-test-userspace
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #27 FILE: .github/workflows/test.yml:50: - { compiler: gcc, testsuite: system-test-userspace, test_range: "-100" } WARNING: Line is 84 characters long (recommended limit is 79) #28 FILE: .github/workflows/test.yml:51: - { compiler: gcc, testsuite: system-test-userspace, test_range: "101-200" } WARNING: Line is 81 characters long (recommended limit is 79) #29 FILE: .github/workflows/test.yml:52: - { compiler: gcc, testsuite: system-test-userspace, test_range: "201-" } Lines checked: 36, Warnings: 3, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v4 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism
Bleep bloop. Greetings Ivan Malov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #50 FILE: lib/netdev-dpdk.c:1208: >flow_transfer_proxy_port_id, NULL); WARNING: Line is 80 characters long (recommended limit is 79) #95 FILE: lib/netdev-dpdk.c:4053: response = xasprintf("Device '%s' can not be detached (flow proxy)", ERROR: Inappropriate bracing around statement #102 FILE: lib/netdev-dpdk.c:4060: if (dev_self != NULL) WARNING: Line is 80 characters long (recommended limit is 79) #123 FILE: lib/netdev-dpdk.c:5524: ret = flow_transfer_proxy ? dev->flow_transfer_proxy_port_id : dev->port_id; WARNING: Line is 80 characters long (recommended limit is 79) #212 FILE: lib/netdev-dpdk.c:5709: ret = rte_flow_tunnel_action_decap_release(dev->flow_transfer_proxy_port_id, Lines checked: 415, Warnings: 4, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v4 2/3] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT
Bleep bloop. Greetings Ivan Malov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #28 FILE: lib/netdev-offload-dpdk.c:743: if (ethdev) Lines checked: 80, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v4 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism
Bleep bloop. Greetings Ivan Malov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #50 FILE: lib/netdev-dpdk.c:1208: >flow_transfer_proxy_port_id, NULL); WARNING: Line is 80 characters long (recommended limit is 79) #95 FILE: lib/netdev-dpdk.c:4053: response = xasprintf("Device '%s' can not be detached (flow proxy)", ERROR: Inappropriate bracing around statement #102 FILE: lib/netdev-dpdk.c:4060: if (dev_self != NULL) WARNING: Line is 80 characters long (recommended limit is 79) #123 FILE: lib/netdev-dpdk.c:5524: ret = flow_transfer_proxy ? dev->flow_transfer_proxy_port_id : dev->port_id; WARNING: Line is 80 characters long (recommended limit is 79) #212 FILE: lib/netdev-dpdk.c:5709: ret = rte_flow_tunnel_action_decap_release(dev->flow_transfer_proxy_port_id, Lines checked: 415, Warnings: 4, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v4 2/3] netdev-offload-dpdk: replace action PORT_ID with REPRESENTED_PORT
Bleep bloop. Greetings Ivan Malov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #28 FILE: lib/netdev-offload-dpdk.c:743: if (ethdev) Lines checked: 80, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] MAINTAINERS: Move myself to emeritus status
Bleep bloop. Greetings Russell Bryant, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 MAINTAINERS: Move myself to emeritus status When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] MAINTAINERS: Move myself to emeritus status
Bleep bloop. Greetings Russell Bryant, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 MAINTAINERS: Move myself to emeritus status When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v4] ofproto-dpif-xlate: Remove repeated function for judge garp
Bleep bloop. Greetings Han Ding, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #32 FILE: lib/flow.h:1136: if (!eth_addr_is_broadcast(FLOW_WC_GET_AND_MASK_WC(flow, wc, dl_dst))) { Lines checked: 109, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn 2/2] Prepare for post-23.03.0.
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Mark Michelson needs to sign off. Lines checked: 53, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn 1/2] Prepare for 23.03.0.
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Mark Michelson needs to sign off. Lines checked: 53, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn 7/7] ci: Replace clang jemalloc suite with system-test-userspace
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #27 FILE: .github/workflows/test.yml:50: - { compiler: gcc, testsuite: system-test-userspace, test_range: "-100" } WARNING: Line is 84 characters long (recommended limit is 79) #28 FILE: .github/workflows/test.yml:51: - { compiler: gcc, testsuite: system-test-userspace, test_range: "101-200" } WARNING: Line is 81 characters long (recommended limit is 79) #29 FILE: .github/workflows/test.yml:52: - { compiler: gcc, testsuite: system-test-userspace, test_range: "201-" } Lines checked: 36, Warnings: 3, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] conntrack:fix conntrack_clean may access the same exp_list each time be called
Bleep bloop. Greetings Liang Mancang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Liang Mancang needs to sign off. Lines checked: 39, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH branch-2.17 2/2] conntrack: Properly unNAT inner header of related traffic.
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Ilya Maximets Lines checked: 465, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH branch-3.0 2/2] conntrack: Properly unNAT inner header of related traffic.
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Ilya Maximets Lines checked: 463, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 2/2] ci: Run tc offload tests in GitHub Actions.
Bleep bloop. Greetings Eelco Chaudron, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 178 characters long (recommended limit is 79) #65 FILE: .github/workflows/build-and-test.yml:96: test_opts:"-k !'offloads - check interface meter offloading',!'offloads - check_pkt_len action',!'conntrack - force commit',!'conntrack - Multiple ICMP traverse'" Lines checked: 81, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v3] utilities: Add simple container automation
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 89 characters long (recommended limit is 79) #69 FILE: utilities/containers/Makefile:7: build: ;$(CONTAINER_CMD) build --no-cache --rm -t $(IMAGE_NAME) -f $(DISTRO)/Dockerfile . Lines checked: 296, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack
References: <20230213163539.4507-1-sangana.abhi...@nutanix.com> Bleep bloop. Greetings Abhiram Sangana, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 82 characters long (recommended limit is 79) #464 FILE: ovn-sb.xml:1412: ct_commit_drop { ct_mark=value[/mask]; }; WARNING: Line is 83 characters long (recommended limit is 79) #465 FILE: ovn-sb.xml:1413: ct_commit_drop { ct_label=value[/mask]; }; WARNING: Line is 116 characters long (recommended limit is 79) #466 FILE: ovn-sb.xml:1414: ct_commit_drop { ct_mark=value[/mask]; ct_label=value[/mask]; }; Lines checked: 862, Warnings: 3, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] controller: Prevent race in packet buffering
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Ales Musil needs to sign off. Lines checked: 1119, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v2] utilities: Add simple container automation
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 89 characters long (recommended limit is 79) #55 FILE: utilities/containers/Makefile:7: build: ;$(CONTAINER_CMD) build --no-cache --rm -t $(IMAGE_NAME) -f $(DISTRO)/Dockerfile . WARNING: Line is 86 characters long (recommended limit is 79) #250 FILE: utilities/containers/fedora/Dockerfile:46: RUN git clone git://git.kernel.org/pub/scm/devel/sparse/sparse.git /workspace/sparse \ WARNING: Line is 87 characters long (recommended limit is 79) #261 FILE: utilities/containers/fedora/Dockerfile:57: python3 -m pip install flake8 'hacking>=3.0' sphinx setuptools pyelftools pyOpenSSL Lines checked: 267, Warnings: 3, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v3 1/2] ofproto-ipfix: use per-domain template timeouts
Bleep bloop. Greetings Adrián Moreno, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #271 FILE: ofproto/ofproto-dpif-ipfix.c:2925: /* XXX: Make frequency of the (Options) Template and Exporter Process Lines checked: 319, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev