Re: [ovs-dev] [PATCH] rhel-systemd: Restart openvswitch service if a daemon crashes

t; ... Thanks for doing this, Eelco. Is it possible to add some of the information from the commit message to the README.RHEL.rst file, so that we can point people to it as expected behavior? Otherwise, Acked-by: Aaron Conole <acon...@redhat.com>

Re: [ovs-dev] [PATCH 1/3] rhel: Fix ifdown for OVSDPDKBond.

Daniele Di Proietto <diproiet...@vmware.com> writes: > The OVSDPDKBond case wasn't handled in the rhel ifdown script. > > Fixes: f6bf8880613a ("rhel: Add support DPDK port creation via network > scripts") > Signed-off-by: Daniele Di Proietto <diproiet...@vmware.

Re: [ovs-dev] [PATCH v2] libX.pc: use the correct output directory

Aaron Conole <acon...@redhat.com> writes: > When the ovsdb library pkgconfig changes were introduced, they placed > generated output in the src directory. This is incorrect, however, as > the output files should actually be placed in the build directory. It > is only seen

Re: [ovs-dev] [PATCH] selinux: Allow creating tap devices.

Daniele Di Proietto writes: > On 25/01/2017 00:01, "Ansis Atteka" wrote: > >>On Jan 25, 2017 4:22 AM, "Daniele Di Proietto" wrote: >> >>Current SELinux policy in RHEL and Fedora doesn't allow the creation of >>TAP devices.

[ovs-dev] [PATCH] ovs-tcpdump: Set mirror port mtu

) Reported-by: Dan Williams <d...@redhat.com> Signed-off-by: Aaron Conole <acon...@redhat.com> --- utilities/ovs-tcpdump.in | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in index a6e4ada..f0c0774

[ovs-dev] [PATCH] ovs-ctl: allow passing user:group to daemons

The Open vSwitch daemons allow passing --user user[:group] to allow spawning under different user privileges. ovs-ctl now accepts --ovs-user in the same form to pass this argument on, as well as create databases and data directories with the appropriate privileges. Signed-off-by: Aaron Conole

Re: [ovs-dev] [RFC] rhel/ifup: support vhost-user client mode

Aaron Conole <acon...@redhat.com> writes: > This adds support for ifup to configure client-mode sockets by exposing > two new variables $OVS_PORT_MODE and $OVS_PORT_PATH to the ifcfg > scripts. When OVS_PORT_MODE is set to 'client', the OVS_PORT_PATH will > be passed as the

Re: [ovs-dev] [PATCH 3/3] rhel: Fix ifup and ifdown after DPDK naming change.

Daniele Di Proietto writes: > On 02/02/2017 12:48, "Ben Pfaff" wrote: > >>On Tue, Jan 24, 2017 at 06:21:53PM -0800, Daniele Di Proietto wrote: >>> Names like dpdk0 and dpdk1 are not enough to identify a DPDK interface. >>> We could update README.RHEL.rst

Re: [ovs-dev] [PATCH] netdev-dpdk: Add support for DPDK 17.02

Ciara Loftus writes: > This commit announces support for DPDK 17.02. Compatibility with DPDK > v16.11 is not broken yet thanks to no code changes being needed for the > upgrade. > > Signed-off-by: Ciara Loftus > --- Is it possible to make this

Re: [ovs-dev] [PATCH 1/2] libX.pc: use the correct output directory

Ben Pfaff <b...@ovn.org> writes: > On Mon, Jan 16, 2017 at 02:06:26PM -0500, Aaron Conole wrote: >> When the ovsdb library pkgconfig changes were introduced, they placed >> generated output in the src directory. This is incorrect, however, as >> the output file

[ovs-dev] [PATCH 2/2] libX: add new release / version info tags

. ex: $ ldd /path/to/utility linux-vdso.so.1 (0x7ffe92cf6000) libopenvswitch-2.so.6 => /lib64/libopenvswitch-2.so.6 (0x7f733b7a3000) libssl.so.10 => /lib64/libssl.so.10 (0x7f733b53) ... Note the library name and version information. Signed-off-by:

[ovs-dev] [PATCH 0/2] Library support: refactor libtool versions

. This corrects an existing erroneous behavior in the system. Patch 2 introduces the versioning and ABI documentation. Aaron Conole (2): libX.pc: use the correct output directory libX: add new release / version info tags Documentation/automake.mk | 1 + .../internals

[ovs-dev] [PATCH 1/2] libX.pc: use the correct output directory

: `./configure --enable-shared`). Fixes: commit e72e07a97e95 ("lib: Add support for pkgconfig for libovsdb.") Signed-off-by: Aaron Conole <acon...@redhat.com> --- RFC to patch: Introduce this after catching the error while doing some testing. lib/automake.mk | 4 ++-- ofproto

Re: [ovs-dev] [PATCH] selinux: Allow creating tap devices.

Daniele Di Proietto <diproiet...@vmware.com> writes: > On 26/01/2017 12:35, "Ansis Atteka" <ansisatt...@gmail.com> wrote: >> >> >>On 26 January 2017 at 21:24, Aaron Conole >><acon...@redhat.com> wrote: >> >>Daniele Di Proietto

Re: [ovs-dev] [PATCH v2 2/4] ovs-tcpdump: should't halt when dumping traffic.

upporting this properly, so: Acked-by: Aaron Conole <acon...@redhat.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 4/4] ovs-tcpdump: Fix error handling when parsing parameter.

pipes.returncode) ? Either way, the change you have above should be applied, so: Acked-by: Aaron Conole <acon...@redhat.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 0/7] checkpatch: Misc. cleanups, and a new feature

Aaron Conole <acon...@bytheb.org> writes: > This series cleans up and clarifies certain issues in the checkpatch > infrastructure. Additionally, a fix for the some of the matches is included. > > The two features added by this series are: > 1. The ability to parse a n

Re: [ovs-dev] [PATCH] dpdk: Fix abort on double free.

rgv_release () at lib/dpdk.c:261 > #5 __run_exit_handlers () from /lib64/libc.so.6 > #6 exit () from /lib64/libc.so.6 > #7 __libc_start_main () from /lib64/libc.so.6 > #8 _start () > > Fix that by not calling free for the memory passed to DPDK. > > C

[ovs-dev] [RFC] Output refactor for customized displays

22.10 * 52.00 Catbert 5000.00 = 250.00 * 20.00 This can be tweaked by playing with the strings on lines 1193, and 1194 of tests/test-util.c to change the output. Aaron Conole (1): Printing Table Framework lib/uti

[ovs-dev] [RFC] Printing Table Framework

into 'rows'. Each column has a label (header). Data can then be extracted by specifying the exact column requested. Currently, the format strings supported are very basic. Data can be extracted by specifying a header name or column number within {} pairs. ex: {0} or {column0}. Signed-off-by: Aaron

Re: [ovs-dev] [RFC] Output refactor for customized displays

Ben Pfaff <b...@ovn.org> writes: > On Fri, Nov 18, 2016 at 05:22:27PM -0500, Aaron Conole wrote: >> During some recent face-to-face talks regarding debugging ovs, an issue >> was raised regarding the output. The gist of the conversation was that as >> it stands, ovs o

Re: [ovs-dev] [RFC v2] lib/table: add new flexible formatting

Ben Pfaff <b...@ovn.org> writes: > On Wed, Dec 07, 2016 at 10:55:54AM -0500, Aaron Conole wrote: >> Adds a new --format="xx={0},..." to the table library, which allows >> users to make table output formats to match their own needs. >> >> Sign

Re: [ovs-dev] [PATCH] dpdk: Fix abort on double free.

Daniele Di Proietto <diproiet...@vmware.com> writes: > On 29/11/2016 07:57, "Aaron Conole" <acon...@redhat.com> wrote: > >>Hi Ilya, >> >>Ilya Maximets <i.maxim...@samsung.com> writes: >> >>> On 28.11.2016 21:55, Aar

Re: [ovs-dev] [RFC v2] lib/table: add new flexible formatting

Ben Pfaff <b...@ovn.org> writes: > On Wed, Dec 07, 2016 at 01:08:43PM -0500, Aaron Conole wrote: >> Ben Pfaff <b...@ovn.org> writes: >> >> > On Wed, Dec 07, 2016 at 10:55:54AM -0500, Aaron Conole wrote: >> >> Adds a new --format="xx={0},...&qu

[ovs-dev] [RFC-PATCH 2/2] lib/dpdk: No more deferred release

DPDK documentation is recently updated to reflect that DPDK does not hold any references to, nor take ownership of, the argv/argc elements. With that understanding, let's just release the memory asap. Signed-off-by: Aaron Conole <acon...@redhat.com> --- NOTE: if the patch at http://dp

[ovs-dev] [PATCH 0/2] dpdk: fix memory release issues

: http://dpdk.org/ml/archives/dev/2016-December/051812.html), which aims to clarify the usage. If that's accepted, then I'd consider patch 2/2 to be non-RFC. Aaron Conole (2): lib/dpdk: fix double free on exit lib/dpdk: No more deferred release lib/dpdk.c | 21 ++--- 1 file

[ovs-dev] [PATCH 1/2] lib/dpdk: fix double free on exit

dk: Convert initialization from cmdline to db") Signed-off-by: Aaron Conole <acon...@redhat.com> --- lib/dpdk.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/dpdk.c b/lib/dpdk.c index 49a589a..28f3485 100644 --- a/lib/dpdk.c +++ b/lib/dpdk.c @@ -250,7 +

Re: [ovs-dev] [PATCH] rhel: Support building python ovs package with native json impl

Although I'm not Flavio, I do have some quick thoughts on this. Russell Bryant writes: > My main concern with this was that it implements a new python-ovs package > and leaves the existing one alone. I'd like to figure out how to change > the existing package so that we always

Re: [ovs-dev] [PATCH] dpctl: Fix usage for most dpctl commands.

ile changed, 10 insertions(+), 10 deletions(-) I didn't build this, but it looks good to me; so a big 'ol Reviewed-by: Aaron Conole <acon...@redhat.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [RFC v2] lib/table: add new flexible formatting

Ben Pfaff <b...@ovn.org> writes: > On Mon, Dec 12, 2016 at 08:11:16PM -0500, Aaron Conole wrote: >> Ben Pfaff <b...@ovn.org> writes: >> >> > On Wed, Dec 07, 2016 at 02:15:12PM -0500, Aaron Conole wrote: >> >> Ben Pfaff <b...@ovn.org> wr

Re: [ovs-dev] [PATCH] netdev-dpdk: Use intermediate queue during packet transmission.

Hi Bhanu, Bhanuprakash Bodireddy writes: > In exact match cache processing on an EMC hit, packets are queued in to > batches matching the flow. Thereafter, packets are processed in batches > for faster packet processing. This particularly is inefficient if

[ovs-dev] [RFC] libX: add new release / version info tags

ren <b...@skyportsystems.com> Signed-off-by: Aaron Conole <acon...@redhat.com> --- This is labelled as RFC. I'm not sure if it's appropriate to apply it to master before the 2.7 branch. configure.ac| 1 + lib/automake.mk | 4 ++-- m4/openvswitch.m4 | 18 ++ o

[ovs-dev] ABI versioning (was Re: [PATCH] rhel: Support...)

>> > Should we bump the libtool version now? We're nearing a release, so >> > it's about the right time. >> >> Sorry for the late response. I think it's probably appropriate to bump >> at least the libtool 'age'. I'm not sure what kinds of ABI changes have >> happened since introduction

Re: [ovs-dev] [PATCH] rhel: Support building python ovs package with native json impl

Ben Pfaff <b...@ovn.org> writes: > On Tue, Dec 13, 2016 at 01:45:05PM -0500, Aaron Conole wrote: >> Also, FYI (and this is sortof a side-note) the libtool ABI versioning >> information hasn't changed since 2014; bumping / managing that may >> become an additional

Re: [ovs-dev] [PATCH v2] netdev-dummy: Limits the number of tx/rx queues.

nickcooper-zhangtonghao writes: > This patch avoids the ovs_rcu to report WARN, caused by blocked > for a long time, when ovs-vswitchd processes a port with many > rx/tx queues. The number of tx/rx queues per port may be appropriate, > because the dpdk uses it as an default

Re: [ovs-dev] [PATCH v2] dpdk: Late initialization.

mory), so the user must >> check the status of the process after setting dpdk-init to true. >> >> Nonetheless, I think this is an improvement, because it doesn't require >> restarting the whole unit. >> >> CC: Aaron Conole <acon...@redhat.com <mailto:acon...@redhat

Re: [ovs-dev] [PATCH v2] dpdk: Late initialization.

require > restarting the whole unit. > > CC: Aaron Conole <acon...@redhat.com> > Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com> > --- > v1->v2: No change, first non-RFC post. > --- Looks good - just one minor detail below

[ovs-dev] [RFC v2] lib/table: add new flexible formatting

Adds a new --format="xx={0},..." to the table library, which allows users to make table output formats to match their own needs. Signed-off-by: Aaron Conole <acon...@redhat.com> --- v1 url: https://mail.openvswitch.org/pipermail/ovs-dev/2016-November/325235.html TODO: Still

Re: [ovs-dev] [RFC v2] lib/table: add new flexible formatting

Ben Pfaff <b...@ovn.org> writes: > On Tue, Dec 13, 2016 at 04:43:32PM -0500, Aaron Conole wrote: >> Ben Pfaff <b...@ovn.org> writes: >> >> > On Mon, Dec 12, 2016 at 08:11:16PM -0500, Aaron Conole wrote: >> >> Ben Pfaff <b...@ovn.org> wri

Re: [ovs-dev] [RFC] lib/automake.mk: remove runtime directories

Flavio Leitner <f...@sysclose.org> writes: > On Wed, Mar 22, 2017 at 12:43:29PM -0400, Eric Garver wrote: >> On Tue, Mar 21, 2017 at 02:20:30PM -0400, Aaron Conole wrote: >> > Aaron Conole <acon...@redhat.com> writes: >> > >> > > The Open

Re: [ovs-dev] [RFC] lib/automake.mk: remove runtime directories

Aaron Conole <acon...@redhat.com> writes: > The Open vSwitch run, log, and DB directories are installed as part of the > normal `make install` process. However, this means they are created with > user and group ownership that may conflict with the desired user. For > exam

Re: [ovs-dev] [RFC] checkpatch.py: look for misspellings in commit messages

Joe Stringer <j...@ovn.org> writes: > On 16 March 2017 at 15:27, Aaron Conole <acon...@redhat.com> wrote: >> Teach checkpatch to find misspellings based on the enchant framework. >> When a potential error is found, print some additional suggestions for >> fixup

Re: [ovs-dev] [PATCH] selinux: Allow creating tap devices.

Aaron Conole <acon...@redhat.com> writes: > Aaron Conole <acon...@redhat.com> writes: >> Daniele Di Proietto <diproiet...@vmware.com> writes: >>> On 26/01/2017 12:35, "Ansis Atteka" <ansisatt...@gmail.com> wrote: >>>>On 2

[ovs-dev] [PATCH 2/2] selinux: enable dpdk permissions

as template file to be built up based on options passed to configure. Signed-off-by: Aaron Conole <acon...@redhat.com> --- selinux/automake.mk | 1 + selinux/openvswitch-custom.te| 16 selinux/openvswitch-custom.te.i

Re: [ovs-dev] [PATCH] checkpatch.py: Fix false positive on if/when/for

Eric Garver writes: > We need to use == instead of the is operator. If you're unlucky it may > fail because they're not exactly the same object, but hold the same > value. > > Example false positive: > > E(120): Inappropriate bracing around statement > > +if (0 !=

Re: [ovs-dev] [RFC] lib/automake.mk: remove runtime directories

Markos Chandras <mchand...@suse.de> writes: > Hi Aaron, > > On 03/09/2017 03:35 PM, Aaron Conole wrote: >> The Open vSwitch run, log, and DB directories are installed as part of the >> normal `make install` process. However, this means they are created with >>

[ovs-dev] [RFC] checkpatch.py: look for misspellings in commit messages

Teach checkpatch to find misspellings based on the enchant framework. When a potential error is found, print some additional suggestions for fixups. Some additional keywords are kept in an extras list and added to the dictionary specific to the Open vSwitch project. Signed-off-by: Aaron Conole

[ovs-dev] [PATCH] dpctl: add examples to the manpage

Signed-off-by: Aaron Conole <acon...@redhat.com> --- lib/dpctl.man | 35 +++ 1 file changed, 35 insertions(+) diff --git a/lib/dpctl.man b/lib/dpctl.man index 2fcbc94..c5fdaa7 100644 --- a/lib/dpctl.man +++ b/lib/dpctl.man @@ -136,7 +136,42 @@ With \fB\-\-cl

Re: [ovs-dev] [PATCH 5/7] utils: Introduce xusleep for subsecond granularity.

"Bodireddy, Bhanuprakash" writes: >>Bhanuprakash Bodireddy writes: >> >>> This will be used by KA framework that needs millisecond granularity. >>> >>> Signed-off-by: Bhanuprakash Bodireddy >>>

Re: [ovs-dev] [PATCH 3/7] netdev-dpdk: Add support for keepalive functionality.

"Bodireddy, Bhanuprakash" writes: >>> >>> +/* >>> + * OVS Shared Memory structure >>> + * >>> + * The information in the shared memory block will be read by collectd. >>> + * */ >>> +struct dpdk_keepalive_shm { >>> +/* IPC semaphore. Posted when a core dies

Re: [ovs-dev] [PATCH 0/7] Add OVS DPDK keep-alive functionality

"Bodireddy, Bhanuprakash" writes: > Thanks Aaron for reviewing this patch series. My comments inline. > >> >>Hi Bhanu, >> >>Bhanuprakash Bodireddy writes: >> >>> This patch is aimed at achieving Fastpath Service Assurance in

Re: [ovs-dev] [PATCH 0/7] Add OVS DPDK keep-alive functionality

Hi Bhanu, Bhanuprakash Bodireddy writes: > This patch is aimed at achieving Fastpath Service Assurance in > OVS-DPDK deployments. This commit adds support for monitoring the packet > processing cores(pmd thread cores) by dispatching heartbeats at regular >

Re: [ovs-dev] [PATCH 3/7] netdev-dpdk: Add support for keepalive functionality.

Bhanuprakash Bodireddy writes: > This commit initializes the keepalive subsystem and spawns keepalive > thread that wakes up at regular intervals to update the timestamp and > status of pmd cores in shared memory. > > This patch implements POSIX shared memory

Re: [ovs-dev] [PATCH 5/7] utils: Introduce xusleep for subsecond granularity.

Bhanuprakash Bodireddy writes: > This will be used by KA framework that needs millisecond granularity. > > Signed-off-by: Bhanuprakash Bodireddy > --- Without this patch, builds starting at 3/7 will fail. That's pretty bad.

Re: [ovs-dev] [PATCH 4/7] process: Retrieve process status.

Bhanuprakash Bodireddy writes: > Implement function to retrieve the process status. This will be used by > Keepalive monitoring thread for detecting false alarms. > > Signed-off-by: Bhanuprakash Bodireddy > --- > lib/process.c

Re: [ovs-dev] [PATCH 1/7] dpdk: Add helper functions for DPDK keepalive.

Bhanuprakash Bodireddy writes: > Introduce helper functions in 'dpdk' module that are needed for > keepalive functionality. Also add dummy functions in 'dpdk-stub' module > that are needed when DPDK is not available. > > Signed-off-by: Bhanuprakash Bodireddy

Re: [ovs-dev] [RFC][PATCH] netdev-dpdk: add support for TSO

Hi Mark, Mark Kavanagh writes: > TCP Segmentation Offload (TSO) is a feature which enables > the TCP/IP network stack to delegate segmentation of a TCP > segment to the NIC, thus saving compute resources. > > This commit adds support for TSO in the DPDK vHost-User

Re: [ovs-dev] [PATCH 2/2] selinux: enable dpdk permissions

Hi Ansis, Ansis Atteka <ansisatt...@gmail.com> writes: > On 29 March 2017 at 12:25, Aaron Conole <acon...@redhat.com> wrote: > > Thanks for doing this. I should have probably built OVS with your patch, but > since my RHEL setup is down > at the moment, then I will d

[ovs-dev] [PATCH 1/2] install-doc: suggest to use ovs-ctl for start/stop

start/stop the daemons. The ovs-ctl script is already mentioned a bit in the install doc, so this just reinforces its use. Suggested-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Aaron Conole <acon...@redhat.com> --- Documentation/intro/install/dpdk.rst| 2 +- Documentation/i

[ovs-dev] [PATCH 0/2] installation: remove the runtime directories

://mail.openvswitch.org/pipermail/ovs-dev/2017-March/329600.html Aaron Conole (2): install-doc: suggest to use ovs-ctl for start/stop lib/automake.mk: don't install runtime directories Documentation/intro/install/dpdk.rst| 2 +- Documentation/intro/install/general.rst | 36

[ovs-dev] [PATCH 2/2] lib/automake.mk: don't install runtime directories

Chandras <mchand...@suse.de> Signed-off-by: Aaron Conole <acon...@redhat.com> --- lib/automake.mk | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/automake.mk b/lib/automake.mk index 62b2f38..faace79 100644 --- a/lib/automake.mk +++ b/lib/automake.mk @@ -534,10 +534,7 @@ EXTRA_DIST

Re: [ovs-dev] [PATCH] dpctl: add examples to the manpage

Joe Stringer <j...@ovn.org> writes: > On 21 March 2017 at 13:32, Aaron Conole <acon...@redhat.com> wrote: >> Signed-off-by: Aaron Conole <acon...@redhat.com> >> --- > > Hi Aaron, thanks for the patch. Feedback below, I can apply if you're > happy with

Re: [ovs-dev] [PATCH 1/2] install-doc: suggest to use ovs-ctl for start/stop

Ben Pfaff <b...@ovn.org> writes: > On Thu, Apr 13, 2017 at 01:51:29PM -0400, Aaron Conole wrote: >> The install documentation guided users to manually start/stop >> daemons. This is good information to have, but with the >> existence of ovs-ctl, is probably not the b

[ovs-dev] [PATCH v2 1/2] install-doc: suggest to use ovs-ctl for start/stop

start/stop the daemons. The ovs-ctl script is already mentioned a bit in the install doc, so this just reinforces its use. Suggested-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Aaron Conole <acon...@redhat.com> --- v1->v2: * Added the location of ovs-ctl script Documentation/intro/i

Re: [ovs-dev] [RFC][PATCH] netdev-dpdk: add support for TSO

"Kavanagh, Mark B" writes: >>Hi Mark, >> >>Mark Kavanagh writes: >> >>> TCP Segmentation Offload (TSO) is a feature which enables >>> the TCP/IP network stack to delegate segmentation of a TCP >>> segment to the NIC, thus saving compute

Re: [ovs-dev] [PATCH] checkpatch: fix pointer declaration

Ben Pfaff <b...@ovn.org> writes: > On Wed, Apr 19, 2017 at 05:42:58PM -0400, Aaron Conole wrote: >> Lance pointed to a problem where scripts were incorrectly being flagged as >> pointer spacing warnings. As an example, the text: >> >> --u*|-u) >>

[ovs-dev] [PATCH] rhel-systemd: start vswitchd after udev

(for instance vfio), and it requires manual intervention. Fixes: 36af136b690c ("rhel-systemd: Delay shutting down the services") Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1397299 Suggested-by: Flavio Leitner <f...@sysclose.org> Signed-off-by: Aaron Conole <

[ovs-dev] [PATCH v2 0/2] installation: remove the runtime directories

://mail.openvswitch.org/pipermail/ovs-dev/2017-March/329600.html v1->v2: * Discussion here: https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/330783.html * Modified install documentation to detail the location of ovs-ctl script Aaron Conole (2): install-doc: suggest to use ovs-ctl for st

[ovs-dev] [PATCH v2 2/2] lib/automake.mk: don't install runtime directories

, whereas the runtime user desired may be openvswitch:openvswitch. Since these directories are automatically created as part of the ovs-ctl command, and with the correct user:group permissions, it makes sense to delay creation until these directories are actually required. Signed-off-by: Aaron

[ovs-dev] [RFC v0 0/4] rhel/fedora: non-root OvS out of the box

This is presented as RFC (v0, since it will likely need changes) for initial feedback. Aaron Conole (4): rhel: allow arbitrary user:group fedora: dynamically allocate ovs user fedora: Also include the db lockfile fedora: allow dpdk to also run as non-root user rhel/openvswitch-fedora.spec.in

[ovs-dev] [RFC v0 4/4] fedora: allow dpdk to also run as non-root user

grows an uninit / reinit function, non-root ovs likely could never use it. Signed-off-by: Aaron Conole <acon...@redhat.com> --- rhel/openvswitch-fedora.spec.in | 25 rhel/usr_lib_systemd_system_ovs-vswitchd.service | 2 ++ 2 files changed, 27 inse

[ovs-dev] [RFC v0 1/4] rhel: allow arbitrary user:group

to root:root, but can be overridden by changing the /etc/sysconfig/openvswitch environment file. Signed-off-by: Aaron Conole <acon...@redhat.com> --- rhel/usr_lib_systemd_system_ovs-vswitchd.service | 4 rhel/usr_lib_systemd_system_ovsdb-server.service | 5 +

[ovs-dev] [RFC v0 3/4] fedora: Also include the db lockfile

automatically. This means that if no extra files exist in /etc/openvswitch, the whole directory will be removed from /etc/. Signed-off-by: Aaron Conole <acon...@redhat.com> --- rhel/openvswitch-fedora.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rhel/openvswitch-fedora.spec.in

Re: [ovs-dev] [PATCH] selinux: Allow creating tap devices.

Aaron Conole <acon...@redhat.com> writes: > Daniele Di Proietto <diproiet...@vmware.com> writes: > >> On 26/01/2017 12:35, "Ansis Atteka" <ansisatt...@gmail.com> wrote: >>> >>> >>>On 26 January 2017 at 21:24, Aaron Conole

Re: [ovs-dev] [PATCH v2] dpdk: Redirect DPDK log to OVS logging subsystem.

'dpdk-extra' field. > > Signed-off-by: Ilya Maximets <i.maxim...@samsung.com> > --- Worked fine for me so far. I'm going to keep running with this. Acked-by: Aaron Conole <acon...@redhat.com> -Aaron ___ dev mailing list d...@openvswitch.o

Re: [ovs-dev] [PATCH] ovs-tcpdump: Set mirror port mtu

Aaron Conole <acon...@redhat.com> writes: > When using ovs-tcpdump to mirror interfaces with MTU larger than the default, > Open vSwitch will lower the interfaces we are interested in monitoring. > Instead, probe the MTU and set the mirrored port's MTU value correctly. > >

Re: [ovs-dev] [PATCH 2/3] netdev-dpdk: Fix device leak on port deletion.

l.com> > Fixes: 55e075e65ef9 ("netdev-dpdk: Arbitrary 'dpdk' port naming") > Fixes: 69876ed78611 ("netdev-dpdk: Add support for virtual DPDK PMDs (vdevs)") > Signed-off-by: Ilya Maximets <i.maxim...@samsung.com> > --- Acked-by: Aaron Conole <acon...@redhat.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/3] netdev-dpdk: Fix double attaching of virtual devices.

quot;) > Signed-off-by: Ilya Maximets <i.maxim...@samsung.com> > --- Acked-by: Aaron Conole <acon...@redhat.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Use uint8_t for port_id.

here uint8_t expected. > > Such behaviour doesn't produce any issues, but it's better to > use same type as in dpdk library for consistency. > > Also, magic number '-1' replaced with DPDK_ETH_PORT_ID_INVALID > macro. > > Signed-off-by: Ilya Maximets <i.maxim...@

Re: [ovs-dev] [PATCH v3 3/6] makefile: create destdir when generating files

Ben Pfaff <b...@ovn.org> writes: > On Tue, Aug 01, 2017 at 06:05:40PM -0400, Aaron Conole wrote: >> When intermediary files are generated, the destination directory is assumed >> to exist. This has worked so far because most files are built prior to >> the dist-pa

Re: [ovs-dev] [PATCH v3 3/6] makefile: create destdir when generating files

Ben Pfaff <b...@ovn.org> writes: > On Wed, Aug 02, 2017 at 05:25:36PM -0400, Aaron Conole wrote: >> Ben Pfaff <b...@ovn.org> writes: >> >> > On Tue, Aug 01, 2017 at 06:05:40PM -0400, Aaron Conole wrote: >> >> When intermediary files are genera

[ovs-dev] [PATCH v3 6/6] redhat: allow dpdk to also run as non-root user

grows an uninit / reinit function, non-root ovs likely could never use it. This does not change OvS+DPDK's SELinux requirements. It still must be disabled. Signed-off-by: Aaron Conole <acon...@redhat.com> --- Documentation/intro/install/dpdk.rst| 7 +++

[ovs-dev] [PATCH v3 5/6] dpdkstrip: add a preprocessor tool for stripping dpdk blocks

-processor. For those files which are not, this commit adds a new pre-processor tool for .in files to either include or exclude those stanzas as appropriate. Signed-off-by: Aaron Conole <acon...@redhat.com> --- Makefile.am| 5 + build-aux/dpdkstrip.p

[ovs-dev] [PATCH v3 4/6] redhat: dynamic service file for vswitchd

This commit changes the service file from static configuration to an autogenerated file, produced during the build. This will be relevant in a future commit. Signed-off-by: Aaron Conole <acon...@redhat.com> --- rhel/.gitignore | 1 +

[ovs-dev] [PATCH v3 3/6] makefile: create destdir when generating files

is not available. This commit adds a 'mkdir -p' before generating the output files. Signed-off-by: Aaron Conole <acon...@redhat.com> --- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index 373ef6e..30794ff 100644 --- a/Makefile.am +++ b/Makefile.am @@ -139,6

[ovs-dev] [PATCH v3 0/6] rhel/fedora: non-root OvS out of the box

7-July/334946.html Refactor for the dpdk non-root user portion due to an issue discovered where the generated service file didn't honor new configuration when re-running ./configure. Also, converted the "Reviewed-by" to "Acked-by". This is because there is no such thing as Reviewed-

[ovs-dev] [PATCH v3 1/6] redhat: allow arbitrary user:group

to root:root, but can be overridden by changing the /etc/sysconfig/openvswitch environment file. Acked-by: Markos Chandras <mchand...@suse.de> Signed-off-by: Aaron Conole <acon...@redhat.com> --- rhel/automake.mk | 1 + rhel/etc_openvswitch_

[ovs-dev] [PATCH v3 2/6] redhat: dynamically allocate and reference ovs user

existing installations, the /etc/openvswitch directory will be created during the installation, rather than being provided as part of the rpm. Acked-by: Markos Chandras <mchand...@suse.de> Signed-off-by: Aaron Conole <acon...@redhat.com> --- rhel/openvswitch-fedora.spec.in

Re: [ovs-dev] [PATCH v3 2/2] rhel: delete transient ports on boot when starting ovsdb-server

Timothy Redaelli writes: > Use ovs-ctl --delete-transient-ports-on-boot to start ovsdb-server. > > This feature can be disabled by appending --no-delete-transient-ports-on-boot > to OPTIONS in /etc/sysconfig/openvswitch > > Signed-off-by: Timothy Redaelli

[ovs-dev] [PATCH] redhat: fix upgrades where group doesn't exist

, it was not there on others. This change allows the ExecStartPre commands to fail. In the case that the user doesn't use DPDK, it won't matter anyway. Fixes: e3e738a3d058 ('redhat: allow dpdk to also run as non-root user') Signed-off-by: Aaron Conole <acon...@redhat.com> Reported-by: Jean-Tsung Hsia

Re: [ovs-dev] pwclient XML errors and form feeds

ocument; however, > form-feeds are illegal in XML 1.0 [2]. This makes the use of form feeds and > the use of pwclient incompatible. > > Aaron Conole pointed out that once Patchwork 2.0 is available, the git-pw > command will render pwclient obsolete. I checked, and git-pw will use &g

Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.

Darrell Ball <db...@vmware.com> writes: > -Original Message- > From: Aaron Conole <acon...@redhat.com> > Date: Wednesday, August 9, 2017 at 12:51 PM > To: Darrell Ball <db...@vmware.com> > Cc: Joe Stringer <j...@ovn.org>, Darrell Ball <dlu...@g

Re: [ovs-dev] [PATCH] netdev-dpdk: include dpdk PCI header directly

Ben Pfaff <b...@ovn.org> writes: > On Wed, Aug 09, 2017 at 04:00:53PM -0400, Aaron Conole wrote: >> As part of a devargs rework in DPDK, the PCI header file was removed, and >> needs to be directly included. This isn't required to build with 17.05 or >> earlier,

Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.

Darrell Ball <db...@vmware.com> writes: > -Original Message- > From: Aaron Conole <acon...@redhat.com> > Date: Thursday, August 10, 2017 at 10:13 AM > To: Darrell Ball <db...@vmware.com> > Cc: ovs dev <d...@openvswitch.org> > Subject: Re: [ovs-

Re: [ovs-dev] [PATCH v2 0/4] rhel/fedora: non-root OvS out of the box

Aaron Conole <acon...@redhat.com> writes: > This series attempts to introduce the ability to start and use > Open vSwitch 'out of the box' as a non-root user. It does this by > modifying the service files to pass the recently introduced --ovs-user > argument around, and by

[ovs-dev] [PATCH] rhel/systemd: Set ovs-vswitchd timeout to 5 minutes

: ovs-vswitchd.service start operation timed out. Terminating. The 5 minutes setting has been observed to work on a system where 400G of hugepages were allocated. Signed-off-by: Aaron Conole <acon...@redhat.com> --- rhel/usr_lib_systemd_system_ovs-vswitchd.service | 1 + 1 file chan

Re: [ovs-dev] [PATCH] [RPM] Update openvswitch-kmod-fedora.spec

Hi Leif, Leif Madsen writes: > Update the kernel module spec file to better reflect how I'm > locally building the kmod RPM in mock and pushing it to COPR. > > These changes also better align with RPM linting and uses the > preferred macros for referring to the build root. >

Re: [ovs-dev] [PATCH] tests: Disable no-format-truncation warnings

Timothy Redaelli writes: > test_snprintf function (tests/test-util.c) tests snprintf with shorter length, > but this emit a warning on GCC 7.0 or later. > > This commit disables that warning on tests only. > > Signed-off-by: Timothy Redaelli > --- As

Re: [ovs-dev] [PATCH 2/4] checkpatch: Print results while checking HEAD and stdin.

Ilya Maximets <i.maxim...@samsung.com> writes: > Currently, result status printed only for patch files. > It'll be nice to have results for other checking types. > > Signed-off-by: Ilya Maximets <i.maxim...@samsung.com> > --- Acked-by: Aaron

Re: [ovs-dev] [PATCH 4/4] checkpatch: Print commit hashes and names.

Ilya Maximets <i.maxim...@samsung.com> writes: > It's better to see real commits instead of 'HEAD~n'. > > Signed-off-by: Ilya Maximets <i.maxim...@samsung.com> > --- Acked-by: Aaron Conole <acon...@redhat.com> ___ dev mai

  1   2   3   4   5   6   7   8   9   10   >