[ovs-dev] [RFC 2/2] rhel: tell ovsctl to freeze the datapath

This commit uses the previous to stop it from deleting active flows in the datapath. Signed-off-by: Aaron Conole <acon...@redhat.com> --- rhel/usr_lib_systemd_system_ovs-vswitchd.service.in | 2 +- utilities/ovs-ctl.in| 4 2 files changed, 5 insertions

[ovs-dev] [PATCH] flake8: Ignore bare except violations

And update the URL which lists error codes (and also points to additional sources for error codes). Signed-off-by: Aaron Conole <acon...@redhat.com> --- Makefile.am | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index d7cfdcd52..2c6

[ovs-dev] [PATCH] ovs-tcpundump: fix a conversion issue

When I tried using ovs-tcpundump, I got the following error message: Traceback (most recent call last): File ./ovs-tcpundump, line 64, in if m is None or int(m.group(1)) == 0: ValueError: invalid literal for int() with base 10: '00a0' Signed-off-by: Aaron Conole <acon...@redhat.

Re: [ovs-dev] [PATCH] flake8: Ignore bare except violations

Ben Pfaff <b...@ovn.org> writes: > On Fri, Jan 12, 2018 at 04:38:18PM -0500, Aaron Conole wrote: >> Ben Pfaff <b...@ovn.org> writes: >> >> > On Fri, Jan 12, 2018 at 03:39:58PM -0500, Aaron Conole wrote: >> >> And update the URL which lists error co

[ovs-dev] [PATCH v2] flake8: Ignore bare except violations

do not use bare except' python/ovs/timeval.py:51:1: E722 do not use bare except' python/ovstest/util.py:52:5: E722 do not use bare except' vtep/ovs-vtep:767:5: E722 do not use bare except' Signed-off-by: Aaron Conole <acon...@redhat.com> --- v1->v2: Include more informat

Re: [ovs-dev] [PATCH] flake8: Ignore bare except violations

Ben Pfaff <b...@ovn.org> writes: > On Fri, Jan 12, 2018 at 03:39:58PM -0500, Aaron Conole wrote: >> And update the URL which lists error codes (and also points to >> additional sources for error codes). >> >> Signed-off-by: Aaron Conole <acon...@redhat.com&

Re: [ovs-dev] [PATCH] rhel: Fix support for root user using DPDK

ng (so I cc'd Stephen). I manually applied this, and it works for me. Acked-by: Aaron Conole <acon...@redhat.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH V2] rhel: Fix support for root user using DPDK

Marcos Felipe Schwarz writes: > Since 2.8.0 OVS runs as non-root user on rhel distros, but the current > implementation breaks the ability to run as root with DPDK and as a > consequence there is no way possible to use UIO drivers on kernel 4.0 and > newer [1, 2]. > [1]

Re: [ovs-dev] [PATCH V3] rhel: Fix support for root user using DPDK

Aaron Conole <acon...@redhat.com> writes: > Ben Pfaff <b...@ovn.org> writes: > >> Well, is it ever useful to be able to drop unneeded capabilities while >> retaining the same uid/gid? It certainly sounds like a reasonable thing >> to want to do. I'm relu

Re: [ovs-dev] [patch v5 00/11] Userspace datapath: Add fragmentation support.

Hi Darrell, Darrell Ball writes: > Fragmentation support for userspace datapath conntrack is added; both > v4 and v6 are supported. See the patches for additional details. Very pumped about this! I went to start reviewing this, but found out that 04/ didn't apply correctly.

Re: [ovs-dev] [PATCH 1/8] doc: Add an overview of the 'dpdk' port

Hi Stephen, Stephen Finucane writes: > These ports are used to allow ingress/egress from the host and are > therefore _reasonably_ important. However, there is no clear overview of > what these ports actually are or why things are done the way they are. > Start closing this

[ovs-dev] [PATCH] rhel: don't drop capabilities when running as root

pdk to also run as non-root user") Signed-off-by: Aaron Conole <acon...@redhat.com> --- NOTE: I did test this a little bit on my system, passing packets, etc. But more eyes can't be bad. rhel/usr_lib_systemd_system_ovs-vswitchd.service.in | 7 --- rhel/usr_lib_systemd_syste

[ovs-dev] [PATCH] selinux: add a new target to build the policy

and issue the selinux "make -f" directive. This commit introduces a new target 'selinux-policy' which builds the openvswitch-custom policy files. Signed-off-by: Aaron Conole <acon...@redhat.com> --- rhel/openvswitch-fedora.spec.in | 4 +--- rhel/openvswitch.spec.in|

[ovs-dev] [PATCH] selinux: allow dpdkvhostuserclient sockets with newer libvirt

:s0 tclass=sock_file type=AVC msg=audit(1518816172.126:1318): avc: denied { connectto } for pid=32717 comm="ovs-vswitchd" path="/tmp/vhost0" scontext=system_u:system_r:openvswitch_t:s0 tcontext=system_u:system_r:svirt_t:s0:c106,c530 tclass=unix_stream_socke

Re: [ovs-dev] [patch v5 00/11] Userspace datapath: Add fragmentation support.

Darrell Ball <dlu...@gmail.com> writes: > On Fri, Feb 9, 2018 at 1:35 PM, Aaron Conole <acon...@redhat.com> wrote: > > Hi Darrell, > > Darrell Ball <dlu...@gmail.com> writes: > > > Fragmentation support for userspace datapath conntrack is add

Re: [ovs-dev] [PATCH] Set release dates for 2.9.0.

:49:31 -0700 > + -- Open vSwitch team <d...@openvswitch.org> Wed, 19 Feb 2018 11:03:12 -0700 Just a nit - 19 Feb is a Mon. :) Otherwise, Acked-by: Aaron Conole <acon...@redhat.com> > openvswitch (2.8.0-1) unstable; urgency=medium ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [branch-2.8 1/2] Set release date for 2.8.2.

Justin Pettit <jpet...@ovn.org> writes: > Signed-off-by: Justin Pettit <jpet...@ovn.org> > --- Acked-by: Aaron Conole <acon...@redhat.com> > NEWS | 4 ++-- > debian/changelog | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) >

Re: [ovs-dev] [branch-2.8 2/2] Prepare for 2.8.3.

Justin Pettit <jpet...@ovn.org> writes: > Signed-off-by: Justin Pettit <jpet...@ovn.org> > --- Acked-by: Aaron Conole <acon...@redhat.com> > NEWS | 4 > configure.ac | 2 +- > debian/changelog | 8 > 3 files changed, 13 inserti

Re: [ovs-dev] [branch-2.9] Prepare for 2.9.1.

Justin Pettit <jpet...@ovn.org> writes: > Signed-off-by: Justin Pettit <jpet...@ovn.org> > --- Acked-by: Aaron Conole <acon...@redhat.com> > NEWS | 4 > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 11 inserti

Re: [ovs-dev] [PATCH] Set release dates for 2.9.0.

Justin Pettit <jpet...@ovn.org> writes: >> On Feb 19, 2018, at 1:38 PM, Aaron Conole <acon...@redhat.com> wrote: >> >> Justin Pettit <jpet...@ovn.org> writes: >> >>> Signed-off-by: Justin Pettit <jpet...@ovn.org> >>> --- &

Re: [ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

Hi Matteo, Matteo Croce writes: > Show DPDK version if Open vSwitch is compiled with DPDK support. > Add a `dpdk_version` column in the datamodel, change ovs-ctl and ovs-dev.py > to populate the field with the right value. > > Signed-off-by: Matteo Croce >

Re: [ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

Matteo Croce <mcr...@redhat.com> writes: > On Tue, Jan 2, 2018 at 6:08 PM, Aaron Conole <acon...@redhat.com> wrote: >> Hi Matteo, >> >> Matteo Croce <mcr...@redhat.com> writes: >> >>> Show DPDK version if Open vSwitch is compiled with DPDK sup

Re: [ovs-dev] [PATCH 0/3] Initial support for new SIP Alg.

Tiago Lam writes: > This patch-set is an initial approach at implementing the new SIP Alg, > mentioned by Aaron at [1]. Thanks for this work, Tiago! > I'm mostly interested in getting to know your thoughts of how this is > headed. There are a couple of points that are worth

Re: [ovs-dev] Automated robotic reply. Re: ...

0-day Robot writes: > Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out your > patch > with message ID <1529454160-88413-1-git-send-email-jpet...@ovn.org> > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > >

Re: [ovs-dev] [PATCH] AUTHORS: Update email address for Jakub Sitnicki.

Jakub Sitnicki writes: > Signed-off-by: Jakub Sitnicki > --- > > The j...@redhat.com address will be valid only until August 4th. :'( With sadness: Acked-by: Aaron Conole > AUTHORS.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/A

Re: [ovs-dev] [PATCH] utilities: Run ovsdb-server pre-startup DB steps as root

Ben Pfaff writes: > I don't understand the conclusion in this thread. Does anyone want me > to apply some patch? Or should I stay tuned for further discussion? Stay tuned for the exciting conclusion, please :) > Thanks, > > Ben. ___ dev mailing

Re: [ovs-dev] [PATCH 1/9] tests: Simplify the setting of aliases.

Hi Ilya, Ilya Maximets writes: > There is no need to create a separate function for each alias. > This will simplify adding new default options and utils. > > Signed-off-by: Ilya Maximets > --- > tests/ovs-macros.at | 35 +-- > 1 file changed, 5 insertions(+),

Re: [ovs-dev] [PATCH] utilities: don't use a bashism to check that datapath exists

C: Martin Xu > Fixes: 9763d17fbd05 ("utilities: check datapath exists before conntrack > flush") > > Signed-off-by: Timothy Redaelli > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] Revert "dp-packet: Handle multi-seg mbufs in resize__()."

Ian Stokes writes: > On 7/25/2018 2:56 PM, Aaron Conole wrote: >> 0-day Robot writes: >> >>> Bleep bloop. Greetings Tiago Lam, I am a robot and I have tried out your >>> patch. >>> Thanks for your contribution. >>> >>> I encountere

Re: [ovs-dev] [PATCH v2 0/9] tests: Clean up syslog.

| 2 +- > tests/tunnel-push-pop.at | 2 +- > tests/vlog.at | 15 +-- > tests/vtep-ctl.at | 4 +- > 28 files changed, 463 insertions(+), 238 deletions(-) For the series: Acked-by: Aaron Conole As a note, I saw a mix of '--detach' and '&' being us

Re: [ovs-dev] [ovs-dev, v3, 2 of 6] ipsec: reintroduce IPsec support for tunneling

0-day Robot writes: > Bleep bloop. Greetings Qiuyu Xiao, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Too many signoffs; are you missing Co-authored-by

Re: [ovs-dev] [PATCH] selinux: more changes to support newer hugetlbfs restrictions

Timothy Redaelli writes: > The new 'map' action is needed for 'hugetlbfs_t:file' too. > > CC: Aaron Conole > Fixes: d2675a146130 ("selinux: changes to support newer hugetlbfs > restrictions") > > Signed-off-by: Timothy Redaelli > --- G

Re: [ovs-dev] [PATCH] ovn: Clean up log() action parsing errors.

Justin Pettit writes: >> On Jul 31, 2018, at 5:21 AM, Mark Michelson wrote: >> >> The 0-day Robot needs to lay off the pipe. > > Yeah, I'm not sure what was happening there. I emailed Aaron about it. Sorry about that. I'll work on protecting the list for when the robot indulges in

Re: [ovs-dev] robot suggestion

Ben Pfaff writes: > Today we've seen some failure reports from the robot because the build > was broken on master. That will happen occasionally (often, as in this > case, because the robot uses a GCC version different from the > submitter). Maybe the robot should even report it, probably in a

[ovs-dev] [PATCH 4/6] system-dpdk: Use a different character marker for sed commands

The default marker for sed commands according to the manual is /, but this is inconvenient when working with paths. The solution is either to escape all instances of / or use sed's \cREGEXc feature. Signed-off-by: Aaron Conole --- tests/system-dpdk.at | 14 +++--- 1 file changed, 7

[ovs-dev] [PATCH 0/6] system-dpdk: add support to ping two namespaces

This allows system-dpdk test suite to ping two namespaces via a pair of dpdkvhostuserclient ports, using testpmd as a forwarding agent. Currently, the final patch in the series (which adds the test) isn't reliable enough yet, so it is still RFC. Submitted for early feedback. Aaron Conole (3

[ovs-dev] [PATCH 1/6] system-dpdk: update test suite for non-phy testing

This allows a system that doesn't have a dedicated DPDK nic to execute some DPDK tests. In this fashion, tests that operate on virtual ports (such as dpdkvhostuserclient) can be executed in a wider set of environments. Signed-off-by: Aaron Conole --- tests/system-dpdk-macros.at | 18

[ovs-dev] [PATCH 3/6] system-dpdk: Allow running the dpdk tests from a VM

Some VM configurations result in CPU flags that cause warnings to be issued by the DPDK libraries. When these warnings are issued, the tests will fail. This commit adds the unreliable tsc warning to the list of ignored warnings. Signed-off-by: Aaron Conole --- tests/system-dpdk.at | 3 +++ 1

[ovs-dev] [PATCH 2/6] system-dpdk: skip all tests if there are no hugepages

From: Bala Sankaran A failure is quite harsh in this scenario. It's better to simply skip all the tests and let the user look at the logs to understand the missing hugepages. Signed-off-by: Bala Sankaran Co-authored-by: Aaron Conole Signed-off-by: Aaron Conole --- tests/system-dpdk

[ovs-dev] [RFC 6/6] system-dpdk: Connect two namespaces via virtio

From: Bala Sankaran This adds a new test to the 'check-dpdk' subsystem that will exercise allocations, PMDs, and the vhost-user code path. Signed-off-by: Bala Sankaran Co-authored-by: Aaron Conole Signed-off-by: Aaron Conole --- NOTE: This currently is broken, and needs some help to fix

[ovs-dev] [PATCH 5/6] system-dpdk: Convert /tmp to use OVS_RUNDIR

Conole Signed-off-by: Aaron Conole --- tests/system-dpdk.at | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at index 834ba06fb..58dc8aaae 100644 --- a/tests/system-dpdk.at +++ b/tests/system-dpdk.at @@ -54,20 +54,20 @@ OVS_DPDK_START

Re: [ovs-dev] [PATCH] selinux: changes to support newer hugetlbfs restrictions

Aaron Conole writes: > Newer selinux base policies now split out 'map' actions, as well as > adding more explicit checks for hugetlbfs objects. Where previously these > weren't required, recent changes have flagged the allocation of hugepages > and subsequent clearing.

Re: [ovs-dev] [PATCH] utilities: Run ovsdb-server pre-startup DB steps as root

Flavio Leitner writes: > On Wed, Jul 18, 2018 at 11:24:43AM -0400, Aaron Conole wrote: >> Markos Chandras writes: >> >> > When ovsdb-server is starting, it performs some DB steps such as >> > creating and upgrading the OvS DB. When we are running as >>

Re: [ovs-dev] [PATCH] utilities: Run ovsdb-server pre-startup DB steps as root

Markos Chandras writes: > Hello Aaron, > > On 18/07/18 16:24, Aaron Conole wrote: >> >> I think there's actually a race condition here. Most likely, >> ovsdb-server doesn't need to be started before network.service. >> >> Looking at the bug, I think

Re: [ovs-dev] [PATCH] unixctl: Style fix.

Ben Pfaff writes: > Reported-by: Aaron Conole > Signed-off-by: Ben Pfaff > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 1/3] unixctl: Make path to unixctl_server socket available to the client.

Ben Pfaff writes: > Acked-by: Alin Gabriel Serdean > Signed-off-by: Ben Pfaff > --- > lib/unixctl.c | 52 > lib/unixctl.h | 2 ++ > tests/daemon.at | 4 ++-- > 3 files changed, 32 insertions(+), 26 deletions(-) > > diff --git

Re: [ovs-dev] [PATCH v5 3/6] debian and rhel: Create IPsec package.

Ben Pfaff writes: > On Thu, Aug 09, 2018 at 06:31:31PM -0400, Aaron Conole wrote: >> Ben Pfaff writes: >> >> > On Thu, Aug 09, 2018 at 12:40:39PM -0700, Ansis Atteka wrote: >> >> On Tue, 7 Aug 2018 at 09:43, Qiuyu Xiao wrote: >> >> > >>

Re: [ovs-dev] [PATCH] checkpatch: Improve accuracy and specificity of sign-off checking.

Aaron Conole writes: > Ben Pfaff writes: > >> This also makes a start at a testsuite for checkpatch. >> >> CC: Aaron Conole >> Signed-off-by: Ben Pfaff >> --- > > I think it's close, but I still get this sort of error: > > 03:07:46 aconole {ips

Re: [ovs-dev] [PATCH] checkpatch: Improve accuracy and specificity of sign-off checking.

Ben Pfaff writes: > This also makes a start at a testsuite for checkpatch. > > CC: Aaron Conole > Signed-off-by: Ben Pfaff > --- I think it's close, but I still get this sort of error: 03:07:46 aconole {ipsec_selinux} ~/git/ovs$ ./utilities/checkpatch.py -1 == Checki

Re: [ovs-dev] [ovs-dev, Branch2.8] netdev-dpdk: Fix failure to configure flow control at netdev-init.

Hi Sugesh (and robot), 0-day Robot writes: > Bleep bloop. Greetings Sugesh Chandran, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > git-am: > Failed to merge in the changes. >

Re: [ovs-dev] [ovs-dev, Branch2.8] netdev-dpdk: Fix failure to configure flow control at netdev-init.

s. Thanks! > Regards > _Sugesh > > >> -----Original Message- >> From: Aaron Conole [mailto:acon...@bytheb.org] >> Sent: Thursday, August 9, 2018 2:15 PM >> To: 0-day Robot >> Cc: Chandran, Sugesh ; d...@openvswitch.org >> Subject: Re: [ovs-dev]

Re: [ovs-dev] [PATCH] vswitch.xml: Update dpdk-init documentation.

Kevin Traynor writes: > dpdk-init is now a string. Add description of 'true' and 'try'. > > Fixes: 3e52fa5644cd ("dpdk: reflect status and version in the database") > Cc: acon...@redhat.com > Signed-off-by: Kevin Traynor > --- Acked-by: Aaron C

Re: [ovs-dev] [PATCH v3] checkpatch: Improve accuracy and specificity of sign-off checking.

Ben Pfaff writes: > This also makes a start at a testsuite for checkpatch. > > CC: Aaron Conole > Signed-off-by: Ben Pfaff > --- Acked-by: Aaron Conole Thanks for this work, Ben! There's one more case that we could possibly consider (but it's rare enough that maybe it

Re: [ovs-dev] [PATCH v2 2/2] table: fix html buffer output

Aaron Conole writes: > Prior to this commit, html output exhibiits a doppler effect for Ironically, I duplicated an 'i' in the word exhibits here. Let me know if you want a respin or if it can be fixed while applying. :-x > content by continually printing strings passe

[ovs-dev] [PATCH v2 2/2] table: fix html buffer output

Prior to this commit, html output exhibiits a doppler effect for content by continually printing strings passed from table_print_html_cell. Fixes: cb139fa8b3a1 ("table: New function table_format() for formatting a table as a string.") Cc: Ben Pfaff Cc: Jakub Sitnicki Signed-off

[ovs-dev] [PATCH v2 1/2] table: append newline when printing tables

rry Wilson Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1608508 Signed-off-by: Aaron Conole Suggested-by: Ben Pfaff --- lib/table.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/table.c b/lib/table.c index cd811caf5..19bf89262 100644 --- a/lib/table.c +++ b/lib/tabl

Re: [ovs-dev] [PATCH] table: append newline when printing tables

Ben Pfaff writes: > On Tue, Aug 07, 2018 at 06:23:12PM -0400, Aaron Conole wrote: >> With commit cb139fa8b3a1 ("table: New function table_format() for >> formatting a table as a string.") a new mechanism for formatting >> tables was introduced, and the table_print

Re: [ovs-dev] [ovs-dev,v3] tests: Test for ovs-ofctl snoop command

Ashish Varma writes: > Hi Aaron, > > My patch is already committed by Ben. Not sure what is wrong here. Thanks for the heads up. This happens - usually if the patch is committed before the bot has run against it. I have it on my list of TODOs, so as soon as my next 'work on the bot' time

[ovs-dev] [PATCH] table: append newline when printing tables

rry Wilson Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1608508 Signed-off-by: Aaron Conole --- NOTE: I chose to keep the fputs and insert an additional fputs. It might alternately be appropriate to change fputs() to puts(). Dealer's choice, I guess :) lib/table.c | 1

[ovs-dev] [PATCH] ovn-ctl: allow configuring user:group for daemons

Add two options, one for controlling the ovs daemon user/group, and the other for controlling the ovn daemon user/group. This allows a fine-grained split between OVN and OVS daemons, and keeps the syntax and user/group separation from ovs-ctl when running ovn-ctl. Signed-off-by: Aaron Conole

Re: [ovs-dev] [PATCH v3] checkpatch: Improve accuracy and specificity of sign-off checking.

Ben Pfaff writes: > On Sun, Aug 12, 2018 at 07:43:14AM -0700, Ben Pfaff wrote: >> On Sat, Aug 11, 2018 at 09:54:01AM -0400, Aaron Conole wrote: >> > Ben Pfaff writes: >> > >> > > This also makes a start at a testsuite for checkpatch. >> > >

Re: [ovs-dev] [ovs-dev, v5, 08 of 20] ovn-controller: Incremental logical flow processing

0-day Robot writes: > Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > git-am: > fatal: sha1 information is lacking or useless

Re: [ovs-dev] [ovs-dev, v5, 08 of 20] ovn-controller: Incremental logical flow processing

Aaron Conole writes: > 0-day Robot writes: > >> Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your >> patch. >> Thanks for your contribution. >> >> I encountered some error that I wasn't expecting. See the details below. >>

Re: [ovs-dev] [ovs-dev, v4, 05 of 20] ovn-controller: Incremental processing engine

Han Zhou writes: > On Mon, Aug 13, 2018 at 1:04 AM, 0-day Robot wrote: >> >> Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your > patch. >> Thanks for your contribution. >> >> I encountered some error that I wasn't expecting. See the details below. >> >> >> checkpatch: >>

Re: [ovs-dev] [ovs-dev, v4, 20 of 20] ovn-performance.at: Test port group incremental processing.

Han Zhou writes: > On Mon, Aug 13, 2018 at 1:06 AM, 0-day Robot wrote: >> >> Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your > patch. >> Thanks for your contribution. >> >> I encountered some error that I wasn't expecting. See the details below. >> >> >> git-am: >>

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

Ian Stokes writes: > On 8/15/2018 10:51 AM, Ophir Munk wrote: >> Hi, >> Please find comments inline. >> >>> -Original Message- >>> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- >>> boun...@openvswitch.org] On Behalf Of Stokes, Ian >>> Sent: Tuesday, August 14, 2018 7:42 PM >>>

Re: [ovs-dev] [PATCH] conntrack.c: Add missing return value check to prevent nptr dereference.

Jiecheng Wu writes: > Function ovs_ct_limit_cmd_get() defined in net/openvswitch/conntrack.c may > cause a null pointer dereference as it calls nla_nest_start which may return > NULL. The returned value is used in function nla_nest_end() later where the > pointer is dereferenced. > --- >

Re: [ovs-dev] compat: Substitute more dependable define

0-day Robot writes: > Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Committer 0-day Robot needs to sign off. > Lines

Re: [ovs-dev] [PATCH] Fix socket permissions on Linux

Terry Wilson writes: > On Thu, Aug 16, 2018 at 4:57 PM, Ben Pfaff wrote: >> On Thu, Aug 16, 2018 at 07:55:09PM +, Terry Wilson wrote: >>> Unix sockets were not being created with the permission 0770, >>> instead using the current umask value. The manpage for fchmod() >>> states that that if

Re: [ovs-dev] [PATCH] utilities: Launch ovsdb-tool without using PAM

and the remaining group > IDs are used as supplementary groups (usually "hugetlbfs", if OVS is > built with DPDK support). > > [1]: https://bugzilla.suse.com/show_bug.cgi?id=1098630 > Reported-by: Markos Chandras > Reported-at: > https://mail.openvswitch.org/pipermail/

Re: [ovs-dev] [PATCH] ovs-ofctl: Better validate OpenFlow message length in "ofp-parse-pcap".

Ben Pfaff writes: > Reported-by: Oscar Wilde > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2018-July/047070.html > Signed-off-by: Ben Pfaff > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvs

Re: [ovs-dev] [PATCH v5 3/6] debian and rhel: Create IPsec package.

Ben Pfaff writes: > On Thu, Aug 09, 2018 at 12:40:39PM -0700, Ansis Atteka wrote: >> On Tue, 7 Aug 2018 at 09:43, Qiuyu Xiao wrote: >> > >> > Added rules and files to create debian and rpm ovs-ipsec packages. >> > >> > Signed-off-by: Qiuyu Xiao >> > Signed-off-by: Ansis Atteka >> >

Re: [ovs-dev] [PATCH] Fix socket permissions on Linux

Terry Wilson writes: >> Gather 'round folks, and let me tell you the tale of a series long >> ago posted: >> >> https://mail.openvswitch.org/pipermail/ovs-dev/2016-August/321866.html >> >> Something... something ... black magic... >> I think the fchmod needs to happen after the bind for the

Re: [ovs-dev] utilities: Drop shebang from bash completion script

Markos Chandras writes: > On 28/08/18 12:57, 0-day Robot wrote: >> Bleep bloop. Greetings Markos Chandras, I am a robot and I have >> tried out your patch. >> Thanks for your contribution. >> >> I encountered some error that I wasn't expecting. See the details below. >> >> >> checkpatch: >>

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

Ian Stokes writes: > On 8/27/2018 5:16 PM, Ben Pfaff wrote: >> I can help with some of these. >> >> On Mon, Aug 27, 2018 at 04:05:39PM +, Ophir Munk wrote: >>> Ian, can you please specify the practical steps regarding the new branches? >>> Specifically, what is the procedure for adding a new

[ovs-dev] [PATCH v2 5/6] system-dpdk: Convert /tmp to use OVS_RUNDIR

Conole Signed-off-by: Aaron Conole --- tests/system-dpdk.at | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at index 834ba06fb..58dc8aaae 100644 --- a/tests/system-dpdk.at +++ b/tests/system-dpdk.at @@ -54,20 +54,20 @@ OVS_DPDK_START

[ovs-dev] [PATCH v2 4/6] system-dpdk: Use a different character marker for sed commands

The default marker for sed commands according to the manual is /, but this is inconvenient when working with paths. The solution is either to escape all instances of / or use sed's \cREGEXc feature. Signed-off-by: Aaron Conole --- tests/system-dpdk.at | 14 +++--- 1 file changed, 7

[ovs-dev] [PATCH v2 6/6] system-dpdk: Execute testpmd on the background

From: Bala Sankaran This adds a new test to the 'check-dpdk' subsystem that will exercise allocations, PMDs, and the vhost-user code path. Signed-off-by: Bala Sankaran Co-authored-by: Aaron Conole Signed-off-by: Aaron Conole --- tests/system-dpdk.at | 77

[ovs-dev] [PATCH v2 0/6] system-dpdk: add support to ping two namespaces

testsuite to make it easier to use. Aaron Conole (3): system-dpdk: update test suite for non-phy testing system-dpdk: Allow running the dpdk tests from a VM system-dpdk: Use a different character marker for sed commands Bala Sankaran (3): system-dpdk: skip all tests if there are no hugepages

[ovs-dev] [PATCH v2 3/6] system-dpdk: Allow running the dpdk tests from a VM

Some VM configurations result in CPU flags that cause warnings to be issued by the DPDK libraries. When these warnings are issued, the tests will fail. This commit adds the unreliable tsc warning to the list of ignored warnings. Signed-off-by: Aaron Conole --- tests/system-dpdk.at | 3 +++ 1

[ovs-dev] [PATCH v2 1/6] system-dpdk: update test suite for non-phy testing

This allows a system that doesn't have a dedicated DPDK nic to execute some DPDK tests. In this fashion, tests that operate on virtual ports (such as dpdkvhostuserclient) can be executed in a wider set of environments. Signed-off-by: Aaron Conole --- tests/system-dpdk-macros.at | 18

[ovs-dev] [PATCH v2 2/6] system-dpdk: skip all tests if there are no hugepages

From: Bala Sankaran A failure is quite harsh in this scenario. It's better to simply skip all the tests and let the user look at the logs to understand the missing hugepages. Signed-off-by: Bala Sankaran Co-authored-by: Aaron Conole Signed-off-by: Aaron Conole --- tests/system-dpdk

Re: [ovs-dev] [PATCH] Documentation:

Gregory Rose writes: > On 7/18/2018 8:03 AM, Aaron Conole wrote: >> Hi Greg, >> >> Greg Rose writes: >> >>> Add netstat when mentioning testing. Many check-kmod failures result >>> when it is not present. >>> >>> Signed-off-by:

Re: [ovs-dev] [PATCH] Documentation:

Hi Greg, Greg Rose writes: > Add netstat when mentioning testing. Many check-kmod failures result > when it is not present. > > Signed-off-by: Greg Rose > --- Just wanted to point out that the subject looks incomplete. Otherwise: Acked-b

Re: [ovs-dev] [PATCH V2] Documentation: Add netstat to testing instructions

Greg Rose writes: > Add netstat when mentioning testing. Many check-kmod failures result > when it is not present. > > Signed-off-by: Greg Rose > > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://ma

[ovs-dev] [PATCH] selinux: changes to support newer hugetlbfs restrictions

for the DPDK .rte_config, and clearing actions copying from /dev/zero will trigger selinux denials. This commit allows openvswitch to have more permissions for the hugetlbfs allocation and use. Signed-off-by: Aaron Conole --- NOTE: I seem to have lost the system with the logs that were used

Re: [ovs-dev] build: Add gitattribute file to build-aux

Hi Alin, 0-day Robot writes: > Bleep bloop. Greetings Alin Gabriel Serdean, I am a robot and I have tried > out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > I suggest folding in something like the following

Re: [ovs-dev] [PATCH] utilities: Run ovsdb-server pre-startup DB steps as root

rkaround this by switching to 'root' user when we are > performing this pre-startup steps and fixup the DB permissions before > we start the actual ovsdb-server daemon. > > [1]: https://bugzilla.suse.com/show_bug.cgi?id=1098630 > Cc: Aaron Conole > Signed-off-by: Markos Chandr

[ovs-dev] [PATCH] netlink-conntrack: undef the correct macro

Fixes: 6830a0c0e6bf ("netlink-conntrack: New module.") Cc: Daniele Di Proietto Signed-off-by: Aaron Conole --- lib/netlink-conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netlink-conntrack.c b/lib/netlink-conntrack.c index e5a5fc118..42be1d

Re: [ovs-dev] [PATCH v2] build: Add gitattribute file to build-aux

a .gittatribute file to build-aux to force LF endings > on Windows. > > Signed-off-by: Alin Gabriel Serdean > Co-authored-by: Aaron Conole > --- Signed-off-by: Aaron Conole Thanks, Alin! ___ dev mailing list d...@openvswitch.org https:

Re: [ovs-dev] Introduce ovs-appctl command to monitor HVs sb connection status

0-day Robot writes: > Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have > tried out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Too many signoffs; are you missing

Re: [ovs-dev] [PATCH] netlink-conntrack: undef the correct macro

Ben Pfaff writes: > On Mon, Jul 23, 2018 at 04:40:49PM -0400, Aaron Conole wrote: >> Fixes: 6830a0c0e6bf ("netlink-conntrack: New module.") >> Cc: Daniele Di Proietto >> Signed-off-by: Aaron Conole > > Thanks, applied to master. > > I didn't backport

Re: [ovs-dev] Revert "dp-packet: Handle multi-seg mbufs in resize__()."

0-day Robot writes: > Bleep bloop. Greetings Tiago Lam, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > Hi Ian (and all), Given there are currently two trees (mainline and

Re: [ovs-dev] dpif-netdev: Fix zero length keys insertion to EMC.

0-day Robot writes: > Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > This isn't an issue with your patch, Ilya. The current mainline has a

[ovs-dev] [PATCH] dpif-netdev: compatible function type

initialization for 'dpif_netdev_class.flow_dump_create') [-Werror] Fixes: ab15e70eb587 ("dpctl: Expand the flow dump type filter") Cc: Gavi Teitz Cc: Roi Dayan Cc: Simon Horman Signed-off-by: Aaron Conole --- lib/dpif-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [ovs-dev] [PATCH v2] tc: Fix sparse warnings.

on Horman > Fixes: 61e8655cfc7a ("tc: Add VLAN tpid for push action") > Signed-off-by: Ben Pfaff > --- Looks good - passed with sparse 0.5.2 Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [RFC] Federating the 0-day robot, and improving the testing

As of June, the 0-day robot has tested over 450 patch series. Occasionally it spams the list (apologies for that), but for the majority of the time it has caught issues before they made it to the tree - so it's accomplishing the initial goal just fine. I see lots of ways it can improve.

Re: [ovs-dev] [PATCH v3 6/6] system-dpdk: Connect network namespaces via dpdkvhostuser ports

K moves to v18.11. > Hello Tiago, > > I agree, I did not happen to notice a workaround for this. > >> >> On 28/08/2018 18:47, Bala Sankaran wrote: >> > This adds a new test to the 'check-dpdk' subsystem that will exercise >> > allocations, PMDs, and the vhost

Re: [ovs-dev] [PATCH] ofproto: Return error codes for Rule insertions

Hi Arvind, Aravind Prasad writes: > Currently, rule_insert() API doesnot have return value. There are some > possible > scenarios where rule insertions can fail at run-time even though the static > checks during rule_construct() had passed previously. > > Some possible scenarios for failure of

Re: [ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.9

0-day Robot writes: > Bleep bloop. Greetings Ian Stokes, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Too many signoffs; are you missing Co-authored-by

<    1   2   3   4   5   6   7   8   9   10   >