Re: [ovs-dev] [v2] odp: Add datapath clone action parser.

On Wed, Feb 1, 2017 at 2:07 PM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Feb 01, 2017 at 01:36:33PM -0800, Andy Zhou wrote: >> When adding userspace datapath clone action, the corresponding odp >> actions parser and unit tests were missing. This patch adds them. >> &

[ovs-dev] [v2] odp: Add datapath clone action parser.

When adding userspace datapath clone action, the corresponding odp actions parser and unit tests were missing. This patch adds them. Reported-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- v1->v2: Be more tolerate of white spaces. Tested with:

Re: [ovs-dev] [PATCH] odp: Add datapath clone action parser.

On Wed, Feb 1, 2017 at 9:45 AM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Jan 31, 2017 at 08:24:02PM -0800, Andy Zhou wrote: >> When adding userspace datapath clone action, the corresponding odp >> actions parser and unit tests were missing. This patch adds them. >> &

Re: [ovs-dev] [PATCH] odp: Fix sample action in userspace

On Thu, Feb 2, 2017 at 10:56 AM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Jan 11, 2017 at 04:00:04PM -0800, Andy Zhou wrote: >> User space implementation of the sample action is not consistent with >> kernel datapath. In kernel datapath, the side effects of actions >>

Re: [ovs-dev] [PATCH 2/2] ovs-vsctl: Disallow empty bridge, port, and interface names.

On Fri, Feb 3, 2017 at 9:06 AM, Ben Pfaff <b...@ovn.org> wrote: > Reported-by: Gabor Locsei <gabor.loc...@ericsson.com> > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2017-February/043613.html > Signed-off-by: Ben Pfaff <b...@ovn.org> Acke

Re: [ovs-dev] [PATCH] ovn: fix slave node can not connect to the master node using SSL, for pacemaker

On Tue, Jan 31, 2017 at 3:51 PM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Jan 31, 2017 at 03:44:38PM -0800, Andy Zhou wrote: >> On Wed, Jan 11, 2017 at 4:11 AM, Guoshuai Li <l...@dtdream.com> wrote: >> > The default slave node connect to the master node using TCP, an

[ovs-dev] [PATCH] odp: Add datapath clone action parser.

When adding userspace datapath clone action, the corresponding odp actions parser and unit tests were missing. This patch adds them. Reported-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- Note: back port to branch-2.7 --- lib/odp

Re: [ovs-dev] [PATCH 4/4] uuid: New macro UUID_ZERO for an all-zero expression or initializer.

On Wed, Feb 8, 2017 at 8:32 AM, Ben Pfaff <b...@ovn.org> wrote: > This is convenient in expressions, e.g. "uuid = x ? *x : UUID_ZERO;". > > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Andy Zhou <az...@ovn.org> _

Re: [ovs-dev] [PATCH 3/4] jsonrpc: Fix capitalization of parameter name.

On Wed, Feb 8, 2017 at 8:32 AM, Ben Pfaff <b...@ovn.org> wrote: > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCHv2 1/2] ovs-router: fix memory leak reported by valgrind.

delete (ovs-router.c:274) > ovs_router_del (ovs-router.c:384) > process_command (unixctl.c:313) > > Signed-off-by: William Tu <u9012...@gmail.com> Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/4] smap: Improve comment on SMAP_CONST1, SMAP_CONST2 macros.

On Wed, Feb 8, 2017 at 8:32 AM, Ben Pfaff <b...@ovn.org> wrote: > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 3/3] ovsdb: Prevent OVSDB server from replicating itself.

On Wed, Feb 8, 2017 at 3:25 PM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Feb 08, 2017 at 03:15:51PM -0800, Andy Zhou wrote: >> On Wed, Feb 8, 2017 at 11:40 AM, Ben Pfaff <b...@ovn.org> wrote: >> > In replication_init(), I'd use "=" to copy the uuid,

Re: [ovs-dev] [PATCH 3/3] ovsdb: Prevent OVSDB server from replicating itself.

On Wed, Feb 8, 2017 at 11:40 AM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Feb 07, 2017 at 08:40:22PM -0800, Andy Zhou wrote: >> Replication OVSDB server from itself is usually caused by configuration >> errors. Such configuration errors can lead to OVSDB server data l

Re: [ovs-dev] [PATCHv2 2/2] ovs-ofctl: fix memory leak reported by valgrind.

On Wed, Feb 8, 2017 at 11:40 AM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Feb 08, 2017 at 11:24:28AM -0800, Andy Zhou wrote: >> On Wed, Feb 8, 2017 at 7:03 AM, William Tu <u9012...@gmail.com> wrote: >> > Testcase 1057 ofproto-dpif - fragment handling - upcall r

[ovs-dev] [PATCH 3/3] ovsdb: Prevent OVSDB server from replicating itself.

.@dtdream.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-January/326963.html Suggested-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/jsonrpc-server.c | 8 +++ ovsdb/ovsdb-server.1.in | 29

[ovs-dev] [PATCH 2/3] ovsdb: Add OVSDB server per instance UUID.

Currently, there is no way for an OVSDB server to ID itself. This patch adds a UUID field that is populated every time OVSDB server runs. Later patch will make use this UUID to detect and stop and OVSDB server from replicating itself. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/j

[ovs-dev] [PATCH 1/3] ovsdb: Gracefully handle replication errors.

the replication session, and leave the OVSDB server up, so that the replication can be restarted, may be with a different configuration, at a later time. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/ovsdb-server.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ovsdb

Re: [ovs-dev] [PATCH] ovsdb: fix data loss when OVSDB replication from itself

On Mon, Feb 6, 2017 at 5:31 PM, 克赛号0181 wrote: > In K8S, Pacemaker is not used usally, we use keepalived to implement the VIP > (OVN service endpoint)，when master nodes fails, the VIP switched earlier > than we notice such event, > so, the new master node will connect itself in

Re: [ovs-dev] [PATCH] ovsdb: fix data loss when OVSDB replication from itself

On Mon, Jan 2, 2017 at 7:09 PM, Guoshuai Li wrote: > Delete the local database after receiving the master data, > this is safer for data. > This patch is used by HA cluster that have no way to > control the order of resources, such as kubernetes. > > Signed-off-by: Guoshuai Li

Re: [ovs-dev] [PATCH] ovn: fix slave node can not connect to the master node using SSL, for pacemaker

to the > master node using a different protocol and port. > > Signed-off-by: Guoshuai Li <l...@dtdream.com> > --- LGTM, Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [userspace meter v2 2/5] dp-packet: Enhance packet batch APIs.

. Add macros to support this use case. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/dp-packet.h | 140 --- lib/dpif-netdev.c| 56 - lib/dpif.c | 2 +- lib/netdev-dummy.c | 10 ++-

Re: [ovs-dev] [userspace clone v3 3/4] dpif-netdev: Add clone action

On Mon, Jan 23, 2017 at 2:13 PM, Jarno Rajahalme wrote: > With minor notes below: > > Acked-by: Jarno Rajahalme > Thanks for the review. I have fixed the two style issues and pushed to all 4 patches. ___ dev mailing list

[ovs-dev] [userspace meter v2 1/5] netdev-dummy: Add --len option for netdev-dummy/receive command

h. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/netdev-dummy.c | 38 -- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index e6e36cd..10df0a7 100644 --- a/lib/netdev-dummy.c +++ b/lib/netdev-dumm

[ovs-dev] [userspace meter v2 0/5] userspace meter

Repost user space meter support. This is based Jarno's original work at: https://mail.openvswitch.org/pipermail/ovs-dev/2015-November/306304.html. With some enhancements, and rebased to current master. --- v1-v2: rebase and repost. Andy Zhou (2): netdev-dummy: Add --len option for netdev-dummy

[ovs-dev] [userspace meter v2 3/5] dpif: Meter framework.

From: Jarno Rajahalme <ja...@ovn.org> Add DPIF-level infrastructure for meters. Allow meter_set to modify the meter configuration (e.g. set the burst size if unspecified). Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- datapath/li

[ovs-dev] [userspace meter v2 4/5] ofproto: Meter translation.

From: Jarno Rajahalme <ja...@ovn.org> Translate OpenFlow METER instructions to datapath meter actions. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- include/openvswitch/ofp-actions.h | 1 + lib/dpif.c

[ovs-dev] [userspace meter v3 5/5] dpif-netdev: Simple DROP meter implementation.

first tried as a whole, and only if some of the meter bands are hit, we need to process the packets individually. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/dpif-netdev.c| 362 --- te

[ovs-dev] [userspace meter v3 3/5] dpif: Meter framework.

From: Jarno Rajahalme <ja...@ovn.org> Add DPIF-level infrastructure for meters. Allow meter_set to modify the meter configuration (e.g. set the burst size if unspecified). Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- datapath/li

[ovs-dev] [userspace meter v3 2/5] dp-packet: Enhance packet batch APIs.

. Add macros to support this use case. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/dp-packet.h | 140 +++ lib/dpif-netdev.c| 62 +-- lib/dpif.c | 2 +- lib/netdev-dummy.c

[ovs-dev] [userspace meter v3 0/5] Userspace meter

Repost user space meter support. This is based Jarno's original work at: https://mail.openvswitch.org/pipermail/ovs-dev/2015-November/306304.html. With some enhancements, and rebased to current master. --- v1-v2: rebase and repost. v2-v3: simplify patch 2/5. Andy Zhou (2): netdev-dummy: Add

[ovs-dev] [userspace meter v3 4/5] ofproto: Meter translation.

From: Jarno Rajahalme <ja...@ovn.org> Translate OpenFlow METER instructions to datapath meter actions. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- include/openvswitch/ofp-actions.h | 1 + lib/dpif.c

Re: [ovs-dev] [userspace meter v3 3/5] dpif: Meter framework.

On Thu, Jan 26, 2017 at 6:34 PM, Jarno Rajahalme wrote: > It feels weird reviewing my own code from past. What if I make a pass of > fixing the problems I see and send a new version of the remaining patches > for review? > > Sounds like a plan. I have pushed the first 2 patches in

[ovs-dev] [userspace clone v3 4/4] xlate: Generate of datapath clone action when supported

Add logic to detect whether datapath support clone. Enhance the xlate logic to make use of it. Added logic to turn on/off clone support for testing. Signed-off-by: Andy Zhou <az...@ovn.org> Acked-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif-

[ovs-dev] [userspace clone v3 3/4] dpif-netdev: Add clone action

userspace context. Signed-off-by: Andy Zhou <az...@ovn.org> --- datapath/linux/compat/include/linux/openvswitch.h | 3 +- lib/dpif-netdev.c | 1 + lib/dpif.c| 1 + lib/odp-execute.c | 34 +++

Re: [ovs-dev] [userspace clone v2 1/4] dpif-netdev: Avoid sending probe packets

On Fri, Jan 20, 2017 at 11:06 AM, Jarno Rajahalme <ja...@ovn.org> wrote: > > > On Jan 19, 2017, at 11:07 PM, Andy Zhou <az...@ovn.org> wrote: > > > > When ofproto probe for datapath features, no packets should actually > > be sent to the network. This

Re: [ovs-dev] [userspace meter v3 2/5] dp-packet: Enhance packet batch APIs.

On Wed, Jan 25, 2017 at 4:50 PM, Jarno Rajahalme <ja...@ovn.org> wrote: > Trusting you address the comments below: > > Acked-by: Jarno Rajahalme <ja...@ovn.org> > Thanks for the review. Pushed with fixes. > > > > On Jan 24, 2017, at 10:45 PM, Andy Zhou <a

Re: [ovs-dev] [userspace meter v3 1/5] netdev-dummy: Add --len option for netdev-dummy/receive command

On Wed, Jan 25, 2017 at 4:16 PM, Jarno Rajahalme <ja...@ovn.org> wrote: > With two small nits below: > > Acked-by: Jarno Rajahalme <ja...@ovn.org> > Thanks. > > > On Jan 24, 2017, at 10:45 PM, Andy Zhou <az...@ovn.org> wrote: > > > > Current

Re: [ovs-dev] [PATCH] ofproto/bond: Fix bond/show when all interfaces are disabled

On Thu, Feb 16, 2017 at 9:39 PM, nickcooper-zhangtonghao <n...@opencloud.tech> wrote: > > On Feb 17, 2017, at 4:49 AM, Andy Zhou <az...@ovn.org> wrote: > > Without this patch, when all slaves are disabled, the 'bond/show' > command still shows the mac address of las

[ovs-dev] [PATCH 1/3] ofproto-dpif: Enhance execute_controller_action().

the packet can be sent to the controller. This solution is to make a copy of the odp actions translated so far, and 'fix up' the copy so that it can be executed. The original odp actions are left intact so that xlate can continue. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif-x

[ovs-dev] [PATCH 2/3] lib: Refactor nested netlink APIs.

Future patches will make use of those changes. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/netlink.c | 19 --- lib/netlink.h | 3 ++- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/lib/netlink.c b/lib/netlink.c index ad7d35a..ae4c72a 100644 ---

[ovs-dev] [PATCH 3/3] xlate: Translate openflow clone into odp sample action.

action for this datapath. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 38 -- tests/ofproto-dpif.at| 2 +- 2 files changed, 29 insertions(+), 11 deletions(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofprot

Re: [ovs-dev] [PATCH] ovn pacemaker: Pass --db-(n/s)b-addr option when starting ovsdb-servers

On Wed, Feb 22, 2017 at 6:58 AM, wrote: > From: Numan Siddique > > When pacemaker script, starts the ovsdb-servers in all the nodes, > it doesn't pass the --db-(n/s)b-addr=MASTER_IP option. > When pacemaker promotes a master, it won't be listening on

Re: [ovs-dev] [PATCH 2/3] bond: fix memory leak and invalid memory write

On Sun, Feb 19, 2017 at 2:41 AM, wrote: > From: Huanle Han > > The recirc rule_op of tcp-balance bond is still referenced > though its memory is freed. And the freed object will be > written invalidly on following bond_update_post_recirc_rules. > The

[ovs-dev] [PATCH 1/2] ofproto/bond: Fix bond reconfiguration race condition.

ported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-February/328969.html CC: Huanle Han <hanxue...@gmail.com> Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/bond.c | 27 +++ ofproto/bond.h | 3 ++- ofproto/ofproto

[ovs-dev] [PATCH 2/2] ofproto/bond: Fix bond post recirc rule leak.

328969.html CC: Huanle Han <hanxue...@gmail.com> Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/bond.c | 36 ++-- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/ofproto/bond.c b/ofproto/bond.c index 6e10c5143c0e..5bb124bda5ad 10

[ovs-dev] [PATCH] ofproto/bond: Simplify bond_may_recirc()

The extra information passed back is no longer used outside bond.c. Make the API simpler. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/bond.c | 25 ++--- ofproto/bond.h | 3 +-- ofproto/ofproto-dpif-xlate.c | 2 +- 3 files chang

Re: [ovs-dev] [PATCH] ovs-ctl: allow passing user:group to daemons

On Tue, Feb 21, 2017 at 2:31 PM, Aaron Conole wrote: > The Open vSwitch daemons allow passing --user user[:group] to allow > spawning under different user privileges. ovs-ctl now accepts --ovs-user > in the same form to pass this argument on, as well as create databases and >

Re: [ovs-dev] [PATCH 3/3] ovsdb: Prevent OVSDB server from replicating itself.

On Wed, Feb 8, 2017 at 11:40 AM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Feb 07, 2017 at 08:40:22PM -0800, Andy Zhou wrote: >> Replication OVSDB server from itself is usually caused by configuration >> errors. Such configuration errors can lead to OVSDB server data l

Re: [ovs-dev] [PATCH 1/4] ofproto/bond: Validate active-slave mac.

Signed-off-by: nickcooper-zhangtonghao <n...@opencloud.tech> Thanks for working on this! This patch looks good to me. I will push it after we converged on the other patches in the series. Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing

Re: [ovs-dev] [PATCH 3/4] ofproto/bond: balance-slb mode fallbacks to active-backup mode.

On Mon, Feb 13, 2017 at 10:52 PM, nickcooper-zhangtonghao wrote: > lacp-fallback-ab determines the behavior of OvS bond in LACP mode. > If the partner switch does not support LACP, setting this option > to true allows OvS to fallback to active-backup. The balance-tcp > mode

Re: [ovs-dev] [PATCH 2/4] ofproto/bond: Drop traffic in balance-tcp mode without lacp.

On Mon, Feb 13, 2017 at 10:52 PM, nickcooper-zhangtonghao wrote: > The balance-tcp mode requires the upstream switch to support 802.3ad > with successful LACP negotiation. When bond ports are configured to > balance-tcp mode without lacp or lacp is disabled, drop the traffic.

Re: [ovs-dev] [PATCH v2] ofproto/bond: Drop traffic in balance-tcp mode without lacp.

On Wed, Feb 15, 2017 at 5:32 PM, nickcooper-zhangtonghao wrote: > The balance-tcp mode requires the upstream switch to support 802.3ad > with successful LACP negotiation. When bond ports are configured to > balance-tcp mode without lacp or lacp is disabled, drop the traffic.

[ovs-dev] [PATCH] ofproto/bond: Fix bond/show when all interfaces are disabled

Without this patch, when all slaves are disabled, the 'bond/show' command still shows the mac address of last active slave in 'active slave mac' output. This patch clears them to zeros. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/bond.c | 12 1 file changed, 8 inse

Re: [ovs-dev] [PATCH] ovs-appctl: Print lacp_fallback_ab info in "bond/show".

On Thu, Feb 16, 2017 at 2:52 AM, nickcooper-zhangtonghao wrote: > Signed-off-by: nickcooper-zhangtonghao Applied. Thanks. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 4/4] doc: Updates bonding.rst because of api changed.

On Mon, Feb 13, 2017 at 10:52 PM, nickcooper-zhangtonghao wrote: > Signed-off-by: nickcooper-zhangtonghao Thansk, pushed to master. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 1/4] ofproto/bond: Validate active-slave mac.

On Tue, Feb 14, 2017 at 7:48 PM, Andy Zhou <az...@ovn.org> wrote: > On Mon, Feb 13, 2017 at 10:52 PM, nickcooper-zhangtonghao > <n...@opencloud.tech> wrote: >> That the mac of active-slave is invalid(e.g. 00:00:00:00:00:00) >> is incidental. Th

Re: [ovs-dev] [PATCH 2/4] ofproto/bond: Drop traffic in balance-tcp mode without lacp.

On Tue, Feb 14, 2017 at 11:45 PM, nickcooper-zhangtonghao <n...@opencloud.tech> wrote: > > On Feb 15, 2017, at 11:51 AM, Andy Zhou <az...@ovn.org> wrote: > > On Mon, Feb 13, 2017 at 10:52 PM, nickcooper-zhangtonghao > <n...@opencloud.tech> wrote: > > The

[ovs-dev] [userspace meter 2/5] dp-packet: Enhance packet batch APIs.

. drop packets from the patch by not writing the packet pointers back. Add macros and data structure changes to reduce duplicated logics. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/dp-packet.h | 140 --- lib/dpif-netdev.c

[ovs-dev] [userspace meter 4/5] ofproto: Meter translation.

From: Jarno Rajahalme <ja...@ovn.org> Translate OpenFlow METER instructions to datapath meter actions. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- include/openvswitch/ofp-actions.h | 1 + lib/dpif.c

[ovs-dev] [userspace meter 1/5] netdev-dummy: Add --len option for netdev-dummy/receive command

h. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/netdev-dummy.c | 38 -- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index e6e36cd..10df0a7 100644 --- a/lib/netdev-dummy.c +++ b/lib/netdev-dumm

[ovs-dev] [userspace meter 5/5] dpif-netdev: Simple DROP meter implementation.

first tried as a whole, and only if some of the meter bands are hit, we need to process the packets individually. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/dpif-netdev.c| 363 --- te

[ovs-dev] [userspace clone v2 3/4] dpif-netdev: Add clone action

userspace context. Signed-off-by: Andy Zhou <az...@ovn.org> --- datapath/linux/compat/include/linux/openvswitch.h | 3 +- lib/dpif-netdev.c | 1 + lib/dpif.c| 1 + lib/odp-execute.c | 34 +++

[ovs-dev] [userspace clone v2 2/4] lib: Add nl_msg_end_non_empty_nested()

Later patch will make use of nl_msg_end_non_empty_nested() Signed-off-by: Andy Zhou <az...@ovn.org> Acked-by: Jarno Rajahalme <ja...@ovn.org> --- lib/netlink.c | 13 + lib/netlink.h | 1 + 2 files changed, 14 insertions(+) diff --git a/lib/netlink.c b/lib/netlink.c i

Re: [ovs-dev] [PATCH v5 1/4] ovn: ovn-ctl support for HA ovn DB servers

On Mon, Nov 7, 2016 at 11:55 PM, Babu Shanmugam <bscha...@redhat.com> wrote: > > > On Monday 07 November 2016 06:49 PM, Andy Zhou wrote: > > This version is better, I am able to apply them. Thanks. > > I got the system running, but managed to get system into a state wh

Re: [ovs-dev] [PATCH v4 1/4] ovn: ovn-ctl support for HA ovn DB servers

On Wed, Nov 2, 2016 at 1:33 AM, Babu Shanmugam wrote: > This patch adds support to start_ovsdb() function in ovn-ctl to start the > ovn db servers in backup mode. This can be done in the following ways > 1. Use parameters --ovn-nb-sync-from-addr and --ovn-sb-sync-from-addr

Re: [ovs-dev] [PATCH v6 0/4] High availability support for OVN DB servers using pacemaker

On Wed, Nov 16, 2016 at 2:13 AM, Babu Shanmugam <bscha...@redhat.com> wrote: > v5 -> v6: > - Added more text to the man page of ovn-ctl and some more information to > the integration guide. > Acked-by: Andy Zhou <az...@ovn.org> This ack applies to all 4 patches

Re: [ovs-dev] [PATCH] ovn: fix OVNDB process is stopped when master node demote to the slave by pacemaker

On Wed, Dec 7, 2016 at 11:42 PM, Guoshuai Li <l...@dtdream.com> wrote: > > On 2016/12/8 5:36, Andy Zhou wrote: > > > > On Tue, Dec 6, 2016 at 9:41 PM, Guoshuai Li <l...@dtdream.com> wrote: > >> When the master node's OVNDB process fails, the local node d

Re: [ovs-dev] [PATCH] ovn: fix OVNDB process is stopped when master node demote to the slave by pacemaker

On Tue, Dec 6, 2016 at 9:41 PM, Guoshuai Li wrote: > When the master node's OVNDB process fails, the local node demote to the > slave. > Failure cause is that the OVNDB process is stop, So the need to re-run the > process up. > if return $OCF_NOT_RUNNING will not demote the

Re: [ovs-dev] [PATCH] datapath: Linux 4.9 compat.

sted with current Linux net-next (4.9) and 3.16. > > Signed-off-by: Jarno Rajahalme <ja...@ovn.org> > Tested building linux 4.0-4.9. Acked-by: Andy Zhou <az...@ovn.org> When compiling with 4.0, I got the following warnning. It does not seem to be related to this patch. /home/azh

[ovs-dev] [RFC: fedora ovn packaging 0/5] RFC fedora ovn packaging

. ovn-central package is retained to be friendly to single host deployments. However ovn-central service is marked as exclusive with the other three services mentioned above. (I am not sure if this is necessary, and may more confusing than its worth) Andy Zhou (5): rpms: Seperate ovsdb-server

[ovs-dev] [RFC: fedora ovn packaging 2/5] rpms: Style fixes

Replace a few tabs with spaces in the file to be more consistent with the rest of the file. Signed-off-by: Andy Zhou <az...@ovn.org> --- rhel/openvswitch-fedora.spec.in | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/rhel/openvswitch-fedora.spe

[ovs-dev] [RFC: fedora ovn packaging 5/5] rpms: Adding three additional OVN packages

Add ovn-northbound-database, ovn-southbound-database and ovn-northd as packages that can be installed independently. Signed-off-by: Andy Zhou <az...@ovn.org> --- rhel/automake.mk | 5 +- rhel/openvswitch-fedora.spec.in

Re: [ovs-dev] [PATCH V2] Fix ovndb_servers master and VirtualIP are not on the same node.

On Fri, Dec 2, 2016 at 11:38 PM, Guoshuai Li wrote: > PCS man page says role=Stopped/Started/Master/Slave. > A role can be master or slave (if no role is specified, it defaults to > 'started'). > > Command line "$pcs constraint colocation add ovndb_servers-master with > master

Re: [ovs-dev] [PATCH 2/4] configure: Use -Wformat-security with -Wformat.

a space in it, which obviously doesn't work. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 3/4] configure: Enable new warning options added in GCC 5.

On Mon, Dec 5, 2016 at 2:38 PM, Ben Pfaff <b...@ovn.org> wrote: > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 4/4] configure: Enable new warning options added in GCC 6.

On Mon, Dec 5, 2016 at 2:38 PM, Ben Pfaff <b...@ovn.org> wrote: > -Wnull-dereference is also new in GCC 6 but upon testing it produces far > too many false positives to be usable for OVS. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-b

Re: [ovs-dev] [PATCH] ovn: Fix pacemaker Master node does not monitor the OVSDB status

On Tue, Dec 6, 2016 at 4:35 AM, Guoshuai Li wrote: > OVSDB resource is multi-state resource, pacemaker monitor actions are > insufficient to monitor a multi-state resource. > the usual one will cover the slave role, so it is need to configure > monitoring for the master. > >

[ovs-dev] [PATCH] rpms: Remove more OVN files form openvswitch rpm builds

OVN is packaged with openvswitch-fedora.spec.in, but not with openvswitch.spec.in. Remove OVN files from openvswitch.spec.in builds to make rpm build happy. Signed-off-by: Andy Zhou <az...@ovn.org> --- rhel/openvswitch.spec.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[ovs-dev] [PATCH 3/3] xlate: Generate of datapath clone action when supported

Add logic to detect whether datapath support clone. Enhance the xlate logic to make use of it. Added logic to turn on/off clone support for testing. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 44 ++-- ofproto/ofprot

[ovs-dev] [PATCH 1/3] lib: Add nl_msg_end_non_empty_nested()

Later patch will make use of this function. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/netlink.c | 13 + lib/netlink.h | 1 + 2 files changed, 14 insertions(+) diff --git a/lib/netlink.c b/lib/netlink.c index 4715d68..ad7d35a 100644 --- a/lib/netlink.c +++ b/lib/net

Re: [ovs-dev] [v2 1/2] ovsdb-idl: Properly handle conditional monitor update error

On Fri, Jan 6, 2017 at 4:17 PM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Jan 06, 2017 at 02:38:45PM -0800, Andy Zhou wrote: > > From: andy zhou <az...@ovn.org> > > > > When generating conditional monitoring update request, current code > > failed to upda

Re: [ovs-dev] [v2 2/2] ovsdb-idl: Enhance conditional monitoring API

On Fri, Jan 6, 2017 at 4:17 PM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Jan 06, 2017 at 02:38:46PM -0800, Andy Zhou wrote: > > To allow client to know when the conditional monitoring changes > > has been accepted by the OVSDB server and the 'idl' contents has > > be

Re: [ovs-dev] [PATCH] travis: Update build list email address.

On Thu, Jan 12, 2017 at 9:16 AM, Ben Pfaff <b...@ovn.org> wrote: > The lists these days prefer an ovs- prefix. Currently all of the build > emails are being dropped because it is missing. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-b

Re: [ovs-dev] [PATCH] dpif: Simplify dpif_execute_helper_cb()

On Wed, Jan 11, 2017 at 4:39 PM, Jarno Rajahalme wrote: > Looks good to me: > > Acked-by: Jarno Rajahalme > Thanks, pushed. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] odp: Fix sample action in userspace

. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/odp-execute.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/odp-execute.c b/lib/odp-execute.c index 73e1016..cec7432 100644 --- a/lib/odp-execute.c +++ b/lib/odp-execute.c @@ -523,8 +523,16 @@ odp_execute_

Re: [ovs-dev] [PATCH 1/3] ovsdb-idl: Avoid sending redundant conditional monitoring updates

On Thu, Dec 22, 2016 at 8:56 AM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Dec 20, 2016 at 01:47:15AM -0800, Andy Zhou wrote: > > In case connection is reset when there are buffered but unsent > > conditions, these conditions will be sent as the new "monitor_cond"

[ovs-dev] [v2 1/2] ovsdb-idl: Properly handle conditional monitor update error

From: andy zhou <az...@ovn.org> When generating conditional monitoring update request, current code failed to update idl's 'request-id'. This bug causes the reply message of the update request, regardless an ACK or a NACK, be logged as an unexpected message at the debug level and i

[ovs-dev] [v2 2/2] ovsdb-idl: Enhance conditional monitoring API

To allow client to know when the conditional monitoring changes has been accepted by the OVSDB server and the 'idl' contents has been updated to match the new conditions. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/ovsdb-idl.c| 44 +--- lib

Re: [ovs-dev] [PATCH 2/3] ovsdb-idl: Properly handle conditional monitor update error

On Wed, Jan 4, 2017 at 3:55 PM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Dec 22, 2016 at 12:12:05PM -0800, Andy Zhou wrote: > > On Thu, Dec 22, 2016 at 9:21 AM, Ben Pfaff <b...@ovn.org> wrote: > > > > > On Tue, Dec 20, 2016 at 01:47:16AM -0800, Andy Zho

Re: [ovs-dev] [PATCH] ovn: fix data loss after an OVN-DB's backup node promote used pacemaker

s-resource-ordering.html > > Signed-off-by: Guoshuai Li <l...@dtdream.com> > Thanks for the patch. Pushed. Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [RFC: fedora ovn packaging 0/5] RFC fedora ovn packaging

On Tue, Dec 20, 2016 at 8:27 AM, Guru Shetty <g...@ovn.org> wrote: > > > On 15 December 2016 at 05:35, Andy Zhou <az...@ovn.org> wrote: > >> The goal of this series is to make it easier to set up OVN in >> a larger setup, i.e. not having all services running o

Re: [ovs-dev] [PATCH] ovsdb-idl: Properly handle conditional monitor update error

I have posted an updated version of this patch at: https://patchwork.ozlabs.org/patch/707398/ On Fri, Dec 16, 2016 at 4:55 PM, Andy Zhou <az...@ovn.org> wrote: > When generating conditional monitoring update request, current code > failed to update idl's 'request-id'. This bug caus

[ovs-dev] [PATCH 3/3] ovsdb-idl: Enhance conditional monitoring API

To allow client to know when the conditional monitoring changes has been accepted by the OVSDB server and the 'idl' contents has been updated to match the new conditions. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/ovsdb-idl.c| 49 ++--

[ovs-dev] [PATCH 2/3] ovsdb-idl: Properly handle conditional monitor update error

From: andy zhou <az...@ovn.org> When generating conditional monitoring update request, current code failed to update idl's 'request-id'. This bug causes the reply message of the update request, regardless an ACK or a NACK, be logged as an unexpected message at the debug level and i

Re: [ovs-dev] [RFC: fedora ovn packaging 0/5] RFC fedora ovn packaging

On Fri, Dec 16, 2016 at 6:19 PM, Russell Bryant <russ...@ovn.org> wrote: > > > On Thu, Dec 15, 2016 at 8:35 AM, Andy Zhou <az...@ovn.org> wrote: > >> The goal of this series is to make it easier to set up OVN in >> a larger setup, i.e. not having a

Re: [ovs-dev] [PATCH] packets: Simplify packet_csum_pseudoheader6().

On Fri, Dec 23, 2016 at 9:06 AM, Ben Pfaff <b...@ovn.org> wrote: > It's simpler to make two calls than eight. > > Reported-by: Eelco Chaudron <echau...@redhat.com> > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Andy Zhou <az...@ovn.org> ___

Re: [ovs-dev] [PATCH 1/4] acinclude: Fix -Wstrict-prototypes and -Wold-style-definition detection.

ototypes. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] faq: Expand on answer about packet buffering removal.

On Fri, Mar 17, 2017 at 8:16 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > Documentation/faq/openflow.rst | 8 > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/faq/openflow.rst b/Documentation/faq/openflow.rst > index

Re: [ovs-dev] [PATCH] doc: Minor improvements to install instructions.

; The Linux kernel datapath module is available from a variety of places, so > don't say you have to use the one you built. > > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@open

Re: [ovs-dev] [PATCH] faq: Expand on answer about packet buffering removal.

On Wed, Mar 29, 2017 at 11:25 AM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Mar 29, 2017 at 10:25:31AM -0700, Andy Zhou wrote: >> On Fri, Mar 17, 2017 at 8:16 AM, Ben Pfaff <b...@ovn.org> wrote: >> > Signed-off-by: Ben Pfaff <b...@ovn.org> >> >

  1   2   3   4   >