Re: [ovs-dev] Help to Modify OVS Source Code

You can look at the "handle_packet_out" function at "ofproto.c" which handles the "PACKET_OUT" message from the controller. (where you can check for the LLDP eth type in the packet) On Tue, Sep 26, 2017 at 9:56 AM, Mohammed Kamel wrote: > Hello, > > I am new at mining and

Re: [ovs-dev] [PATCH v2] netdev, dpif: fix the crash/assert on port delete

ing problems? The series is posted > here: > https://patchwork.ozlabs.org/project/openvswitch/list/?series=13360 > > On Mon, Nov 13, 2017 at 12:36:06PM -0800, Ashish Varma wrote: > > Thanks Ben. > > > > On Mon, Nov 13, 2017 at 11:36 AM, Ben Pfaff <b...@ovn.org>

[ovs-dev] [PATCH v2] tests: add-del-add sequence for interface

Added a unit test case for testing the condition when a veth interface is added to br0 and then the veth interface is deleted from the system and added back with the same name. Signed-off-by: Ashish Varma <ashishvarma@gmail.com> --- v1-v2 Incorporated the comments by Yi-Hung Wei:

Re: [ovs-dev] [PATCH v2] netdev, dpif: fix the crash/assert on port delete

Thanks Ben. On Mon, Nov 13, 2017 at 11:36 AM, Ben Pfaff <b...@ovn.org> wrote: > On Mon, Nov 06, 2017 at 12:17:45PM -0800, Ashish Varma wrote: > > a crash is seen in "netdev_ports_remove" when an interface is deleted > and added > > back in the system and when

[ovs-dev] [PATCH] netdev, dpif: fix the crash/assert on port delete

code where the "ifindex_to_port_data" (ifindex -> portnum map node) is getting freed when the ifindex is not available any more. (as the interface is already deleted.) VMware-BZ: #1975788 Signed-off-by: Ashish Varma <ashishvarma@gmail.com> --- AUTHORS.rst| 1

Re: [ovs-dev] [PATCH] netdev, dpif: fix the crash/assert on port delete

<b...@ovn.org> wrote: > On Fri, Nov 03, 2017 at 07:36:41AM -0700, Ashish Varma wrote: > > a crash is seen in "netdev_ports_remove" when an interface is deleted > and added > > back in the system and when the interface is part of a bridge > configuration. > >

[ovs-dev] [PATCH] tests: add-del-add sequence for interface

added a unit test case for testing the condition when a tap interface is added to br0 and then the tap interface is deleted from the system and added back with the same name. Signed-off-by: Ashish Varma <ashishvarma@gmail.com> --- tests/automake.mk | 3 ++- tests/

Re: [ovs-dev] [PATCH 1/3] tests/sendpkt.py: Fix to work with Python3

Acked-by: Ashish Varma > On Thu, May 31, 2018 at 7:52 AM, Timothy Redaelli wrote: > CC: Ashish Varma > Fixes: 296251ca0c82 ("tests: Added NSH related unit test cases for > datapath") > Signed-off-by: Timothy Redaelli > --- > tests/sendpkt.py | 5 - >

[ovs-dev] [PATCH v1] doc: Added OVS Conntrack tutorial

OVS supports connection tracker related match fields and actions. Added a tutorial to demonstrate the basic use cases for some of these match fields and actions. Signed-off-by: Ashish Varma <ashishvarma@gmail.com> --- Documentation/automake.mk | 1 + Documentation/tut

Re: [ovs-dev] [PATCH] tests: Test for ovs-ofctl snoop command

have few > comments about testing itself. See inline. > > Best regard, Ilya Maximets. > > > Added test for snoop command to check for the initial handshake messages > > when a bridge connects to a controller via 'unix' connection method. > > > > Signed-off-by: Ashis

[ovs-dev] [PATCH] tests: Test for ovs-ofctl snoop command

Added test for snoop command to check for the initial handshake messages when a bridge connects to a controller via 'unix' connection method. Signed-off-by: Ashish Varma --- tests/ovs-ofctl.at | 28 1 file changed, 28 insertions(+) diff --git a/tests/ovs-ofctl.at b

Re: [ovs-dev] [PATCH v1] ovs-testcontroller: Added section for runtime managment commands

Thanks for the review. I will send a v2 patch with your suggestions. On Tue, Aug 7, 2018 at 4:06 PM, Ben Pfaff wrote: > On Mon, Aug 06, 2018 at 05:21:37PM -0700, Ashish Varma wrote: > > Even though there are no runtime management commands supported by > > ovs-testcontroller,

[ovs-dev] [PATCH v2] tests: Test for ovs-ofctl snoop command

Added test for snoop command to check for the initial handshake messages when a bridge connects to a controller via 'unix' connection method. Signed-off-by: Ashish Varma --- v1-v2: Removed the sleep and added OVS_WAIT_UNTIL. Added comment on why we are adding an exception for the 'connection

[ovs-dev] [PATCH v3] tests: Test for ovs-ofctl snoop command

Added test for snoop command to check for the initial handshake messages when a bridge connects to a controller via 'unix' connection method. Signed-off-by: Ashish Varma --- v2-v3: Moved 'on_exit kill" command before the start of the command to avoid the race condition between

[ovs-dev] [PATCH v1] ovs-testcontroller: Added section for runtime managment commands

') Added an empty section in the man page for 'RUNTIME MANAGEMENT COMMANDS' to avoid confusion to the reader of the man page. Signed-off-by: Ashish Varma --- utilities/ovs-testcontroller.8.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/utilities/ovs-testcontroller.8.in b/utilities/ovs

Re: [ovs-dev] [ovs-dev,v3] tests: Test for ovs-ofctl snoop command

Thanks for clarifying. On Tue, Aug 7, 2018 at 12:07 PM, Aaron Conole wrote: > Ashish Varma writes: > > > Hi Aaron, > > > > My patch is already committed by Ben. Not sure what is wrong here. > > Thanks for the heads up. > > This happens - usually if the patch

Re: [ovs-dev] Problem in using ovs in raspberry pi - regd.

I understand that you have few Rasberry Pi's as switches and some as hosts. A picture/some more explanation of the topology would help. How many ports does the Rasberry Pi have. How many are connected to the OVS bridge? I understand you use the wireless interface of Rasberry Pi to connet to RYU.

Re: [ovs-dev] [PATCH v1] tests: Added NSH related unit test cases for datapath

Sure, no problem. Thanks, Ashish On Tue, Apr 10, 2018 at 5:00 PM, Gregory Rose <gvrose8...@gmail.com> wrote: > On 4/6/2018 7:35 AM, Gregory Rose wrote: > >> >> >> On 4/4/2018 10:23 AM, Ben Pfaff wrote: >> >>> On Thu, Mar 29, 2018 at 04:46:09PM -

[ovs-dev] [PATCH v3] ovs-ofctl: Fixed the "snoop" command of ovs-ofctl

id != recv_xid)". This would happening because the "vconn" to ".snoop" socket would not respond to TABLE_FEATURES_REQUEST sent by ovs-ofctl. This commit disables showing port or table names in the snoop command. Signed-off-by: Ashish Varma <ashishvarma@gmail.com>

[ovs-dev] [PATCH v1] ovs-ofctl: Fixed the "snoop" command of ovs-ofctl

id != recv_xid)". This would happening because the "vconn" to ".snoop" socket would not respond to TABLE_FEATURES_REQUEST sent by ovs-ofctl. This commit disables showing port or table names in the snoop command. Signed-off-by: Ashish Varma <ashishvarma@gmail.

[ovs-dev] [PATCH v2] ovs-ofctl: Fixed the "snoop" command of ovs-ofctl

n would loop for ever waiting for response. The fix for this is to turn off display of table/port names when running snoop command. Signed-off-by: Ashish Varma <ashishvarma@gmail.com> --- v1-v2 Added more description to the cause of the issue and reason to add the fix. --- utilities/ov

Re: [ovs-dev] [PATCH v2] ovs-ofctl: Fixed the "snoop" command of ovs-ofctl

sage on the snoop connection. ovs-vswitchd would not > reply > > back on this connection, but instead would keep sending the open flow > messages > > received from controller. ‘table_iterator_next()/port_iterator_next()’ > function > > would loop for ever waiting

[ovs-dev] [PATCH v1] tests: Added NSH related unit test cases for datapath

Added test cases for encap, decap, replace and forwarding of NSH packets. Also added a python script 'sendpkt.py' to send hex ethernet frames. Signed-off-by: Ashish Varma <ashishvarma@gmail.com> --- tests/automake.mk | 4 +- tests/sendpkt.py

[ovs-dev] [PATCH v1] ofproto-dpif-upcall: fix for segmentation fault

Added check for NULL pointer on return from xlate_lookup_ofproto function. Access to "ofproto" variable when NULL was causing segmentation fault. VMware-BZ: #2061914 Signed-off-by: Ashish Varma <ashishvarma@gmail.com> --- ofproto/ofproto-dpif-upcall.c | 5 + 1 file chang

[ovs-dev] Error at ovsdb-cluster.at:204

Not sure if this is reported before. I am seeing failure (not always) at the following line when running the test ten times in the main branch: i=10;while [ $i -gt 0 ]; do make check TESTSUITEFLAGS='2485' | grep "2485: OVSDB 3-server torture test"; i=$((i-1)); done 2485: OVSDB 3-server torture

[ovs-dev] [PATCH v1] Documentation: Fixing some minor spelling mistakes and consistent usage of certain keywords.

Signed-off-by: Ashish Varma --- Documentation/tutorials/ovs-conntrack.rst | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/Documentation/tutorials/ovs-conntrack.rst b/Documentation/tutorials/ovs-conntrack.rst index 07ea998..a86288f 100644

Re: [ovs-dev] [PATCH v1] Documentation: Fixing some minor spelling mistakes and consistent usage of certain keywords.

04:55 PM, Ashish Varma wrote: > > Signed-off-by: Ashish Varma > > --- > > Documentation/tutorials/ovs-conntrack.rst | 20 ++-- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/Documentation/tutorials/ovs-conntrack.rst

Re: [ovs-dev] [PATCH v1] ofp-monitor: Added support for OpenFlow 1.4+ Flow Monitor

Thanks for the feedback. Would revert back shortly with replies and few questions followed by the v2 patch. On Mon, Dec 10, 2018 at 1:54 PM Ben Pfaff wrote: > On Wed, Nov 28, 2018 at 10:30:07AM -0800, Ashish Varma wrote: > > OVS supports Nicira version of Flow Monitor feature whi

[ovs-dev] [PATCH v1] ofctl.man: Minor change to correct the "out_group" field usage text.

Right now the man page of ovs-ofctl has "out_group=port". Correcting the output to group instead of port. Signed-off-by: Ashish Varma --- utilities/ovs-ofctl.8.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.

[ovs-dev] [PATCH v2] Documentation: Fixing some minor spelling mistakes and consistent usage of certain keywords.

Signed-off-by: Ashish Varma --- v1-v2 Reverted the sentence "Each of these flags are" back to "Each of these flags is". --- Documentation/tutorials/ovs-conntrack.rst | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/Documentation/tutoria

[ovs-dev] [PATCH v1] ofp-monitor: Added support for OpenFlow 1.4+ Flow Monitor

multipart message. Also added support in "ovs-ofctl monitor" to send OpenFlow 1.4+ messages to OVS. Added unit test cases to test the OpenFlow version of Flow Monitor messages. Signed-off-by: Ashish Varma --- include/openflow/openflow-1.4.h | 79 ++ include/openvswitch/ofp-monit

[ovs-dev] [PATCH v1] ofp-monitor: Fixed the usage of 'usable_protocols' variable in 'parse_flow_monitor_request' function.

and return an error. Modified the man page of ovs-ofctl to reflect Flow Monitor support as OpenFlow 1.0 Nicira extension only. Signed-off-by: Ashish Varma --- lib/ofp-monitor.c| 8 utilities/ovs-ofctl.8.in | 3 ++- utilities/ovs-ofctl.c| 8 3 files changed, 18

Re: [ovs-dev] [PATCH v2] ofp-monitor: Added support for OpenFlow 1.4+ Flow Monitor

On Tue, Feb 5, 2019 at 4:41 PM Ben Pfaff wrote: > On Tue, Feb 05, 2019 at 04:26:56PM -0800, Ashish Varma wrote: > > In the parse_flow_monitor_request(), usable_protocols is an out > parameter. > > (and is set in parse_flow_monitor_request() only if a match fie

Re: [ovs-dev] [PATCH v2] ofp-monitor: Added support for OpenFlow 1.4+ Flow Monitor

in ofctl_monitor. Would add the examples in tests/ofp-print.at I will add the monitoring support for OpenFlow 1.1, 1.2 and 1.3 as a separate patch. Thanks, Ashish On Mon, Feb 4, 2019 at 3:48 PM Ben Pfaff wrote: > On Thu, Jan 31, 2019 at 03:49:39PM -0800, Ashish Varma wrote: > > OVS suppor

[ovs-dev] [PATCH v2] ofp-monitor: Added support for OpenFlow 1.4+ Flow Monitor

multipart message. Also added support in "ovs-ofctl monitor" to send OpenFlow 1.4+ messages to OVS. Added unit test cases to test the OpenFlow version of Flow Monitor messages. Signed-off-by: Ashish Varma --- v1-v2: Aligned the comments on members

[ovs-dev] [PATCH v1] ofproto-dpif-trace: Fix for the segmentation fault in ofproto_trace().

XLATE_TOO_MANY_RESUBMITS error. VMware-BZ: #2282287 Signed-off-by: Ashish Varma --- ofproto/ofproto-dpif-trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-trace.c b/ofproto/ofproto-dpif-trace.c index eca61ce..4a981e1 100644 --- a/ofproto/ofproto

[ovs-dev] [PATCH] rhel: Fixed a bug for checking the correct major version and revision.

resulting in failure to load the kernel module. Signed-off-by: Ashish Varma --- rhel/openvswitch-kmod-fedora.spec.in | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/rhel/openvswitch-kmod-fedora.spec.in b/rhel/openvswitch-kmod-fedora.spec.in index 92d763f

[ovs-dev] [PATCH v2] rhel: Fixed a bug for checking the correct major version and revision.

resulting in failure to load the kernel module. Fixes: 402efbe4e176 ("rhel: Add 4.12 kernel support in ovs-kmod-manage.sh") Signed-off-by: Ashish Varma --- v1-v2: Added the Fixes tag. --- rhel/openvswitch-kmod-fedora.spec.in | 13 ++--- 1 file changed, 6 insertions(+), 7

[ovs-dev] [PATCH v1] doc: Added OVS Nicira Extension document

OVS supports Nicira Extensions as various vendor messages or as vendor types in stats or multipart messages. Added a document to describe the Nicira extension as currently supported by OVS. Signed-off-by: Ashish Varma --- Documentation/automake.mk | 1

[ovs-dev] [PATCH v2] ofp-monitor: Fixed the usage of 'usable_protocols' variable in 'parse_flow_monitor_request' function.

and return an error. Modified the man page of ovs-ofctl to reflect Flow Monitor support as OpenFlow 1.0 Nicira extension only. Signed-off-by: Ashish Varma --- v1-v2: Added a test that triggers the error condition fixed in this patch. Setting the usable_protocols variable to OFPUTIL_P_OF10_ANY

[ovs-dev] [PATCH v2] doc: Added OVS Extensions document

OVS supports OVS Extensions as various vendor messages or as vendor types in stats or multipart messages. Added a document to describe the extensions as currently supported by OVS. Signed-off-by: Ashish Varma --- v1-v2: Fixed the indentation in the commit message. Converted the document from FAQ

Re: [ovs-dev] [PATCH v1 2/2] ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+

I will take a look. Thanks, Ashish On Tue, Aug 24, 2021 at 9:29 AM Vasu Dasari wrote: > Hi Ben/Ashish, > > When you get a chance, Can you please take a look at my code? > > -Vasu > > *Vasu Dasari* > > > On Thu, Jul 29, 2021 at 10:36 PM Vasu Dasari wrote: > >> Extended OpenFlow monitoring