I couldn't figure out a way to fix this without making it inline. Weird.
Reported-by: Qiuyu Xiao
Signed-off-by: Ben Pfaff
---
Documentation/tutorials/ovn-sandbox.rst | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/Documentation/tutorials/ovn-sandbox.r
On Fri, Jun 01, 2018 at 05:57:44PM -0700, William Tu wrote:
> On Fri, Jun 1, 2018 at 1:07 PM, Greg Rose wrote:
> > A recent patch to gre.c added a call to skb_checksum_simple_complete()
> > which is not present in kernels before 3.16. Fix up the compatability
> > layer to allow compile on older k
ignore extra bytes.
This commit fixes both problems, by removing the padding bytes and
initializing every byte in outgoing messages.
Reported-by: David van Moolenbroek
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2018-June/046864.html
Signed-off-by: Ben Pfaff
---
AUTHORS.rst
parts of the tests to match.
Signed-off-by: Ben Pfaff
---
lib/bfd.c | 54 +--
tests/bfd.at | 32 +++---
tests/ofproto-dpif.at | 16 +++
3 files changed, 51 insertions(+), 51 deletions(-)
diff
parts of the tests to match.
Signed-off-by: Ben Pfaff
---
lib/cfm.c | 20 ++--
tests/cfm.at | 20 ++--
tests/ofproto-dpif.at | 6 +++---
3 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/lib/cfm.c b/lib/cfm.c
index 19957a968d3a
parts of the tests to match.
Signed-off-by: Ben Pfaff
---
lib/dpctl.c | 34 +-
tests/dpctl.at| 26 +-
tests/ofproto-dpif.at | 4 ++--
tests/pmd.at | 10 +-
4 files changed, 37 insertions(+), 37 deletions
parts of the tests to match.
Signed-off-by: Ben Pfaff
---
lib/ovs-lldp.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/lib/ovs-lldp.c b/lib/ovs-lldp.c
index d7062f3252cb..05c1dd4344be 100644
--- a/lib/ovs-lldp.c
+++ b/lib/ovs-lldp.c
parts of the tests to match.
Signed-off-by: Ben Pfaff
---
lib/lacp.c| 110 -
tests/lacp.at | 746 +-
2 files changed, 428 insertions(+), 428 deletions(-)
diff --git a/lib/lacp.c b/lib/lacp.c
index 8353746be169..d6b36aa3d587
parts of the tests to match.
Signed-off-by: Ben Pfaff
---
lib/rstp.c | 22 +++---
lib/stp.c| 23 ---
tests/stp.at | 14 +++---
3 files changed, 30 insertions(+), 29 deletions(-)
diff --git a/lib/rstp.c b/lib/rstp.c
index 7a61b24d7b36
parts of the tests to match.
Signed-off-by: Ben Pfaff
---
lib/stopwatch.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/stopwatch.c b/lib/stopwatch.c
index 20e2eefc0445..2e69d8189aa5 100644
--- a/lib/stopwatch.c
+++ b/lib/stopwatch.c
@@ -280,14 +280,14
parts of the tests to match.
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif-trace.c | 2 +-
tests/bfd.at | 4 ++--
tests/ofproto-dpif.at| 4 ++--
tests/system-traffic.at | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/ofproto/ofproto-dpif
parts of the tests to match.
Signed-off-by: Ben Pfaff
---
ofproto/bond.c| 8
tests/lacp.at | 52 +--
tests/ofproto-dpif.at | 20 ++--
3 files changed, 40 insertions(+), 40 deletions(-)
diff --git a/ofproto
parts of the tests to match.
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif-upcall.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index d80a10d31b7d..85f5792519b3 100644
--- a/ofproto/ofproto-dpif
This should make it harder to reintroduce inappropriate indentation.
Signed-off-by: Ben Pfaff
---
Makefile.am | 15 +++
build-aux/automake.mk | 1 +
build-aux/initial-tab-whitelist | 16
3 files changed, 32 insertions(+)
create mode
parts of the tests to match.
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif.c| 4 +-
tests/bridge.at | 20 +++
tests/mcast-snooping.at | 8 +--
tests/mpls-xlate.at | 30 +-
tests/netdev-type.at | 6 +-
tests/nsh.at
On Mon, Jun 04, 2018 at 10:36:31AM -0400, Mark Michelson wrote:
> s/remov/remove/
>
> Signed-off-by: Mark Michelson
Applied to master, thanks!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Jun 01, 2018 at 10:42:01AM -0700, Han Zhou wrote:
> OVSDB IDL can track changes, but for deleted rows, the data is
> destroyed and only uuid is tracked. In some cases we need to
> check the data of the deleted rows. This patch preserves data
> for deleted rows until track clear is called.
>
On Fri, Jun 01, 2018 at 10:41:59AM -0700, Han Zhou wrote:
> Signed-off-by: Han Zhou
This seems like a refinement of the incremental processing engine
mainly. Is there a reason it can only happen in this point in the
series? In other words, can this be folded into patch 1?
__
On Mon, Jun 04, 2018 at 01:33:30PM -0700, Greg Rose wrote:
> Fix compile warning about redefined symbol
>
> Fixes: 10f242363d ("compat: Add skb_checksum_simple_complete()")
>
> Signed-off-by: Greg Rose
Applied to master, thanks!
___
dev mailing list
d
On Tue, Jun 05, 2018 at 06:46:22PM +0530, Vikas Kumar wrote:
> can any one tell me, whether OVS development team has developed the AVB
> (audio video bridging) protocol in Open Vswich? or are they developing
> right now?
No. No.
___
dev mailing list
d..
On Tue, Jun 05, 2018 at 09:34:10AM -0700, Gregory Rose wrote:
> On 6/5/2018 9:07 AM, William Tu wrote:
> >On Mon, Jun 4, 2018 at 1:14 PM, Greg Rose wrote:
> >>The ERSPAN feature depends on the gre kernel module so on systems where
> >>the ERSPAN feature isn't supported the openvswitch kernel modul
On Fri, Jun 01, 2018 at 06:38:53PM +0200, Jiri Benc wrote:
> On Fri, 1 Jun 2018 09:15:33 -0700, Gregory Rose wrote:
> > Since ERSPAN over gre/ip_gre was added to the Linux 4.16 kernel the
> > compat interface is needed
> > for kernels up to 4.15 so that we can support ERSPAN. If the built-in
> >
On Sat, Jun 02, 2018 at 09:11:56AM -0700, aginwala wrote:
> using pacemaker so that controllers can be placed in different fault domains.
> More background about the discussions can be found on:
> https://mail.openvswitch.org/pipermail/ovs-discuss/2018-May/046770.html
>
> Signed-off-by: aginwala
.
>
>
> Regards,
>
> On Tue, Jun 5, 2018 at 10:41 AM, Ben Pfaff wrote:
>
> > On Sat, Jun 02, 2018 at 09:11:56AM -0700, aginwala wrote:
> > > using pacemaker so that controllers can be placed in different fault
> > domains.
> > > More background about th
On Mon, Jun 04, 2018 at 11:33:32AM -0700, Toms Atteka wrote:
> Adjusted docstring and variable names according to previous code changes;
> Fixed grammar "a attribute" > "an attribute".
>
> Fixes: bf42f674 (idl: Convert python daemons to utilize SchemaHelper)
> Signed-off-by: Toms Atteka
Thanks,
On Wed, Jun 06, 2018 at 12:05:25AM +0530, Numan Siddique wrote:
> On Sat, Jun 2, 2018 at 9:41 PM, aginwala wrote:
>
> > using pacemaker so that controllers can be placed in different fault
> > domains.
> > More background about the discussions can be found on:
> > https://mail.openvswitch.org/pip
as U de Queiroz
Signed-off-by: Ben Pfaff
---
build-aux/automake.mk | 1 +
build-aux/generate-dhparams-c | 31 +++
lib/.gitignore| 1 -
lib/automake.mk | 17 ++--
lib/dhparams.c| 192 ++
5 fil
On Mon, Jun 04, 2018 at 04:49:28PM +0300, Ilya Maximets wrote:
> On 01.04.2018 03:12, Ben Pfaff wrote:
> > The --disable-system option indicates that the user wants to avoid using
> > the host's datapath. This is also a good indication that the user does
> > not want t
On Tue, Jun 05, 2018 at 05:42:52PM +0300, Roi Dayan wrote:
>
>
> On 05/06/2018 15:42, Lorenzo Bianconi wrote:
> >Fix following compilation error running 'make rpm-fedora'
> >
> >error: Installed (but unpackaged) file(s) found:
> >/usr/share/man/man1/ovs-sim.1.gz
> >
> >RPM build errors:
> >
Ansis Atteka
Seems reasonable.
Acked-by: Ben Pfaff
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> this should say "not_later".
> >
> > Signed-off-by: Louis Peens
> > Reviewed-by: Pieter Jansen van Vuuren
> > Reviewed-by: Simon Horman
>
> Thanks Louis.
>
> Everyone else,
>
> are there any objections to me applying this change?
Acke
On Tue, Jun 05, 2018 at 03:25:42PM -0700, Ben Pfaff wrote:
> From: Eneas U de Queiroz
>
> The version of dhparams.c generated by any given version of OpenSSL or
> LibreSSL might work only with that version of the library. This can be
> inconvenient for cross-compiling if the &q
On Wed, Jun 06, 2018 at 03:23:28PM -0700, Greg Rose wrote:
> Before attempting to add a gre tunnel to OVS via the vport gre
> kernel interface make sure that the openvswitch kernel module has
> been able to grab the gre protocol entry point. If OVS does not
> own the gre protocol then report addre
To review the problem we're trying to solve, ovn-controller uses too
much CPU in many circumstances because it recomputes everything on every
iteration on the main loop. That includes when it wakes up for any
reason, e.g. in response to a timer, or to an "ovs-appctl" command, or
to respond to an "
On Thu, Jun 07, 2018 at 04:32:10PM -0700, Han Zhou wrote:
> On Thu, Jun 7, 2018 at 11:15 AM, Ben Pfaff wrote:
> >
> > To review the problem we're trying to solve, ovn-controller uses too
> > much CPU in many circumstances because it recomputes everything on every
>
Hi James. I have an intern for the summer, Qiuyu, who is working to add
IPSEC support to OVN, so that tunnels between hypervisors are protected
against compromise of the physical network. An important question for
this purpose is what IPSEC daemon does Ubuntu support and prefer? It
sounds like F
The OVS coding style says that input parameters should come first,
followed by output parameters. This changes a few functions in
ovn-controller to fit this style. It also marks a number of input
parameters 'const', for clarity.
Signed-off-by: Ben Pfaff
---
ovn/contro
ables
around and starts using that feature in ovn-controller.
CC: Han Zhou
Signed-off-by: Ben Pfaff
---
ovn/controller/bfd.c| 9 ++-
ovn/controller/bfd.h| 5 +-
ovn/controller/binding.c| 29 ---
ovn/controller/binding.h| 13 +++-
ovn/contr
This was duplicate functionality.
Signed-off-by: Ben Pfaff
---
ovn/controller/chassis.c| 5 +++--
ovn/controller/chassis.h| 6 --
ovn/controller/ovn-controller.c | 24
ovn/controller/ovn-controller.h | 3 ---
4 files changed, 11 insertions(+), 27
It seems like a good idea to use the built-in indexing instead of doing it
by hand.
Signed-off-by: Ben Pfaff
---
ovn/controller/bfd.c| 23 +++---
ovn/controller/bfd.h| 6 ++--
ovn/controller/binding.c| 13
ovn/controller/binding.h| 3
arguments to any function that needs to use
them.
Signed-off-by: Ben Pfaff
---
Documentation/topics/idl-compound-indexes.rst | 110 -
lib/ovsdb-idl-provider.h | 57 ++---
lib/ovsdb-idl.c | 330 +-
lib/ovsdb-idl.h
On Thu, Jun 07, 2018 at 04:51:34PM -0700, Ben Pfaff wrote:
> On Thu, Jun 07, 2018 at 04:32:10PM -0700, Han Zhou wrote:
> > On Thu, Jun 7, 2018 at 11:15 AM, Ben Pfaff wrote:
> > >
> > > To review the problem we're trying to solve, ovn-controller uses too
>
On Mon, Jun 11, 2018 at 02:57:26PM +0530, Vikas Kumar wrote:
> I am new to ovs and I have setup PISCES based setup for ovs using this
> github repository (https://github.com/P4-vSwitch). Does OVS support
> P4Runtime API to talk to controller apart from openflow?
No.
___
On Mon, Jun 11, 2018 at 09:09:21AM +0100, James Page wrote:
> Hi Ben
>
> (I'm struggling with sending from my @ubuntu.com address at the moment so
> this will probably bounce on the ML).
>
> On Fri, 8 Jun 2018 at 16:15 Ben Pfaff wrote:
>
> > Hi James. I have
On Mon, Jun 11, 2018 at 10:48:24AM -0700, Han Zhou wrote:
> On Fri, Jun 8, 2018 at 2:59 PM, Ben Pfaff wrote:
> > diff --git a/ovn/controller/lflow.c b/ovn/controller/lflow.c
> > index d09fd107298b..db96197828aa 100644
> > --- a/ovn/controller/lflow.c
> > +++ b/ovn/cont
On Mon, Jun 11, 2018 at 11:23:58AM -0700, Han Zhou wrote:
> On Fri, Jun 8, 2018 at 2:59 PM, Ben Pfaff wrote:
> >
> > We're working to make ovn-controller compute more incrementally, to reduce
> > CPU usage. To make it easier to keep track of dependencies, it makes
On Mon, Jun 11, 2018 at 04:16:06PM -0400, Mark Michelson wrote:
> So far all I've reviewed is the documentation. See my comments below.
>
> On 06/08/2018 05:59 PM, Ben Pfaff wrote:
> >The design of the compound index feature in the C OVSDB IDL was unusual.
> >Indexes
hes.
- Patch 1 (previously 3): improved some documentation.
- The last two patches are new.
Ben Pfaff (5):
ovsdb-idl: Redesign use of indexes.
chassis-index: Use OVSDB index mechanism.
ovn-controller: Use chassis_lookup_by_name() instead of get_chassis().
ovn-controller: Drop ovs_
This was duplicate functionality.
Signed-off-by: Ben Pfaff
---
ovn/controller/chassis.c| 5 +++--
ovn/controller/chassis.h| 6 --
ovn/controller/ovn-controller.c | 24
ovn/controller/ovn-controller.h | 3 ---
4 files changed, 11 insertions(+), 27
It seems like a good idea to use the built-in indexing instead of doing it
by hand.
Signed-off-by: Ben Pfaff
---
ovn/controller/bfd.c| 23 +++---
ovn/controller/bfd.h| 6 ++--
ovn/controller/binding.c| 13
ovn/controller/binding.h| 3
These were essentially unused except within ovn-controller.c itself.
Signed-off-by: Ben Pfaff
---
ovn/controller/ovn-controller.c | 68 +++--
ovn/controller/ovn-controller.h | 3 --
2 files changed, 32 insertions(+), 39 deletions(-)
diff --git a/ovn
arguments to any function that needs to use
them.
Signed-off-by: Ben Pfaff
---
Documentation/topics/idl-compound-indexes.rst | 116 -
lib/ovsdb-idl-provider.h | 57 ++---
lib/ovsdb-idl.c | 330 +-
lib/ovsdb-idl.h
The remaining controller_ctx members were ovsdb_idl_txn pointers that could
be passed to functions directly, so this commit makes that change and
removes the structure.
Signed-off-by: Ben Pfaff
---
ovn/controller/bfd.h| 1 -
ovn/controller/binding.c| 33
On Mon, Jun 11, 2018 at 02:59:01PM -0700, Han Zhou wrote:
> On Mon, Jun 11, 2018 at 2:01 PM, Ben Pfaff wrote:
> >
> > On Mon, Jun 11, 2018 at 11:23:58AM -0700, Han Zhou wrote:
> > > On Fri, Jun 8, 2018 at 2:59 PM, Ben Pfaff wrote:
> > > >
> > > > W
On Mon, Jun 11, 2018 at 03:14:09PM -0700, Justin Pettit wrote:
>
> > On May 17, 2018, at 8:22 AM, Ben Pfaff wrote:
> >
> > Signed-off-by: Ben Pfaff
>
> Acked-by: Justin Pettit
Thanks, applied to master.
___
dev mailin
On Mon, Jun 11, 2018 at 02:49:28PM -0700, Justin Pettit wrote:
>
> > On Jun 4, 2018, at 2:27 PM, Ben Pfaff wrote:
> >
> > This should make it harder to reintroduce inappropriate indentation.
> >
> > Signed-off-by: Ben Pfaff
>
> Nice addition.
>
>
On Mon, Jun 11, 2018 at 02:47:41PM -0700, Justin Pettit wrote:
>
>
> > On Jun 4, 2018, at 2:27 PM, Ben Pfaff wrote:
> >
> > It's always been OVS coding style to use spaces rather than tabs for
> > indentation, but some tabs have snuck in over time. This
On Mon, Jun 11, 2018 at 11:19:08AM -0700, aginwala wrote:
> Can you also apply
> https://github.com/openvswitch/ovs/commit/c381bca52f629f3d35f00471dcd10cba1a9a3d99
> to branch-2.9 too.
Sure, done.
> Wanted to know if its not yet done on purpose to avoid implications if any
> or you have any other
On Mon, Jun 11, 2018 at 07:17:13PM -0700, Han Zhou wrote:
> On Mon, Jun 11, 2018 at 3:14 PM, Ben Pfaff wrote:
> > +2. Pass the index, an iteration variable, and the key values to the
> iterator.
>
> s/key values/index row objects
Thanks, fixed.
> > +void
> > +o
Hi Guru, Han raised the following question while reading a patch of
mine. Will you give your opinion?
On Mon, Jun 11, 2018 at 07:17:13PM -0700, Han Zhou wrote:
> > +static struct ovs_list *
> > +bfd_find_ha_gateway_chassis(
> > +struct ovsdb_idl_index *sbrec_port_binding_by_datapath,
> > +
On Mon, Jun 11, 2018 at 07:52:41PM -0700, Han Zhou wrote:
> Acked-by: Han Zhou
Thanks for the reviews. I applied this series to master.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Thanks for the pull requests. I merged all of these (master, 2.9, and
2.8).
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
OK, I crossported to branch-2.9.
On Wed, Jun 13, 2018 at 01:24:44PM +0200, Miguel Angel Ajo Pelayo wrote:
> Ben, Russell, could we get this down to ovs 2.9?
>
> It's very important for scale.
>
> Best regards,
> Miguel Ángel.
>
> On Wed, Jun 13, 2018 at 1:13 PM Daniel Alvarez Sanchez
> wrote:
se that's
alphabetically first, no other real reason). It would require a little
more work to apply it everywhere, but it's probably not a huge deal.
Comments?
CC: Han Zhou
Signed-off-by: Ben Pfaff
---
ovn/controller/automake.mk | 5 +
ovn/controller/bfd-vswitch-
On Wed, Jun 13, 2018 at 08:29:28PM -0700, Han Zhou wrote:
> On Wed, Jun 13, 2018 at 3:37 PM, Ben Pfaff wrote:
> >
> > To make ovn-controller recompute incrementally, we need accurate
> > dependencies for each function that reads or writes a table. It's
> > curr
On Thu, Jun 14, 2018 at 10:17:58AM -0700, Han Zhou wrote:
> On Thu, Jun 14, 2018 at 10:09 AM, Ben Pfaff wrote:
> >
> > On Wed, Jun 13, 2018 at 08:29:28PM -0700, Han Zhou wrote:
> > > On Wed, Jun 13, 2018 at 3:37 PM, Ben Pfaff wrote:
> > > >
> > > >
On Thu, Jun 14, 2018 at 04:18:27PM +0800, findtheonly...@gmail.com wrote:
> From: findtheonlway
>
> When recv packet from onos, the ovs may report an error or
> crash due to the buffer is uninitalized.
>
> Signed-off-by: findtheonlway
> Signed-off-by: sunwenjie
Can you provide an example? It
This makes the comment more meaningful.
Signed-off-by: Ben Pfaff
---
ovn/controller/binding.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/ovn/controller/binding.c b/ovn/controller/binding.c
index 2b27f3cbd9ad..021ecddcff77 100644
--- a/ovn/controller
On Thu, Jun 14, 2018 at 12:00:43PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
For the series:
Acked-by: Ben Pfaff
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Thanks Yi-Hung (and Greg). I applied these to master. If they need
backports, let me know.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Jun 14, 2018 at 05:27:18PM +0200, Lorenzo Bianconi wrote:
> Using icmp4 action, send an ICMP time exceeded frame whenever
> an OVN logical router receives an IPv4 packets whose TTL has
> expired (ip.ttl == {0, 1})
>
> Signed-off-by: Lorenzo Bianconi
> ---
> Changes since v1:
> - use ovn-n
On Wed, Jun 13, 2018 at 03:43:03PM -0400, Aaron Conole wrote:
> lib/lldp/lldpd.c: In function :
> lib/lldp/lldpd.c:520:17: warning: output truncated before terminating nul
> copying as many bytes from a string as its length [-Wstringop-truncation]
> strncat(buffer, cfg->g_protocol
On Wed, Jun 13, 2018 at 03:43:04PM -0400, Aaron Conole wrote:
> lib/netdev-dpdk.c: In function :
> lib/netdev-dpdk.c:2865:49: warning: output may be truncated before the last
> format character [-Wformat-truncation=]
> snprintf(vhost_vring, 16, "vring_%d_size", i);
>
On Wed, Jun 06, 2018 at 10:07:14AM -0700, Ansis Atteka wrote:
> On Wed, Jun 6, 2018, 7:31 AM Aaron Conole wrote:
>
> > Aaron Conole writes:
> >
> > > Currently, Open vSwitch on linux embeds the logic of loading and
> > unloading
> > > kernel modules into the ovs-ctl and ovs-lib script files. Th
uot;man ovs-sim" from its
nested shell.
This commit makes this happen.
Suggested-by: Roi Dayan
Signed-off-by: Ben Pfaff
---
Documentation/automake.mk | 12
rhel/openvswitch-fedora.spec.in | 1 -
rhel/openvswitch.spec.in| 1 -
utilities/ovs-sim.in
On Thu, Jun 07, 2018 at 10:17:53AM +0300, Roi Dayan wrote:
>
>
> On 06/06/2018 08:49, Ansis Atteka wrote:
> > On Tue, 5 Jun 2018 at 20:32, Ben Pfaff wrote:
> >>
> >> On Tue, Jun 05, 2018 at 07:48:26PM -0700, Ansis Atteka wrote:
> >>> Fix following
(*args)
> socket.error: [Errno 99] Cannot assign requested address
>
> In this case HAVE_IPV6 is not set and all IPv6 tests fails.
> This commit fixes the problem by check also for EADDRNOTAVAIL.
>
> CC: Ben Pfaff
> Fixes: 5c1d812d7fb3 ("tests: Avoid printing Python excepti
Thanks Timothy (and Ashish). I applied this to master.
On Mon, Jun 04, 2018 at 03:21:46PM -0700, Ashish Varma wrote:
> Acked-by: Ashish Varma >
>
> On Thu, May 31, 2018 at 7:52 AM, Timothy Redaelli
> wrote:
>
> > CC: Ashish Varma
> > Fixes: 296251ca0c82 ("tests: Added NSH related unit test ca
On Thu, May 31, 2018 at 04:52:41PM +0200, Timothy Redaelli wrote:
> This partially reverts commit d53d2f4b84cc77868f2a55d66417fe6058d0.
>
> Python2 check for "six.moves.range" is not reverted.
>
> Signed-off-by: Timothy Redaelli
Thanks for the patch.
The commit message doesn't make it clea
On Tue, Jun 12, 2018 at 03:37:09PM -0400, Aaron Conole wrote:
> Timothy Redaelli writes:
>
> > Currently python-netifaces is needed for ovs-tcpdump that is installed
> > by openvswitch-test package.
> >
> > This commit adds {python,python2}-netifaces as a dependency for the
> > openvswitch-test p
Thanks for the patch.
The patch cannot be applied. It appears to be white space damaged.
Please resubmit using "git send-email".
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Jun 11, 2018 at 05:51:42PM -0700, Darrell Ball wrote:
> Signed-off-by: Darrell Ball
Thanks, applied to master.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Jun 14, 2018 at 05:11:39PM -0400, Aaron Conole wrote:
> Ben Pfaff writes:
>
> > On Wed, Jun 13, 2018 at 03:43:04PM -0400, Aaron Conole wrote:
> >> lib/netdev-dpdk.c: In function :
> >> lib/netdev-dpdk.c:2865:49: warning: output may be truncated before t
These don't trigger any new actual warnings in my own build.
GCC 8.x adds other new warning options that are enabled by -Wall or
-Wextra. This commit doesn't explicitly enable those because OVS already
enables -Wall and -Wextra.
Signed-off-by: Ben Pfaff
---
configure.ac | 2 ++
1 fi
On Thu, Jun 14, 2018 at 05:10:10PM -0400, Aaron Conole wrote:
> Ben Pfaff writes:
>
> > On Wed, Jun 13, 2018 at 03:43:03PM -0400, Aaron Conole wrote:
> >> lib/lldp/lldpd.c: In function :
> >> lib/lldp/lldpd.c:520:17: warning: output truncated before
> >>
On Mon, Jun 11, 2018 at 10:32:52AM +, Stokes, Ian wrote:
> Hi all,
>
> The recent DPDK 18.05 release provides BPF functionality for DPDK devices.
>
> The BPF Library provides the ability to load and execute Enhanced Berkeley
> Packet Filters (eBPF) within user-space DPDK applications. It als
On Thu, Jun 07, 2018 at 04:33:39PM +0200, Eelco Chaudron wrote:
> On 07/06/18 16:11, Flavio Leitner wrote:
> >Tap device is not added to the kernel datapath, so there is
> >no way to get netns information.
> >
> >Reported-by: Eelco Chaudron
> >Signed-off-by: Flavio Leitner
> >---
> > lib/netdev-
On Thu, Jun 07, 2018 at 04:33:50PM +0200, Eelco Chaudron wrote:
> On 07/06/18 16:10, Flavio Leitner wrote:
> >If the 'openvswitch' kernel module is not loaded, the API is not
> >available and the userspace will keep retrying. This approach is
> >not ideal for the netdev datapath type.
> >
> >This p
On Thu, Jun 07, 2018 at 04:34:02PM +0200, Eelco Chaudron wrote:
> On 07/06/18 16:10, Flavio Leitner wrote:
> >Assume the device is present if it can be opened.
> >
> >Reported-by: Eelco Chaudron
> >Signed-off-by: Flavio Leitner
> >---
> > lib/netdev-linux.c | 1 +
> > 1 file changed, 1 insertion
On Tue, Jun 05, 2018 at 05:37:42PM +0300, Ilya Maximets wrote:
> From: Ivan Dyukov
>
> The change fixes random stp test failure. Accuracy is about 20%.
> Failed test is following:
> 2337: STP - flush the fdb and mdb when topology changed
>
> In some cases, a validation is executed after topology
he list as a single scan, which should be more efficient.
Signed-off-by: Kyle Simpson
Signed-off-by: Ben Pfaff
---
lib/ofp-actions.c | 267 ++
1 file changed, 106 insertions(+), 161 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-act
Thanks, applied to master.
On Fri, Jun 15, 2018 at 09:20:49AM -0400, Mark Michelson wrote:
> Acked-by: Mark Michelson
>
> On 06/14/2018 03:36 PM, Ben Pfaff wrote:
> >This makes the comment more meaningful.
> >
> >Signed-off-by: Ben Pfaff
> >---
&
On Fri, Jun 15, 2018 at 01:44:50AM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
/connmgr.c:1432
> #20 0x00800177 in connmgr_run (mgr=0x2765bd0,
> handle_openflow=0x7c204f ) at ofproto/connmgr.c:363
> #21 0x007b479f in ofproto_run (p=0x27b4b10) at
> ofproto/ofproto.c:1816
> #22 0x007a4d31 in bridge_run__ () at vswitchd/bridge.c:2941
> #23 0x
On Fri, Jun 15, 2018 at 05:56:28PM +0300, Ilya Maximets wrote:
> > lib/netdev-dpdk.c: In function :
> > lib/netdev-dpdk.c:2865:49: warning: output may be truncated before the
> > last format character [-Wformat-truncation=]
> > snprintf(vhost_vring, 16, "vring_%d_size", i);
> > ^~
On Thu, Jun 07, 2018 at 02:59:46PM +0530, vkomm...@redhat.com wrote:
> From: Venkata Anil
>
> This patch avoids tunneling and instead uses source tenant vlan network
> across hypervisors for traffic from vlan network on local hypervisor
> towards gateway hypervisor hosting redirect chassiss port.
On Fri, Jun 15, 2018 at 11:49:06AM +0200, Lorenzo Bianconi wrote:
> Add TCP reset/ICMP port unreachable messages in reply to IP packets directed
> to
> the logical router's IP addresses
Thanks for implementing this!
I noticed a needlessly inefficient pattern here, where the actions are
a fixed s
On Thu, May 31, 2018 at 11:13:19AM +0200, Eelco Chaudron wrote:
> This change adds the ovs_dump_dp_provider command, which allows
> dumping of all the registered registered_dpif_class structures.
>
> In addition it has some small internal cleanups.
>
> Signed-off-by: Eelco Chaudron
Thanks, appl
On Fri, Jun 01, 2018 at 01:21:31PM +0200, Eelco Chaudron wrote:
> This changes add two additional gdb commands:
>
> - ovs_dump_netdev_provider
> - ovs_dump_ovs_list
Thanks, applied to master.
___
dev mailing list
d...@openvswitch.org
https://mail.openv
;
>
>
> > -Original Message-
> > From: Wang, Yipeng1
> > Sent: Friday, June 1, 2018 9:46 PM
> > To: Van Haaren, Harry ; ovs-dev@openvswitch.org
> > Cc: Gobriel, Sameh ; jpet...@ovn.org; Ben Pfaff
> > (b...@ovn.org) ; William Tu ;
> > db..
1 - 100 of 7535 matches
Mail list logo
