Re: [ovs-dev] Scale testing OVN with ovn-heater for OpenStack use cases

Hey Frode, Dumitru, thanks a lot for initiating this On Thu, May 11, 2023 at 6:05 PM Frode Nordahl wrote: > Hello, Dumitru, Daniel and team, > > On Thu, May 11, 2023 at 5:23 PM Dumitru Ceara wrote: > > > > Hi Frode, > > > > During an internal discussion with RedHat OpenStack folks (Daniel in

[ovs-dev] [PATCH v3] db-ctl-base: Partially revert b8bf410a5

/ovs/commit/b8bf410a5c94173da02279b369d75875c4035959 Fixes: b8bf410a5 ("db-ctl-base: Use partial map/set updates for last add/set commands") Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2182767 Signed-off-by: Daniel Alvarez Sanchez --- Notes: * v2: fix failing test

[ovs-dev] [PATCH v2] db-ctl-base: Partially revert b8bf410a5

/ovs/commit/b8bf410a5c94173da02279b369d75875c4035959 Signed-off-by: Daniel Alvarez Sanchez Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2182767 --- Notes: v1 -> v2 - Fix failing test lib/db-ctl-base.c | 42 +- tests/ovs-vsctl.at |

[ovs-dev] [PATCH] db-ctl-base: Partially revert b8bf410a5

/ovs/commit/b8bf410a5c94173da02279b369d75875c4035959 Signed-off-by: Daniel Alvarez Sanchez Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2182767 --- lib/db-ctl-base.c | 42 +- tests/ovs-vsctl.at | 2 ++ 2 files changed, 11 insertions(+), 33

Re: [ovs-dev] [PATCH ovn] northd: Make the use of common zone in NAT configurable

Thanks a lot Ales! On Tue, Feb 7, 2023 at 9:08 AM Ales Musil wrote: > There are essentially three problems with the current > combination of DGP + SNAT + LB: > > 1) The first packet is being SNATed in common zone due > to a problem with pinctrl not preserving ct_mark/ct_label. > The commit

Re: [ovs-dev] [PATCH ovn 0/5] Add MAC binding aging mechanism

On Wed, Jun 15, 2022 at 1:54 PM Ales Musil wrote: > Hi Daniel, > > thank you for the suggestions, please see my replies inline. > > On Wed, Jun 15, 2022 at 1:00 PM Daniel Alvarez Sanchez < > dalva...@redhat.com> wrote: > >> Hey Ales, first of all thanks a lot for

Re: [ovs-dev] [PATCH ovn 0/5] Add MAC binding aging mechanism

Hey Ales, first of all thanks a lot for this series!! Great job and good approach. I however have some concerns but maybe they're not much of a deal, please let me know what you think: - Broadcast gARPs will cause all ovn-controller instances in the cluster to attempt to write into the SB

Re: [ovs-dev] [PATCH ovn v2] pinctrl: Don't send gARPs for localports

On Thu, Mar 25, 2021 at 8:58 AM Dumitru Ceara wrote: > On 3/24/21 6:23 PM, Daniel Alvarez Sanchez wrote: > > Ports of type 'localport' are present on every hypervisor and > > ovn-controller is sending gARPs for them which makes upstream > > switches to see its

[ovs-dev] [PATCH ovn v2] pinctrl: Don't send gARPs for localports

://bugzilla.redhat.com/show_bug.cgi?id=1939470 Signed-off-by: Daniel Alvarez Sanchez Signed-off-by: Dumitru Ceara --- v1 -> v2: added test controller/pinctrl.c | 6 + tests/ovn.at | 55 2 files changed, 61 insertions(+) diff --

[ovs-dev] [PATCH ovn] pinctrl: Don't send gARPs for localports

://bugzilla.redhat.com/show_bug.cgi?id=1939470 Signed-off-by: Daniel Alvarez Sanchez --- controller/pinctrl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/controller/pinctrl.c b/controller/pinctrl.c index b42288ea5..523a45b9a 100644 --- a/controller/pinctrl.c +++ b/controller/pinctrl.c

Re: [ovs-dev] [PATCH ovn] ovn-controller: Always run the I-P OVS Interface change handler.

On Thu, Dec 17, 2020 at 10:23 AM Dumitru Ceara wrote: > The incremental processing engine implementation is such that if an > input node gets updated but the output node doesn't have a change > handler for it then the output node is immediately recomputed. That is, > no other input change

Re: [ovs-dev] Scaling of Logical_Flows and MAC_Binding tables

On Wed, Nov 25, 2020 at 7:59 PM Dumitru Ceara wrote: > On 11/25/20 7:06 PM, Numan Siddique wrote: > > On Wed, Nov 25, 2020 at 10:24 PM Renat Nurgaliyev > wrote: > >> > >> > >> > >> On 25.11.20 16:14, Dumitru Ceara wrote: > >>> On 11/25/20 3:30 PM, Renat Nurgaliyev wrote: > Hello folks, >

Re: [ovs-dev] [PATCH] ovs-ctl: Don't set hostname as external-id

Thanks a lot! I proposed the new approach at: https://patchwork.ozlabs.org/project/openvswitch/patch/20200525152821.19838-1-dalva...@redhat.com/ On Sat, May 23, 2020 at 8:38 PM Han Zhou wrote: > > > > On Sat, May 23, 2020 at 12:06 AM Daniel Alvarez wrote: > > > > > > Thanks a lot Terry! > > >

Re: [ovs-dev] [PATCH] ovs-ctl: Don't set hostname as external-id

On Fri, May 22, 2020 at 2:17 AM Han Zhou wrote: > > > > On Thu, May 21, 2020 at 3:19 AM Daniel Alvarez Sanchez > wrote: > > > > On Thu, May 21, 2020 at 9:22 AM Han Zhou wrote: > > > > > > > > > > > > On Wed, May 20, 2020 at 8:52 A

Re: [ovs-dev] [PATCH] ovs-ctl: Don't set hostname as external-id

On Thu, May 21, 2020 at 9:22 AM Han Zhou wrote: > > > > On Wed, May 20, 2020 at 8:52 AM Daniel Alvarez wrote: > > > > ovs-ctl started to add the hostname as external-id [0] at some point. > > > > However, this can be problematic as if it's already set by an external > > entity it will get

Re: [ovs-dev] [PATCH ovn] ovn-controller to no longer monitor Chassis' external_ids

Thanks Lucas! The only problem I see is that we still need something like the Private_Chassis approach that we discussed or otherwise bumping nb_cfg will still be generating N notifications (N == num_chassis) on every write. Still, this solves part of the problem. I was wondering if we could

Re: [ovs-dev] [PATCH v3 ovn] Documentation: Change 'Open vSwitch' for 'OVN and logo

On Fri, Mar 20, 2020 at 1:38 PM Mark Michelson wrote: > Thanks for this. Getting the conversion from "Open vSwitch" to OVN has > been a challenge. > > Everything looks good here, but I have one further suggestion. When you > click the links to manpages on ovn.org, the header on the manpages

Re: [ovs-dev] [PATCH v2 ovn] Documentation: Change 'Open vSwitch' for 'OVN and logo

On Tue, Mar 17, 2020 at 6:57 PM Ben Pfaff wrote: > On Tue, Mar 17, 2020 at 06:22:07PM +0100, Daniel Alvarez wrote: > > The current version of the documentation is still using the > > Open vSwitch logo and includes some references to OVS that > > should be changed by OVN. > > > > Signed-off-by:

Re: [ovs-dev] [PATCH ovn] Documentation: Change 'Open vSwitch' for 'OVN' and logo

On Tue, Mar 17, 2020 at 5:11 PM Ilya Maximets wrote: > On 3/17/20 4:17 PM, Daniel Alvarez wrote: > > The current version of the documentation is still using the > > Open vSwitch logo and includes some references to OVS that > > should be changed by OVN. > > > > Signed-off-by: Daniel Alvarez > >

Re: [ovs-dev] [PATCH ovn] ovn-northd: Address scale issues with DNAT flows.

Can we please include this patch as part of the next release? This is a really important bug fix especially on systems that have a considerable number of floating IPs where otherwise the cloud becomes unusable. On Tue, Feb 4, 2020 at 2:28 PM Daniel Alvarez Sanchez wrote: > Hi Numan, > &g

Re: [ovs-dev] [PATCH ovn] ovn-northd: Address scale issues with DNAT flows.

the localnet port so it is really distributed and does not traverse any tunnels. Thanks! Daniel Tested-By: Daniel Alvarez Sanchez Acked-By: Daniel Alvarez Sanchez On Tue, Feb 4, 2020 at 1:59 PM Dumitru Ceara wrote: > On 2/1/20 11:53 AM, num...@ovn.org wrote: > > From: Numan Siddique >

Re: [ovs-dev] [PATCH ovn] ovn-controller: Add missing port group lflow references.

Thanks for this patch. This can be a security issue as ACLs applied to a Port Group may not be taking effect. Tested this patch on an OpenStack environment that recreated the issue and I confirm that it fixes the problem. On Mon, Dec 2, 2019 at 1:40 PM Dumitru Ceara wrote: > The commit that

Re: [ovs-dev] [PATCH ovn] ovn-controller: Add command to trigger an I-P full recompute.

This is very handy! Can you please add the command to [0]? [0] https://github.com/ovn-org/ovn/blob/master/controller/ovn-controller.8.xml#L403 On Mon, Dec 2, 2019 at 5:19 PM Dumitru Ceara wrote: > Incremental processing tries to minimize the number of times > ovn-controller has to fully

Re: [ovs-dev] [PATCH ovn] Exclude inport and outport symbol tables from conjunction

Acked-by: Daniel Alvarez On Fri, Sep 13, 2019 at 11:02 PM Mark Michelson wrote: > > Acked-by: Mark Michelson > > It sucks that we lose the efficiency of the conjunctive match altogether > on port groups because of this error, but I understand this is a huge > bug and needs fixing. If I'm not

Re: [ovs-dev] [ovs-discuss] ovn-controller is taking 100% CPU all the time in one deployment

Hi Han, On Fri, Aug 30, 2019 at 10:37 PM Han Zhou wrote: > > On Fri, Aug 30, 2019 at 1:25 PM Numan Siddique wrote: > > > > Hi Han, > > > > I am thinking of this approach to solve this problem. I still need to > test it. > > If you have any comments or concerns do let me know. > > > > > >

Re: [ovs-dev] [ovs-discuss] ovn-controller is taking 100% CPU all the time in one deployment

On Fri, Aug 30, 2019 at 8:18 PM Han Zhou wrote: > > > > On Fri, Aug 30, 2019 at 6:46 AM Mark Michelson wrote: > > > > On 8/30/19 5:39 AM, Daniel Alvarez Sanchez wrote: > > > On Thu, Aug 29, 2019 at 10:01 PM Mark Michelson > > > wrote: > > &g

Re: [ovs-dev] [ovs-discuss] ovn-controller is taking 100% CPU all the time in one deployment

On Thu, Aug 29, 2019 at 10:01 PM Mark Michelson wrote: > > On 8/29/19 2:39 PM, Numan Siddique wrote: > > Hello Everyone, > > > > In one of the OVN deployments, we are seeing 100% CPU usage by > > ovn-controllers all the time. > > > > After investigations we found the below > > > > -

Re: [ovs-dev] [PATCH v2, ovn] Make pid_exists() more robust against empty pid argument

On Wed, Aug 14, 2019 at 5:49 PM Michele Baldessari wrote: > > In some of our destructive testing of ovn-dbs inside containers managed > by pacemaker we reached a situation where /var/run/openvswitch had > empty .pid files. The current code does not deal well with them > and pidfile_is_running()

Re: [ovs-dev] [PATCH v2] Shutdown SSL connection before closing socket

Acked-By: Daniel Alvarez On Thu, Jul 11, 2019 at 3:08 PM Terry Wilson wrote: > > Without shutting down the SSL connection, log messages like: > > stream_ssl|WARN|SSL_read: unexpected SSL connection close > jsonrpc|WARN|ssl:127.0.0.1:47052: receive error: Protocol error >

Re: [ovs-dev] [PATCH branch2.11] ovsdb-server: drop all connections on read/write status change

On Fri, Jul 12, 2019 at 4:17 PM Daniel Alvarez wrote: > > Prior to this patch, only db change aware connections were dropped > on a read/write status change. However, current schema in OVN does > not allow clients to monitor whether a particular DB changes this > status. In order to accomplish

Re: [ovs-dev] [PATCH] ovsdb-server: drop all connections on read/write status change

On Wed, Jul 10, 2019 at 10:24 PM Ben Pfaff wrote: > > On Tue, Jul 09, 2019 at 12:16:30PM +0200, Daniel Alvarez wrote: > > Prior to this patch, only db change aware connections were dropped > > on a read/write status change. However, current schema in OVN does > > not allow clients to monitor

Re: [ovs-dev] [PATCH] OVN resource agent - make promotion synchronous

Thanks a lot Michele. Just mentioning that this has been tested in an OpenStack environment successfully. A timeout is not needed for the while loop since pacemaker will enforce its own. On Tue, Jul 9, 2019 at 9:20 AM Michele Baldessari wrote: > > Currently inside the ovsdb_server_promote()

Re: [ovs-dev] [PATCH v2] OVN: fix DVR Floating IP support

Even I successfully tested this before getting merged, I just hit some scenario where traffic goes to the gateway node. If we have logical port lp1 with a dnat_and_snat NAT rule to fip1 and from lp1 you ping fip1, the traffic is leaving the hypervisor to the gateway node and comes back to lp1.

Re: [ovs-dev] [PATCH v3] OVN: Add support for Transport Zones

create > tunnels with every node on every other edge site while still allowing > these sites to create tunnels with the central node. > > * Extra security layer: Where users wants to create "trust zones" > and prevent computes in a more secure zone to communicate with a

Re: [ovs-dev] [PATCH] ofp-packet: Fix NXT_RESUME with geneve tunnel metadata

We have hit this issue as well on 2.9, would it be possible to backport it? On Mon, Oct 8, 2018 at 7:17 PM Ben Pfaff wrote: > > On Fri, Oct 05, 2018 at 09:19:54AM -0700, Yi-Hung Wei wrote: > > The patch address vswitchd crash when it receives NXT_RESUME with geneve > > tunnel metadata. The

Re: [ovs-dev] [PATCH] Un-revert Work around Python/C JSON unicode differences

Thanks for this! On Tue, Jan 15, 2019 at 8:48 PM Ben Pfaff wrote: > > On Mon, Jan 14, 2019 at 08:15:36AM -0600, Terry Wilson wrote: > > This fix was reverted because it depended on a small bit of code > > in a patch that was reverted that changed some python/ovs testing > > and build. The fix is

Re: [ovs-dev] [PATCH] ovn-controller: Inject GARPs to logical switch pipeline to update neighbors

This patch is making test "ovn -- vlan traffic for external network with distributed router gateway port" fail at [0]. The reason seems to be that now we're sending GARPs so n_packets is not 0 anymore for the flow that the test is checking: ./ovn.at:8816: as hv1 ovs-ofctl dump-flows br-int

Re: [ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

I forgot about this, sorry. Just sent the patch with the comment. Thanks a lot, Daniel On Sat, Aug 18, 2018 at 5:41 PM Ben Pfaff wrote: > > On August 18, 2018 8:18:51 AM PDT, Daniel Alvarez Sanchez > wrote: >> >> Thanks a lot Ben. >> It was fixed in glibc 2.28.

Re: [ovs-dev] [PATCH] ovn-ctl: Fix the wrong pidfile argument passed to ovsdb-servers

Thanks Numan! On Tue, Oct 9, 2018 at 9:17 AM wrote: > From: Numan Siddique > > When OVN db servers are started usinb ovn-ctl, if the pid files > (/var/run/openvswitch/ovnnb_db.pid for example) are already > present, then ovn-ctl passes "--pidfile=123" if the pid file has > '123' stored in it.

Re: [ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

Thanks a lot Ben. It was fixed in glibc 2.28. Shall I send a patch to add the comment in the code? I think it's a good idea so that we can remove the workaround eventually. Not sure about sending a patch for just a comment though :) On Wed, Aug 15, 2018 at 10:40 PM Ben Pfaff wrote: > On Mon,

Re: [ovs-dev] OVN/OVS split: OVN mailing list?

+1 for the split of the ML On Mon, Aug 13, 2018 at 11:17 AM Lucas Alvares Gomes wrote: > Hi, > > > Before starting in-depth technical discussions on this list or the > > ovs-dev list, I'm curious if people would be interested in splitting off > > a separate OVN list for this and future

Re: [ovs-dev] [PATCH v3] ovn.at: Add stateful test for ACL on port groups.

Thanks a lot Han! On Tue, Jun 26, 2018 at 9:41 AM Jakub Sitnicki wrote: > On Mon, 25 Jun 2018 10:03:02 -0700 > Han Zhou wrote: > > > A bug was reported on the feature of applying ACLs on port groups [1]. > > This bug was not detected by the original test case, because it didn't > > test the

Re: [ovs-dev] [PATCH v2 3/3] OVN: add protocol unreachable support to OVN router ports

Yes, let's hope we can get it in soon... expecting an v3 from Darrell apparently. Thanks! On Fri, Jun 29, 2018 at 2:15 PM Lucas Alvares Gomes wrote: > Hi, > > > this should be the same issue reported by Darrell ('ovn: Fix gateway > > load balancing') > > Regards, > > > > Yeah that's right, I

Re: [ovs-dev] [PATCH v2 3/3] OVN: add protocol unreachable support to OVN router ports

Hi all, We are hitting issues with this patch on OpenStack CI in this particular test [0]. The scenario is one VM trying to ping the router interface; replies are sent by the router interface but never reached the instance back as the last NAT action doesn't happen. Stopping northd and deleting

Re: [ovs-dev] [PATCH] ovn-northd: Apply pre ACLs when using Port Groups

Thanks a lot Han for the review. Just sent the v2 with the test fixed. I'll leave the hash index for a follow up as I'm short in time but if you want to edit my patch feel free to do it or send another one. Thanks again for the Port Groups implementation! :) Cheers, Daniel On Wed, Jun 20, 2018

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

> majop...@redhat.com> > > wrote: > > > >> Acked-by: Miguel Angel Ajo > >> > >> On Wed, Feb 28, 2018 at 9:13 AM Daniel Alvarez Sanchez < > >> dalva...@redhat.com> wrote: > >> > >>> Thanks Terry and Han for the reviews! >

Re: [ovs-dev] [PATCH] datapath: RHEL 7.5 ndo_change_mtu backward compatibility

Thanks Lucas, this makes sense. There is something that this patch is fixing and I'm not sure why. Maybe someone can shed some light: Using datapath from OVS master, and a setup where we have a physical interface connected to an OVS bridge (br-ex) connected to another OVS bridge (br-int) through

Re: [ovs-dev] [PATCH] ovn: Add a new action 'nd_na_router' to handle NS requests for router IPs

On Tue, May 8, 2018 at 3:26 PM, Mark Michelson wrote: > On 05/08/2018 05:36 AM, Numan Siddique wrote: > >> >> >> On Tue, May 8, 2018 at 1:20 PM, Miguel Angel Ajo Pelayo < >> majop...@redhat.com > wrote: >> >> Thank you Numan! >> >> It took

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

t;> > >> >> >> There was a similar attempt by Zong Kai Li in 2016 [1]. This patch > >> >> >> takes a slightly different approach by using weak refs instead of > >> >> >> strings, which requires a new

Re: [ovs-dev] [PATCH v2 2/2] ovn: Support address sets generated from port groups

Acked-by: Daniel Alvarez Thanks Han! Everything LGTM and the tests pass okay against current master. On Thu, Apr 5, 2018 at 2:51 AM, Han Zhou wrote: > Address sets are automatically generated from corresponding port > groups, and can be used directly in

Re: [ovs-dev] [PATCH v2 1/2] ovn: Support port groups in ACLs

nvswitch.org/pipermail/ovs-discuss/2018- > February/046260.html > [3] https://mail.openvswitch.org/pipermail/ovs-dev/2018-March/344873.html > [4] https://patchwork.ozlabs.org/patch/874433/ > > Reported-by: Daniel Alvarez Sanchez <dalva...@redhat.com> > Reported-at: https://mail.open

Re: [ovs-dev] [PATCH v1] Fix AUTHORS.rst

Acked-by: Daniel Alvarez Just as a note, normally v1 is not used in the subject, that you can avoid it by using "git send-email -1 --to=d...@openvswitch.org" and it will send just the latest commit without adding the v1 tag to the email subject. On Wed, Apr 11, 2018 at

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

Thanks Han! On Thu, Apr 5, 2018 at 2:58 AM, Han Zhou wrote: > On Wed, Apr 4, 2018 at 4:58 PM, Ben Pfaff wrote: > > > I see that there was a lot of feedback on this series, which seems to > > have resulted in some constructive design decisions. But I don't see

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

Reviewed-by: Daniel Alvarez <dalva...@redhat.com> On Mon, Mar 12, 2018 at 8:41 PM, Han Zhou <zhou...@gmail.com> wrote: > Thanks Daniel and Mark for the review. I will fix these in V2. > > On Mon, Mar 12, 2018 at 7:01 AM, Daniel Alvarez Sanchez < > dalva...@redhat.

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

;> set table. This way it will also benefit for a follow up patch that > > >> enables generating address sets automatically from port groups to > > >> avoid a lot a trouble from client perspective [2]. > > >> > > >> [1] https://mail.openvswitch.org/

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

also benefit for a follow up patch that > enables generating address sets automatically from port groups to > avoid a lot a trouble from client perspective [2]. > > [1] https://mail.openvswitch.org/pipermail/ovs-dev/2016-August/077118.html > [2] https://mail.openvswitch.org/pip

Re: [ovs-dev] [PATCH 2/2] ovn: Support address sets generated from port groups

LGTM! Just one tiny comment inline in the tests. On Thu, Mar 1, 2018 at 4:37 AM, Han Zhou wrote: > Address sets are automatically generated from corresponding port > groups, and can be used directly in ACL match conditions. > > There are two address sets generated for each

Re: [ovs-dev] [PATCH] ovsdb: compact databases more strictly

Done: https://patchwork.ozlabs.org/patch/884143/ Thanks a lot again for taking a look. I'd appreciate the backport into 2.9 as well if you all agree. Regards, Daniel On Sat, Mar 10, 2018 at 1:35 PM, Daniel Alvarez Sanchez <dalva...@redhat.com > wrote: > Thanks a lot Ben and Mark. &g

Re: [ovs-dev] [PATCH] ovsdb: compact databases more strictly

Thanks a lot Ben and Mark. Yes, I'll be sending it right away. Thanks a lot guys. On Fri, Mar 9, 2018 at 8:13 PM, Ben Pfaff wrote: > On Fri, Mar 09, 2018 at 08:05:22AM -0600, Mark Michelson wrote: > > Hi Daniel, > > > > Mostly this looks correct. I had one small finding and have

Re: [ovs-dev] [PATCH] ovsdb: Correctly log time since last compaction.

to be computed relative to that clock, not against wall clock time. > > > > This only affected the log message, not the decision about when to > > compact. > > > > Signed-off-by: Ben Pfaff <b...@ovn.org> > > Reported-by: Daniel Alvarez Sanchez <dalva...@re

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

On Fri, Mar 2, 2018 at 3:22 PM, Mark Michelson <mmich...@redhat.com> wrote: > On 03/02/2018 05:57 AM, Daniel Alvarez Sanchez wrote: > >> >> >> On Fri, Mar 2, 2018 at 12:49 AM, Mark Michelson <mmich...@redhat.com >> <mailto:mmich...@redhat.com>

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

atch >> takes a slightly different approach by using weak refs instead of >> strings, which requires a new table instead of reusing the address >> set table. This way it will also benefit for a follow up patch that >> enables generating address sets automatically from port groups to >&

Re: [ovs-dev] [PATCH 1/2] ovn: Support port groups in ACLs

enefit for a follow up patch that > enables generating address sets automatically from port groups to > avoid a lot a trouble from client perspective [2]. > > [1] https://mail.openvswitch.org/pipermail/ovs-dev/2016-August/077118.html > [2] https://mail.openvswitch.org/pip

Re: [ovs-dev] [PATCH 2/2] ovn: Support address sets generated from port groups

Hi Han, I've tested both patches today on a lab setup and from a performance perspective there's no big difference after merging my IDL patch with 800 ports. However, I must say that this it's greatly improving the reconnection times to OVSDB (now the dumps from ovsdb-server upon reconnection are

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

> Previous code will make resources creation take longer as the number >> > of elements in the row grows because of that JSON conversion. This >> > patch eliminates it and now the time remains consant regardless >> > of the database contents improving performance and scaling

Re: [ovs-dev] [PATCH] util: Use lookup table to optimize hexit_value().

Thanks for the patch, Ben. Looks good to me. Acked-by: Daniel Alvarez <dalva...@redhat.com> On Sat, Feb 3, 2018 at 12:16 AM, Ben Pfaff <b...@ovn.org> wrote: > Daniel Alvarez Sanchez reported a significant overall speedup in ovn-northd > due to a similar patch. > > Rep

Re: [ovs-dev] [PATCH] ovn-northd: Avoid duplicate logical flows in SB db

Thanks Ben, Han, Miguel. On Tue, Jan 9, 2018 at 11:59 AM, Miguel Angel Ajo Pelayo < majop...@redhat.com> wrote: > You're probably right, it's probably not worth increasing the complexity > of ovn-northd when we can check this in the low level, and suppress > the final OpenFlow duplicates, the

[ovs-dev] [OVN][Request] New OVS 2.8 tag

Hi folks, It'd be great if we could have 2.8.2 tag so that we can benefit from some patches that we would require in OVN and its OpenStack integration such as: * OVN: Add external_ids to NAT and Logical_Router_Static_Route tables [0] * ovn-northd; Treat logical ports of router type as always

Re: [ovs-dev] [PATCH v1] OVN: Add external_ids to NAT and Logical_Router_Static_Route tables.

Acked-by: Daniel Alvarez >From [0] one can expect this column to be present in all tables. [0] https://github.com/openvswitch/ovs/blob/v2.8.1/ovn/ovn-nb.xml#L19 On Mon, Dec 4, 2017 at 2:16 PM, wrote: > From: Lucas Alvares Gomes

Re: [ovs-dev] [ovs-discuss] [OVN] OVN doesn't work using OVS 2.8.1 on Centos 7.3 using conntrack

d, Oct 25, 2017 at 3:09 PM, Daniel Alvarez Sanchez < > dalva...@redhat.com > > > wrote: > > > > > > > > > > > On Tue, Oct 24, 2017 at 11:35 PM, Ben Pfaff <b...@ovn.org> wrote: > > > > > >> On Tue, Oct 24, 2017 at 02:27:59PM

Re: [ovs-dev] [ovs-discuss] [OVN] OVN doesn't work using OVS 2.8.1 on Centos 7.3 using conntrack

On Tue, Oct 24, 2017 at 11:35 PM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Oct 24, 2017 at 02:27:59PM -0700, Ben Pfaff wrote: > > On Tue, Oct 24, 2017 at 11:07:58PM +0200, Daniel Alvarez Sanchez wrote: > > > Hi guys, > > > > > > Great job Numan! >

Re: [ovs-dev] [ovs-discuss] [OVN] OVN doesn't work using OVS 2.8.1 on Centos 7.3 using conntrack

Hi guys, Great job Numan! As we discussed over IRC, the patch below may make more sense. It essentially sets the dl_type so that when packet comes from the controller, it matches a valid type and OVS_KEY_ATTR_CT_ORIG_TUPLE_IPV4 is not added. Maybe what Numan proposed and this patch could be a

[ovs-dev] [OVN] OVN doesn't work using OVS 2.8.1 on Centos 7.3 using conntrack

System information: === OS: CentOS Linux release 7.3.1611 (Core) Kernel version: 3.10.0-693.2.2.el7.x86_64 #1 SMP OVS version: v2.8.1 (git tag) #ovs-vswitchd --version ovs-vswitchd (Open vSwitch) 2.8.1 Bug description: Right now, OVN doesn't work using OVS 2.8.1 on

Re: [ovs-dev] ovs-vswitchd is resetting the MTU of a bridge when a patch port is deleted.

Yes, thanks Numan for the patch :) Another option would be that ovn-controller sets explicitly the MTU to 1450. Not sure which of the two is the best or would have less side effects. Cheers, Daniel On Tue, Sep 12, 2017 at 10:43 AM, Numan Siddique wrote: > Hello, > > Daniel

Re: [ovs-dev] Revisit OVN meeting schedule?

On Wed, Jul 26, 2017 at 5:13 PM, Ben Pfaff wrote: > On July 26, 2017 8:07:57 AM PDT, Russell Bryant wrote: > >It has been difficult for some of our newer contributors in Europe to > >make our weekly OVN IRC meeting, so I wanted to revisit the schedule. > >Roughly

Re: [ovs-dev] [PATCH] netdev: check for iface_name not NULL in netdev_get_addrs

, Aaron Conole <acon...@redhat.com> wrote: > Daniel Alvarez Sanchez <dalva...@redhat.com> writes: > > > When the interfaces list is retrieved through getiffaddrs(), there > > might be elements with iface_name set to NULL. > > This patch checks iface_

[ovs-dev] [PATCH v2] netdev: check for NULL fields in netdev_get_addrs

When the interfaces list is retrieved through getiffaddrs(), there might be elements with iface_name set to NULL. This patch checks ifa_name to be not NULL before comparing it to the actual device name in the loop that calculates how many interfaces exist with that same name. Also, this patch

[ovs-dev] [PATCH] netdev: check for iface_name not NULL in netdev_get_addrs

When the interfaces list is retrieved through getiffaddrs(), there might be elements with iface_name set to NULL. This patch checks iface_name to be not NULL before comparing it to the actual device name in the loop that calculates how many interfaces exist with that same name. Note, that this

Re: [ovs-dev] [PATCH v4 2/7] ovn: l3ha, NBDB and SBDB changes and documentation

Super nit comments while trying to go through the code. Very good work btw! Thanks a lot Miguel and Anil! On Wed, Jul 12, 2017 at 3:12 PM, Miguel Angel Ajo wrote: > From: "majop...@redhat.com" > > This commit introduces the north and south db changes

Re: [ovs-dev] [PATCH v5] OVN localport type support

Great! Thanks a lot Ben :) On Tue, May 30, 2017 at 6:57 PM, Ben Pfaff wrote: > On Fri, May 26, 2017 at 12:08:43PM +, Daniel Alvarez wrote: > > This patch introduces a new type of OVN ports called "localport". > > These ports will be present in every hypervisor and may have the

Re: [ovs-dev] [PATCH v4] OVN localport type support

. Thanks once again! Daniel On Fri, May 26, 2017 at 6:46 AM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, May 23, 2017 at 03:13:08PM +0200, Daniel Alvarez Sanchez wrote: > > On Tue, May 23, 2017 at 10:01 AM, Miguel Angel Ajo Pelayo < > > majop...@redhat.com> wrote: >

Re: [ovs-dev] [PATCH v4] OVN localport type support

to drop output/forwarding > of packets? > > I like the idea... let's see what others say about this, I don't know how strict we want to be consuming bits from registers. Thanks Miguel for the suggestion :) > Best, > Miguel Ángel Ajo > > > > On Fri, May 19, 2017 at

Re: [ovs-dev] [PATCH] OVN localport type support

e=14, priority=100,reg15=0x1,metadata=0x7 actions=load:0x7->NXM_NX_TUN_ID[0..23],set_field:0x1->tun_metadata0,move:NXM_NX_REG14[0..14]->NXM_NX_TUN_METADATA0[16..30],output:40 > On Tue, May 09, 2017 at 05:09:43PM +0200, Daniel Alvarez Sanchez wrote: > > Hi, > > > &g

Re: [ovs-dev] [PATCH] OVN localport type support

less it comes from lp1 (reg14=0x1) when it'll be dropped. On Fri, May 5, 2017 at 5:51 PM, Ben Pfaff <b...@ovn.org> wrote: > [oops, adding back the list] > > On Fri, May 05, 2017 at 08:51:01AM -0700, Ben Pfaff wrote: > > On Fri, May 05, 2017 at 02:58:45PM +0200, Daniel Al

Re: [ovs-dev] [PATCH v3] python: Allow tuning the session probe_interval from IDL

Acked-by: Daniel Alvarez Looks good to me. Just a minor comment in case you need to submit another version of the patch: comments say that it will default to at least 1000 ms. In fact, it'll default to OVS minimum default value. If this changes at some point (unlikely),