Commands are added to disable and also enable fragmentation handling
for conntrack.
Signed-off-by: Darrell Ball
---
NEWS| 4
lib/ct-dpif.c | 8
lib/ct-dpif.h | 1 +
lib/dpctl.c | 50 ++
lib
Use 'must' instead of 'should'.
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index efe8a18..30941ff 100644
--- a/lib/conntrack.c
+++ b/lib/conntrack.c
@@ -1291,7 +1
Enhance the api parse_ipv6_ext_hdrs to return the
fragmentation header to be used in later patches.
Signed-off-by: Darrell Ball
Acked-by: Justin Pettit
---
lib/conntrack.c | 4 ++--
lib/flow.c | 31 +--
lib/flow.h | 3 ++-
3 files changed, 25 insertions
Signed-off-by: Darrell Ball
Acked-by: Justin Pettit
---
tests/system-traffic.at | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 519b234..75648d4 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
@@ -2530,6 +2530,7
Signed-off-by: Darrell Ball
Acked-by: Justin Pettit
---
lib/dp-packet.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index ba91e58..ecf16fb 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
@@ -637,7 +637,7 @@ dp_packet_mbuf_init
_size when min_frag_size is
reconfigured.
Tighten ip_tot_len sanity check for reassembled packets which
was more loose than intended.
Add another sanity check for fragment ip_tot_len; even though
it be redundant, add for completeness.
v1->v2: Few fixes,
Filter out packet-ins for V6 packets as this is a V4 test.
Signed-off-by: Darrell Ball
---
tests/system-traffic.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 519b234..cbd9542 100644
--- a/tests/system-traffic.at
Only standard sanity failures, which are normally rare, are tracked.
Signed-off-by: Darrell Ball
---
NEWS| 2 +
lib/conntrack.c | 114 +---
lib/conntrack.h | 15 +++
lib/ct-dpif.c | 27 +
lib/ct
On Thu, Jul 5, 2018 at 1:49 PM, Ian Stokes wrote:
> On 7/5/2018 9:38 PM, Darrell Ball wrote:
>
>> Traditionally, for boolean variables we use boolean values.
>> Lets keep to that tradition.
>> Hopefully, using false with a bool works with gcc 6.3.1;
>> I use both re
: 165c1f0649af ("db-ctl-base: Fix compilation warnings.")
Signed-off-by: Darrell Ball
---
lib/db-ctl-base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c
index 1768b45..4af8489 100644
--- a/lib/db-ctl-base.c
+++ b/lib/db-ctl-base.c
>
> Hi Darrell,
>
> thx for the info, I will always use it in subsequent patches.
> I implemented what is indicated in ovn-northd doc and just run
> ovn tests (not system ones). Thx for fixing it
>
> Regards,
> Lorenzo
>
No worries Lorenzo.
This is
this patch is withdrawn
Darrell
On Thu, Jun 28, 2018 at 3:39 PM, Darrell Ball wrote:
> Line continuations are useful for specifying big packets in
> hex form in tests. Allow the hex packet to include '\'s to
> specify continuations. Also line length is limited to 998
>
yep, test file long line corruption again
On Thu, Jun 28, 2018 at 3:55 PM, 0-day Robot wrote:
> Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out
> your patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. S
Tests are added to cover out of order fragments, overlapping fragments
and multiple extension headers in the case of IPv6.
Signed-off-by: Darrell Ball
---
tests/system-kmod-macros.at | 16
tests/system-traffic.at | 200 +++
tests/system
Signed-off-by: Darrell Ball
---
NEWS| 2 +
lib/conntrack.c | 114 +---
lib/conntrack.h | 13 ++
lib/ct-dpif.c | 24 +++
lib/ct-dpif.h | 13 ++
lib/dpctl.c | 62
tests are added to better maintain fragmentation support.
This needs backporting to 2.9.
Fixes: c8b1ad49da68("conntrack: Reorder sanity checks in extract_l3_ipvx().")
Fixes: a489b16854b5("conntrack: New userspace connection tracker.")
Signed-off-by: Darrell Ball
---
lib/conn
Signed-off-by: Darrell Ball
---
NEWS| 2 +
lib/conntrack.c | 114 +---
lib/conntrack.h | 13 ++
lib/ct-dpif.c | 24 +++
lib/ct-dpif.h | 13 ++
lib/dpctl.c | 62
tests are added to better maintain fragmentation support.
This needs backporting to 2.9.
Fixes: c8b1ad49da68("conntrack: Reorder sanity checks in extract_l3_ipvx().")
Fixes: a489b16854b5("conntrack: New userspace connection tracker.")
Signed-off-by: Darrell Ball
---
lib/conn
Tests are added to cover out of order fragments, overlapping fragments
and multiple extension headers in the case of IPv6.
Signed-off-by: Darrell Ball
---
tests/system-kmod-macros.at | 16
tests/system-traffic.at | 200 +++
tests/system
ned-off-by: Darrell Ball
---
lib/packets.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/lib/packets.c b/lib/packets.c
index 38bfb60..13186f9 100644
--- a/lib/packets.c
+++ b/lib/packets.c
@@ -490,21 +490,32 @@ eth_from_hex(const char *hex, struct dp_packet
On Thu, Jun 28, 2018 at 11:59 AM, Darrell Ball wrote:
>
>
> On Thu, Jun 28, 2018 at 11:26 AM, Darrell Ball wrote:
>
>> On Thu, Jun 28, 2018 at 9:41 AM, Mark Michelson
>> wrote:
>>
>>> Hi Darrell,
>>>
>>> I'm not 100% sure this is
On Thu, Jun 28, 2018 at 11:26 AM, Darrell Ball wrote:
> On Thu, Jun 28, 2018 at 9:41 AM, Mark Michelson
> wrote:
>
>> Hi Darrell,
>>
>> I'm not 100% sure this is correct. I think this change would only be
>> correct if the router's IP addresses are al
>
sudo make check-kmod -C _gcc //kernel
sudo make check-system-userspace -C _gcc //Userspace DP
>
> On Thu, Jun 28, 2018 at 11:46 AM, Darrell Ball wrote:
>
>>
>>
>> On Thu, Jun 28, 2018 at 11:44 AM, Han Zhou wrote:
>>
>>> Hi Mark, what I meant is th
think this change would only be
>>> correct if the router's IP addresses are also load balancer VIPs. In
>>> the case where the VIPs do not overlap with the router IP addresses,
>>> I think we'd want to have the ICMP responses still in place.
>&g
Thanks
Some long lines in the test file are leading to subsequent corruption in
the patch
I fixed it and will resend
Darrell
On Wed, Jun 27, 2018 at 11:54 PM, 0-day Robot wrote:
> Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out
> your patch.
> Thanks
])
The load balance VIP is "vips:30.0.0.1"
One the the router port's of interest has IP 20.0.0.2
>
>
> On 06/28/2018 01:15 AM, Darrell Ball wrote:
>
>> Non-distributed and distributed gateway load balancing is broken.
>> Recent changes for port unr
Tests are added to cover out of order fragments, overlapping fragments
and multiple extension headers in the case of IPv6.
Signed-off-by: Darrell Ball
---
tests/system-kmod-macros.at | 16
tests/system-traffic.at | 200 +++
tests/system
Signed-off-by: Darrell Ball
---
NEWS| 2 +
lib/conntrack.c | 114 +---
lib/conntrack.h | 13 ++
lib/ct-dpif.c | 24 +++
lib/ct-dpif.h | 13 ++
lib/dpctl.c | 62
tests are added to better maintain fragmentation support.
This needs backporting to 2.9.
Fixes: c8b1ad49da68("conntrack: Reorder sanity checks in extract_l3_ipvx().")
Fixes: a489b16854b5("conntrack: New userspace connection tracker.")
Signed-off-by: Darrell Ball
---
lib/conn
I sent a more complete V2.
Darrell
On Wed, Jun 27, 2018 at 6:49 PM, Darrell Ball wrote:
> Non-distributed and distributed gateway load balancing is broken.
> Recent changes for port unreachable handling broke the associated
> unsnat functionality.
>
> Fixes: 86558ac2e476 (&qu
port unreachable support to OVN logical
router.")
Fixes: 159932c9e4ea ("OVN: add TCP port unreachable support to OVN logical
router.")
Fixes: 0e858e05f76b ("OVN: add protocol unreachable support to OVN router
ports.")
CC: Lorenzo Bianconi
Signed-off-by: Darrell Ball
--
ort unreachable support to OVN logical
router.")
Fixes: 0e858e05f76b ("OVN: add protocol unreachable support to OVN router
ports.")
CC: Lorenzo Bianconi
Signed-off-by: Darrell Ball
---
ovn/northd/ovn-northd.c | 106
1 file changed,
gt; 0-day Robot writes:
>
> > Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out
> your patch.
> > Thanks for your contribution.
> >
> > I encountered some error that I wasn't expecting. See the details below.
> >
> >
> >
18 at 4:16 PM, Darrell Ball wrote:
> Signed-off-by: Darrell Ball
> ---
> NEWS| 2 +
> lib/conntrack.c | 114 ++
> +++---
> lib/conntrack.h | 13 ++
> lib/ct-dpif.c | 24 +++
> lib/c
Signed-off-by: Darrell Ball
---
NEWS| 2 +
lib/conntrack.c | 114 +---
lib/conntrack.h | 13 ++
lib/ct-dpif.c | 24 +++
lib/ct-dpif.h | 13 ++
lib/dpctl.c | 62
Tests are added to cover out of order fragments, overlapping fragments
and multiple extension headers in the case of IPv6.
Signed-off-by: Darrell Ball
---
tests/system-kmod-macros.at | 16
tests/system-traffic.at | 200 +++
tests/system
tests are added to better maintain fragmentation support.
This needs backporting to 2.9.
Fixes: c8b1ad49da68("conntrack: Reorder sanity checks in extract_l3_ipvx().")
Fixes: a489b16854b5("conntrack: New userspace connection tracker.")
Signed-off-by: Darrell Ball
---
lib/conn
Tests are added to cover out of order and overlapping fragments.
Signed-off-by: Darrell Ball
---
tests/system-kmod-macros.at | 8
tests/system-traffic.at | 96
tests/system-userspace-macros.at | 8
3 files changed, 112
tests are added to better maintain fragmentation support.
This needs backporting to 2.9.
Fixes: c8b1ad49da68("conntrack: Reorder sanity checks in extract_l3_ipvx().")
Fixes: a489b16854b5("conntrack: New userspace connection tracker.")
Signed-off-by: Darrell Ball
---
lib/conn
On Thu, Jun 14, 2018 at 12:00 PM, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
> lib/dpctl.c | 158 +++---
> --
> 1 file changed, 38 insertions(+), 120 deletions(-)
>
> diff --git a/lib/dpctl.c b/lib/dpctl.c
> index ec8c51e4b0a7..
:38 PM, "ovs-dev-boun...@openvswitch.org on behalf of Justin
Pettit" wrote:
> On Apr 8, 2018, at 7:53 PM, Darrell Ball wrote:
>
> diff --git a/lib/conntrack.c b/lib/conntrack.c
> index 2b20e93..987c034 100644
> --- a/lib/conntrac
Signed-off-by: Darrell Ball
---
tests/automake.mk | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/automake.mk b/tests/automake.mk
index c420b29..8224e5a 100644
--- a/tests/automake.mk
+++ b/tests/automake.mk
@@ -233,6 +233,13 @@ check-kernel-valgrind: all $(valgrind_wrappers
Thanks for the detailed review Justin
On Tue, Jun 5, 2018 at 11:36 PM, Justin Pettit wrote:
>
> > On Apr 8, 2018, at 7:53 PM, Darrell Ball wrote:
> >
> > diff --git a/lib/ct-dpif.c b/lib/ct-dpif.c
> > index 5fa3a97..32d55c1 100644
> > --- a/lib/ct-dpif.c
>
On Thu, May 31, 2018 at 8:32 AM, Greg Rose wrote:
> A recent patch series added support for ERSPAN but left some problems
> remaining for kernel releases from 4.10 to 4.14. This patch
> addresses those problems.
>
> Of note is that the old cisco gre compat layer code is gone for good.
>
> Also,
On Thu, May 24, 2018 at 2:16 PM, Ben Pfaff wrote:
> On Thu, May 24, 2018 at 12:08:31PM -0700, William Tu wrote:
> > On Thu, May 24, 2018 at 10:20 AM, Ben Pfaff wrote:
> > > On Thu, May 24, 2018 at 05:36:10AM -0700, William Tu wrote:
> > >> On Wed, May 23, 2018 at
Acked-by: Darrell Ball
On Wed, May 23, 2018 at 1:51 PM, Ben Pfaff wrote:
> Reported-by: Paul Greenberg
> Reported-at: https://github.com/openvswitch/ovs-issues/issues/149
> Fixes: c7b02b800615 ("Add support for OpenFlow 1.5 statistics (OXS).")
> Signed-off-by: Ben Pfaff
On Wed, May 23, 2018 at 11:27 AM, Ben Pfaff wrote:
> On Tue, May 22, 2018 at 10:58:24AM -0700, Darrell Ball wrote:
> > Flagged by clang.
> >
> > CC: Greg Rose
> > Fixes: 068794b43f0e ("erspan: Add flow-based erspan options")
> > Signed-off-by: Darrell
8794b43f0e ("erspan: Add flow-based erspan options")
Signed-off-by: Darrell Ball
---
lib/odp-util.c | 36
lib/packets.h | 6 +++---
2 files changed, 23 insertions(+), 19 deletions(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index 105ac80..767281f
Flagged by clang.
CC: William Tu
Fixes: 068794b43f0e ("erspan: Add flow-based erspan options")
Signed-off-by: Darrell Ball
---
lib/netdev-native-tnl.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-t
index = (ovs_be32 *)(ersh + 1);
^~
1 error generated.
On 5/22/18, 1:02 PM, "ovs-dev-boun...@openvswitch.org on behalf of Gregory
Rose" wrote:
On 5/22/2018 10:58 AM, Darrell Ball wrote:
> Flagged by clang.
>
> CC: Greg Rose
> Fixes:
pebcak issues on my part - Ignore this patch as it was not rebased
Also, I checked the erspan header and made some adjustments to the code similar
to v1.
Darrell
On 5/22/18, 9:31 AM, "ovs-dev-boun...@openvswitch.org on behalf of Darrell
Ball" wrote:
Flagged by clang.
Flagged by clang.
CC: Greg Rose
Fixes: 068794b43f0e ("erspan: Add flow-based erspan options")
Signed-off-by: Darrell Ball
---
lib/netdev-native-tnl.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-t
I sent a V2, which further simplified the code.
On 5/22/18, 9:23 AM, "ovs-dev-boun...@openvswitch.org on behalf of Darrell
Ball" wrote:
Flagged by clang.
CC: Greg Rose
Fixes: 068794b43f0e ("erspan: Add flow-based erspan options")
Signed-
Flagged by clang.
CC: Greg Rose
Fixes: 068794b43f0e ("erspan: Add flow-based erspan options")
Signed-off-by: Darrell Ball
---
lib/netdev-native-tnl.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-t
Flagged by clang.
CC: Greg Rose
Fixes: 068794b43f0e ("erspan: Add flow-based erspan options")
Signed-off-by: Darrell Ball
---
lib/netdev-native-tnl.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c
ind
On Fri, May 18, 2018 at 10:26 AM, Gregory Rose wrote:
> On 5/18/2018 10:15 AM, Darrell Ball wrote:
>
>>
>> On 5/18/18, 9:58 AM, "ovs-dev-boun...@openvswitch.org on behalf of
>> Gregory Rose" > gvrose8...@gmail.com> wrote:
>>
>> On 5/18/201
On Fri, May 18, 2018 at 9:57 AM, Gregory Rose wrote:
> On 5/18/2018 9:32 AM, Ben Pfaff wrote:
>
>> On Fri, May 18, 2018 at 08:41:54AM -0700, Gregory Rose wrote:
>>
>>> The other two failures I can repro on the master branch so they are not
>>> related to this patch series.
>>>
>> What are the oth
On 5/18/18, 9:58 AM, "ovs-dev-boun...@openvswitch.org on behalf of Gregory
Rose" wrote:
On 5/18/2018 9:32 AM, Ben Pfaff wrote:
> On Fri, May 18, 2018 at 08:41:54AM -0700, Gregory Rose wrote:
>> The other two failures I can repro on the master branch so they are not
>> related t
On Fri, May 18, 2018 at 9:39 AM, Ben Pfaff wrote:
> On Fri, May 18, 2018 at 09:29:22AM -0700, Darrell Ball wrote:
> > The test 'ofproto-dpif - in place modification (vlan)' fails often
> > due to miss handling. Hence, make it more predictable by specifying
> > tha
The test 'ofproto-dpif - in place modification (vlan)' fails often
due to miss handling. Hence, make it more predictable by specifying
that misses should just be dropped.
Signed-off-by: Darrell Ball
---
tests/ofproto-dpif.at | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
di
The test 'ofproto-dpif - in place modification (vlan)' fails often
due to miss handling. Hence, make it more predictable by specifying
that misses should just be dropped.
Signed-off-by: Darrell Ball
---
tests/ofproto-dpif.at | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
I sent a V3.
On 5/16/18, 5:59 PM, "ovs-dev-boun...@openvswitch.org on behalf of Darrell
Ball" wrote:
Correct and clarify 'steal'/'may_steal' in odp_execute_actions().
Reported-by: Ilya Maximets
Signed-off-by: Darrell Ball
---
lib/odp
Correct and clarify 'steal'/'may_steal' comments in
odp_execute_actions().
Reported-by: Ilya Maximets
Signed-off-by: Darrell Ball
---
v1->v3: Correct the last sentence which somehow is not getting
penned as intended.
lib/odp-execute.c | 8 ++--
1 file chan
I sent a V2
On 5/16/18, 7:10 PM, "ovs-dev-boun...@openvswitch.org on behalf of Darrell
Ball" wrote:
Maybe 'should_steal' is better semantics than 'must_steal'
On Wed, May 16, 2018 at 6:55 PM, Darrell Ball wrote:
> Signed-off-by: Darr
Different patches
On 5/16/18, 7:38 PM, "Ben Pfaff" wrote:
I got at least two copies of v2. Are they different?
On Thu, May 17, 2018 at 12:59:49AM +0000, Darrell Ball wrote:
> I sent a V2.
>
> On 5/16/18, 5:46 PM, "ovs-dev-boun...@openvswitch.o
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 4 ++--
lib/dpif-netdev.c | 27 ++-
lib/dpif.c| 6 +++---
lib/netdev-dpdk.c | 18 +-
lib/odp-execute.c | 4 ++--
lib/odp-execute.h | 2 +-
6 files changed, 31 insertions(+), 30 deletions
Maybe 'should_steal' is better semantics than 'must_steal'
On Wed, May 16, 2018 at 6:55 PM, Darrell Ball wrote:
> Signed-off-by: Darrell Ball
> ---
> lib/dp-packet.h | 4 ++--
> lib/dpif-netdev.c | 26 +-
> lib/dpif.c|
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 4 ++--
lib/dpif-netdev.c | 26 +-
lib/dpif.c| 6 +++---
lib/netdev-dpdk.c | 18 +-
lib/odp-execute.c | 4 ++--
lib/odp-execute.h | 2 +-
6 files changed, 30 insertions(+), 30 deletions
I sent a V2.
On 5/16/18, 5:46 PM, "ovs-dev-boun...@openvswitch.org on behalf of Darrell
Ball" wrote:
Correct and clarify 'steal'/'may_steal' in odp_execute_actions().
Reported-by: Ilya Maximets
Signed-off-by: Darrell Ball
---
lib/odp
Correct and clarify 'steal'/'may_steal' in odp_execute_actions().
Reported-by: Ilya Maximets
Signed-off-by: Darrell Ball
---
lib/odp-execute.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/odp-execute.c b/lib/odp-execute.c
index 1969f02..
Correct and clarify 'steal'/'may_steal' in odp_execute_actions().
Reported-by: Ilya Maximets
Signed-off-by: Darrell Ball
---
lib/odp-execute.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/odp-execute.c b/lib/odp-execute.c
index 1969f02..
e problem.
>
>
>
> sudo ip netns exec ns2 ping -s 5000 -W 1 192.168.10.10 ç= Note packet
> size is increased to force fragmentation at the sender.
>
>
>
> 2018-05-14T18:35:44.571Z|00114|util|EMER|lib/odp-util.c:7008: assertion
> flow->nw_proto == base_flow->nw_proto &
Thanks Justin
Darrell
On 5/15/18, 6:05 PM, "ovs-dev-boun...@openvswitch.org on behalf of Justin
Pettit" wrote:
> On May 14, 2018, at 6:38 PM, Darrell Ball wrote:
>
> Fix tcp sequence tracking for cases when picking up an existing
connection.
>
On Wed, May 16, 2018 at 6:01 AM, Ilya Maximets
wrote:
> On 15.05.2018 20:18, Ben Pfaff wrote:
> > On Tue, May 15, 2018 at 02:23:38PM +0300, Ilya Maximets wrote:
> >> Unconditional return may cause packet leak in case of
> >> 'may_steal == true'.
> >>
> >> Additionally, removed redundant checking
it message
Thanks; I do add comments below '---' from time to time :-) but you are
right, this does not belong in the commit message.
I also added a 'Fixes' tag for completeness.
> .
>
> -=-=-=-=-=-=-=-=-=-=-
> ...
> would be lessened and code complexity increased
added
complexity is not worth the benefit of the slightly more strictness in the
case of picking up a new connection.
Fixes: a489b16854b5 ("conntrack: New userspace connection tracker")
Signed-off-by: Darrell Ball
---
Fix needs backporting to 2.7.
lib/conntrack-tcp.c | 9 +++--
1
as well.
Would you mind describing your test in more detail (packets and flows)?
Thanks Darrell
> Thanks
> Rohith
>
> On 11/05/18, 2:16 AM, "Darrell Ball" wrote:
>
> Thanks Rohith
> I see this patch was applied, but I have one question inline.
>
&g
Thanks Rohith
I see this patch was applied, but I have one question inline.
On 4/20/18, 1:48 AM, "ovs-dev-boun...@openvswitch.org on behalf of Rohith
Basavaraja" wrote:
Currently when fragmented packets are to be transmitted in to tunnel,
base_flow->nw_frag which was initially non-zero
On 5/9/18, 2:19 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff"
wrote:
On Wed, Apr 25, 2018 at 01:11:42PM -0700, Darrell Ball wrote:
> The function inet_parse_active() is an external API and used
> as one stop shopping for parsing ip add
sent a v2
On 5/8/18, 1:23 PM, "ovs-dev-boun...@openvswitch.org on behalf of Darrell Ball"
wrote:
Signed-off-by: Darrell Ball
---
vswitchd/vswitch.xml | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/vswitchd/vswitch.xml
Signed-off-by: Darrell Ball
---
v1->v2: Fix some broken wording.
vswitchd/vswitch.xml | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index 9c2a826..74544e4 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.
On Tue, May 8, 2018 at 11:41 AM, Ben Pfaff wrote:
> On Tue, May 08, 2018 at 10:22:23AM -0700, Darrell Ball wrote:
> > Add ovsdb-server command option to the manager_options
> > documentation.
> >
> > Signed-off-by: Darrell Ball
>
> Thanks, I applied this to mast
Signed-off-by: Darrell Ball
---
vswitchd/vswitch.xml | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index 9c2a826..b5318a1 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -689,8 +689,15
Thanks; this is an excellent addition to the tutorial.
I sent out a related patch to extend the ovs-vsctl ‘manager_options’
documentation
https://patchwork.ozlabs.org/patch/910352/
Acked-by: Darrell Ball
On 5/8/18, 8:30 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff&quo
Add ovsdb-server command option to the manager_options
documentation.
Signed-off-by: Darrell Ball
---
utilities/ovs-vsctl.8.in | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/utilities/ovs-vsctl.8.in b/utilities/ovs-vsctl.8.in
index b18782c..9f6ea6d 100644
--- a
#
# Used to check fragmentation counters for some fragmentation tests using
Darrell
On Sun, Apr 8, 2018 at 7:54 PM, Darrell Ball wrote:
> Enhance fragmentation tests for userspace datapath.
>
> Signed-off-by: Darrell Ball
> ---
> tests/system-kmod-macros.at | 30 --
>
} else {
+next_state = IPF_LIST_STATE_REASS_FAIL;
+}
}
}
ipf_list->state = next_state;
Darrell
On Sun, Apr 8, 2018 at 7:53 PM, Darrell Ball wrote:
> Fragmentation handling is added for supporting conntrack.
> Both v4 and v6 are supported.
>
The function inet_parse_active() is an external API and used
as one stop shopping for parsing ip address and L4 port
combinations from many other modules. Hence, the function
header is extended to describe the special cases that it
handles.
Signed-off-by: Darrell Ball
---
lib/socket-util.c | 6
Thanks for the patch.
On Wed, Apr 25, 2018 at 8:43 AM, Ben Pfaff wrote:
> At startup time, ovn-controller connects to the OVS database and retrieves
> a pointer to the southbound database, then connects to the southbound
> database and retrieves a snapshot. Until now, however, it didn't pay
> a
-balancing ok
101: ovn -- load-balancing - same subnet.ok
102: ovn -- load balancing in gateway router ok
103: ovn -- multiple gateway routers, load-balancing ok
104: ovn -- load balancing in router with gateway router port ok
Signed-off-by: Darrell Ball
ole all OpenFlow messages received.
Usually, switch
should specify the name of a bridge in the ovs−vswitchd database.
“
eg) ovs-ofctl monitor br0 65534 invalid_ttl --detach --no-chdir --pidfile 2>
ofctl_monitor.log
On 24 April 2018 at 02:42, Darrell Ball wrote:
> //Y
//You can verify that OVS supports deletion by cookie specification by checking
these tests:
932: ofproto.at:1746ofproto - del flows based on cookie
933: ofproto.at:1767ofproto - del flows based on cookie mask
// Run the tests using “make check” like this:
sudo make check TESTSUITEFLAG
increased netlink traffic and processing with associated wasted
work. Let us flag a configuration issue at warn level (rather than dbg) to
catch the problem early.
Signed-off-by: Darrell Ball
---
lib/netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/netdev.c b/lib
Not yet; I will check with Justin when he gets back from PTO
On 4/10/18, 4:50 PM, "Ben Pfaff" wrote:
Did you find anyone to take a look?
On Fri, Mar 09, 2018 at 07:29:06PM +0000, Darrell Ball wrote:
> Windows folks have also been looking at this, as this fil
A verbose option is added to dump the frag lists.
Signed-off-by: Darrell Ball
---
lib/ct-dpif.c | 24 +
lib/ct-dpif.h | 4 +++
lib/dpctl.c | 35 +++--
lib/dpctl.man | 5 ++--
lib/dpif-netdev.c | 25 ++
lib/dpif
Enhance fragmentation tests for userspace datapath.
Signed-off-by: Darrell Ball
---
tests/system-kmod-macros.at | 30 --
tests/system-traffic.at | 33 +++
tests/system-userspace-macros.at | 118 ---
3 files changed, 166
A new command "ovs-appctl dpctl/ipf-set-maxfrags" is added
for userspace datapath conntrack fragmentation support.
Signed-off-by: Darrell Ball
---
NEWS| 2 ++
lib/ct-dpif.c | 8
lib/ct-dpif.h | 1 +
lib/dpctl.c
A new command "ovs-appctl dpctl/ipf-get-status" is added
for userspace datapath conntrack fragmentation support.
The command shows the configuration status as well as
fragment counters.
Signed-off-by: Darrell Ball
---
NEWS| 2 ++
lib/ct-dpif.c | 21 +
in the database as well and overall simplicity.
Accordingly, fragmentation handling is enabled by default.
This patch enables fragmentation tests for the userspace datapath.
Signed-off-by: Darrell Ball
---
NEWS |2 +
include/sparse/netinet/ip6.h |1 +
lib
Signed-off-by: Darrell Ball
---
NEWS| 2 ++
lib/ct-dpif.c | 8
lib/ct-dpif.h | 1 +
lib/dpctl.c | 41 +
lib/dpctl.man | 11 +++
lib/dpif-netdev.c | 9 +
lib/dpif-netlink.c | 1
601 - 700 of 1564 matches
Mail list logo
