Thanks for the series/work; I’ll be reviewing this series, but focusing on the
high level aspects initially.
Some high level comments:
I noticed that your own comments in the series often pointed out various issues
with this series, such as
assuming TCP transport, which is ‘unusual’, no NAT su
superceded and now outdated, but let me fold your comments for
V3,
since there is now a request to combine some weakly related patches including
this one into a series.
Cheers Darrell
On Sun, Nov 19, 2017 at 01:02:19PM -0800, Darrell Ball wrote:
> Fix up some instances where var
On 1/4/18, 1:25 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff"
wrote:
On Fri, Dec 15, 2017 at 07:32:48PM -0800, Darrell Ball wrote:
> Presently, alg expectations are removed by being time expired.
> This was intended to happen before the control
On 1/4/18, 1:30 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff"
wrote:
On Mon, Dec 18, 2017 at 08:27:17AM -0800, Darrell Ball wrote:
> Get and set dpctl commands are added for conntrack maxconns.
> These commands are only supported in the userspace
On 1/4/18, 1:07 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff"
wrote:
On Tue, Dec 26, 2017 at 10:51:38AM -0800, Darrell Ball wrote:
> In order to support more algs with different requirements,
> expectation handling is allowed to handle more cases,
In order to support more algs with different requirements,
expectation handling is allowed to handle more cases, such as
a wildcard source ip as in the case of SIP. NAT can also be
skipped in some alg cases.
Some renaming is done to support the above changes.
Signed-off-by: Darrell Ball
ookups.
> >
> > 8. The PMD stats test is updated to handle the new user stats of
> > packets received, packets recirculated and average number of datapath
> > passes per packet.
> >
> > On top of that introduce a "-pmd " option to
Signed-off-by: Darrell Ball
---
tests/system-kmod-macros.at | 19 +
tests/system-traffic.at | 85
tests/system-userspace-macros.at | 12 ++
3 files changed, 116 insertions(+)
diff --git a/tests/system-kmod-macros.at b/tests
A get command is added for number of conntrack connections.
This command is only supported in the userspace datapath
at this time.
Signed-off-by: Darrell Ball
Signed-off-by: Antonio Fischetti
Co-authored-by: Antonio Fischetti
---
lib/conntrack.c | 7 +++
lib/conntrack.h | 1
Get and set dpctl commands are added for conntrack maxconns.
These commands are only supported in the userspace
datapath at this time.
Signed-off-by: Darrell Ball
Signed-off-by: Antonio Fischetti
Co-authored-by: Antonio Fischetti
---
lib/conntrack.c | 14 +++
lib/conntrack.h
Commands are added to:
Get the number of conntrack connections.
Get the maximum limit of conntrack connections.
Set the maximum limit of conntrack connections.
These commands are only supported in the userspace
datapath at this time.
A supporting test is added.
Darrell Ball (3):
dpctl
at:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-December/341683.html
Signed-off-by: Darrell Ball
---
v1->v2: Use single node for both expectations and expectation_refs.
Remove outdated comment.
Simplify an api.
lib/conntrack-private.h | 7 +-
lib/conntrack.c
--Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Monday, December 11, 2017 6:44 PM
> To: Fischetti, Antonio ;
> d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v3 2/5] conntrack: add commands to r/w CT
> parameters.
>
>
I sent a V2 here
https://patchwork.ozlabs.org/patch/847315/
an extra signoff had snuck into v1
Thanks Darrell
On 12/11/17, 5:22 PM, "Darrell Ball" wrote:
Ben
I sent a 2.7 patch here:
https://patchwork.ozlabs.org/patch/847308/
it should be applicable for 2
the error
can be generated by any intermediate node.
Reported-by: wangzhike
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-December/341609.html
Fixes: a489b1685 ("conntrack: New userspace connection tracker.")
CC: Daniele Di Proietto
Signed-off-by: Darrell Ball
Sig
ou look at that?
On Mon, Dec 11, 2017 at 10:28:32PM +0000, Darrell Ball wrote:
> Yes, it is Ben
>
> Thanks Darrell
>
> On 12/11/17, 2:27 PM, "Ben Pfaff" wrote:
>
> It fails to apply due to conflicts in system-traffic.at.
the error
can be generated by any intermediate node.
Reported-by: wangzhike
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-December/341609.html
Fixes: a489b1685 ("conntrack: New userspace connection tracker.")
CC: Daniele Di Proietto
Signed-off-by: Darrell Ball
Sig
A few suggestions Yi-hung
Thanks Darrell
On 11/21/17, 5:04 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yi-Hung
Wei" wrote:
This patch adds support of flushing a conntrack entry specified by the
conntrack 5-tuple in dpif-netdev.
Signed-off-by: Yi-Hung Wei
---
li
Yes, it is Ben
Thanks Darrell
On 12/11/17, 2:27 PM, "Ben Pfaff" wrote:
It fails to apply due to conflicts in system-traffic.at. Is it safe to
drop that change and apply the rest?
On Mon, Dec 11, 2017 at 10:22:39PM +0000, Darrell Ball wrote:
> Needs to go ba
Needs to go back to 2.6; at least the changes in lib/conntrack.c
Thanks Darrell
On 12/11/17, 2:20 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff"
wrote:
On Wed, Dec 06, 2017 at 06:04:20PM -0800, Darrell Ball wrote:
> An address sanity check is done on icmp
One extra note inline
Thanks Darrell
On 12/11/17, 8:35 AM, "Darrell Ball" wrote:
Thanks Antonio for doing all this and pushing it forward.
Regarding patches 2-4:
I understand you want to save some code for various possible set and get
operations.
The pri
CC: Kevin Traynor
CC: Darrell Ball
Signed-off-by: Antonio Fischetti
---
Documentation/intro/install/dpdk.rst | 25 +
lib/dpctl.man| 10 ++
2 files changed, 35 insertions(+)
diff --git a/Documentation/int
f *, uint32_t *nconns);
/* Meters */
///////
On 10/13/17, 1:27 AM, "ovs-dev-boun...@openvswitch.org on behalf of
antonio.fische...@intel.com" wrote:
Add infrastructure to implement:
- dpctl/ct-get-glbl-cf
needed by prior art
and some cases where they were needed but missed.
There was one case where there was a missing space after "}".
There were a few cases where for loop index decalrations could be
folded into the loop.
One function was missing some const qualifiers.
Signed-off-by: Da
On 12/6/17, 2:57 PM, "ovs-dev-boun...@openvswitch.org on behalf of Justin
Pettit" wrote:
> On Nov 21, 2017, at 5:00 PM, Yi-Hung Wei wrote:
>
> diff --git a/lib/conntrack.c b/lib/conntrack.c
> index f5a3aa9fab34..c9077c07042c 100644
> --- a/lib/conntrack.c
>
at:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-December/341683.html
Signed-off-by: Darrell Ball
---
This patch depends on the series here:
https://patchwork.ozlabs.org/project/openvswitch/list/?series=16626
lib/conntrack-private.h | 13 ++-
lib/conntrack.c
is “making assumptions”.
I am open to the decision. So if you think your patch is more suitable, I
can be the co-author.
[Darrell] I will keep you as co-author then.
Br,
Wang Zhike
-Original Message-
From: Darrell Ball [mailto:db...@vmware.com]
Sent
.
Also. if you prefer, I can make you the author.
Thanks Darrell
On 12/6/17, 11:22 AM, "Darrell Ball" wrote:
Thanks for looking at this.
In the commit message, can you delineate.
1/ The forward direction packet in terms of src ip, dest ip, L4 attributes
2/ T
the error
can be generated by any intermediate node.
Reported-by: wangzhike
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-December/341609.html
Fixes: a489b1685 ("conntrack: New userspace connection tracker.")
CC: Daniele Di Proietto
Signed-off-by: Darrell Ball
Sig
Thanks for looking at this.
In the commit message, can you delineate.
1/ The forward direction packet in terms of src ip, dest ip, L4 attributes
2/ The reverse direction error packet in terms of src ip, dest ip, icmp error
payload
Darrell
On 12/4/17, 10:22 PM, "ovs-dev-boun...@openvswitch.org
Thanks for the reviews Aaron.
Darrell
On 12/6/17, 11:04 AM, "ovs-dev-boun...@openvswitch.org on behalf of Aaron
Conole" wrote:
Darrell Ball writes:
> Presently, alg processing is enabled by default to better exercise code.
> This is similar to kernels be
On 11/30/17, 8:02 AM, "Aaron Conole" wrote:
Darrell Ball writes:
> There is a bug here in that the control connection should still be
created even though it is likely an unused control connection.
> The following incremental fixes it.
Good catch.
.
A test is extended to check that the control connection is still
created in such a case.
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 32 +++-
tests/system-traffic.at | 21 +
2 files changed, 48 insertions(+), 5 deletions(-)
diff --git
: Darrell Ball
---
lib/conntrack.c| 39 +++
lib/conntrack.h| 8
lib/dpif-netdev.c | 4 ++--
tests/test-conntrack.c | 6 +++---
4 files changed, 36 insertions(+), 21 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index
2/ Fix a bug in patch 3 and add an associated test to
check that the control connection is still present even
when a helper is not bound.
Darrell Ball (3):
conntrack: Refactor algs.
conntrack: Allow specified alg port numbers.
conntrack: Disable algs by defa
Upcoming requirements for new algs make it desirable to split out
alg helpers more cleanly.
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 156
1 file changed, 101 insertions(+), 55 deletions(-)
diff --git a/lib/conntrack.c b/lib
will submit with this patch
Darrell
On 11/22/17, 12:56 AM, "ovs-dev-boun...@openvswitch.org on behalf of Darrell
Ball" wrote:
Presently, alg processing is enabled by default to better exercise code.
This is similar to kernels before 4.7 as well. The recommended defa
even say something like
“since your VM accepts all incoming traffic without filtering, why do you even
use conntrack rules for that VM”, for example.
I know there is an infinite number of broken conntrack pipelines that can be
written.
Thanks Darrell
On 11/20/17, 6:13 PM, "Darrell
some relevant plumbing support;
I would submit that soon, since it is more relevant now.
Darrell
On Sat, Nov 25, 2017 at 07:37:23PM +0000, Darrell Ball wrote:
> Let me clarify some general points.
>
> 1/ We will not be porting any code from the Linux kernel, whether
Let me clarify some general points.
1/ We will not be porting any code from the Linux kernel, whether it be SIP
module code or anything else.
2/ Furthermore, we will not be using proprietary code algorithms and other
aspects from the Linux kernel.
3/ Furthermore, those people working in, havin
On 11/20/17, 7:17 AM, "ovs-dev-boun...@openvswitch.org on behalf of Aaron
Conole" wrote:
Hi Darrell,
Darrell Ball writes:
> Upcoming requirements for new algs make it necessary to split out
> alg helper more cleanly.
>
> Signe
.
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 35 +--
1 file changed, 29 insertions(+), 6 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index 1364d05..fed9f61 100644
--- a/lib/conntrack.c
+++ b/lib/conntrack.c
@@ -819,6 +819,26 @@ conn_clean
Algs can use variable control port numbers for servers.
The main use case is a kind of feeble security measure; the
thinking being by some is that it obscures the alg traffic.
It is really not very effective, but the kernel has this
capability. This patch mimics it.
Signed-off-by: Darrell Ball
Upcoming requirements for new algs make it desirable to split out
alg helper more cleanly.
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 108
1 file changed, 69 insertions(+), 39 deletions(-)
diff --git a/lib/conntrack.c b/lib
Some refactoring of alg support is done.
Also algs are disabled by default unless an alg specifier
is supplied; this allows for enhanced security and matches
later kernels.
Another change to allow for non-standard alg conntrol
port specification.
Darrell Ball (3):
conntrack: Refactor algs
On 11/20/17, 2:53 PM, "Jan Scheurich" wrote:
Thanks, Darrel, for the quick patch.
I have one major concern (see below).
> > This code doesn't care across packets. It simply always sets
> > CS_ESTABLISHED and CS_REPLY_DIR when ctx->reply is true.
> >
> >
On 11/20/17, 10:02 AM, "Aaron Conole" wrote:
Darrell Ball writes:
> On 11/20/17, 9:43 AM, "Aaron Conole" wrote:
>
> Darrell Ball writes:
>
> > On 11/20/17, 7:46 AM, "ovs-dev-boun...@openvswitch.org on beha
On 11/20/17, 9:43 AM, "Aaron Conole" wrote:
Darrell Ball writes:
> On 11/20/17, 7:46 AM, "ovs-dev-boun...@openvswitch.org on behalf of
> Aaron Conole" acon...@redhat.com> wrote:
>
> Darrell Ball writes:
>
>
On 11/20/17, 7:19 AM, "ovs-dev-boun...@openvswitch.org on behalf of Aaron
Conole" wrote:
Hi Darrell,
Darrell Ball writes:
> Presently, alg processing is enabled by default to exercise testing.
> This is similar to kernels before 4.7. The rec
On 11/20/17, 7:46 AM, "ovs-dev-boun...@openvswitch.org on behalf of Aaron
Conole" wrote:
Darrell Ball writes:
> Presently, the userpace connection tracker 'established' packet
> state diverges from the kernel and this patch brings them in line.
On 11/19/17, 11:18 AM, "Ben Pfaff" wrote:
On Fri, Nov 17, 2017 at 07:34:49PM +0000, Darrell Ball wrote:
> This patch mostly breaks OVS coding style in many instances and also
invents its own coding guidelines.
>
> 1/OVS prefers variable declarations near t
On 11/19/17, 10:25 AM, "Flavio Leitner" wrote:
On Sat, 18 Nov 2017 00:41:27 +
Darrell Ball wrote:
> On 11/17/17, 3:01 PM, "Flavio Leitner" wrote:
>
> On Fri, 17 Nov 2017 19:34:49 +
> Darrell Ball wrote:
>
on but the discrepancy
between documentation and kernel behavior certainly didn’t help.
Perhaps it is better we continue this discussion in person during the OVS
conference?
Regards, Jan
From: Darrell Ball [mailto:db...@vmware.com]
Sent: Saturday, 04 November, 2017 01:47
To: Jan Scheuric
Hi Flavio
Let me know if you like to be co-author for this patch; I would be
fine with that.
Thanks Darrell
On 11/19/17, 1:04 PM, "ovs-dev-boun...@openvswitch.org on behalf of Darrell
Ball" wrote:
Fix up some instances where variable declarations were not close
enough to
written to
commit a connection in the trusted direction, which is recommended.
A test is added to verify this.
The documentation is updated to describe the new behavior of
'established' and also clarify 'new'.
Signed-off-by: Darrell Ball
---
lib/conntrack-privat
: Darrell Ball
---
lib/conntrack.c | 35 +--
1 file changed, 29 insertions(+), 6 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index 7fbcfba..dea2fed 100644
--- a/lib/conntrack.c
+++ b/lib/conntrack.c
@@ -789,13 +789,34 @@ conn_clean(struct conntrack *ct
needed by prior art
and some cases where they were needed but missed.
There was one case where there was a missing space after "}".
There were a few cases where for loop index decalrations could be
folded into the loop.
Signed-off-by: Darrell Ball
---
lib/conntra
Upcoming requirements for new algs make it necessary to split out
alg helper more cleanly.
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 73 ++---
1 file changed, 44 insertions(+), 29 deletions(-)
diff --git a/lib/conntrack.c b/lib
g
checking/helpers.
Darrell Ball (4):
conntrack: Some formatting improvements.
conntrack: Refactor algs.
conntrack: Disable algs by default.
conntrack: Change established state to match kernel.
lib/conntrack-private.h | 1 +
lib/conntrack.c
On 11/17/17, 3:01 PM, "Flavio Leitner" wrote:
On Fri, 17 Nov 2017 19:34:49 +
Darrell Ball wrote:
> This patch mostly breaks OVS coding style in many instances and also
invents its own coding guidelines.
>
> 1/OVS prefers variable declaratio
This patch mostly breaks OVS coding style in many instances and also invents
its own coding guidelines.
1/OVS prefers variable declarations near their usage and your patch violates
extensively.
Most of this patch is related to this.
I’ll point out a few to provide examples, but I don’t like this
t. So the ODL
developers testing with kernel datapath assumed their design was suitable. You
can argue that was a misunderstanding of the function but the discrepancy
between documentation and kernel behavior certainly didn’t help.
Perhaps it is better we continue this discussion in pers
er flags are set.
2.
If trk is set, one or more other flags may be set.
3.
If inv is set, only the trk flag is also set.
4.
new and est are mutually exclusive.
5.
new and rpl are mutu
I’ll look at these in detail Ben
Thanks Darrell
On 11/3/17, 2:49 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff"
wrote:
On Fri, Oct 13, 2017 at 09:25:12AM +0100, antonio.fische...@intel.com wrote:
> This change comes from the consideration that when the CT is enabled
I believe this series is superceded by the HWOL series from Yuanhan Liu
y...@fridaylinux.org
On 10/30/17, 2:22 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff"
wrote:
On Wed, Jul 05, 2017 at 12:27:08PM +, Shachar Beiser wrote:
> The HW set the mark id that represents
This patch was merged to dpdk_merge on Sept 6 and later merged to ovs.
https://mail.openvswitch.org/pipermail/ovs-dev/2017-September/338413.html
On 10/30/17, 2:38 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff"
wrote:
Hi Ian and Gao, it looks like this patch never got applied
On 10/19/17, 9:56 AM, "ovs-dev-boun...@openvswitch.org on behalf of
antonio.fische...@intel.com" wrote:
In case a mempool name could not be generated log a message
and return a null mempool pointer to the caller.
CC: Mark B Kavanagh
CC: Darrell Ball
CC: Ci
On 9/27/17, 3:41 AM, "Finn Christensen" wrote:
-Original Message-
From: Yuanhan Liu [mailto:y...@fridaylinux.org]
Sent: 27. september 2017 11:47
To: Finn Christensen
Cc: Darrell Ball ; d...@openvswitch.org; Chandran
Sugesh ; Si
On 9/26/17, 8:27 PM, "Yuanhan Liu" wrote:
On Wed, Sep 27, 2017 at 03:13:33AM +0000, Darrell Ball wrote:
>
>
> On 9/26/17, 6:25 PM, "Yuanhan Liu" wrote:
>
> On Tue, Sep 26, 2017 at 09:58:16PM +, Darrell Ball wrote:
>
On 9/26/17, 6:25 PM, "Yuanhan Liu" wrote:
On Tue, Sep 26, 2017 at 09:58:16PM +0000, Darrell Ball wrote:
> The second major change is there is a thread introduced to do the real
> flow offload. This is for diminishing the overhead by hw flow offload
&g
entioned earlier.
The data would need to be from a non-instrumented version of the
code.
I think the rev_conn->conn_type need to be CT_CONN_TYPE_UN_NAT.
From: Darrell Ball [mailto:dlu...@gmail.com]
Sent: Tuesday, September 12, 2017 12:38 PM
To: wangy
On 9/25/17, 12:41 PM, "Ben Pfaff" wrote:
On Mon, Sep 25, 2017 at 06:37:29PM +0000, Darrell Ball wrote:
>
>
> On 9/25/17, 11:31 AM, "Ben Pfaff" wrote:
>
> On Mon, Sep 25, 2017 at 06:28:46PM +, Darrell Ball wrote:
>
On 9/25/17, 10:37 PM, "Yuanhan Liu" wrote:
Some hightlights in v3
==
Here is the v3, with 2 major changes and further testings (including
many flows). This took more effort than I thought, thus v3 publication
has been delayed for a while.
Th
On 9/26/17, 8:06 AM, "ovs-dev-boun...@openvswitch.org on behalf of
antonio.fische...@intel.com" wrote:
Log an error message when the creation of a name for a
new mempool fails.
CC: Ciara Loftus
CC: Kevin Traynor
CC: Aaron Conole
Signed-off-by: Antonio Fischetti
On 9/26/17, 12:58 PM, "Darrell Ball" wrote:
On 9/26/17, 8:04 AM, "ovs-dev-boun...@openvswitch.org on behalf of
antonio.fische...@intel.com" wrote:
In a PVP test where vhostuser ports are configured as
clients, OvS crashes when QEMU is la
On 9/26/17, 8:05 AM, "ovs-dev-boun...@openvswitch.org on behalf of
antonio.fische...@intel.com" wrote:
Skip initialization of mempool objects if this was already
done in a previous call to dpdk_mp_create.
CC: Ciara Loftus
CC: Kevin Traynor
CC: Aaron Conole
Signe
On 9/26/17, 8:04 AM, "ovs-dev-boun...@openvswitch.org on behalf of
antonio.fische...@intel.com" wrote:
In a PVP test where vhostuser ports are configured as
clients, OvS crashes when QEMU is launched.
This patch avoids the repeated calls to netdev_change_seq_changed
after the r
rrell
Ball" wrote:
A new debug function is added and used in a
subsequent patch.
Acked-by: Antonio Fischetti
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 58
+
1 file changed, 58
Add an OVS_UNLIKELY and reorder a few variable condition
checks.
Acked-by: Bhanuprakash Bodireddy
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index 3026772..33d2a21 100644
--- a/lib
Bodireddy
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-September/338515.html
Acked-by: Bhanuprakash Bodireddy
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntra
it has been
recreated.
Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.")
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 34 --
1 file changed, 28 insertions(+), 6 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
ind
A new debug function is added and used in a
subsequent patch.
Acked-by: Antonio Fischetti
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 58 +
1 file changed, 58 insertions(+)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index
Create a separate function from existing code, so the
code can be reused in a subsequent patch; no change
in functionality.
Acked-by: Bhanuprakash Bodireddy
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 41 -
1 file changed, 28 insertions(+), 13
re the
former function is invoked. This is an additional fix.
Signed-off-by: Zoltan Balogh
Signed-off-by: Laszlo Suru
Co-authored-by: Laszlo Suru
CC: Jan Scheurich
CC: Sugesh Chandran
CC: Darrell Ball
Signed-off-by: Darrell Ball
---
lib/dp-packet.c | 1 -
lib/dp-packet.h | 3 ++-
lib/netdev-
proper way to handle
this. In addition to initializing cutlen in received packets,
the other OVS transient fields are removed from the DPDK pool
initialization.
Acked-by: Sugesh Chandran
Signed-off-by: Darrell Ball
---
lib/dp-packet.c | 16 +---
lib/dp-packet.h | 10 ++
lib
On 9/25/17, 12:41 PM, "Ben Pfaff" wrote:
On Mon, Sep 25, 2017 at 06:37:29PM +0000, Darrell Ball wrote:
>
>
> On 9/25/17, 11:31 AM, "Ben Pfaff" wrote:
>
> On Mon, Sep 25, 2017 at 06:28:46PM +, Darrell Ball wrote:
>
On 9/25/17, 2:51 AM, "Fischetti, Antonio" wrote:
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Friday, September 22, 2017 9:26 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH
You would print error in the cases as well
What do you think ?
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Friday, September 22, 2017 8:42 AM
> To: Fischetti, Antonio ; d...@openvs
On 9/25/17, 11:31 AM, "Ben Pfaff" wrote:
On Mon, Sep 25, 2017 at 06:28:46PM +0000, Darrell Ball wrote:
>
>
> On 9/25/17, 10:49 AM, "ovs-dev-boun...@openvswitch.org on behalf of
Justin Pettit"
wrote:
>
>
> > On
On 9/25/17, 10:49 AM, "ovs-dev-boun...@openvswitch.org on behalf of Justin
Pettit" wrote:
> On Sep 25, 2017, at 5:54 AM, Russell Bryant wrote:
>
> There's some important changes in branch-2.7. Can we do a 2.7.3
> release soon? Does anyone have anything they need addres
Are there any other comments?
On 8/30/17, 10:49 AM, "Darrell Ball" wrote:
Thanks Kevin
Naming is hard.
The name looks a bit more intuitive and matches closely with the
description previously added.
Darrell
On 8/30/17, 10:45 AM, "Kevin
Are there any other comments for this patch?
On 8/30/17, 11:01 AM, "Darrell Ball" wrote:
Thanks for the patch Kevin
On 8/30/17, 10:45 AM, "Kevin Traynor" wrote:
rxq_cycle_sort summed the latest cycles from each queue for sorting.
While
Thanks for working on this Billy
One comment inline.
On 9/22/17, 6:47 AM, "Billy O'Mahony" wrote:
Hi All,
Please find attached RFC patch for EMC load-shedding [1] as promised [2].
This applies clean on 5ff834 "Increment ct packet counters..." It also uses
Ilya's patch "
Hi Billy
Maybe you need to rebase your branch; this patch was applied a couple weeks ago.
Thanks Darrell
On 9/22/17, 6:47 AM, "Billy O'Mahony" wrote:
From: Ilya Maximets
DP_STAT_LOOKUP_HIT statistics used mistakenly for calculation
of total number of packets. This leads to co
Co-authored-by: Laszlo Suru
CC: Jan Scheurich
CC: Sugesh Chandran
CC: Darrell Ball
---
lib/dp-packet.c | 1 -
lib/dp-packet.h | 3 ++-
lib/netdev-dpdk.c | 7 ---
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/lib/dp-packet.c b/li
I applied the patch to dpdk_merge here
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_darball_ovs_commits_dpdk-5Fmerge&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=A2_FCacqbp2moAo3HGFlTuxsjONUGhlN42OBcAuQQ6w&s=b6btPKhgvOFr2GOUYvktND6kaC6jc3fXI-mXfvNgXOU&e=
On 9/2
I applied the patch to dpdk_merge here
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_darball_ovs_commits_dpdk-5Fmerge&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=A2_FCacqbp2moAo3HGFlTuxsjONUGhlN42OBcAuQQ6w&s=b6btPKhgvOFr2GOUYvktND6kaC6jc3fXI-mXfvNgXOU&e=
On 9/2
I applied the patch to dpdk_merge here
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_darball_ovs_commits_dpdk-5Fmerge&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=A2_FCacqbp2moAo3HGFlTuxsjONUGhlN42OBcAuQQ6w&s=b6btPKhgvOFr2GOUYvktND6kaC6jc3fXI-mXfvNgXOU&e=
On 9/2
I applied the patch to dpdk_merge here
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_darball_ovs_commits_dpdk-5Fmerge&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=A2_FCacqbp2moAo3HGFlTuxsjONUGhlN42OBcAuQQ6w&s=b6btPKhgvOFr2GOUYvktND6kaC6jc3fXI-mXfvNgXOU&e=
On 9/2
I applied the patch to dpdk_merge here
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_darball_ovs_commits_dpdk-5Fmerge&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=A2_FCacqbp2moAo3HGFlTuxsjONUGhlN42OBcAuQQ6w&s=b6btPKhgvOFr2GOUYvktND6kaC6jc3fXI-mXfvNgXOU&e=
On 9/2
801 - 900 of 1564 matches
Mail list logo
