Instead of casting time_t to uint32_t for the 0x comparison,
define a TIME_T_MAX and use it for both setting and comparison.
Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build system.")
Signed-off-by: Eelco Chaudron
--
Note that this checkpatch repor
data structures to use uint32_t variables.
Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build system.")
Signed-off-by: Eelco Chaudron
---
lib/sflow_api.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/sflow_api.h b/lib/sflow_a
he build system.")
Signed-off-by: Eelco Chaudron
---
lib/sflow_poller.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/sflow_poller.c b/lib/sflow_poller.c
index 9e6a487bc..46e40cbd4 100644
--- a/lib/sflow_poller.c
+++ b/lib/sflow_poller.c
@@ -6,6 +6,7 @@
*/
#
quot;)
Signed-off-by: Eelco Chaudron
---
lib/cfm.c | 2 +-
lib/netdev-linux.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/cfm.c b/lib/cfm.c
index c3742f3de..7eb080157 100644
--- a/lib/cfm.c
+++ b/lib/cfm.c
@@ -863,7 +863,7 @@ cfm_process_heartbeat(struct cf
gt; This commit also adds a unit test to fuzz test the actions
> autovalidator.
>
> Signed-off-by: Emma Finn
> Reported-by: Eelco Chaudron
> ---
> lib/odp-execute-avx512.c | 5 +
> tests/dpif-netdev.at | 26 ++
> 2 files changed, 31 inserti
On 22 May 2024, at 0:11, Ilya Maximets wrote:
> On 5/16/24 19:03, Adrian Moreno wrote:
>>
>>
>> On 4/24/24 9:53 PM, Adrian Moreno wrote:
>>> This is the userspace counterpart of the work being done in the kernel
>>> [1]. Sending it as RFC to get some early feedback on the overall
>>> solution.
>
On 21 May 2024, at 17:47, Simon Horman wrote:
> On Tue, May 21, 2024 at 08:35:21AM +0200, Eelco Chaudron wrote:
>>
>>
>> On 20 May 2024, at 20:13, Simon Horman wrote:
>>
>>> From: Ville Skyttä
>>>
>>> Fix CONFIG_HAVE_EBPF_JIT Kconfig o
On 16 May 2024, at 14:46, Ilya Maximets wrote:
> On 5/14/24 15:15, Eelco Chaudron wrote:
>> The flow_reval_monitor.py script incorrectly reported the reasons for
>> FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped.
>> This patch rectifies the order
On 1 May 2024, at 16:54, Mike Pattrick wrote:
> Currently a bridge mirror will collect all packets and tools like
> ovs-tcpdump can apply additional filters after they have already been
> duplicated by vswitchd. This can result in inefficient collection.
>
> This patch adds support to apply pre-
On 21 May 2024, at 0:03, Ilya Maximets wrote:
> On 5/1/24 14:33, Eelco Chaudron wrote:
>>
>>
>> On 29 Apr 2024, at 14:59, Ilya Maximets wrote:
>>
>>> On 4/16/24 09:44, Eelco Chaudron wrote:
>>>> This patch adds a daily Coverity run for the OVS ma
owse/FDP-164
> Fixes: 58264848a5a7 ("openvswitch: Add vxlan tunneling support.")
> Signed-off-by: Aaron Conole
Thanks for the additional comments and detailed commit message. The change
looks good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
a88 ("odp: Add SRv6 tunnel actions.")
> Fixes: 03fc1ad78521 ("userspace: Add SRv6 tunnel support.")
> Signed-off-by: Ilya Maximets
Thanks for fixing this, looks good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 20 May 2024, at 17:39, Simon Horman wrote:
> Add Jun Gu to AUTHORS file.
>
> Signed-off-by: Simon Horman
Looks good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/lis
On 20 May 2024, at 17:39, Simon Horman wrote:
> From: Jun Gu
>
> Correct spelling of destination in ovs-ctl.in.
>
> Signed-off-by: Jun Gu
> Signed-off-by: Simon Horman
> ---
Looks good to me.
Acked-by: Eelco Chaudron
_
On 20 May 2024, at 20:13, Simon Horman wrote:
> Add Ville Skyttä to AUTHORS file.
>
> Signed-off-by: Simon Horman
Looks good.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
oling?
The rest looks good.
Acked-by: Eelco Chaudron
> Signed-off-by: Simon Horman
> ---
> Documentation/intro/install/afxdp.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/intro/install/afxdp.rst
> b/Documentation/intro/install/
below 3.8.
>
> Even though 'packaging' is a common dependency, added to the test
> requirements so it will not be missed in CI.
>
> Signed-off-by: Ilya Maximets
Thanks for fixing this. The changes look good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
on: Introduce unit tests.")
> Signed-off-by: Ilya Maximets
Thanks for fixing this. The changes looks good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
s our macros already check to make sure the function parameter
> is the correct size.
>
> So that check is disabled in the single function that is causing all of
> the errors.
>
> Signed-off-by: Mike Pattrick
Thanks for fixing the naming.
Acked-by: Eelco Chaudron
_
On 1 May 2024, at 16:54, Mike Pattrick wrote:
> Currently a bridge mirror will collect all packets and tools like
> ovs-tcpdump can apply additional filters after they have already been
> duplicated by vswitchd. This can result in inefficient collection.
>
> This patch adds support to apply pre
ttrick
> Acked-by: Simon Horman
> Acked-by: Eelco Chaudron
> Signed-off-by: Mike Pattrick
> ---
Even with the additional changes this patch looks good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://m
gt; This commit also adds a unit test to fuzz test the actions
> autovalidator.
>
> Signed-off-by: Emma Finn
> Reported-by: Eelco Chaudron
Hi Emma,
Thanks for also fixing the IPv6 case, however, the test you added does not seem
to catch the issue. See notes below.
Cheers,
Eelc
)
> #10 0xaeb50110 in __libc_start_main (/usr/lib64/libc.so.6+
> 0x2b110)
> #11 0x40906c in _start (/usr/local/bin/ovsdb-client+0x40906c)
>
> Fixes: cb139fa8b3a1 ("table: New function table_format() for formatting a
> table as a string.")
> Signed
On 13 May 2024, at 17:02, Ilya Maximets wrote:
> On 5/8/24 11:19, Eelco Chaudron wrote:
>> The flow_reval_monitor.py script incorrectly reported the reasons for
>> FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped.
>> This patch rectifies the order using
script, with the comments in the code.
Fixes: 86b9e653ef22 ("revalidator: Add a USDT probe during flow deletion with
purge reason.")
Signed-off-by: Eelco Chaudron
---
v3: - Renamed ofproto dpif to bridge in delete reasons.
- Added comment pointing back to delete reasons in .c.
v2: -
On 14 May 2024, at 14:50, Ilya Maximets wrote:
> On 5/14/24 14:43, Eelco Chaudron wrote:
>>
>>
>> On 14 May 2024, at 14:28, Ilya Maximets wrote:
>>
>>> On 5/14/24 13:27, Eelco Chaudron wrote:
>>>>
>>>>
>>>> On 14 May
On 14 May 2024, at 14:28, Ilya Maximets wrote:
> On 5/14/24 13:27, Eelco Chaudron wrote:
>>
>>
>> On 14 May 2024, at 13:05, Ilya Maximets wrote:
>>
>>> On 5/14/24 12:14, Adrian Moreno wrote:
>>>>
>>>>
>>>> On 5/14/24 11
On 14 May 2024, at 13:05, Ilya Maximets wrote:
> On 5/14/24 12:14, Adrian Moreno wrote:
>>
>>
>> On 5/14/24 11:09 AM, Ilya Maximets wrote:
>>> On 5/14/24 09:39, Adrian Moreno wrote:
>>>>
>>>>
>>>> On 5/10/24 12:45 PM, Adrian M
On 13 May 2024, at 21:59, Adrian Moreno wrote:
> On 5/13/24 2:38 PM, Adrian Moreno wrote:
>>
>>
>> On 5/13/24 1:32 PM, Eelco Chaudron wrote:
>>>
>>>
>>> On 13 May 2024, at 10:44, Adrian Moreno wrote:
>>>
>>>> On 5/10/24 1
On 13 May 2024, at 14:44, Adrian Moreno wrote:
> On 5/13/24 2:38 PM, Ilya Maximets wrote:
>> On 5/13/24 09:17, Eelco Chaudron wrote:
>>>
>>>
>>> On 10 May 2024, at 15:06, Ilya Maximets wrote:
>>>
>>>> On 5/10/24 14:01, Eelco Chaudron
On 13 May 2024, at 14:50, Adrian Moreno wrote:
> On 5/13/24 2:48 PM, Ilya Maximets wrote:
>> On 5/13/24 13:10, Adrian Moreno wrote:
>>>
>>>
>>> On 5/13/24 12:44 PM, Eelco Chaudron wrote:
>>>>
>>>>
>>>> On 13 May 2024, at 9
On 13 May 2024, at 10:44, Adrian Moreno wrote:
> On 5/10/24 12:06 PM, Eelco Chaudron wrote:
>> On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
>>
>>> Offload the sample action if it contains psample information by creating
>>> a tc "sample" action with
On 13 May 2024, at 9:01, Adrian Moreno wrote:
> On 5/10/24 12:06 PM, Eelco Chaudron wrote:
>> On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
>>
>>> This simple program reads from psample and prints the packets to stdout.
>>> It's useful for quickly coll
On 10 May 2024, at 13:15, Adrian Moreno wrote:
> On 5/10/24 12:06 PM, Eelco Chaudron wrote:
>> On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
>>
>>> When a OFP_SAMPLE action is xlated and a dpif_psample object has been
>>> configured (via Flow_Sample_C
On 13 May 2024, at 8:45, Adrian Moreno wrote:
> On 5/10/24 12:06 PM, Eelco Chaudron wrote:
>> On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
>>
>>> Add a new resource in ofproto-dpif and the corresponding API in
>>> ofproto_provider.h to represent and change
On 10 May 2024, at 15:06, Ilya Maximets wrote:
> On 5/10/24 14:01, Eelco Chaudron wrote:
>>
>>
>> On 10 May 2024, at 12:45, Adrian Moreno wrote:
>>
>>> On 5/10/24 12:06 PM, Eelco Chaudron wrote:
>>>> On 24 Apr 2024, at 21:53, Adrian Moreno wrote
On 10 May 2024, at 12:45, Adrian Moreno wrote:
> On 5/10/24 12:06 PM, Eelco Chaudron wrote:
>> On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
>>
>>> The new odp sample attributes allow userspace to specify a group_id and
>>> user-defined cookie to be passed dow
s.
>
> Fixes: 92eb03f7b03a ("odp-execute: Add ISA implementation of set_masked IPv4
> action")
> Signed-off-by: Emma Finn
> Reported-by: Eelco Chaudron
Hi Emma,
Thanks for fixing this, however, it looks like the same issue also exists in
IPv6.
In addition, can you also a
On 7 May 2024, at 16:30, Adrian Moreno wrote:
> Add a man page for ovs-flowviz as well as a topic page with some more
> detailed examples.
>
> Signed-off-by: Adrian Moreno
Thanks for making the changes, they look good to me.
Acked-by: Ee
On 10 May 2024, at 10:23, Adrian Moreno wrote:
> On 5/10/24 9:14 AM, Eelco Chaudron wrote:
>>
>>
>> On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
>>
>>> This is the userspace counterpart of the work being done in the kernel
>>> [1]. Sending it as
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
Maybe add a small description to this patch.
> Signed-off-by: Adrian Moreno
> ---
> ofproto/ofproto-dpif-psample.c | 59 ++
> ofproto/ofproto-dpif-psample.h | 1 +
> ofproto/ofproto-dpif.c | 1 +
> 3 files
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> In preparation to allowing certain actions to have a cookie that does
> not represent the entire flow, rename flower->act_cookie to
> flower->flow_cookie.
>
> This patch does not introduce any behavioral change, it's just a
> variable renaming.
Sma
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> Add a psample_group field to the Flow Sample Collector Set table and use
> it to configure the psample ofproto layer.
See comments below,
Eelco
> Signed-off-by: Adrian Moreno
> ---
> vswitchd/bridge.c | 54 +
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> Add a new resource in ofproto-dpif and the corresponding API in
> ofproto_provider.h to represent and change psample configuration.
See comments below.
//Eelco
> Signed-off-by: Adrian Moreno
> ---
> ofproto/automake.mk| 2 +
> ofp
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> This simple program reads from psample and prints the packets to stdout.
> It's useful for quickly collecting sampled packets.
See some comments below, did not review the actual sample application in detail.
//Eelco
> Signed-off-by: Adrian Moreno
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> Only kernel datapath supports psample so check that the datapath is not
> userspace and that it accepts the new attributes.
>
> Signed-off-by: Adrian Moreno
> ---
> ofproto/ofproto-dpif.c | 59 ++
> ofproto/
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> The new odp sample attributes allow userspace to specify a group_id and
> user-defined cookie to be passed down to psample.
>
> Add support for parsing and formatting such action.
>
> Signed-off-by: Adrian Moreno
Hi Adrian,
See my comments below
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> When a OFP_SAMPLE action is xlated and a dpif_psample object has been
> configured (via Flow_Sample_Collector_Set table) with the same
> collector_set_id, add psample information to the odp sample action.
See comments below.
//Eelco
> Signed-off-
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> Signed-off-by: Adrian Moreno
> ---
> tests/system-common-macros.at| 4 +++
> tests/system-offloads-traffic.at | 53
> 2 files changed, 57 insertions(+)
>
> diff --git a/tests/system-common-macros.at b/tests/sy
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> Offload the sample action if it contains psample information by creating
> a tc "sample" action with the user cookie inside the action's cookie.
>
> Avoid using the "sample" action's cookie to store the ufid.
I have some concerns about the sample a
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> Add a cache entry type for psample objects.
> Store both the dpif_psample reference and the collector_set_id so we can
> quickly find the particular exporter.
>
> Using that mechanism, account for packet and byte statistics.
See comments inline.
/
On 24 Apr 2024, at 21:53, Adrian Moreno wrote:
> This is the userspace counterpart of the work being done in the kernel
> [1]. Sending it as RFC to get some early feedback on the overall
> solution.
>
> ** Problem description **
> Currently, OVS supports several observability features, such as
>
On 9 May 2024, at 15:25, Simon Horman wrote:
> On Wed, May 08, 2024 at 11:19:56AM +0200, Eelco Chaudron wrote:
>> The flow_reval_monitor.py script incorrectly reported the reasons for
>> FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped.
>> This patc
ady parsed.
>
> Fixes: 9dd7f8907c37 ("openvswitch: Add original direction conntrack tuple to
> sw_flow_key.")
> Reported-by: Antonin Bas
> Closes: https://github.com/openvswitch/ovs-issues/issues/327
> Signed-off-by: Ilya Maximets
This patch looks good to me.
Acked-by: Ee
On 7 May 2024, at 16:18, Adrian Moreno wrote:
> On 5/3/24 11:43 AM, Eelco Chaudron wrote:
>>
>>
>> On 24 Apr 2024, at 15:50, Adrian Moreno wrote:
>>
>>> Add support for psample sampling via two new attributes to the
>>> OVS_ACTION_ATTR_SAMPLE actio
script, with the comments in the code.
Fixes: 86b9e653ef22 ("revalidator: Add a USDT probe during flow deletion with
purge reason.")
Signed-off-by: Eelco Chaudron
---
v2: - Converted the list of strings to dictionary.
- Added comment to code to keep code and script in sync.
T14:50:17.0770596Z WARNING: Running the setup command as
> `meson [options]` instead of `meson setup [options]` is ambiguous
> and deprecated.
>
> Link: https://git.dpdk.org/dpdk/commit/?id=bf66003b51ec
> Signed-off-by: David Marchand
Thanks, the change looks good to me.
Acked-b
needs to prevent these packets from being processed through TC.
Signed-off-by: Eelco Chaudron
---
v2: - Fixed and added some comments.
- Use ovs-pcap to compare packets.
NOTE: This patch needs an AVX512 fix before it can be applied.
Intel is working on this.
---
lib/netdev-offload-tc.c
On 2 May 2024, at 14:46, Ilya Maximets wrote:
> On 4/29/24 16:48, Eelco Chaudron wrote:
>> While offloading header modifications to TC, OVS is using {TCA_PEDIT} +
>> {TCA_CSUM} combination as that it the only way to represent header
>> rewrite. However, {TCA_CSUM} is u
On 24 Apr 2024, at 15:50, Adrian Moreno wrote:
> Add support for psample sampling via two new attributes to the
> OVS_ACTION_ATTR_SAMPLE action.
>
> OVS_SAMPLE_ATTR_PSAMPLE_GROUP used to pass an integer psample group_id.
> OVS_SAMPLE_ATTR_PSAMPLE_COOKIE used to pass a variable-length binary
> co
)
> [1280, 1344) 'action_set' (line 4762)
>
> SUMMARY: AddressSanitizer: stack-use-after-return
>ofproto/ofproto-dpif-trace.c:704:49 in ofproto_trace_recirc_node
>
> Fix that by copying the action.
>
> Fixes: d072d2de011b ("ofproto-dpif-trace: Improve
lvm-project/issues/90848
> Fixes: db5a101931c5 ("clang: Fix the alignment warning.")
> Signed-off-by: Ales Musil
> ---
> v3: Do partial revert of db5a101931c5 instead of simple cast.
Looks good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 2 May 2024, at 16:48, Finn, Emma wrote:
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Thursday, May 2, 2024 8:14 AM
>> To: Finn, Emma
>> Cc: Simon Horman ; Stokes, Ian ;
>> Van Haaren, Harry ; d...@openvswitch.org;
>> Flavio Lei
The flow_reval_monitor.py script incorrectly reported the reasons for
FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped.
This patch rectifies the order.
Fixes: 86b9e653ef22 ("revalidator: Add a USDT probe during flow deletion with
purge reason.")
Signed-off-by: Eelc
On 1 May 2024, at 15:36, Finn, Emma wrote:
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Wednesday, May 1, 2024 1:52 PM
>> To: Simon Horman
>> Cc: Finn, Emma ; Stokes, Ian ;
>> sunil.pa...@intel.com; Van Haaren, Harry ;
>> d...@openv
On 1 May 2024, at 14:39, Simon Horman wrote:
> On Tue, Apr 30, 2024 at 02:42:45PM +0200, Eelco Chaudron wrote:
>> Greetings, Intel team!
>>
>> The self-test conducted as part of this patch has revealed an issue with the
>> AVX512 checksumming code. Since it was agree
On 29 Apr 2024, at 14:59, Ilya Maximets wrote:
> On 4/16/24 09:44, Eelco Chaudron wrote:
>> This patch adds a daily Coverity run for the OVS main branch
>> to the GitHub actions. The result of the runs can be found here:
>>
>> https://scan.coverity.com/projec
On 26 Apr 2024, at 10:57, Simon Horman wrote:
> On Tue, Apr 16, 2024 at 09:44:52AM +0200, Eelco Chaudron wrote:
>> This patch adds a daily Coverity run for the OVS main branch
>> to the GitHub actions. The result of the runs can be found here:
>>
>> https:/
On 1 May 2024, at 12:54, Simon Horman wrote:
> Update link to pacemaker main page as the existing link is broken.
> Also, use HTTPS.
>
> Broken link flagged by make check-docs
>
> Signed-off-by: Simon Horman
> ---
Thanks for fixing the link.
Ack
On 5 Apr 2024, at 12:14, Ilya Maximets wrote:
> On 1/11/24 00:08, Eelco Chaudron wrote:
>> This patch identifies new static analysis issues during a GitHub action
>> run and reports them. The process involves analyzing the changes introduced
>> in the current commit and co
can be found in this mail link:
https://mail.openvswitch.org/pipermail/ovs-build/2024-April/038590.html
Cheers,
Eelco
On 29 Apr 2024, at 16:48, Eelco Chaudron wrote:
> While offloading header modifications to TC, OVS is using {TCA_PEDIT} +
> {TCA_CSUM} combination as that it the only
, AFAIK.
>>
>> Signed-off-by: Ilya Maximets
>> ---
>
> Hi, Eelco and Simon. May I ask you to take a look at this patch?
>
> It's blocking Cirrus CI and I don't think anything else should be
> merged until CI is fixed.
>
> Best regards, Ilya Maximets.
needs to prevent these packets from being processed through TC.
Signed-off-by: Eelco Chaudron
---
lib/netdev-offload-tc.c | 32 +
tests/system-traffic.at | 62 +
2 files changed, 94 insertions(+)
diff --git a/lib/netdev-offload-tc.c b/lib
On 27 Apr 2024, at 11:00, wushao...@chinatelecom.cn wrote:
> From: Shaohua Wu
>
> In scenarios with multiple PMDs, there may be
> simultaneous requests for recirc_id from multiple
> PMD threads.In recirc_alloc_id_ctx, we first check
> if there is a duplicate entry in the metadata_map
> for the
nks Jun for the follow-up! The change looks good to me!
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
s not one of its aliases to prevent
unnecessary creation and destruction of the vport by ovs-vswitchd.
Maybe the maintainers are fine with the current text, in that case:
Acked-by: Eelco Chaudron
>
> Signed-off-by: Jun Gu
> ---
> net/openvswitch/vport-netdev.c | 5 -
> 1 fi
On 16 Apr 2024, at 11:20, jun.gu wrote:
> Check vport net device name to avoid the name that be used to query is
> inconsistent the retured name.
>
> Consider net device supports alias, the alias can be set to interface
> table in ovs userspace. Consider the following process:
> - set a net devi
u are right,
OVS userspace does not support using interface aliases.
Maybe you can update the commit message, and add a code comment to clarify this
in your next revision?
Cheers,
Eelco
> 在 4/15/24 18:04, Eelco Chaudron 写道:
>>
>> On 13 Apr 2024, at 10:48, jun.gu wrote:
>>
&
:
- COVERITY_SCAN_TOKEN; The secret token from the project page
- COVERITY_SCAN_EMAIL; The maintainer's email alias
Signed-off-by: Eelco Chaudron
---
.github/workflows/coverity.yml | 131 +
Makefile.am| 1 +
README.rst | 2 +
3 files ch
On 13 Apr 2024, at 10:48, jun.gu wrote:
> Check vport name from dev_get_by_name, this can avoid to add and remove
> NIC repeatedly when NIC rename failed at system startup.
>
> Signed-off-by: Jun Gu
> ---
> net/openvswitch/vport-netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
cked 10939 ms
>>> waiting for pmd-c03/id:8 to quiesce
>>> 2024-04-03T03:42:39.083Z|00151|ovs_rcu(urcu2)|WARN|blocked 19318 ms
>>> waiting for pmd-c03/id:8 to quiesce
>>> 2024-04-03T03:42:52.928Z|00155|ovs_rcu(urcu2)|WARN|blocked 33164 ms
>>> waitin
gt; Signed-off-by: Ilya Maximets
Thanks for fixing this! AppVeyor is working again with this patch applied!
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 9 Apr 2024, at 9:06, Adrian Moreno wrote:
> Add a man page for ovs-flowviz as well as a topic page with some more
> detailed examples.
>
> Signed-off-by: Adrian Moreno
In addition to Ilya’s comments, find 3 small comments below. The rest looks
good.
Cheers,
Eelco
> ---
> Documentation/
lows br-int | ovs-flowviz openflow console -h
>
> [1] https://rich.readthedocs.io/en/stable/introduction.html
>
> Signed-off-by: Adrian Moreno
Thanks for moving the dot around ;)
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 10 Apr 2024, at 16:09, Simon Horman wrote:
> The OvS primary development branch has been renamed main
> so there is no longer any need for this CI configuration
> to refer to master.
>
> Signed-off-by: Simon Horman
Thanks for following through with the main branch change.
On 10 Apr 2024, at 16:09, Simon Horman wrote:
> The OvS primary development branch has been renamed main
> so there is no longer any need for this CI configuration
> to refer to master.
>
> Signed-off-by: Simon Horman
Thanks for following through with the main branch change.
llows even though the patch does add the file to
> RST_MANPAGES:
>
> """
> WARNING: New doc ovs-flowviz.8.rst not listed in
> Documentation/automake.mk
> """
>
> Fix it by making the {dir}/ part of the docre regexp optional.
>
> S
On 10 Apr 2024, at 12:49, Ilya Maximets wrote:
> On 4/10/24 12:44, Eelco Chaudron wrote:
>>
>>
>> On 10 Apr 2024, at 12:09, Kevin Traynor wrote:
>>
>>> On 10/04/2024 11:04, Kevin Traynor wrote:
>>>> On 10/04/2024 10:51, Eelco Chaudron wrote:
On 10 Apr 2024, at 12:09, Kevin Traynor wrote:
> On 10/04/2024 11:04, Kevin Traynor wrote:
>> On 10/04/2024 10:51, Eelco Chaudron wrote:
>>>
>>>
>>> On 10 Apr 2024, at 11:41, Ilya Maximets wrote:
>>>
>>>> 13.3 was released on
On 10 Apr 2024, at 11:41, Ilya Maximets wrote:
> 13.3 was released on March 5 and 13.2 will reach EoL in June.
> Update now.
Changing from 13.2 to 13.3 looks fine to me. Assume you ran it trough GitHub
actions;
Acked-by: Eelco Chaudron
//Eelco
> Signed-off-by: Ilya
lchecker and
> need to be excluded.
>
> Signed-off-by: Ilya Maximets
Thanks for the enhancement.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
set Open_vSwitch . other_config:max-revalidator=1000’. I would
personally not go over 1seconds, as it affects the statists shown in dump-flows.
Good luck,
Eelco
> Thanks, Shahaji
>
>
> On Thu, Mar 28, 2024 at 1:54 PM Eelco Chaudron wrote:
>
>>
>>
>> On 28 Mar
On 2 Apr 2024, at 19:46, Simon Horman wrote:
> On Tue, Apr 02, 2024 at 03:21:16PM +0200, Eelco Chaudron wrote:
>> This patch add another set of keywords based on the results
>> of the last thousand committed patches.
>>
>> Signed-off-by: Eelco Chaudron
>
> Acke
u2)|WARN|blocked 173540 ms
> waiting for pmd-c03/id:8 to quiesce
> 2024-04-03T03:47:58.186Z|00158|ovs_rcu(urcu2)|WARN|blocked 338421 ms
> waiting for pmd-c03/id:8 to quiesce
>
>
> Not sure if this is related to the core issue.
I’ll guess it’s the opposite. If we do not go through
e.")
> [2] https://inclusivenaming.org/word-lists/
>
> Signed-off-by: Simon Horman
Thanks this revision looks good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5 Apr 2024, at 15:43, Ilya Maximets wrote:
> On 4/5/24 15:08, Ilya Maximets wrote:
>> On 4/5/24 15:01, Eric Garver wrote:
>>> On Fri, Apr 05, 2024 at 11:39:58AM +0200, Eelco Chaudron wrote:
>>>>
>>>>
>>>> On 3 Apr 2024, at 16:35, Eric
On 5 Apr 2024, at 15:04, Ilya Maximets wrote:
> On 4/5/24 14:33, Eelco Chaudron wrote:
>>
>>
>> On 4 Apr 2024, at 14:09, Ilya Maximets wrote:
>>
>>> ukey_install() returns boolean signaling if the ukey was installed
>>> or not. Installation may fa
b() error.")
> Signed-off-by: Ilya Maximets
> ---
Thanks for looking into this, and the patch looks good to me.
Maybe we should have another patch fixing some of the namings?
upcall_ukey_replace -> ukey_replace
handler_duplicate_upcall -> dup
On 2 Apr 2024, at 16:44, Simon Horman wrote:
> Recently OVS adopted a policy of using the inclusive naming word list v1
> [1, 2].
>
> In keeping with this policy rename the primary development branch from
> 'master' to 'main'. This patch does not actually make that change,
> but rather updates
On 3 Apr 2024, at 16:35, Eric Garver wrote:
> Kernel support has been added for this action. As such, we need to probe
> the datapath for support.
>
> Signed-off-by: Eric Garver
> ---
> include/linux/openvswitch.h | 2 +-
> lib/dpif.c | 6 ++-
> lib/dpif.h
301 - 400 of 1221 matches
Mail list logo
