This series fixes some of Clang's scan-build warnings reported.
v2:
- Split patch two into two, i.e. put the actual fix in a separate patch.
- Updated commit messages.
Eelco Chaudron (5):
general: Fix Clang's static analyzer 'Dead initialization' warnings.
general: Fix Clang's
ries was all about this
new helper ;)
I’ll leave the other two patches for the CT fooks...
Cheers,
Eelco
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 20 Oct 2023, at 12:43, jm...@redhat.com wrote:
> From: Jakob Meng
>
> This patch follows an alternative approach to RFC [0].
>
> For monitoring systems such as Prometheus it would be beneficial if OVS
> and OVS-DPDK would expose statistics in a machine-readable format.
> Several approaches
On 19 Oct 2023, at 17:29, Mike Pattrick wrote:
> On Thu, Oct 19, 2023 at 9:00 AM Eelco Chaudron wrote:
>>
>>
>>
>> On 19 Oct 2023, at 4:37, Mike Pattrick wrote:
>>
>>> Currently a bond will not always revalidate when an active member
>>> chan
0 00
> 03d0 00 00 00 00 ff ff ff ff-
>
> Without the change, each action would be a 1900+ characters
> long string of mostly zeroes.
>
> Signed-off-by: Ilya Maximets
Changes look good to me!
Acked-by: Eelco Chaudron
___
dev ma
On 19 Oct 2023, at 15:00, Eelco Chaudron wrote:
> On 19 Oct 2023, at 4:37, Mike Pattrick wrote:
>
>> Currently a bond will not always revalidate when an active member
>> changes. This can result in counter-intuitive behaviors like the fact
>> that using ovs-appct
id:70102d81-30a1-44b9-aa76-3d02a9ffd2c9
>
> To avoid evaluating already deleted flows, the second part of the fix is
> to ensure that dumping from the leader revalidator thread is done out of
> any pause request.
>
> As a result of this patch, the unit test "offloads - delete
On 19 Oct 2023, at 4:37, Mike Pattrick wrote:
> Currently a bond will not always revalidate when an active member
> changes. This can result in counter-intuitive behaviors like the fact
> that using ovs-appctl bond/set-active-member will cause the bond to
> revalidate but changing
On 19 Oct 2023, at 4:35, Mike Pattrick wrote:
> On Fri, Oct 13, 2023 at 4:28 AM Eelco Chaudron wrote:
>>
>>
>>
>> On 8 Oct 2023, at 7:26, Mike Pattrick wrote:
>>
>>> Currently a bond will not always revalidate when an active member
>>> chan
On 18 Oct 2023, at 13:42, Ilya Maximets wrote:
> On 10/17/23 15:49, Eelco Chaudron wrote:
>> This patch fixes two 'Dead assignment' warnings, where the one in
>> count_common_prefix_run() is actually a bug where the set is in reverse
>> order.
>>
>&
On 18 Oct 2023, at 13:02, Simon Horman wrote:
> On Tue, Oct 17, 2023 at 03:49:55PM +0200, Eelco Chaudron wrote:
>
> Hi Eelco,
>
> As per my commoent on patch 3/4.
> I think it would be good to be clear about if these are bugs or not.
Dont think this will happen in real l
On 18 Oct 2023, at 12:56, Simon Horman wrote:
> On Tue, Oct 17, 2023 at 03:49:48PM +0200, Eelco Chaudron wrote:
>> Rather than crashing when a mod_double is requested, return
>> `Operation not supported`.
>>
>> Signed-off-by: Eelco Chaudron
>
> Hi Eelco,
>
On 18 Oct 2023, at 12:50, Simon Horman wrote:
> On Tue, Oct 17, 2023 at 03:49:41PM +0200, Eelco Chaudron wrote:
>> This patch fixes two 'Dead assignment' warnings, where the one in
>> count_common_prefix_run() is actually a bug where the set is in reverse
>> order.
>
On 18 Oct 2023, at 12:46, Simon Horman wrote:
> On Wed, Oct 18, 2023 at 12:39:51PM +0200, Simon Horman wrote:
>> On Tue, Oct 17, 2023 at 03:49:31PM +0200, Eelco Chaudron wrote:
>>> Signed-off-by: Eelco Chaudron
>>> ---
>>> lib/meta-flow.c |
Signed-off-by: Eelco Chaudron
---
lib/dpif-netdev.c |4
tests/test-id-fpool.c |2 +-
tests/test-mpsc-queue.c |2 +-
3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 157694bcf..b8f065d1d 100644
--- a/lib/dpif
This patch fixes two 'Dead assignment' warnings, where the one in
count_common_prefix_run() is actually a bug where the set is in reverse order.
Signed-off-by: Eelco Chaudron
---
lib/ofp-monitor.c |5 ++---
lib/ofp-table.c |2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
diff
Rather than crashing when a mod_double is requested, return
`Operation not supported`.
Signed-off-by: Eelco Chaudron
---
ovsdb/mutation.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/ovsdb/mutation.c b/ovsdb/mutation.c
index cbc71bc49..794560019 100644
This series fixes some of Clang's scan-build warnings reported.
Eelco Chaudron (4):
general: Fix Clang's static analyzer 'Dead initialization' warnings.
general: Fix Clang's static analyzer 'Dead assignment' warnings.
ovsdb: Fix Clang's static analyzer 'func null dereference
Signed-off-by: Eelco Chaudron
---
lib/meta-flow.c |4 ++--
lib/ofp-actions.c |8 +---
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/lib/meta-flow.c b/lib/meta-flow.c
index 474344194..aa7cf1fcb 100644
--- a/lib/meta-flow.c
+++ b/lib/meta-flow.c
@@ -2751,8 +2751,8
On 17 Oct 2023, at 15:34, Ilya Maximets wrote:
> On 10/17/23 15:24, Eelco Chaudron wrote:
>>
>>
>> On 17 Oct 2023, at 14:16, Ilya Maximets wrote:
>>
>>> First stable release for OVS 3.2, 2 months after the initial release.
>>>
>>&g
> configure.ac | 2 +-
> debian/changelog | 8 +++-
> 3 files changed, 13 insertions(+), 3 deletions(-)
Ack for the series:
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> configure.ac | 2 +-
> debian/changelog | 8 +++-
> 3 files changed, 13 insertions(+), 3 deletions(-)
Ack for the series:
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
6 +-
> configure.ac | 2 +-
> debian/changelog | 8 +++-
> 3 files changed, 13 insertions(+), 3 deletions(-)
Ack for the series:
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
changelog | 8 +++-
> 3 files changed, 13 insertions(+), 3 deletions(-)
Ack for the series:
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 16 Oct 2023, at 14:24, Eelco Chaudron wrote:
> On 16 Oct 2023, at 14:22, David Marchand wrote:
>
>> On Fri, Oct 13, 2023 at 11:49 AM Eelco Chaudron wrote:
>>>> The check-offloads target can run fine if removing the exception on
>>>> "failed to flow_
On 16 Oct 2023, at 14:22, David Marchand wrote:
> On Fri, Oct 13, 2023 at 11:49 AM Eelco Chaudron wrote:
>>> The check-offloads target can run fine if removing the exception on
>>> "failed to flow_get" and "failed to acquire ukey" warning logs.
&g
On 16 Oct 2023, at 12:52, Roi Dayan wrote:
> On 16/10/2023 11:31, Eelco Chaudron wrote:
>>
>>
>> On 16 Oct 2023, at 10:07, Roi Dayan wrote:
>>
>>> On 16/10/2023 11:00, Roi Dayan wrote:
>>>>
>>>> On 16/10/2023 10:42, Eelco Chaudron
On 16 Oct 2023, at 10:07, Roi Dayan wrote:
> On 16/10/2023 11:00, Roi Dayan wrote:
>>
>> On 16/10/2023 10:42, Eelco Chaudron wrote:
>>>
>>>
>>> On 16 Oct 2023, at 9:09, Roi Dayan wrote:
>>>
>>>> On 09/10/2023 15:05, Roi Dayan wrot
a part of set_tunnel
>> which doesn't reset mirror.
>>
>> Fixes: feed7f677505 ("ofproto-dpif-upcall: Mirror packets that are
>> modified.")
>> Signed-off-by: Roi Dayan
>> Acked-by: Simon Horman
>> Acked-by: Eelco Chaudron
>> ---
>>
>
On 9 Oct 2023, at 14:05, Roi Dayan wrote:
> Hi,
>
> The first commit removing the redundant mirror when using tunnel options.
> The second is a test to verify it stays like this and doesn't break again.
> The third commit is just updating prefixes of tests to match the file their
> in.
>
>
On 13 Oct 2023, at 8:49, Eelco Chaudron wrote:
> On 7 Oct 2023, at 10:37, James Raphael Tiovalen wrote:
>
>> This commit adds a non-exhaustive list of tests for some of the
>> functions declared in `lib/byteq`.
>>
>> These unit tests have been executed via `make c
On 13 Oct 2023, at 9:27, Eelco Chaudron wrote:
> On 7 Oct 2023, at 5:49, Faicker Mo wrote:
>
>> When the IP header is modified, for example, by NAT or a ToS/TTL change,
>> the IP header checksum needs recalculation. In addition to the IP header
>> checksum, for UDPLITE,
ails for
> me though it predates this patch, and I did not understand why it fails
> yet.
I’m not getting this error in my test environment. I tested all datapaths and
did not get any errors.
> The check-offloads target can run fine if removing the exception on
> "failed to flow_get&q
On 8 Oct 2023, at 7:26, Mike Pattrick wrote:
> Currently a bond will not always revalidate when an active member
> changes. This can result in counter-intuitive behaviors like the fact
> that using ovs-appctl bond/set-active-member will cause the bond to
> revalidate but changing
ing warning can be seen in the logging:
> Can't offload rewrite of IP/IPV6 with ip_proto: X.
>
> Fixes: d6118e628988 ("netdev-tc-offloads: Verify csum flags on dump from tc")
> Signed-off-by: Faicker Mo
Thanks for making the changes! The patch looks good
esses change.
>
> This patch adds support for TC offloading of IGMP, UDPLITE, and SCTP
> packets by adding the correct csum action.
>
> Signed-off-by: Faicker Mo
Thanks for making the changes! The patch looks good to me now!
Acked-by: Eelco Chaudron
On 9 Oct 2023, at 14:05, Roi Dayan wrote:
> Test geneve options mirror flow doesn't add redundant mirror.
>
> Signed-off-by: Roi Dayan
Thanks Roi for fixing the unit test.
With this change ACK for the series!
Acked-by: Eelco Chaudron
__
Horman
> Signed-off-by: James Raphael Tiovalen
Hi James,
Thanks for working trough all the revisions and fixing my comments! I think
this patch looks good now.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswi
On 9 Oct 2023, at 13:40, Roi Dayan wrote:
> On 09/10/2023 12:56, Eelco Chaudron wrote:
>>
>>
>> On 8 Oct 2023, at 9:08, Roi Dayan wrote:
>>
>>> On 05/10/2023 15:36, Eelco Chaudron wrote:
>>>>
>>>>
>>>> On 4 Oct 2023, at 12
On 8 Oct 2023, at 9:08, Roi Dayan wrote:
> On 05/10/2023 15:36, Eelco Chaudron wrote:
>>
>>
>> On 4 Oct 2023, at 12:09, Roi Dayan via dev wrote:
>>
>>> Test geneve options mirror flow doesn't add redundant mirror.
>>>
>>> Signed-off-by: R
On 5 Oct 2023, at 16:28, James Raphael Tiovalen wrote:
> This commit adds a non-exhaustive list of tests for some of the
> functions declared in `lib/byteq`.
>
> These unit tests have been executed via `make check` and they
> successfully passed.
>
> Signed-off-by: James Raphael Tiovalen
Hi
On 6 Oct 2023, at 11:29, jm...@redhat.com wrote:
> From: Jakob Meng
>
> Fixes: fc06ea9a1883 ("netdev-dpdk: Add custom rx-steering configuration.")
> Signed-off-by: Jakob Meng
> ---
This looks good to me!
Acked-by: Eelco Chaudron
__
On 6 Oct 2023, at 11:29, jm...@redhat.com wrote:
> From: Jakob Meng
>
> Fixes: f4336f504b17 ("netdev-dpdk: Add option to configure VF MAC address. ")
> Signed-off-by: Jakob Meng
> ---
This looks good to me!
Acked-by: Eelco Chaudron
> vswitchd/vswitch.xml |
On 6 Oct 2023, at 11:10, Jakob Meng wrote:
On 06.10.23 10:55, Eelco Chaudron wrote:
On 6 Oct 2023, at 9:21, Jakob Meng wrote:
On 05.10.23 17:53, Kevin Traynor wrote:
On 05/10/2023 13:52, Eelco Chaudron wrote:
On 4 Oct 2023, at 10:31, jm...@redhat.com wrote:
From: Jakob Meng
On 6 Oct 2023, at 9:21, Jakob Meng wrote:
> On 05.10.23 17:53, Kevin Traynor wrote:
>> On 05/10/2023 13:52, Eelco Chaudron wrote:
>>> On 4 Oct 2023, at 10:31, jm...@redhat.com wrote:
>>>
>>>> From: Jakob Meng
>>>>
>>>> The
On 4 Oct 2023, at 21:40, Mike Pattrick wrote:
> Currently a bridge mirror will collect all packets and tools like
> ovs-tcpdump can apply additional filters after they have already been
> duplicated by vswitchd. This can result in inefficient collection.
>
> This patch adds support to apply
trick
Hi Mike,
Small nit below, if fixed, please add my ‘Acked-by: Eelco Chaudron
’ in the next rev.
//Eelco
> ---
> ofproto/ofproto-dpif-mirror.c | 61 ++-
> ofproto/ofproto-dpif-mirror.h | 30 -
> ofproto/ofproto-dpif-xlate.c | 2
On 4 Oct 2023, at 10:32, jm...@redhat.com wrote:
> From: Jakob Meng
>
> Fixes: fc06ea9a1883 ("netdev-dpdk: Add custom rx-steering configuration.")
This looks good to me!
Acked-by: Eelco Chaudron
___
dev mailing list
d...@op
On 4 Oct 2023, at 10:31, jm...@redhat.com wrote:
> From: Jakob Meng
>
> The status options pci-vendor_id and pci-device_id for dpdk netdevs
> have been replaced by bus_info. This patch updates the documentation
> in vswitchd/vswitch.xml accordingly.
>
> Fixes: a77c7796f23a ("dpdk: Update to
On 4 Oct 2023, at 10:26, jm...@redhat.com wrote:
> From: Jakob Meng
>
> Fixes: f4336f504b17 ("netdev-dpdk: Add option to configure VF MAC address. ")
Thank for adding/fixing the documentation.
//Eelco
Acked-by: Eelco Chaudron
> ---
> vswitchd/vswitch.xml | 4
On 5 Oct 2023, at 9:51, Simon Horman wrote:
> On Wed, Oct 04, 2023 at 02:59:48PM +0200, Eelco Chaudron wrote:
>> Added a reference to the DPDK documentation as a result of
>> analyzing the OVS code for potential performance impacts due
>> to the Downfall mitigation.
>&
On 4 Oct 2023, at 12:09, Roi Dayan via dev wrote:
> Use test title prefix according to filename the test is in
> for tunnel.at and ofproto-dpif.at.
>
> Signed-off-by: Roi Dayan
Thanks for making this change, looks good to me.
Acked-by: Ee
r.
>
> Fixes: feed7f677505 ("ofproto-dpif-upcall: Mirror packets that are modified.")
> Signed-off-by: Roi Dayan
> Acked-by: Simon Horman
This patch looks good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitc
On 4 Oct 2023, at 12:09, Roi Dayan via dev wrote:
> Test geneve options mirror flow doesn't add redundant mirror.
>
> Signed-off-by: Roi Dayan
In general this patch looks good, some small nit below.
//Eelco
> ---
>
> Notes:
> v2:
> - add dot in title.
>
> tests/tunnel.at | 29
Added a reference to the DPDK documentation as a result of
analyzing the OVS code for potential performance impacts due
to the Downfall mitigation.
Signed-off-by: Eelco Chaudron
---
Documentation/topics/dpdk/bridge.rst |5 +
1 file changed, 5 insertions(+)
diff --git a/Documentation
On 3 Oct 2023, at 18:14, Mike Pattrick wrote:
> On Mon, Oct 2, 2023 at 6:07 AM Simon Horman wrote:
>>
>> On Fri, Sep 08, 2023 at 12:28:24PM -0400, Mike Pattrick wrote:
>>> Currently a bridge mirror will collect all packets and tools like
>>> ovs-tcpdump can apply additional filters after they
On 19 Jun 2023, at 12:18, Chris Mi wrote:
> On 6/19/2023 6:04 PM, Eelco Chaudron wrote:
>>
>> On 19 Jun 2023, at 7:05, Chris Mi wrote:
>>
>>> Add three sFlow offload test cases:
>>>
>>>3: offloads - sflow with sampling=1 - offloads enabl
On 30 Sep 2023, at 10:07, James R T wrote:
> On Thu, Sep 28, 2023 at 8:28 PM Eelco Chaudron wrote:
>>
>> Move stuff in alphabetical order:
>>
>> #include
>> #undef NDEBUG
>> #include
>> #include
>> #include
>> #include
>> #inc
On 29 Sep 2023, at 9:00, Nicholas Piggin wrote:
> On Fri Sep 29, 2023 at 1:26 AM AEST, Aaron Conole wrote:
>> Nicholas Piggin writes:
>>
>>> Dynamically allocating the sw_flow_key reduces stack usage of
>>> ovs_vport_receive from 544 bytes to 64 bytes at the cost of
>>> another GFP_ATOMIC
on initial creation
> of the ofservice, as these config values are available from the
> ofproto_controller struct c.
>
> Signed-off-by: Brad Cowie
> Acked-by: Simon Horman
Thanks Brad, for the quick turnaround and including my comments. This version
looks good to me.
Cheers,
Ee
On 9 Sep 2023, at 10:48, James Raphael Tiovalen wrote:
> This commit adds a non-exhaustive list of tests for some of the
> functions declared in `lib/byteq`.
>
> These unit tests have been executed via `make check` and they
> successfully passed.
>
> Signed-off-by: James Raphael Tiovalen
Hi
have a final version of Ilya’s RFC patch applied.
This is the patch I’m referring to:
https://patchwork.ozlabs.org/project/openvswitch/patch/20230908234009.892803-1-i.maxim...@ovn.org/
//Eelco
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswit
On 28 Sep 2023, at 3:27, Brad Cowie wrote:
> ofconn connection parameters, such as probe_interval and max_backoff,
> are always set to their default values when vswitchd starts up even if
> the user has configured these to be something different in ovsdb:
>
> $ ovs-vsctl set controller UUID
On 27 Sep 2023, at 15:05, Ilya Maximets wrote:
> On 9/27/23 14:34, Roi Dayan wrote:
>>
>> On 18/06/2020 21:17, Roi Dayan wrote:
>>> This is to match a recent kernel checkpatch change that
>>> also increased it to 100 line length.
>>>
>>> Signed-off-by: Roi Dayan
>>> Reviewed-by: Simon Horman
On 26 Sep 2023, at 16:57, Aaron Conole wrote:
> Eelco Chaudron writes:
>
>> This patch adds an utility that can be used to determine if
>> an issue is related to a lack of Linux kernel resources.
>>
>> This tool is also featured in a Red Hat developers
On 25 Sep 2023, at 13:49, Adrian Moreno wrote:
> On 9/12/23 12:36, Eelco Chaudron wrote:
>> This patch adds an utility that can be used to determine if
>> an issue is related to a lack of Linux kernel resources.
>>
>> This tool is also featured in a Red
On 15 Sep 2023, at 6:36, Brad Cowie wrote:
> ofconn connection parameters, such as probe_interval and max_backoff,
> are always set to their default values when vswitchd starts up even if
> the user has configured these to be something different in ovsdb:
>
> $ ovs-vsctl set controller UUID
On 5 Sep 2023, at 12:17, Faicker Mo via dev wrote:
> The warning message is
Hi Faicker, thanks for the patch!
> |1|tc(handler4)|WARN|can't offload rewrite of IP/IPV6 with ip_proto: X.
>
> IPIP and GRE only need the checksum recalculation of the IP header if the
> IP header is rewritten.
>
>
On 5 Sep 2023, at 12:17, Faicker Mo via dev wrote:
> When the IP header is rewritten like NAT or ttl/tos changed,
> the csum of IP header need recalculation. The UDPLITE checksum
> needs recalculation if src or dst changed in IP header.
> The tc-csum action is for this.
>
> Signed-off-by:
On 5 Sep 2023, at 12:17, Faicker Mo via dev wrote:
Hi Faicker,
Thanks for this patch series! I have some comments below.
> When the IP header is rewritten like NAT or ttl/tos changed,
> the csum of IP header need recalculation. The UDPLITE checksum
> needs recalculation if src or dst changed in
push_nsh() is also a simple
> function without a possibility for re-entry, so the stack is returned
> right away.
>
> With this change the preallocated space is reduced by 256 B per call:
>
> b18: 48 81 ec b0 00 00 00sub$0xb0,%rsp
>
> Signed-off-by: Ilya Maxime
push_nsh() is also a simple
> function without a possibility for re-entry, so the stack is returned
> right away.
>
> With this change the preallocated space is reduced by 256 B per call:
>
> b18: 48 81 ec b0 00 00 00sub$0xb0,%rsp
>
> Signed-off-by: Ilya
On 26 Aug 2023, at 8:01, mit...@outlook.com wrote:
From: Lin Huang
OvS has supported packet-per-second policer which can be set at
ingress
and egress side in kernel datapath. But the userspace datapath dosen't
support for ingress and egress packet-per-second policing now.
So, this patch
On 26 Aug 2023, at 8:01, mit...@outlook.com wrote:
From: Lin Huang
OvS has supported packet-per-second policer which can be set at
ingress
and egress side in kernel datapath. But the userspace datapath doesn't
support for ingress and egress packet-per-second policing now.
So, this patch
On 26 Aug 2023, at 8:01, mit...@outlook.com wrote:
From: Lin Huang
Currently srtcm_policer free packet one by one, if packets are exceed
rate limit.
That is a inefficient way to free memory which we have to call
rte_pktmbuf_free()
pkt_cnt times.
To improve this, we can use
On 26 Aug 2023, at 8:01, mit...@outlook.com wrote:
From: Lin Huang
Now, token-bucket 'last_fill' is updated by token_bucket_withdraw()
itself.
Add a new function parameter 'now' to update timestamp by caller.
Signed-off-by: Lin Huang
Thanks Lin for following up, and sorry for the late
On 19 Sep 2023, at 13:25, Simon Horman wrote:
> On Thu, Sep 14, 2023 at 03:52:50PM +0200, Eelco Chaudron wrote:
>>
>>
>> On 14 Sep 2023, at 15:44, Eelco Chaudron wrote:
>>
>>> This patch adds WARNINGs for the subject line length and the format,
>>> i
On 19 Sep 2023, at 10:42, Robin Jarry wrote:
> Adrian Moreno, Sep 19, 2023 at 09:18:
>>> Both OVSDB and appctl are literally JSON-RPC protocols. There is no
>>> need to re-invent anything.
>>
>> Right. Isn't appctl simpler in this case? IIUC, it would still satisfy
>> the requirements: client
On 9 Sep 2023, at 1:40, Ilya Maximets wrote:
Currently OVS requires restart of ovs-vswitchd after enabling hardware
offload. This is necessary to make sure all the correct features are
probed and all the internal configurations are in the right state.
Making that process a bit less
ly, skipping some action, or logging a warning if a null pointer is
> encountered.
>
> Signed-off-by: James Raphael Tiovalen
> Reviewed-by: Simon Horman
Thanks James for following through with this patchset!
This revision looks all good to me!
rtions since it should be impossible for these calls to
> `dp_packet_data()` to return NULL.
>
> Signed-off-by: James Raphael Tiovalen
> Reviewed-by: Simon Horman
> Acked-by: Aaron Conole
Thanks James for following trough with this patchset!
This revision looks all good to me
On 14 Sep 2023, at 15:44, Eelco Chaudron wrote:
This patch adds WARNINGs for the subject line length and the format,
i.e., the sentence should start with a capital and end with a dot.
Acked-by: Simon Horman
Signed-off-by: Eelco Chaudron
Simon, let me know if you are ok with the change
This patch adds WARNINGs for the subject line length and the format,
i.e., the sentence should start with a capital and end with a dot.
Acked-by: Simon Horman
Signed-off-by: Eelco Chaudron
---
v3: - Fixed sed to work on BSD.
v2: - Add test cases
- Made it work on files and git patches
On 14 Sep 2023, at 13:44, David Marchand wrote:
> On Mon, Sep 11, 2023 at 11:54 AM Eelco Chaudron wrote:
>> On 11 Sep 2023, at 11:36, David Marchand wrote:
>>
>>> On Fri, Sep 8, 2023 at 4:28 PM Eelco Chaudron wrote:
>>>> On 6 Sep 2023, at 8:20, David
On 12 Sep 2023, at 15:19, Robin Jarry wrote:
> Eelco Chaudron, Sep 12, 2023 at 09:17:
>> I feel like if we do need another way of getting (real time)
>> statistics out of OVS, we should use the same communication channel as
>> the other ovs-xxx utilities are using. But
-by: Eelco Chaudron
---
v2: Addressed review comments from Aaron.
v3: Changed wording in documentation.
v4: Addressed review comments from Adrian.
utilities/automake.mk |4
utilities/usdt-scripts/kernel_delay.py | 1420 +++
utilities/usdt-scripts
On 11 Sep 2023, at 14:00, Adrian Moreno wrote:
> On 8/21/23 17:41, Eelco Chaudron wrote:
>> This patch adds an utility that can be used to determine if
>> an issue is related to a lack of Linux kernel resources.
>>
>> This tool is also featured in a Red Hat developer
On 11 Sep 2023, at 12:41, Robin Jarry wrote:
> Hey Kevin,
>
> Kevin Traynor, Sep 07, 2023 at 15:37:
>> This came up in conversation with other maintainers as I mentioned I was
>> reviewing and the question raised was - Why add this ? if you want these
>> values exposed, wouldn't it be better to
This patch adds WARNINGs for the subject line length and the format,
i.e., the sentence should start with a capital and end with a dot.
Signed-off-by: Eelco Chaudron
---
v2: - Add test cases
- Made it work on files and git patches
- Changed it from 50 chars on the summary, to 70 chars
On 9 Sep 2023, at 1:11, Ilya Maximets wrote:
> On 9/5/23 14:40, Eelco Chaudron wrote:
>> This patch adds WARNINGs for the subject line length and the format,
>> i.e., the sentence should start with a capital and end with a dot.
>>
>> Signed-off-by: Eelco Cha
On 11 Sep 2023, at 11:36, David Marchand wrote:
> On Fri, Sep 8, 2023 at 4:28 PM Eelco Chaudron wrote:
>> On 6 Sep 2023, at 8:20, David Marchand wrote:
>>
>>> Integrate system-traffic.at tests as part of check-dpdk.
>>>
>>> Some tests that can't wo
-by: Eelco Chaudron
---
v2: Addressed review comments from Aaron.
v3: Changed wording in documentation.
utilities/automake.mk |4
utilities/usdt-scripts/kernel_delay.py | 1402 +++
utilities/usdt-scripts/kernel_delay.rst | 596 +
3 files
On 9 Sep 2023, at 10:48, James Raphael Tiovalen wrote:
> C++ does not allow implicit conversion from void pointer to a specific
> pointer type. This change removes the cast from uint32_t* to void* in
> `hash_words_32aligned` and adds an explicit typecast from uint32_t* to
> uint64_t* in
On 6 Sep 2023, at 8:20, David Marchand wrote:
> Integrate system-traffic.at tests as part of check-dpdk.
>
> Some tests that can't work with the userspace datapath are skipped by
> overriding some OVS_CHECK_* macros.
>
> ADD_VETH is implemented using the net/af_xdp DPDK driver.
>
>
won't register this
> helper unless a netdev is actually allocated.
>
> Signed-off-by: David Marchand
These changes look good to me!
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
m-dpdk tests) and
> use it in the existing tests.
>
> Acked-by: Eelco Chaudron
> Acked-by: Aaron Conole
> Signed-off-by: David Marchand
Thanks David for resubmitting this series!
Re-ACKing this patch as it has some changes since the last time I reviewed it
On 6 Sep 2023, at 15:41, Simon Horman wrote:
> On Tue, Sep 05, 2023 at 02:40:24PM +0200, Eelco Chaudron wrote:
>> This patch adds WARNINGs for the subject line length and the format,
>> i.e., the sentence should start with a capital and end with a dot.
>
> Hi Eelco,
This patch adds WARNINGs for the subject line length and the format,
i.e., the sentence should start with a capital and end with a dot.
Signed-off-by: Eelco Chaudron
---
utilities/checkpatch.py | 30 ++
1 file changed, 30 insertions(+)
diff --git a/utilities
-by: Eelco Chaudron
---
v2: Addressed review comments from Aaron.
utilities/automake.mk |4
utilities/usdt-scripts/kernel_delay.py | 1402 +++
utilities/usdt-scripts/kernel_delay.rst | 597 +
3 files changed, 2003 insertions(+)
create
On 28 Aug 2023, at 16:15, Aaron Conole wrote:
> Eelco Chaudron writes:
>
>> This patch adds an utility that can be used to determine if
>> an issue is related to a lack of Linux kernel resources.
>>
>> This tool is also featured in a Red Hat developers
401 - 500 of 2699 matches
Mail list logo
