the correct megaflow instead of key lookup.
Thanks for fixing Ilya’s comments! I’ve also copied in some of the v3
discussion, so we can wrap it up here.
Acked-by: Eelco Chaudron
//Eelco
> Signed-off-by: Peng He
> ---
> lib/dpif-netdev.c | 62 ++---
On 4 Jul 2023, at 15:11, Ilya Maximets wrote:
> Before the cleanup option, the bridge_exit() call was fairly fast,
> because it didn't include any particularly long operations. However,
> with the cleanup flag, this function destroys a lot of datapath
> resources freeing a lot of memory,
the test suite.
>
> Signed-off-by: Peng He
Thanks for fixing the comments on v11. The changes look good, with one little
nit (see below), but those can be applied during commit.
Acked-by: Eelco Chaudron
> ---
> ofproto/ofproto-dpif-upcall.c | 50 +--
>
On 4 Jul 2023, at 11:00, Ales Musil wrote:
> On Mon, Jun 19, 2023 at 11:32 AM Eelco Chaudron wrote:
>
>> This patch includes changes made earlier by David in the
>> ovs branch to cache the dpdk builds.
>>
>> Co-authored-by: David Marchand
>> Signed-o
On 27 Jun 2023, at 12:48, Roi Dayan wrote:
> Hi,
>
> This series adds TC offload support for filtering vxlan tunnels with gbp
> option.
> First 4 patches do some refactoring and the later patches adds the feature.
>
> Thanks,
> Roi
Thanks for following up on the series!
I’ve applied the
On 4 Jul 2023, at 8:55, Sayali Naval (sanaval) via dev wrote:
> As per the Open vSwitch Manual
> (http://www.openvswitch.org/support/dist-docs/ovs-vsctl.8.txt) the Bridge
> IPFIX parameters can be passed as follows:
>
> ovs-vsctl -- set Bridge br0 ipfix=@i \
> -- --id=@i
On 4 Jul 2023, at 3:39, Sayali Naval (sanaval) via dev wrote:
> As per the Open vSwitch Manual
> (http://www.openvswitch.org/support/dist-docs/ovs-vsctl.8.txt) the Bridge
> IPFIX parameters can be passed as follows:
>
> ovs-vsctl -- set Bridge br0 ipfix=@i \
> -- --id=@i
On 30 Jun 2023, at 14:33, Eric Garver wrote:
> On Fri, Jun 30, 2023 at 08:57:15AM +0200, Eelco Chaudron wrote:
>>
>>
>> On 29 Jun 2023, at 22:30, Eric Garver wrote:
>>
>>> Probe the datapath implementation for support of OVS_ACTION_ATTR_DROP.
>>&g
On 5 Jun 2023, at 8:25, Adrian Moreno wrote:
> On 6/5/23 08:22, Adrian Moreno wrote:
>>
>> On 6/2/23 16:13, Adrian Moreno wrote:
>>> There are currently two issues that limit our ability to configure QoS
>>> on certain cards in linux:
>>>
>>> 1) Firstly, the maximum link speed (which is used as
On 29 Jun 2023, at 22:30, Eric Garver wrote:
> Probe the datapath implementation for support of OVS_ACTION_ATTR_DROP.
> Also add a new test case.
Hi Eric,
Thanks for the patch, but I get quite some build failures on missing switch
cases.
Can you take a look? If you build with the
On 29 Jun 2023, at 17:54, Ilya Maximets wrote:
> On 6/29/23 17:43, Eelco Chaudron wrote:
>>
>>
>> On 22 Jun 2023, at 0:32, Ilya Maximets wrote:
>>
>>> Current implementation of meters in the userspace datapath takes
>>> the meter lock for every pa
On 22 Jun 2023, at 0:32, Ilya Maximets wrote:
> Current implementation of meters in the userspace datapath takes
> the meter lock for every packet batch. If more than one thread
> hits the flow with the same meter, they will lock each other.
>
> Replace the critical section with atomic
On 26 Jun 2023, at 15:43, Mike Pattrick wrote:
> Currently OVS keeps track of which mirrors that each packet has been
> sent to for the purpose of deduplication. However, this doesn't consider
> that openflow rules can make significant changes to packets after
> ingress.
>
> For example, OVN
On 27 Jun 2023, at 12:48, Roi Dayan wrote:
> From: Gavin Li
>
> Add a vxlan gbp offload test case:
>
> vxlan offloads with gbp extention - ping between two ports - offloads
> enabled ok
>
> Signed-off-by: Gavin Li
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
Some small comments
On 27 Jun 2023, at 12:48, Roi Dayan wrote:
> From: Gavin Li
>
> Add TC offload support for vxlan encap with gbp option
>
> Signed-off-by: Gavin Li
> Reviewed-by: Gavi Teitz
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
> Acked-by: Eelco Chaudron
&g
On 2 Jun 2023, at 16:13, Adrian Moreno wrote:
> Currently, the netdev's speed is being calculated by taking the link's
> feature bits (using netdev_get_features()) and transforming them into
> bps.
>
> This mechanism can be both inaccurate and difficult to maintain, mainly
> because we
On 27 Jun 2023, at 14:16, Ilya Maximets wrote:
> Signed-off-by: Ilya Maximets
Changes look good.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 27 Jun 2023, at 14:16, Ilya Maximets wrote:
> Signed-off-by: Ilya Maximets
Changes look good.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 27 Jun 2023, at 14:16, Ilya Maximets wrote:
> Signed-off-by: Ilya Maximets
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
9..673f22720 100644
Change look good, and as you mentioned it’s good the have a new release ;)
Acked-by: Eelco Chaudron
> --- a/NEWS
> +++ b/NEWS
> @@ -1,3 +1,6 @@
> +v2.17.8 - xx xxx
> +-
> +
> v2.17.7 - 27 Jun 2023
> --
On 23 Jun 2023, at 19:07, Mike Pattrick wrote:
> Currently OVS keeps track of which mirrors that each packet has been
> sent to for the purpose of deduplication. However, this doesn't consider
> that openflow rules can make significant changes to packets after
> ingress.
>
> For example, OVN
On 15 Jun 2023, at 4:51, Peng He wrote:
> OVS allows overlapping megaflows, as long as the actions of these
> megaflows are equal. However, the current implementation of action
> modification relies on flow_lookup instead of ufid, this could result
> in looking up a wrong megaflow and make the
On 23 Jun 2023, at 14:33, Dumitru Ceara wrote:
> On 6/23/23 14:23, Eelco Chaudron wrote:
>>
>>
>> On 23 Jun 2023, at 14:22, Eelco Chaudron wrote:
>>
>>> On 23 Jun 2023, at 14:12, Dumitru Ceara wrote:
>>>
>>>> As far as I can tell they'
On 23 Jun 2023, at 14:22, Eelco Chaudron wrote:
> On 23 Jun 2023, at 14:12, Dumitru Ceara wrote:
>
>> As far as I can tell they're used mostly for CI job definitions and
>> these tend to result in long lines.
>>
>> Reported-at:
>> https://mail.openvswitch.or
nole
> Signed-off-by: Dumitru Ceara
Looks good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 9 Jun 2023, at 17:03, Peng He wrote:
> push_dp_ops only handles delete ops errors but ignores the modify
> ops results. It's better to handle all the dp operation errors in
> a consistent way.
>
> This patch prevents the inconsistency by considering modify failure
> in revalidators.
>
> To
On 23 Jun 2023, at 12:57, Simon Horman wrote:
> On Fri, Jun 23, 2023 at 11:16:50AM +0200, Eelco Chaudron wrote:
>>
>>
>> On 19 Jun 2023, at 13:56, Roi Dayan wrote:
>>
>>> From: Gavin Li
>>>
>>> Add a vxlan gbp offload test case:
>>
On 19 Jun 2023, at 13:56, Roi Dayan wrote:
> From: Gavin Li
>
> Add a vxlan gbp offload test case:
>
> vxlan offloads with gbp extention - ping between two ports - offloads
> enabled ok
>
> Signed-off-by: Gavin Li
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
> ---
Thanks for
h 7 and
this one. But I don’t think it should block the series.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 23 Jun 2023, at 10:44, Eelco Chaudron wrote:
> On 19 Jun 2023, at 13:56, Roi Dayan wrote:
>
>> From: Gavin Li
>>
>> Add TC offload support for vxlan encap with gbp option
>>
>> Signed-off-by: Gavin Li
>> Reviewed-by: Gavi Teitz
>> Revi
ok good to me, one small nit, but not
worth sending a new rev (maybe it can be fixed during commit).
Acked-by: Eelco Chaudron
> ---
> acinclude.m4 | 7
> include/linux/tc_act/tc_tunnel_key.h | 17 +++-
> lib/netdev-offload-tc.c |
named
> struct and pass it entirely.
>
> Signed-off-by: Gavin Li
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
Thanks for following up! The changes look good to me.
Acked-by: Eelco Chaudron
___
dev mailing l
p! The changes look good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ed by
> message policy. To avoid this, add NLA_F_NESTED explicitly for all
> nested netlink messages with a new function
> nl_msg_start_nested_with_flag().
>
> Signed-off-by: Gavin Li
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
Thanks for following up! The chang
changes look good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
changes look good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
support more vxlan
> options in the future, change the function arguments to pass tunnel
> entirely to it instead of keep adding new arguments.
>
> Signed-off-by: Gavin Li
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
Thanks for following up! The changes look g
ug.cgi?id=2104779
> Signed-off-by: Mike Pattrick
> Reviewed-by: Simon Horman
Changes look good to me, one small nit below, but not related to your changes.
So if no more revs are needed, we can leave it as is.
Acked-by: Eelco Chaudron
> ---
> Since v1:
> - Refactored code int
On 22 Jun 2023, at 13:29, Ilya Maximets wrote:
> On 6/22/23 11:30, Eelco Chaudron wrote:
>>
>>
>> On 22 Jun 2023, at 11:15, Ilya Maximets wrote:
>>
>>> On 6/22/23 10:50, Eelco Chaudron wrote:
>>>>
>>>>
>>>> On 30 May 2023,
On 22 Jun 2023, at 11:15, Ilya Maximets wrote:
> On 6/22/23 10:50, Eelco Chaudron wrote:
>>
>>
>> On 30 May 2023, at 9:32, Eelco Chaudron wrote:
>>
>>> On 26 May 2023, at 22:51, Ilya Maximets wrote:
>>>
>>>> On 5/26/23 15:09, Eelco C
On 30 May 2023, at 9:32, Eelco Chaudron wrote:
> On 26 May 2023, at 22:51, Ilya Maximets wrote:
>
>> On 5/26/23 15:09, Eelco Chaudron wrote:
>>>
>>>
>>> On 26 May 2023, at 14:03, Balazs Nemeth wrote:
>>>
>>>> The only way that stats-&g
On 21 Jun 2023, at 14:50, Simon Horman wrote:
> Eelco Chaudron was elected by the Open vSwitch committers yesterday.
> This formalises his status as an Open vSwitch committer.
>
> Welcome Eelco!
Not sire if I should ack ;)
Acked-by: Eelco Chaudron
> Signed-off-b
On 20 Jun 2023, at 16:57, Ilya Maximets wrote:
> On 6/20/23 16:10, Aaron Conole wrote:
>> Adrian Moreno writes:
>>
>>> On 6/19/23 10:36, Eelco Chaudron wrote:
>>>> On 16 Jun 2023, at 19:19, Aaron Conole wrote:
>>>>
>>>>> Martin Ke
On 20 Jun 2023, at 16:17, Aaron Conole wrote:
> Eelco Chaudron writes:
>
>> Add additional error coverage counters for dpif operation failures.
>> This could help to quickly identify netlink problems when communicating
>> with the OVS kernel module.
Add additional error coverage counters for dpif operation failures.
This could help to quickly identify netlink problems when communicating
with the OVS kernel module.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2070630
Signed-off-by: Eelco Chaudron
---
lib/dpif.c | 39
>
> Signed-off-by: Chris Mi
> Reviewed-by: Roi Dayan
> Acked-by: Eelco Chaudron
Thanks for making all the suggested changes to this series. This is my final
ack, which should conclude the series :)
Acked-by: Eelco Chaudron
//Eelco
___
Mi
> Reviewed-by: Roi Dayan
Thanks for making all the suggested changes.
Acked-by: Eelco Chaudron
//Eelco
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 19 Jun 2023, at 7:05, Chris Mi wrote:
> Iterate each registered offload API. It's not a problem for today
> since we only have one implementation.
>
> Signed-off-by: Chris Mi
> Reviewed-by: Roi Dayan
> ---
>
You forgot to include my ACK on v27. So here it is ag
ait.
>
> Signed-off-by: Chris Mi
> Reviewed-by: Roi Dayan
You forgot to include my ACK on v27. So here it is again:
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
to include my ACK on v27. So here it is again:
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
D, userspace can recover the sample
> info and send sampled packet to the right sample monitoring host.
>
> Signed-off-by: Chris Mi
> Reviewed-by: Roi Dayan
Thanks for making all the suggested changes.
Acked-by: Eelco Chaudron
//Eelco
__
On 19 Jun 2023, at 7:01, Chris Mi wrote:
>
>>> +if (err) {
>>> +VLOG_ERR_RL(_rl, "No OVS_ACTION_ATTR_USERSPACE attribute");
>>> +}
>>> +return err;
>>> +}
>>> +
>>> +static void
>>> +offload_sample_init(struct offload_sample *sample,
>>> +const struct
This patch includes changes made earlier by David in the
ovs branch to cache the dpdk builds.
Co-authored-by: David Marchand
Signed-off-by: David Marchand
Signed-off-by: Eelco Chaudron
---
v2: Replaced 'sleep 1' with '' after consulting with Dumitru.
v3: No changes
Note that I ran the full
Allow the ovn-system tests to run on the OVS-DPDK infrastructure,
i.e., DPDK ports and mbuf memory.
Co-authored-by: David Marchand
Signed-off-by: David Marchand
Signed-off-by: Eelco Chaudron
---
v2: No changes.
v3: Add 'dpdk-extra="--log-level=pmd.*:error --no-pci"' to test init
On 16 Jun 2023, at 19:19, Aaron Conole wrote:
> Martin Kennelly writes:
>
>> Hey ovs community,
>>
>> I am a developer working on ovn-kubernetes and I want to programmatically
>> consume long poll information
>> i.e:
>> ovs|00211|timeval(handler25)|WARN|Unreasonably long 52388ms poll
>
> Signed-off-by: Chris Mi
> Reviewed-by: Roi Dayan
> Acked-by: Eelco Chaudron
See some comments inline below.
//Eelco
> ---
> Documentation/howto/tc-offload.rst | 24 +
> tests/system-offloads-traffic.at | 152 +
> 2 files ch
On 1 Jun 2023, at 13:16, Chris Mi wrote:
> Create a unique group ID to map the sFlow info when offloading sample
> action to TC. When showing the offloaded datapath flows, translate the
> group ID from TC sample action to sFlow info using the mapping.
>
> Signed-off-by: Chris Mi
> Reviewed-by:
ait.
>
> Signed-off-by: Chris Mi
> Reviewed-by: Roi Dayan
Thanks for working trough all the revisions. This one looks good...
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 1 Jun 2023, at 13:16, Chris Mi wrote:
> Iterate each registered offload API. It's not a problem for today
> since we only have one implementation.
>
> Signed-off-by: Chris Mi
> Reviewed-by: Roi Dayan
Thanks for working trough all the revisions. This one looks good...
working trough all the revisions. This one looks good...
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 1 Jun 2023, at 13:16, Chris Mi wrote:
> When offloading sample action to TC, userspace creates a unique ID
> to map sample action and tunnel info and passes this ID to kernel
> instead of the sample info. Kernel will send this ID and sampled
> packet to userspace. Using the ID, userspace can
On 1 Jun 2023, at 13:16, Chris Mi wrote:
> This patch set adds offload support for sFlow.
>
> Psample is a genetlink channel for packet sampling. TC action act_sample
> uses psample to send sampled packets to userspace.
>
> When offloading sample action to TC, userspace creates a unique ID to
>
On 12 Jun 2023, at 17:07, Mike Pattrick wrote:
> On Mon, Jun 12, 2023 at 10:54 AM Eelco Chaudron wrote:
>>
>>
>>
>> On 12 Jun 2023, at 15:11, Mike Pattrick wrote:
>>
>>> On Tue, May 30, 2023 at 10:23 AM Robin Jarry wrote:
>>>>
>>&g
On 12 Jun 2023, at 15:11, Mike Pattrick wrote:
> On Tue, May 30, 2023 at 10:23 AM Robin Jarry wrote:
>>
>> EditorConfig is a file format and collection of text editor plugins for
>> maintaining consistent coding styles between different editors and IDEs.
>>
>> Initialize the file following the
On 9 Jun 2023, at 17:08, Ilya Maximets wrote:
> On 6/9/23 16:40, Eelco Chaudron wrote:
>> Allow the ovn-system tests to run on the OVS-DPDK infrastructure,
>> i.e., DPDK ports and mbuf memory.
>>
>> Co-authored-by: David Marchand
>> Signed-off-by: David
This patch includes changes made earlier by David in the
ovs branch to cache the dpdk builds.
Co-authored-by: David Marchand
Signed-off-by: David Marchand
Signed-off-by: Eelco Chaudron
---
v2: Replaced 'sleep 1' with '' after consulting with Dumitru.
Note that I ran the full GitHub ci 20x
Allow the ovn-system tests to run on the OVS-DPDK infrastructure,
i.e., DPDK ports and mbuf memory.
Co-authored-by: David Marchand
Signed-off-by: David Marchand
Signed-off-by: Eelco Chaudron
---
v2: No changes for this patch.
tests/automake.mk | 23 +++--
tests/ofproto
On 25 May 2023, at 22:34, Mike Pattrick wrote:
> Several xlate actions used in recursive translation currently store a
> large amount of information on the stack. This can result in handler
> threads quickly running out of stack space despite before
> xlate_resubmit_resource_check() is able to
On 3 Jun 2023, at 2:01, Peng He wrote:
> push_dp_ops only handles delete ops errors but ignores the modify
> ops results. It's better to handle all the dp operation errors in
> a consistent way.
>
> This patch prevents the inconsistency by considering modify failure
> in revalidators.
>
> To
fen...@inspur.com/
> Signed-off-by: Ilya Maximets
The changes look good to me.
Only tested on linux, and looking up the APIs on Windows, that part seems fine.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 2 Jun 2023, at 20:42, Peng He wrote:
> OVS allows overlapping megaflows, as long as the actions of these
> megaflows are equal. However, the current implementation of action
> modification relies on flow_lookup instead of ufid, this could result
> in looking up a wrong megaflow and make the
On 18 May 2023, at 22:08, Mike Pattrick wrote:
> Several xlate actions used in recursive translation currently store a
> large amount of information on the stack. This can result in handler
> threads quickly running out of stack space despite before
> xlate_resubmit_resource_check() is able to
This patch includes changes made earlier by David in the
ovs branch to cache the dpdk builds.
Co-authored-by: David Marchand
Signed-off-by: David Marchand
Signed-off-by: Eelco Chaudron
---
.ci/ci.sh | 12 ++-
.ci/dpdk-build.sh | 54
Allow the ovn-system tests to run on the OVS-DPDK infrastructure,
i.e., DPDK ports and mbuf memory.
Co-authored-by: David Marchand
Signed-off-by: David Marchand
Signed-off-by: Eelco Chaudron
---
tests/automake.mk | 23 +++--
tests/ofproto-macros.at|9 ++-
tests
Forgot to put OVN in the title will resend it, so the correct patchwork will
pick it up :(
//Eelco
On 7 Jun 2023, at 10:58, Eelco Chaudron wrote:
> Allow the ovn-system tests to run on the OVS-DPDK infrastructure,
> i.e., DPDK ports and mbuf memory.
>
> Co-authored-by: Da
On 7 Jun 2023, at 3:05, wangchuanlei wrote:
> Thanks for fix this, in common enviroment, it's a
> small probability event.
Well, on ARM, they could replicate it a couple of times, but I guess the system
was under memory pressure and has a lot of cores.
>> Eelco Chau
This patch includes changes made earlier by David in the
ovs branch to cache the dpdk builds.
Co-authored-by: David Marchand
Signed-off-by: David Marchand
Signed-off-by: Eelco Chaudron
---
.ci/ci.sh | 12 ++-
.ci/dpdk-build.sh | 54
Allow the ovn-system tests to run on the OVS-DPDK infrastructure,
i.e., DPDK ports and mbuf memory.
Co-authored-by: David Marchand
Signed-off-by: David Marchand
Signed-off-by: Eelco Chaudron
---
tests/automake.mk | 23 +++--
tests/ofproto-macros.at|9 ++-
tests
On 6 Jun 2023, at 13:43, Paolo Abeni wrote:
> On Mon, 2023-06-05 at 16:38 +0200, Simon Horman wrote:
>> On Mon, Jun 05, 2023 at 03:53:59PM +0200, Eelco Chaudron wrote:
>>>> Yeah, I see that. And I might have done the same thing.
>>>> But, OTOH, this change is m
0f06079f90
We moved the per cpu upcall counter allocation to the existing vport
alloc and free functions to solve this.
Fixes: 95637d91fefd ("net: openvswitch: release vport resources on failure")
Fixes: 1933ea365aa7 ("net: openvswitch: Add support to count upcall packets"
On 5 Jun 2023, at 15:07, Simon Horman wrote:
> On Mon, Jun 05, 2023 at 02:54:35PM +0200, Eelco Chaudron wrote:
>>
>>
>> On 5 Jun 2023, at 14:41, Simon Horman wrote:
>>
>>> On Mon, Jun 05, 2023 at 10:59:50AM +0200, Eelco Chaudron wrote:
>>>> Curr
ing the mutex, so the current behavior is not changing. The
seq_read() behavior is already defined as, "Returns seq's current
sequence number (which could change immediately)". So the change
should not impact the current behavior.
Signed-off-by: Eelco Chaudron
---
v2: Update acquir
On 5 Jun 2023, at 14:41, Simon Horman wrote:
> On Mon, Jun 05, 2023 at 10:59:50AM +0200, Eelco Chaudron wrote:
>> Currently, the per cpu upcall counters are allocated after the vport is
>> created and inserted into the system. This could lead to the datapath
>> accessin
0f06079f90
We moved the per cpu upcall counter allocation to the existing vport
alloc and free functions to solve this.
Fixes: 95637d91fefd ("net: openvswitch: release vport resources on failure")
Fixes: 1933ea365aa7 ("net: openvswitch: Add support to count upcall packets")
On 2 Jun 2023, at 17:12, Peng He wrote:
> Hi, Eelco and Ilya,
> I have sent a new version of this patch with a test case.
Thanks! I’ll try to review it asap, but I have a bit of a review backlog :(
//Eelco
> Eelco Chaudron 于2023年5月15日周一 15:45写道：
>
>>
>>
>> On
On 2 Jun 2023, at 17:12, Peng He wrote:
> Hi, Eelco and Ilya,
> I have sent a new version of this patch with a test case.
Nice…
> Eelco Chaudron 于2023年5月15日周一 15:45写道：
>
>>
>>
>> On 12 May 2023, at 3:57, Peng He wrote:
>>
>>> Hi,
>
On 26 May 2023, at 10:24, Chris Mi wrote:
> On 5/10/2023 10:57 PM, Eelco Chaudron wrote:
>> On 27 Apr 2023, at 3:27, Chris Mi wrote:
>>
>>>>> recirc_id(0),in_port(1),eth(src=06:9c:de:63:c9:40,dst=01:00:5e:00:00:fb),eth_type(0x0800),ipv4(tos=0/0x3,frag=no),
>&
On 26 May 2023, at 10:21, Chris Mi wrote:
> On 5/10/2023 10:52 PM, Eelco Chaudron wrote:
>> On 26 Apr 2023, at 4:47, Chris Mi wrote:
>>
>>
>>
>>>>> +
>>>>> +P0_IFINDEX=$(cat /sys/class/net/ovs-p0/ifindex)
>>>>> +m4_defi
On 26 May 2023, at 10:19, Chris Mi wrote:
> On 5/10/2023 8:20 PM, Eelco Chaudron wrote:
>> On 26 Apr 2023, at 4:44, Chris Mi wrote:
>>
>>
>>
>>>>> +
>>>>> +static int
>>>>> +offload_sample_init(struct offload_samp
On 26 May 2023, at 10:18, Chris Mi wrote:
> On 5/10/2023 7:42 PM, Eelco Chaudron wrote:
>> On 26 Apr 2023, at 4:42, Chris Mi wrote:
>>
>>
>>>>>/* DPIF_UC_ACTION only. */
>>>>>struct nlattr *userdata;/* Argument to
&g
On 26 May 2023, at 10:17, Chris Mi wrote:
> On 5/10/2023 5:54 PM, Eelco Chaudron wrote:
>> On 26 Apr 2023, at 4:36, Chris Mi wrote:
>>
>>> On 4/12/2023 10:06 PM, Eelco Chaudron wrote:
>>
>>
>>>>> +{
>>>>> +new->type =
t;)
> Signed-off-by: David Marchand
Changes look god to me (visual inspection only).
Acked-by: Eelco Chaudron
> ---
> lib/netdev-offload-dpdk.c | 2 +-
> lib/netdev-offload.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/netdev-offlo
em also exists in
the real world when the end-user changes the OpenFlow rules.
//Eelco
> Eelco Chaudron 于2022年11月28日周一 16:53写道：
>
>> The datapath supports installing wider flows, and OVS relies on
>> this behavior. For example if ipv4(src=1.1.1.1/192.0.0.0,
>> dst=1.1.1.2/
On 30 May 2023, at 10:39, Hao Jue PX Wang via discuss wrote:
Hello team,
In this stable release doc link
https://docs.openvswitch.org/en/stable/faq/issues/, I found this
description of STP, I am wondering is there further plan for OVS STP
testing? as this STP is very useful in preventing
On 26 May 2023, at 22:51, Ilya Maximets wrote:
> On 5/26/23 15:09, Eelco Chaudron wrote:
>>
>>
>> On 26 May 2023, at 14:03, Balazs Nemeth wrote:
>>
>>> The only way that stats->{n_packets,n_bytes} would decrease is due to an
>>> overflow, or
Send from my phone
> Op 26 mei 2023 om 20:52 heeft Ilya Maximets het volgende
> geschreven:
>
> On 5/26/23 20:43, Ilya Maximets wrote:
>>> On 5/23/23 12:39, Frode Nordahl wrote:
>>> The tc module combines the use of the `tc_transact` helper
>>> function for communication with the in-kernel
On 26 May 2023, at 15:40, Marcelo Ricardo Leitner wrote:
> On Fri, May 26, 2023 at 03:09:02PM +0200, Eelco Chaudron wrote:
>>
>>
>> On 26 May 2023, at 14:03, Balazs Nemeth wrote:
>>
>>> The only way that stats->{n_packets,n_bytes} would decrease is due t
On 17 May 2023, at 12:18, Eelco Chaudron wrote:
> On 16 May 2023, at 21:48, Ilya Maximets wrote:
>
>> On 5/16/23 10:20, Eelco Chaudron wrote:
>>>
>>>
>>> On 15 May 2023, at 17:47, Ilya Maximets wrote:
>>>
>>>> On 5/15/23 16:24, Ee
wed-by: Simon Horman
> Signed-off-by: Frode Nordahl
Thanks Frode for the v4, it looks good to me. And if you sent out a v5 with
only Ilya’s suggested change you can keep my ack.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
on a missing “,” compared to the dp flow dump, but I think Ilya can add
this on commit.
Acked-by: Eelco Chaudron
//Eelco
> ---
> ofproto/ofproto-dpif-upcall.c | 30 --
> 1 file changed, 24 insertions(+), 6 deletions(-)
>
> diff --git a/ofproto/o
601 - 700 of 2699 matches
Mail list logo
