[ovs-dev] [PATCH v10 05/11] netdev-offload-tc: Conntrack ALGs are not supported with tc.

, and it will not invoke the ALG helper. Fixes: 576126a931cd ("netdev-offload-tc: Add conntrack support") Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- Documentation/howto/tc-offload.rst| 11 +++ lib/netdev-offload-tc.c |4 tests/system-offloads

[ovs-dev] [PATCH v10 03/11] netdev-offload-tc: Fix tc conntrack force commit support.

tc was not setting the OVS_CT_ATTR_FORCE_COMMIT flag when a forced commit was requested. This patch will fix this. Fixes: 576126a931cd ("netdev-offload-tc: Add conntrack support") Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- lib/netdev-offload-tc.c | 13 +++

[ovs-dev] [PATCH v10 02/11] test: Do not use MPLS implicit null label in test cases.

TC flower does not allow the push of the implicit null labels (RFC3032). Avoid the use of such labels in the MPLS test cases. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system-traffic.at | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests

[ovs-dev] [PATCH v10 01/11] tests: Include working system-traffic tests into the system-offloads-testsuite.

Include and run the system-traffic.at tests as part of the system offload testsuite. Exclude all the tests that will not run without any special modifications. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/automake.mk |3 ++ tests/ofproto-macros.at

[ovs-dev] [PATCH v10 00/11] tests: Add system-traffic.at tests to check-offloads.

ches 4, 6 and 10. v2: - Fix commit message on last patch - Moved handling of system-traffic.at tests to a separate file system-offloads.at - Re-based to the latest ovs master branch - Added Roi's ACKs Eelco Chaudron (11): tests: Include working system-traffic tests into the syste

Re: [ovs-dev] [PATCH 00/11] tests: Add system-traffic.at tests to check-offloads.

Please ignore this version, it’s missing a version number and changes to two files :( //Eelco On 2 Feb 2023, at 8:37, Eelco Chaudron wrote: > This series makes it possible to include system-traffic.at tests into > "make check-offloads" tests. > > The last patch of the

Re: [ovs-dev] [PATCH net-next v3 1/1] net:openvswitch:reduce cpu_used_mask memory

On 2 Feb 2023, at 11:32, Eddy Tao wrote: > Use actual CPU number instead of hardcoded value to decide the size > of 'cpu_used_mask' in 'struct sw_flow'. Below is the reason. > > 'struct cpumask cpu_used_mask' is embedded in struct sw_flow. > Its size is hardcoded to CONFIG_NR_CPUS bits, which

Re: [ovs-dev] [PATCH v2] net: openvswitch: fix flow memory leak in ovs_flow_cmd_new

Center (linuxtesting.org) with Syzkaller. > > Fixes: 68bb10101e6b ("openvswitch: Fix flow lookup to use unmasked key") > Signed-off-by: Fedor Pchelkin > Signed-off-by: Alexey Khoroshilov > --- > v1->v2: make goto statements structured Thanks for fixing this, th

[ovs-dev] [PATCH 10/11] tests: Fix reading of OpenFlow byte counters in GRE test cases.

With some datapaths, read TC, it takes a bit longer to update the OpenFlow statistics. Rather than adding an additional delay, try to read the counters multiple times until we get the desired value. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system-traffic.at | 18

[ovs-dev] [PATCH 11/11] tests: Comment currently failing TC system-traffic tests.

tunnel by simulated packets These tests where executed on a Fedora37 machine with the kernel 6.1.5-200.fc37.x86_64 installed. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system-offloads-testsuite-macros.at | 21 + tests/system-traffic.at |2

[ovs-dev] [PATCH 08/11] odp-util: Make odp_flow_key_from_flow__ nlattr order the same as the kernel.

Make the order of the Netlink attributes for odp_flow_key_from_flow__() the same as the kernel will return them. This will make sure the attributes displayed in the dpctl/dump-flows output appear in the same order for all datapath. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- lib/odp

[ovs-dev] [PATCH 09/11] netdev-offload-tc: If the flow has not been used, report it as such.

ctions") Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- lib/tc.c| 14 +- tests/system-traffic.at |1 - 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/lib/tc.c b/lib/tc.c index 1fb2b4a92..4c07e2216 100644 --- a/lib/tc.c +++ b/lib/tc.c

[ovs-dev] [PATCH 07/11] test: Fix 'conntrack - Multiple ICMP traverse' for tc case.

tc does not include ethernet header length in packet byte count. This fix will allow the packets that go trough tc to be 14 bytes less. This difference in the TC implementation is already described in tc-offload.rst. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system

[ovs-dev] [PATCH 05/11] netdev-offload-tc: Conntrack ALGs are not supported with tc.

, and it will not invoke the ALG helper. Fixes: 576126a931cd ("netdev-offload-tc: Add conntrack support") Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- Documentation/howto/tc-offload.rst| 11 +++ lib/netdev-offload-tc.c |4 tests/system-offloads

[ovs-dev] [PATCH 06/11] test: tc does not support conntrack timeout, skip the related test.

The tc conntrack implementation does not support the timeout option. The current implementation is silently ignoring the timeout option by adding a general conntrack entry. This patch will skip the related test by overriding the support macro. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan

[ovs-dev] [PATCH 04/11] test: Flush datapath when changing rules on the fly.

Flush datapath flows as TC flows take some more time to be flushed out. The flush speeds this up. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system-traffic.at |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/system-traffic.at b/tests/system

[ovs-dev] [PATCH 03/11] netdev-offload-tc: Fix tc conntrack force commit support.

tc was not setting the OVS_CT_ATTR_FORCE_COMMIT flag when a forced commit was requested. This patch will fix this. Fixes: 576126a931cd ("netdev-offload-tc: Add conntrack support") Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- lib/netdev-offload-tc.c | 13 +++

[ovs-dev] [PATCH 02/11] test: Do not use MPLS implicit null label in test cases.

TC flower does not allow the push of the implicit null labels (RFC3032). Avoid the use of such labels in the MPLS test cases. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system-traffic.at | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests

[ovs-dev] [PATCH 01/11] tests: Include working system-traffic tests into the system-offloads-testsuite.

Include and run the system-traffic.at tests as part of the system offload testsuite. Exclude all the tests that will not run without any special modifications. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/automake.mk |3 ++ tests/ofproto-macros.at

[ovs-dev] [PATCH 00/11] tests: Add system-traffic.at tests to check-offloads.

tem-traffic.at tests to a separate file system-offloads.at - Re-based to the latest ovs master branch - Added Roi's ACKs Eelco Chaudron (11): tests: Include working system-traffic tests into the system-offloads-testsuite. test: Do not use MPLS implicit null label in test cases. ne

[ovs-dev] [PATCH v4] netdev-offload-tc: Preserve tc statistics when flow gets modified.

implementation. It also updates the check_pkt_len tc test to purge the flows, so we do not use existing updated tc flow counters, but start with fresh installed set of datapath flows. Signed-off-by: Eelco Chaudron --- Please note that for now two copies of the test case exists, but I will clean this up once

Re: [ovs-dev] [PATCH v3] netdev-offload-tc: Preserve tc statistics when flow gets modified.

On 1 Feb 2023, at 12:02, Ilya Maximets wrote: > On 1/31/23 15:38, Eelco Chaudron wrote: >> >> >> On 31 Jan 2023, at 14:13, Ilya Maximets wrote: >> >>> On 1/13/23 13:57, Eelco Chaudron wrote: >>>> When a flow gets modified, i.e. the actions are ch

Re: [ovs-dev] [PATCH v3] netdev-offload-tc: Preserve tc statistics when flow gets modified.

On 31 Jan 2023, at 14:13, Ilya Maximets wrote: > On 1/13/23 13:57, Eelco Chaudron wrote: >> When a flow gets modified, i.e. the actions are changes, the tc layer will >> remove, and re-add the flow. This is causing all the counters to be reset. >> >> This patch wi

Re: [ovs-dev] [PATCH v4] netdev-offload-tc: del ufid mapping if device not exist

I replied to a v2 of this patch, but do not see any of my comments includes, so here are they again: On 30 Jan 2023, at 9:29, Faicker Mo wrote: From b8ec4ac672e7ef3370d52bae66db7eef7b8d9da6 Mon Sep 17 00:00:00 2001From: Faicker Mo Date: Thu, 12 Jan 2023 11:55:37 +0800 Subject: [PATCH]

Re: [ovs-dev] [PATCH v8 15/15] tests: Comment currently failing TC system-traffic tests.

On 26 Jan 2023, at 21:03, Ilya Maximets wrote: > On 1/24/23 14:01, Eelco Chaudron wrote: >> The goal was to run 200 successful tc tests in a row. To do this the >> following was run: >> >> for i in {1..200}; do make check-offloads || break; \ >> echo &quo

Re: [ovs-dev] [PATCH v8 14/15] tests: Fix reading of OpenFlow byte counters in GRE test cases.

On 26 Jan 2023, at 22:47, Ilya Maximets wrote: > On 1/24/23 14:01, Eelco Chaudron wrote: >> With some datapaths, read TC, it takes a bit longer to update the >> OpenFlow statistics. Rather than adding an additional delay, try >> to read the counters multiple times unt

Re: [ovs-dev] [PATCH v8 13/15] netdev-offload-tc: If the flow has not been used, report it as such.

On 26 Jan 2023, at 22:43, Ilya Maximets wrote: > On 1/24/23 13:59, Eelco Chaudron wrote: >> If a tc flow was installed but has not yet been used, report it as such. >> >> In addition, add a delay to the "IGMP - flood under normal action" test >> case

Re: [ovs-dev] [PATCH v8 09/15] netdev-offload-tc: Conntrack ALGs are not supported with tc.

On 26 Jan 2023, at 22:33, Ilya Maximets wrote: > On 1/26/23 22:32, Ilya Maximets wrote: >> On 1/24/23 13:57, Eelco Chaudron wrote: >>> tc does not support conntrack ALGs. Even worse, with tc enabled, they >>> should not be used/configured at all. This is because eve

Re: [ovs-dev] [PATCH v8 04/15] test: Add delay on revalidator flush for offload test cases.

On 26 Jan 2023, at 22:29, Ilya Maximets wrote: > On 1/24/23 13:56, Eelco Chaudron wrote: >> The revalidator/purge commands in the system test cases sometimes >> get called immediately after a partial test is completed. This >> could cause the revalidator thread to log

Re: [ovs-dev] [PATCH v8 08/15] test: Flush datapath when changing rules on the fly.

On 26 Jan 2023, at 21:50, Ilya Maximets wrote: > On 1/24/23 13:57, Eelco Chaudron wrote: >> Flush datapath flows as TC flows take some more time to be flushed out. >> The flush speeds this up. >> >> Signed-off-by: Eelco Chaudron >> Acked-by: Roi Dayan &g

Re: [ovs-dev] [PATCH v8 07/15] test: Fix "conntrack - floating IP" test for TC.

On 26 Jan 2023, at 21:47, Ilya Maximets wrote: > On 1/24/23 13:57, Eelco Chaudron wrote: >> This change fixes the "conntrack - floating" test for the TC >> offload case. In this scenario, the connection might move to >> CLOSE_WAIT, which would fail the test

Re: [ovs-dev] [PATCH v8 06/15] tests: Add delay to dump-conntrack for tc test cases.

On 26 Jan 2023, at 21:42, Ilya Maximets wrote: > On 1/24/23 13:56, Eelco Chaudron wrote: >> This patch adds a delay before dumping the conntrack table because with >> tc it takes a bit longer before it gets synced. >> >> Signed-off-by: Eelco Chaudron >> Acke

Re: [ovs-dev] [PATCH v8 05/15] netdev-offload-tc: Fix tc conntrack force commit support.

On 26 Jan 2023, at 21:40, Ilya Maximets wrote: > On 1/24/23 13:56, Eelco Chaudron wrote: >> tc was not setting the OVS_CT_ATTR_FORCE_COMMIT flag when a forced >> commit was requested. This patch will fix this. >> >> Signed-off-by: Eelco Chaudron >> Acked

Re: [ovs-dev] [PATCH v8 03/15] test: Do not use MPLS implicit null label in test cases.

On 26 Jan 2023, at 21:15, Ilya Maximets wrote: > On 1/24/23 13:47, Eelco Chaudron wrote: >> TC flower does not allow the push of the implicit null labels (RFC3032). >> Avoid the use of such labels in the MPLS test cases. > > Do they cause test failures or OVS just fal

Re: [ovs-dev] [PATCH v8 02/15] tests: Include working system-traffic tests into the system-offloads-testsuite.

On 26 Jan 2023, at 21:10, Ilya Maximets wrote: > On 1/24/23 13:45, Eelco Chaudron wrote: >> Include and run the system-traffic.at tests as part of the system offload >> testsuite. Exclude all the tests that will not run without any special >> modifications. >> >&

Re: [ovs-dev] [PATCH] netdev-offload-tc: del ufid mapping if device not exist

CHECK_EXEC([at_ns0], [ping -q -c 2 -i 0.2 10.1.1.3 | FORMAT_PING], [0], > [dnl > +2 packets transmitted, 2 received, 0% packet loss, time 0ms > +]) > + > +sleep 12 > +AT_CHECK([test $(ovs-appctl dpctl/dump-flows | grep -c "eth_type(0x0800)") > -eq 0], [0], [ignore]) > + >

[ovs-dev] [PATCH v2] tc: Add TCA_KIND flower to delete and get operation to avoid rtnl_lock().

is queried for unlocked support. Fixes: f98e418fbdb6 ("tc: Add tc flower functions") Signed-off-by: Eelco Chaudron --- lib/netdev-linux.c |2 +- lib/netdev-offload-tc.c | 20 ++-- lib/tc.c| 10 +- lib/tc.h|3 ++- 4 files ch

Re: [ovs-dev] [PATCH] tc: Add TCA_KIND flower to delete and get operation to avoid rtnl_lock().

On 27 Jan 2023, at 11:36, Ilya Maximets wrote: > On 1/26/23 13:33, Marcelo Ricardo Leitner wrote: >> On Thu, Jan 26, 2023 at 04:23:39AM -0800, Marcelo Ricardo Leitner wrote: >>> +Cc Chris, Paul and Vlad. >>> >>> On Thu, Jan 26, 2023 at 11:08:02AM +0100, Ee

Re: [ovs-dev] [PATCH v8 00/15] tests: Add system-traffic.at tests to check-offloads.

On 26 Jan 2023, at 17:52, Simon Horman wrote: > On Tue, Jan 24, 2023 at 01:42:57PM +0100, Eelco Chaudron wrote: >> This series makes it possible to include system-traffic.at tests into >> "make check-offloads" tests. >> >> The last patch of the series expla

Re: [ovs-dev] [PATCH v8 14/15] tests: Fix reading of OpenFlow byte counters in GRE test cases.

On 26 Jan 2023, at 17:58, Simon Horman wrote: > On Tue, Jan 24, 2023 at 02:01:19PM +0100, Eelco Chaudron wrote: >> With some datapaths, read TC, it takes a bit longer to update the >> OpenFlow statistics. Rather than adding an additional delay, try >> to read the counters

[ovs-dev] [PATCH] tc: Add TCA_KIND flower to delete and get operation to avoid rtnl_lock().

A long long time ago, an effort was made to make tc flower rtnl_lock() free. However, on the OVS part we forgot to add the TCA_KIND "flower" attribute, which tell the kernel to skip the lock. This patch corrects this by adding the attribute for the delete and get operations. Signed-off

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix misaligned access to ct label.

; support") > Signed-off-by: Ilya Maximets The changes look good to me. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v8 15/15] tests: Comment currently failing TC system-traffic tests.

put to gre tunnel by simulated packets Some other test cases also fail due to what looks like problems in the tc kernel conntrack implementation. For details see the details in the system-offloads.at exclusion list definition. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system-o

[ovs-dev] [PATCH v8 14/15] tests: Fix reading of OpenFlow byte counters in GRE test cases.

With some datapaths, read TC, it takes a bit longer to update the OpenFlow statistics. Rather than adding an additional delay, try to read the counters multiple times until we get the desired value. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system-offloads.at |2 -- tests

[ovs-dev] [PATCH v8 13/15] netdev-offload-tc: If the flow has not been used, report it as such.

If a tc flow was installed but has not yet been used, report it as such. In addition, add a delay to the "IGMP - flood under normal action" test case to make it work with many repetitions. This delay is also present in other ICMP/IGMP tests. Signed-off-by: Eelco Chaudron Acked-by:

[ovs-dev] [PATCH v8 12/15] odp-util: Make odp_flow_key_from_flow__ nlattr order the same as the kernel.

Make the order of the Netlink attributes for odp_flow_key_from_flow__() the same as the kernel will return them. This will make sure the attributes displayed in the dpctl/dump-flows output appear in the same order for all datapath. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- lib/odp

[ovs-dev] [PATCH v8 11/15] test: Fix 'conntrack - Multiple ICMP traverse' for tc case.

tc does not include ethernet header length in packet byte count. This fix will allow the packets that go trough tc to be 14 bytes less. This difference in the TC implementation is already described in tc-offload.rst. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system

[ovs-dev] [PATCH v8 10/15] test: tc does not support conntrack timeout, skip the related test.

The tc conntrack implementation does not support the timeout option. The current implementation is silently ignoring the timeout option by adding a general conntrack entry. This patch will skip the related test by overriding the support macro. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan

[ovs-dev] [PATCH v8 09/15] netdev-offload-tc: Conntrack ALGs are not supported with tc.

, and it will not invoke the ALG helper. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- Documentation/howto/tc-offload.rst | 11 +++ lib/netdev-offload-tc.c|4 tests/system-offloads.at | 27 +++ 3 files changed, 22 insertions(+), 20

[ovs-dev] [PATCH v8 08/15] test: Flush datapath when changing rules on the fly.

Flush datapath flows as TC flows take some more time to be flushed out. The flush speeds this up. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system-offloads.at |2 -- tests/system-traffic.at |6 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [PATCH v8 07/15] test: Fix "conntrack - floating IP" test for TC.

This change fixes the "conntrack - floating" test for the TC offload case. In this scenario, the connection might move to CLOSE_WAIT, which would fail the test as it only accepts TIME_WAIT. However, both indicate the connection was established, so the test should pass. Signed-off

[ovs-dev] [PATCH v8 06/15] tests: Add delay to dump-conntrack for tc test cases.

This patch adds a delay before dumping the conntrack table because with tc it takes a bit longer before it gets synced. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system-common-macros.at |3 + tests/system-offloads.at | 25 + tests/system-traffic.at | 199

[ovs-dev] [PATCH v8 05/15] netdev-offload-tc: Fix tc conntrack force commit support.

tc was not setting the OVS_CT_ATTR_FORCE_COMMIT flag when a forced commit was requested. This patch will fix this. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- lib/netdev-offload-tc.c | 13 +++-- tests/system-offloads.at |1 - 2 files changed, 11 insertions(+), 3

[ovs-dev] [PATCH v8 04/15] test: Add delay on revalidator flush for offload test cases.

the revalidator/purge command, which can be overwritten when the system tests are run on a tc enabled datapath. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system-common-macros.at |4 tests/system-offloads.at |8 +++- tests/system-traffic.at | 38

[ovs-dev] [PATCH v8 03/15] test: Do not use MPLS implicit null label in test cases.

TC flower does not allow the push of the implicit null labels (RFC3032). Avoid the use of such labels in the MPLS test cases. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system-offloads.at |2 -- tests/system-traffic.at |8 2 files changed, 4 insertions(+), 6

[ovs-dev] [PATCH v8 02/15] tests: Include working system-traffic tests into the system-offloads-testsuite.

Include and run the system-traffic.at tests as part of the system offload testsuite. Exclude all the tests that will not run without any special modifications. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/automake.mk |1 tests/system-offloads-testsuite.at

[ovs-dev] [PATCH v8 01/15] tests: Allow system-traffic tests to be skipped based on a list.

When the test description is part of the OVS_TEST_SKIP_LIST variable, the test is skipped. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/ofproto-macros.at |5 - tests/ovs-macros.at |7 +++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/tests

Re: [ovs-dev] [PATCH v7 00/15] tests: Add system-traffic.at tests to check-offloads.

On 24 Jan 2023, at 10:07, Eelco Chaudron wrote: > This series makes it possible to include system-traffic.at tests into > "make check-offloads" tests. > > The last patch of the series explains which tests are still not passing > and might need some more w

[ovs-dev] [PATCH v8 00/15] tests: Add system-traffic.at tests to check-offloads.

- Re-based to the latest ovs master branch - Added Roi's ACKs Eelco Chaudron (15): tests: Allow system-traffic tests to be skipped based on a list. tests: Include working system-traffic tests into the system-offloads-testsuite. test: Do not use MPLS implicit null label in

[ovs-dev] [PATCH v7 14/15] tests: Fix reading of OpenFlow byte counters in GRE test cases.

With some datapaths, read TC, it takes a bit longer to update the OpenFlow statistics. Rather than adding an additional delay, try to read the counters multiple times until we get the desired value. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system-offloads.at |2 -- tests

[ovs-dev] [PATCH v7 15/15] tests: Comment currently failing TC system-traffic tests.

put to gre tunnel by simulated packets Some other test cases also fail due to what looks like problems in the tc kernel conntrack implementation. For details see the details in the system-offloads.at exclusion list definition. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system-o

[ovs-dev] [PATCH v7 13/15] netdev-offload-tc: If the flow has not been used, report it as such.

If a tc flow was installed but has not yet been used, report it as such. In addition, add a delay to the "IGMP - flood under normal action" test case to make it work with many repetitions. This delay is also present in other ICMP/IGMP tests. Signed-off-by: Eelco Chaudron Acked-by:

[ovs-dev] [PATCH v7 12/15] odp-util: Make odp_flow_key_from_flow__ nlattr order the same as the kernel.

Make the order of the Netlink attributes for odp_flow_key_from_flow__() the same as the kernel will return them. This will make sure the attributes displayed in the dpctl/dump-flows output appear in the same order for all datapath. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- lib/odp

[ovs-dev] [PATCH v7 11/15] test: Fix 'conntrack - Multiple ICMP traverse' for tc case.

tc does not include ethernet header length in packet byte count. This fix will allow the packets that go trough tc to be 14 bytes less. This difference in the TC implementation is already described in tc-offload.rst. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system

[ovs-dev] [PATCH v7 10/15] test: tc does not support conntrack timeout, skip the related test.

The tc conntrack implementation does not support the timeout option. The current implementation is silently ignoring the timeout option by adding a general conntrack entry. This patch will skip the related test by overriding the support macro. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan

[ovs-dev] [PATCH v7 09/15] netdev-offload-tc: Conntrack ALGs are not supported with tc.

, and it will not invoke the ALG helper. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- Documentation/howto/tc-offload.rst | 11 +++ lib/netdev-offload-tc.c|4 tests/system-offloads.at | 27 +++ 3 files changed, 22 insertions(+), 20

[ovs-dev] [PATCH v7 08/15] test: Flush datapath when changing rules on the fly.

Flush datapath flows as TC flows take some more time to be flushed out. The flush speeds this up. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system-offloads.at |2 -- tests/system-traffic.at |6 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [PATCH v7 07/15] test: Fix "conntrack - floating IP" test for TC.

This change fixes the "conntrack - floating" test for the TC offload case. In this scenario, the connection might move to CLOSE_WAIT, which would fail the test as it only accepts TIME_WAIT. However, both indicate the connection was established, so the test should pass. Signed-off

[ovs-dev] [PATCH v7 06/15] tests: Add delay to dump-conntrack for tc test cases.

This patch adds a delay before dumping the conntrack table because with tc it takes a bit longer before it gets synced. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system-common-macros.at |3 + tests/system-offloads.at | 25 + tests/system-traffic.at | 198

[ovs-dev] [PATCH v7 05/15] netdev-offload-tc: Fix tc conntrack force commit support.

tc was not setting the OVS_CT_ATTR_FORCE_COMMIT flag when a forced commit was requested. This patch will fix this. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- lib/netdev-offload-tc.c | 13 +++-- tests/system-offloads.at |1 - 2 files changed, 11 insertions(+), 3

[ovs-dev] [PATCH v7 04/15] test: Add delay on revalidator flush for offload test cases.

the revalidator/purge command, which can be overwritten when the system tests are run on a tc enabled datapath. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system-common-macros.at |4 tests/system-offloads.at |8 +++- tests/system-traffic.at | 38

[ovs-dev] [PATCH v7 03/15] test: Do not use MPLS implicit null label in test cases.

TC flower does not allow the push of the implicit null labels (RFC3032). Avoid the use of such labels in the MPLS test cases. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/system-offloads.at |2 -- tests/system-traffic.at |8 2 files changed, 4 insertions(+), 6

[ovs-dev] [PATCH v7 02/15] tests: Include working system-traffic tests into the system-offloads-testsuite.

Include and run the system-traffic.at tests as part of the system offload testsuite. Exclude all the tests that will not run without any special modifications. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/automake.mk |1 tests/system-offloads-testsuite.at

[ovs-dev] [PATCH v7 01/15] tests: Allow system-traffic tests to be skipped based on a list.

When the test description is part of the OVS_TEST_SKIP_LIST variable, the test is skipped. Signed-off-by: Eelco Chaudron Acked-by: Roi Dayan --- tests/ofproto-macros.at |5 - tests/ovs-macros.at |7 +++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/tests

[ovs-dev] [PATCH v7 00/15] tests: Add system-traffic.at tests to check-offloads.

- Added Roi's ACKs Eelco Chaudron (15): tests: Allow system-traffic tests to be skipped based on a list. tests: Include working system-traffic tests into the system-offloads-testsuite. test: Do not use MPLS implicit null label in test cases. test: Add delay on revalid

Re: [ovs-dev] [PATCH v6 09/15] netdev-offload-tc: Conntrack ALGs are not supported with tc.

On 24 Jan 2023, at 7:39, Roi Dayan wrote: > On 13/12/2022 17:35, Eelco Chaudron wrote: >> tc does not support conntrack ALGs. Even worse, with tc enabled, they >> should not be used/configured at all. This is because even though TC >> will ignore the rules wit

Re: [ovs-dev] [PATCH] [ovs-dev v5] dpctl: Add support to count upcall packets

y: wangchuanlei > --- Thanks for keeping up with all the revisions! The changes look good to me and seem to be working. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] tests/mfex: Silence Blowfish/CAST5 deprecation warnings.

by: Robin Jarry > Signed-off-by: David Marchand Tested on my recently upgraded build server, and the problem disappears ;) The changes look good to me. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v7] utilities: Add revalidator measurement script and needed USDT probes.

On 23 Jan 2023, at 11:32, Simon Horman wrote: > On Mon, Jan 23, 2023 at 11:28:45AM +0100, Eelco Chaudron wrote: >> >> >> On 19 Jan 2023, at 11:38, Simon Horman wrote: >> >>> On Tue, Jan 17, 2023 at 10:19:23AM +0100, Eelco Chaudron wrote: >>>>

[ovs-dev] [PATCH v8] utilities: Add revalidator measurement script and needed USDT probes.

and how this tool can help you understand what is happening in your system. https://developers.redhat.com/articles/2022/10/19/open-vswitch-revalidator-process-explained Signed-off-by: Eelco Chaudron Acked-by: Adrian Moreno Acked-by: Simon Horman --- v2: Added note that script only works

Re: [ovs-dev] [PATCH v7] utilities: Add revalidator measurement script and needed USDT probes.

On 19 Jan 2023, at 11:38, Simon Horman wrote: > On Tue, Jan 17, 2023 at 10:19:23AM +0100, Eelco Chaudron wrote: >> This patch adds a Python script that can be used to analyze the >> revalidator runs by providing statistics (including some real time >> graphs). >>

Re: [ovs-dev] [PATCH 1/1] daemon-unix: Support OVS-DPDK HW offloads for non-root user

On 22 Mar 2021, at 15:21, David Marchand wrote: > Hello Gaëtan, > > On Fri, Mar 19, 2021 at 5:59 PM Gaetan Rivet wrote: >> Our rte_flow implementation uses ICM mappings to program our hardware, >> which requires super privileged access. We are looking into ways to avoid it. > > Ok, thanks for

Re: [ovs-dev] [PATCH] netdev-offload-tc: del ufid mapping if device not exist

On 12 Jan 2023, at 7:55, Faicker Mo wrote: > The device may be deleted and added with ifindex changed. > The tc rules on the device will be deleted if the device is deleted. > The func tc_del_filter will fail when flow del. The mapping of > ufid to tc will not be deleted. > The traffic will

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-upcall.c: Add counters for reasons of DP flow deletions.

On 17 Jan 2023, at 4:11, Han Zhou wrote: > On Mon, Jan 16, 2023 at 7:36 AM Eelco Chaudron wrote: >> >> >> >> On 18 Oct 2022, at 18:11, Adrian Moreno wrote: >> >>> On 10/14/22 20:07, Han Zhou wrote: >>>> >>>> >>>&g

Re: [ovs-dev] [PATCH 1/2] Revalidator: Allow min-revalidator-pps to be 0 (disabled).

On 17 Jan 2023, at 4:08, Han Zhou wrote: > On Mon, Jan 16, 2023 at 7:14 AM Eelco Chaudron wrote: >> >> >> >> On 18 Oct 2022, at 18:08, Adrian Moreno wrote: >> >>> On 10/14/22 19:49, Han Zhou wrote: >>>> >>>> >>>&g

Re: [ovs-dev] [PATCH v2] Revalidator: Allow min-revalidator-pps to be 0.

tapath flows to be revalidated, > resulting in higher CPU cost of revalidator threads. This is the > downside but in certain cases this is still more desirable than packet > misses to user space. > > Signed-off-by: Han Zhou Thanks for addressing the

[ovs-dev] [PATCH v7] utilities: Add revalidator measurement script and needed USDT probes.

and how this tool can help you understand what is happening in your system. https://developers.redhat.com/articles/2022/10/19/open-vswitch-revalidator-process-explained Signed-off-by: Eelco Chaudron --- v2: Added note that script only works a with single datapath configured. v3: Updated patch

Re: [ovs-dev] [PATCH v6] utilities: Add revalidator measurement script and needed USDT probes.

On 13 Jan 2023, at 10:22, Adrian Moreno wrote: > On 1/2/23 16:30, Eelco Chaudron wrote: >> This patch adds a Python script that can be used to analyze the >> revalidator runs by providing statistics (including some real time >> graphs). >> >> The USDT even

Re: [ovs-dev] OVS "soft freeze" for 3.1 is in effect.

On 16 Jan 2023, at 14:05, Ilya Maximets wrote: > On 1/12/23 20:38, Dumitru Ceara wrote: >> On 1/12/23 19:13, Han Zhou wrote: >>> On Mon, Jan 2, 2023 at 3:08 PM Ilya Maximets wrote: Hi. As described in Documentation/internals/release-process.rst, we are in a "soft freeze" state:

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-upcall.c: Add counters for reasons of DP flow deletions.

On 18 Oct 2022, at 18:11, Adrian Moreno wrote: > On 10/14/22 20:07, Han Zhou wrote: >> >> >> On Thu, Oct 13, 2022 at 11:51 PM Adrian Moreno > > wrote: >>> >>> >>> >>> On 8/9/22 03:41, Han Zhou wrote: Signed-off-by: Han Zhou mailto:hz...@ovn.org>> ---  

Re: [ovs-dev] [PATCH 1/2] Revalidator: Allow min-revalidator-pps to be 0 (disabled).

On 18 Oct 2022, at 18:08, Adrian Moreno wrote: > On 10/14/22 19:49, Han Zhou wrote: >> >> >> On Thu, Oct 13, 2022 at 11:43 PM Adrian Moreno > > wrote: >>> >>> Hi Han. >>> >>> On 8/9/22 03:40, Han Zhou wrote: Today the minimum value for this setting is 1. This

[ovs-dev] [PATCH v3] netdev-offload-tc: Preserve tc statistics when flow gets modified.

implementation. It also updates the check_pkt_len tc test to purge the flows, so we do not use updated tc flows, with their counters. Signed-off-by: Eelco Chaudron --- -v2: Do not update the stats->used, as in terse dump they should be 0. -v3: Added some comments based on the v2 review. Please n

Re: [ovs-dev] [PATCH v2] netdev-offload-tc: Preserve tc statistics when flow gets modified.

On 12 Jan 2023, at 18:29, Michael Santana wrote: > On 12/15/22 09:52, Eelco Chaudron wrote: >> When a flow gets modified, i.e. the actions are changes, the tc layer will >> remove, and re-add the flow. This is causing all the counters to be reset. >> >> This patch wi

Re: [ovs-dev] Support for offloading only the exact match fields/flows in OVS

On 10 Jan 2023, at 12:16, Farhan Tariq wrote: > Hi OVS family, > > I have been working on offloading only the exact-match flows in case of > disable-megaflows. We observed that when the megaflows are disabled and we > add a rule without any mask for any match field, then mf_set_value()

Re: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Wait for valid hw flow stats before applying min-revalidate-pps

On 5 Jan 2023, at 14:39, Eelco Chaudron wrote: >>> I'm not saying that we don't have issue with statistics. We do have >>> 2 separate issues here - dump duration and statistics update frequency. >>> Just trying to figure out which is a primary and which is

Re: [ovs-dev] [PATCH branch-2.17] tc: Add support for TCA_STATS_PKT64

er functions") > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1776816 > Signed-off-by: Mike Pattrick Changes look good to me! Thanks for back porting to 2.17. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org htt

[ovs-dev] [PATCH] system-dpdk: Fix error message in ping vhost-user ports.

. This patch will wait for the socket disconnect to be handled by the vhost-user before shutting down OVS. Signed-off-by: Eelco Chaudron Signed-off-by: David Marchand Co-authored-by: David Marchand --- v2: Used sync point rather than ignoring the messages. tests/system-dpdk.at |3 +++ 1

Re: [ovs-dev] [PATCH] [ovs-dev v4] dpctl: Add support to count upcall packets

On 6 Jan 2023, at 11:37, Ilya Maximets wrote: > On 1/6/23 11:12, Eelco Chaudron wrote: >> >> >> On 6 Jan 2023, at 10:49, wangchuanlei wrote: >> >>>> On 1/5/23 16:40, Eelco Chaudron wrote: >>>>> >>>>> >>>>>

Re: [ovs-dev] [PATCH v9] tc: Add support for TCA_STATS_PKT64

rrent master > Since v4: > - Fixed alignment issue > - Moved declarations and definitions > Since v5: > -Aesthetic changes > Since v6: > -Aesthetic changes introduced a compilation issue on some compilers > Since v7: > -Coding standards > Since v8: > -Fixed UBSan issues Re

Re: [ovs-dev] [PATCH] [ovs-dev v4] dpctl: Add support to count upcall packets

On 6 Jan 2023, at 10:49, wangchuanlei wrote: >> On 1/5/23 16:40, Eelco Chaudron wrote: >>> >>> >>> On 5 Jan 2023, at 2:52, wangchuanlei wrote: >>> >>>> Add support to count upall packets, when kmod of openvswitch upcall >>>> t

<    5   6   7   8   9   10   11   12   13   14   >