correctly? Why is it different from your
observation earlier (is it because of the max bandwidth of the test env)?
Does it suggest that a simple timeout mechanism is not suitable?
Thanks,
Han
> Regards,
> Ales
>
> [0] https://bugzilla.redhat.com/show_bug.cgi?id=2084668#c6
>
>
On Fri, Jul 8, 2022 at 2:39 AM Ales Musil wrote:
>
> The ovn-controller had a race condition over MAC
> binding table with other controllers. When multiple
> controllers received GARP from single source usually
> the one who was able to win the race put it into SB.
> The others got transaction err
On Thu, Jul 7, 2022 at 8:55 AM Dumitru Ceara wrote:
>
> On 7/7/22 13:45, Dumitru Ceara wrote:
> > On 7/7/22 00:08, Han Zhou wrote:
> >> On Wed, Jul 6, 2022 at 8:45 AM Dumitru Ceara wrote:
> >>>
> >>> Hi Han,
> >>>
> >>> On 7/6
On Wed, Jun 22, 2022 at 3:23 AM Xavier Simonart wrote:
>
> When VIF ports are claimed on a chassis, SBDB Port_Binding table is
updated.
> If the SBDB IDL is still is read-only ("in transaction") when such a
update
> is required, the update is not possible and recompute is triggered through
> I+P f
On Wed, Jul 6, 2022 at 8:45 AM Dumitru Ceara wrote:
>
> Hi Han,
>
> On 7/6/22 00:41, Han Zhou wrote:
> > The ls_in_pre_stateful priority 120 flow that saves dst IP and Port to
> > registers is causing a critical dataplane performance impact to
> > short-lived conne
Add the option for deployments that do not require multiple LB VIPs
sharing same backends for hairpin traffic, so that they can set this
to false to be able to better utilize HW offload capabilities.
Signed-off-by: Han Zhou
---
controller/lflow.c | 46
raffic for VIPs with shared
backends.")
[1] 0038579d1928 ("northd: Optimize ct nat for load balancer traffic.")
Signed-off-by: Han Zhou
---
controller/lflow.c | 74 ++--
include/ovn/logical-fields.h | 5 -
lib/lb.c | 3 -
lib/lb.h
hange.
This patch also adjust the order of adding tracked and untracked columns
to monitoring, to workaround a problem in OVS IDL that could end up
overwriting the track flag. A XXX comment is added for future
improvement.
Signed-off-by: Han Zhou
---
controller/ovn-controller.c
icant enough to affect the
throughput for this comparison. I wonder if there are more obvious
differences if tested with a higher bandwidth environment, e.g. with 10G,
25G or even higher line rate. I will find some time to test this in our
data center environment.
On the other hand, as mentioned in
On Wed, Jun 29, 2022 at 1:37 AM Dumitru Ceara wrote:
>
> On 6/28/22 19:18, Han Zhou wrote:
> > On Tue, Jun 28, 2022 at 8:20 AM Dumitru Ceara wrote:
> >>
> >> On 6/28/22 02:49, Han Zhou wrote:
> >>> When ovn-controller is restarted, it may need mul
On Tue, Jun 28, 2022 at 8:20 AM Dumitru Ceara wrote:
>
> On 6/28/22 02:49, Han Zhou wrote:
> > When ovn-controller is restarted, it may need multiple iterations of
> > main loop before completely download all related data from SB DB,
> > especially when ovn-monitor-all
that leaving the unused ports on the chassis for little longer is not
harmful.
Signed-off-by: Han Zhou
---
controller/patch.c | 15 -
tests/ovn-controller.at | 71 +
2 files changed, 85 insertions(+), 1 deletion(-)
diff --git a/controller/patc
On Fri, Jun 24, 2022 at 12:41 PM Numan Siddique wrote:
>
> On Fri, Jun 24, 2022 at 11:49 AM Han Zhou wrote:
> >
> > On Fri, Jun 24, 2022 at 1:11 AM Ales Musil wrote:
> > >
> > > Hi Han,
> > >
> > > after our discussion I did he suggested te
gt;
> Thanks,
> Ales
>
> On Wed, Jun 22, 2022 at 9:51 AM Ales Musil wrote:
>>
>>
>>
>> On Wed, Jun 22, 2022 at 9:21 AM Han Zhou wrote:
>>>
>>>
>>>
>>> On Fri, Jun 17, 2022 at 2:08 AM Ales Musil wrote:
>>> >
&
On Wed, Jun 22, 2022 at 12:51 AM Ales Musil wrote:
>
>
>
> On Wed, Jun 22, 2022 at 9:21 AM Han Zhou wrote:
>>
>>
>>
>> On Fri, Jun 17, 2022 at 2:08 AM Ales Musil wrote:
>> >
>> > Add MAC binding aging mechanism, that
>> > should ta
On Fri, Jun 17, 2022 at 2:08 AM Ales Musil wrote:
>
> Add MAC binding aging mechanism, that
> should take care of stale MAC bindings.
>
> The mechanism works on "ownership" of the
> MAC binding row. The chassis that creates
> the row is then checking if the "idle_age"
> of the flow is over the agi
> > > > > > +static void
> > > > > > > > +run_activated_ports(struct ovsdb_idl_txn *ovnsb_idl_txn,
> > > > > > > > +struct ovsdb_idl_i
On Mon, Jun 13, 2022 at 6:07 PM Ihar Hrachyshka wrote:
>
> On Mon, Jun 13, 2022 at 6:30 PM Han Zhou wrote:
> >
> >
> >
> > On Mon, Jun 13, 2022 at 11:41 AM Ihar Hrachyshka
wrote:
> > >
> > > When options:activation-strategy is set to "rarp&q
ST_FOR_EACH (pp, list, &ports_to_activate_in_db) {
> +if (pp->dp_key == dp_key && pp->port_key == port_key) {
> +ovs_mutex_unlock(&pinctrl_mutex);
> +return true;
> +}
> +}
> +LIST_FOR_EACH (pp, list, ports_to_activat
On Mon, Jun 13, 2022 at 11:40 AM Ihar Hrachyshka
wrote:
>
> On Thu, Jun 9, 2022 at 3:01 AM Han Zhou wrote:
> >
> >
> >
> > On Tue, Jun 7, 2022 at 7:06 PM Ihar Hrachyshka
wrote:
> > >
> > > When options:activation-strategy is set to "rarp&q
+212,9 @@ If \fB@\fIname\fR is specified, then the UUID for the
new row may be
> referred to by that name elsewhere in the same \fB\*(PN\fR
> invocation in contexts where a UUID is expected. Such references may
> precede or follow the \fBcreate\fR command.
> +.IP
> +If a valid \fB@\fIuuid\fR is specified, then it is used as the UUID
> +of the new row.
A typo here: \fB@ should be removed.
I didn't find any test for this option --id . I think a simple test
with ovs-vsctl should be good.
With the above minor comment addressed:
Acked-by: Han Zhou
(sorry for the slow response)
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
42be (northd: Add support for NAT with multiple DGP).
>
> This patch updates the behavior by inferring the DGP where the NAT
> rule needs to be applied based on the "external_ip" column of the
> NAT rule when "gateway_port" column is not set.
>
> Signed-off-b
On Tue, Jun 7, 2022 at 7:06 PM Ihar Hrachyshka wrote:
>
> When options:activation-strategy is set to "rarp" for LSP, when used in
> combination with multiple chassis names listed in
> options:requested-chassis, additional chassis will install special flows
> that would block all ingress and egress
crete use cases/scenarios)
In the case of OVN LB, I don't see a reason why it would miss the cache
except for the first packets. Adding an extra eBPF/XDP stage on top of the
OVS cached pipeline doesn't seem to improve the performance.
> > On Wed, 8 Jun 2022 at 14:43, Han Zho
On Mon, May 30, 2022 at 5:46 PM wrote:
>
> From: Numan Siddique
>
> XDP program - ovn_xdp.c added in this RFC patch series implements basic
port
> security and drops any packet if the port security check fails.
> There are still few TODOs in the port security checks. Like
> - Make ovn xdp
On Tue, Jun 7, 2022 at 8:20 AM Dumitru Ceara wrote:
>
> In large scale scenarios this option hugely reduces the size of the
> Southbound database positively affecting end to end performance. In
> such scenarios there's no real reason to ever disable datapath groups.
>
> In lower scale scenarios a
On Fri, Jun 3, 2022 at 1:20 PM Ihar Hrachyshka wrote:
>
> When options:activation-strategy is set to "rarp" for LSP, when used in
> combination with multiple chassis names listed in
> options:requested-chassis, additional chassis will install special flows
> that would block all ingress and egress
On Thu, Jun 2, 2022 at 11:39 AM Dumitru Ceara wrote:
>
> On 6/2/22 19:22, Han Zhou wrote:
> > On Thu, Jun 2, 2022 at 10:09 AM Mark Michelson
wrote:
> >>
> >> On 6/2/22 11:22, Dumitru Ceara wrote:
> >>> Change the way ovn-controller decides whether
asked access
to ct_label: the push/pop actions support in ovn-controller. But I think
there is no need to add another feature name for that, because the
ct-lb-mark and ct-masked-mark would already cover that dependency, because
they are changed together in the same minor version. So instead I
On Thu, Jun 2, 2022 at 10:09 AM Mark Michelson wrote:
>
> On 6/2/22 11:22, Dumitru Ceara wrote:
> > Change the way ovn-controller decides whether it should match on
> > ct_mark.natted or ct_label.natted for hairpin load balancer traffic.
> > Until now this was done solely based on the northd-repor
On Thu, Jun 2, 2022 at 7:43 AM Dumitru Ceara wrote:
>
> On 6/2/22 16:35, Han Zhou wrote:
> > On Thu, Jun 2, 2022 at 5:07 AM Dumitru Ceara wrote:
> >>
> >> On 6/2/22 04:08, Han Zhou wrote:
> >>> On Wed, Jun 1, 2022 at 11:44 AM Mark Michelson
>
On Thu, Jun 2, 2022 at 5:07 AM Dumitru Ceara wrote:
>
> On 6/2/22 04:08, Han Zhou wrote:
> > On Wed, Jun 1, 2022 at 11:44 AM Mark Michelson
wrote:
> >>
> >> On 6/1/22 13:44, Numan Siddique wrote:
> >>> On Wed, Jun 1, 2022 at 12:52 PM Mark Michelson
>
On Wed, Jun 1, 2022 at 11:44 AM Mark Michelson wrote:
>
> On 6/1/22 13:44, Numan Siddique wrote:
> > On Wed, Jun 1, 2022 at 12:52 PM Mark Michelson
wrote:
> >>
> >> Thanks Dumitru. This looks good to me.
> >>
> >> Acked-by: Mark Michelson
> >
> > Thanks Dumitru.
> > I applied this patch to main
gt; ---
>
> Version 2:
> - Updated the commit mesage clarifying the word 'completed'. [Han]
> - Dropped the log reset part since it's not really necessary
> and a bit misleading. [Han]
>
Thanks Ilya!
Acked-by: Han Zhou
> ovsdb/raft.c | 133 +++
: this paragraph can be ignored because "log-related" is not in this
branch yet when this patch is backported here)
Thanks,
Han
> Han Zhou (6):
> ovn-sb.xml: Fix ct_lb documentation.
> actions: Add action ct_lb_mark.
> actions: Add stack push and pop actions
On Mon, May 23, 2022 at 12:39 PM Dumitru Ceara wrote:
>
> From: Han Zhou
>
> Add an engine node en_northd_internal_version as an input to
> en_lflow_output. When this node is updated, it triggers a recompute for
> en_lflow_output. This node adds SB_Global as its only input, a
On Tue, Mar 29, 2022 at 3:06 PM Han Zhou wrote:
>
>
>
> On Tue, Mar 29, 2022 at 2:20 PM Numan Siddique wrote:
> >
> > On Mon, Mar 28, 2022 at 1:40 AM Han Zhou wrote:
> > >
> > > Some NICs support HW offloading for datapath flows, but masked access
to
&g
Thanks Ilya for addressing this problem! Please see some comments below:
On Thu, May 5, 2022 at 5:24 AM Ilya Maximets wrote:
>
> While becoming a follower, the leader completes all the current
nit: The word "completes" here may be a little confusing. We are talking
about complete with error instea
On Tue, May 17, 2022 at 2:41 AM Xavier Simonart wrote:
>
> Hi Han
> Thanks for looking into this and for your feedback.
> Please see comments below
>
> On Tue, May 17, 2022 at 8:03 AM Han Zhou wrote:
>>
>>
>>
>> On Thu, May 12, 2022 at 2:04 AM Xavier Sim
On Thu, May 12, 2022 at 2:04 AM Xavier Simonart wrote:
>
> When VIF ports are claimed on a chassis, SBDB Port_Binding table is
updated.
> If the SBDB IDL is still is read-only ("in transaction") when such a
update
> is required, the update is not possible and recompute is triggered through
> I+P f
On Thu, May 5, 2022 at 6:38 AM Ihar Hrachyshka wrote:
>
> When options:activation-strategy is set to "rarp" for LSP, when used in
> combination with multiple chassis names listed in
> options:requested-chassis, additional chassis will install special flows
> that would block all ingress and egress
On Thu, May 5, 2022 at 6:38 AM Ihar Hrachyshka wrote:
>
> When multiple chassis are set in requested-chassis, port binding is
> configured in multiple cluster locations. In case of live migration
> scenario, only one of the locations run a workload at a particular
> point in time. Yet, it's expect
On Thu, May 12, 2022 at 9:32 AM Dumitru Ceara wrote:
>
> On 5/12/22 10:58, Dumitru Ceara wrote:
> > On 5/3/22 21:37, Han Zhou wrote:
> >> During the process of claiming a VIF port on a chassis, there are
> >> multiple SB and local OVSDB updates by ovn-controll
On Thu, May 5, 2022 at 6:38 AM Ihar Hrachyshka wrote:
>
> When the option is set to a comma separated list of chassis names, OVN
> will attempt to bind the port at any number of other locations in
> addition to the main chassis.
>
> This is useful in live migration scenarios where it's important t
On Thu, May 5, 2022 at 6:38 AM Ihar Hrachyshka wrote:
>
> In a future patch, there will be a scenario where the same port has
> attachments at multiple (specifically, 2) chassis, so make sure that
> 'up' property is updated by the main chassis only.
>
> Signed-off-by: Ihar Hrachyshka
> ---
> con
or = ofpacts_pull_openflow_actions(userdata,
userdata->size,
>version, NULL,
NULL,
>&ofpacts);
> --
> 2.34.1
>
> ___
> dev mailing
roject/ovn/patch/20220401101640.1139426-1-xsimo...@redhat.com/
>> , and I'd also like confirmation that this approach doesn't incur the
>> delays that Dumitru mentioned on Xavier's patch.
>>
>> With those confirmations, I'll add my ack to this patch.
>&
On Wed, May 4, 2022 at 9:05 AM Venugopal Iyer wrote:
>
> Changes look good to me Han.
>
> thanks!
>
> -venu
>
Thanks Venu. I merged to main and backported to branch-22.03.
Han
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailma
On Wed, May 4, 2022 at 4:22 PM Han Zhou wrote:
>
>
>
> On Wed, May 4, 2022 at 3:44 PM Numan Siddique wrote:
> >
> > On Tue, May 3, 2022 at 7:32 PM Han Zhou wrote:
> > >
> > > On Thu, Apr 28, 2022 at 9:36 AM Dumitru Ceara
wrote:
On Wed, May 4, 2022 at 3:44 PM Numan Siddique wrote:
>
> On Tue, May 3, 2022 at 7:32 PM Han Zhou wrote:
> >
> > On Thu, Apr 28, 2022 at 9:36 AM Dumitru Ceara wrote:
> > >
> > > This uses the newly added ovsdb_idl_set_write_changed_only_all() to
> > >
On Thu, Apr 28, 2022 at 9:36 AM Dumitru Ceara wrote:
>
> This uses the newly added ovsdb_idl_set_write_changed_only_all() to
> explicitly disable atomicity checks for read/write columns and to enable
> optimizing the process of building the SB transaction.
>
> Bump OVS submodule to pick up d94cd0d
...@ovn.org
> * - Gurucharan Shetty
> - g...@ovn.org
> * - Han Zhou
> @@ -67,3 +65,5 @@ More information about Emeritus Committers can be found
>
> * - Name
> - Email
> + * - Ben Pfaff
> + - b...@ovn.org
> --
> 2.35.1
>
&
ace_claim(), so in the above scenarios the changes
don't need to be handled and won't trigger recompute any more. A test
case is also updated to capture this (which is very likely, if not 100%,
to fail without the fix).
Signed-off-by: Han Zhou
---
v2: Add comments that was miss
On Thu, Apr 14, 2022 at 4:06 AM Dumitru Ceara wrote:
>
> On 4/1/22 12:16, Xavier Simonart wrote:
> > Before this patch, when all flows for a port have been installed in OVS,
> > ovn-installed was immediately written to the OVS DB; the notification of
> > this change to the OVN controller (handled
ace_claim(), so in the above scenarios the changes
don't need to be handled and won't trigger recompute any more. A test
case is also updated to capture this (which is very likely, if not 100%,
to fail without the fix).
Signed-off-by: Han Zhou
---
controller/binding.c| 70 ++
83cd8 ("Support for multiple VTEP in OVN")
Cc: Venugopal Iyer
Signed-off-by: Han Zhou
---
controller/binding.c | 3 ++-
tests/ovn.at | 9 +
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/controller/binding.c b/controller/binding.c
index 7281b0485..e284704
nflict with flow-restore-wait, of course).
Thanks,
Han
>
> On Tue, 19 Apr 2022 at 03:23, Han Zhou wrote:
>>
>> Whenever OpenFlow connection between ovn-controller and OVS is
>> connected/reconnected, typically during ovn-controller/OVS
>> restart/upgrade, ovn-contro
On Mon, Apr 25, 2022 at 2:28 AM Dumitru Ceara wrote:
>
> On 4/22/22 20:38, Terry Wilson wrote:
> > On Wed, Apr 20, 2022 at 2:31 PM Dumitru Ceara wrote:
> >>
> >> At a first glance, change tracking should never be allowed for
> >> write-only columns. However, some clients (e.g., ovn-northd) that
this change).
>
> End-to-end ovn-kubernetes scale tests on 120-node clusters also show
> significant reduction of latency to bring up pods; both average and P99
> latency decreased by ~30%.
>
> Signed-off-by: Dumitru Ceara
Thanks Dumitru for the revision. I only have two minor
On Mon, Apr 25, 2022 at 11:31 AM Mark Michelson wrote:
>
> Acked-by: Mark Michelson
>
Thanks Mark for the reviews. I applied the series to main.
Han
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
for most deployments.
>
> Acked-by: Mark Michelson
Thanks Mark.
>
> I have one comment down below.
>
> On 4/18/22 15:22, Han Zhou wrote:
> > Whenever OpenFlow connection between ovn-controller and OVS is
> > connected/reconnected, typically during ovn-controller/OV
On Tue, Apr 19, 2022 at 6:38 AM Dumitru Ceara wrote:
>
> This option changes how logical switch ACL related flows are generated
> such that the following behavior is ensured:
>
> a. If a logical switch has no ACL applied to it (either directly or
> indirectly via a port group) then traffic is alwa
On Tue, Apr 19, 2022 at 12:49 AM Dumitru Ceara wrote:
>
> On 4/16/22 00:41, Han Zhou wrote:
> > On Fri, Apr 15, 2022 at 1:45 PM Dumitru Ceara wrote:
> >>
> >> On 4/15/22 20:25, Han Zhou wrote:
> >>> On Fri, Apr 15, 2022 at 7:22 AM Dumitru Ceara
wrot
On Thu, Apr 7, 2022 at 6:15 PM Han Zhou wrote:
>
> I have some comment myself regarding the documentation:
>
> On Wed, Apr 6, 2022 at 4:36 PM Han Zhou wrote:
> >
> > Whenever OpenFlow connection between ovn-controller and OVS is
> > connected/reconnected, typic
being delayed.
Signed-off-by: Han Zhou
---
controller/ofctrl.c | 4
1 file changed, 4 insertions(+)
diff --git a/controller/ofctrl.c b/controller/ofctrl.c
index eb66d0348..9f9cd56ef 100644
--- a/controller/ofctrl.c
+++ b/controller/ofctrl.c
@@ -669,6 +669,10 @@ run_S_CLEAR_FLOWS(void
this patch, there were ~13 seconds ping failures during ovn-controller
restart.
With this patch, the ping failure reduced to ~6 seconds.
(The ~6 seconds down time was introduced by step 3 - install the new
flows to ovs, which will be addressed in future patches)
Signed-off-by: Han Zhou
---
controlle
there is no ping failure observed with 100ms interval
(ping -i 0.1).
Signed-off-by: Han Zhou
---
controller/ofctrl.c | 78 ++---
1 file changed, 46 insertions(+), 32 deletions(-)
diff --git a/controller/ofctrl.c b/controller/ofctrl.c
index 249bac140..496f
- delete meters
It is required for a future change that needs all operations in a
bundle. Ideally we should add meters to the bundle as well but it is not
supported yet by OVS.
Signed-off-by: Han Zhou
---
controller/ofctrl.c | 110
1 file changed, 61
the down time introduced
by step 2; patches 3 and 4 avoids the down time introduced by step 3.
A test shows zero ping loss (with 0.1s interval), while without the patches it
was 100% ping drops during ~13s.
Han Zhou (4):
ofctrl: Wakeup when entering S_UPDATE_FLOWS.
ofctrl: Support ovn-ofctrl
On Fri, Apr 15, 2022 at 1:45 PM Dumitru Ceara wrote:
>
> On 4/15/22 20:25, Han Zhou wrote:
> > On Fri, Apr 15, 2022 at 7:22 AM Dumitru Ceara wrote:
> >>
> >> At a first glance, change tracking should never be allowed for
> >> write-only columns. However, s
On Fri, Apr 15, 2022 at 7:22 AM Dumitru Ceara wrote:
>
> At a first glance, change tracking should never be allowed for
> write-only columns. However, some clients (e.g., ovn-northd) that are
> mostly exclusive writers of a database, use change tracking to avoid
> duplicating the IDL row records
On Wed, Apr 6, 2022 at 7:33 AM Dumitru Ceara wrote:
>
> This option changes how logical switch ACL related flows are generated
> such that the following behavior is ensured:
>
> a. If a logical switch has no ACL applied to it (either directly or
> indirectly via a port group) then traffic is alway
On Wed, Apr 13, 2022 at 8:48 AM Numan Siddique wrote:
>
> On Wed, Apr 13, 2022 at 2:34 AM Han Zhou wrote:
> >
> > During incremental flow processing, we track the OVS desired flow
> > changes so that we can incrementally install them to OVS. The function
> > merge_t
On Mon, Apr 11, 2022 at 2:05 PM Numan Siddique wrote:
>
> On Sat, Feb 5, 2022 at 12:12 AM Han Zhou wrote:
> >
> > On Fri, Feb 4, 2022 at 7:58 AM Mark Michelson
wrote:
> > >
> > > As far as I can tell, this looks correct.
> > >
> > > Acked-by
c: Merge opposite changes of tracked flows before
installing.")
Signed-off-by: Han Zhou
---
controller/ofctrl.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/controller/ofctrl.c b/controller/ofctrl.c
index 2d8a8ec9c..eb66d0348 100644
--- a/controll
I have some comment myself regarding the documentation:
On Wed, Apr 6, 2022 at 4:36 PM Han Zhou wrote:
>
> Whenever OpenFlow connection between ovn-controller and OVS is
> connected/reconnected, typically during ovn-controller/OVS
> restart/upgrade, ovn-controller would:
> 1.
On Tue, Apr 5, 2022 at 11:00 AM Mark Michelson wrote:
>
> Acked-by: Mark Michelson
>
Applied, thanks!
Han
> On 3/30/22 01:50, Han Zhou wrote:
> > The comment is misleading. The conjunctive match IDs always starts from
> > 1 instead of 0.
> >
> > Signed
On Tue, Apr 5, 2022 at 10:59 AM Mark Michelson wrote:
>
> This is my favorite type of change :)
It happens to be mine, too :)
>
> Acked-by: Mark Michelson
>
Thanks Mark. Applied to main.
> On 3/30/22 01:49, Han Zhou wrote:
> > This is not needed any more and force_cros
being delayed.
Signed-off-by: Han Zhou
---
controller/ofctrl.c | 4
1 file changed, 4 insertions(+)
diff --git a/controller/ofctrl.c b/controller/ofctrl.c
index a7c2d2011..a67dab024 100644
--- a/controller/ofctrl.c
+++ b/controller/ofctrl.c
@@ -669,6 +669,10 @@ run_S_CLEAR_FLOWS(void
what value to set.
Signed-off-by: Han Zhou
---
controller/ofctrl.c | 87 -
controller/ofctrl.h | 4 +-
controller/ovn-controller.8.xml | 27 ++
controller/ovn-controller.c | 6 +--
controller/pinctrl.c| 2 +
On Wed, Mar 23, 2022 at 4:22 PM Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
>
> Introduce the capability to run a recompute just on updated nodes in case
> of an incremental processing abort (e.g. if the controller is not able to
> write on the sb db and the change can't be processed inc
The comment is misleading. The conjunctive match IDs always starts from
1 instead of 0.
Signed-off-by: Han Zhou
---
lib/expr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/expr.c b/lib/expr.c
index 47ef6108e..caae0d4b2 100644
--- a/lib/expr.c
+++ b/lib/expr.c
This is not needed any more and force_crossproduct is always false.
Signed-off-by: Han Zhou
---
lib/expr.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/lib/expr.c b/lib/expr.c
index 47ef6108e..77c67cde4 100644
--- a/lib/expr.c
+++ b/lib/expr.c
@@ -33,19
On Tue, Mar 29, 2022 at 2:20 PM Numan Siddique wrote:
>
> On Mon, Mar 28, 2022 at 1:40 AM Han Zhou wrote:
> >
> > Some NICs support HW offloading for datapath flows, but masked access to
> > the 128-bit ct_label field may prevent a flow being offloaded due to HW
>
On Tue, Mar 29, 2022 at 2:19 PM Numan Siddique wrote:
>
> On Mon, Mar 28, 2022 at 1:48 AM Han Zhou wrote:
> >
> > Add an engine node en_northd_internal_version as an input to
> > en_lflow_output. When this node is updated, it triggers a recompute for
> > en_lflow_ou
On Wed, Mar 23, 2022 at 1:25 PM Numan Siddique wrote:
>
> On Wed, Mar 23, 2022 at 2:39 PM Han Zhou wrote:
> >
> > On Wed, Mar 23, 2022 at 11:26 AM Numan Siddique wrote:
> > >
> > > On Wed, Mar 23, 2022 at 2:13 PM Han Zhou wrote:
> > > >
> &
patch the northd_internal_version will be used in
en_lflow_output and impact flow generation.
Signed-off-by: Han Zhou
---
controller/ovn-controller.c | 66 +
tests/ovn-controller.at | 46 ++
2 files changed, 112 insertions(+)
diff --
The documentation of the ct_lb action wasn't up to date. Add the
description for backends and hash_fields.
Fixes: 5af304e7478a ("Support selection fields in load balancer.")
Signed-off-by: Han Zhou
Acked-by: Numan Siddique
---
ovn-sb.xml | 29 ++---
1 f
the check
for the ecmp-symmetric-reply related flow in the lr_in_arp_resolve
stage..
Signed-off-by: Han Zhou
---
northd/ovn-northd.8.xml | 17 ++---
tests/ovn-northd.at | 4
2 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/northd/ovn-northd.8.xml b/northd/
Add two new actions push & pop for stack operations.
Signed-off-by: Han Zhou
---
include/ovn/actions.h | 8 +
lib/actions.c | 73 +++
ovn-sb.xml| 15 +
tests/ovn.at | 11 +++
utilities/ovn-trace.c
: Han Zhou
---
include/ovn/actions.h | 3 ++-
lib/actions.c | 55 ---
ovn-sb.xml| 10
tests/ovn.at | 24 +++
utilities/ovn-trace.c | 8 ++-
5 files changed, 79 insertions(+), 21 deletions(-)
diff
atically.
For this to work, a new patch is added to handle SB_Global changes in I-P
engine of ovn-controller.
Han Zhou (6):
ovn-sb.xml: Fix ct_lb documentation.
actions: Add action ct_lb_mark.
actions: Add stack push and pop actions.
ovn-northd: Improve the doc and te
On Wed, Mar 23, 2022 at 11:26 AM Numan Siddique wrote:
>
> On Wed, Mar 23, 2022 at 2:13 PM Han Zhou wrote:
> >
> > On Wed, Mar 23, 2022 at 9:42 AM Numan Siddique wrote:
> > >
> > > On Tue, Mar 22, 2022 at 2:54 PM Han Zhou wrote:
> > > >
>
On Wed, Mar 23, 2022 at 9:42 AM Numan Siddique wrote:
>
> On Tue, Mar 22, 2022 at 2:54 PM Han Zhou wrote:
> >
> > Some NICs support HW offloading for datapath flows, but masked access to
> > the 128-bit ct_label field may prevent a flow being offloaded due to HW
>
On Mon, Mar 21, 2022 at 9:50 AM Numan Siddique wrote:
>
> On Mon, Mar 21, 2022 at 12:26 PM Numan Siddique wrote:
> >
> > On Mon, Mar 21, 2022 at 12:21 PM Numan Siddique wrote:
> > >
> > > On Sun, Mar 13, 2022 at 8:01 PM Han Zhou wrote:
> > > >
&
Add two new actions push & pop for stack operations.
Signed-off-by: Han Zhou
---
include/ovn/actions.h | 8 +
lib/actions.c | 73 +++
ovn-sb.xml| 15 +
tests/ovn.at | 11 +++
utilities/ovn-trace.c
the check
for the ecmp-symmetric-reply related flow in the lr_in_arp_resolve
stage..
Signed-off-by: Han Zhou
---
northd/ovn-northd.8.xml | 17 ++---
tests/ovn-northd.at | 4
2 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/northd/ovn-northd.8.xml b/northd/
On Mon, Mar 21, 2022 at 9:49 AM Numan Siddique wrote:
>
> On Sun, Mar 13, 2022 at 7:58 PM Han Zhou wrote:
> >
> > Some NICs support HW offloading for datapath flows, but masked access to
> > the 128-bit ct_label field may prevent a flow being offloaded due to HW
>
: Han Zhou
---
include/ovn/actions.h | 3 ++-
lib/actions.c | 55 ---
ovn-sb.xml| 10
tests/ovn.at | 24 +++
utilities/ovn-trace.c | 8 ++-
5 files changed, 79 insertions(+), 21 deletions(-)
diff
The documentation of the ct_lb action wasn't up to date. Add the
description for backends and hash_fields.
Fixes: 5af304e7478a ("Support selection fields in load balancer.")
Signed-off-by: Han Zhou
---
ovn-sb.xml | 29 ++---
1 file changed, 18 insertions(+
601 - 700 of 2559 matches
Mail list logo
