[ovs-dev] [PATCH 06/21] datapath: Do not trigger events for unconfirmed connections.

Upstream commit: commit 193e30967897f3a8b6f9f137ac30571d832c2c5c Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:54 2017 -0800 openvswitch: Do not trigger events for unconfirmed connections. Receiving change events before the 'new' event for the connecti

[ovs-dev] [PATCH 04/21] datapath: Fix comments for skb->_nfct

Upstream commit: commit 5e17da634a21b1200853fe82ba67d6571f2beabe Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:52 2017 -0800 openvswitch: Fix comments for skb->_nfct Fix comments referring to skb 'nfct' and 'nfctinfo' fields now that they are

[ovs-dev] [PATCH 03/21] datapath: add and use nf_ct_set helper

f_conn entry and the ctinfo bits to an sk_buff. This avoids changing code in followup patch that merges skb->nfct and skb->nfctinfo into skb->_nfct. Signed-off-by: Florian Westphal <f...@strlen.de> Signed-off-by: Pablo Neira Ayuso <pa...@netfilter.org> Signed-off-b

[ovs-dev] [PATCH 02/21] datapath: add and use skb_nfct helper

and changes its type so add a helper to avoid intrusive rename change later. Signed-off-by: Florian Westphal <f...@strlen.de> Signed-off-by: Pablo Neira Ayuso <pa...@netfilter.org> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- acinclude.m4

[ovs-dev] [PATCH 01/21] datapath: make ndo_get_stats64 a void function

ts64 to have a void function. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> Signed-off-by: David S. Miller <da...@davemloft.net> This seems to be fine for all prior Linux versions as well. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/vport-int

[ovs-dev] [PATCH 00/21] Conntrack enhancements.

and use skb_nfct helper datapath: add and use nf_ct_set helper Jarno Rajahalme (18): datapath: Fix comments for skb->_nfct datapath: Use inverted tuple in ovs_ct_find_existing() if NATted. datapath: Do not trigger events for unconfirmed connections. datapath: Unionize ovs_key_ct_la

Re: [ovs-dev] [PATCH 2/2] ofproto/bond: Fix bond post recirc rule leak.

Looks right to me, Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Feb 23, 2017, at 1:31 PM, Andy Zhou <az...@ovn.org> wrote: > > When bond is removed or when its configuration changes, > the post recirculation rules that are installed by current > bond configurat

Re: [ovs-dev] [PATCH 1/2] ofproto/bond: Fix bond reconfiguration race condition.

LGTM, Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Feb 23, 2017, at 1:31 PM, Andy Zhou <az...@ovn.org> wrote: > > During the upcall thread bond output translation, bond_may_recirc() > is currently called outside the lock. In case the main thread executes > bond_rec

Re: [ovs-dev] Sync on PTAP, EXT-382 and NSH

Thanks for the invite. In general I’d prefer if the email title or body would also contain the proposed meeting date & time. I started review of the L3 userspace patches 3 weeks ago, but unfortunately have been swamped by urgent release tasks ever since. This should ease a bit next week.

[ovs-dev] [PATCH v5 4/4] dpif-netdev: Simple DROP meter implementation.

of the meter bands are hit, we need to process the packets individually. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/dpif-netdev.c| 380 --- tests/dpif-netdev.at | 106 ++ 2 f

[ovs-dev] [PATCH v5 3/4] ofproto: Meter translation.

Translate OpenFlow METER instructions to datapath meter actions. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- include/openvswitch/ofp-actions.h | 1 + lib/dpif.c| 47 +++--- lib/o

[ovs-dev] [PATCH v5 1/4] dpif: Meter framework.

Add DPIF-level infrastructure for meters. Allow meter_set to modify the meter configuration (e.g. set the burst size if unspecified). Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- datapath/linux/compat/include/linux/openvswitch.h | 4

[ovs-dev] [PATCH v5 2/4] ofproto: Fix thread safety annotation.

ofproto_check_ofpacts() requires ofproto_mutex, but the header did not tell that so the trace did not take the mutex. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif-trace.c | 2 ++ ofproto/ofproto-provider.h | 3 ++- 2 files changed, 4 insertions(+), 1 de

[ovs-dev] [PATCH v5 0/4] Userspace meter implementation.

ofproto_check_ofpacts(), as doing so would take more analysis. - Note that the "execution with help" is broken. Userspace datapath execution should never need help, so this is OK for now. Jarno Rajahalme (4): dpif: Meter framework. ofproto: Fix thread safety annotation. ofpr

[ovs-dev] [PATCH v4 4/4] dpif-netdev: Simple DROP meter implementation.

of the meter bands are hit, we need to process the packets individually. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/dpif-netdev.c| 362 --- tests/dpif-netdev.at | 106 +++ 2 f

[ovs-dev] [PATCH v4 3/4] ofproto: Meter translation.

Translate OpenFlow METER instructions to datapath meter actions. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- include/openvswitch/ofp-actions.h | 1 + lib/dpif.c| 47 +++--- lib/o

Re: [ovs-dev] [BUG] upcall handler thread crash

Again, thanks for reporting this bug! I just posted a more complete patch to fix this issue to the ova-dev list. Please have a look. Jarno > On Feb 7, 2017, at 4:36 AM, wangyunjian wrote: > > I have tested patch without issue. Will you submit it as an official

[ovs-dev] [PATCH] mirror: Allow concurrent lookups.

itself) was tested by Yunjian Wang and was found to fix the observed crash when running a script that adds and deletes a port repeatedly. Reported-by: Yunjian Wang <wangyunj...@huawei.com> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif-m

[ovs-dev] [PATCH 8/8] datapath: handle NF_REPEAT from nf_conntrack_in()

.@netfilter.org> This upstream change is impossible to detect at module compile time, so we keep the NF_REPEAT check after the nf_conntrack_in() call. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/conntrack.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/datapat

[ovs-dev] [PATCH 6/8] datapath: remove unnecessary EXPORT_SYMBOLs

s are really used only by openvswitch.ko. Remove the exports. Tested by loading all 4 openvswitch modules, nothing breaks. Signed-off-by: Jiri Benc <jb...@redhat.com> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft

[ovs-dev] [PATCH 7/8] datapath: use core MTU range checking in core net infra

ler <da...@davemloft.net> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Upstream commit: commit 425df17ce3a26d98f76e2b6b0af2acf4aeb0b026 Author: Jarno Rajahalme <ja...@ovn.org> Date: Tue Feb 14 21:16:28 2017 -0800 openvswitch: Set internal device max mtu to

[ovs-dev] [PATCH 5/8] datapath: remove unused functions

t's the only caller of free_vport_rcu thus this one can be removed, too. Signed-off-by: Jiri Benc <jb...@redhat.com> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Jarno Rajahalme <ja...@ovn.org

[ovs-dev] [PATCH 4/8] datapath: avoid resetting flow key while installing new flow.

da...@davemloft.net> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/datapath.c | 8 datapath/flow.c | 2 -- datapath/flow_netlink.c | 6 -- datapath/flow_netlink.h | 3 ++- 4 files changed

[ovs-dev] [PATCH 3/8] datapath: Fix Frame-size larger than 1024 bytes warning.

than 1024 bytes [-Wframe-larger-than=] Signed-off-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/datapath.c

[ovs-dev] [PATCH 2/8] datapath: use percpu flow stats

Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/flow.c | 42 ++ datapath/fl

[ovs-dev] [PATCH 0/8] Upstream Linux kernel datapath backports.

Many contributors are currently working on backporting upstream Linux kernel datapath changes to the OVS tree kernel datapath. This series addresses apparent gaps in this work as follows: In this series: 08733a0 netfilter: handle NF_REPEAT from nf_conntrack_in() Already applied: 56989f6

[ovs-dev] [PATCH 1/8] datapath: fix flow stats accounting when node 0 is not possible

.net> This patch contained a memory leak that is fixed in this backport. The next patch silently fixed that in upstream, too. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/flow.c | 6 -- datapath/flow_table.c | 3 ++- 2 files changed, 6 insertions(+), 3 deletion

Re: [ovs-dev] [PATCH] doc: Describe backporting process.

Thanks for writing this up - makes my life a little bit easier :-) Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Feb 15, 2017, at 3:05 PM, Joe Stringer <j...@ovn.org> wrote: > > This patch documents the backporting process, and provides a walkthrough > for developers wh

Re: [ovs-dev] [BUG] upcall handler thread crash

> On Feb 5, 2017, at 10:49 PM, wangyunjian wrote: > > My ovs version is > openvswitch-2.5.0(http://openvswitch.org/releases/openvswitch-2.5.0.tar.gz). > I had modified the code as follows and getted other crash. Do it need a lock > to protect the operations > of

Re: [ovs-dev] [PATCH 0/7] userspace: Support for L3 tunneling

Thanks for this contribution, Jan & al! I’ll start reviewing these right away. Please find my comment addressing your concern below, > On Feb 3, 2017, at 2:37 AM, Jan Scheurich wrote: > > This patch set is part of an initiative to deal with non-Ethernet packets in

Re: [ovs-dev] OVS - ODL Sync on OF Bundle in 1.3

ht.org/view/OpenDaylight_OpenFlow_Plugin:Main > <https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Main> > > I will also send a separate meeting invite once you confirm. > > Abhijit > > From: Jarno Rajahalme <ja...@ovn.org <mailto:ja...@ovn.org>> > Date: Wedne

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

> On Jan 27, 2017, at 1:01 PM, Thomas Morin <thomas.mo...@orange.com> wrote: > > Jarno, > > 2017-01-27, Jarno Rajahalme: >> Cleanest solution would be to use the new clone action for the datapath, >> which, if important, we could also backport to OVS 2.5.x. &g

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

to use the new clone action for the datapath, which, if important, we could also backport to OVS 2.5.x. Datapath CLONE is yet to be upstreamed, though, may take a little time. Jarno > -Thomas > > 2017-01-06, Jarno Rajahalme: >> I sent a patch to do this fix on OVS master. IMO

Re: [ovs-dev] [userspace meter v3 3/5] dpif: Meter framework.

It feels weird reviewing my own code from past. What if I make a pass of fixing the problems I see and send a new version of the remaining patches for review? Jarno > On Jan 24, 2017, at 10:45 PM, Andy Zhou <az...@ovn.org> wrote: > > From: Jarno Rajahalme <ja...@ovn.org>

Re: [ovs-dev] [PATCH v2 3/3] ovs-router: introduce pkt-mark.

Also, IMO this series is good to go to the branch-2.7 as well. Jarno > On Jan 25, 2017, at 2:54 PM, Jarno Rajahalme <ja...@ovn.org> wrote: > > With a few remarks below, > > Acked-by: Jarno Rajahalme <ja...@ovn.org <mailto:ja...@ovn.org>> > >> On

Re: [ovs-dev] [PATCH v2 3/3] ovs-router: introduce pkt-mark.

With a few remarks below, Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 24, 2017, at 9:57 PM, Pravin B Shelar <pshe...@ovn.org> wrote: > > OVS router is basically partial copy of linux kernel FIB. > kernel routing table uses skb-mark along with usual routing >

Re: [ovs-dev] [PATCH v2 1/3] tunnel: Add support to configure ptk_mark

With one correction below, Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 24, 2017, at 9:57 PM, Pravin B Shelar <pshe...@ovn.org> wrote: > > Today packet mark action is broken for Tunnel ports with > tunnel monitoring. User can write a flow to set pkt-mark

Re: [ovs-dev] OVS - ODL Sync on OF Bundle in 1.3

;>, Sharath > Kumar V <sharath.kuma...@ericsson.com <mailto:sharath.kuma...@ericsson.com>>, > Kanagasundaram K <kanagasundara...@ericsson.com > <mailto:kanagasundara...@ericsson.com>>, Sunil Kumar G > <sunil.g.ku...@ericsson.com <mailto:sunil.g.ku...@eric

Re: [ovs-dev] Sync on PTAP, EXT-382 and NSH

I also missed the meeting, did not have it my calendar, sorry. Jarno > On Jan 24, 2017, at 5:52 AM, Jiri Benc wrote: > > On Wed, 18 Jan 2017 09:53:18 +, Jan Scheurich wrote: >> Please be invited to the next sync meeting. > > Sorry, won't make the meeting today. Too

Re: [ovs-dev] [PATCH v2 1/2] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

The userspace CLONE action is now merged to OVS master, so you can rebase the patches to use that. Jarno > On Jan 24, 2017, at 3:49 AM, Zoltán Balogh wrote: > > Hi, > > All right, we will rebase the code once the patch is merged. > > Could you have a look at

Re: [ovs-dev] [userspace clone v3 1/4] dpif-netdev: Avoid sending probe packets

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 20, 2017, at 6:05 PM, Andy Zhou <az...@ovn.org> wrote: > > When ofproto probe for datapath features, no packets should actually > be sent to the network. This pactch fixes the userspace by dropping > probe pack

Re: [ovs-dev] [PATCH v2 1/2] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

> On Jan 22, 2017, at 5:50 AM, Jan Scheurich wrote: > > How does the dpif-netdev CLONE action introduced here relate to the similar > action already introduced in the context of the OpenFLow CLONE action (see > for example >

[ovs-dev] Fwd: [PATCH] datapath: internal-dev: Disable rtnl_link_ops register under linux < 3.17

Thomas & Pravin, Apparently the commit 5282e284ac57 (“datapath: introduce rtnl ops stub”) applied to OVS two years ago is not compatible with Linux 3.16 or earlier, as the corresponding upstream change was only applied in Linux 3.17. For Linux 3.16 and earlier, in your opinion, is the right

Re: [ovs-dev] OVS - ODL Sync on OF Bundle in 1.3

Wednesday, 18 January, 2017 16:23 > To: Jan Scheurich; Abhijit Kumbhare; Zoltán Balogh; László Sürü; Miklós > Pelyva; Jozef Bacigál; Tomáš Slušný; Prasanna Huddar; Shuva Jyoti Kar; > Sharath Kumar V; Kanagasundaram K; Sunil Kumar G; D Arunprakash; Muthukumaran > K; Jarno Rajahalme (ja...@

Re: [ovs-dev] [PATCH 3/3] ovs-router: introduce pkt-mark.

> On Dec 28, 2016, at 1:44 AM, Pravin B Shelar wrote: > > OVS router is basically partial copy of linux kernel FIB. > kernel routing table use skb-mark along with usual routing “use”->”uses” Could you elaborate a bit here, is the kernel doing a simple exact match of the

Re: [ovs-dev] [PATCH 2/3] routing-table: parse skb-mark from RTNETLINK msg

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Dec 28, 2016, at 1:44 AM, Pravin B Shelar <pshe...@ovn.org> wrote: > > Keep track of skb-mark of given RTNL routing notification. > This will be used by next commit. > > Signed-off-by: Pravin B Shelar <pshe...@ovn.o

Re: [ovs-dev] [PATCH 1/3] tunnel: Add support to configure ptk_mark

Pravin, Sorry for the delay, I hope you find time to respond. > On Dec 28, 2016, at 1:44 AM, Pravin B Shelar wrote: > > Today packet mark action is broaken for Tunnel ports with > tunnel monitoring. “broaken”->”broken” Could you be more specific here. Setting packet mark

Re: [ovs-dev] [userspace clone v2 4/4] xlate: Generate of datapath clone action when supported

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 19, 2017, at 11:07 PM, Andy Zhou <az...@ovn.org> wrote: > > Add logic to detect whether datapath support clone. > Enhance the xlate logic to make use of it. > Added logic to turn on/off clone support for testing. &g

Re: [ovs-dev] [userspace clone v2 3/4] dpif-netdev: Add clone action

> On Jan 19, 2017, at 11:07 PM, Andy Zhou wrote: > > Add support for userspace datapath clone action. The clone action > provides an action envelope to enclose an action list. > For example, with actions A, B, C and D, and an action list: > A, clone(B, C), D > > The clone

Re: [ovs-dev] [userspace clone v2 1/4] dpif-netdev: Avoid sending probe packets

> On Jan 19, 2017, at 11:07 PM, Andy Zhou wrote: > > When ofproto probe for datapath features, no packets should actually > be sent to the network. This pactch fixes the userspace by dropping > probe packets before action execution. > > Signed-off-by: Andy Zhou >

Re: [ovs-dev] [PATCH 3/3] xlate: Generate of datapath clone action when supported

Needs rebasing if you address my comments to the previous patch. Jarno > On Jan 13, 2017, at 4:13 PM, Andy Zhou wrote: > > Add logic to detect whether datapath support clone. > Enhance the xlate logic to make use of it. > Added logic to turn on/off clone support for testing. >

Re: [ovs-dev] [PATCH 2/3] dpif-netdev: Add clone action

> On Jan 13, 2017, at 4:13 PM, Andy Zhou wrote: > > Add support for userspace datapath clone action. The clone action > provides an action envelope to enclose an action list. > For example, with action A, B, C and D, and an action list: “with action”->”with actions” > A,

Re: [ovs-dev] [PATCH 1/3] lib: Add nl_msg_end_non_empty_nested()

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 13, 2017, at 4:13 PM, Andy Zhou <az...@ovn.org> wrote: > > Later patch will make use of this function. IMO it would be good for the commit message to also include the name of the function without referencing the ti

Re: [ovs-dev] [PATCH] ofproto-dpif: Use acquire/release barriers with 'tables_version'.

> On Jan 19, 2017, at 4:49 PM, Jarno Rajahalme <ja...@ovn.org> wrote: > > >> On Jan 13, 2017, at 12:23 PM, Ben Pfaff <b...@ovn.org> wrote: >> >> On Thu, Jan 12, 2017 at 10:17:32AM -0800, Jarno Rajahalme wrote: >>> Use memory_order_release whe

Re: [ovs-dev] [PATCH] ofproto-dpif: Use acquire/release barriers with 'tables_version'.

> On Jan 13, 2017, at 12:23 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Thu, Jan 12, 2017 at 10:17:32AM -0800, Jarno Rajahalme wrote: >> Use memory_order_release when updating the tables version number to >> make sure no memory accesses before the atomic_store (possibl

Re: [ovs-dev] [PATCH] faq: Document OVS packet buffering.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 18, 2017, at 2:43 PM, Ben Pfaff <b...@ovn.org> wrote: > > We get questions about this sometimes. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > Documentation/faq/design.rst | 32 ++

[ovs-dev] [PATCH] ofproto-dpif: Use acquire/release barriers with 'tables_version'.

. Suggested-by: Daniele Di Proietto <ddiproie...@vmware.com> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 3b27

Re: [ovs-dev] [PATCH] dpif: Simplify dpif_execute_helper_cb()

Looks good to me: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 11, 2017, at 3:37 PM, Andy Zhou <az...@ovn.org> wrote: > > The may_steal flag is now used, Remove OVS_UNUSED. > > Since dp_packet_delete() handles the NULL pointer properly, we can > drop a fe

Re: [ovs-dev] Unwildcarding of fields modified by set_field action

> On Jan 11, 2017, at 12:10 AM, Jan Scheurich <jan.scheur...@web.de> wrote: > > > On 2017-01-11 01:14, Jarno Rajahalme wrote: >> >> Unwildcarding of set fields is only done for practical reasons in the >> userspace code, and could be optimized away, especi

Re: [ovs-dev] *** SPAM *** [PATCH] xlate: Recirculate also when MPLS POP is implicit.

> On Jan 6, 2017, at 9:06 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Thu, Jan 05, 2017 at 06:19:41PM -0800, Jarno Rajahalme wrote: >> 'ctx->was_mpls' is used to flag when an MPLS packet has been popped to >> a non-MPLS packet, but it was not set when the MPLS POP

Re: [ovs-dev] [PATCH v3] dpcls: Avoid one 8-byte chunk in subtable mask.

intel.com> > Co-authored-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> > Signed-off-by: Jarno Rajahalme <ja...@ovn.org> > Co-authored-by: Jarno Rajahalme <ja...@ovn.org> > --- > lib/dpif-netdev.c | 13 + > 1 file changed, 13 inserti

Re: [ovs-dev] [PATCH 2/2] revalidator: Complain for more ukey transitions.

In the worst case this patch will introduce rate-limited logging for other states than UKEY_OPERATIONAL that may want to transition onto themselves, so: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 10, 2017, at 3:54 PM, Joe Stringer <j...@ovn.org> wrote: > > For

Re: [ovs-dev] [PATCH 1/2] revalidator: Prevent double-delete of ukey.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jan 10, 2017, at 3:54 PM, Joe Stringer <j...@ovn.org> wrote: > > revalidator_sweep__() splits checking for whether to delete a ukey from > the actual deletion to prevent taking the umap lock for too long. > However it use

Re: [ovs-dev] Sync on PTAP, EXT-382 and NSH

> On Jan 9, 2017, at 3:15 AM, Yang, Yi Y wrote: > > Jan, do you think when your proposal can be merged into ovs? The old NSH > implementation and new proposal aren’t contradictory, they can coexist, your > new proposal isn’t just for NSH, new proposal won’t have push_nsh

Re: [ovs-dev] [PATCH 0/3] Tunnel: add support for packet marking

> On Jan 7, 2017, at 10:03 AM, Pravin Shelar wrote: > > On Fri, Jan 6, 2017 at 10:21 PM, Ben Pfaff wrote: >> On Wed, Dec 28, 2016 at 01:44:11AM -0800, Pravin B Shelar wrote: >>> Following patch series adds support for setting packet >>> mark for tunnel traffic.

Re: [ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

> On Jan 5, 2017, at 9:06 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Thu, Jan 05, 2017 at 05:45:29PM -0800, Jarno Rajahalme wrote: >> >>> On Jan 5, 2017, at 4:48 PM, Ben Pfaff <b...@ovn.org> wrote: >>> >>> On Thu, Jan 05, 2017 at 04:03:1

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

! Jarno > On Dec 14, 2016, at 1:52 PM, Jarno Rajahalme <ja...@ovn.org> wrote: > >> >> On Dec 13, 2016, at 8:44 PM, Takashi YAMAMOTO <yamam...@ovn.org >> <mailto:yamam...@ovn.org>> wrote: >> >> >> >> On Wed, Dec 14, 2016 at

[ovs-dev] [PATCH] xlate: Recirculate also when MPLS POP is implicit.

or now we trigger recirculation instead. Reported-by: Thomas Morin <thomas.mo...@orange.com> Suggested-by: Takashi YAMAMOTO <yamam...@ovn.org> Fixes: 742c0ac3c0ab ("mpls: Fix MPLS restoration after patch port and group bucket.") Signed-off-by: Jarno Rajahalme <ja...@ovn.org&

Re: [ovs-dev] Issues with the use of the clone action for resubmission to the pipeline

> On Jan 5, 2017, at 4:28 PM, Ben Pfaff wrote: > > On Tue, Jan 03, 2017 at 02:55:19AM -0800, Mickey Spiegel wrote: >> One of the motivations for clone is to use it as a lightweight way to >> resubmit to an earlier table at the beginning of the pipeline, without >> incurring all of

Re: [ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

> On Jan 5, 2017, at 4:48 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Thu, Jan 05, 2017 at 04:03:17PM -0800, Jarno Rajahalme wrote: >> >>> On Jan 4, 2017, at 11:03 PM, Ben Pfaff <b...@ovn.org> wrote: >>> >>> On Wed, Jan 04, 2017 at 07:21:44

Re: [ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

> On Jan 4, 2017, at 11:03 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Wed, Jan 04, 2017 at 07:21:44PM -0800, Jarno Rajahalme wrote: >> >>> On Dec 21, 2016, at 2:36 PM, Ben Pfaff <b...@ovn.org> wrote: >>> >>> On Wed, Dec 07, 2016 at 04:49:

Re: [ovs-dev] [PATCH v2] dpcls: Avoid one 8-byte chunk in subtable mask.

f-by: Antonio Fischetti <antonio.fische...@intel.com> > Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> > Co-authored-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> > Signed-off-by: Jarno Rajahalme <ja...@ovn.org> > Co-author

Re: [ovs-dev] [PATCH] tunneling: Combining actions to avoid packet recirculation in tunnel encapsulation.

> On Jan 5, 2017, at 6:57 AM, Chandran, Sugesh <sugesh.chand...@intel.com> > wrote: > > Hi Jarno, > > Thank you for looking into the path, > Please find my answers inline blow. > > > Regards > _Sugesh > > >> -Original Message-

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

, ctinfo); > if (err != NF_ACCEPT) > return err; > > +#if LINUX_VERSION_CODE < KERNEL_VERSION(4,6,0) > + if (dst_set) > + skb_dst_set(skb, NULL); > +#endif > + > /* Adjust seqs after helper. This is needed due to some helpers (e.

Re: [ovs-dev] [PATCH] dpcls: Avoid one 8-byte chunk in subtable mask.

io Fischetti <antonio.fische...@intel.com> > Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> > Co-authored-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> > Signed-off-by: Jarno Rajahalme <ja...@ovn.org> > Co-authored-by:

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

+ > /* Adjust seqs after helper. This is needed due to some helpers (e.g., >* FTP with NAT) adusting the TCP payload size when mangling IP >* addresses and/or port numbers in the text-based control connection. > -- > 2.7.4 > > > On Wed, Jan 4, 2017 at 5:50 PM,

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

> On Jan 4, 2017, at 9:50 AM, John Hurley <john.hur...@netronome.com> wrote: > > > > On Wed, Jan 4, 2017 at 12:53 AM, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: > > > On Dec 28, 2016, at 3:05 PM, John Hurley <

Re: [ovs-dev] [PATCH RFC] dpcls: Avoid one 8-byte chunk in subtable mask.

> On Dec 22, 2016, at 4:02 AM, Fischetti, Antonio <antonio.fische...@intel.com> > wrote: > > Thanks Jarno for your feedback, please find below my replies inline. > >> -Original Message----- >> From: Jarno Rajahalme [mailto:ja...@ovn.org <mailto:ja...@ovn

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

> On Dec 28, 2016, at 3:05 PM, John Hurley wrote: > > sorry, updated patch…. This patch is still whitespace damaged. Maybe use git format-patch and git send-email to send it? > > > > Fix for a bug when sending a NATed packet to

Re: [ovs-dev] [PATCH] tunneling: Combining actions to avoid packet recirculation in tunnel encapsulation.

Sugesh, So the issue is that instead of recirculating on the datapath, we can compute the “recirculation” actions on the tunnel push translation time, as these actions only depend on the tunnel attributes? This explains why the recirculation in this case is unnecessary, and mentioning this in

Re: [ovs-dev] [PATCH v2 1/4] ofproto: Update access rules for 'flow_cookie'.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Dec 20, 2016, at 11:03 PM, Ben Pfaff <b...@ovn.org> wrote: > > The 'flow_cookie' member of struct rule is read during flow translation > without holding a mutex, breaking the documented OVS_GUARDED access rule. > Howe

Re: [ovs-dev] splitting commits in Git (was: Re: Sync on PTAP, EXT-382 and NSH)

> On Dec 21, 2016, at 9:30 AM, Ben Pfaff wrote: > > There was a question about splitting up large commits in Git. I do this > routinely and I volunteered to find some resources. > > The "git-rebase" manpage has a section titled "SPLITTING COMMITS" that > is a good place to

Re: [ovs-dev] [PATCH RFC] dpcls: Avoid one 8-byte chunk in subtable mask.

> On Dec 19, 2016, at 2:43 PM, antonio.fische...@intel.com wrote: > > This patch skips the chunk comprising of dp_hash and in_port in the > subtable mask when the dpcls refers to a physical port. This will > slightly speed up the hash computation as one expensive function call > to hash_add64()

Re: [ovs-dev] OVS2.6+dpdk IPv6 Conntrack support

> On Dec 19, 2016, at 1:29 PM, Darrell Ball <db...@vmware.com> wrote: > > > > On 12/16/16, 1:25 PM, "ovs-dev-boun...@openvswitch.org > <mailto:ovs-dev-boun...@openvswitch.org> on behalf of Jarno Rajahalme" > <ovs-dev-boun...@openvswit

Re: [ovs-dev] OVS2.6+dpdk IPv6 Conntrack support

> On Dec 16, 2016, at 9:12 AM, Sridhar Gaddam wrote: > > ​​ > > > On Tue, Dec 13, 2016 at 1:12 PM, Daniele Di Proietto > wrote: > >> 2016-12-12 3:21 GMT-08:00 Sridhar Gaddam : >>> Hello, >>> >>> In our setup, we are using OVS

[ovs-dev] Backporting "net: mpls: Fixups for GSO"

Simon, I was looking at backporting upstream commit 48d2ab609b6b (“net: mpls: Fixups for GSO”), but quickly figured out I’m out of my depth here. This commit changes how the skb offsets are set up for an MPLS packet, but seems to omit the corresponding changes to key_extract() so that MPLS

Re: [ovs-dev] general question about synchronization in ovs

> On Dec 15, 2016, at 1:07 PM, Yuxin Ren <r...@gwmail.gwu.edu> wrote: > > On Thu, Dec 15, 2016 at 4:00 PM, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: >> >>> On Dec 15, 2016, at 7:55 AM, Yuxin Ren <r...@gwmail.gwu.edu>

Re: [ovs-dev] general question about synchronization in ovs

> On Dec 15, 2016, at 7:55 AM, Yuxin Ren wrote: > > Hi, > > I am a beginner to OVS. > I have some basic questions about OVS. > > Is it a multiple threads application? Yes. > If so, what data structures are shared by multiple threads? Most of them, e.g., flow tables,

Re: [ovs-dev] [PATCH 1/3] datapath: Checks the MTU for netdev-internal ports.

We should first backport this upstream commit and see if there is anything left to fix. Either way, Linux kernel datapath fixes should be first fixed on the upstream net-next repo: - 91572088e3 (“net: use core MTU range checking in core net infra”) Jarno > On Dec 11, 2016, at 8:48 PM,

Re: [ovs-dev] [PATCH] datapath: Fix compile time assertion.

> On Dec 9, 2016, at 17:57, Joe Stringer <j...@ovn.org> wrote: > >> On 9 December 2016 at 17:53, Jarno Rajahalme <ja...@ovn.org> wrote: >> compiletime_assert() cannot be used in file scope, so use preprocessor >> directives instead. >> >> Report

Re: [ovs-dev] [PATCH] datapath: Linux 4.9 compat.

Thanks for the reviews! Pushed to master with a better title and a compiletime_assert() for GENL_ID_GENERATE, if it is defined. Jarno > On Dec 9, 2016, at 2:36 PM, Pravin Shelar <pshe...@ovn.org> wrote: > > On Wed, Dec 7, 2016 at 4:31 PM, Jarno Rajahalme <ja...@ovn

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

utput for the test run might reveal why the actions validation fails. Jarno > -Thomas > > >> >>>> On Dec 1, 2016, at 5:57 PM, Jarno Rajahalme <ja...@ovn.org >>>> <mailto:ja...@ovn.org>> wrote: >>>> >>>> >>>>>

Re: [ovs-dev] [PATCH] ofproto-dpif-ipfix: Fix assertion failure for bad configuration.

Acked-by: Jarno Rajahalme <ja...@ovn.org> With questions for clarification below, Jarno > On Dec 9, 2016, at 3:12 PM, Ben Pfaff <b...@ovn.org> wrote: > > The assertions in dpif_ipfix_set_options() made some bad assumptions about > flow exporters. The code that add

Re: [ovs-dev] [PATCH 1/3] csum: Fix csum_continue() on big endian with an odd number of bytes.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Dec 8, 2016, at 6:50 PM, Daniele Di Proietto <diproiet...@vmware.com> > wrote: > > Even though it reads 16 bits at a time, csum_continue() is almost > neutral to endianness (see RFC 1071 1.2 (B), "Byte Order Indepe

[ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

of bytes. Iterating the stack in the reverse order is not possible, so some code needs to reverse the stack first to then traverse the stack. This could be avoided by storing the length of the value both before and after it. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- include/openvswit

[ovs-dev] [PATCH] datapath: Linux 4.9 compat.

_GENERATE is no longer defined, but since it was defined as 0, it is safe to drop it from all initializers also on older Linux versions. Tested with current Linux net-next (4.9) and 3.16. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- acinclude.m4

Re: [ovs-dev] [PATCH net-next v2] ofproto: Honor OFPFF_RESET_COUNTS flag in flow modify message.

> On Dec 1, 2016, at 3:44 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Thu, Dec 01, 2016 at 01:09:12PM -0800, Jarno Rajahalme wrote: >>> If I may be permitted to nit-pick, the name "modify_forward_counts" took >>> me a bit of thinking to properly under

Re: [ovs-dev] [PATCH] mpls: Fix MPLS restoration after patch port and group bucket.

Thanks for the review, pushed to master, branch-2.6, and branch-2.5. Jarno > On Dec 3, 2016, at 5:54 AM, Takashi YAMAMOTO <yamam...@ovn.org> wrote: > > > > On Sat, Dec 3, 2016 at 12:38 PM, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: &

Re: [ovs-dev] [PATCH] tunnel: set udp dst-port in tunnel metadata

Acked-by: Jarno Rajahalme <ja...@ovn.org> Is it OK to leave the tunnel.tp_src unset, or left set to the value from the incoming tunnel? Jarno > On Dec 4, 2016, at 11:52 PM, Pravin B Shelar <pshe...@ovn.org> wrote: > > VxLan device expect valid tp-dst in tunnel metada

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

I sent a patch to fix this on OVS master. After it is reviewed I’ll backport it to branch-2.5 (it only needs trivial fixes to apply, so you may want to try that as well). Jarno > On Dec 1, 2016, at 5:57 PM, Jarno Rajahalme <ja...@ovn.org> wrote: > > >> On Nov 30,

<    1   2   3   4   >