[ovs-dev] [PATCH v4 3/4] netdev-native-tnl: Mark all vxlan/geneve packets as tunneled.

2024-02-15 Thread Mike Pattrick
VXLAN and GENEVE TSO.") Reported-by: David Marchand Signed-off-by: Mike Pattrick --- v4: Corrected packet to pkt --- lib/dp-packet.h | 19 +-- lib/netdev-native-tnl.c | 10 -- lib/packets.c | 8 3 files changed, 29 insertions(+), 8 deletions

Re: [ovs-dev] [PATCH v4 4/4] Userspace: Add system test with UDP tunneling of UDP traffic.

2024-02-16 Thread Mike Pattrick
On Fri, Feb 16, 2024 at 3:23 PM Ilya Maximets wrote: > > On 2/15/24 23:53, Mike Pattrick wrote: > > Previously a gap existed in the tunnel system tests where only ICMP and > > TCP traffic was tested. However, the code paths using for UDP traffic is > > different then ei

[ovs-dev] [PATCH] dp-packet: Don't offload inner csum if outer isn't supported.

2024-02-20 Thread Mike Pattrick
don't offload inner either. Reported-at: https://issues.redhat.com/browse/FDP-363 Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") Signed-off-by: Mike Pattrick --- nb: I also tested a more complex patch that only resolved the inner checksum and offloaded the UDP layer. T

Re: [ovs-dev] [PATCH v2] bond: Reset stats when deleting post recirc rule.

2024-02-20 Thread Mike Pattrick
rg/project/openvswitch/patch/20240209161718.1149494-1-i.maxim...@ovn.org/ > > Reported-at: https://github.com/openvswitch/ovs-issues/issues/319 > Co-authored-by: Ilya Maximets > Signed-off-by: Ilya Maximets > Signed-off-by: Adrian Moreno > --- Looks reasonable to me. Acked

Re: [ovs-dev] [PATCH v2] dpif-netdev: Do not create handler threads.

2024-02-20 Thread Mike Pattrick
read system during testing, with the number > of threads reduced from 95 to 0. > > Signed-off-by: Eelco Chaudron > --- I tested this out a bit, and it seems to work well. Acked-by: Mike Pattrick ___ dev mailing list d...@openvswitch.or

[ovs-dev] [PATCH] userspace: Allow UDP zero checksum with IPv6 tunnels.

2024-02-20 Thread Mike Pattrick
to set csum=false on IPv6 tunnels. Signed-off-by: Mike Pattrick --- lib/netdev-native-tnl.c | 2 +- lib/netdev-vport.c | 13 +++-- lib/netdev.h| 9 - ofproto/tunnel.c| 11 +-- tests/tunnel.at | 6 +++--- vswitchd/vswitch.xml| 8

[ovs-dev] [PATCH] Userspace: Software fallback for UDP encapsulated TCP segmentation.

2024-02-20 Thread Mike Pattrick
When sending packets that are flagged as requiring segmentation to an interface that doens't support this feature, send the packet to the TSO software fallback instead of dropping it. Signed-off-by: Mike Pattrick --- lib/dp-packet-gso.c | 73 + l

Re: [ovs-dev] [PATCH] dp-packet: Don't offload inner csum if outer isn't supported.

2024-02-20 Thread Mike Pattrick
On Tue, Feb 20, 2024 at 10:07 AM Mike Pattrick wrote: > > Some network cards support inner checksum offloading but not outer > checksum offloading. Currently OVS will resolve that outer checksum but > allows the network card to resolve the inner checksum, invalidating the > outer

Re: [ovs-dev] [PATCH] userspace: Allow UDP zero checksum with IPv6 tunnels.

2024-02-20 Thread Mike Pattrick
On Tue, Feb 20, 2024 at 8:56 PM Mike Pattrick wrote: > > This patch adopts the proposed RFC 6935 by allowing null UDP checksums > even if the tunnel protocol is IPv6. This is already supported by Linux > through the udp6zerocsumtx tunnel option. It is disabled by default and > I

Re: [ovs-dev] [PATCH 1/3] tests: Move the non-local port as tunnel endpoint test.

2024-02-20 Thread Mike Pattrick
er visually and less error > prone by requesting port numbers for all the ports. > > Signed-off-by: Ilya Maximets Acked-by: Mike Pattrick ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v2] userspace: Allow UDP zero checksum with IPv6 tunnels.

2024-02-21 Thread Mike Pattrick
to set csum=false on IPv6 tunnels. Signed-off-by: Mike Pattrick --- v2: Changed documentation, and added a NEWS item --- NEWS| 5 - lib/netdev-native-tnl.c | 2 +- lib/netdev-vport.c | 13 +++-- lib/netdev.h| 9 - ofproto/tunnel.c

[ovs-dev] [PATCH v3] userspace: Allow UDP zero checksum with IPv6 tunnels.

2024-02-21 Thread Mike Pattrick
to set csum=false on IPv6 tunnels. Signed-off-by: Mike Pattrick --- v2: Changed documentation, and added a NEWS item v3: NEWS file merge conflict --- NEWS| 3 +++ lib/netdev-native-tnl.c | 2 +- lib/netdev-vport.c | 13 +++-- lib/netdev.h| 9

Re: [ovs-dev] [PATCH] Userspace: Software fallback for UDP encapsulated TCP segmentation.

2024-02-21 Thread Mike Pattrick
On Tue, Feb 20, 2024 at 11:09 PM Mike Pattrick wrote: > > When sending packets that are flagged as requiring segmentation to an > interface that doens't support this feature, send the packet to the TSO > software fallback instead of dropping it. > > Signed-off-by: Mike Pat

[ovs-dev] [PATCH v2] ovsdb: Don't iterate over rows on empty mutation.

2024-02-22 Thread Mike Pattrick
, returning immediately. One notable change in functionality is not performing the RBAC check in this condition, as no mutation actually takes place. Reported-by: Terry Wilson Reported-at: https://issues.redhat.com/browse/FDP-359 Signed-off-by: Mike Pattrick --- v2: Added additional non-rbac tests

[ovs-dev] [PATCH v2] dp-packet: Don't offload inner csum if outer isn't supported.

2024-02-26 Thread Mike Pattrick
don't offload inner either. Reported-at: https://issues.redhat.com/browse/FDP-363 Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") Signed-off-by: Mike Pattrick --- nb: I also tested a more complex patch that only resolved the inner checksum and offloaded the UDP layer. T

[ovs-dev] [PATCH v7 1/2] ofproto-dpif-mirror: Reduce number of function parameters.

2024-02-26 Thread Mike Pattrick
Previously the mirror_set() and mirror_get() functions took a large number of parameters, which was inefficient and difficult to read and extend. This patch moves most of the parameters into a struct. Signed-off-by: Mike Pattrick Acked-by: Simon Horman Acked-by: Eelco Chaudron --- ofproto

[ovs-dev] [PATCH v7 2/2] ofproto-dpif-mirror: Add support for pre-selection filter.

2024-02-26 Thread Mike Pattrick
packets are mirrored based on flow metadata. This significantly improves overall vswitchd performance during mirroring if only a subset of traffic is required. Signed-off-by: Mike Pattrick --- v7: - Make sure filter mask is added to masks of non-matching flows. - Added additional tests

Re: [ovs-dev] [PATCH v2] conntrack: Fix flush not flushing all elements.

2024-02-27 Thread Mike Pattrick
On Mon, Feb 26, 2024 at 5:50 AM Xavier Simonart wrote: > > On netdev datapath, when a ct element was cleaned, the cmap > could be shrinked, potentially causing some elements to be skipped > in the flush iteration. > > Fixes: 967bb5c5cd90 ("conntrack: Add rcu support.") > Signed-off-by: Xavier Simo

Re: [ovs-dev] [PATCH 1/5] Documentation: Extend copyright to 2024.

2024-02-27 Thread Mike Pattrick
On Tue, Feb 27, 2024 at 10:36 AM Simon Horman wrote: > > IANAL, but I think we can extend the copyright attached > to documentation to cover the current year: we are still > actively working on the documentation. > > Signed-off-by: Simon Horman Acked-by: Mike Pattrick I wo

Re: [ovs-dev] [PATCH 2/5] Documentation: Correct spelling errors.

2024-02-27 Thread Mike Pattrick
On Tue, Feb 27, 2024 at 10:37 AM Simon Horman wrote: > > Correct spelling errors in .rst files flagged by codespell. > > Signed-off-by: Simon Horman > --- These look correct to me. Acked-by: Mike Pattrick ___ dev mailing list d...@

Re: [ovs-dev] [PATCH 3/5] Documentation: Anuket project updates.

2024-02-27 Thread Mike Pattrick
rf/en/latest/release/release-notes/release-notes.html > > Signed-off-by: Simon Horman > --- Acked-by: Mike Pattrick ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 4/5] Documentatoin: Update Pacemaker link.

2024-02-27 Thread Mike Pattrick
On Tue, Feb 27, 2024 at 10:36 AM Simon Horman wrote: > > Update link to OCF Resource Agents documentation as the existing link > is broken. Also, use HTTPS. > > Broken link flagged by make check-docs > > Signed-off-by: Simon Horman Ac

Re: [ovs-dev] [PATCH 5/5] Documentation: Update links to upstream Kernel documentation.

2024-02-27 Thread Mike Pattrick
tead. > > 1., 2. & 3. Found by inspection > 4. Flagged by check-docs > > Signed-off-by: Simon Horman Acked-by: Mike Pattrick ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v5 1/2] util: Support checking for kernel versions.

2024-02-27 Thread Mike Pattrick
On Mon, Feb 26, 2024 at 4:22 AM Felix Huettner via dev wrote: > > Extract checking for a given kernel version to a separate function. > It will be used also in the next patch. > > Signed-off-by: Felix Huettner > --- > v4->v5: > - fix wrong ifdef that broke on macos > - fix ovs_kernel_is_version_o

Re: [ovs-dev] [PATCH v2] ovsdb: Don't iterate over rows on empty mutation.

2024-02-28 Thread Mike Pattrick
On Wed, Feb 28, 2024 at 8:41 AM Ilya Maximets wrote: > > On 2/22/24 17:37, Mike Pattrick wrote: > > Previously when an empty mutation was used to count the number of rows > > in a table, OVSDB would iterate over all rows twice. First to perform an > > RBAC check, an

Re: [ovs-dev] [PATCH v3] conntrack: Fix flush not flushing all elements.

2024-03-04 Thread Mike Pattrick
ot;) > Signed-off-by: Xavier Simonart Acked-by: Mike Pattrick ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v6 1/2] util: Support checking for kernel versions.

2024-03-05 Thread Mike Pattrick
On Mon, Mar 4, 2024 at 3:22 AM Felix Huettner via dev wrote: > > Extract checking for a given kernel version to a separate function. > It will be used also in the next patch. > > Signed-off-by: Felix Huettner > --- Acked-by: Mike Pattrick _

Re: [ovs-dev] [PATCH v6 2/2] netlink-conntrack: Optimize flushing ct zone.

2024-03-06 Thread Mike Pattrick
ed-By: Luca Czesla > Signed-off-by: Luca Czesla > Co-Authored-By: Max Lamprecht > Signed-off-by: Max Lamprecht > Signed-off-by: Felix Huettner > --- Acked-by: Mike Pattrick ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v3] ovsdb: Don't iterate over rows on empty mutation.

2024-03-06 Thread Mike Pattrick
, returning immediately. One notable change in functionality is not performing the RBAC check in this condition, as no mutation actually takes place. Reported-by: Terry Wilson Reported-at: https://issues.redhat.com/browse/FDP-359 Signed-off-by: Mike Pattrick --- v2: Added additional non-rbac tests

[ovs-dev] [PATCH] tests/mfex: Rertain support for cryptography pre-v37.

2023-03-21 Thread Mike Pattrick
27; has no attribute 'CryptographyDeprecationWarning' This import was only added to __init__ to deprecate python3.6. Importing the exception from cryptography.utils is the compatible option. Signed-off-by: Mike Pattrick --- tests/mfex_fuzzy.py | 5 +++-- 1 file changed, 3 insertions(+), 2 de

[ovs-dev] [PATCH v10 1/4] Documentation: Document netdev offload.

2023-03-21 Thread Mike Pattrick
From: Flavio Leitner Document the implementation of netdev hardware offloading in userspace datapath. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- Since v9: - Renamed documentation to reflect the userspace checksum nature of this feature

[ovs-dev] [PATCH v10 2/4] dpif-netdev: Show netdev offloading flags.

2023-03-21 Thread Mike Pattrick
From: Flavio Leitner This patch modifies netdev_get_status to include information about checksum offload status by port, allowing the user to gain insight into where checksum offloading is active. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick

[ovs-dev] [PATCH v10 3/4] userspace: Enable IP checksum offloading by default.

2023-03-21 Thread Mike Pattrick
P checksum offload alone, so the support is not enabled. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- Since v9: - Removed duplicative field tx_ip_csum_offload from netdev-dpdk.c - Left rx_csum_offload field as it is not duplicative - Moved system

[ovs-dev] [PATCH v10 4/4] userspace: Enable L4 checksum offloading by default.

2023-03-21 Thread Mike Pattrick
nd L4 offload, so this patch enables the feature. However, Linux socket interface remains disabled because the API doesn't allow enabling those two features without enabling TSO too. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- Since v9:

[ovs-dev] [PATCH v11 1/4] Documentation: Document netdev offload.

2023-03-27 Thread Mike Pattrick
From: Flavio Leitner Document the implementation of netdev hardware offloading in userspace datapath. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- Since v9: - Renamed documentation to reflect the userspace checksum nature of this feature

[ovs-dev] [PATCH v11 0/4] Enhanced checksum support

2023-03-27 Thread Mike Pattrick
This patch set is a stripped down subset of the initial 17 patchset introduced by Flavio Leitner in 2021. The initial omnibus patchset was very complex and included a refactor, which stymied review and would have made backporting more complex. It also didn't resolve an ongoing issue with the DPDK

[ovs-dev] [PATCH v11 2/4] dpif-netdev: Show netdev offloading flags.

2023-03-27 Thread Mike Pattrick
From: Flavio Leitner This patch modifies netdev_get_status to include information about checksum offload status by port, allowing the user to gain insight into where checksum offloading is active. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick

[ovs-dev] [PATCH v11 3/4] userspace: Enable IP checksum offloading by default.

2023-03-27 Thread Mike Pattrick
P checksum offload alone, so the support is not enabled. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick -- Since v9: - Removed duplicative field tx_ip_csum_offload from netdev-dpdk.c - Left rx_csum_offload field as it is not duplicative - Moved system

[ovs-dev] [PATCH v11 4/4] userspace: Enable L4 checksum offloading by default.

2023-03-27 Thread Mike Pattrick
nd L4 offload, so this patch enables the feature. However, Linux socket interface remains disabled because the API doesn't allow enabling those two features without enabling TSO too. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- Since v9:

Re: [ovs-dev] [PATCH 1/2] dpif-netlink: always create at least 1 handler

2023-03-27 Thread Mike Pattrick
solation.") > Cc: msant...@redhat.com > > Suggested-by: Aaron Conole > Signed-off-by: Adrian Moreno I didn't test this, but it seems reasonable to me that we prevent the creation of zero threads. Acked-by: Mike Pattrick __

Re: [ovs-dev] [PATCH 2/2] ovs-thread: fix cpus not read for the first 10s

2023-03-27 Thread Mike Pattrick
but it's unclear whether that's better, or just different. I only mention it because count_cpu_cores__() can return 0. Acked-by: Mike Pattrick ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] netdev-tc-offloads: Fix misaligned 8 byte read.

2023-03-27 Thread Mike Pattrick
load.c:303 #2 in dpif_netlink_flow_dump_next lib/dpif-netlink.c:1921 [...] Signed-off-by: Mike Pattrick --- lib/netdev-offload-tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c index 4fb9d9f21..506b74ce7 100644 --- a/

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Fix misaligned 8 byte read.

2023-03-28 Thread Mike Pattrick
On Tue, Mar 28, 2023 at 6:02 AM Ilya Maximets wrote: > > On 3/27/23 22:32, Mike Pattrick wrote: > > UB Sanitizer report: > > > > lib/netdev-offload-tc.c:1276:19: runtime error: load of misaligned > > address 0x7f74e801976c for type 'union ovs_u128&#x

[ovs-dev] [PATCH v2] netdev-tc-offloads: Fix misaligned 8 byte read.

2023-03-28 Thread Mike Pattrick
load.c:303 #2 in dpif_netlink_flow_dump_next lib/dpif-netlink.c:1921 [...] Signed-off-by: Mike Pattrick --- Since v1: - Changed memcpy to get_32aligned_u128 - Checked full size of cookie length --- lib/netdev-offload-tc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

Re: [ovs-dev] [PATCH] seq: Make read of the current value atomic

2023-03-28 Thread Mike Pattrick
On Mon, Mar 27, 2023 at 7:25 AM Eelco Chaudron wrote: > > Make the read of the current seq->value atomic, i.e., not needing to > acquire the global mutex when reading it. On 64-bit systems, this > incurs no overhead, and it will avoid the mutex and potentially > a system call. > > For incrementing

Re: [ovs-dev] [PATCH] seq: Make read of the current value atomic

2023-03-31 Thread Mike Pattrick
On Fri, Mar 31, 2023 at 10:45 AM Eelco Chaudron wrote: > > > > On 30 Mar 2023, at 17:57, Jon Kohler wrote: > > >> On Mar 28, 2023, at 1:32 PM, Mike Pattrick wrote: > >> > >> On Mon, Mar 27, 2023 at 7:25 AM Eelco Chaudron wrote: > >>> >

Re: [ovs-dev] [PATCH v2 1/2] ovs-monitor-ipsec: Migration from ipsec.conf to swanctl.conf

2023-04-21 Thread Mike Pattrick
On Tue, Mar 22, 2022 at 10:09 AM Emeel Hakim via dev wrote: > > As strongswan moved to the modern vici-based interface,this patch > modifies ovs-monitor-ipsec to use strongswan's vici-based > configuration instead of the legacy stroke-based configuration. > > Reviewed-by: Raed Salem > Signed-off-

Re: [ovs-dev] [PATCH v2 2/2] deb: Update openvswitch-ipsec dependencies

2023-04-21 Thread Mike Pattrick
On Tue, Mar 22, 2022 at 10:09 AM Emeel Hakim via dev wrote: > > patch ovs-monitor-ipsec: Migration from ipsec.conf to swanctl.conf > introduces strongswan-swanctl as an openvswitch-ipsec dependency, > this patch adds it to the openvswitch-ipsec dependencies. > > Signed-off-by: Emeel Hakim > --- >

Re: [ovs-dev] [PATCH v11 2/4] dpif-netdev: Show netdev offloading flags.

2023-05-02 Thread Mike Pattrick
On Fri, Apr 28, 2023 at 6:46 PM Ilya Maximets wrote: > > On 3/27/23 12:50, Mike Pattrick wrote: > > From: Flavio Leitner > > > > This patch modifies netdev_get_status to include information about > > checksum offload status by port, allowing the user to gain i

[ovs-dev] [PATCH v12 0/4] Enhanced checksum support

2023-05-16 Thread Mike Pattrick
This patch set is a stripped down subset of the initial 17 patchset introduced by Flavio Leitner in 2021. The initial omnibus patchset was very complex and included a refactor, which stymied review and would have made backporting more complex. It also didn't resolve an ongoing issue with the DPDK

[ovs-dev] [PATCH v12 1/4] Documentation: Document netdev offload.

2023-05-16 Thread Mike Pattrick
From: Flavio Leitner Document the implementation of netdev hardware offloading in userspace datapath. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- Since v9: - Renamed documentation to reflect the userspace checksum nature of this feature

[ovs-dev] [PATCH v12 3/4] userspace: Enable IP checksum offloading by default.

2023-05-16 Thread Mike Pattrick
P checksum offload alone, so the support is not enabled. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick -- Since v9: - Removed duplicative field tx_ip_csum_offload from netdev-dpdk.c - Left rx_csum_offload field as it is not duplicative - Moved system

[ovs-dev] [PATCH v12 4/4] userspace: Enable L4 checksum offloading by default.

2023-05-16 Thread Mike Pattrick
nd L4 offload, so this patch enables the feature. However, Linux socket interface remains disabled because the API doesn't allow enabling those two features without enabling TSO too. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- Since v9:

[ovs-dev] [PATCH v12 2/4] dpif-netdev: Show netdev offloading flags.

2023-05-16 Thread Mike Pattrick
From: Flavio Leitner This patch modifies netdev_get_status to include information about checksum offload status by port, allowing the user to gain insight into where checksum offloading is active. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick

[ovs-dev] [PATCH v13 1/4] Documentation: Document netdev offload.

2023-05-16 Thread Mike Pattrick
From: Flavio Leitner Document the implementation of netdev hardware offloading in userspace datapath. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- Since v9: - Renamed documentation to reflect the userspace checksum nature of this feature

[ovs-dev] [PATCH v13 0/4] Enhanced checksum support

2023-05-16 Thread Mike Pattrick
This patch set is a stripped down subset of the initial 17 patchset introduced by Flavio Leitner in 2021. The initial omnibus patchset was very complex and included a refactor, which stymied review and would have made backporting more complex. It also didn't resolve an ongoing issue with the DPDK

[ovs-dev] [PATCH v13 3/4] userspace: Enable IP checksum offloading by default.

2023-05-16 Thread Mike Pattrick
P checksum offload alone, so the support is not enabled. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick -- Since v9: - Removed duplicative field tx_ip_csum_offload from netdev-dpdk.c - Left rx_csum_offload field as it is not duplicative - Moved system

[ovs-dev] [PATCH v13 4/4] userspace: Enable L4 checksum offloading by default.

2023-05-16 Thread Mike Pattrick
nd L4 offload, so this patch enables the feature. However, Linux socket interface remains disabled because the API doesn't allow enabling those two features without enabling TSO too. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- Since v9:

[ovs-dev] [PATCH v13 2/4] dpif-netdev: Show netdev offloading flags.

2023-05-16 Thread Mike Pattrick
From: Flavio Leitner This patch modifies netdev_get_status to include information about checksum offload status by port, allowing the user to gain insight into where checksum offloading is active. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick

[ovs-dev] [PATCH v2] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2023-05-18 Thread Mike Pattrick
over 3kb from several translation actions. This patch also moves some trace function from do_xlate_actions into its own function to reduce stack usage. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779 Signed-off-by: Mike Pattrick --- Since v1: - Refactored code into specialized

Re: [ovs-dev] [PATCH v4] ovs-ofctl:'--bundle' option can be used with OpenFlow 1.3

2023-05-25 Thread Mike Pattrick
e included in EXT-230. The support exists in ofp-bundle.c for OFP13_VERSION, though, the error message is a little confusing: "bundles need OpenFlow 1.3 or later ('-O OpenFlow14')" Acked-by: Mike Pattrick Cheers, MKP > --- > utilities/ovs-ofctl.8.in | 10 +- &

[ovs-dev] [PATCH v3] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2023-05-25 Thread Mike Pattrick
over 3kb from several translation actions. This patch also moves some trace function from do_xlate_actions into its own function to reduce stack usage. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779 Signed-off-by: Mike Pattrick --- Since v1: - Refactored code into specialized

Re: [ovs-dev] [PATCH] netdev-offload-dpdk: Fix crash in debug log.

2023-05-26 Thread Mike Pattrick
port. > > Fixes: faf71e492263 ("netdev-dpdk: Print port name in offload API messages.") > Signed-off-by: David Marchand LGTM. Acked-by: Mike Pattrick > --- > lib/netdev-offload-dpdk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/

Re: [ovs-dev] [PATCH v13 4/4] userspace: Enable L4 checksum offloading by default.

2023-05-29 Thread Mike Pattrick
On Wed, May 24, 2023 at 8:56 AM Ilya Maximets wrote: > > On 5/17/23 05:11, Mike Pattrick wrote: > > From: Flavio Leitner > > > > The netdev receiving packets is supposed to provide the flags > > indicating if the L4 checksum was verified and it is OK or BAD, >

[ovs-dev] [PATCH v14 1/4] Documentation: Document netdev offload.

2023-06-02 Thread Mike Pattrick
Document the implementation of netdev hardware offloading in userspace datapath. Signed-off-by: Flavio Leitner Co-authored-by: Flavio Leitner Signed-off-by: Mike Pattrick --- Since v9: - Renamed documentation to reflect the userspace checksum nature of this feature - Edited for

[ovs-dev] [PATCH v14 0/4] Enhanced checksum support

2023-06-02 Thread Mike Pattrick
wrote a section of the documentation - Removed exclusion of the combination of rte_flow offload, userspace tso, and RAW_ENCAP - Added a TUNGETFEATURES check in netdev-linux.c for better support of early 2.6 era kernels Mike Pattrick (4): Documentation: Document netdev offload. dp

[ovs-dev] [PATCH v14 2/4] dpif-netdev: Show netdev offloading flags.

2023-06-02 Thread Mike Pattrick
This patch modifies netdev_get_status to include information about checksum offload status by port, allowing the user to gain insight into where checksum offloading is active. Signed-off-by: Flavio Leitner Co-authored-by: Flavio Leitner Signed-off-by: Mike Pattrick --- Since v9: - Removed

[ovs-dev] [PATCH v14 3/4] userspace: Enable IP checksum offloading by default.

2023-06-02 Thread Mike Pattrick
he support is not enabled. Signed-off-by: Flavio Leitner Co-authored-by: Flavio Leitner Signed-off-by: Mike Pattrick --- Since v9: - Removed duplicative field tx_ip_csum_offload from netdev-dpdk.c - Left rx_csum_offload field as it is not duplicative - Moved system-userspace-offload.a

[ovs-dev] [PATCH v14 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-02 Thread Mike Pattrick
patch enables the feature. However, Linux socket interface remains disabled because the API doesn't allow enabling those two features without enabling TSO too. Signed-off-by: Flavio Leitner Co-authored-by: Flavio Leitner Signed-off-by: Mike Pattrick --- Since v9: - Extended miniflow_extra

Re: [ovs-dev] [PATCH v2] conntrack: Fix icmp_id conflicts in snat

2023-06-05 Thread Mike Pattrick
On Wed, Dec 14, 2022 at 10:50 PM wrote: > > From: wushaohua > > The icmp_id maybe conflicts in snat > Description: > If multiple devices send icmp packets with the same icmp_id, > the sip of the packets changes to the same source ip address after the snat > operation, > and the packets are sent

Re: [ovs-dev] [PATCH v4] ofproto-dpif-xlate: Remove repeated function for judge garp

2023-06-06 Thread Mike Pattrick
On Mon, Feb 20, 2023 at 5:05 AM Han Ding wrote: > > > Function is_gratuitous_arp() and function is_garp() are all used to judge > whether the flow is gratuitous arp. It is not necessary to use two functions > to do the same thing and just keep one. > > Gratuitous ARP message is a generally link-le

[ovs-dev] [PATCH v4] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2023-06-09 Thread Mike Pattrick
over 3kb from several translation actions. This patch also moves some trace function from do_xlate_actions into its own function to reduce stack usage. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779 Signed-off-by: Mike Pattrick Reviewed-by: Simon Horman --- Since v1

Re: [ovs-dev] [PATCH v4] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2023-06-09 Thread Mike Pattrick
On Fri, Jun 9, 2023 at 10:01 AM Mike Pattrick wrote: > > Several xlate actions used in recursive translation currently store a > large amount of information on the stack. This can result in handler > threads quickly running out of stack space despite before > xlate_resubmit_reso

[ovs-dev] [PATCH v5] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2023-06-09 Thread Mike Pattrick
over 3kb from several translation actions. This patch also moves some trace function from do_xlate_actions into its own function to reduce stack usage. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779 Signed-off-by: Mike Pattrick Reviewed-by: Simon Horman --- Since v1

Re: [ovs-dev] [PATCHv2] bfd: Add IPv6 address support to BFD packets

2023-06-09 Thread Mike Pattrick
On Tue, Aug 2, 2022 at 4:04 PM Toms Atteka wrote: > > Added config options for source and destination IPv6 addresses to > BFD packets. IPv6 address presence overrides IPv4 address and > packets are crafted as IPv6. > > Added IP address values to status to ease setting up IP addresses. > > Signed-o

Re: [ovs-dev] [PATCH v3] rhel: make the version, displayed to the user, customizable

2023-06-12 Thread Mike Pattrick
entOS/RHEL spec file in order to have > the version be aligned with the downstream one. > > Signed-off-by: Timothy Redaelli This seems reasonable to me, and it looks like you've incorporated the requests from v1 and v2. Acked-by: Mike Pattrick > --- > Makefile.am

Re: [ovs-dev] [PATCH v2] Add editorconfig file

2023-06-12 Thread Mike Pattrick
g-Properties#max_line_length > Signed-off-by: Robin Jarry > --- Great idea, editorconfig is super convenient to have. Acked-by: Mike Pattrick > > Notes: > v2: add .editorconfig to EXTRA_DIST > > .editorconfig | 14 ++ > Makefile.am | 1 + > 2

Re: [ovs-dev] [PATCH v2] netdev-linux: fix memory leak in qos

2023-06-12 Thread Mike Pattrick
On Mon, Jun 12, 2023 at 4:39 AM 张祖建 wrote: > > Reported by Valgrind: > > ==00:00:00:46.715 951138== 56 bytes in 1 blocks are definitely lost in loss > record 363 of 408 > ==00:00:00:46.715 951138== at 0x4848899: malloc (in > /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) > ==00:00:00:4

Re: [ovs-dev] [PATCH v2] Add editorconfig file

2023-06-12 Thread Mike Pattrick
On Mon, Jun 12, 2023 at 10:54 AM Eelco Chaudron wrote: > > > > On 12 Jun 2023, at 15:11, Mike Pattrick wrote: > > > On Tue, May 30, 2023 at 10:23 AM Robin Jarry wrote: > >> > >> EditorConfig is a file format and collection of text editor plugins for &g

[ovs-dev] [PATCH v15 3/4] userspace: Enable IP checksum offloading by default.

2023-06-14 Thread Mike Pattrick
he support is not enabled. Signed-off-by: Flavio Leitner Co-authored-by: Flavio Leitner Signed-off-by: Mike Pattrick --- Since v9: - Removed duplicative field tx_ip_csum_offload from netdev-dpdk.c - Left rx_csum_offload field as it is not duplicative - Moved system-userspace-offload.a

[ovs-dev] [PATCH v15 0/4] Enhanced checksum support

2023-06-14 Thread Mike Pattrick
ck TUNGETFEATURES once - Respect FLOW_TNL_F_CSUM flag Mike Pattrick (4): Documentation: Document netdev offload. dpif-netdev: Show netdev offloading flags. userspace: Enable IP checksum offloading by default. userspace: Enable L4 checksum offloading by default. Documentation/automake.mk

[ovs-dev] [PATCH v15 2/4] dpif-netdev: Show netdev offloading flags.

2023-06-14 Thread Mike Pattrick
This patch modifies netdev_get_status to include information about checksum offload status by port, allowing the user to gain insight into where checksum offloading is active. Signed-off-by: Flavio Leitner Co-authored-by: Flavio Leitner Signed-off-by: Mike Pattrick --- Since v9: - Removed

[ovs-dev] [PATCH v15 1/4] Documentation: Document netdev offload.

2023-06-14 Thread Mike Pattrick
Document the implementation of netdev hardware offloading in userspace datapath. Signed-off-by: Flavio Leitner Co-authored-by: Flavio Leitner Signed-off-by: Mike Pattrick --- Since v9: - Renamed documentation to reflect the userspace checksum nature of this feature - Edited for

[ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-14 Thread Mike Pattrick
patch enables the feature. However, Linux socket interface remains disabled because the API doesn't allow enabling those two features without enabling TSO too. Signed-off-by: Flavio Leitner Co-authored-by: Flavio Leitner Signed-off-by: Mike Pattrick --- Since v9: - Extended miniflow_extra

Re: [ovs-dev] [PATCH v15 0/4] Enhanced checksum support

2023-06-18 Thread Mike Pattrick
On Thu, Jun 15, 2023 at 3:30 PM Ilya Maximets wrote: > > On 6/14/23 21:03, Mike Pattrick wrote: > > This patch set is a stripped down subset of the initial 17 patchset > > introduced > > by Flavio Leitner in 2021. > > > > The initial omnibus patchset was

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Drop TSO in case of conflicting virtio features.

2023-06-19 Thread Mike Pattrick
ures. > > This patch proposes to try and detect those vhost socket disconnection > and fallback restoring the old virtio features (and disabling TSO for this > vhost port). > > Signed-off-by: David Marchand > --- > Note: this series depends on Mike series and

[ovs-dev] [PATCH 1/2] userspace: Respect tso/gso segment size.

2023-06-21 Thread Mike Pattrick
packets are dropped. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- lib/dp-packet.c| 1 + lib/dp-packet.h| 26 + lib/netdev-dpdk.c | 13 +++-- lib/netdev-linux.c | 73 +- 4 files

[ovs-dev] [PATCH 2/2] userspace: Add Generic Segmentation Offloading.

2023-06-21 Thread Mike Pattrick
ch is sent in order to the netdev. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- lib/automake.mk | 2 + lib/dp-packet-gso.c | 172 lib/dp-packet-gso.h | 24 +++ lib/dp-packet.c | 4 +- l

[ovs-dev] [PATCH v2 1/2] userspace: Respect tso/gso segment size.

2023-06-21 Thread Mike Pattrick
packets are dropped. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- lib/dp-packet.c| 3 ++ lib/dp-packet.h| 26 lib/netdev-dpdk.c | 12 +++- lib/netdev-linux.c | 76 -- 4 files

[ovs-dev] [PATCH v2 2/2] userspace: Add Generic Segmentation Offloading.

2023-06-21 Thread Mike Pattrick
ch is sent in order to the netdev. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- lib/automake.mk | 2 + lib/dp-packet-gso.c | 172 lib/dp-packet-gso.h | 24 +++ lib/dp-packet.h | 11 +++

[ovs-dev] [PATCH v3 2/2] userspace: Add Generic Segmentation Offloading.

2023-06-21 Thread Mike Pattrick
ch is sent in order to the netdev. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- lib/automake.mk | 2 + lib/dp-packet-gso.c | 172 lib/dp-packet-gso.h | 24 +++ lib/dp-packet.h | 11 +++

[ovs-dev] [PATCH v3 1/2] userspace: Respect tso/gso segment size.

2023-06-21 Thread Mike Pattrick
packets are dropped. Signed-off-by: Flavio Leitner Co-authored-by: Mike Pattrick Signed-off-by: Mike Pattrick --- v3: Corrected sparse error --- lib/dp-packet.c| 3 ++ lib/dp-packet.h| 26 lib/netdev-dpdk.c | 12 +++- lib/netdev-linux.c | 76

[ovs-dev] [PATCH v2] ofproto-dpif-upcall: Mirror packets that are modified

2023-06-23 Thread Mike Pattrick
7;t see an echo reply even though one has been sent. This patch resets the mirrors every time a packet is modified, so mirrors will recieve every copy of a packet that is sent for output. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2155579 Signed-off-by: Mike Pattrick --- ofproto/of

Re: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Mirror packets that are modified

2023-06-26 Thread Mike Pattrick
On Mon, Jun 26, 2023 at 5:42 AM Eelco Chaudron wrote: > > > > On 23 Jun 2023, at 19:07, Mike Pattrick wrote: > > > Currently OVS keeps track of which mirrors that each packet has been > > sent to for the purpose of deduplication. However, this doesn't consider

[ovs-dev] [PATCH v3] ofproto-dpif-upcall: Mirror packets that are modified

2023-06-26 Thread Mike Pattrick
7;t see an echo reply even though one has been sent. This patch resets the mirrors every time a packet is modified, so mirrors will recieve every copy of a packet that is sent for output. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2155579 Signed-off-by: Mike Pattrick --- v2: Refa

Re: [ovs-dev] [PATCH v3] ofproto-dpif-upcall: Mirror packets that are modified

2023-06-29 Thread Mike Pattrick
On Thu, Jun 29, 2023 at 10:06 AM Eelco Chaudron wrote: > > > > On 26 Jun 2023, at 15:43, Mike Pattrick wrote: > > > Currently OVS keeps track of which mirrors that each packet has been > > sent to for the purpose of deduplication. However, this doesn't consider

Re: [ovs-dev] [PATCH v5] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2023-06-29 Thread Mike Pattrick
On Thu, Jun 29, 2023 at 3:10 PM Ilya Maximets wrote: > > On 6/9/23 17:05, Mike Pattrick wrote: > > Several xlate actions used in recursive translation currently store a > > large amount of information on the stack. This can result in handler > > threads quickly running ou

Re: [ovs-dev] [PATCH v5] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2023-06-30 Thread Mike Pattrick
On Fri, Jun 30, 2023 at 12:33 PM Ilya Maximets wrote: > > On 6/30/23 18:13, Ilya Maximets wrote: > > On 6/30/23 00:45, Mike Pattrick wrote: > >> On Thu, Jun 29, 2023 at 3:10 PM Ilya Maximets wrote: > >>> > >>> On 6/9/23 17:05, Mike Pattrick wrote: &

[ovs-dev] [PATCH v5] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2023-07-10 Thread Mike Pattrick
over 3kb from several translation actions. This patch also moves some trace function from do_xlate_actions into its own function. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779 Signed-off-by: Mike Pattrick Reviewed-by: Simon Horman --- Since v1: - Refactored code into

[ovs-dev] [PATCH v4] ofproto-dpif-upcall: Mirror packets that are modified

2023-07-10 Thread Mike Pattrick
7;t see an echo reply even though one has been sent. This patch resets the mirrors every time a packet is modified, so mirrors will recieve every copy of a packet that is sent for output. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2155579 Signed-off-by: Mike Pattrick --- v2: Refa

<    1   2   3   4   5   6   7   8   >