VXLAN and GENEVE TSO.")
Reported-by: David Marchand
Signed-off-by: Mike Pattrick
---
v4: Corrected packet to pkt
---
lib/dp-packet.h | 19 +--
lib/netdev-native-tnl.c | 10 --
lib/packets.c | 8
3 files changed, 29 insertions(+), 8 deletions
On Fri, Feb 16, 2024 at 3:23 PM Ilya Maximets wrote:
>
> On 2/15/24 23:53, Mike Pattrick wrote:
> > Previously a gap existed in the tunnel system tests where only ICMP and
> > TCP traffic was tested. However, the code paths using for UDP traffic is
> > different then ei
don't offload inner either.
Reported-at: https://issues.redhat.com/browse/FDP-363
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Signed-off-by: Mike Pattrick
---
nb: I also tested a more complex patch that only resolved the inner
checksum and offloaded the UDP layer. T
rg/project/openvswitch/patch/20240209161718.1149494-1-i.maxim...@ovn.org/
>
> Reported-at: https://github.com/openvswitch/ovs-issues/issues/319
> Co-authored-by: Ilya Maximets
> Signed-off-by: Ilya Maximets
> Signed-off-by: Adrian Moreno
> ---
Looks reasonable to me.
Acked
read system during testing, with the number
> of threads reduced from 95 to 0.
>
> Signed-off-by: Eelco Chaudron
> ---
I tested this out a bit, and it seems to work well.
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.or
to set csum=false on IPv6 tunnels.
Signed-off-by: Mike Pattrick
---
lib/netdev-native-tnl.c | 2 +-
lib/netdev-vport.c | 13 +++--
lib/netdev.h| 9 -
ofproto/tunnel.c| 11 +--
tests/tunnel.at | 6 +++---
vswitchd/vswitch.xml| 8
When sending packets that are flagged as requiring segmentation to an
interface that doens't support this feature, send the packet to the TSO
software fallback instead of dropping it.
Signed-off-by: Mike Pattrick
---
lib/dp-packet-gso.c | 73 +
l
On Tue, Feb 20, 2024 at 10:07 AM Mike Pattrick wrote:
>
> Some network cards support inner checksum offloading but not outer
> checksum offloading. Currently OVS will resolve that outer checksum but
> allows the network card to resolve the inner checksum, invalidating the
> outer
On Tue, Feb 20, 2024 at 8:56 PM Mike Pattrick wrote:
>
> This patch adopts the proposed RFC 6935 by allowing null UDP checksums
> even if the tunnel protocol is IPv6. This is already supported by Linux
> through the udp6zerocsumtx tunnel option. It is disabled by default and
> I
er visually and less error
> prone by requesting port numbers for all the ports.
>
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
to set csum=false on IPv6 tunnels.
Signed-off-by: Mike Pattrick
---
v2: Changed documentation, and added a NEWS item
---
NEWS| 5 -
lib/netdev-native-tnl.c | 2 +-
lib/netdev-vport.c | 13 +++--
lib/netdev.h| 9 -
ofproto/tunnel.c
to set csum=false on IPv6 tunnels.
Signed-off-by: Mike Pattrick
---
v2: Changed documentation, and added a NEWS item
v3: NEWS file merge conflict
---
NEWS| 3 +++
lib/netdev-native-tnl.c | 2 +-
lib/netdev-vport.c | 13 +++--
lib/netdev.h| 9
On Tue, Feb 20, 2024 at 11:09 PM Mike Pattrick wrote:
>
> When sending packets that are flagged as requiring segmentation to an
> interface that doens't support this feature, send the packet to the TSO
> software fallback instead of dropping it.
>
> Signed-off-by: Mike Pat
, returning immediately. One notable change in
functionality is not performing the RBAC check in this condition, as no
mutation actually takes place.
Reported-by: Terry Wilson
Reported-at: https://issues.redhat.com/browse/FDP-359
Signed-off-by: Mike Pattrick
---
v2: Added additional non-rbac tests
don't offload inner either.
Reported-at: https://issues.redhat.com/browse/FDP-363
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Signed-off-by: Mike Pattrick
---
nb: I also tested a more complex patch that only resolved the inner
checksum and offloaded the UDP layer. T
Previously the mirror_set() and mirror_get() functions took a large
number of parameters, which was inefficient and difficult to read and
extend. This patch moves most of the parameters into a struct.
Signed-off-by: Mike Pattrick
Acked-by: Simon Horman
Acked-by: Eelco Chaudron
---
ofproto
packets are mirrored based on flow metadata. This
significantly improves overall vswitchd performance during mirroring if
only a subset of traffic is required.
Signed-off-by: Mike Pattrick
---
v7:
- Make sure filter mask is added to masks of non-matching flows.
- Added additional tests
On Mon, Feb 26, 2024 at 5:50 AM Xavier Simonart wrote:
>
> On netdev datapath, when a ct element was cleaned, the cmap
> could be shrinked, potentially causing some elements to be skipped
> in the flush iteration.
>
> Fixes: 967bb5c5cd90 ("conntrack: Add rcu support.")
> Signed-off-by: Xavier Simo
On Tue, Feb 27, 2024 at 10:36 AM Simon Horman wrote:
>
> IANAL, but I think we can extend the copyright attached
> to documentation to cover the current year: we are still
> actively working on the documentation.
>
> Signed-off-by: Simon Horman
Acked-by: Mike Pattrick
I wo
On Tue, Feb 27, 2024 at 10:37 AM Simon Horman wrote:
>
> Correct spelling errors in .rst files flagged by codespell.
>
> Signed-off-by: Simon Horman
> ---
These look correct to me.
Acked-by: Mike Pattrick
___
dev mailing list
d...@
rf/en/latest/release/release-notes/release-notes.html
>
> Signed-off-by: Simon Horman
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Feb 27, 2024 at 10:36 AM Simon Horman wrote:
>
> Update link to OCF Resource Agents documentation as the existing link
> is broken. Also, use HTTPS.
>
> Broken link flagged by make check-docs
>
> Signed-off-by: Simon Horman
Ac
tead.
>
> 1., 2. & 3. Found by inspection
> 4. Flagged by check-docs
>
> Signed-off-by: Simon Horman
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Feb 26, 2024 at 4:22 AM Felix Huettner via dev
wrote:
>
> Extract checking for a given kernel version to a separate function.
> It will be used also in the next patch.
>
> Signed-off-by: Felix Huettner
> ---
> v4->v5:
> - fix wrong ifdef that broke on macos
> - fix ovs_kernel_is_version_o
On Wed, Feb 28, 2024 at 8:41 AM Ilya Maximets wrote:
>
> On 2/22/24 17:37, Mike Pattrick wrote:
> > Previously when an empty mutation was used to count the number of rows
> > in a table, OVSDB would iterate over all rows twice. First to perform an
> > RBAC check, an
ot;)
> Signed-off-by: Xavier Simonart
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Mar 4, 2024 at 3:22 AM Felix Huettner via dev
wrote:
>
> Extract checking for a given kernel version to a separate function.
> It will be used also in the next patch.
>
> Signed-off-by: Felix Huettner
> ---
Acked-by: Mike Pattrick
_
ed-By: Luca Czesla
> Signed-off-by: Luca Czesla
> Co-Authored-By: Max Lamprecht
> Signed-off-by: Max Lamprecht
> Signed-off-by: Felix Huettner
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
, returning immediately. One notable change in
functionality is not performing the RBAC check in this condition, as no
mutation actually takes place.
Reported-by: Terry Wilson
Reported-at: https://issues.redhat.com/browse/FDP-359
Signed-off-by: Mike Pattrick
---
v2: Added additional non-rbac tests
27; has no attribute
'CryptographyDeprecationWarning'
This import was only added to __init__ to deprecate python3.6. Importing
the exception from cryptography.utils is the compatible option.
Signed-off-by: Mike Pattrick
---
tests/mfex_fuzzy.py | 5 +++--
1 file changed, 3 insertions(+), 2 de
From: Flavio Leitner
Document the implementation of netdev hardware offloading
in userspace datapath.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
Since v9:
- Renamed documentation to reflect the userspace checksum nature of
this feature
From: Flavio Leitner
This patch modifies netdev_get_status to include information about
checksum offload status by port, allowing the user to gain insight into
where checksum offloading is active.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
P checksum offload alone, so the
support is not enabled.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
Since v9:
- Removed duplicative field tx_ip_csum_offload from netdev-dpdk.c
- Left rx_csum_offload field as it is not duplicative
- Moved system
nd L4 offload, so this
patch enables the feature. However, Linux socket interface
remains disabled because the API doesn't allow enabling
those two features without enabling TSO too.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
Since v9:
From: Flavio Leitner
Document the implementation of netdev hardware offloading
in userspace datapath.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
Since v9:
- Renamed documentation to reflect the userspace checksum nature of
this feature
This patch set is a stripped down subset of the initial 17 patchset introduced
by Flavio Leitner in 2021.
The initial omnibus patchset was very complex and included a refactor, which
stymied review and would have made backporting more complex. It also didn't
resolve an ongoing issue with the DPDK
From: Flavio Leitner
This patch modifies netdev_get_status to include information about
checksum offload status by port, allowing the user to gain insight into
where checksum offloading is active.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
P checksum offload alone, so the
support is not enabled.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
--
Since v9:
- Removed duplicative field tx_ip_csum_offload from netdev-dpdk.c
- Left rx_csum_offload field as it is not duplicative
- Moved system
nd L4 offload, so this
patch enables the feature. However, Linux socket interface
remains disabled because the API doesn't allow enabling
those two features without enabling TSO too.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
Since v9:
solation.")
> Cc: msant...@redhat.com
>
> Suggested-by: Aaron Conole
> Signed-off-by: Adrian Moreno
I didn't test this, but it seems reasonable to me that we prevent the
creation of zero threads.
Acked-by: Mike Pattrick
__
but it's unclear
whether that's better, or just different. I only mention it because
count_cpu_cores__() can return 0.
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
load.c:303
#2 in dpif_netlink_flow_dump_next lib/dpif-netlink.c:1921
[...]
Signed-off-by: Mike Pattrick
---
lib/netdev-offload-tc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c
index 4fb9d9f21..506b74ce7 100644
--- a/
On Tue, Mar 28, 2023 at 6:02 AM Ilya Maximets wrote:
>
> On 3/27/23 22:32, Mike Pattrick wrote:
> > UB Sanitizer report:
> >
> > lib/netdev-offload-tc.c:1276:19: runtime error: load of misaligned
> > address 0x7f74e801976c for type 'union ovs_u128
load.c:303
#2 in dpif_netlink_flow_dump_next lib/dpif-netlink.c:1921
[...]
Signed-off-by: Mike Pattrick
---
Since v1:
- Changed memcpy to get_32aligned_u128
- Checked full size of cookie length
---
lib/netdev-offload-tc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -
On Mon, Mar 27, 2023 at 7:25 AM Eelco Chaudron wrote:
>
> Make the read of the current seq->value atomic, i.e., not needing to
> acquire the global mutex when reading it. On 64-bit systems, this
> incurs no overhead, and it will avoid the mutex and potentially
> a system call.
>
> For incrementing
On Fri, Mar 31, 2023 at 10:45 AM Eelco Chaudron wrote:
>
>
>
> On 30 Mar 2023, at 17:57, Jon Kohler wrote:
>
> >> On Mar 28, 2023, at 1:32 PM, Mike Pattrick wrote:
> >>
> >> On Mon, Mar 27, 2023 at 7:25 AM Eelco Chaudron wrote:
> >>>
>
On Tue, Mar 22, 2022 at 10:09 AM Emeel Hakim via dev
wrote:
>
> As strongswan moved to the modern vici-based interface,this patch
> modifies ovs-monitor-ipsec to use strongswan's vici-based
> configuration instead of the legacy stroke-based configuration.
>
> Reviewed-by: Raed Salem
> Signed-off-
On Tue, Mar 22, 2022 at 10:09 AM Emeel Hakim via dev
wrote:
>
> patch ovs-monitor-ipsec: Migration from ipsec.conf to swanctl.conf
> introduces strongswan-swanctl as an openvswitch-ipsec dependency,
> this patch adds it to the openvswitch-ipsec dependencies.
>
> Signed-off-by: Emeel Hakim
> ---
>
On Fri, Apr 28, 2023 at 6:46 PM Ilya Maximets wrote:
>
> On 3/27/23 12:50, Mike Pattrick wrote:
> > From: Flavio Leitner
> >
> > This patch modifies netdev_get_status to include information about
> > checksum offload status by port, allowing the user to gain i
This patch set is a stripped down subset of the initial 17 patchset introduced
by Flavio Leitner in 2021.
The initial omnibus patchset was very complex and included a refactor, which
stymied review and would have made backporting more complex. It also didn't
resolve an ongoing issue with the DPDK
From: Flavio Leitner
Document the implementation of netdev hardware offloading
in userspace datapath.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
Since v9:
- Renamed documentation to reflect the userspace checksum nature of
this feature
P checksum offload alone, so the
support is not enabled.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
--
Since v9:
- Removed duplicative field tx_ip_csum_offload from netdev-dpdk.c
- Left rx_csum_offload field as it is not duplicative
- Moved system
nd L4 offload, so this
patch enables the feature. However, Linux socket interface
remains disabled because the API doesn't allow enabling
those two features without enabling TSO too.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
Since v9:
From: Flavio Leitner
This patch modifies netdev_get_status to include information about
checksum offload status by port, allowing the user to gain insight into
where checksum offloading is active.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
From: Flavio Leitner
Document the implementation of netdev hardware offloading
in userspace datapath.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
Since v9:
- Renamed documentation to reflect the userspace checksum nature of
this feature
This patch set is a stripped down subset of the initial 17 patchset introduced
by Flavio Leitner in 2021.
The initial omnibus patchset was very complex and included a refactor, which
stymied review and would have made backporting more complex. It also didn't
resolve an ongoing issue with the DPDK
P checksum offload alone, so the
support is not enabled.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
--
Since v9:
- Removed duplicative field tx_ip_csum_offload from netdev-dpdk.c
- Left rx_csum_offload field as it is not duplicative
- Moved system
nd L4 offload, so this
patch enables the feature. However, Linux socket interface
remains disabled because the API doesn't allow enabling
those two features without enabling TSO too.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
Since v9:
From: Flavio Leitner
This patch modifies netdev_get_status to include information about
checksum offload status by port, allowing the user to gain insight into
where checksum offloading is active.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
over 3kb from several translation actions.
This patch also moves some trace function from do_xlate_actions into its
own function to reduce stack usage.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779
Signed-off-by: Mike Pattrick
---
Since v1:
- Refactored code into specialized
e included in
EXT-230.
The support exists in ofp-bundle.c for OFP13_VERSION, though, the
error message is a little confusing: "bundles need OpenFlow 1.3 or
later ('-O OpenFlow14')"
Acked-by: Mike Pattrick
Cheers,
MKP
> ---
> utilities/ovs-ofctl.8.in | 10 +-
&
over 3kb from several translation actions.
This patch also moves some trace function from do_xlate_actions into its
own function to reduce stack usage.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779
Signed-off-by: Mike Pattrick
---
Since v1:
- Refactored code into specialized
port.
>
> Fixes: faf71e492263 ("netdev-dpdk: Print port name in offload API messages.")
> Signed-off-by: David Marchand
LGTM.
Acked-by: Mike Pattrick
> ---
> lib/netdev-offload-dpdk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/
On Wed, May 24, 2023 at 8:56 AM Ilya Maximets wrote:
>
> On 5/17/23 05:11, Mike Pattrick wrote:
> > From: Flavio Leitner
> >
> > The netdev receiving packets is supposed to provide the flags
> > indicating if the L4 checksum was verified and it is OK or BAD,
>
Document the implementation of netdev hardware offloading
in userspace datapath.
Signed-off-by: Flavio Leitner
Co-authored-by: Flavio Leitner
Signed-off-by: Mike Pattrick
---
Since v9:
- Renamed documentation to reflect the userspace checksum nature of
this feature
- Edited for
wrote a section of the documentation
- Removed exclusion of the combination of rte_flow offload, userspace tso, and
RAW_ENCAP
- Added a TUNGETFEATURES check in netdev-linux.c for better support of early
2.6 era kernels
Mike Pattrick (4):
Documentation: Document netdev offload.
dp
This patch modifies netdev_get_status to include information about
checksum offload status by port, allowing the user to gain insight into
where checksum offloading is active.
Signed-off-by: Flavio Leitner
Co-authored-by: Flavio Leitner
Signed-off-by: Mike Pattrick
---
Since v9:
- Removed
he
support is not enabled.
Signed-off-by: Flavio Leitner
Co-authored-by: Flavio Leitner
Signed-off-by: Mike Pattrick
---
Since v9:
- Removed duplicative field tx_ip_csum_offload from netdev-dpdk.c
- Left rx_csum_offload field as it is not duplicative
- Moved system-userspace-offload.a
patch enables the feature. However, Linux socket interface
remains disabled because the API doesn't allow enabling
those two features without enabling TSO too.
Signed-off-by: Flavio Leitner
Co-authored-by: Flavio Leitner
Signed-off-by: Mike Pattrick
---
Since v9:
- Extended miniflow_extra
On Wed, Dec 14, 2022 at 10:50 PM wrote:
>
> From: wushaohua
>
> The icmp_id maybe conflicts in snat
> Description:
> If multiple devices send icmp packets with the same icmp_id,
> the sip of the packets changes to the same source ip address after the snat
> operation,
> and the packets are sent
On Mon, Feb 20, 2023 at 5:05 AM Han Ding wrote:
>
>
> Function is_gratuitous_arp() and function is_garp() are all used to judge
> whether the flow is gratuitous arp. It is not necessary to use two functions
> to do the same thing and just keep one.
>
> Gratuitous ARP message is a generally link-le
over 3kb from several translation actions.
This patch also moves some trace function from do_xlate_actions into its
own function to reduce stack usage.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779
Signed-off-by: Mike Pattrick
Reviewed-by: Simon Horman
---
Since v1
On Fri, Jun 9, 2023 at 10:01 AM Mike Pattrick wrote:
>
> Several xlate actions used in recursive translation currently store a
> large amount of information on the stack. This can result in handler
> threads quickly running out of stack space despite before
> xlate_resubmit_reso
over 3kb from several translation actions.
This patch also moves some trace function from do_xlate_actions into its
own function to reduce stack usage.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779
Signed-off-by: Mike Pattrick
Reviewed-by: Simon Horman
---
Since v1
On Tue, Aug 2, 2022 at 4:04 PM Toms Atteka wrote:
>
> Added config options for source and destination IPv6 addresses to
> BFD packets. IPv6 address presence overrides IPv4 address and
> packets are crafted as IPv6.
>
> Added IP address values to status to ease setting up IP addresses.
>
> Signed-o
entOS/RHEL spec file in order to have
> the version be aligned with the downstream one.
>
> Signed-off-by: Timothy Redaelli
This seems reasonable to me, and it looks like you've incorporated the
requests from v1 and v2.
Acked-by: Mike Pattrick
> ---
> Makefile.am
g-Properties#max_line_length
> Signed-off-by: Robin Jarry
> ---
Great idea, editorconfig is super convenient to have.
Acked-by: Mike Pattrick
>
> Notes:
> v2: add .editorconfig to EXTRA_DIST
>
> .editorconfig | 14 ++
> Makefile.am | 1 +
> 2
On Mon, Jun 12, 2023 at 4:39 AM 张祖建 wrote:
>
> Reported by Valgrind:
>
> ==00:00:00:46.715 951138== 56 bytes in 1 blocks are definitely lost in loss
> record 363 of 408
> ==00:00:00:46.715 951138== at 0x4848899: malloc (in
> /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==00:00:00:4
On Mon, Jun 12, 2023 at 10:54 AM Eelco Chaudron wrote:
>
>
>
> On 12 Jun 2023, at 15:11, Mike Pattrick wrote:
>
> > On Tue, May 30, 2023 at 10:23 AM Robin Jarry wrote:
> >>
> >> EditorConfig is a file format and collection of text editor plugins for
&g
he
support is not enabled.
Signed-off-by: Flavio Leitner
Co-authored-by: Flavio Leitner
Signed-off-by: Mike Pattrick
---
Since v9:
- Removed duplicative field tx_ip_csum_offload from netdev-dpdk.c
- Left rx_csum_offload field as it is not duplicative
- Moved system-userspace-offload.a
ck TUNGETFEATURES once
- Respect FLOW_TNL_F_CSUM flag
Mike Pattrick (4):
Documentation: Document netdev offload.
dpif-netdev: Show netdev offloading flags.
userspace: Enable IP checksum offloading by default.
userspace: Enable L4 checksum offloading by default.
Documentation/automake.mk
This patch modifies netdev_get_status to include information about
checksum offload status by port, allowing the user to gain insight into
where checksum offloading is active.
Signed-off-by: Flavio Leitner
Co-authored-by: Flavio Leitner
Signed-off-by: Mike Pattrick
---
Since v9:
- Removed
Document the implementation of netdev hardware offloading
in userspace datapath.
Signed-off-by: Flavio Leitner
Co-authored-by: Flavio Leitner
Signed-off-by: Mike Pattrick
---
Since v9:
- Renamed documentation to reflect the userspace checksum nature of
this feature
- Edited for
patch enables the feature. However, Linux socket interface
remains disabled because the API doesn't allow enabling
those two features without enabling TSO too.
Signed-off-by: Flavio Leitner
Co-authored-by: Flavio Leitner
Signed-off-by: Mike Pattrick
---
Since v9:
- Extended miniflow_extra
On Thu, Jun 15, 2023 at 3:30 PM Ilya Maximets wrote:
>
> On 6/14/23 21:03, Mike Pattrick wrote:
> > This patch set is a stripped down subset of the initial 17 patchset
> > introduced
> > by Flavio Leitner in 2021.
> >
> > The initial omnibus patchset was
ures.
>
> This patch proposes to try and detect those vhost socket disconnection
> and fallback restoring the old virtio features (and disabling TSO for this
> vhost port).
>
> Signed-off-by: David Marchand
> ---
> Note: this series depends on Mike series and
packets are dropped.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
lib/dp-packet.c| 1 +
lib/dp-packet.h| 26 +
lib/netdev-dpdk.c | 13 +++--
lib/netdev-linux.c | 73 +-
4 files
ch is sent in order to the netdev.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
lib/automake.mk | 2 +
lib/dp-packet-gso.c | 172
lib/dp-packet-gso.h | 24 +++
lib/dp-packet.c | 4 +-
l
packets are dropped.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
lib/dp-packet.c| 3 ++
lib/dp-packet.h| 26
lib/netdev-dpdk.c | 12 +++-
lib/netdev-linux.c | 76 --
4 files
ch is sent in order to the netdev.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
lib/automake.mk | 2 +
lib/dp-packet-gso.c | 172
lib/dp-packet-gso.h | 24 +++
lib/dp-packet.h | 11 +++
ch is sent in order to the netdev.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
lib/automake.mk | 2 +
lib/dp-packet-gso.c | 172
lib/dp-packet-gso.h | 24 +++
lib/dp-packet.h | 11 +++
packets are dropped.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
v3: Corrected sparse error
---
lib/dp-packet.c| 3 ++
lib/dp-packet.h| 26
lib/netdev-dpdk.c | 12 +++-
lib/netdev-linux.c | 76
7;t see an echo reply even though
one has been sent.
This patch resets the mirrors every time a packet is modified, so
mirrors will recieve every copy of a packet that is sent for output.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2155579
Signed-off-by: Mike Pattrick
---
ofproto/of
On Mon, Jun 26, 2023 at 5:42 AM Eelco Chaudron wrote:
>
>
>
> On 23 Jun 2023, at 19:07, Mike Pattrick wrote:
>
> > Currently OVS keeps track of which mirrors that each packet has been
> > sent to for the purpose of deduplication. However, this doesn't consider
7;t see an echo reply even though
one has been sent.
This patch resets the mirrors every time a packet is modified, so
mirrors will recieve every copy of a packet that is sent for output.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2155579
Signed-off-by: Mike Pattrick
---
v2: Refa
On Thu, Jun 29, 2023 at 10:06 AM Eelco Chaudron wrote:
>
>
>
> On 26 Jun 2023, at 15:43, Mike Pattrick wrote:
>
> > Currently OVS keeps track of which mirrors that each packet has been
> > sent to for the purpose of deduplication. However, this doesn't consider
On Thu, Jun 29, 2023 at 3:10 PM Ilya Maximets wrote:
>
> On 6/9/23 17:05, Mike Pattrick wrote:
> > Several xlate actions used in recursive translation currently store a
> > large amount of information on the stack. This can result in handler
> > threads quickly running ou
On Fri, Jun 30, 2023 at 12:33 PM Ilya Maximets wrote:
>
> On 6/30/23 18:13, Ilya Maximets wrote:
> > On 6/30/23 00:45, Mike Pattrick wrote:
> >> On Thu, Jun 29, 2023 at 3:10 PM Ilya Maximets wrote:
> >>>
> >>> On 6/9/23 17:05, Mike Pattrick wrote:
&
over 3kb from several translation actions.
This patch also moves some trace function from do_xlate_actions into its
own function.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779
Signed-off-by: Mike Pattrick
Reviewed-by: Simon Horman
---
Since v1:
- Refactored code into
7;t see an echo reply even though
one has been sent.
This patch resets the mirrors every time a packet is modified, so
mirrors will recieve every copy of a packet that is sent for output.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2155579
Signed-off-by: Mike Pattrick
---
v2: Refa
201 - 300 of 782 matches
Mail list logo