Re: [ovs-dev] [PATCH ovn v4 3/9] northd: Add Sampling_App table.

2024-07-31 Thread Numan Siddique
On Wed, Jul 31, 2024 at 11:48 AM Ilya Maximets wrote: > > On 7/31/24 17:05, Dumitru Ceara wrote: > > On 7/31/24 16:40, Ilya Maximets wrote: > >> On 7/31/24 16:17, Dumitru Ceara wrote: > >>> On 7/31/24 16:07, Ilya Maximets wrote: > On 7/31/24 16:04, Ilya Maximets wrote: > > On 7/31/24 11:0

Re: [ovs-dev] [PATCH ovn v4 1/9] northd: Fix up logical flow documentation for QoS.

2024-07-31 Thread Numan Siddique
gt; > > > > >This table implements switching behavior. It contains these logical > > @@ -2117,7 +2090,7 @@ output; > > > > > > > > -Ingress Table 28 Destination unknown > > +Ingress Table 27 Destination unknown >

Re: [ovs-dev] [PATCH ovn v4 3/9] northd: Add Sampling_App table.

2024-07-31 Thread Numan Siddique
On Wed, Jul 31, 2024 at 4:20 PM Numan Siddique wrote: > > On Wed, Jul 31, 2024 at 11:48 AM Ilya Maximets wrote: > > > > On 7/31/24 17:05, Dumitru Ceara wrote: > > > On 7/31/24 16:40, Ilya Maximets wrote: > > >> On 7/31/24 16:17, Dumitru Ceara wrote: > &

Re: [ovs-dev] [PATCH ovn] ct-zones: reserve zones for upcoming ports

2024-08-06 Thread Numan Siddique
On Tue, Aug 6, 2024 at 12:29 AM Mansi Sharma wrote: > > Ping for review. Thanks for the patch. This patch needs a rebase. And it is failing compilation --- env REAL_CC="gcc" CHECK="sparse -Wsparse-error -I /workspace/ovn-tmp/ovs/include/sparse -m64 -I /usr/local/include -I /usr/include/x86_64-l

Re: [ovs-dev] [PATCH ovn] northd: Allow Load balancer to be attached to router with multiple GW ports

2024-08-06 Thread Numan Siddique
9Ij2MlCi8dO02I-kZf0&s=JR1CKXLiNrDGVt85mXYTutzBqhpCpiABOutl2TMPWEE&e= > >>> [2] > >> https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_pipermail_ovs-2Ddev_2024-2DJuly_415977.html&d=DwIFaQ&c=s883GpUCOChKOHiocYtGcg&r=BWfApgwqQ_BTXd_yEq_kwWLM-KTqkdPvolD

Re: [ovs-dev] [PATCH ovn v2] Add support for centralize routing for distributed gw ports.

2024-08-06 Thread Numan Siddique
On Mon, Aug 5, 2024 at 8:45 AM Felix Huettner via dev wrote: > > On Mon, Jul 29, 2024 at 10:38:49PM -0400, num...@ovn.org wrote: > > From: Numan Siddique > > > > Consider a deployment with the below logical resources: > > > > 1. A bridged logical switch 

Re: [ovs-dev] [PATCH ovn v2] Add support for centralize routing for distributed gw ports.

2024-08-06 Thread Numan Siddique
On Tue, Aug 6, 2024 at 2:50 AM Han Zhou wrote: > > On Mon, Jul 29, 2024 at 7:39 PM wrote: > > > > From: Numan Siddique > > > > Consider a deployment with the below logical resources: > > > > 1. A bridged logical switch 'public' with a port

Re: [ovs-dev] [PATCH ovn v2] Add support for centralize routing for distributed gw ports.

2024-08-07 Thread Numan Siddique
gt; keine E-Mails von zhou...@gmail.com. Weitere Informationen, warum dies > > > wichtig ist, finden Sie unter > > > https://aka.ms/LearnAboutSenderIdentification ] > > > > > > On Tue, Aug 6, 2024 at 8:35 PM Numan Siddique wrote: > > > > > > >

Re: [ovs-dev] [PATCH ovn v4 1/9] northd: Fix up logical flow documentation for QoS.

2024-08-07 Thread Numan Siddique
On Thu, Aug 1, 2024 at 5:10 AM Dumitru Ceara wrote: > > On 8/1/24 00:53, Numan Siddique wrote: > > > > > Acked-by: Numan Siddique > > > > Thanks! > > > Not related to this patch: > > I think ovn-northd.8.xml has been out of sync with the logica

Re: [ovs-dev] [PATCH ovn v2] Add support for centralize routing for distributed gw ports.

2024-08-07 Thread Numan Siddique
On Wed, Aug 7, 2024 at 3:53 PM Han Zhou wrote: > > On Wed, Aug 7, 2024 at 11:30 AM Numan Siddique wrote: > > > > On Wed, Aug 7, 2024 at 11:35 AM Han Zhou wrote: > > > > > > On Wed, Aug 7, 2024 at 7:18 AM Felix Huettner > > > wrote: > > > &

Re: [ovs-dev] [PATCH ovn v7 0/9] Add ACL Sampling using per-flow IPFIX.

2024-08-07 Thread Numan Siddique
On Wed, Aug 7, 2024 at 2:52 AM Dumitru Ceara wrote: > > This series adds support for sampling packets processed by ACLs by using > per-flow IPFIX. This new feature allows users to configure > (potentially) different sampling options for ACL matched traffic that > creates new connections or that i

Re: [ovs-dev] [PATCH ovn] ovn-controller: Support ovn-encap-ip-default option.

2024-08-07 Thread Numan Siddique
NFO_RL(&rl, "ovn-encap-ip-default (%s) must be one of the IPs " > + "in ovn-encap-ip.", encap_ip_default); > +return false; > +} Hi Han, Thanks for the patch. Lets say CMS has configured ovn-encap-ip = [127.0.0.1, 127.0.0.2, 127.0

Re: [ovs-dev] [PATCH ovn v2] controller, controller-vtep: Add --unixctl option.

2024-08-07 Thread Numan Siddique
On Wed, Aug 7, 2024 at 5:02 PM Dumitru Ceara wrote: > > On 8/1/24 18:21, Rosemarie O'Riorden wrote: > > All other OVN daemons have the --unixctl option to specify the control > > socket file. It was missing from ovn-controller and ovn-controller-vtep, > > which this patch fixes. > > > > Reported-a

Re: [ovs-dev] [PATCH ovn] tests: Cleanup more on_exit commands.

2024-08-07 Thread Numan Siddique
On Wed, Aug 7, 2024 at 7:28 AM Ales Musil wrote: > > On Thu, Jul 25, 2024 at 3:15 PM Xavier Simonart wrote: > > > Avoid unnecessary errors trying to stop or restart already > > stopped processes. > > Tests were not failing due to this, but potentially confusing errors were > > logged. > > > > Fix

Re: [ovs-dev] [PATCH ovn] tests: Remove almost duplicate macros.

2024-08-07 Thread Numan Siddique
On Wed, Aug 7, 2024 at 7:30 AM Ales Musil wrote: > > On Thu, Jul 25, 2024 at 3:16 PM Xavier Simonart wrote: > > > (stop/restart)_ovsdb_controller_updates macros (using nft) are now defined > > in ovn-macro.at. > > Remove similar implementations (using iptables) from system-ovn.at. > > > > Signed-

Re: [ovs-dev] [PATCH ovn] tests: Fix typo in read-only sb ssl-ciphers test.

2024-08-07 Thread Numan Siddique
On Thu, Aug 1, 2024 at 6:00 AM Vladislav Odintsov wrote: > > Though this typo does not affect test correctness, it is worth to be > fixed in a right way. > > Fixes: bcc650a29d3f ("tests: Fix ssl-ciphers RO sb test with old openssl.") > Signed-off-by: Vladislav Odintsov Thanks. Applied to main.

Re: [ovs-dev] [PATCH ovn v2] controller, controller-vtep: Add --unixctl option.

2024-08-08 Thread Numan Siddique
On Thu, Aug 8, 2024 at 3:31 AM Dumitru Ceara wrote: > > On 8/8/24 05:47, Numan Siddique wrote: > > On Wed, Aug 7, 2024 at 5:02 PM Dumitru Ceara wrote: > >> > >> On 8/1/24 18:21, Rosemarie O'Riorden wrote: > >>> All other OVN daemons have the --uni

Re: [ovs-dev] [PATCH ovn v3] northd: Add change handler for FDB updates.

2024-08-08 Thread Numan Siddique
On Wed, Jul 31, 2024 at 1:37 AM Ales Musil wrote: > > On Mon, Jul 29, 2024 at 11:56 AM Naveen Yerramneni < > naveen.yerramn...@nutanix.com> wrote: > > > This change avoids northd full recompute for FDB updates. > > Also, fixed incremental processing for port deletion to > > delete all fdb entries

Re: [ovs-dev] [PATCH ovn] ci: ovn-kubernetes: Move to stable release-1.0 branch.

2024-08-08 Thread Numan Siddique
On Thu, Aug 8, 2024 at 7:54 AM Dumitru Ceara wrote: > > Since https://github.com/ovn-org/ovn-kubernetes/pull/4333 ovn-kubernetes > has stable release branches. Use the latest in our CI to avoid > the instability of the ovn-kubernetes master branch. > > Reported-at: https://issues.redhat.com/brows

Re: [ovs-dev] [PATCH ovn] logical-fields: Add missing multicast matches for MLD and IGMP.

2024-08-08 Thread Numan Siddique
On Thu, Aug 8, 2024 at 3:17 PM Dumitru Ceara wrote: > > On 8/8/24 20:00, Ilya Maximets wrote: > > MLD flows are added to pipelines unconditionally in order to avoid > > sending such traffic through conntrack. The problem is that these > > matches turn into matches on ip6.dst that end up as exact

Re: [ovs-dev] [PATCH ovn] logical-fields: Add missing multicast matches for MLD and IGMP.

2024-08-08 Thread Numan Siddique
On Thu, Aug 8, 2024 at 5:22 PM Numan Siddique wrote: > > On Thu, Aug 8, 2024 at 3:17 PM Dumitru Ceara wrote: > > > > On 8/8/24 20:00, Ilya Maximets wrote: > > > MLD flows are added to pipelines unconditionally in order to avoid > > > sending such traffic thr

Re: [ovs-dev] [PATCH ovn] logical-fields: Add missing multicast matches for MLD and IGMP.

2024-08-08 Thread Numan Siddique
On Thu, Aug 8, 2024 at 5:26 PM Numan Siddique wrote: > > On Thu, Aug 8, 2024 at 5:22 PM Numan Siddique wrote: > > > > On Thu, Aug 8, 2024 at 3:17 PM Dumitru Ceara wrote: > > > > > > On 8/8/24 20:00, Ilya Maximets wrote: > > > > MLD flows are adde

Re: [ovs-dev] [PATCH OVN] Add "disable_arp_nd_rsp" option to LSP

2024-08-08 Thread Numan Siddique
, 2024 at 5:38 PM Numan Siddique wrote: > > On Thu, Feb 15, 2024 at 8:46 PM Naveen Yerramneni > wrote: > > > > > > > > > On 12-Feb-2024, at 8:36 PM, Ihar Hrachyshka wrote: > > > > > > On Tue, Jan 30, 2024 at 10:52 PM Naveen Yerramneni > &

Re: [ovs-dev] [Patch ovn v8] Text representations for drop sampling.

2024-08-09 Thread Numan Siddique
On Thu, Aug 8, 2024 at 3:01 PM Dumitru Ceara wrote: > > On 8/8/24 19:09, Jacob Tanenbaum wrote: > > Created a new column in the southbound database to hardcode a human readable > > description for flows. This first use is describing why the flow is > > dropping packets. > > The new column is call

Re: [ovs-dev] [PATCH ovn v3] tests: Add system tests for MAC_Binding.

2024-08-09 Thread Numan Siddique
On Mon, Jul 29, 2024 at 7:16 AM Naveen Yerramneni wrote: > > 1. Test to validate traffic that needs ARP resolution > when SB is disconnected. > 2. Test to validate MAC binding buffer limit when SB > is disconnected. > > Signed-off-by: Naveen Yerramneni Thanks. Applied to main. Numan > --- > v

Re: [ovs-dev] [PATCH ovn 0/2] github: Fixes for workflows on forks.

2024-08-09 Thread Numan Siddique
On Wed, Aug 7, 2024 at 7:50 AM Ales Musil wrote: > > On Mon, Jul 29, 2024 at 2:40 PM Ilya Maximets wrote: > > > > > Ilya Maximets (2): > > github: Don't run scheduled workflows on forks. > > github: Fix running multi-node tests on forks. > > > > .github/workflows/containers.yml

Re: [ovs-dev] [PATCH ovn 1/2] Prepare for 24.09.0.

2024-08-09 Thread Numan Siddique
On Fri, Aug 9, 2024 at 10:01 AM Mark Michelson wrote: With your Signed-off-by tag added: Acked-by: Numan Siddique Numan > > --- > NEWS | 4 ++-- > configure.ac | 2 +- > debian/changelog | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) >

Re: [ovs-dev] [PATCH ovn 2/2] Prepare for post-24.09.0.

2024-08-09 Thread Numan Siddique
With your Signed-off-by tag added: Acked-by: Numan Siddique Numan On Fri, Aug 9, 2024 at 10:02 AM Mark Michelson wrote: > > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) >

Re: [ovs-dev] [Patch ovn v7] northd: Routing protocol port redirection.

2024-08-09 Thread Numan Siddique
On Fri, Aug 9, 2024 at 2:42 PM Martin Kalcok wrote: > > This change adds two new LRP options: > * routing-protocol-redirect > * routing-protocols > > These allow redirection of a routing protocol traffic to > an Logical Switch Port. This enables external routing daemons > to listen on an interfa

Re: [ovs-dev] [PATCH ovn v1] Reply only for multicast IPv6 Neigh Solicitation packets.

2024-08-14 Thread Numan Siddique
On Mon, Aug 12, 2024 at 9:10 AM Ilya Maximets wrote: > > On 8/12/24 06:16, num...@ovn.org wrote: > > From: Numan Siddique > > > > IPv6 Neigh Solicitation (NS) responder logical flows match on ip6.dst > > field. These flows when translated to datapath flows also mat

Re: [ovs-dev] [PATCH ovn v2] Reply only for the multicast ND solicitations.

2024-08-15 Thread Numan Siddique
On Thu, Aug 15, 2024 at 6:38 AM Dumitru Ceara wrote: > > On 8/15/24 05:02, num...@ovn.org wrote: > > From: Numan Siddique > > > > IPv6 ND Solicitation (NS) responder logical flows match on ip6.dst > > field. These flows when translated to datapath flows also match

Re: [ovs-dev] [PATCH ovn v3] Reply only for the multicast ND solicitations.

2024-08-16 Thread Numan Siddique
On Fri, Aug 16, 2024, 5:38 AM Dumitru Ceara wrote: > On 8/15/24 18:52, num...@ovn.org wrote: > > From: Numan Siddique > > > > IPv6 ND Solicitation (NS) responder logical flows match on ip6.dst > > field. These flows when translated to datapath flows also match on

Re: [ovs-dev] [PATCH ovn v3] Reply only for the multicast ND solicitations.

2024-08-16 Thread Numan Siddique
On Fri, Aug 16, 2024 at 8:13 AM Ilya Maximets wrote: > > On 8/15/24 18:52, num...@ovn.org wrote: > > From: Numan Siddique > > > > IPv6 ND Solicitation (NS) responder logical flows match on ip6.dst > > field. These flows when translated to datapath flows also match

Re: [ovs-dev] [PATCH ovn branch-23.06 1/2] Set release date for 23.06.5.

2024-08-16 Thread Numan Siddique
On Thu, Aug 15, 2024 at 3:16 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 ++- > debian/changelog | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS >

Re: [ovs-dev] [PATCH ovn branch-23.06 1/2] Set release date for 23.06.5.

2024-08-16 Thread Numan Siddique
On Fri, Aug 16, 2024 at 11:46 AM Numan Siddique wrote: > > On Thu, Aug 15, 2024 at 3:16 PM Mark Michelson wrote: > > > > Signed-off-by: Mark Michelson > > Acked-by: Numan Siddique Hi Mark, I just noticed that the changelog in the branch-23.03, branch-23.06 and bran

Re: [ovs-dev] [PATCH ovn branch-23.06 2/2] Prepare for 23.06.6.

2024-08-16 Thread Numan Siddique
OVN team ] > + * New upstream version > + > + -- OVN team Thu, 15 Aug 2024 15:07:30 -0400 > + Please change the package name to lowercase "ovn". More context here - https://github.com/ovn-org/ovn/commit/2084f06aafdac5589b7bb67ebaeb3fca4c9b7d5f With that fixed

Re: [ovs-dev] [PATCH ovn branch-23.09 0/2] Release patches for v23.09.5.

2024-08-16 Thread Numan Siddique
s(+), 3 deletions(-) With the package name in debian/changelog fixed to lowercase, for both the patches in the series: Acked-by: Numan Siddique Numan > > -- > 2.45.2 > > ___ > dev mailing list > d...@openvswitch.org >

Re: [ovs-dev] [PATCH ovn branch-24.03 1/2] Set release date for 24.03.3.

2024-08-16 Thread Numan Siddique
On Thu, Aug 15, 2024 at 3:17 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 ++- > debian/changelog | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS >

Re: [ovs-dev] [PATCH ovn branch-24.03 2/2] Prepare for 24.03.4.

2024-08-16 Thread Numan Siddique
team ] > + * New upstream version > + > + -- OVN team Thu, 15 Aug 2024 15:10:20 -0400 > + With the package name in debian/changelog fixed to lowercase: Acked-by: Numan Siddique Numan > ovn (24.03.3-1) unstable; urgency=low > [ OVN team ] >

Re: [ovs-dev] [PATCH ovn] tests: Skip "IPv6 switching - megaflow check" if scapy is not installed.

2024-08-19 Thread Numan Siddique
On Mon, Aug 19, 2024 at 9:08 AM Dumitru Ceara wrote: > > On 8/19/24 04:57, num...@ovn.org wrote: > > From: Numan Siddique > > > > Otherwise the test blocks indefinitely. > > > > Fixes: 2e7f318c9b54 ("Reply only for the multicast ND solicitat

Re: [ovs-dev] [PATCH ovn] northd: Fix potential crash when creating chassisredirect port.

2024-08-20 Thread Numan Siddique
On Mon, Aug 19, 2024 at 7:11 PM Han Zhou wrote: > > On Mon, Aug 19, 2024 at 9:18 AM wrote: > > > > From: Numan Siddique > > > > Commit 8d13579bf5b3 creates a chassisredirect port for a logical switch > > port (of type 'router') in certain scenarios

Re: [ovs-dev] [PATCH ovn] AUTHORS: Update email for Rosemarie O'Riorden.

2024-08-20 Thread Numan Siddique
On Thu, Aug 15, 2024 at 4:25 PM Rosemarie O'Riorden wrote: > > Signed-off-by: Rosemarie O'Riorden Thanks. Applied to main. Numan > --- > .mailmap| 1 + > AUTHORS.rst | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/.mailmap b/.mailmap > index 977d160e4..263a58a5

Re: [ovs-dev] [PATCH ovn v2] pinctrl: Explicitly set ICMPv6 code for packet too big.

2024-08-29 Thread Numan Siddique
On Thu, Aug 29, 2024 at 11:13 AM Ales Musil wrote: > > The ICMPv6 code was set to 1 which is wrong for the packet too big > which is wrong, the code should always remain 0. This resulted in > wrong csum being computed. Set the code to 0 explicitly. > > Fixes: 4725ad125b42 ("controller: Avoid doubl

Re: [ovs-dev] [PATCH ovn branch-24.09 1/2] Set release date for 24.09.0.

2024-09-05 Thread Numan Siddique
On Thu, Sep 5, 2024 at 1:12 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 2 +- > debian/changelog | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS >

Re: [ovs-dev] [PATCH ovn branch-24.09 2/2] Prepare for 24.09.1.

2024-09-05 Thread Numan Siddique
On Thu, Sep 5, 2024 at 1:12 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > &g

Re: [ovs-dev] [PATCH ovn v9 3/5] ovn-controller: Handle datapath changes incrementally for ct zone I-P engine node.

2021-06-14 Thread Numan Siddique
On Mon, Jun 14, 2021 at 3:28 AM Han Zhou wrote: > > On Thu, Jun 3, 2021 at 5:29 AM wrote: > > > > From: Numan Siddique > > > > After the commit [1], we do a full recompute of ct zone I-P engine for > > any datapath binding change. This results in physi

Re: [ovs-dev] [PATCH ovn v9 3/5] ovn-controller: Handle datapath changes incrementally for ct zone I-P engine node.

2021-06-14 Thread Numan Siddique
On Mon, Jun 14, 2021 at 7:14 AM Numan Siddique wrote: > > On Mon, Jun 14, 2021 at 3:28 AM Han Zhou wrote: > > > > On Thu, Jun 3, 2021 at 5:29 AM wrote: > > > > > > From: Numan Siddique > > > > > > After the commit [1], we do a full recomput

Re: [ovs-dev] [PATCH ovn v9 3/5] ovn-controller: Handle datapath changes incrementally for ct zone I-P engine node.

2021-06-14 Thread Numan Siddique
On Mon, Jun 14, 2021 at 7:20 AM Numan Siddique wrote: > > On Mon, Jun 14, 2021 at 7:14 AM Numan Siddique wrote: > > > > On Mon, Jun 14, 2021 at 3:28 AM Han Zhou wrote: > > > > > > On Thu, Jun 3, 2021 at 5:29 AM wrote: > > > > > > > &g

Re: [ovs-dev] [PATCH ovn v9 0/5] ovn-controller: Split logical flow and physical flow processing

2021-06-14 Thread Numan Siddique
chelson wrote: > > > Hi Numan, For patches 2-5, > > > > Acked-by: Mark Michelson > > > > For patch 1, it all looks understandable to me, but I will defer to Han > > for an authoritative ACK. I'll still give my provisional: > > > > Acked-by:

Re: [ovs-dev] [PATCH v3] [python] Don't mix system poll/monkeypatched select

2021-06-14 Thread Numan Siddique
successfully (SO_ERROR is one of the usual error codes listed > here, explaining the reason for the failure) > > so this patch does that instead. > > Signed-off-by: Terry Wilson Thanks for addressing this. LGTM Acked-by: Numan Siddique Thanks Numan > --- > pytho

Re: [ovs-dev] [PATCH ovn] northd: Add support for DHCP Option 12 (Hostname)

2021-06-14 Thread Numan Siddique
On Fri, May 28, 2021 at 7:32 AM Vladislav Odintsov wrote: > > DHCP Option Hostname is a per-Logical_Switch_Port property, configured in > Logical_Switch_Port's options:hostname field. It is used if DHCPv4 is > enabled for this LSP. > > Signed-off-by: Vladislav Odintsov Thanks for the patch. Eac

Re: [ovs-dev] [External] : [PATCH ovn v2] ovn-northd.c: Add proxy ARP support to OVN

2021-06-14 Thread Numan Siddique
On Mon, Jun 14, 2021 at 5:19 AM Brendan Doyle wrote: > > Hi, > > Just wondering how to move this along. It's been in the queue a while now. > The product I'm working on requires this feature and If I can't get it > upstream > I'll need to look at other options. Hi Brendan, Sorry for the late rep

Re: [ovs-dev] [External] : [PATCH ovn v2] ovn-northd.c: Add proxy ARP support to OVN

2021-06-15 Thread Numan Siddique
On Tue, Jun 15, 2021 at 7:50 AM Brendan Doyle wrote: > > > > On 14/06/2021 21:17, Numan Siddique wrote: > > On Mon, Jun 14, 2021 at 5:19 AM Brendan Doyle > > wrote: > >> Hi, > >> > >> Just wondering how to move this along. It's been i

Re: [ovs-dev] [PATCH ovn] northd: Add support for DHCP Option 12 (Hostname)

2021-06-15 Thread Numan Siddique
requirement is to set the hostname for each of the VMs, then I'm fine with your approach. Can you please also update the documentation in ovn-nb.xml in tthe DHCP_Options table section ? Thanks Numan > > Let me know your thoughts on this, please. > > Regards, > Vladislav Odintsov

Re: [ovs-dev] [External] : [PATCH ovn v2] ovn-northd.c: Add proxy ARP support to OVN

2021-06-15 Thread Numan Siddique
On Tue, Jun 15, 2021 at 8:34 AM Brendan Doyle wrote: > > > > On 15/06/2021 13:26, Numan Siddique wrote: > > On Tue, Jun 15, 2021 at 7:50 AM Brendan Doyle > > wrote: > >> > >> > >> On 14/06/2021 21:17, Numan Siddique wrote: > >>&

Re: [ovs-dev] [PATCH ovn] northd: Add support for DHCP Option 12 (Hostname)

2021-06-15 Thread Numan Siddique
uperseded" or "changes requested". Please take a look at the present queue - https://patchwork.ozlabs.org/project/ovn/list/? Thanks Numan > > Regards, > Vladislav Odintsov > > > On 15 Jun 2021, at 15:35, Numan Siddique wrote: > > > > On Tue, Jun 15, 2021 at

Re: [ovs-dev] [PATCH ovn] northd: Reduce number of logical flow allocations.

2021-06-15 Thread Numan Siddique
On Tue, Jun 1, 2021 at 9:33 AM Dumitru Ceara wrote: > > There's no need to allocate a logical flow structure if we're going to > merge it to an existing one that refers to a datapath group. > > This saves a lot of xstrdup() calls followed immediately by free(). > > Reported-at: https://bugzilla.re

Re: [ovs-dev] [PATCH ovn 1/2] ofctrl: Remove unused hashmap.

2021-06-15 Thread Numan Siddique
On Tue, Jun 15, 2021 at 9:28 AM Mark Michelson wrote: > > On 6/15/21 9:24 AM, Mark Michelson wrote: > > Signed-off-by: Mark Michelson For both the patches in the series: Acked-by: Numan Siddique > > --- > > controller/ofctrl.c | 1 - > > 1 file changed, 1 de

Re: [ovs-dev] [PATCH ovn v2 3/3] northd: Precompute load balancer IP sets.

2021-06-15 Thread Numan Siddique
On Thu, Jun 10, 2021 at 8:48 AM Dumitru Ceara wrote: > > There's no need to parse the IP sets every time we iterate through them. > It's enough to parse them once for every main loop iteration. > > Reported-at: https://bugzilla.redhat.com/1962338 > Signed-off-by: Dumitru Ceara Thanks for the ser

Re: [ovs-dev] [PATCH ovn v4 0/2] controller-vtep: Fix MMR creation and commit only changed data

2021-06-15 Thread Numan Siddique
On Tue, Jun 15, 2021 at 12:27 PM Vladislav Odintsov wrote: > > This series fixes duplicated MMR records in VTEP Database, which > previously was created for each port binding. > Also, now VTEP Logical_Switch's tunnel_key and replication_mode > are committed only if needed. Thanks Vladislav for th

Re: [ovs-dev] [PATCH v3 ovn 0/5] Handle DNAT/no-NAT conntrack tuple collisions if possible.

2021-06-15 Thread Numan Siddique
On Fri, Jun 11, 2021 at 6:11 AM Dumitru Ceara wrote: > > This depends on the following OVS patch to be accepted: > > https://patchwork.ozlabs.org/project/openvswitch/patch/162264080113.315078.1220132318734842720.stgit@ebuild/ > > However, the capability name, "ct_zero_snat" has been agreed upon so

Re: [ovs-dev] [PATCH ovn v4 0/2] controller-vtep: Fix MMR creation and commit only changed data

2021-06-15 Thread Numan Siddique
all the branches, let me know if I have > to > send backports or you can do it by yourself. Done. The patches applied cleanly to all the branches. Thanks Numan > > > Regards, > Vladislav Odintsov > > > On 15 Jun 2021, at 21:00, Numan Siddique wrote: > >

Re: [ovs-dev] [ovn] howto? L3 support in HW VTEP

2021-06-18 Thread Numan Siddique
On Fri, Jun 18, 2021 at 7:42 AM Vladislav Odintsov wrote: > > Hi all, > > I’m trying to implement support for L3 routing between OVN and HW VTEP > devices. > In my setup I use Cumulus Linux-managed Mellanox SN2000 switches. > Current L2 functionality in this setup works well: ovn-controller-vtep

Re: [ovs-dev] [PATCH ovn branch-21.06 v6 0/2] Release patches for v21.06.0.

2021-06-18 Thread Numan Siddique
| 2 +- > > debian/changelog | 6 +++--- > > 3 files changed, 7 insertions(+), 7 deletions(-) > > > > This one looks correct to me. Thanks! > > Acked-by: Ilya Maximets For the series: Acked-by: Numan Siddique Numan > ___

Re: [ovs-dev] [PATCH v3 ovn 0/5] Handle DNAT/no-NAT conntrack tuple collisions if possible.

2021-06-18 Thread Numan Siddique
On Tue, Jun 15, 2021 at 4:52 PM Numan Siddique wrote: > > On Fri, Jun 11, 2021 at 6:11 AM Dumitru Ceara wrote: > > > > This depends on the following OVS patch to be accepted: > > > > https://patchwork.ozlabs.org/project/openvswitch/patch/162264080113.315078.12

Re: [ovs-dev] [PATCH ovn] northd: do not centralized traffic for unclaimed virtual ports

2021-06-21 Thread Numan Siddique
On Fri, Jun 4, 2021 at 12:55 PM Lorenzo Bianconi wrote: > > Add a rule to drop traffic from a distributed NAT if the virtual > port has not claimed yet becaused otherwise the traffic will be > centralized misconfiguring the TOR switch. > > https://bugzilla.redhat.com/show_bug.cgi?id=1952961 > Sign

Re: [ovs-dev] [PATCH v3 2/3] northd: enable check_pkt_larger for gw router

2021-06-21 Thread Numan Siddique
On Fri, Jun 11, 2021 at 10:32 AM Lorenzo Bianconi wrote: > > As it is already done for distributed gw router scenario, introduce > check_pkt_larger logical flows for gw router use case. > > Signed-off-by: Lorenzo Bianconi Hi Lorenzo, Thanks for the patches. You forgot to put the "ovn" tag in t

Re: [ovs-dev] [PATCH v3 3/3] northd: add check_pkt_larger lflows for ingress traffic

2021-06-21 Thread Numan Siddique
On Fri, Jun 11, 2021 at 10:32 AM Lorenzo Bianconi wrote: > > Introduce check_pkt_larger action for ingress traffic > entering the cluster from a distributed gw router port > or from a gw router. This patch enables pMTU discovery > for ingress traffic. > > Signed-off-by: Lorenzo Bianconi Hi Lore

Re: [ovs-dev] [PATCH ovn v3] northd: Add support for DHCP Option 12 (Hostname)

2021-06-22 Thread Numan Siddique
On Tue, Jun 15, 2021 at 11:34 AM Vladislav Odintsov wrote: > > DHCP option Hostname (opcode 12) can be configured in > Logical_Switch_Port as well as in DHCP_Options table's > options:hostname column. If both methods of configuration were > used, Logical_Switch_Port's setting takes precedence. > >

Re: [ovs-dev] [PATCH ovn] Disable ARP/NA responders for vlan-passthru switches

2021-06-22 Thread Numan Siddique
On Tue, Jun 15, 2021 at 8:40 PM Ihar Hrachyshka wrote: > > When vlan-passthru is on, VIFs may attach different VLAN tags. In this > case, VIFs are not guaranteed to belong to the same L2 broadcast domain. > Because of that, we don't know if a peer port on the switch has the same > tag used and sho

Re: [ovs-dev] [PATCH ovn v3 3/3] ovn-controller: Fix incremental processing for logical port references.

2021-06-23 Thread Numan Siddique
On Mon, Jun 21, 2021 at 2:52 AM Han Zhou wrote: > > If a lflow has an lport name in the match, but when the lflow is > processed the port-binding is not seen by ovn-controller, the > corresponding openflow will not be created. Later if the port-binding is > created/monitored by ovn-controller, the

Re: [ovs-dev] [PATCH ovn] controller: Fix the wrong 'struct' type for 'pflow_output_data'.

2021-06-23 Thread Numan Siddique
On Wed, Jun 23, 2021 at 11:26 AM Mark Michelson wrote: > > Acked-by: Mark Michelson Thanks. Applied to the main branch. Numan > > On 6/22/21 4:10 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > 'pflow_output_data' should be of type &

Re: [ovs-dev] [ovn] did we ever get OVN set up as an official LF project?

2021-06-23 Thread Numan Siddique
On Wed, Jun 23, 2021 at 1:58 PM Ben Pfaff wrote: > > I don't see the charter, etc. in the OVN tree. I know we started the > process but I don't know whether we finished it. I'm not sure about the official status but I presumed that OVN is part of LF. Trishan de Lanerolle (CC'ed) has reached out

Re: [ovs-dev] [PATCH ovn v3 3/3] ovn-controller: Fix incremental processing for logical port references.

2021-06-24 Thread Numan Siddique
On Wed, Jun 23, 2021 at 8:10 PM Han Zhou wrote: > > On Wed, Jun 23, 2021 at 7:48 AM Numan Siddique wrote: > > > > On Mon, Jun 21, 2021 at 2:52 AM Han Zhou wrote: > > > > > > If a lflow has an lport name in the match, but when the lflow is > > >

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix port group I-P when they contain non-vif ports.

2021-06-25 Thread Numan Siddique
On Fri, Jun 25, 2021 at 7:51 AM Dumitru Ceara wrote: > > It's valid that port_groups contain non-vif ports, they can actually > contain any type of logical_switch_port. > > Also, there's no need to allocate a new sset containing the local ports' > names every time the I-P engine processes a change

Re: [ovs-dev] [PATCH ovn v2 2/2] ovn-macros.at: Enable northd parallelization

2021-06-25 Thread Numan Siddique
On Tue, Jun 22, 2021 at 7:09 PM Fabrizio D'Angelo wrote: > > - Add NORTHD_USE_PARALLELIZATION variable to enable it in ovn_start. > > - Add NORTHD_DUMMY_NUMA variable for passing --dummy-numa flag when > tests are run in a low CPU system. > > Signed-off-by: Fabrizio D'Angelo > Acked-by: Mark Mi

Re: [ovs-dev] [External] : [PATCH ovn v3] ovn-northd.c: Add proxy ARP support to OVN

2021-06-25 Thread Numan Siddique
On Thu, Jun 24, 2021 at 5:14 AM Brendan Doyle wrote: > > Hi, > > Just wondering how to move this along. It's been in the queue a while now. > I've made the requested changes, this is v3 of the patch. > > The product I'm working on requires this feature and If I can't get it > upstream > I'll need

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix port group I-P when they contain non-vif ports.

2021-06-25 Thread Numan Siddique
On Fri, Jun 25, 2021 at 2:53 PM Han Zhou wrote: > > On Fri, Jun 25, 2021 at 4:50 AM Dumitru Ceara wrote: > > > > It's valid that port_groups contain non-vif ports, they can actually > > contain any type of logical_switch_port. > > > > Also, there's no need to allocate a new sset containing the lo

Re: [ovs-dev] [External] : [PATCH ovn v3] ovn-northd.c: Add proxy ARP support to OVN

2021-06-27 Thread Numan Siddique
r 'https://brendandoy...@github.com': > > remote: Permission to ovn-org/ovn.git denied to BrendanDoyle1. > > fatal: unable to access 'https://github.com/ovn-org/ovn/': The > > requested URL returned error: 403 > If the v4 does not work I'll have to wa

Re: [ovs-dev] [PATCH ovn] ovn-northd-ddlog: Fix build errror due to wrong ovs-numa.h path.

2021-06-28 Thread Numan Siddique
On Mon, Jun 28, 2021 at 11:25 AM Dumitru Ceara wrote: > > Fixes: 37ad427cfb78 ("northd: Port dummy-numa cli option from OVS") > Signed-off-by: Dumitru Ceara Oops. Thanks for fixing it. I applied. Thanks Numan > --- > northd/ovn-northd-ddlog.c | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [ovs-dev] [ovn] howto? L3 support in HW VTEP

2021-06-28 Thread Numan Siddique
Ucast_Macs_Remote record in VTEP DB. > > networks: ["192.168.2.1/24”] # When physical host sends traffic > > to its chassis, routing between sw1 and sw2 works. > > gateway chassis: [9721a9e9-73ef-4a9a-8a50-afa84811c6ef] > > > > > > OV

Re: [ovs-dev] [PATCH ovn v5] ovn-northd.c: Add proxy ARP support to OVN

2021-06-29 Thread Numan Siddique
On Tue, Jun 29, 2021 at 7:48 AM Brendan Doyle wrote: > > Numan, > > Did this version apply ? I'm guessing not. This was generated with git > mail. But I don't see > an entry in https://patchwork.ozlabs.org/project/ovn/list/ > for it. Please let me know if this has issue, if so I'll try generate a

Re: [ovs-dev] [PATCH ovn] northd-ddlog: Add proxy arp flows for configured addresses in lsp router port.

2021-06-29 Thread Numan Siddique
Hi Ben, This patch is not working as expected. Need your help here. Not very urgent. Please see below. Thanks Numan On Tue, Jun 29, 2021 at 12:09 PM wrote: > > From: Numan Siddique > > The commit [1] didn't add the ddlog part. > > [1] - 8087cbc7462("ovn-northd

Re: [ovs-dev] [External] : [PATCH ovn] northd-ddlog: Add proxy arp flows for configured addresses in lsp router port.

2021-06-29 Thread Numan Siddique
On Tue, Jun 29, 2021 at 2:29 PM Brendan Doyle wrote: > > > Thanks for doing the ddlog for this, comment below > > On 29/06/2021 17:08, num...@ovn.org wrote: > > From: Numan Siddique > > > > The commit [1] didn't add the ddlog part. > > > > [1]

Re: [ovs-dev] [PATCH ovn] northd: avoid memory reallocation while building ACL and QoS rules

2021-06-29 Thread Numan Siddique
On Tue, Jun 22, 2021 at 5:22 PM Mark Michelson wrote: > > On 6/22/21 1:14 PM, Dan Williams wrote: > > On Fri, 2021-06-18 at 21:49 +0200, Dumitru Ceara wrote: > >> On 6/4/21 10:00 PM, Dan Williams wrote: > >>> Inspried by: > >>> > >>> 3b6362d64e86b northd: Avoid memory reallocation while building l

Re: [ovs-dev] [PATCH ovn v8 4/6] northd: Add IP routing and ARP resolution flows for NAT/LB addresses.

2021-06-29 Thread Numan Siddique
On Thu, Jun 3, 2021 at 2:50 PM Mark Michelson wrote: > > Dealing with NAT and load balancer IPs has been a bit of a pain point. > It requires creating static routes if east-west traffic to those > addresses is desired. Further, it requires ARPs to be sent between the > logical routers in order to

Re: [ovs-dev] [PATCH ovn] Set release date for 21.06.0.

2021-06-29 Thread Numan Siddique
On Tue, Jun 29, 2021 at 4:57 PM Mark Michelson wrote: > > Thanks for fixing my error, Numan. > > Acked-by: Mark Michelson Thanks. I applied to the main branch. Numan > > On 6/25/21 8:00 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > And also p

Re: [ovs-dev] [PATCH v2 ovn 0/9] northd: rework ovn-northd lb flow installation

2021-06-29 Thread Numan Siddique
On Fri, Jun 18, 2021 at 9:04 AM Lorenzo Bianconi wrote: > > Rework lb flow logic in order to visit first each load_balancer and then > related datapath during lb flow installation. > This patch allows to reduce memory footprint and cpu utilization in > ovn-northd. > Hi Lorenzo, The ovsrobot CI r

Re: [ovs-dev] [RFC PATCH ovn] Introduce representor port plugging support

2021-06-29 Thread Numan Siddique
On Thu, Jun 10, 2021 at 10:13 AM Frode Nordahl wrote: > > On Thu, Jun 10, 2021 at 1:46 PM Ilya Maximets wrote: > > > > On 6/10/21 8:36 AM, Han Zhou wrote: > > > > > > > > > On Thu, May 13, 2021 at 9:25 AM Frode Nordahl > > > mailto:frode.nord...@canonical.com>> wrote: > > >> > > >> On Thu, May 1

Re: [ovs-dev] [PATCH ovn v8 0/6] ARP and Floating IP Fixes

2021-06-30 Thread Numan Siddique
On Thu, Jun 3, 2021 at 2:50 PM Mark Michelson wrote: > > This patch series aims to fix issues seen in OpenStack deployments when > floating IPs were assigned to routers, and those floating IPs were not > part of any subnet configured on that router. > > Originally, this was a two patch series but

Re: [ovs-dev] [PATCH ovn 1/3] system-ovn.at: fix typo

2021-06-30 Thread Numan Siddique
On Tue, Jun 22, 2021 at 1:17 AM Han Zhou wrote: > > Acked-by: Han Zhou Thanks, I applied this patch. Numan > > On Sat, Jun 19, 2021 at 2:51 AM Mark Gray wrote: > > > Signed-off-by: Mark Gray > > --- > > tests/system-ovn.at | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > d

Re: [ovs-dev] ovn-northd-ddlog scale issues

2021-07-01 Thread Numan Siddique
On Thu, Jul 1, 2021 at 4:31 AM Dumitru Ceara wrote: > > On 7/1/21 9:18 AM, Ben Pfaff wrote: > > On Tue, Jun 29, 2021 at 03:32:26PM -0700, Ben Pfaff wrote: > >> On Mon, Jun 28, 2021 at 05:40:53PM +0200, Dumitru Ceara wrote: > >>> On 5/20/21 5:50 PM, Ben Pfaff wrote: > On Thu, May 20, 2021 at 0

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Fix port group I-P when they contain non-vif ports.

2021-07-01 Thread Numan Siddique
On Wed, Jun 30, 2021 at 7:04 PM Han Zhou wrote: > > On Wed, Jun 30, 2021 at 7:01 AM Dumitru Ceara wrote: > > > > It's valid that port_groups contain non-vif ports, they can actually > > contain any type of logical_switch_port. > > > > Also, there's no need to allocate a new sset containing the lo

Re: [ovs-dev] [PATCH ovn v4] ovn-controller: Fix incremental processing for logical port references.

2021-07-01 Thread Numan Siddique
n the lflow is firstly parsed. A test case is also added to > cover the scenario. > > Signed-off-by: Han Zhou LGTM Acked-by: Numan Siddique Numan > --- > v3 -> v4: Updated the test case to cover: > - when the referenced lport is removed > - when the ref

Re: [ovs-dev] [PATCH ovn v2] northd-ddlog: Add proxy arp flows for configured addresses in lsp router port.

2021-07-01 Thread Numan Siddique
On Thu, Jul 1, 2021 at 1:45 PM Ben Pfaff wrote: > > On Thu, Jul 01, 2021 at 08:45:21AM -0400, num...@ovn.org wrote: > > From: Numan Siddique > > > > The commit [1] didn't add the ddlog part. > > > > [1] - 8087cbc7462("ovn-northd.c: Add proxy ARP

Re: [ovs-dev] [PATCH ovn 0/4] Fix test "ovn -- vlan traffic for external network with distributed router gateway port"

2021-07-02 Thread Numan Siddique
rove debuggability in gratuitous ARP test. > Thanks for the fix and for the bonus fixes For the entire series: Acked-by: Numan siddique Numan > tests/ovn.at | 144 ++- > 1 file changed, 74 insertions(+), 70 deletions(-) > > -- >

Re: [ovs-dev] [PATCH ovn] northd-ddlog: Add proxy arp flows for configured addresses in lsp router port.

2021-07-02 Thread Numan Siddique
commas, since extract_ip_addresses() doesn't support comma separated strings of ip addresses. Thanks Numan > > On Tue, Jun 29, 2021 at 02:01:19PM -0400, Numan Siddique wrote: > > Hi Ben, > > > > This patch is not working as expected. Need your help here. Not

Re: [ovs-dev] [PATCH ovn] add ovn-kubernetes job to github actions

2021-07-05 Thread Numan Siddique
On Thu, Jul 1, 2021 at 2:36 PM wrote: > > From: Antonio Ojea > > It allows to specify the ovn-kubernetes commits to test against. > > Submitted-at: https://github.com/ovn-org/ovn/pull/61 > Signed-off-by: Antonio Ojea Thanks for the PR. I applied this patch to the main branch. Numan > --- >

Re: [ovs-dev] [RFC PATCH ovn] Introduce representor port plugging support

2021-07-05 Thread Numan Siddique
On Mon, Jul 5, 2021 at 12:12 PM Frode Nordahl wrote: > > On Wed, Jun 30, 2021 at 12:32 AM Numan Siddique wrote: > > > > On Thu, Jun 10, 2021 at 10:13 AM Frode Nordahl > > wrote: > > > > > > On Thu, Jun 10, 2021 at 1:46 PM Ilya Maximets wrote: > >

Re: [ovs-dev] [PATCH v6 ovn 1/8] northd: move snat_type out of vip loop

2021-07-05 Thread Numan Siddique
On Mon, Jul 5, 2021 at 12:08 PM Lorenzo Bianconi wrote: > > Move snat_type out of vip loop in build_lrouter_lb_flows() since there > is not vip dependency > > Acked-by: Dumitru Ceara > Signed-off-by: Lorenzo Bianconi Thanks. I applied this patch to the main branch. Numan > --- > northd/ovn-

<    1   2   3   4   5   6   7   8   9   10   >