On Wed, May 13, 2020 at 7:24 PM Dumitru Ceara wrote:
> On 5/11/20 11:46 AM, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > If ofctrl_check_and_add_flow(F') is called where flow F' has
> match-actions (M, A2)
> > and if there already exists a fl
On Fri, May 15, 2020 at 5:22 PM Dumitru Ceara wrote:
> On 5/15/20 12:17 PM, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > Fixes the memory leak because of this.
> >
> > Signed-off-by: Numan Siddique
>
> Looks good to me.
>
> Acked-by:
On Fri, May 15, 2020 at 8:23 PM Ihar Hrachyshka wrote:
> On 5/11/20 10:15 AM, Ihar Hrachyshka wrote:
> > On 5/8/20 2:17 PM, Numan Siddique wrote:
> >>
> >>
> >> On Fri, May 8, 2020 at 9:58 PM Ihar Hrachyshka >> <mailto:ihrac...@redhat.com>>
On Thu, May 14, 2020 at 4:00 PM Dumitru Ceara wrote:
> On 5/13/20 3:38 PM, Ihar Hrachyshka wrote:
> > Hi all,
> >
> > This series is to allow for multiple localnet ports to be present in a
> > logical switch. Even before the series, it was allowed to create
> > multiple ports of this kind but
On Fri, May 15, 2020 at 10:42 PM Ihar Hrachyshka
wrote:
> On 5/15/20 12:24 PM, Numan Siddique wrote:
> > On Fri, May 15, 2020 at 8:23 PM Ihar Hrachyshka
> wrote:
> >
> >> On 5/11/20 10:15 AM, Ihar Hrachyshka wrote:
> >>> On 5/8/20 2:17 PM, Numan Siddique w
On Fri, May 15, 2020 at 1:45 PM Tao YunXiang <
taoyunxi...@cmss.chinamobile.com> wrote:
> This change will check the existence of lr-policy uuid.
> If not, it will print "uuid is not found".
>
> Fixes: 1b030874c32("ovn-nbctl.c: Add an optional way to delete router
> policy by uuid")
>
>
> Author:
On Wed, May 13, 2020 at 6:53 PM Dumitru Ceara wrote:
> On 5/13/20 2:56 PM, Ilya Maximets wrote:
> > 'sset_array' allocates new array that must be freed by the caller:
> >
> > 640 bytes in 40 blocks are definitely lost in loss record 73 of 74
> > at 0x483980B: malloc
134: prepare_ipv6_prefixd (pinctrl.c:1209)
> > by 0x41FC57: pinctrl_run (pinctrl.c:2930)
> > by 0x4096BB: main (ovn-controller.c:2101)
> >
> > CC: Numan Siddique
> > CC: Lorenzo Bianconi
> > Fixes: 8be01f4a5329 ("Send service monitor hea
On Thu, May 14, 2020 at 1:36 AM Mark Michelson wrote:
> Acked-by: Mark Michelson
>
>
Thanks Ilya and Mark. I applied this patch to master.
Numan
> On 5/13/20 1:12 PM, Ilya Maximets wrote:
> > GCC 9 complains:
> > utilities/ovn-nbctl.c: In function 'nbctl_qos_del':
> >
On Wed, May 13, 2020 at 4:57 PM Ilya Maximets wrote:
> On 5/13/20 12:19 PM, Dumitru Ceara wrote:
> > In function get_nat_addresses(), memory reserved for c_addresses is not
> > freed in case of distributed NAT (i.e., central_ip_address == false):
> >
> > ==22493== 36 bytes in 2 blocks are
ocata/networking-guide/config-routed-networks.html
>
> Signed-off-by: Ihar Hrachyshka
>
Hi Ihar,
Please see below. I've 2 small comments.
With the first comment addressed
Acked-by: Numan Siddique
Since Dumitru has already acked your patches, can you please put an
"Acked-by"
e messages.
>
> Signed-off-by: Ihar Hrachyshka
>
Acked-by: Numan Siddique
I've one comment. Please see below.
> ---
> controller/patch.c | 23 +++
> 1 file changed, 19 insertions(+), 4 deletions(-)
>
> diff --git a/controller/patch.c b/controll
On Fri, Sep 6, 2019 at 4:09 PM Ilya Maximets wrote:
> On 05.09.2019 18:18, Ben Pfaff wrote:
> > On Tue, Sep 03, 2019 at 06:07:26PM +0300, Ilya Maximets wrote:
> >> Useful for tracking where the uninitialized memory came from.
> >> Report example:
> >>
> >> Thread 13 revalidator11:
> >>
in the series
> didn't need any update from v2, I pushed only 5/6 but now it's displayed
> separately in patchwork; let me know if that's an issue and/or I should
> repost the whole series.)
>
>
I think it's better to repost as a whole series.
Thanks
Numan
> Thanks for consideratio
On Wed, Apr 29, 2020 at 2:30 PM Numan Siddique wrote:
>
>
> On Fri, Apr 24, 2020 at 8:41 PM Mark Michelson
> wrote:
>
>> This is essentially a copy of existing load balancer tests that use TCP,
>> but with a few modifications for SCTP.
>>
>> Userspace
On Mon, May 11, 2020 at 7:57 PM Dumitru Ceara wrote:
> On 5/11/20 11:45 AM, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > This patch adds a new data structure - 'struct local_binding' which
> represents
> > a probable local port binding. A new objec
> > > > The current version of the documentation is still using the
> > > > Open vSwitch logo and includes some references to OVS that
> > > > should be changed by OVN.
> > > >
> > > > Signed-off-by: Daniel Alvarez
Acked-by: Numan Siddique
Thanks
Numa
On Sat, Mar 14, 2020 at 5:41 AM Terry Wilson wrote:
>
> For columns like QoS.queues where we have a map containing refTable
> values, assigning w/ __setattr__ e.g. qos.queues={1: $queue_row}
> works, but using using qos.setkey('queues', 1, $queue_row) results
> in an Exception. The opdat argument
On Sat, Mar 14, 2020 at 12:52 AM Mark Michelson wrote:
>
> This allows for load balancers to use SCTP as a supported protocol in
> addition to the already-supported UDP and TCP.
>
> With this patch, health checks are not supported for SCTP load
> balancers. A test has been added to ensure that
On Thu, Mar 12, 2020 at 7:43 PM Lorenzo Bianconi
wrote:
>
> Do not insert FIP entries in S_ROUTER_IN_ARP_RESOLVE stage if the
> destination is not resident on the local chassis since the the L2
> address will be resolved by the arp action
Hi Lorenzo,
If eth.dst for the FIP can be resolved using
mber. The code in xlate_lookup_ofproto_() mishandled this case,
> failing to return the ofproto data structure. This commit fixes the
> problem and adds a test to guard against regression.
>
> Reported-by: Numan Siddique
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/20
On Thu, Mar 19, 2020 at 9:51 PM Han Zhou wrote:
>
> On Thu, Mar 19, 2020 at 5:27 AM wrote:
> >
> > From: Numan Siddique
> >
> > If a logical port has 'unknown' address, it means it can send and receive
> > packet with any IP and MAC and generally port secu
On Fri, Mar 20, 2020 at 4:33 AM Ben Pfaff wrote:
>
> There was a missing ] and an extra space.
>
> Signed-off-by: Ben Pfaff
Acked-by: Numan Siddique
Numan
> ---
> ofproto/ofproto-unixctl.man | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/
On Wed, Mar 18, 2020 at 7:49 PM Lorenzo Bianconi
wrote:
>
> Introduce IPv6 Prefix delegation state machine according to RFC 3633
> https://tools.ietf.org/html/rfc3633.
> Add handle_dhcpv6_reply controller action to parse advertise/reply from
> IPv6 delegation server.
> Introduce logical flows in
n about
the distributed gateway ports and VLAN support in OVN as the documentation
makes it very clear.
Acked-by: Numan Siddique
Thanks
Numan
> --
> 2.24.1
>
> ___
> dev mailing list
> d...
On Sat, Mar 21, 2020 at 9:19 PM Lorenzo Bianconi
wrote:
>
> >
> > On Wed, Mar 18, 2020 at 7:49 PM Lorenzo Bianconi
> > wrote:
> > >
> > > Introduce IPv6 Prefix delegation state machine according to RFC 3633
> > > https://tools.ietf.org/html/rfc3633.
> > > Add handle_dhcpv6_reply controller
On Mon, Mar 23, 2020 at 5:53 PM Dumitru Ceara wrote:
>
> Commit 32f5ebb06226 limited the ARP/ND broadcast domain but in scenarios
> where ARP responder flows are installed only on chassis that own the
> associated logical ports ARP requests should still be forwarded on
> localnet ports because
On Mon, Mar 23, 2020 at 6:05 PM Dumitru Ceara wrote:
>
> Commit 32f5ebb06226 limited the ARP/ND broadcast domain but in scenarios
> where ARP responder flows are installed only on chassis that own the
> associated logical ports ARP requests should still be forwarded on
> localnet ports because
la.redhat.com/1808125
> CC: Andy Zhou
> Fixes: 5351980b047f ("ovsdb-idl: Avoid sending redundant conditional
> monitoring updates")
> Signed-off-by: Dumitru Ceara
Acked-by: Numan Siddique
Thanks
Numan
>
> ---
> v2:
> - Updated commit log so that the "Fixes
On Tue, Mar 24, 2020 at 5:17 AM Ben Pfaff wrote:
>
> On Mon, Mar 23, 2020 at 06:39:14PM -0400, Ihar Hrachyshka wrote:
> > First, some questions as to implementation (or feasibility) of several
> > todo items in my list for the patch.
> >
> > 1) I initially thought that, because VXLAN would have
On Thu, Mar 19, 2020 at 11:23 AM Tao YunXiang
wrote:
>
> We can delete qos by specify ls and more parameters.
> If CMS want to delete it exactly, it must specify detailed "match" field.
> It's not an easy way, also maybe deleted by mistake.
> This change adds a way to specify ls and uuid, which
On Tue, Mar 24, 2020 at 7:20 AM Tao YunXiang
wrote:
>
> We can delete router policy by specify lr and more parameters.
> If CMS want to delete it exactly, it must specify detailed "match" field.
> It's not an easy way, also maybe deleted by mistake.
> This change adds a way to specify lr and
On Tue, Mar 24, 2020 at 3:34 PM Dumitru Ceara wrote:
>
> Commit 32f5ebb06226 limited the ARP/ND broadcast domain but in scenarios
> where ARP responder flows are installed only on chassis that own the
> associated logical ports ARP requests should still be forwarded on
> localnet ports because
On Mon, Mar 23, 2020 at 8:49 PM wrote:
>
> From: Lucas Alvares Gomes
>
> nb_cfg as a mechanism to "ping" OVN control plane is very useful
> in many ways. However, the current implementation will trigger
> update notifications flooding in the whole control plane. Each
> HV updates to SB the
:37 PM Numan Siddique wrote:
>
> On Tue, Mar 24, 2020 at 5:17 AM Ben Pfaff wrote:
> >
> > On Mon, Mar 23, 2020 at 06:39:14PM -0400, Ihar Hrachyshka wrote:
> > > First, some questions as to implementation (or feasibility) of several
> > > todo items in my
On Tue, Mar 24, 2020 at 8:58 PM Ihar Hrachyshka wrote:
>
> On Tue, Mar 24, 2020 at 9:18 AM Numan Siddique wrote:
> >
> > (Sorry, top posting it)
> >
> > Hi Ihar,
> >
> > I tested out your patch. All the tests pass.
> >
> > I then test
On Tue, Mar 24, 2020 at 7:06 PM Dumitru Ceara wrote:
>
> The test for "ARP/ND request broadcast limiting" checks that injected
> ARP packets are not flooded using the MC_FLOOD multicast group. However,
> this introduces a race condition in the test because GARPs generated by
> OVN would also hit
On Fri, Apr 17, 2020 at 10:14 PM Flavio Fernandes
wrote:
> Tested-by: Flavio Fernandes
>
>
Thanks Flavio for testing this patch. I applied this patch to master.
Numan
>
>
> > On Apr 17, 2020, at 10:57 AM, num...@ovn.org wrote:
> >
> > From: Numan Siddiqu
On Thu, May 7, 2020 at 5:58 PM Mark Michelson wrote:
> Acked-by: Mark Michelson
>
>
Thanks Mark, Han and Maciej for the reviews. I applied this patch to master.
Numan
> On 5/7/20 2:49 AM, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > This patch add
On Thu, May 7, 2020 at 6:29 PM Dumitru Ceara wrote:
> On 4/30/20 6:59 PM, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > No functional changes are introduced in this patch.
> >
> > Signed-off-by: Numan Siddique
>
> Hi Numan,
>
> A fe
On Sat, May 2, 2020 at 1:50 AM Mark Michelson wrote:
> Hi everyone,
>
> As announced last week today is soft freeze for OVN. This means that any
> patches for new features not already up for review will not be
> considered for inclusion in 20.06. Bug fixes found between now and the
> 20.06
On Thu, May 7, 2020 at 2:13 PM taoyunxi...@cmss.chinamobile.com <
taoyunxi...@cmss.chinamobile.com> wrote:
> Sorry,
> Acutally, I summited a new change for [0], and the patchwork
> address is [1]
>
> [0] [ovs-dev,OVN,v2] ovn-nbctl.c: Add an optional way to delete router
> policy by uuid
On Thu, May 7, 2020 at 11:27 PM Ankur Sharma
wrote:
> From: Dhathri Purohith
>
> 1. Add support for DHCP domain search option (119)
>Domain search list is encoded according to the specifications in RFC
> 1035,
>section 4.1.4.
>
> 2. Fix the data type for DHCP option tftp_server (66)
>
On Wed, May 6, 2020 at 11:46 PM Han Zhou wrote:
> On Wed, May 6, 2020 at 11:05 AM Numan Siddique wrote:
> >
> >
> >
> > On Wed, May 6, 2020 at 11:24 PM Han Zhou wrote:
> >>
> >> On Tue, May 5, 2020 at 11:38 AM wrote:
> >> >
> &
On Wed, May 6, 2020 at 11:24 PM Han Zhou wrote:
> On Tue, May 5, 2020 at 11:38 AM wrote:
> >
> > From: Numan Siddique
> >
> > This patch add a new column 'selection_fields' in Load_Balancer
> > table in NB DB. CMS can define a set of packet headers to
On Sat, May 9, 2020 at 12:57 PM Tao YunXiang <
taoyunxi...@cmss.chinamobile.com> wrote:
> We can delete qos by specify ls and more parameters.
> If CMS want to delete it exactly, it must specify detailed "match" field.
> It's not an easy way, also maybe deleted by mistake.
> This change adds a
off-by: Ryan Goulding
> Signed-off-by: Numan Siddique
>
Thanks Ryan for the PR. I applied this patch to master.
Thanks
Numan
> ---
> AUTHORS.rst | 1 +
> README.rst | 9 -
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/AUTHORS.rst b/AU
On Fri, May 8, 2020 at 12:49 PM wrote:
> From: Artem Teleshev
>
> Reported-at: https://github.com/ovn-org/ovn/issues/42
> Submitted-at: https://github.com/ovn-org/ovn/pull/43
> Signed-off-by: Artem Teleshev
> Signed-off-by: Numan Siddique
> ---
>
Thanks for the pa
On Fri, May 8, 2020 at 12:29 PM wrote:
> From: Dan Williams
>
> Submitted-at: https://github.com/ovn-org/ovn/pull/40
> Signed-off-by: Dan Williams
> Signed-off-by: Numan Siddique
>
Thanks Dan for improving the OVN documentation.
I applied this patch to mas
On Fri, May 8, 2020 at 11:34 AM wrote:
> From: Numan Siddique
>
> Dave Tucker proposed these patches to remove the unused OVS code
> from the OVN tree as PR here - https://github.com/ovn-org/ovn/pull/38.
>
> This PR was unattended for a long time. It was last updated on 24th
&
On Fri, May 8, 2020 at 3:17 PM wrote:
> From: Girish Moodalbail
>
> the redirect-type option is being incorrectly called out as
> redirect-chassis so fix the references
>
> Submitted-at: https://github.com/ovn-org/ovn/pull/44
> Signed-off-by: Girish Moodalbail
> Signe
On Wed, May 20, 2020 at 12:37 PM Han Zhou wrote:
> Hi Numan, I haven't finished the review yet, but send out a comment that I
> think is important. I will continue the review tomorrow.
>
>
> On Sat, May 16, 2020 at 10:56 AM wrote:
> >
> > From: Numan Siddique
> &g
ke to see another ACK on this from someone that is more
> familiar with the intricacies of the incremental engine though.
>
Thanks for the review Mark.
I submitted v7 of the patches and I've added your Ack in all the patches.
Thanks
Numan
>
> On 5/16/20 1:55 PM, num...@ovn.or
On Wed, May 20, 2020 at 8:41 PM Ihar Hrachyshka wrote:
> Signed-off-by: Ihar Hrachyshka
>
Thanks. I applied this patch to master.
Numan
> ---
> NEWS | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/NEWS b/NEWS
> index fea196d34..4dab4f7d5 100644
> --- a/NEWS
> +++ b/NEWS
> @@
On Thu, May 21, 2020 at 6:57 AM Han Zhou wrote:
> Hi Numan, please see my comments below.
>
Thanks for the review. Please see below for a few comments.
>
> On Wed, May 20, 2020 at 12:41 PM wrote:
> >
> > From: Numan Siddique
> >
> > This patch han
On Thu, May 21, 2020 at 12:28 PM Han Zhou wrote:
> Please see my comments below.
>
> On Wed, May 20, 2020 at 12:41 PM wrote:
> >
> > From: Numan Siddique
> >
> > In order to handle runtime data changes incrementally, the flow outut
> > runtime data hand
On Fri, May 22, 2020 at 1:17 AM Han Zhou wrote:
> On Thu, May 21, 2020 at 3:49 AM Numan Siddique wrote:
> >
> >
> >
> > On Thu, May 21, 2020 at 6:57 AM Han Zhou wrote:
> >>
> >> Hi Numan, please see my comments below.
> >
> >
>
On Sat, May 23, 2020 at 7:30 AM Han Zhou wrote:
> On Fri, May 22, 2020 at 10:29 AM Numan Siddique wrote:
> >
> >
> >
> > On Thu, May 21, 2020 at 12:02 PM Han Zhou wrote:
> >>
> >> On Wed, May 20, 2020 at 12:41 PM wrote:
> >> >
> &g
On Fri, May 1, 2020 at 9:14 PM William Tu wrote:
> Cc: Numan Siddique
> Signed-off-by: William Tu
>
Thanks for the patch.
Acked-by: Numan Siddique
Numan
> ---
> Documentation/faq/releases.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentat
nks for fixing this. I need to check why it didn't fail in my system.
Acked-by: Numan Siddique
Numan
> ---
> tests/test-tcp-rst.py | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tests/test-tcp-rst.py b/tests/test-tcp-rst.py
> index 6f96c57..5
On Thu, Sep 3, 2020 at 5:52 PM Dumitru Ceara wrote:
> On 9/3/20 2:07 PM, Numan Siddique wrote:
> >
> >
> > On Thu, Aug 27, 2020 at 8:18 PM Dumitru Ceara > <mailto:dce...@redhat.com>> wrote:
> >
> > It's quite common that IP Multicast is ena
On Fri, Aug 28, 2020 at 5:42 PM Dumitru Ceara wrote:
> Reported-at: https://bugzilla.redhat.com/id=1873455
> Reported-by: Ying Xu
> Signed-off-by: Dumitru Ceara
>
Thanks. I applied this patch to master and branch-20.06.
Numan
> ---
> utilities/ovn-nbctl.c | 5 +
> 1 file changed, 5
Hi Ihar,
Overall the patch LGTM.
I have few comments. Please see below.
Thanks
Numan
On Wed, Aug 26, 2020 at 10:45 PM Ihar Hrachyshka
wrote:
> Because of limited space in VXLAN VNI to pass over all three of -
> datapath id, ingress port, egress port - the implementation ignores
> ingress;
On Thu, Sep 3, 2020 at 10:36 PM Tony Liu wrote:
> Hi,
>
> I tried to set northd_probe_interval="3" and
> northd-probe-interval="3" in NB_Global options.
> Still got this from ovn-northd log.
>
> 2020-09-03T17:00:16.445Z|22664|reconnect|ERR|tcp:10.6.20.25:6642: no
oraproject.org/rpms/ovn
Thanks
Numan
>
> Thanks!
> Tony
> > -Original Message-
> > From: Numan Siddique
> > Sent: Thursday, September 3, 2020 10:24 AM
> > To: Tony Liu
> > Cc: ovs-dev
> > Subject: Re: [ovs-dev] [OVN] ovn-northd inacti
On Thu, Aug 20, 2020 at 8:04 AM Ankur Sharma
wrote:
> From: Ankur Sharma
>
> This patch has northd changes which consumes allowed/exempted external ip
> configuration per NAT rule in logical flow.
>
> Allowed external ip range adds an additional match criteria in
> snat/dnat logical flow rules.
Hi Ankur,
Sorry for the late review. This patch LGTM except for one comment. I have
few comments in patch 2.
Thanks
Numan
On Thu, Aug 20, 2020 at 8:05 AM Ankur Sharma
wrote:
> From: Ankur Sharma
>
> This patch adds following columns to NAT table.
>
> a. allowed_ext_ips:
>Represents
is also why the commands are not
> documented.
>
> CC: Numan Siddique
> Fixes: 6b0f01116bab ("ovn-controller: Handle runtime data changes in flow
> output engine")
> Reported-by: Tim Rozet
> Reported-at: https://bugzilla.redhat.com/1871961
> Signed-off-by: Dumitru Ceara
report for 2 seconds is enough to
> get accurate latency report.
>
> Signed-off-by: Han Zhou
Acked-by: Numan Siddique
Note: You have to rebase before applying.
Thanks
Numan
> ---
> This patch is a revision of the last patch in a previous patch series to
> address comments from N
estamp support from the previous
> commit), we can measure the exact time when hypervisors completed
> SB DB change handling and enforcing to OVS.
>
> Signed-off-by: Han Zhou
>
Acked-by: Numan Siddique
Thanks
Numan
> ---
> tests/ovn.at | 3 +++
>
On Sat, Sep 5, 2020 at 12:46 AM Numan Siddique wrote:
>
>
> On Sat, Sep 5, 2020, 12:04 AM Han Zhou wrote:
>
>> On Fri, Sep 4, 2020 at 11:18 AM Numan Siddique wrote:
>> >
>> >
>> >
>> > On Wed, Sep 2, 2020 at 4:57 AM Han Zhou wrote:
On Wed, Sep 2, 2020 at 4:57 AM Han Zhou wrote:
> The section was placed at wrong postion. This patch fixes it.
>
> Signed-off-by: Han Zhou
>
Acked-by: Numan Siddique
Thanks
Numan
> ---
> utilities/ovn-nbctl.8.xml | 53
> +--
s processing a NB DB change, updates the changes to
> SB DB, and when the slowest chassis finishes processing the changes.
>
> Signed-off-by: Han Zhou
>
Hi Han,
I have one comment in the documentation. With that comment addressed:
Acked-by: Numan Siddique
Please
On Wed, Sep 9, 2020 at 2:33 PM wrote:
>
> From: Anton Ivanov
>
> Replaces ds_put_cstr and ds_put_format which evaluate to
> constant expressions with string constants
>
> Signed-off-by: Anton Ivanov
Acked-by: Numan Siddique
Thanks
Numan
> ---
>
for a
> port that is "down" isn't considered harmful.
>
> Acked-by: Numan Siddique
> Signed-off-by: Han Zhou
> ---
> v1 -> v2: change the option from "check_lsp_is_up" to "ignore_lsp_down" as
> suggested by Numan.
Hi Han,
The pa
On Wed, Sep 9, 2020 at 1:32 AM Mark Michelson wrote:
>
> I know this is weird because I ACKed this exact patch once in the past,
> but I found a small issue. See below:
>
> On 9/2/20 2:46 PM, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > Th
On Wed, Sep 9, 2020 at 3:36 PM Yi Li wrote:
>
> Signed-off-by: Yi Li
Thanks. I applied this patch to master.
Numan'
> ---
> controller/bfd.c | 1 -
> controller/pinctrl.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/controller/bfd.c b/controller/bfd.c
> index
On Fri, Sep 11, 2020 at 1:26 AM Han Zhou wrote:
>
> On Thu, Sep 10, 2020 at 11:57 AM Ilya Maximets wrote:
> >
> > It might take some time for availability zone to become
> > visible in the output of 'show' command.
> >
> > This fixes periodic failures of testsuite jobs on Travis.
> >
> > Fixes:
On Fri, Sep 11, 2020 at 4:09 PM Dumitru Ceara wrote:
>
> We currently skip conntrack for IPv6 Neighbor Discovery packets because
> conntrack marks all ND packets as invalid [0].
>
> The same thing should be done for MLD packets. Otherwise, as soon as an
> allow-related ACL or load balancer is
On Fri, Sep 11, 2020 at 3:24 PM Dumitru Ceara wrote:
>
> On 9/11/20 11:46 AM, Numan Siddique wrote:
> > On Fri, Sep 11, 2020 at 2:25 PM Dumitru Ceara wrote:
> >>
> >> We currently skip conntrack for IPv6 Neighbor Discovery packets because
> >> connt
On Fri, Sep 11, 2020 at 2:25 PM Dumitru Ceara wrote:
>
> We currently skip conntrack for IPv6 Neighbor Discovery packets because
> conntrack marks all ND packets as invalid [0].
>
> The same thing should be done for MLD packets. Otherwise, as soon as an
> allow-related ACL or load balancer is
On Fri, Sep 11, 2020 at 6:11 PM Mark Michelson wrote:
>
> Acked-by: Mark Michelson
Thanks Dumitru and Mark and Han for the suggestion.
The patch LGTM. I applied this patch to master.
There was one test case failing - 148: ovn -- lflow cache for conjunctions.
This test case was added by me
On Thu, Sep 10, 2020 at 11:34 PM Mark Michelson wrote:
>
> Acked-by: Mark Michelson
Thanks Mark. I applied this patch to master.
Numan
>
> On 9/9/20 3:19 AM, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > when ovn-ctl run_(nb_sb)_ovsdb is calle
On Fri, Sep 11, 2020 at 8:14 PM Mark Michelson wrote:
> Acked-by: Mark Michelson
>
Thanks Dumitru and Mark. I applied this patch to master.
Numan
>
> Thanks Numan!
>
> On 9/11/20 5:10 AM, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > Pri
On Tue, Sep 8, 2020 at 2:28 AM Ankur Sharma
wrote:
> From: Ankur Sharma
>
> This patch adds following columns to NAT table.
>
> a. allowed_ext_ips:
>Represents Address Set of External IPs for which
>a NAT rule is applicable.
>
> b. exempted_ext_ips:
>Represents Address Set of
On Tue, Sep 8, 2020 at 1:16 PM Numan Siddique wrote:
>
>
> On Tue, Sep 8, 2020 at 12:58 PM Han Zhou wrote:
>
>> On Mon, Sep 7, 2020 at 3:11 AM Dumitru Ceara wrote:
>> >
>> > ovn-controller always stores the last configured system-id/chassis-id in
>
On Tue, Sep 8, 2020 at 12:58 PM Han Zhou wrote:
> On Mon, Sep 7, 2020 at 3:11 AM Dumitru Ceara wrote:
> >
> > ovn-controller always stores the last configured system-id/chassis-id in
> > memory regardless if the connection to the SB is up or down. This is OK
> > as long as the change can be
On Mon, Sep 7, 2020 at 10:29 PM Dumitru Ceara wrote:
> Steps to reproduce the issue:
>
> $ make sandbox
> $ ovs-vsctl set open . external_ids:system-id=new-chassis
>
> Fixes: 94a32fca2d2b ("chassis: Fix the way encaps are updated for a
> chassis record.")
> Fixes: 5344f24ecb1a ("ovn-controller:
On Mon, Sep 7, 2020 at 9:34 PM Dumitru Ceara wrote:
> OVN was dropping IP packets destined to IPs owned by logical routers but
> only if those IPs are not used for SNAT rules. However, if a packet
> doesn't match an existing NAT session and its destination is still a
> router owned IP, it can be
On Tue, Sep 8, 2020 at 2:13 PM Dumitru Ceara wrote:
>
> OVN was dropping IP packets destined to IPs owned by logical routers but
> only if those IPs are not used for SNAT rules. However, if a packet
> doesn't match an existing NAT session and its destination is still a
> router owned IP, it can
On Wed, Sep 2, 2020 at 6:54 AM Ihar Hrachyshka wrote:
>
> User stories:
> 1) NFV: an admin wants to run two separate instances of OVN controller
>using the same database but configuring ports on different bridges.
>Some of these bridges may use DPDK while others may not.
>
> 2) Parallel
On Tue, Sep 8, 2020 at 4:54 PM Dumitru Ceara wrote:
>
> On 9/8/20 12:58 PM, Numan Siddique wrote:
> > On Tue, Sep 8, 2020 at 2:13 PM Dumitru Ceara wrote:
> >>
> >> OVN was dropping IP packets destined to IPs owned by logical routers but
> >> only if those I
the
> use cases when ARP reponse for a port that is "down" isn't considered
> harmful.
>
> Signed-off-by: Han Zhou
Few minor comments.
Acked-by: Numan Siddique with those addressed.
Thanks
Numan
> ---
> northd/ovn-northd.8.xml | 15 ++-
On Tue, Sep 8, 2020 at 6:48 PM Dumitru Ceara wrote:
>
> On 9/8/20 2:06 PM, Numan Siddique wrote:
> > On Tue, Sep 8, 2020 at 4:54 PM Dumitru Ceara wrote:
> >>
> >> On 9/8/20 12:58 PM, Numan Siddique wrote:
> >>> On Tue, Sep 8, 2020 at 2:13 PM Dumitru Ce
then cache
*
I had missed freeing the ovnacts ofpbuffer in one place.
Thanks
Numan
> On 9/9/20 6:09 AM, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > A similar patch was committed earlier [1] and then reverted [2].
> > This patch is similar to [1], but n
On Fri, Sep 11, 2020 at 3:11 PM wrote:
> From: Anton Ivanov
>
> Signed-off-by: Anton Ivanov
>
Hi Anton,
Thanks for this series.
I found most of the patches to be splitting the code into functions into
proper logical blocks.
However, patches 3 to 7, split the code into functions which I
On Tue, Sep 15, 2020 at 4:42 PM Numan Siddique wrote:
>
>
>
> On Fri, Sep 11, 2020 at 3:11 PM wrote:
>
>> From: Anton Ivanov
>>
>> Signed-off-by: Anton Ivanov
>>
>
> Hi Anton,
>
> Thanks for this series.
>
> I found most of the patc
On Wed, Sep 16, 2020 at 9:18 AM Han Zhou wrote:
> The name was misleading because it in fact parses lflow match instead
> of actions.
>
> Fixes: 1213bc8270 ("ovn-controller: Cache logical flow expr matches.")
> Cc: Numan Siddique
> Signed-off-by: Han Zhou
>
On Wed, Sep 16, 2020 at 2:56 PM Dumitru Ceara wrote:
> On 9/15/20 7:28 PM, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > Signed-off-by: Numan Siddique
> > ---
> > NEWS | 2 +-
> > configure.ac | 2 +-
> > debian/changelog
On Mon, Sep 14, 2020 at 3:17 PM Dumitru Ceara wrote:
> On 9/14/20 11:20 AM, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > The commit in the Fixes tag, while addressing the issue to send ARP
> replies for
> > the SNAT entries, didn't take into account the
901 - 1000 of 2788 matches
Mail list logo
