Re: [ovs-dev] [PATCH] compat: Remove rpl_dev_queue_xmit() backport.

t; > Signed-off-by: Joe Stringer <j...@ovn.org> > --- > CC: Simon Horman <ho...@verge.net.au> > > Simon, I'm not sure what the repercussions are of this but by my reading > of the code the extra skb_gso_segment compat code here is never invoked > anyway so

Re: [ovs-dev] [PATCH] compat: Remove rpl_dev_queue_xmit() backport.

On Thu, Feb 09, 2017 at 04:32:08PM -0800, Joe Stringer wrote: > On 9 February 2017 at 02:20, Simon Horman <simon.hor...@netronome.com> wrote: > > Hi Joe, > > > > On Wed, Feb 08, 2017 at 04:50:36PM -0800, Joe Stringer wrote: > >> The MPLS portions of this w

Re: [ovs-dev] [PATCH ovs V3 06/25] dpif: Save added ports in a port map for netdev flow api use

On Wed, Feb 08, 2017 at 05:29:19PM +0200, Roi Dayan wrote: > From: Paul Blakey > > To use netdev flow offloading api, dpifs needs to iterate over > added ports. This addition inserts the added dpif ports in a hash map, > The map will also be used to translate dpif ports to

Re: [ovs-dev] [PATCH ovs V3 15/25] dpif-netlink: Delete a flow from netdev

On Wed, Feb 08, 2017 at 05:29:28PM +0200, Roi Dayan wrote: > From: Paul Blakey > > If a flow was offloaded to a netdev we delete it using netdev > flow api. > > Signed-off-by: Paul Blakey > Reviewed-by: Roi Dayan > --- >

Re: [ovs-dev] [PATCH ovs V3 12/25] dpif-netlink: Use netdev flow put api to insert a flow

On Wed, Feb 08, 2017 at 05:29:25PM +0200, Roi Dayan wrote: > From: Paul Blakey > > Using the new netdev flow api operate will now try and > offload flows to the relevant netdev of the input port. > Other operate methods flows will come in later patches. > > Signed-off-by:

Re: [ovs-dev] [PATCH ovs V3 07/25] dpif-netlink: Flush added ports using netdev flow api

On Wed, Feb 08, 2017 at 05:29:20PM +0200, Roi Dayan wrote: > From: Paul Blakey > > If netdev flow offloading is enabled, flush all > added ports using netdev flow api. > > Signed-off-by: Paul Blakey > Reviewed-by: Roi Dayan ... >

Re: [ovs-dev] [PATCH ovs V3 09/25] dpif-netlink: Dump netdevs flows on flow dump

On Wed, Feb 08, 2017 at 05:29:22PM +0200, Roi Dayan wrote: > From: Paul Blakey > > While dumping flows, dump flows that were offloaded to > netdev and parse them back to dpif flow. > > Signed-off-by: Paul Blakey > Reviewed-by: Roi Dayan

Re: [ovs-dev] [PATCH ovs V3 23/25] dpctl: Add an option to dump only certain kinds of flows

On Wed, Feb 08, 2017 at 05:29:36PM +0200, Roi Dayan wrote: > From: Paul Blakey > > Usage: > # to dump all datapath flows (default): > ovs-dpctl dump-flows > > # to dump only flows that in kernel datapath: > ovs-dpctl dump-flows type=ovs ovs does not seem to

Re: [ovs-dev] [PATCH ovs V3 06/25] dpif: Save added ports in a port map for netdev flow api use

On Wed, Feb 15, 2017 at 10:46:20AM +0200, Roi Dayan wrote: > > > On 14/02/2017 17:52, Simon Horman wrote: > >On Wed, Feb 08, 2017 at 05:29:19PM +0200, Roi Dayan wrote: > >>From: Paul Blakey <pa...@mellanox.com> > >> > >>To use netdev flow offlo

Re: [ovs-dev] [PATCH ovs V3 05/25] other-config: Add tc-policy switch to control tc flower flag

On Wed, Feb 08, 2017 at 05:29:18PM +0200, Roi Dayan wrote: > From: Paul Blakey > > Add a new configuration tc-policy option that controls tc > flower flag. Possible options are none, skip_sw, skip_hw. > The default is none which is to insert the rule both to sw and hw. > This

Re: [ovs-dev] [PATCH ovs V3 05/25] other-config: Add tc-policy switch to control tc flower flag

On Wed, Feb 15, 2017 at 01:48:37PM +0200, Roi Dayan wrote: > On 15/02/2017 13:16, Chandran, Sugesh wrote: > >>From: Roi Dayan [mailto:r...@mellanox.com] ... > >>On 14/02/2017 01:53, Chandran, Sugesh wrote: > From: Roi Dayan [mailto:r...@mellanox.com] ... > +

Re: [ovs-dev] [PATCH 0/3] ovs-vswitchd: Port protected mode

On Sun, Nov 20, 2016 at 11:36:38AM +0200, Ben Kelly wrote: > On Thu, Nov 17, 2016 at 5:57 PM, Simon Horman > <simon.hor...@netronome.com> wrote: > > On Mon, Nov 14, 2016 at 12:30:37AM +1100, Ben Kelly wrote: > >> Port protected mode is available in some switching ASI

Re: [ovs-dev] [PATCH v2] rhel: support enable/disable of ovn services

On Mon, Nov 21, 2016 at 06:01:52PM -0500, Lance Richardson wrote: > OVN services (northd, ovn-controller, ovn-controller-vtep) cannot > currently be enabled/disabled to start automatically on boot. > > Add [Install] section for these services to allow them to be enabled > and disabled. > >

Re: [ovs-dev] [PATCH v2] rhel: support enable/disable of ovn services

On Tue, Nov 22, 2016 at 09:06:39AM -0500, Lance Richardson wrote: > > From: "Simon Horman" <simon.hor...@netronome.com> > > To: "Lance Richardson" <lrich...@redhat.com> > > Cc: d...@openvswitch.org, mkal...@redhat.com > > Sent: Tuesday

Re: [ovs-dev] [PATCHv2] lib: Use nl_attr_get_odp_port().

On Mon, Nov 14, 2016 at 01:29:05PM -0800, Joe Stringer wrote: > This helper is a little tidier than the alternative. Use it treewide. > > Signed-off-by: Joe Stringer <j...@ovn.org> Acked-by: Simon Horman <simon.hor...@netronome.com> __

Re: [ovs-dev] [PATCH branch-v2.5] ofproto-dpif-xlate: Fix duplicate multicast packets

On Tue, Nov 15, 2016 at 10:32:49AM +, O'Reilly, Darragh wrote: > When iterating the list of mrouters, skip any that are not on the same > vlan as the multicast packet to be forwarded. This bug was causing > duplicate packets when more than one mrouter was behind a trunk port. > > Reported-at:

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Fix --ovn-controller-log.

On Thu, Nov 17, 2016 at 08:39:27AM -0500, Russell Bryant wrote: > This option was documented, but didn't actually work because > it wasn't used when starting ovn-controller. > > Signed-off-by: Russell Bryant <russ...@ovn.org> Acked-by: Simon Horman <simon

Re: [ovs-dev] [PATCH 2/2] rhel: Support ovn-ctl args through env vars.

gned-off-by: Russell Bryant <russ...@ovn.org> > Co-authored-by: Babu Shanmugam <bscha...@redhat.com> > Signed-off-by: Babu Shanmugam <bscha...@redhat.com> Acked-by: Simon Horman <simon.hor...@netronome.com> ___ dev mailing list d..

Re: [ovs-dev] [PATCH] .mailmap: Document file format.

but this commit simplifies > them into one of the two forms documented. > > Signed-off-by: Russell Bryant <russ...@ovn.org> Acked-by: Simon Horman <simon.hor...@netronome.com> ___ dev mailing list d...@openvswitch.org https://mail.

Re: [ovs-dev] [PATCH] FAQ: Fix current LTS version

On Mon, Nov 14, 2016 at 03:09:45PM +, O'Reilly, Darragh wrote: > Signed-off-by: Darragh O'Reilly > --- > FAQ.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, I applied this to master and backported it to branch-2.5 and branch-2.6.

Re: [ovs-dev] [PATCH 0/3] ovs-vswitchd: Port protected mode

On Mon, Nov 14, 2016 at 12:30:37AM +1100, Ben Kelly wrote: > Port protected mode is available in some switching ASICs (b53 etc) and > Cisco also implements this feature. >

Re: [ovs-dev] [PATCH] tests: Test reset_counts in flow_mod message

Hi Tony, On Tue, Nov 29, 2016 at 12:47:57AM +, Tony van der Peet wrote: > commit 23c753793204df86aa6eedd00ec62911a1ef9559 > Author: Tony van der Peet > Date: Tue Nov 29 13:16:17 2016 +1300 > > tests: Test reset_counts in flow_mod message > >

Re: [ovs-dev] [PATCH] dpdk: update download url

On Mon, Nov 28, 2016 at 06:51:56PM +, Kevin Traynor wrote: > On 11/27/2016 10:22 PM, Thomas Monjalon wrote: > > The documentation and the travis script were getting the DPDK sources > > from the DPDK cgit service at dpdk.org/browse/dpdk. > > A fastest alternative is to use the CDN

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

Hi Thomas, On Wed, Nov 30, 2016 at 12:05:46PM +0100, Thomas Morin wrote: > Hi Ben, > > 2016-11-30, Ben Pfaff: > >Do you have any idea what in your OpenFlow pipeline might do that, > >i.e. is there anything especially tricky in the OpenFlow flows? > > > > Are you willing to show us your OpenFlow

Re: [ovs-dev] [PATCH] util: Remove obsolete comment.

On Wed, Jan 04, 2017 at 09:23:54AM -0800, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Simon Horman <simon.hor...@netronome.com> > --- > include/openvswitch/util.h | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > di

Re: [ovs-dev] [PATCH ovs V5 00/24] Introducing HW offload support for openvswitch

further work and as the patch-set is already large it makes sense to me not to further expand it by adding more features to it. Furthermore I think the patch-set should have minimal impact on those not interested in programming flows into hardware. Modulo resolving the build error that Joe re

Re: [ovs-dev] [PATCH ovs V4 00/24] Introducing HW offload support for openvswitch

On Mon, Mar 20, 2017 at 10:56:34AM +0200, Roi Dayan wrote: > > > On 20/03/2017 10:33, Roi Dayan wrote: > > > > > >On 16/03/2017 17:40, Simon Horman wrote: > >>On Mon, Mar 13, 2017 at 03:36:50PM +0200, Roi Dayan wrote: > >>>This patch series intro

Re: [ovs-dev] How do we set fields for selection_method=hash?

d feature:-) > > -Original Message- > From: Simon Horman [mailto:simon.hor...@netronome.com] > Sent: Monday, March 20, 2017 9:28 PM > To: Yang, Yi Y <yi.y.y...@intel.com> > Cc: ovs-dev@openvswitch.org > Subject: Re: How do we set fields for selection_method=hash? > >

Re: [ovs-dev] How do we set fields for selection_method=hash?

On Tue, Mar 14, 2017 at 06:32:30AM +, Yang, Yi Y wrote: > Hi, Simon > > I notice you Netronome implemented selection_method support in ovs, now I > just want to use the specified match fields as hash input, I checked > ovs-ofctl man pages, for such use case, I must use "selection_method=hash

Re: [ovs-dev] [PATCH] compat: Remove rpl_dev_queue_xmit() backport.

On Thu, Mar 02, 2017 at 03:00:37PM -0800, Joe Stringer wrote: > On 8 February 2017 at 16:50, Joe Stringer wrote: > > The MPLS portions of this were inadvertently broken in v2.4 due to > > 433637881ca5 ("datapath: define compat __skb_gso_segment()") which > > inverts the

Re: [ovs-dev] [PATCH ovs V4 00/24] Introducing HW offload support for openvswitch

On Mon, Mar 13, 2017 at 03:36:50PM +0200, Roi Dayan wrote: > This patch series introduces rule offload functionality to dpif-netlink > via netdev ports new flow offloading API. The user can specify whether to > enable rule offloading or not via OVS configuration. Netdev providers > are able to

Re: [ovs-dev] Minutes: OvS Offload Discussion at Netdev 2.1

> seemed reasonable to the people I discussed this with. Thanks Joe, FWIW that sounds reasonable to me. > On 8/04/2017 16:48, "Simon Horman" <simon.hor...@netronome.com> wrote: > > At Netdev 2.1 a meeting was held to discuss OvS offload. Minutes of the > discussio

[ovs-dev] Minutes: OvS Offload Discussion at Netdev 2.1

Conole, Ben LaHaise, Eran Ben Elisha, Hannes Frederic Sowa, Jakub Kicinski, Jiri Pirko, Joe Stringer, John Fastabend, Nick Viljoen, Rashid Khan, Rony Efraim, Simon Horman Joe raised 2 concerns: 1) How to enable users to understand whether offload is successful and if not, why

Re: [ovs-dev] Minutes: OvS Offload Discussion at Netdev 2.1

On Wed, Apr 12, 2017 at 03:01:29PM -0300, Flavio Leitner wrote: > On Sat, Apr 08, 2017 at 04:47:57PM -0400, Simon Horman wrote: > > At Netdev 2.1 a meeting was held to discuss OvS offload. Minutes of the > > discussion follow. I apologise in advance for any errors or omissions; >

Re: [ovs-dev] [PATCH ovs V3 00/25] Introducing HW offload support for openvswitch

On Wed, Feb 08, 2017 at 05:29:13PM +0200, Roi Dayan wrote: > This patch series introduces rule offload functionality to dpif-netlink > via netdev ports new flow offloading API. The user can specify whether to > enable rule offloading or not via OVS configuration. Netdev providers > are able to

Re: [ovs-dev] [PATCH ovs V4 00/24] Introducing HW offload support for openvswitch

ix breaking of datapath compilation > Fix testsuite failures Hi Roi, thanks for posting the update. I took a stab at resolving the first of the TODO items listed above. It is supposed to allow compilation to work against all (supported) kernels. Feel free to squash it into your patc

Re: [ovs-dev] [PATCH 3/3] netdev-tc-offloads: Parse ip related fields only if eth type is ip

On Thu, Jul 27, 2017 at 01:20:00PM +0300, Roi Dayan wrote: > From: Paul Blakey > > No need to parse ip related fields otherwise. I would prefer if the changelog could be read without reference to the subject. As you are planning to respin anyway perhaps you could fix this

Re: [ovs-dev] [PATCH 2/3] tc: Split IPs and transport layer ports unions in flower struct

On Thu, Jul 27, 2017 at 01:19:59PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Split dst/src_port and ipv4/ipv6 union so we can > distingush them easily for later features. The implications of this change on the size of struct tc_flower_key seem somewhat undesirable to

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Fix false errors on interfaces without tunnel config

gned-off-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Paul Blakey <pa...@mellanox.com> Thanks, this looks good to me. I would be happy to apply if someone provided an Ack. I'd also be happy if someone else applied it with: Acked-by: Simon Horman <simon.hor...@netronome.com>

Re: [ovs-dev] [PATCH 1/3] tc: Refactor nl_msg_put_flower_options

t; > Reviewed-by: Roi Dayan <r...@mellanox.com> LGTM Acked-by: Simon Horman <simon.hor...@netronome.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] tc: Correct convert ticks to msecs on parsing tc TM

On Thu, Jul 27, 2017 at 01:20:07PM +0300, Or Gerlitz wrote: > On 7/27/2017 1:14 PM, Roi Dayan wrote: > >the system call is done only once. > > good to know, would be worth to mention that on the change-log, so it's > clear we're good w.r.t performance. Roi, could you respin this patch with an

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Fix false errors on interfaces without tunnel config

On Tue, Aug 01, 2017 at 04:48:02PM -0700, Joe Stringer wrote: > On 1 August 2017 at 13:57, Joe Stringer <j...@ovn.org> wrote: > > On 28 July 2017 at 05:43, Simon Horman <simon.hor...@netronome.com> wrote: > >> On Thu, Jul 27, 2017 at 02:40:02PM +0300, Roi Dayan wr

[ovs-dev] [PATCH/RFC] bond: add enable-recirc configuration for bond.

ehensive testing is in progress. Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- ofproto/bond.c | 11 ++- ofproto/bond.h | 1 + vswitchd/bridge.c| 3 +++ vswitchd/

Re: [ovs-dev] [PATCH/RFC] bond: add enable-recirc configuration for bond.

Hi Andy, On Tue, Aug 15, 2017 at 01:31:36PM -0700, Andy Zhou wrote: > On Tue, Aug 15, 2017 at 9:13 AM, Simon Horman > <simon.hor...@netronome.com> wrote: > > From: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> > > > > Adds a config paramete

Re: [ovs-dev] [PATCH 0/7] Add offload support for ip ttl and tcp flags

On Fri, Aug 11, 2017 at 11:43:23AM -0700, Joe Stringer wrote: > On 8 August 2017 at 01:03, Simon Horman <simon.hor...@netronome.com> wrote: > > On Mon, Aug 07, 2017 at 06:19:04PM +0300, Roi Dayan wrote: > >> Hi, > >> > >> This series adds support for off

Re: [ovs-dev] [PATCH 0/4] Add offload support for action set

feature I am very pleased to see. Acked-by: Simon Horman <simon.hor...@netronome.com> > > Thanks, > Roi > > > Paul Blakey (4): > compat: Add act_pedit compatibility for old kernels > odp-util: Expose ovs flow key attr len table for reuse > tc: Add heade

Re: [ovs-dev] [PATCH 3/4] tc: Add header rewrite using tc pedit action

On Tue, Aug 08, 2017 at 05:21:53PM +0300, Roi Dayan wrote: > From: Paul Blakey > > To be later used to implement ovs action set offloading. > > Signed-off-by: Paul Blakey > Reviewed-by: Roi Dayan > --- > lib/tc.c | 372 >

Re: [ovs-dev] [PATCH] dpif: Refactor obj type from void pointer to dpif_class

On Wed, Jul 26, 2017 at 02:35:10PM -0700, Joe Stringer wrote: > On 24 July 2017 at 22:28, Roi Dayan wrote: > > It's basically what is being passed today and passing a specific > > type adds a compiler type check. > > > > Signed-off-by: Roi Dayan > >

Re: [ovs-dev] [PATCH V2] tc: Add SCTP support

On Wed, Jul 26, 2017 at 02:35:51PM -0700, Joe Stringer wrote: > On 25 July 2017 at 04:39, Roi Dayan wrote: > > From: Vlad Buslov > > > > Implement SCTP source and destination ports support for flower. > > > > Signed-off-by: Vlad Buslov

Re: [ovs-dev] [PATCH] tc: Correct convert ticks to msecs on parsing tc TM

On Thu, Jul 27, 2017 at 11:29:10AM +0300, Or Gerlitz wrote: > On 7/27/2017 11:00 AM, Simon Horman wrote: > >>Use sysconf(_SC_CLK_TCK) to read run time "number of clock ticks per > >>second" and use that to convert ticks to msecs. > >>This is how iproute doe

Re: [ovs-dev] [PATCH] tc: Correct convert ticks to msecs on parsing tc TM

version when parsing tc filters. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> This looks good to me. I'm happy to apply this if someone could provide an Acked-by tag. Or alternatively for someone to apply it with: Acked-by: Simon Ho

Re: [ovs-dev] [PATCH 1/3] datapath: Fixups for MPLS GSO

On Tue, Apr 25, 2017 at 05:45:34PM -0700, Yi-Hung Wei wrote: > Hi Simon, > > Thanks for your review. Please find my relies below. > I will sent out v2 based on your review. > > On Tue, Apr 25, 2017 at 12:43 AM, Simon Horman > <simon.hor...@netronome.com> wrote: >

Re: [ovs-dev] [PATCH ovs V7 02/24] netdev: Adding a new netdev api to be used for offloading flows

Paul Blakey <pa...@mellanox.com> > >>Reviewed-by: Roi Dayan <r...@mellanox.com> > >>Reviewed-by: Simon Horman <simon.hor...@netronome.com> > >>--- > > > > > > > >>diff --git a/lib/netdev.h b/lib/netdev.h > >>index d6c07c1.

Re: [ovs-dev] [PATCH 1/3] datapath: Fixups for MPLS GSO

Hi Yi-Hung, thanks for taking on this difficult piece of work and apologies for the delay in responding. On Mon, Apr 03, 2017 at 04:24:36PM -0700, Yi-Hung Wei wrote: > This commit backports the following upstream commits to fix MPLS GSO in ovs > datapath. It has been tested on kernel 4.4 and

Re: [ovs-dev] [PATCH 2/3] datapath: Fix ovs_flow_key_update()

29f45bc4f19 ("openvswitch: add mac_proto field to the flow key") > Signed-off-by: Yi-Hung Wei <yihung@gmail.com> > Acked-by: Jiri Benc <jb...@redhat.com> > Signed-off-by: David S. Miller <da...@davemloft.net> > > Signed-off-by: Yi-Hung Wei

Re: [ovs-dev] [PATCH 3/3] system-traffic: Add test for mpls actions

> commit 5ba0c107c51e ("datapath: Fix ovs_flow_key_update()") to behave > correctly. > > Signed-off-by: Yi-Hung Wei <yihung@gmail.com> Very nice to see a test for this. Acked-by: Simon Horman <simon.hor...@netronome.com> __

Re: [ovs-dev] [PATCH 0/7] Add offload support for ip ttl and tcp flags

On Mon, Aug 07, 2017 at 06:19:04PM +0300, Roi Dayan wrote: > Hi, > > This series adds support for offloading ip ttl and tcp flags > using tc interface. This looks nice, thanks. Acked-by: Simon Horman <simon.hor...@netronome.com> I'm also happy to apply this if someone else

Re: [ovs-dev] [PATCH 1/2] netdev-vport: Always implement get_ifindex for netdev-vport

On Tue, Aug 08, 2017 at 07:36:25AM +0300, Roi Dayan wrote: > > > On 07/08/2017 20:05, Ben Pfaff wrote: > >On Mon, Aug 07, 2017 at 07:00:31AM -0700, Ben Pfaff wrote: > >>On Mon, Aug 07, 2017 at 07:32:02AM +0300, Roi Dayan wrote: > >>>From: Paul Blakey > >>> > >>>Always

Re: [ovs-dev] [PATCH v4 0/5] Backport upstream mpls fix

On Tue, May 02, 2017 at 10:38:17AM -0700, Joe Stringer wrote: > On 2 May 2017 at 05:03, Simon Horman <simon.hor...@netronome.com> wrote: > > On Mon, May 01, 2017 at 10:24:30AM -0700, Yi-Hung Wei wrote: > >> This series backports the upstream mpls fixes and add a system tr

[ovs-dev] [PATCH] tests: Only run python SSL test if SSL support is configured

support ./ovsdb-idl.at:1215: exit code was 1, expected 0 Fixes: d90ed7d65ba8 ("python: Add SSL support to the python ovs client library") Cc: Numan Siddique <nusid...@redhat.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- tests/ovsdb-idl.at | 1 + 1 fil

Re: [ovs-dev] [PATCH ovs V7 02/24] netdev: Adding a new netdev api to be used for offloading flows

On Wed, May 03, 2017 at 08:20:18AM +0300, Roi Dayan wrote: > > > On 24/04/2017 14:35, Simon Horman wrote: > >On Tue, Apr 18, 2017 at 03:18:55PM +0300, Roi Dayan wrote: > >> > >> > >>On 14/04/2017 04:11, Joe Stringer wrote: > >>>On 7 Ap

Re: [ovs-dev] [PATCH ovs V8 13/26] netdev-tc-offloads: Implement netdev flow put using tc interface

On Wed, May 03, 2017 at 06:08:04PM +0300, Roi Dayan wrote: > From: Paul Blakey <pa...@mellanox.com> > > Currently only tunnel offload is supported. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> &g

Re: [ovs-dev] [PATCH ovs V8 21/26] dpctl: Add an option to dump only certain kinds of flows

ws type=ovs > > # to dump only flows that are offloaded: > ovs-dpctl dump-flows type=offloaded > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> As p

Re: [ovs-dev] [PATCH ovs V8 25/26] dpif: Refactor flow logging functions to be used by other modules

On Wed, May 10, 2017 at 05:19:26PM +0200, Simon Horman wrote: > On Wed, May 03, 2017 at 06:08:16PM +0300, Roi Dayan wrote: > > Signed-off-by: Roi Dayan <r...@mellanox.com> > > Reviewed-by: Paul Blakey <pa...@mellanox.com> > > Reviewed-by: Simon Horman <simon.ho

Re: [ovs-dev] [PATCH ovs V8 26/26] dpif-netlink: Use dpif logging functions

On Wed, May 03, 2017 at 06:08:17PM +0300, Roi Dayan wrote: Please add some changelog text here. > Signed-off-by: Roi Dayan > Reviewed-by: Paul Blakey > --- > lib/dpif-netlink.c | 55 > +- > 1 file

Re: [ovs-dev] [PATCH ovs V8 25/26] dpif: Refactor flow logging functions to be used by other modules

On Wed, May 03, 2017 at 06:08:16PM +0300, Roi Dayan wrote: > Signed-off-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Paul Blakey <pa...@mellanox.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com> ___ dev mailing l

Re: [ovs-dev] [PATCH ovs V8 05/26] dpif: Save added ports in a port map for netdev flow api use

On Tue, May 16, 2017 at 12:16:46PM +0300, Roi Dayan wrote: > > > On 08/05/2017 15:49, Simon Horman wrote: > >On Wed, May 03, 2017 at 06:07:56PM +0300, Roi Dayan wrote: > >>From: Paul Blakey <pa...@mellanox.com> > >> > >>To use netdev flow offlo

Re: [ovs-dev] [PATCH V9 02/31] tc: Introduce tc module

On Sun, May 28, 2017 at 02:59:44PM +0300, Roi Dayan wrote: > Add tc module to expose tc operations to be used by other modules. > Move some tc related functions from netdev-linux.c to tc.c > This patch doesn't change any functionality. > > Signed-off-by: Paul Blakey >

Re: [ovs-dev] [PATCH V9 03/31] compat: Add tc compatibility headers for old kernels

tibility is not provided there. > In other words, the compat code is only used when compiling user-space > code against old kernel headers. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Signed-off-by: Simon Horman <simon.hor...@netronome.com> > Reviewed-by: Roi D

Re: [ovs-dev] [PATCH V9 10/31] netdev-tc-offloads: Implement netdev flow flush using tc interface

On Sun, May 28, 2017 at 02:59:52PM +0300, Roi Dayan wrote: > From: Paul Blakey <pa...@mellanox.com> > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com>

Re: [ovs-dev] [PATCH V9 09/31] dpif-netlink: Flush added ports using netdev flow api

an <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > Acked-by: Flavio Leitner <f...@sysclose.org> Thanks, this looks good to me. As it has been acked I would I would be happy to apply it once earlier in t

Re: [ovs-dev] [PATCH V9 08/31] dpif: Save added ports in a port map for netdev flow api use

translate dpif ports to netdevs. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > Acked-by: Flavio Leitner <f...@sysclose.org> Thanks, this looks good to

Re: [ovs-dev] [PATCH V9 01/31] netdev-linux: Refactor two tc functions

On Sun, May 28, 2017 at 02:59:43PM +0300, Roi Dayan wrote: > Refactor tc_make_request and tc_add_del_ingress_qdisc to accept > ifindex instead of netdev struct. > We later want to move those outside netdev-linux module to be > used by other modules. > This patch doesn't change any functionality. >

Re: [ovs-dev] [PATCH V9 06/31] other-config: Add hw-offload switch to control netdev flow offloading

f the kernel datapath. > This configuration option defaults to false - disabled. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> Thanks, this looks good to me. I w

Re: [ovs-dev] [PATCH V9 07/31] other-config: Add tc-policy switch to control tc flower flag

ule both to sw and hw. > This option is only relevant if hw-offload is enabled. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> Thanks, the comment below not w

Re: [ovs-dev] [PATCH V9 04/31] tc: Add tc flower functions

On Sun, May 28, 2017 at 02:59:46PM +0300, Roi Dayan wrote: > Add tc helper functions to query and manipulate the flower classifier. > > Signed-off-by: Paul Blakey > Signed-off-by: Roi Dayan Thanks, this looks good to me and I would be happy to apply it if

Re: [ovs-dev] [PATCH V9 05/31] netdev: Adding a new netdev API to be used for offloading flows

ox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> This looks good to me, modulo the minor nits below, and I would be happy to apply it if someone provided a review. > diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc

Re: [ovs-dev] [PATCH V10 02/33] tc: Introduce tc module

On Thu, Jun 08, 2017 at 02:46:19PM +0300, Roi Dayan wrote: > Add tc module to expose tc operations to be used by other modules. > Move some tc related functions from netdev-linux.c to tc.c > This patch doesn't change any functionality. > > Signed-off-by: Paul Blakey >

Re: [ovs-dev] [PATCH V10 03/33] tc: Refactor tcm handle assignment when creating filter qdisc

On Thu, Jun 08, 2017 at 02:46:20PM +0300, Roi Dayan wrote: > Use the available TC macros instead of 0x. > > Signed-off-by: Roi Dayan This looks good to me. I'd be happy to apply it if someone reviewed it. > --- > lib/tc.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [ovs-dev] [PATCH V10 01/33] netdev-linux: Refactor two tc functions

On Thu, Jun 08, 2017 at 02:46:18PM +0300, Roi Dayan wrote: > Refactor tc_make_request and tc_add_del_ingress_qdisc to accept > ifindex instead of netdev struct. > We later want to move those outside netdev-linux module to be > used by other modules. > This patch doesn't change any functionality. >

Re: [ovs-dev] [PATCH V10 04/33] tc: Move functions the create/parse handle to be static inline

On Thu, Jun 08, 2017 at 02:46:21PM +0300, Roi Dayan wrote: > Those functions are just wrappers to available macros for readability. > Move them to tc.h to avoid function-call overhead. > > Signed-off-by: Roi Dayan This looks good to me. I'd be happy to apply it if someone

Re: [ovs-dev] [PATCH V10 28/33] dpctl: Indicate if flow is offloaded when dumping flows of all types

On Sat, Jun 10, 2017 at 10:23:11AM -0300, Flavio Leitner wrote: > On Thu, Jun 08, 2017 at 02:46:45PM +0300, Roi Dayan wrote: > > From: Paul Blakey > > > > When verbosity is requested on dump-flows (-m) indicate which flows > > are offloaded. > > > > Signed-off-by: Paul

Re: [ovs-dev] [PATCH V11 18/33] netdev-tc-offloads: Implement netdev flow put using tc interface

On Tue, Jun 13, 2017 at 06:03:40PM +0300, Roi Dayan wrote: > From: Paul Blakey <pa...@mellanox.com> > > Currently only tunnel offload is supported. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> &g

Re: [ovs-dev] [PATCH V11 00/33] Introducing HW offload support for openvswitch

On Tue, Jun 13, 2017 at 06:03:22PM +0300, Roi Dayan wrote: > This patch series introduces rule offload functionality to dpif-netlink > via netdev ports new flow offloading API. The user can specify whether to > enable rule offloading or not via OVS configuration. Netdev providers > are able to

Re: [ovs-dev] [PATCH V11 08/33] other-config: Add tc-policy switch to control tc flower flag

ule both to sw and hw. > This option is only relevant if hw-offload is enabled. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> This looks good to

Re: [ovs-dev] [PATCH V11 02/33] tc: Introduce tc module

On Tue, Jun 13, 2017 at 06:03:24PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Add tc module to expose tc operations to be used by other modules. > Move some tc related functions from netdev-linux.c to tc.c > This patch doesn't change any functionality. > >

Re: [ovs-dev] [PATCH V11 01/33] netdev-linux: Refactor two tc functions

On Tue, Jun 13, 2017 at 06:03:23PM +0300, Roi Dayan wrote: > Refactor tc_make_request and tc_add_del_ingress_qdisc to accept > ifindex instead of netdev struct. > We later want to move those outside netdev-linux module to be > used by other modules. > This patch doesn't change any functionality. >

Re: [ovs-dev] [PATCH V11 05/33] tc: Add tc flower functions

On Tue, Jun 13, 2017 at 06:03:27PM +0300, Roi Dayan wrote: > Add tc helper functions to query and manipulate the flower classifier. > > Signed-off-by: Paul Blakey > Co-authored-by: Roi Dayan > Signed-off-by: Roi Dayan > Acked-by: Flavio

Re: [ovs-dev] [PATCH V11 04/33] tc: Move functions the create/parse handle to be static inline

On Tue, Jun 13, 2017 at 06:03:26PM +0300, Roi Dayan wrote: > Those functions are just wrappers to available macros for readability. > Move them to tc.h to avoid function-call overhead. > > Signed-off-by: Roi Dayan > Acked-by: Flavio Leitner Thanks, applied

Re: [ovs-dev] [PATCH V11 03/33] tc: Refactor tcm handle assignment when creating filter qdisc

On Tue, Jun 13, 2017 at 06:03:25PM +0300, Roi Dayan wrote: > Use the available TC macros instead of 0x. > > Signed-off-by: Roi Dayan > Acked-by: Flavio Leitner Thanks, applied to master. ___ dev mailing list

Re: [ovs-dev] [PATCH V11 08/33] other-config: Add tc-policy switch to control tc flower flag

On Wed, Jun 14, 2017 at 10:17:54AM +0200, Simon Horman wrote: > On Tue, Jun 13, 2017 at 06:03:30PM +0300, Roi Dayan wrote: > > From: Paul Blakey <pa...@mellanox.com> > > > > Add a new configuration tc-policy option that controls tc > > flower flag. Possible o

Re: [ovs-dev] [PATCH V11 06/33] netdev: Adding a new netdev API to be used for offloading flows

ox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > Acked-by: Flavio Leitner <f...@sysclose.org> Thanks, applied to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH V11 07/33] other-config: Add hw-offload switch to control netdev flow offloading

f the kernel datapath. > This configuration option defaults to false - disabled. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > Acked-by: Flav

Re: [ovs-dev] [PATCH] docs: Document that hw-offload is experimental.

ental. Over time, we expect that the functionality and usefulness > of this feature will grow and we should be in a better shape to revisit > the status of this functionality after it has had some time to mature. > > Signed-off-by: Joe Stringer <j...@ovn.org> Acked

Re: [ovs-dev] [PATCH V11 00/33] Introducing HW offload support for openvswitch

On Thu, Jun 15, 2017 at 04:36:25PM -0700, Joe Stringer wrote: > On 15 June 2017 at 03:15, Simon Horman <simon.hor...@netronome.com> wrote: > > On Tue, Jun 13, 2017 at 06:03:22PM +0300, Roi Dayan wrote: > >> This patch series introduces rule offload functionality to dpif

Re: [ovs-dev] [PATCH] tests: Only run python SSL test if SSL support is configured

On Wed, May 03, 2017 at 10:56:39AM -0700, Ben Pfaff wrote: > On Wed, May 03, 2017 at 05:55:51PM +0200, Simon Horman wrote: > > Only run python SSL test, which invokes ovsdb with a --remote=pssl, > > if SSL support is configured. > > > > Without this change the following

Re: [ovs-dev] [PATCH ovs V8 01/26] tc: Add tc flower interface

On Sun, May 07, 2017 at 02:46:14PM +0300, Roi Dayan wrote: > > > On 04/05/2017 19:35, Simon Horman wrote: > >On Wed, May 03, 2017 at 06:07:52PM +0300, Roi Dayan wrote: > >>From: Paul Blakey <pa...@mellanox.com> > >> > >>Add tc flower interface that

Re: [ovs-dev] [PATCH v3 1/5] datapath: Fixups for MPLS GSO

Hi Yi-Hung, I'm having a little trouble following the status of this patchset. Would it be possible to repost v3 (or post v4 if that is pending) with: * A cover letter including: - An overview of the patchset - An overview of the changes between v2 and v3 (and v4 is there is one).

Re: [ovs-dev] [PATCH v4 0/5] Backport upstream mpls fix

On Mon, May 01, 2017 at 10:24:30AM -0700, Yi-Hung Wei wrote: > This series backports the upstream mpls fixes and add a system traffic > test for mpls actions. Thanks Yi-Hung, this looks good to me. Acked-by: Simon Horman <simon.hor...@netronome.com> Joe, were you considering applyi

Re: [ovs-dev] [PATCH ovs V8 05/26] dpif: Save added ports in a port map for netdev flow api use

translate dpif ports to netdevs. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> ... > diff --git a/lib/netdev.h b/lib/netdev.h > index 7435fdf..9aa7e5e 100

  1   2   3   4   5   6   7   8   9   10   >