On Mon, Apr 24, 2023 at 12:37:04PM +0200, Simon Horman wrote:
> On Thu, Apr 20, 2023 at 09:39:28AM +0200, Eelco Chaudron wrote:
> > When doing performance testing with OVS v3.1 we ran into a deadlock
> > situation with the netdev_hmap_rwlock read/write lock. After som
On Fri, Apr 21, 2023 at 05:16:49PM +0200, Adrian Moreno wrote:
> It is equivalent to tc_policer_init() so remove the duplicated function.
>
> Signed-off-by: Adrian Moreno
Nice :)
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvs
On Fri, Apr 21, 2023 at 05:16:48PM +0200, Adrian Moreno wrote:
> Currently, htb rates are capped at ~34Gbps because they are internally
> expressed as 32-bit fields.
>
> Move min and max rates to 64-bit fields and use TCA_HTB_RATE64 and
> TCA_HTB_CEIL64 to configure HTC classes to break this
On Fri, Apr 21, 2023 at 05:16:45PM +0200, Adrian Moreno wrote:
> Currently, the netdev's speed is being calculated by taking the link's
> feature bits (using netdev_get_features()) and transforming them into
> bps.
>
> This mechanism can be both inaccurate and difficult to maintain, mainly
>
On Mon, Apr 24, 2023 at 02:06:53PM +0200, Ilya Maximets wrote:
> On 4/23/23 05:47, wangyunjian wrote:
> > Is there any issue with this patch? Why is it in the Superseded state?
>
> Hi. Not sure what happened here.
> I moved it back to 'New' for now.
That might have been me conflating things.
If
#9 0x40bcfd in bridge_reconfigure vswitchd/bridge.c:921
> #10 0x41f1a9 in bridge_run vswitchd/bridge.c:3313
> #11 0x42d4fb in main vswitchd/ovs-vswitchd.c:132
> #12 0x7f312fbbcc86 in __libc_start_main (/usr/lib64/libc.so.6+0x25c86)
>
> Fixes: fed8962aff57 ("Add new p
ied, but, FWIIW,
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
actual rates.
>
> Signed-off-by: Adrian Moreno
Tested-by: Simon Horman
> ---
> lib/netdev-linux.c | 37 ++---
> 1 file changed, 18 insertions(+), 19 deletions(-)
>
> diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
> index 8ee75981b..a2bae30
rtab(struct ofpbuf *msg, uint16_t type, const struct tc_ratespec
> *rate,
> +uint64_t bps);
Its unfortunate that there are now two parameters relating to the rate.
But I think this is a case of playing the hand we've been dealt.
And as I have no better idea I'm ok with this.
On Fri, Apr 21, 2023 at 05:16:51PM +0200, Adrian Moreno wrote:
> Use TCA_POLICE_RATE64 if the rate cannot be expressed using 32bits.
>
> This breaks the 32Gbps barrier. The new barrier is ~4Tbps caused by
> netdev's API expressing kbps rates using 32-bit integers.
>
> Reported-at:
node in the meter data hash table.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/netdev-dpdk.c | 191 ++
lib/netdev-dpdk.h | 41
lib/netdev-offload-dpdk.c | 191
From: Peng Zhang
Add the meter algorithms. DPDK meter support three algorithms,
and OVS also can support these algorithms.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/netdev-dpdk.c | 58
Hi,
this series adds support for DPDK meter HW offload.
Changes between v3 and v4:
* Add hash to store meter data
* Offload metter with flow
* Use rte_flow for proxy id
Changes between v2 and v3:
* Use common API for DPDK and non-DPDK meter offloads
* Make use of netdev_ports_traverse to
From: Peng Zhang
By calling meter API, so it can offload meter to HW in netdev
datapath. Add the check for datapath in the meter API to avoid
the unnecessary error.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
Documentation/howto
From: Peng Zhang
Manage "transfer" flows via the corresponding mechanism.
Doing so requires that the traffic source be specified
explicitly, via the corresponding pattern item.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
From: Peng Zhang
Add support of DPDK meter action logic. With flow add/destroy
from the HW, add/del the meter in the HW.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/netdev-offload-dpdk.c | 131
On Mon, Apr 24, 2023 at 02:01:03PM +0800, Wan Junjie via dev wrote:
> ovs-save will do replace-flows for ovs restart. For some reason, ovs
> could have an invalid action, like invalid meter. Then adding flows
> will be stopped at the position of the first invalid flow. This could
> happen when ovs
On Mon, Apr 17, 2023 at 06:28:13PM +0200, David Marchand wrote:
> Caught during some code review.
> The incriminated commit had put an unneeded check on tc ingress support
> for the meter offloading test.
>
> Note: SUPPORT_TC_INGRESS_PPS had been reworked in the commit 5f0fdf5e2c2e
> ("test: Move
On Tue, Apr 18, 2023 at 10:34:22AM +0200, David Marchand wrote:
> On Tue, Apr 18, 2023 at 10:20 AM Simon Horman
> wrote:
> >
> > On Mon, Apr 17, 2023 at 06:28:13PM +0200, David Marchand wrote:
> > > Caught during some code review.
> > > The incriminated co
On Sat, Apr 15, 2023 at 11:21:48PM +0800, James Raphael Tiovalen wrote:
> This commit adds some `ovs_assert()` checks to the return values of
> `dp_packet_data()` to ensure that they are not NULL and to prevent
> null-pointer dereferences, which might lead to unwanted crashes. We use
> assertions
On Sat, Apr 15, 2023 at 11:21:49PM +0800, James Raphael Tiovalen wrote:
> This commit adds zero-initializations by changing `SFL_ALLOC` from
> `malloc` to `xzalloc`, initializing a `pollfd` struct variable with
> zeroes, and changing some calls to `xmalloc` to `xzalloc`. This is to
> prevent
for older
> kernels.")
> Suggested-by: David Marchand
> Signed-off-by: Yunjian Wang
> ---
> v3: update commit log
Thanks for the update.
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Mar 30, 2023 at 11:13:32AM +0800, Faicker Mo wrote:
> Thanks for your testing.
> Add the ignore msg "failed to offload flow" to OVS_TRAFFIC_VSWITCHD_STOP can
> pass the fail test.
> I'll post an update later.
Thanks. I'll look out for it.
> From: Simon Horman
On Wed, Mar 22, 2023 at 09:35:29PM +0100, Ilya Maximets wrote:
> On 3/9/23 14:02, Simon Horman wrote:
> > From: Peng Zhang
...
> > diff --git a/lib/netdev-offload-provider.h b/lib/netdev-offload-provider.h
> > index 9108856d18d1..7ecbb8d026f1 100644
> > --- a/li
From: Peng Zhang
Add the meter algorithms. DPDK meter support three algorithms,
and OVS also can support these algorithms.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/netdev-dpdk.c | 58
-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/dpif-netdev.c | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 2c08a71c8db2..e8d0ca6606de 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
to HW.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
Documentation/howto/dpdk.rst | 5 +-
lib/netdev-offload-provider.h | 21 +-
lib/netdev-offload-tc.c | 9 ++-
lib/netdev-offload.c | 135
From: Peng Zhang
Add support of DPDK meter action logic.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/netdev-offload-dpdk.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/lib/netdev-offload-dpdk.c b/lib
From: Peng Zhang
For dpif-netdev, meters are mapped by DPDK meter with one-to-one
relationship. Implement meter offload API to set/get/del the DPDK
meter with proxy port id.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/netdev
On Fri, Mar 17, 2023 at 09:47:36PM +0100, Eelco Chaudron wrote:
>
>
> Send from my phone
>
> > Op 17 mrt. 2023 om 21:11 heeft Marcelo Ricardo Leitner
> > het volgende geschreven:
> >
> > On Thu, Mar 16, 2023 at 09:51:34AM +0100, Eelco Chaudron wrote:
> >>
> >>
> >>> On 22 Dec 2022, at
able for every push.
>
> [1] -
> https://github.com/ovn-org/ovn-fake-multinode/blob/main/.ci/test_basic.sh
>
> Signed-off-by: Numan Siddique
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ke_multinode setup
> by running 'ovn_cluster.sh start'.
>
> This test suite is also triggered for the newly added fake multinode CI
> job.
>
> The fake multinode system tests suite can be enhanced further for new
> features and to cover multi node scenarios.
>
> Signed-off-b
Hi,
this series adds support for DPDK meter HW offload.
Changes between v2 and v3.
* Use common API for DPDK and non-DPDK meter offloads
* Make use of netdev_ports_traverse to offload the meter
* Add dpdk-latest to subject prefix
Changes between v1 and v2:
* Add the prox mechanism: add the
From: Peng Zhang
Manage "transfer" flows via the corresponding mechanism.
Doing so requires that the traffic source be specified
explicitly, via the corresponding pattern item.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
On Fri, Mar 31, 2023 at 02:10:35PM +0200, Dumitru Ceara wrote:
> On 3/31/23 13:52, Simon Horman wrote:
> > On Tue, Mar 21, 2023 at 01:59:06PM -0400, Mark Michelson wrote:
> >> Prior to this commit, ACLs were evaluated and acted on in a single
> >> stage. With this
nd the loop has run the test 73014 times
without recording any failures.
I think we are good here :)
Reviewed-by: Simon Horman
Tested-by: Simon Horman
>
>
> > +])
> > +NS_CHECK_EXEC([at_ns0], [ping -q -c 2 -i 0.2 10.1.1.3 | FORMAT_PING], [0],
> > [dnl
> > +2 packet
> at utilities/ovs-testcontroller.c:180
>
> Fix that by zeroing out the po variable.
>
> Fixes: 577bfa9f6879 ("ofp-util: Add OpenFlow 1.5 packet-out support")
> Signed-off-by: Faicker Mo
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
lt reschedule time may be convenient in
> some conditions, like debugging.
> This patch introduces new commands allowing to get and set the sweep
> interval in ms.
>
> Signed-off-by: Paolo Valerio
Reviewed-by: Simon Horman
___
dev ma
On Thu, Apr 06, 2023 at 02:13:00PM +0200, Ilya Maximets wrote:
> On 4/6/23 08:38, Simon Horman wrote:
> > On Wed, Apr 05, 2023 at 02:07:42PM +, lin huang wrote:
> >> Hi Simon,
> >>
> >> : )
> >> Thanks for your reply.
> >>
> >>
On Thu, Apr 06, 2023 at 02:07:00PM +0200, Dumitru Ceara wrote:
> On 4/5/23 14:43, Simon Horman wrote:
> > On Tue, Apr 04, 2023 at 11:01:26PM +0200, Lorenzo Bianconi wrote:
> >> Similar to qos_max_rate and qos_burst, take into account qos_min_rate in
> >>
On Mon, Apr 03, 2023 at 11:50:26AM +0200, Ales Musil wrote:
> After integration bridge change the tunnels would
> stay on the old bridge preventing new tunnels creation
> and disrupting traffic. Detect the bridge change
> and clear the tunnels from the old integration bridge.
>
> Reported-at:
Musil
> ---
> v8: No change since v7.
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Apr 10, 2023 at 09:23:46PM +0800, Wan Junjie via dev wrote:
> put dump-meters' result in one line so add-meters can handle.
> save and restore meters when restart ovs.
> bundle functions are not implemented in this patch.
>
> Signed-off-by: Wan Junjie
Hi,
unfortunately this one doesn't
On Tue, Apr 11, 2023 at 11:03:46AM +0800, Wan Junjie wrote:
> put dump-meters' result in one line so add-meters can handle.
> save and restore meters when restart ovs.
> bundle functions are not implemented in this patch.
>
> Signed-off-by: Wan Junjie
>
> ---
> v9:
> fix verbosity mask bits for
On Mon, Apr 10, 2023 at 01:26:12PM -0400, Mark Michelson wrote:
...
> diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c
...
> @@ -2390,6 +2394,16 @@ nbctl_acl_add(struct ctl_context *ctx)
> nbrec_acl_set_options(acl, );
> }
>
> +const char *tier_s =
On Mon, Apr 10, 2023 at 01:26:11PM -0400, Mark Michelson wrote:
> With this commit, ACLs can now be arranged in hierarchical tiers. A tier
> number can be assigned to an ACL. When evaluating ACLs, we first will
> consider ACLs at tier 0. If no matching ACL is found, then we move to
> tier 1. This
On Tue, Apr 04, 2023 at 01:46:05PM +, lin huang wrote:
> Hi Ilya,
>
> Pls review my code.
>
> I want to add a new policer which is pps-based in netdev-dpdk module.
> The policer is divided into ingress and egress part. Both use the ovs native
> tocken bucket library as the counter.
>
ding a flow per load-balancer backend.
>
> Signed-off-by: Lorenzo Bianconi
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi Wan Junjie,
On Tue, Apr 04, 2023 at 03:42:47PM +0800, Wan Junjie wrote:
> Hi Simon,
>
> On Wed, Mar 29, 2023 at 11:57 PM Simon Horman
> wrote:
> > On Fri, Mar 10, 2023 at 09:03:48PM +0800, Wan Junjie wrote:
...
> > > @@ -805,5 +831,73 @@ ofputil_format_meter_mod
On Tue, Apr 04, 2023 at 11:01:26PM +0200, Lorenzo Bianconi wrote:
> Similar to qos_max_rate and qos_burst, take into account qos_min_rate in
> port_has_qos_params routine.
>
> Fixes: dbf12e5fe1f7 ("qos: add support for port minimum bandwidth guarantee")
> Signed-off-by: Lorenzo Bianconi
Hi
On Thu, Mar 30, 2023 at 08:17:18AM +, Naveen Yerramneni wrote:
> Add OpenFlow extn to set conntrack entries limit per zone.
> This extn will be used in future to set the zone level limit for
> drop zones used by OVN.
>
> Signed-off-by: Naveen Yerramneni
> Reviewe
On Fri, Apr 07, 2023 at 10:44:35AM +0200, Simon Horman wrote:
> On Thu, Apr 06, 2023 at 07:05:13PM -0700, Jakub Kicinski wrote:
> > On Wed, 5 Apr 2023 07:53:41 + Felix Huettner wrote:
> > > assume the following setup on a single machine:
> > > 1. An openvswit
On Thu, Apr 06, 2023 at 05:25:06PM +0200, Dumitru Ceara wrote:
> On 4/6/23 14:45, Simon Horman wrote:
> > On Thu, Apr 06, 2023 at 02:07:00PM +0200, Dumitru Ceara wrote:
> >> On 4/5/23 14:43, Simon Horman wrote:
> >>> On Tue, Apr 04, 2023 at 11:01:26PM +0200, Lorenzo
On Thu, Apr 06, 2023 at 07:05:13PM -0700, Jakub Kicinski wrote:
> On Wed, 5 Apr 2023 07:53:41 + Felix Huettner wrote:
> > assume the following setup on a single machine:
> > 1. An openvswitch instance with one bridge and default flows
> > 2. two network namespaces "server" and "client"
> > 3.
is longer than 16 bytes, the thread
> name will fail to be set
>
> Signed-off-by: Songtao Zhan
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> at utilities/ovs-testcontroller.c:180
>
> Fix that by initing the flow metadata.
>
> Fixes: 35eb6326d5d0 ("ofp-util: Add flow metadata to ofputil_packet_out")
> Signed-off-by: Faicker Mo
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Apr 07, 2023 at 02:59:04PM +0800, wanghanlin wrote:
> When 'cs' is not connected to a server, then
> ovsdb_cs_db_compose_lock_request__ will update
> 'cs_db' lock flag, but the lock flag will not
> be updated next.
>
> Signed-off-by: wanghanlin
Hi,
Are there also error conditions where
gt;
> Reported-at: https://bugzilla.redhat.com/2173635
> Signed-off-by: Ales Musil
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ceara
> > ---
> > NOTE: this should be applied to branches 22.09, 22.06 and 22.03 (LTS).
> > ---
> > .ci/ovn-kubernetes/Dockerfile| 2 +-
> > .github/workflows/ovn-kubernetes.yml | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
&
On Wed, Mar 15, 2023 at 05:11:01PM +0800, Faicker Mo wrote:
> Derivation cases of CVE-2020-35498:
> 1. invalid ipv4 header total-length field
> 2. invalid ipv6 header payload-length field
> These may cause unwanted flow to send to datapath.
>
>
> Signed-off-by: Faicker Mo
I think the immediate
.
The code looks good to me, thanks for addressing by review of v2.
> Signed-off-by: Naveen Yerramneni
> Reviewed-by: Simon Horman
> ---
> Notes:
> v1 -> v2
> - Fix memory leak and added logs
> v2 -> v3
> - Addressed nits
...
_
he rest succeeded:
a success rate of 99.95% :)
As it's not entirely clear how reliable such a setup is
(or our expectations for it) [1], I think I am ok with this patch.
Reviewed-by: Simon Horman
[1] https://mail.openvswitch.org/pipermail/ovs-dev/2023-March/403164.html
For the record, of the failur
On Tue, Mar 28, 2023 at 01:45:22PM +0200, Eelco Chaudron wrote:
>
>
> On 10 Mar 2023, at 17:20, Simon Horman wrote:
>
> > On Fri, Mar 10, 2023 at 10:15:44AM +0100, Simon Horman wrote:
> >> On Thu, Mar 09, 2023 at 05:22:43PM +0100, Eelco Chaudron wrote:
> >>&
lt reschedule time may be convenient in
> some conditions, like debugging.
> This patch introduces new commands allowing to get and set the sweep
> next run in ms.
>
> Signed-off-by: Paolo Valerio
Reviewed-by: Simon Horman
___
dev ma
On Fri, Mar 10, 2023 at 09:03:48PM +0800, Wan Junjie wrote:
> put dump-meters' result in one line so add-meters can handle.
> save and restore meters when restart ovs.
> bundle functions are not implemented in this patch.
>
> Signed-off-by: Wan Junjie
>
> ---
> v5:
> merge oneline to verbosity
is longer than 16 bytes, the thread
> name will fail to be set
>
> Signed-off-by: Songtao Zhan
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Mar 21, 2023 at 01:59:06PM -0400, Mark Michelson wrote:
> Prior to this commit, ACLs were evaluated and acted on in a single
> stage. With this commit, evaluation of ACLs and acting on an ACL's
> decision are separated into two stages.
>
> The acl_eval stage checks the ACL match and will
On Mon, Mar 27, 2023 at 06:50:10AM -0400, Mike Pattrick wrote:
> From: Flavio Leitner
>
> Document the implementation of netdev hardware offloading
> in userspace datapath.
>
> Signed-off-by: Flavio Leitner
> Co-authored-by: Mike Pattrick
> Signed-off-by: Mike Pattr
mmits targeting
> conversion speed increase.
>
> Signed-off-by: Ilya Maximets
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
, because we shouldn't blindly
> trust the storage.
>
> Signed-off-by: Ilya Maximets
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
t; data. The database file will not be that similar to the original,
> but there is no way to represent conversion in a standalone database
> file format otherwise.
>
> Fixes: 00de46f9ee42 ("ovsdb-tool: Convert clustered db to standalone db.")
> Sign
Signed-off-by: Flavio Leitner
> Co-authored-by: Mike Pattrick
> Signed-off-by: Mike Pattrick
> Reviewed-by: David Marchand
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> Handled the same way as we did for the previous incompatible format
> change in 2.15 (column diffs).
>
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-discuss/2022-December/052140.html
> Signed-off-by: Ilya Maximets
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
the storage.
>
> Keep the converted database from the first time around and use it
> after reading the request back from the storage. This cuts in half
> the conversion CPU cost.
>
> Signed-off-by: Ilya Maximets
Reviewed-by: Simon Horman
end out all the monitor
> replies in the example above. So, it's a 40x performance improvement.
> On a more reasonable setup with 250 nodes, the process takes up to
> 8-10 seconds instead of 4-5 minutes.
>
> Conditional monitoring will benefit from this change as well, however
On Wed, Apr 05, 2023 at 02:07:42PM +, lin huang wrote:
> Hi Simon,
>
> : )
> Thanks for your reply.
>
> There are some explanations about your comments.
>
> Best regards, Huang Lin.
>
> > -Original Message-
> > From: Simon Horman
>
On Thu, Mar 30, 2023 at 09:04:02PM +0200, Ilya Maximets wrote:
> On 3/30/23 11:45, Simon Horman wrote:
> > On Fri, Mar 17, 2023 at 09:47:36PM +0100, Eelco Chaudron wrote:
> >>
> >>
> >> Send from my phone
> >>
> >>> Op 17 mrt. 2023 om
On Thu, Mar 30, 2023 at 05:27:23PM +0800, Faicker Mo wrote:
> The device may be deleted and added with ifindex changed.
> The tc rules on the device will be deleted if the device is deleted.
> The func tc_del_filter will fail when flow del. The mapping of
> ufid to tc will not be deleted.
> The
On Fri, Mar 31, 2023 at 12:05:09PM +0200, Ilya Maximets wrote:
> On 3/31/23 11:07, Simon Horman wrote:
> > On Thu, Mar 30, 2023 at 09:04:02PM +0200, Ilya Maximets wrote:
> >> On 3/30/23 11:45, Simon Horman wrote:
> >>> On Fri, Mar 17, 2023 at 09:47:36PM +0100, Eelco
On Thu, Feb 02, 2023 at 12:09:47PM +0100, Eelco Chaudron wrote:
> Include and run the system-traffic.at tests as part of the system offload
> testsuite. Exclude all the tests that will not run without any special
> modifications.
>
> Signed-off-by: Eelco Chaudron
> Acked-by: Roi Dayan
...
>
ecessary rather
> than allocating the entire space at once. This makes the approach less
> memory-intensive for id pools with a large theoretical maximum number of
> values.
>
> Signed-off-by: Mark Michelson
Reviewed-by: Simon Horman
On Fri, Feb 10, 2023 at 12:30:58PM +0100, Adrian Moreno wrote:
>
>
> On 1/25/23 16:35, Simon Horman wrote:
> > On Tue, Jan 24, 2023 at 08:21:28PM +0100, Adrián Moreno wrote:
> > > From: Adrian Moreno
> > >
> > > IPFIX templates have to be sent for e
; investigation. They are:
>
> datapath - truncate and output to gre tunnel
> datapath - truncate and output to gre tunnel by simulated packets
>
> These tests where executed on a Fedora37 machine with the kernel
> 6.1.5-200.fc37.x86_64 installed.
>
> Signed-off-
On Thu, Feb 09, 2023 at 09:42:03AM +0100, Eelco Chaudron wrote:
>
>
> On 8 Feb 2023, at 17:50, Simon Horman wrote:
>
> > On Tue, Feb 07, 2023 at 03:07:24PM +0100, Eelco Chaudron wrote:
> >> With some datapaths, read TC, it takes a bit longer to update the
> >&
On Thu, Feb 09, 2023 at 05:32:40PM +0800, Hangyu Hua wrote:
> old_meter needs to be free after it is detached regardless of whether
> the new meter is successfully attached.
>
> Fixes: c7c4c44c9a95 ("net: openvswitch: expand the meters supported number")
> Signed-off-by: Hangyu Hua
> ---
>
>
4c44c9a95 ("net: openvswitch: expand the meters supported number")
> > Signed-off-by: Hangyu Hua
>
> Thanks for doing a v3. The change looks good to me!
>
> Acked-by: Eelco Chaudron
Reviewed-by: Simon Horman
___
dev mailin
On Thu, Feb 02, 2023 at 12:09:37PM +0100, Eelco Chaudron wrote:
> This series makes it possible to include system-traffic.at tests into
> "make check-offloads" tests.
>
> The last patch of the series explains which tests are still not passing
> and might need some more work.
>
> I'll try to work
On Fri, Feb 03, 2023 at 08:36:12PM +0100, Ilya Maximets wrote:
> On 2/3/23 17:48, Simon Horman wrote:
> > On Thu, Feb 02, 2023 at 12:09:47PM +0100, Eelco Chaudron wrote:
> >> Include and run the system-traffic.at tests as part of the system offload
> >> tests
hould
appear in the patch subject:
[PATCH v1 net-next 1/3] genetlink: Use string_is_valid() helper
That notwithstanding,
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
g_helpers: Move string_is_valid()
That notwithstanding,
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Feb 03, 2023 at 11:42:45PM +0800, Eddy Tao wrote:
> Use actual CPU number instead of hardcoded value to decide the size
> of 'cpu_used_mask' in 'struct sw_flow'. Below is the reason.
>
> 'struct cpumask cpu_used_mask' is embedded in struct sw_flow.
> Its size is hardcoded to
hould
appear in the patch subject:
[PATCH v1 net-next 3/3] openvswitch: Use string_is_valid()
That notwithstanding,
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Jan 31, 2023 at 10:19:39PM +0300, Fedor Pchelkin wrote:
> Syzkaller reports a memory leak of new_flow in ovs_flow_cmd_new() as it is
> not freed when an allocation of a key fails.
>
> BUG: memory leak
> unreferenced object 0x888116668000 (size 632):
> comm "syz-executor231", pid
On Tue, Feb 07, 2023 at 12:31:33PM +0800, Eddy Tao wrote:
> Redefine clear_vlan to initialize one struct vlan_head
> Define clear_vlans to initialize key.eth.vlan and key.eth.cvlan
> Calls the revised functions accurately
>
> Reasoning:
>
> For vlan packet, current code calls clear_vlan
On Wed, Feb 08, 2023 at 07:29:27AM +0100, Ales Musil wrote:
> On Tue, Feb 7, 2023 at 11:54 AM Simon Horman
> wrote:
>
> > On Mon, Feb 06, 2023 at 12:46:10PM +0100, Ales Musil wrote:
> > > The inner header was not handled properly.
> > > Simplify the
e
> done only when defrag returns 0, as it does in other places
> in kernel.
>
> Signed-off-by: Xin Long
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ned-off-by: Xin Long
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
t; There are nf_ct_helper() and nf_ct_add_helper() from nf_conntrak_helper
> in this patch, and will be more in the following patches.
>
> Signed-off-by: Xin Long
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mai
;
> Signed-off-by: Xin Long
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ff-by: Xin Long
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
901 - 1000 of 1494 matches
Mail list logo
