Re: [ovs-dev] [PATCH v2 2/3] ovs-router: Set suitable type to netdev_open().

, and route_table_valid is inited as false (we will call the route_table_reset in this case). So it’s also unnecessary to immediately reset route table in the route_table_init(). On Fri, Aug 4, 2017 at 2:00 AM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Jul 18, 2017 at 08:44:15PM -0700, Tonghao Zhang wrot

Re: [ovs-dev] [PATCH v2 2/3] ovs-router: Set suitable type to netdev_open().

Hi Ben, this patch is ok ? On Fri, Aug 4, 2017 at 10:45 AM, Tonghao Zhang <xiangxia.m@gmail.com> wrote: > We can avoid the deadlock via removing the route_table_reset() from > the route_table_init() > > the call trace is below > dp_initialize (ovsthread_once) &

Re: [ovs-dev] [PATCH v2 2/3] ovs-router: Set suitable type to netdev_open().

This should > not have changed the behavior at all. > > I wonder whether we should change the behavior of netdev_open() with a > NULL type, so that it somehow searches for the proper type. > > Thank you for your work making OVS better. > > On Fri, Aug 11, 2017 at 06:02:06PM +0

Re: [ovs-dev] [PATCH 2/2] openvswitch: Optimize operations for OvS flow_stats.

check all possible cpu when getting, >> cleaning, and updating the flow_stats. Adding the cpu_used_mask to >> sw_flow struct does’t increase the cacheline number. >> >> Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.com> > > Patch look

[ovs-dev] [PATCH v2 2/2] openvswitch: Optimize operations for OvS flow_stats.

all possible cpu when getting, cleaning, and updating the flow_stats. Adding the cpu_used_mask to sw_flow struct does’t increase the cacheline number. Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.com> Acked-by: Pravin B Shelar <pshe...@ovn.org> --- net/openvswitch/flow.c | 7

[ovs-dev] [PATCH v2 1/2] openvswitch: Optimize updating for OvS flow_stats.

In the ovs_flow_stats_update(), we only use the node var to alloc flow_stats struct. But this is not a common case, it is unnecessary to call the numa_node_id() everytime. This patch is not a bugfix, but there maybe a small increase. Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.

[ovs-dev] [PATCH 2/2] openvswitch: Optimize operations for OvS flow_stats.

all possible cpu when getting, cleaning, and updating the flow_stats. Adding the cpu_used_mask to sw_flow struct does’t increase the cacheline number. Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.com> --- net/openvswitch/flow.c | 7 --- net/openvswitch/flow.h | 2 +

[ovs-dev] [PATCH 1/2] openvswitch: Optimize updating for OvS flow_stats.

In the ovs_flow_stats_update(), we only use the node var to alloc flow_stats struct. But this is not a common case, it is unnecessary to call the numa_node_id() everytime. This patch is not a bugfix, but there maybe a small increase. Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.

[ovs-dev] [PATCH v2 1/3] ovs-router: Remove redundant headers.

Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.com> --- lib/ovs-router.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/ovs-router.c b/lib/ovs-router.c index b387657..ce2f80b 100644 --- a/lib/ovs-router.c +++ b/lib/ovs-router.c @@ -44,8 +44,6 @@ #include "unixctl.h

[ovs-dev] [PATCH v2 3/3] AUTHORS.rst: Update name and e-mail.

Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.com> --- AUTHORS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AUTHORS.rst b/AUTHORS.rst index 10c84c1..177cef8 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -312,6 +312,7 @@ Tsvi Slonim

[ovs-dev] [PATCH 3/3] AUTHORS.rst: Update name and e-mail.

Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.com> --- AUTHORS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AUTHORS.rst b/AUTHORS.rst index 10c84c1..177cef8 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -312,6 +312,7 @@ Tsvi Slonim

[ovs-dev] [PATCH 2/3] ovs-router: Set suitable type to netdev_open().

35560.html But without it, the patch I support also avoid the problem. However we should check the type in the ovs-router module, this patch works well with the patch Eelco support. Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.com> --- lib/ov

[ovs-dev] [PATCH 1/3] ovs-router: Remove redundant headers.

Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.com> --- lib/ovs-router.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/ovs-router.c b/lib/ovs-router.c index b387657..ce2f80b 100644 --- a/lib/ovs-router.c +++ b/lib/ovs-router.c @@ -44,8 +44,6 @@ #include "unixctl.h

[ovs-dev] [PATCH] tests: Check ip command whether support udp6zerocsum.

The version of ip-route may not support udp6zerocsum for vxlan6 or geneve6. If we run the kernel check, there may be always error message. Before running the test units, we check the ip command. Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.com> --- tests/system-common-macros.a

[ovs-dev] [PATCH] dpif-netdev: Optimize the exact match lookup.

% performance improve, but it is hard to tell exactly due to variance in the test results). Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.com> --- lib/dpif-netdev.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c

[ovs-dev] [PATCH 1/2] datapath: Avoid using stack larger than 1024.

Upstream commit: commit 9cc9a5cb176ccb4f2cda5ac34da5a659926f125f Author: Tonghao Zhang <xiangxia.m@gmail.com> Date: Thu Jun 29 17:27:44 2017 -0700 datapath: Avoid using stack larger than 1024. When compiling OvS-master on 4.4.0-81 kernel, there is a w

[ovs-dev] [PATCH 2/2] AUTHORS.rst: Update email and name.

Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.com> --- AUTHORS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AUTHORS.rst b/AUTHORS.rst index 5fbb9b6..ada3fe7 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -310,6 +310,7 @@ Tsvi Slonim

Re: [ovs-dev] [PATCH v3] route-table: Remove netdevs in netdev_hash when deleted

why not remove the function of route_table_link_del to name_table_change() ? On Wed, Aug 9, 2017 at 3:41 PM, fukaige wrote: > From: Kaige Fu > > Start a virtual machine with its backend tap device attached to a brought up > linux bridge. > If we delete

Re: [ovs-dev] [PATCH] tests/stp: Use long warps instead of multiple calls.

Thanks for your work. Tested-by: Tonghao Zhang <xiangxia.m@gmail.com> On Wed, Sep 13, 2017 at 4:46 PM, Ilya Maximets <i.maxim...@samsung.com> wrote: > This change fixes constant test failure on RHEL 7 system with > CFL

Re: [ovs-dev] [PATCH 0/2] datapath: Optimize operations for OvS flow_stats.

Haha, I'm fine. We just make the ovs better. On Sat, Sep 16, 2017 at 1:45 AM, Greg Rose <gvrose8...@gmail.com> wrote: > On 09/10/2017 06:00 PM, Tonghao Zhang wrote: >> >> The linux kernel 4.13 has been released. I backport the patches of >> openvswitch h

[ovs-dev] [PATCH 1/2] datapath: Optimize updating for OvS flow_stats.

Upstream commit: commit c57c054eb5b1ccf230c49f736f7a018fcbc3e952 Author: Tonghao Zhang <xiangxia.m@gmail.com> Date: Mon Jul 17 23:28:05 2017 -0700 openvswitch: Optimize updating for OvS flow_stats. In the ovs_flow_stats_update(), we only use th

[ovs-dev] [PATCH 2/2] datapath: Optimize operations for OvS flow_stats.

Upstream commit: commit c4b2bf6b4a35348fe6d1eb06928eb68d7b9d99a9 Author: Tonghao Zhang <xiangxia.m@gmail.com> Date: Mon Jul 17 23:28:06 2017 -0700 openvswitch: Optimize operations for OvS flow_stats. When calling the flow_free() to free the fl

[ovs-dev] [PATCH 0/2] datapath: Optimize operations for OvS flow_stats.

The linux kernel 4.13 has been released. I backport the patches of openvswitch here. Tonghao Zhang (2): datapath: Optimize updating for OvS flow_stats. datapath: Optimize operations for OvS flow_stats. datapath/flow.c | 10 +- datapath/flow.h | 2 ++ datapath

[ovs-dev] [PATCH RFC] ofproto: Support multiple ovs-vswitchd process

en_vSwitch . other_config:backend-prefix="dp1" Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.com> --- ofproto/ofproto-dpif.c | 29 ++--- ofproto/ofproto-provider.h | 2 +- ofproto/ofproto.c | 8 ++-- ofproto/ofproto.h | 3 ++- vswitchd/bridge.c

[ovs-dev] [PATCH] vswitch.xml: Add details for mac option.

Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.com> --- vswitchd/vswitch.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index f899a19..e73fdca 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -2100,7 +

[ovs-dev] ovs+dpdk vhost-user performance.

hi, I tested the vhost-user, but i dont get a better performance. The test case is VM2VM which are in the same host. if we use the vhost-net in kernel, we get a 20 Gbits/sec throughput, but vhost-user is only 5Gits/sec. vhost-net: qemu-system-x86_64 -enable-kvm -m 1G -smp 4 \ -cpu host \ -netdev

[ovs-dev] [PATCH] netdev-linux: Report netdev change events when mac changed.

, then openvswitch will reconfigure the datapath id and mac addr of local port. Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.com> --- lib/netdev-linux.c | 3 +++ lib/netlink-notifier.c | 4 +--- lib/netlink-notifier.h | 1 + lib/rtnetlink.c| 9 + lib/rtnetlink.h

[ovs-dev] [PATCH] netdev-linux: Report netdev change events when mac changed.

will be c6:c6:d7:46:b4:4b This patch reports the mac changed event when ports changed, then openvswitch will reconfigure the datapath id and mac addr of local port. Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.com> --- lib/netdev-linux.c | 3 +++ lib/netlink-notifier.c | 4 +--- lib/n

Re: [ovs-dev] [PATCH net-next 1/6] netdev-dpdk: Allow vswitchd to parse devargs as dpdk-bond args

On Thu, Apr 12, 2018 at 10:18 PM, Jan Scheurich wrote: >> > The bond of openvswitch has not good performance. >> >> Any examples? > > For example, balance-tcp bond mode for L34 load sharing still requires a > recirculation after dp_hash. Yes, we need more bond modes

Re: [ovs-dev] [PATCH net-next 0/6] Add dpdk-bond support

On Sat, Apr 14, 2018 at 2:16 AM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Apr 12, 2018 at 05:52:46AM -0700, xiangxia.m@gmail.com wrote: >> From: Tonghao Zhang <xiangxia.m@gmail.com> >> >> The bond of openvswitch has not good performance. > >

[ovs-dev] interface mac setting

One question, why now ovs can only set the mac of internal interface, for example: ovs-vsctl set Interface p1 type=internal mac=\"00:11:22:33:44:55\" ovs-vsctl get Interface p1 mac_in_use And the doc about 'mac' is not explained, why we cannot set it for other type interface. So it's a bug?

Re: [ovs-dev] [PATCH net-next 0/6] Add dpdk-bond support

On Sat, Apr 14, 2018 at 2:15 AM, Ben Pfaff wrote: > Why is this series tagged "net-next"? It doesn't appear to have > anything to do with the kernel. sorry about that. ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH] ovs-ofctl: Export the command option '--no-names'

g> Signed-off-by: Tonghao Zhang <xiangxia.m@gmail.com> --- utilities/ovs-ofctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c index 386e4f0..c637649 100644 --- a/utilities/ovs-ofctl.c +++ b/utilities/ovs-ofctl.c @@ -514,

Re: [ovs-dev] [PATCH net-next] openvswitch: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

On Mon, Mar 25, 2019 at 9:24 AM wenxu wrote: > > On 2019/3/25 上午2:46, Pravin Shelar wrote: > > On Sun, Mar 24, 2019 at 12:03 AM wenxu wrote: > >> On 2019/3/24 上午5:39, Pravin Shelar wrote: > >>> On Sat, Mar 23, 2019 at 2:18 AM wenxu wrote: > On 2019/3/23 下午3:50, Pravin Shelar wrote: >

Re: [ovs-dev] [PATCH net-next] openvswitch: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

On Sat, Mar 23, 2019 at 5:28 PM wenxu wrote: > > On 2019/3/23 下午3:50, Pravin Shelar wrote: > > On Thu, Mar 21, 2019 at 3:34 AM wrote: > >> From: wenxu > >> > >> There is currently no support for the multicasti/broadcst aspects > >> of VXLAN in ovs. In the datapath flow the tun_dst must

Re: [ovs-dev] [ovs-dev, v3] netdev-linux: Don't remove ingress when not configured

should apply the http://patchwork.ozlabs.org/patch/1081918/ and then test this patch On Wed, Apr 10, 2019 at 2:12 AM 0-day Robot wrote: > > Bleep bloop. Greetings Tonghao Zhang, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered

Re: [ovs-dev] [PATCH] netdev-linux: Don't remove ingress when not configured

On Tue, Apr 9, 2019 at 4:21 AM Ben Pfaff wrote: > > On Fri, Apr 05, 2019 at 12:53:39AM -0400, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > In some case, we may not use the openvswitch tc to limit the ingress > > police rate. And before we add the

[ovs-dev] [PATCH v2 2/2] netdev-linux: Don't remove ingress when not configured

In some case, we may not use the openvswitch tc to limit the ingress police rate. And before we add the port to openvswitch bridge, we may set the ingress policer, so don't remove the ingress when we not configured it in openvswitch. Signed-off-by: Tonghao Zhang --- lib/netdev-linux.c | 21

[ovs-dev] [PATCH v2 1/2] netdev-linux: Add coverage counters for netdev_set_policing when ingress tc-offload

When enable tc-offload, we should add coverage counters for netdev_set_policing. Fixes: e7f6ba220e10 ("lib/tc: add ingress ratelimiting support for tc-offload") Cc: Pieter Jansen van Vuuren Signed-off-by: Tonghao Zhang --- lib/netdev-linux.c | 3 ++- 1 file changed, 2 insertions(+),

[ovs-dev] [PATCH v3 1/2] netdev-linux: Add coverage counters for netdev_set_policing when ingress tc-offload

When enable tc-offload, we should add coverage counters for netdev_set_policing. Fixes: e7f6ba220e10 ("lib/tc: add ingress ratelimiting support for tc-offload") Cc: Pieter Jansen van Vuuren Signed-off-by: Tonghao Zhang Reviewed-by: Pieter Jansen van Vuuren --- lib/netdev-linux.c

[ovs-dev] [PATCH v3 2/2] netdev-linux: Don't remove ingress when not configured

In some case, we may not use the openvswitch tc to limit the ingress police rate. And before we add the port to openvswitch bridge, we may set the ingress policer, so don't remove the ingress when we not configured it in openvswitch. Signed-off-by: Tonghao Zhang --- lib/netdev-linux.c | 23

[ovs-dev] [PATCH REBASE v3] netdev-linux: Add coverage counters for netdev_set_policing when ingress tc-offload

When enable tc-offload, we should add coverage counters for netdev_set_policing. Fixes: e7f6ba220e10 ("lib/tc: add ingress ratelimiting support for tc-offload") Cc: Pieter Jansen van Vuuren Signed-off-by: Tonghao Zhang Reviewed-by: Pieter Jansen van Vuuren --- lib/netdev-li

Re: [ovs-dev] [PATCH v3 1/2] netdev-linux: Add coverage counters for netdev_set_policing when ingress tc-offload

On Sat, Apr 13, 2019 at 1:56 AM Ben Pfaff wrote: > > On Wed, Apr 10, 2019 at 01:10:44PM -0700, Tonghao Zhang wrote: > > When enable tc-offload, we should add coverage counters for > > netdev_set_policing. > > > > Fixes: e7f6ba220e10 ("lib/tc: add ingress ratel

Re: [ovs-dev] [PATCH net-next v6 01/10] net: openvswitch: add flow-mask cache for performance

On Sat, Nov 2, 2019 at 7:40 AM William Tu wrote: > > On Fri, Nov 1, 2019 at 7:25 AM wrote: > > > > From: Tonghao Zhang > > > > The idea of this optimization comes from a patch which > > is committed in 2014, openvswitch community. The author > >

Re: [ovs-dev] same tcp session encapsulated with different udp src port in kernel mode if packet has do ip_forward

On Mon, Nov 4, 2019 at 7:44 PM ychen wrote: > > > > we can easily reproduce this phenomenon by using tcp socket stream sending > from ovs internal port. > > > > > At 2019-10-30 19:49:16, "ychen" wrote: > > Hi, >when we use docker to establish tcp session, we found that the packet > which

Re: [ovs-dev] [PATCH net-next] net: openvswitch: add hash info to upcall

On Mon, Nov 11, 2019 at 9:07 PM Simon Horman wrote: > > On Sun, Nov 10, 2019 at 07:44:18PM +0800, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > When using the kernel datapath, the upcall don't > > add skb hash info relatived. That will intro

Re: [ovs-dev] [PATCH ovs] ofproto-dpif-upcall: Allow HASH packet attribute

ping On Fri, Nov 15, 2019 at 10:59 AM wrote: > > From: Tonghao Zhang > > The kernel datapath may sent upcall with hash info, > ovs-vswitchd should get it from upcall and then send > it back. > > The reason is that: > | When using the kernel datapath, the upcall don'

Re: [ovs-dev] [PATCH net-next v3] net: openvswitch: add hash info to upcall

On Wed, Nov 13, 2019 at 2:06 AM Gregory Rose wrote: > > > On 11/12/2019 7:08 AM, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > When using the kernel datapath, the upcall don't > > include skb hash info relatived. That will introduce > >

Re: [ovs-dev] [PATCH v2] Change in openvswitch kernel module to support MPLS label depth of 3 in ingress direction.

On Fri, Nov 22, 2019 at 2:15 AM Gregory Rose wrote: > > > On 11/21/2019 7:49 AM, Martin Varghese wrote: > > From: Martin Varghese > > > > The openvswitch kernel module was supporting a MPLS label depth of 1 > > in the ingress direction though the userspace OVS supports a max depth > > of 3

Re: [ovs-dev] [PATCH net-next v4 08/10] net: openvswitch: fix possible memleak on destroy flow-table

On Thu, Oct 24, 2019 at 3:14 PM Pravin Shelar wrote: > > On Tue, Oct 22, 2019 at 7:35 PM Tonghao Zhang > wrote: > > > > On Tue, Oct 22, 2019 at 2:58 PM Pravin Shelar wrote: > > > > ... > > > > > > > > > Sure, I can review it, Can you

Re: [ovs-dev] [PATCH net-next v4 08/10] net: openvswitch: fix possible memleak on destroy flow-table

On Fri, Oct 18, 2019 at 6:38 AM Pravin Shelar wrote: > > On Wed, Oct 16, 2019 at 5:50 AM wrote: > > > > From: Tonghao Zhang > > > > When we destroy the flow tables which may contain the flow_mask, > > so release the flow mask struct. > > > > S

Re: [ovs-dev] [PATCH net-next v4 05/10] net: openvswitch: optimize flow-mask looking up

On Sat, Oct 19, 2019 at 7:27 AM William Tu wrote: > > On Wed, Oct 16, 2019 at 5:54 AM wrote: > > > > From: Tonghao Zhang > > > > The full looking up on flow table traverses all mask array. > > If mask-array is too large, the number of invalid flow-mask &g

Re: [ovs-dev] [PATCH net-next v4 08/10] net: openvswitch: fix possible memleak on destroy flow-table

On Sat, Oct 19, 2019 at 2:12 AM Pravin Shelar wrote: > > On Thu, Oct 17, 2019 at 8:16 PM Tonghao Zhang > wrote: > > > > On Fri, Oct 18, 2019 at 6:38 AM Pravin Shelar wrote: > > > > > > On Wed, Oct 16, 2019 at 5:50 AM wrote: > > > > > >

Re: [ovs-dev] [PATCH net-next v4 08/10] net: openvswitch: fix possible memleak on destroy flow-table

On Tue, Oct 29, 2019 at 3:38 PM Pravin Shelar wrote: > > On Sun, Oct 27, 2019 at 11:49 PM Tonghao Zhang > wrote: > > > > On Thu, Oct 24, 2019 at 3:14 PM Pravin Shelar wrote: > > > > > > On Tue, Oct 22, 2019 at 7:35 PM Tonghao Zhang > > > wrote:

Re: [ovs-dev] [PATCH net-next v4 08/10] net: openvswitch: fix possible memleak on destroy flow-table

On Tue, Oct 22, 2019 at 2:58 PM Pravin Shelar wrote: > > On Sun, Oct 20, 2019 at 10:02 PM Tonghao Zhang > wrote: > > > > On Sat, Oct 19, 2019 at 2:12 AM Pravin Shelar wrote: > > > > > > On Thu, Oct 17, 2019 at 8:16 PM Tonghao Zhang > > > wrote:

Re: [ovs-dev] [PATCH net-next v4 00/10] optimize openvswitch flow looking up

On Tue, Oct 22, 2019 at 1:14 AM William Tu wrote: > > On Wed, Oct 16, 2019 at 5:50 AM wrote: > > > > From: Tonghao Zhang > > > > This series patch optimize openvswitch for performance or simplify > > codes. > > > > Patch 1, 2, 4: Port Pravin B

Re: [ovs-dev] [PATCH net-next v3] net: openvswitch: add hash info to upcall

On Wed, Nov 13, 2019 at 12:54 PM Pravin Shelar wrote: > > On Tue, Nov 12, 2019 at 7:09 AM wrote: > > > > From: Tonghao Zhang > > > > When using the kernel datapath, the upcall don't > > include skb hash info relatived. That will introduce > > some pro

Re: [ovs-dev] [PATCH net-next] net: openvswitch: add hash info to upcall

> On Nov 12, 2019, at 12:35 PM, Pravin Shelar wrote: > >> On Sun, Nov 10, 2019 at 3:44 AM wrote: >> >> From: Tonghao Zhang >> >> When using the kernel datapath, the upcall don't >> add skb hash info relatived. That will introduce >&g

Re: [ovs-dev] [PATCH net-next 0/9] optimize openvswitch flow looking up

On Fri, Oct 4, 2019 at 1:09 AM William Tu wrote: > > Hi Tonghao, > > Thanks for the patch. > > > On 29 Sep 2019, at 19:09, xiangxia.m@gmail.com wrote: > > > > > From: Tonghao Zhang > > > > > > This series patch optimize openvswitch. &

Re: [ovs-dev] [ovs-dev v3] dpif-netdev: Allow to set max capacity of flow on netdev.

On Sat, Jan 11, 2020 at 12:44 AM Ilya Maximets wrote: > > On 10.01.2020 03:16, Tonghao Zhang wrote: > > On Fri, Jan 10, 2020 at 2:04 AM Ben Pfaff wrote: > >> > >> On Thu, Jan 09, 2020 at 04:14:10PM +0100, Ilya Maximets wrote: > >>> On 09.01.2020 08:36, x

Re: [ovs-dev] [PATCH] tc: handle packet mark of zero

On Mon, Jan 13, 2020 at 6:03 PM Simon Horman wrote: > > Hi, > > On Mon, Jan 13, 2020 at 05:28:04PM +0800, Tonghao Zhang wrote: > > On Fri, Jan 10, 2020 at 7:06 PM Simon Horman > > wrote: > > > > > > From: John Hurley > > > >

Re: [ovs-dev] [PATCH] tc: handle packet mark of zero

On Fri, Jan 10, 2020 at 7:06 PM Simon Horman wrote: > > From: John Hurley > > Openstack may set an skb mark of 0 in tunnel rules. This is considered to > be an unused/unset value. However, it prevents the rule from being > offloaded. > > Check if the key value of the skb mark is 0 when it is in

Re: [ovs-dev] OVS-DPDK public meeting

On Sat, Jan 11, 2020 at 12:37 AM Kevin Traynor wrote: > > Next meeting Jan 22nd 1700 UTC > (Ian will run meeting - may be cancelled if no agenda) > > January 8th minutes > > Attendees: David, Flavio, Ilya, Johann, Malvika, Aaron, Simon, Ian, Kevin. > > - OVS 2.13 Release > -- Feature Freeze is

Re: [ovs-dev] [PATCH RESEND ovs-dev] netdev-offload-tc: Add checking when assigning flow api

On Mon, Jan 20, 2020 at 4:59 PM Ilya Maximets wrote: > > On 19.01.2020 12:40, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > netdev_assign_flow_api will try to init the netdev, > > if success, the netdev will use the offload api. > > If we in

Re: [ovs-dev] [ovs-dev v3] dpif-netdev: Allow to set max capacity of flow on netdev.

On Thu, Jan 9, 2020 at 11:14 PM Ilya Maximets wrote: > > On 09.01.2020 08:36, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > For installing more than MAX_FLOWS (65536) flows to netdev datapath. > > Add the ovs-appctl subcommand "dpif-netdev/pmd

Re: [ovs-dev] [ovs-dev v3] dpif-netdev: Allow to set max capacity of flow on netdev.

On Fri, Jan 10, 2020 at 2:04 AM Ben Pfaff wrote: > > On Thu, Jan 09, 2020 at 04:14:10PM +0100, Ilya Maximets wrote: > > On 09.01.2020 08:36, xiangxia.m@gmail.com wrote: > > > From: Tonghao Zhang > > > > > > For installing more than MAX_FLOWS (655

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix using uninitialized execute hash.

On Sat, Jan 4, 2020 at 7:50 AM Ilya Maximets wrote: > > Most of callers doesn't initialize dpif_execute.hash leaving random > value from the stack. And this random value used later while encoding > netlink message and might produce unwanted kernel behavior. > > Fix that by fully initializing

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix using uninitialized upcall hash.

all->hash); > } > > error = upcall_receive(upcall, udpif->backer, >packet, > @@ -830,6 +831,7 @@ recv_upcalls(struct handler *handler) > upcall->key = dupcall->key; > upcall->key_len = dupcall->key_len; > upca

Re: [ovs-dev] [PATCH net-next v2] openvswitch: add TTL decrement action

Hi Matteo, Did you have plan to implement the TTL decrement action in userspace datapath(with dpdk), I am doing some research offloading about TTL decrement action, and may sent patch TTL decrement offload action, using dpdk rte_flow. On Fri, Dec 20, 2019 at 8:37 PM Matteo Croce wrote: > > On

Re: [ovs-dev] [PATCH net-next v2] openvswitch: add TTL decrement action

On Wed, Dec 25, 2019 at 7:16 AM bindiya Kurle wrote: > > Hi Tonghao, > Once this kernel patch is integrated . I will be submitting patch to ovs-dpdk > for implementing dec_ttl action on dpdk datapath. Good， thanks > Regards, > Bindiya > > On Tue, Dec 24, 2019 at 2:12 PM

Re: [ovs-dev] [PATCH] dpif-netdev: Allow to set max capacity of flow on netdev

On Wed, Jan 8, 2020 at 6:34 AM Ben Pfaff wrote: > > On Mon, Dec 23, 2019 at 07:17:34PM +0800, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > There may be too many flows (> MAX_FLOWS 65536) on > > dpif-netdev at same time. For this case, we s

Re: [ovs-dev] [PATCH ovs 2/2] dpif-netdev: Add meter cache for performance

On Sat, Mar 14, 2020 at 7:01 PM 0-day Robot wrote: > > Bleep bloop. Greetings Tonghao Zhang, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > build: &g

Re: [ovs-dev] [PATCH net-next v1 1/3] net: openvswitch: expand the meters number supported

On Wed, Apr 8, 2020 at 11:09 PM William Tu wrote: > > On Wed, Apr 01, 2020 at 06:50:09PM +0800, Tonghao Zhang wrote: > > On Tue, Mar 31, 2020 at 11:57 AM Pravin Shelar wrote: > > > > > > On Sun, Mar 29, 2020 at 5:35 PM Tonghao Zhang > > > wrote: > >

Re: [ovs-dev] [PATCH net-next v1 1/3] net: openvswitch: expand the meters number supported

On Wed, Apr 8, 2020 at 11:59 PM Tonghao Zhang wrote: > > On Wed, Apr 8, 2020 at 11:09 PM William Tu wrote: > > > > On Wed, Apr 01, 2020 at 06:50:09PM +0800, Tonghao Zhang wrote: > > > On Tue, Mar 31, 2020 at 11:57 AM Pravin Shelar wrote: > > > > > >

Re: [ovs-dev] [PATCH net-next v1 1/3] net: openvswitch: expand the meters number supported

On Fri, Apr 10, 2020 at 5:41 AM William Tu wrote: > > On Wed, Apr 08, 2020 at 11:59:25PM +0800, Tonghao Zhang wrote: > > On Wed, Apr 8, 2020 at 11:09 PM William Tu wrote: > > > > > > On Wed, Apr 01, 2020 at 06:50:09PM +0800, Tonghao Zhang wrote: > > > &g

Re: [ovs-dev] OvS DPDK crash when HPET timer enabled

On Mon, Apr 13, 2020 at 11:26 PM Ravi Kerur wrote: > > > > On Sun, Apr 12, 2020 at 5:05 AM Tonghao Zhang > wrote: >> >> On Sun, Apr 12, 2020 at 7:57 AM Ravi Kerur wrote: >> > >> > Hello OvS DPDK team, >> > >> > I am using

Re: [ovs-dev] [PATCH ovs] netdev-offload-tc: Use accurately function to check dl_type.

On Sat, Apr 11, 2020 at 11:48 PM William Tu wrote: > > On Fri, Apr 10, 2020 at 06:02:47PM +0800, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > When offloading the flows which matching the vlan feild, > > there is an error[1]. Then we can't offl

Re: [ovs-dev] OvS DPDK crash when HPET timer enabled

On Sun, Apr 12, 2020 at 7:57 AM Ravi Kerur wrote: > > Hello OvS DPDK team, > > I am using OvS 2.13.90 and DPDK 19.11 and wanted to use HPET timer instead > of invariant TSC. > > Enabled CONFIG_RTE_LIBEAL_USE_HPET=y in DPDK > > Kernel has > CONFIG_HPET_TIMER=y > CONFIG_HPET_EMULATE_RTC=y >

Re: [ovs-dev] [PATCH net-next v2 1/5] net: openvswitch: expand the meters supported number

On Mon, Apr 20, 2020 at 1:29 AM Pravin Shelar wrote: > > On Sat, Apr 18, 2020 at 10:25 AM wrote: > > > > From: Tonghao Zhang > > > > In kernel datapath of Open vSwitch, there are only 1024 > > buckets of meter in one dp. If installing more than 1024

Re: [ovs-dev] [PATCH net-next v2 2/5] net: openvswitch: set max limitation to meters

On Mon, Apr 20, 2020 at 1:31 AM Pravin Shelar wrote: > > On Sat, Apr 18, 2020 at 10:25 AM wrote: > > > > From: Tonghao Zhang > > > > Don't allow user to create meter unlimitedly, > > which may cause to consume a large amount of kernel memory. > > The

Re: [ovs-dev] [PATCH v2 1/2] dpif-netdev: Expand the meter capacity using cmap

t; > Cc: Ilya Maximets > > Subject: [ovs-dev] [PATCH v2 1/2] dpif-netdev: Expand the meter capacity > > using cmap > > > > From: Tonghao Zhang > > > > For now, ovs-vswitchd use the array of the dp_meter struct to store meter's > > data, and at most, th

Re: [ovs-dev] [PATCH ovs v1 0/2] Allow setting MAC on DPDK interfaces

On Sun, Mar 15, 2020 at 5:49 PM Noa Levy wrote: > > ping > > > -Original Message- > > From: Noa Ezra > > Sent: Thursday, March 5, 2020 4:15 PM > > To: ovs-dev@openvswitch.org > > Cc: i.maxim...@ovn.org; Ameer Mahagneh ; Noa > > Levy ; Roni Bar Yanai ; > > e...@labmailer.mlnx; Majd

Re: [ovs-dev] [PATCH ovs v1 0/2] Allow setting MAC on DPDK interfaces

On Sun, Mar 15, 2020 at 5:49 PM Noa Levy wrote: > > ping > > > -Original Message- > > From: Noa Ezra > > Sent: Thursday, March 5, 2020 4:15 PM > > To: ovs-dev@openvswitch.org > > Cc: i.maxim...@ovn.org; Ameer Mahagneh ; Noa > > Levy ; Roni Bar Yanai ; > > e...@labmailer.mlnx; Majd

Re: [ovs-dev] [PATCH 1/2] tun_metadata: Fix coredump caused by use-after-free bug

On Fri, Mar 27, 2020 at 3:58 AM Yifeng Sun wrote: > > Tun_metadata can be referened by flow and frozen_state at the same > time. When ovs-vswitchd handles TLV table mod message, the involved > tun_metadata gets freed. The call trace to free tun_metadata is > shown as below: > > ofproto_run > -

Re: [ovs-dev] [PATCH v2 1/2] dpif-netdev: Expand the meter capacity using cmap

On Tue, Mar 24, 2020 at 8:40 PM Tonghao Zhang wrote: > > On Tue, Mar 24, 2020 at 1:11 PM Ben Pfaff wrote: > > > > On Tue, Mar 24, 2020 at 09:25:41AM +0800, Tonghao Zhang wrote: > > > On Mon, Mar 16, 2020 at 12:06 PM Tonghao Zhang > > > wrote: > > &g

Re: [ovs-dev] [PATCH net-next v1 1/3] net: openvswitch: expand the meters number supported

On Tue, Mar 31, 2020 at 11:57 AM Pravin Shelar wrote: > > On Sun, Mar 29, 2020 at 5:35 PM Tonghao Zhang > wrote: > > > > On Mon, Mar 30, 2020 at 12:46 AM Pravin Shelar wrote: > > > > > > On Sat, Mar 28, 2020 at 8:46 AM wrote: > > > > >

Re: [ovs-dev] [PATCH net-next v1 1/3] net: openvswitch: expand the meters number supported

On Mon, Mar 30, 2020 at 12:46 AM Pravin Shelar wrote: > > On Sat, Mar 28, 2020 at 8:46 AM wrote: > > > > From: Tonghao Zhang > > > > In kernel datapath of Open vSwitch, there are only 1024 > > buckets of meter in one dp. If installing more than 1024

Re: [ovs-dev] [PATCH] net: openvswitch: use do_div() for 64-by-32 divisions:

On Sat, Apr 25, 2020 at 1:54 AM Geert Uytterhoeven wrote: > > Hi Toke, > > On Fri, Apr 24, 2020 at 6:45 PM Toke Høiland-Jørgensen > wrote: > > Geert Uytterhoeven writes: > > > On Fri, Apr 24, 2020 at 5:05 PM Eric Dumazet > > > wrote: > > >> On 4/24/20 5:10 AM, Geert Uytterhoeven wrote: > >

Re: [ovs-dev] [PATCH net-next v3 0/5] expand meter tables and fix bug

On Fri, Apr 24, 2020 at 3:49 AM David Miller wrote: > > From: David Miller > Date: Thu, 23 Apr 2020 12:45:29 -0700 (PDT) > > > From: xiangxia.m@gmail.com > > Date: Thu, 23 Apr 2020 01:08:55 +0800 > > > >> From: Tonghao Zhang > >> > >

Re: [ovs-dev] [PATCH ovs v2 0/4] expand the meter table and fix bug

On Sat, May 16, 2020 at 1:14 AM Ilya Maximets wrote: > > On 5/13/20 3:31 PM, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > The patch set expand or shrink the meter table when necessary. > > and other patches fix bug or improve codes. > > >

Re: [ovs-dev] [PATCH ovs v2 1/4] dpif-netdev: Expand the meters supported number

On Sat, May 16, 2020 at 1:09 AM Ilya Maximets wrote: > > On 5/13/20 3:31 PM, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > For now, ovs-vswitchd use the array of the dp_meter struct > > to store meter's data, and at most, there are only 65536 >

Re: [ovs-dev] [PATCH OVS 2/4] dpif-netdev: Add burst size to buckets

On Sat, May 9, 2020 at 11:26 PM William Tu wrote: > > On Sat, May 09, 2020 at 09:54:10AM +0800, Tonghao Zhang wrote: > > On Sat, May 9, 2020 at 7:23 AM William Tu wrote: > > > > > > On Thu, Apr 30, 2020 at 07:00:37PM +0800, xiangxia.m@gmail.com wrot

Re: [ovs-dev] [PATCH OVS 1/4] dpif-netdev: Expand the meters supported number

On Sun, May 10, 2020 at 12:19 AM William Tu wrote: > > On Thu, Apr 30, 2020 at 07:00:36PM +0800, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > For now, ovs-vswitchd use the array of the dp_meter struct > > to store meter's data, and at most, the

Re: [ovs-dev] [RFC v2 PATCH 4/4] bpf: Add reference XDP program implementation for netdev-offload-xdp

On Tue, Apr 21, 2020 at 10:48 PM Toshiaki Makita wrote: > > This adds a reference program, flowtable_afxdp.o, which can be used to > offload flows to XDP through netdev-offload-xdp. > The program will be compiled when using --enable-bpf switch. Hi Toshiaki Good! One question, did we test the

Re: [ovs-dev] [PATCH v2 1/2] dpif-netdev: Expand the meter capacity using cmap

On Mon, Mar 16, 2020 at 12:06 PM Tonghao Zhang wrote: > > On Mon, Mar 16, 2020 at 11:07 AM Yanqin Wei wrote: > > > > Hi Xiangxia, > > > > The meter id is allocated by id_pool, which can always return the lowest > > available id. > Yes, I

Re: [ovs-dev] [PATCH v2 1/2] dpif-netdev: Expand the meter capacity using cmap

On Tue, Mar 24, 2020 at 1:11 PM Ben Pfaff wrote: > > On Tue, Mar 24, 2020 at 09:25:41AM +0800, Tonghao Zhang wrote: > > On Mon, Mar 16, 2020 at 12:06 PM Tonghao Zhang > > wrote: > > > > > > On Mon, Mar 16, 2020 at 11:07 AM Yanqin Wei

Re: [ovs-dev] [PATCH OVS 3/4] dpif-netdev: Use the u32 instead of u64 for buckets

On Sat, May 9, 2020 at 7:12 AM William Tu wrote: > > On Thu, Apr 30, 2020 at 07:00:38PM +0800, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > When setting the meter rate to 4+Gbps, there is an overflow, the > > meters don't work as expected. >

Re: [ovs-dev] [PATCH OVS 2/4] dpif-netdev: Add burst size to buckets

On Sat, May 9, 2020 at 7:23 AM William Tu wrote: > > On Thu, Apr 30, 2020 at 07:00:37PM +0800, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > For now, the meter of the userspace datapath, don't include > > the bucket burst size to buckets. This pat

Re: [ovs-dev] [PATCH] datapath: Add hash info to upcall.

; Reviewed-by: Greg Rose > Signed-off-by: David S. Miller > > commit bd1903b7c4596ba6f7677d0dfefd05ba5876707d > Author: Tonghao Zhang > Date: Wed Nov 13 23:04:49 2019 +0800 > > net: openvswitch: add hash info to upcall > > When using the kernel

Re: [ovs-dev] [PATCH] netdev-offload-dpdk: Support offload of VLAN PUSH/POP actions

On Sun, May 24, 2020 at 3:38 PM Sriharsha Basavapatna via dev wrote: > > Parse VLAN PUSH/POP OVS datapath actions and add respective RTE actions. One question, if pop vlan in the hw, then process it in userspace datapath, the metadata of vlan should restore it. I guess pop_vlan/pop_vxlan are same

  1   2   3   >