[ovs-dev] [PATCH] system-traffic.at: Make nsh test more robust.

2019-07-17 Thread William Tu
The patch adds '-n' to tcpdump to avoid address coverting. Since '-U' is used to output to stdout, simply use 'cat' to search result. Use OVS_WAIT_UNTIL instead of sleep ,and also remove/add some newlines. Signed-off-by: William Tu --- tests/system-traffic.at | 89

[ovs-dev] [PATCHv17 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-17 Thread William Tu
/af_xdp.rst. Note that by default, this feature is not compiled in. Signed-off-by: William Tu --- v15: * address review feedback from Ilya https://patchwork.ozlabs.org/patch/1125476/ * skip TCP related test cases * reclaim all CONS_NUM_DESC at complete tx * add retries to kick_tx * increase

[ovs-dev] [PATCHv17 1/2] ovs-thread: Add pthread spin lock support.

2019-07-17 Thread William Tu
The patch adds the basic spin lock functions: ovs_spin_{lock, try_lock, unlock, init, destroy}. OSX does not support pthread spin lock, so make it linux only. Signed-off-by: William Tu --- configure.ac | 1 + include/openvswitch/thread.h | 24 lib/ovs

Re: [ovs-dev] [PATCHv16 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-17 Thread William Tu
On Wed, Jul 17, 2019 at 9:56 AM Ben Pfaff wrote: > > On Fri, Jul 12, 2019 at 04:50:56PM -0700, William Tu wrote: > > The patch introduces experimental AF_XDP support for OVS netdev. > > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > > type bui

Re: [ovs-dev] [PATCHv16 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-17 Thread William Tu
On Wed, Jul 17, 2019 at 8:54 AM Ilya Maximets wrote: > > On 17.07.2019 18:47, William Tu wrote: > > On Wed, Jul 17, 2019 at 8:41 AM Ilya Maximets > > wrote: > >> > >> On 13.07.2019 2:50, William Tu wrote: > >>> The patch introduces experime

Re: [ovs-dev] [PATCHv16 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-17 Thread William Tu
On Wed, Jul 17, 2019 at 8:41 AM Ilya Maximets wrote: > > On 13.07.2019 2:50, William Tu wrote: > > The patch introduces experimental AF_XDP support for OVS netdev. > > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > > type built upon the

Re: [ovs-dev] [PATCH] userspace: Enable non-bridge port as tunnel endpoint.

2019-07-16 Thread William Tu
On Tue, Jul 16, 2019 at 2:13 PM Ben Pfaff wrote: > > On Tue, Jul 16, 2019 at 02:59:55PM -0400, 0-day Robot wrote: > > checkpatch: > > WARNING: Unexpected sign-offs from developers who are not authors or > > co-authors or committers: William Tu > > Lines checke

Re: [ovs-dev] [PATCHv16 1/2] ovs-thread: Add pthread spin lock support.

2019-07-15 Thread William Tu
On Mon, Jul 15, 2019 at 11:54 AM Ben Pfaff wrote: > > On Mon, Jul 15, 2019 at 05:28:44PM +0300, Ilya Maximets wrote: > > On 13.07.2019 2:50, William Tu wrote: > > > The patch adds the basic spin lock functions: > > > ovs_spin_{lock, try_lock, unlock, init, destro

Re: [ovs-dev] [PATCH] userspace: Fix nsh test failures.

2019-07-15 Thread William Tu
On Mon, Jul 15, 2019 at 7:12 AM Ilya Maximets wrote: > > On 13.07.2019 17:25, William Tu wrote: > > When doing > > $ make check-kmod TESTSUITEFLAGS='-k nsh' > > > > every test passes, but when doing > > $ make check-system-userspace TESTSUITEFLAGS

Re: [ovs-dev] [PATCH] odp-util: Fix NSH mask parsing.

2019-07-15 Thread William Tu
mask' to make it be > like all other parsing functions. > > Additionally fixed missing comma in the 'format_nsh_key'. > > CC: Yi Yang > Fixes: f59cb331c481 ("nsh: rework NSH netlink keys and actions") > Signed-off-by: Ilya Maximets > --- LGTM, thanks for the fix.

[ovs-dev] [PATCH] userspace: Fix nsh test failures.

2019-07-13 Thread William Tu
after the tcpdump starts to capture packets. But I don't know why more sleep time makes the revalidator warning disappears. Signed-off-by: William Tu --- tests/system-traffic.at | 64 - 1 file changed, 32 insertions(+), 32 deletions(-) diff --git

[ovs-dev] [PATCHv16 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-12 Thread William Tu
/af_xdp.rst. Note that by default, this feature is not compiled in. Signed-off-by: William Tu --- v15: * address review feedback from Ilya https://patchwork.ozlabs.org/patch/1125476/ * skip TCP related test cases * reclaim all CONS_NUM_DESC at complete tx * add retries to kick_tx * increase

[ovs-dev] [PATCHv16 1/2] ovs-thread: Add pthread spin lock support.

2019-07-12 Thread William Tu
The patch adds the basic spin lock functions: ovs_spin_{lock, try_lock, unlock, init, destroy}. OSX does not support pthread spin lock, so make it linux only. Signed-off-by: William Tu --- include/openvswitch/thread.h | 22 ++ lib/ovs-thread.c | 31

Re: [ovs-dev] [PATCHv15 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-12 Thread William Tu
On Thu, Jul 11, 2019 at 6:42 AM Ilya Maximets wrote: > > On 09.07.2019 22:35, William Tu wrote: > > The patch introduces experimental AF_XDP support for OVS netdev. > > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > > type built upon the

Re: [ovs-dev] [PATCH 2/2] datapath: fix csum updates for MPLS actions

2019-07-09 Thread William Tu
; Signed-off-by: David S. Miller > > Fixes: ccf4378615e9 ("datapath: Add basic MPLS support to kernel") > Fixes: b51367aad315 ("datapath: update checksum in {push,pop}_mpls") > Cc: John Hurley > Signed-off-by: Greg Rose > --- LGTM Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/2] compat: ip6_gre: fix possible use-after-free in ip6erspan_rcv

2019-07-09 Thread William Tu
Miller > > Fixes: c387d8177f20 ("compat: Add ipv6 GRE and IPV6 Tunneling") > Cc: Lorenzo Bianconi > Signed-off-by: Greg Rose > --- Thanks for backporting this patch. Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCHv15 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-09 Thread William Tu
/af_xdp.rst. Note that by default, this feature is not compiled in. Signed-off-by: William Tu --- v14: * Mainly address issue reported by Ilya https://patchwork.ozlabs.org/patch/1118972/ when doing 'make check-afxdp' * Fix xdp frame headroom issue * Fix vlan test cases by disabling txvlan

[ovs-dev] [PATCHv15 1/2] ovs-thread: Add pthread spin lock support.

2019-07-09 Thread William Tu
The patch adds the basic spin lock functions: ovs_spin_{lock, try_lock, unlock, init, destroy}. OSX does not support pthread spin lock, so make it linux only. Signed-off-by: William Tu --- include/openvswitch/thread.h | 22 ++ lib/ovs-thread.c | 31

Re: [ovs-dev] [PATCHv14 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-08 Thread William Tu
On Mon, Jul 8, 2019 at 1:50 PM William Tu wrote: > > Hi Ilya, > > Thanks for all the feedback! > > On Fri, Jul 5, 2019 at 8:32 AM Ilya Maximets wrote: > > > > On 01.07.2019 19:08, William Tu wrote: > > > The patch introduces experimental AF_XDP support fo

Re: [ovs-dev] [PATCHv14 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-08 Thread William Tu
On Fri, Jul 5, 2019 at 10:48 AM Ilya Maximets wrote: > > Few more comments inline. > > On 01.07.2019 19:08, William Tu wrote: > > The patch introduces experimental AF_XDP support for OVS netdev. > > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux so

Re: [ovs-dev] [PATCHv14 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-08 Thread William Tu
Hi Ilya, Thanks for all the feedback! On Fri, Jul 5, 2019 at 8:32 AM Ilya Maximets wrote: > > On 01.07.2019 19:08, William Tu wrote: > > The patch introduces experimental AF_XDP support for OVS netdev. > > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux soc

Re: [ovs-dev] [PATCH 3/3] compat: Clean up tunnel_id_to_key

2019-07-03 Thread William Tu
On Fri, Jun 28, 2019 at 1:40 PM Greg Rose wrote: > > This function was just a duplicate of tunnel_id_to_key32 - I'm not sure > why it was ever needed but let's dump it now. > > Signed-off-by: Greg Rose > --- LGTM Acked-by: William Tu _

Re: [ovs-dev] [PATCH 1/3] compat: Remove duplicate metadata destination code

2019-07-03 Thread William Tu
adata.h. > > > > Signed-off-by: Greg Rose > > --- LGTM Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/3] compat: Clean up gre_calc_hlen

2019-07-03 Thread William Tu
f gre_calc_hlen and ip_gre_calc_hlen since the 3.10 kernel are > handled correctly. > > Signed-off-by: Greg Rose > --- Thanks for clearing this up. Acked-by: William Tu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCHv5] tunnel: Add layer 2 IPv6 GRE encapsulation support.

2019-07-03 Thread William Tu
On Tue, Jul 2, 2019 at 4:43 PM Gregory Rose wrote: > > > On 7/1/2019 12:45 PM, William Tu wrote: > > The patch adds ip6gre support. Tunnel type 'ip6gre' with packet_type= > > legacy_l2 is a layer 2 GRE tunnel over IPv6, carrying inner ethernet packets > > and encap with

Re: [ovs-dev] [PATCHv5] tunnel: Add layer 2 IPv6 GRE encapsulation support.

2019-07-01 Thread William Tu
On Mon, Jul 1, 2019 at 3:10 PM Gregory Rose wrote: > > > > On 7/1/2019 12:45 PM, William Tu wrote: > > The patch adds ip6gre support. Tunnel type 'ip6gre' with packet_type= > > legacy_l2 is a layer 2 GRE tunnel over IPv6, carrying inner ethernet packets > > and en

[ovs-dev] [PATCHv5] tunnel: Add layer 2 IPv6 GRE encapsulation support.

2019-07-01 Thread William Tu
: # make check-kernel TESTSUITEFLAGS='-k ip6gre' under kernel 5.2 and for userspace: # make check TESTSUITEFLAGS='-k ip6gre' Signed-off-by: William Tu --- v1-v2 - rebase to master v2-v3 - update documentation suggested by Eli v3-v4 - squash Eli's documentation v4-v5 - remove using

[ovs-dev] [PATCHv14 2/2] netdev-afxdp: add new netdev type for AF_XDP.

2019-07-01 Thread William Tu
/af_xdp.rst. Note that by default, this feature is not compiled in. Signed-off-by: William Tu --- v8-v9: - rebase to master 180bbbed3a3867d52 - Address review feedback from Ben, Ilya and Eelco, at: https://patchwork.ozlabs.org/patch/1097740/ - == From Ilya == - Optimize the reconfiguration logic

[ovs-dev] [PATCHv14 1/2] ovs-thread: Add pthread spin lock support.

2019-07-01 Thread William Tu
The patch adds the basic spin lock functions: ovs_spin_{lock, try_lock, unlock, init, destroy}. OSX does not support pthread spin lock, so make it linux only. Signed-off-by: William Tu --- include/openvswitch/thread.h | 22 ++ lib/ovs-thread.c | 31

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-28 Thread William Tu
> > > +int > > +netdev_afxdp_batch_send(struct netdev *netdev, int qid, > > +struct dp_packet_batch *batch, > > +bool concurrent_txq) > > +{ > > +struct netdev_linux *dev = netdev_linux_cast(netdev); > > +struct xsk_socket_info *xsk_info =

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-27 Thread William Tu
Hi Ilya, Thanks for the feedback. > > +static struct dp_packet_afxdp * > > +dp_packet_cast_afxdp(const struct dp_packet *d) > > +{ > > +ovs_assert(d->source == DPBUF_AFXDP); > > +return CONTAINER_OF(d, struct dp_packet_afxdp, packet); > > +} > > + > > +static inline void > >

Re: [ovs-dev] [PATCHv4] tunnel: Add layer 2 IPv6 GRE encapsulation support.

2019-06-27 Thread William Tu
On Thu, Jun 27, 2019 at 9:10 AM Gregory Rose wrote: > > > > On 6/27/2019 7:51 AM, Ben Pfaff wrote: > > On Wed, Jun 26, 2019 at 03:21:49PM -0700, Gregory Rose wrote: > >> On 6/26/2019 11:59 AM, Ben Pfaff wrote: > >>> On Wed, Jun 26, 2019 at 08:22:07AM -0700,

Re: [ovs-dev] [PATCHv4] tunnel: Add layer 2 IPv6 GRE encapsulation support.

2019-06-27 Thread William Tu
On Wed, Jun 26, 2019 at 11:31 PM Eli Britstein wrote: > > > On 6/27/2019 1:21 AM, Gregory Rose wrote: > > > > On 6/26/2019 11:59 AM, Ben Pfaff wrote: > >> On Wed, Jun 26, 2019 at 08:22:07AM -0700, William Tu wrote: > >>> The patch adds ip6gretap support.

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-26 Thread William Tu
On Fri, Jun 21, 2019 at 7:56 AM Ilya Maximets wrote: > > On 19.06.2019 22:51, William Tu wrote: > > The patch introduces experimental AF_XDP support for OVS netdev. > > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > > type built upon the

Re: [ovs-dev] [PATCH 0/1] netdev-vport: Make ip6gretap netdev type to use TC rules

2019-06-26 Thread William Tu
On Wed, Jun 26, 2019 at 2:07 AM Eli Britstein wrote: > > Enable TC datapath on ip6gretap interface. > It will work once https://patchwork.ozlabs.org/patch/1120457/ is merged. > I've sent v4 patch https://patchwork.ozlabs.org/patch/1122890/ William ___

[ovs-dev] [PATCHv4] tunnel: Add layer 2 IPv6 GRE encapsulation support.

2019-06-26 Thread William Tu
-kernel TESTSUITEFLAGS='-k ip6gretap' under kernel 5.2 and for userspace: # make check TESTSUITEFLAGS='-k ip6gretap' Signed-off-by: William Tu Signed-off-by: Eli Britstein Co-authored-by: Eli Britstein Tested-by: Greg Rose Reviewed-by: Greg Rose --- v1-v2 - rebase to master v2-v3 - update

[ovs-dev] [PATCHv2] tunnel: add ip6gretap support.

2019-06-26 Thread William Tu
ip6gretap' Signed-off-by: William Tu --- v1-v2: rebase to master --- Documentation/faq/configuration.rst | 12 +++ NEWS| 1 + datapath/linux/compat/ip6_gre.c | 2 +- lib/dpif-netlink-rtnl.c | 2 +- lib/dpif-netlink.c | 4 ++- lib

Re: [ovs-dev] [PATCH] ovs-thread: Add pthread spin lock support.

2019-06-26 Thread William Tu
On Wed, Jun 26, 2019 at 7:08 AM Ben Pfaff wrote: > > On Wed, Jun 26, 2019 at 10:37:49AM -0300, Flavio Leitner via dev wrote: > > > > Hi William, > > > > On Thu, Jun 20, 2019 at 11:00:56AM -0700, William Tu wrote: > > > The patch adds the basic spin lock fu

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-25 Thread William Tu
> 7. It's a known issue that tunneling is not working right now in > system-traffic > userspace tests. Could be workarounded by removing '--disable-system' from > OVS_TRAFFIC_VSWITCHD_START in tests/system-userspace-macros.at. I'm going to > prepare a patch for this issue in a near future. > I

[ovs-dev] [PATCH] vswitchd: Separate disable system and route.

2019-06-25 Thread William Tu
. As a consequence, hitting errors due to OVS userspace parses the IGMP packet but its datapaths do not, so odp_flow_key_to_flow() return ODP_FIT_TOO_LITTLE. commit c645550bb249 ("odp-util: Always report ODP_FIT_TOO_LITTLE for IGMP.") Fix it by filtering out the IGMP-related error message. Signed-off-by:

Re: [ovs-dev] [PATCHv3] tunnel: Add layer 2 IPv6 GRE encapsulation support.

2019-06-25 Thread William Tu
On Tue, Jun 25, 2019 at 12:03 PM Eli Britstein wrote: > > > On 6/25/2019 7:12 PM, William Tu wrote: > > On Sat, Jun 22, 2019 at 8:44 AM Eli Britstein wrote: > >> > >> On 6/21/2019 8:47 PM, William Tu wrote: > >>> The patch adds ip6gretap supp

Re: [ovs-dev] [PATCH v2] vswitchd: Always cleanup userspace datapath.

2019-06-25 Thread William Tu
eanup'. > > > > This change fixes OVS disappearing from the DPDK point of view > > (keeping HW NICs improperly configured, sudden closing of vhost-user > > connections) and will help with linux devices clearing with upcoming > > AF_XDP netdev support. > &

Re: [ovs-dev] [PATCH 1/1] ip6gretap documentation

2019-06-25 Thread William Tu
On Sat, Jun 22, 2019 at 8:42 AM Eli Britstein wrote: > > Signed-off-by: Eli Britstein > --- Acked-by: William Tu > vswitchd/vswitch.xml | 32 > 1 file changed, 20 insertions(+), 12 deletions(-) > > diff --git a/vswitchd/vswitch.xml b

Re: [ovs-dev] [PATCHv3] tunnel: Add layer 2 IPv6 GRE encapsulation support.

2019-06-25 Thread William Tu
On Sat, Jun 22, 2019 at 8:44 AM Eli Britstein wrote: > > > On 6/21/2019 8:47 PM, William Tu wrote: > > The patch adds ip6gretap support. Tunnel type 'ip6gretap' is a layer 2 GRE > > tunnel over IPv6, carrying inner ethernet packets and encap with GRE header >

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-22 Thread William Tu
Hi Ilya, Thanks for such a detailed review! I wasn't thinking about making all "make check-afxdp" test cases passed because there are some errors not related to XDP. But since you've done lots of investigation, let's fix all and make it passed. > Hi! > I finally managed to successfully run

Re: [ovs-dev] [PATCHv11] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-22 Thread William Tu
> The PVP script will not restart OVS, or reapply the config, or bring > down the link between the tests. > > Just to be sure, I re-ran it, and checked the logging, but nothing of > the above. That's too bad, thanks for re-ran it. > In addition, the same test without the VM does not show the

[ovs-dev] [PATCHv3] tunnel: Add layer 2 IPv6 GRE encapsulation support.

2019-06-21 Thread William Tu
-kernel TESTSUITEFLAGS='-k ip6gretap' under kernel 5.2 and for userspace: # make check TESTSUITEFLAGS='-k ip6gretap' Signed-off-by: William Tu Tested-by: Greg Rose Reviewed-by: Greg Rose --- v1-v2 - rebase to master v2-v3 - update documentation suggested by Eli --- --- Documentation/faq

Re: [ovs-dev] [PATCHv2] tunnel: add ip6gretap support.

2019-06-21 Thread William Tu
On Fri, Jun 21, 2019 at 10:00 AM Gregory Rose wrote: > > > On 6/20/2019 8:55 AM, William Tu wrote: > > The patch adds ip6gretap support. Tunnel type ip6gretap is a layer 2 GRE > > tunnel over IPv6, carrying inner ethernet packets and encap with GRE header > > with o

Re: [ovs-dev] [PATCHv2] tunnel: add ip6gretap support.

2019-06-21 Thread William Tu
On Thu, Jun 20, 2019 at 12:23 PM Eli Britstein wrote: > > > On 6/20/2019 9:19 PM, William Tu wrote: > >> I'll be working on clarifying the documentation. And we need to clarify > >> that we will not be supporting ip6gre because it > >> requires ARPHRD_IP6GRE.

Re: [ovs-dev] [PATCHv11] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-20 Thread William Tu
On Thu, Jun 20, 2019 at 1:26 AM Eelco Chaudron wrote: > > > > On 20 Jun 2019, at 4:15, William Tu wrote: > > >> The PVP test seems to work fine however after a while it stops > >> forwarding: > >> > >> $ ovs-ofctl dump-flows ovs_pvp_br0 >

Re: [ovs-dev] [PATCHv2] tunnel: add ip6gretap support.

2019-06-20 Thread William Tu
> I'll be working on clarifying the documentation. And we need to clarify > that we will not be supporting ip6gre because it > requires ARPHRD_IP6GRE. OVS only works with ARPHRD_ETHER so it can only > support ip6gretap. > > > > > Alternatively, we can maybe detect the options:remote_ip to be an

[ovs-dev] [PATCH] ovs-thread: Add pthread spin lock support.

2019-06-20 Thread William Tu
The patch adds the basic spin lock functions: ovs_spin_{lock, try_lock, unlock, init, destroy}. I have some use cases using af_xdp, patches will come later. Signed-off-by: William Tu --- include/openvswitch/thread.h | 18 ++ lib/ovs-thread.c | 23

Re: [ovs-dev] [PATCH] tunnel: add ip6gretap support.

2019-06-20 Thread William Tu
On Thu, Jun 20, 2019 at 9:12 AM 0-day Robot wrote: > > Bleep bloop. Greetings William Tu, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > git-am: >

[ovs-dev] [PATCHv2] tunnel: add ip6gretap support.

2019-06-20 Thread William Tu
ip6gretap' Signed-off-by: William Tu --- v1-v2: rebase to master --- Documentation/faq/configuration.rst | 12 +++ NEWS| 1 + datapath/linux/compat/ip6_gre.c | 2 +- lib/dpif-netlink-rtnl.c | 2 +- lib/dpif-netlink.c | 4 ++- lib

[ovs-dev] [PATCH] tunnel: add ip6gretap support.

2019-06-20 Thread William Tu
ip6gretap' Signed-off-by: William Tu --- Documentation/faq/configuration.rst | 12 +++ NEWS| 1 + datapath/linux/compat/ip6_gre.c | 2 +- lib/dpif-netlink-rtnl.c | 2 +- lib/dpif-netlink.c | 4 ++- lib/netdev-vport.c

Re: [ovs-dev] [PATCHv11] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-19 Thread William Tu
> The PVP test seems to work fine however after a while it stops > forwarding: > > $ ovs-ofctl dump-flows ovs_pvp_br0 > cookie=0x0, duration=8.510s, table=0, n_packets=1, n_bytes=1020, > in_port=eno1 actions=output:tapVM > cookie=0x0, duration=8.504s, table=0, n_packets=1, n_bytes=252, >

[ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-19 Thread William Tu
/af_xdp.rst. Note that by default, this feature is not compiled in. Signed-off-by: William Tu --- v1->v2: - add a list to maintain unused umem elements - remove copy from rx umem to ovs internal buffer - use hugetlb to reduce misses (not much difference) - use pmd mode netdev in OVS (huge performa

Re: [ovs-dev] [PATCHv12] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-19 Thread William Tu
> Thanks for a new version! > > There was patches on master branch not so long ago that changed the base > netdev structures and renamed some files, so this patch is not applicable > now and needs a rebase. > > Best regards, Ilya Maximets. Thanks Eelco and Ilya, I will rebase to master and send

[ovs-dev] [PATCHv12] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-18 Thread William Tu
/af_xdp.rst. Note that by default, this feature is not compiled in. Signed-off-by: William Tu --- v1->v2: - add a list to maintain unused umem elements - remove copy from rx umem to ovs internal buffer - use hugetlb to reduce misses (not much difference) - use pmd mode netdev in OVS (huge performa

Re: [ovs-dev] [PATCHv11] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-18 Thread William Tu
> The PVP test seems to work fine however after a while it stops > forwarding: > > $ ovs-ofctl dump-flows ovs_pvp_br0 > cookie=0x0, duration=8.510s, table=0, n_packets=1, n_bytes=1020, > in_port=eno1 actions=output:tapVM > cookie=0x0, duration=8.504s, table=0, n_packets=1, n_bytes=252, >

Re: [ovs-dev] [PATCHv11] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-18 Thread William Tu
> > I guess, this crash caused by trying to destroy unallocated queue. > > Following change could help: > --- > diff --git a/lib/netdev-afxdp.c b/lib/netdev-afxdp.c > index a6543e8f5..6e1431dce 100644 > --- a/lib/netdev-afxdp.c > +++ b/lib/netdev-afxdp.c > @@ -249,7 +249,7 @@

Re: [ovs-dev] [PATCHv11] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-18 Thread William Tu
> > I’m using an RHEL7 instance and use systemd to restart openvswitch > with “systemctl restart openvswitch”. > It uses ovs-ctl to stat/stop, see here for some details: > > https://github.com/openvswitch/ovs/blob/master/rhel/usr_lib_systemd_system_ovs-vswitchd.service.in > > Thanks Eelco, I can

Re: [ovs-dev] [PATCHv11] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-17 Thread William Tu
On Mon, Jun 17, 2019 at 11:23 AM William Tu wrote: > > Hi Eelco, > > On Mon, Jun 17, 2019 at 3:12 AM Eelco Chaudron wrote: > > > > Hi William, > > > > See below parts of an offline email discussion I had with Magnus before, > > and some research I did

Re: [ovs-dev] [PATCHv11] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-17 Thread William Tu
Hi Eelco, On Mon, Jun 17, 2019 at 3:12 AM Eelco Chaudron wrote: > > Hi William, > > See below parts of an offline email discussion I had with Magnus before, > and some research I did in the end, which explains that by design you > might not get all the descriptors ready. I think it's different

Re: [ovs-dev] [PATCHv11] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-15 Thread William Tu
se(>umem->cq, tx_done); +xsk->outstanding_tx -= tx_done; +} } int On Thu, Jun 13, 2019 at 12:17 AM Eelco Chaudron wrote: > > On 13 Jun 2019, at 2:37, William Tu wrote: > > Hi Eelco, > > #0 0x7fbc6a78193f in raise () from /lib64/libc.so.6 > #1 0x000

Re: [ovs-dev] [PATCHv11] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-12 Thread William Tu
Hi Eelco, > > >>> #0 0x7fbc6a78193f in raise () from /lib64/libc.so.6 > > >>> #1 0x7fbc6a76bc95 in abort () from /lib64/libc.so.6 > > >>> #2 0x004ed1a1 in __umem_elem_push_n (addrs=0x7fbc40f2ec50, > > >>> n=32, umemp=0x24cc790) at lib/xdpsock.c:32 > > >>> #3 umem_elem_push_n

Re: [ovs-dev] [PATCHv11] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-12 Thread William Tu
g one port as rx and the other as tx, and after a couple seconds I can see the crash. Let me compare with v8 to see what happen. William > > Cheers, > > Eelco > > On 11 Jun 2019, at 19:47, William Tu wrote: > > > Hi Eelco, > > > > I tested using ixgbe driver but s

Re: [ovs-dev] AF_XDP with QoS support question

2019-06-10 Thread William Tu
Hi Jakub, Thanks for your feedback. On Sat, Jun 8, 2019 at 2:19 PM Jakub Kicinski wrote: > > On Fri, 7 Jun 2019 19:55:34 -0700, William Tu wrote: > > Hi, > > > > When using AF_XDP, the TC qdisc layer is by-passed and packets go to > > userspace directly. One p

Re: [ovs-dev] [PATCHv11] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-07 Thread William Tu
> > > + ethtool -L enp2s0 combined 1 > > > + ovs-vsctl set Open_vSwitch . other_config:pmd-cpu-mask=0x10 > > > + ovs-vsctl add-port br0 enp2s0 -- set interface enp2s0 type="afxdp" > > > \ > > > +options:n_rxq=1 options:xdpmode=drv \ > > > +other_config:pmd-rxq-affinity="0:4" another

[ovs-dev] AF_XDP with QoS support question

2019-06-07 Thread William Tu
Hi, When using AF_XDP, the TC qdisc layer is by-passed and packets go to userspace directly. One problem is that there is no QoS support when using AF_XDP. For egress shaping, I'm thinking about using tc-mqprio, which has hardware offload support. And for OVS, we can add tc-mqprio support. For

Re: [ovs-dev] [PATCHv11] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-07 Thread William Tu
terface > eno1 new configuration > > However when configuring this after startup it’s fine, but trying to > restart OVS with this configuration results in a system core… > > > > > On 5 Jun 2019, at 22:47, William Tu wrote: > > > The patch introduces experimental AF_XDP

[ovs-dev] [PATCHv11] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-05 Thread William Tu
/af_xdp.rst. Note that by default, this feature is not compiled in. Signed-off-by: William Tu --- v1->v2: - add a list to maintain unused umem elements - remove copy from rx umem to ovs internal buffer - use hugetlb to reduce misses (not much difference) - use pmd mode netdev in OVS (huge performa

Re: [ovs-dev] [PATCHv10] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-02 Thread William Tu
Hi Ilya, Thanks for your review. On Thu, May 30, 2019 at 8:57 AM Ilya Maximets wrote: > > On 28.05.2019 22:01, William Tu wrote: > > The patch introduces experimental AF_XDP support for OVS netdev. > > diff --git a/lib/dpif-netdev-perf.h b/lib/dpif-netdev-perf.h >

Re: [ovs-dev] [PATCH RFC] netdev-dpdk: add af_xdp support.

2019-05-31 Thread William Tu
On Fri, May 31, 2019 at 8:58 AM Ilya Maximets wrote: > > On 31.05.2019 1:08, William Tu wrote: > > Hi Ilya, > > > > Thanks for the comments. > > > > On Thu, May 30, 2019 at 12:47 AM Ilya Maximets > > wrote: > >> > >> On 29.05.2019 20:

Re: [ovs-dev] [PATCH RFC] netdev-dpdk: add af_xdp support.

2019-05-30 Thread William Tu
Hi Ilya, Thanks for the comments. On Thu, May 30, 2019 at 12:47 AM Ilya Maximets wrote: > > On 29.05.2019 20:57, William Tu wrote: > > On Wed, May 29, 2019 at 10:51 AM William Tu wrote: > >> > > Thanks for the logs. It looks like a bug in DPDK. > Does rte_eal_

Re: [ovs-dev] [PATCH RFC] netdev-dpdk: add af_xdp support.

2019-05-29 Thread William Tu
On Wed, May 29, 2019 at 10:51 AM William Tu wrote: > > Hi Ilya, > > Thanks for your feedback. > > On Wed, May 29, 2019 at 6:15 AM Ilya Maximets wrote: > > > > On 28.05.2019 23:12, William Tu wrote: > > > The patch adds support for using DPDK's A

Re: [ovs-dev] [PATCH RFC] netdev-dpdk: add af_xdp support.

2019-05-29 Thread William Tu
Hi Ilya, Thanks for your feedback. On Wed, May 29, 2019 at 6:15 AM Ilya Maximets wrote: > > On 28.05.2019 23:12, William Tu wrote: > > The patch adds support for using DPDK's AF_XDP PMD. > > Base on DPDK 19.08-rc0: > > commit c6a53a6bcd0ae52afe0a6d58b059af577c940

[ovs-dev] [PATCH RFC] netdev-dpdk: add af_xdp support.

2019-05-28 Thread William Tu
ce loopback shows around 7Mpps with 64B pkt. $ ovs-ofctl add-flow br0 "in_port=afxdp-p0, \ actions=set_field:14->in_port,set_field:a0:36:9f:33:b1:40->dl_src,afxdp-p0" Note: I have to set e_RTE_METER_GREEN to 0 to pass compile. Signed-off-by: William Tu --- lib/netdev-dpdk.c

[ovs-dev] [PATCHv10] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-28 Thread William Tu
/af_xdp.rst. Note that by default, this feature is not compiled in. Signed-off-by: William Tu --- v1->v2: - add a list to maintain unused umem elements - remove copy from rx umem to ovs internal buffer - use hugetlb to reduce misses (not much difference) - use pmd mode netdev in OVS (huge performa

Re: [ovs-dev] [PATCHv9] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-27 Thread William Tu
n this path) ./configure --enable-afxdp --with-dpdk= Regards, William > Best Regards, > Wei Yanqin > > -Original Message- > From: ovs-dev-boun...@openvswitch.org On > Behalf Of William Tu > Sent: Saturday, May 25, 2019 4:37 AM > To: Ben Pfaff > Cc: ; Ilya Maximets

Re: [ovs-dev] [PATCHv9] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-24 Thread William Tu
On Fri, May 24, 2019 at 11:32 AM Ben Pfaff wrote: > > On Fri, May 24, 2019 at 11:03:33AM -0700, William Tu wrote: > > The patch introduces experimental AF_XDP support for OVS netdev. > > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > >

[ovs-dev] [PATCHv9] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-24 Thread William Tu
/af_xdp.rst. Note that by default, this feature is not compiled in. Signed-off-by: William Tu --- v1->v2: - add a list to maintain unused umem elements - remove copy from rx umem to ovs internal buffer - use hugetlb to reduce misses (not much difference) - use pmd mode netdev in OVS (huge performa

Re: [ovs-dev] [PATCHv8] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-20 Thread William Tu
On Mon, May 20, 2019 at 3:58 PM Ben Pfaff wrote: > > On Mon, May 20, 2019 at 03:57:21PM -0700, Ben Pfaff wrote: > > On Fri, May 17, 2019 at 12:23:35PM +0200, Eelco Chaudron wrote: > > > - When I restart or stop OVS (using the systemctl interface as found in > > > RHEL) it does not clean up the

Re: [ovs-dev] [PATCHv8] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-20 Thread William Tu
On Mon, May 20, 2019 at 3:38 AM Eelco Chaudron wrote: > > > > On 17 May 2019, at 14:39, Ilya Maximets wrote: > > > Hi. > > Just a few comments to the issues you're listed. > > > > Best regards, Ilya Maximets. > > > > On 17.05.2019 13:23, Eelco Chaudron wrote: > >> Hi William, > >> > >> First a

Re: [ovs-dev] [PATCHv8] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-17 Thread William Tu
Hi Eelco, Thanks for all the feedbacks. There are some issues in driver, some in libbpf, and some in my implementation. I will work on it ASAP. On Fri, May 17, 2019 at 3:23 AM Eelco Chaudron wrote: > > Hi William, > > First a list of issues I found during some basic testing... > > - When I

Re: [ovs-dev] [PATCHv8] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-15 Thread William Tu
Hi Ilya, Thanks for your feedback. On Mon, May 13, 2019 at 10:48 AM Ilya Maximets wrote: > > On 10.05.2019 2:54, William Tu wrote: > > The patch introduces experimental AF_XDP support for OVS netdev. > > AF_XDP, Address Family of the eXpress Data Path, is a new Linux socket t

Re: [ovs-dev] [PATCHv8] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-15 Thread William Tu
> > + OVS AF_XDP netdev is using the userspace datapath, the same datapath > > + as used by OVS-DPDK. So it requires --disable-system for ovs-vswitchd > > + and datapath_type=netdev when adding a new bridge. > > I don't think that '--disable-system' is needed. It doesn't affect anything. >

[ovs-dev] [PATCHv8] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-09 Thread William Tu
/af_xdp.rst. Note that by default, this is not compiled in. Signed-off-by: William Tu --- v1->v2: - add a list to maintain unused umem elements - remove copy from rx umem to ovs internal buffer - use hugetlb to reduce misses (not much difference) - use pmd mode netdev in OVS (huge performance impr

Re: [ovs-dev] [PATCHv7] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-08 Thread William Tu
Hi Ilya, Thanks for your review. I will fix them in my next version. On Mon, May 6, 2019 at 5:37 AM Ilya Maximets wrote: > > Hi. Thanks for a new version. > > Quick review inline. > > Best regards, Ilya Maximets. > > On 03.05.2019 22:02, William Tu wrote: > > The

[ovs-dev] [PATCHv7] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-03 Thread William Tu
/af_xdp.rst Signed-off-by: William Tu --- v1->v2: - add a list to maintain unused umem elements - remove copy from rx umem to ovs internal buffer - use hugetlb to reduce misses (not much difference) - use pmd mode netdev in OVS (huge performance improve) - remove malloc dp_packet, instead put dp_pac

Re: [ovs-dev] [ovs-dev, PATCHv6] netdev-afxdp: add new netdev type for AF_XDP.

2019-04-30 Thread William Tu
Thanks Ben and Eelco On Tue, Apr 30, 2019 at 9:18 AM Eelco Chaudron wrote: > > > On 30 Apr 2019, at 18:10, Ben Pfaff wrote: > > > On 25.04.2019 2:47, William Tu wrote: > >> +#define unlikely OVS_UNLIKELY > >> +#define likely OVS_LIKELY > >> +#define

Re: [ovs-dev] [ovs-dev, PATCHv6] netdev-afxdp: add new netdev type for AF_XDP.

2019-04-27 Thread William Tu
On Thu, Apr 25, 2019 at 8:09 AM Ilya Maximets wrote: > Hi. > > This is not a full review. Just a bunch of thoughts. > > See inline. > > Best regards, Ilya Maximets. > > On 25.04.2019 2:47, William Tu wrote: > > The patch introduces experimental AF_XDP support fo

Re: [ovs-dev] [ovs-dev, PATCHv6] netdev-afxdp: add new netdev type for AF_XDP.

2019-04-26 Thread William Tu
On Fri, Apr 26, 2019 at 2:46 AM Ilya Maximets wrote: > On 25.04.2019 2:47, William Tu wrote: > > diff --git a/lib/netdev.c b/lib/netdev.c > > index 7d7ecf6f0946..c30016b34033 100644 > > --- a/lib/netdev.c > > +++ b/lib/netdev.c > > @@ -145,6

Re: [ovs-dev] [ovs-dev, PATCHv6] netdev-afxdp: add new netdev type for AF_XDP.

2019-04-25 Thread William Tu
egards, Ilya Maximets. > > On 25.04.2019 2:47, William Tu wrote: > > The patch introduces experimental AF_XDP support for OVS netdev. > > AF_XDP is a new address family working together with eBPF/XDP. > > A socket with AF_XDP family can receive and send raw packets > > from an eBPF/

[ovs-dev] [PATCHv6] netdev-afxdp: add new netdev type for AF_XDP.

2019-04-24 Thread William Tu
Documentation/intro/install/afxdp.rst Signed-off-by: William Tu Signed-off-by: Yi-Hung Wei Co-authored-by: Yi-Hung Wei --- v1->v2: - add a list to maintain unused umem elements - remove copy from rx umem to ovs internal buffer - use hugetlb to reduce misses (not much difference) - use pmd mode net

Re: [ovs-dev] [PATCH v5] netdev-afxdp: add new netdev type for AF_XDP.

2019-04-22 Thread William Tu
Hi Ben, Thanks for the feedback. On Mon, Apr 22, 2019 at 10:57 AM Ben Pfaff wrote: > On Fri, Apr 19, 2019 at 01:22:14PM -0700, William Tu wrote: > > The patch introduces experimental AF_XDP support for OVS netdev. > > AF_XDP is a new address family working together with eBPF/XD

[ovs-dev] [PATCHv3] dpif-netdev: fix meter at high packet rate.

2019-04-19 Thread William Tu
divides the delta by 1000, in order to convert to msec granularity. The patch fixes it updating the time when across millisecond boundary. Fixes: 05f9e707e194 ("dpif-netdev: Use microsecond granularity.") Cc: Ilya Maximets Cc: Yi-Hung Wei Signed-off-by: William Tu --- lib/dpif-ne

Re: [ovs-dev] [PATCHv2] dpif-netdev: fix meter at high packet rate.

2019-04-19 Thread William Tu
On Fri, Apr 19, 2019 at 3:18 PM Yi-Hung Wei wrote: > On Fri, Apr 19, 2019 at 2:04 PM William Tu wrote: > > > > When testing packet rate around 1Mpps with meter enabled, the frequency > > of hitting meter action becomes much higher, around 30us each time. > > As a resu

[ovs-dev] [PATCHv2] dpif-netdev: fix meter at high packet rate.

2019-04-19 Thread William Tu
divides the delta by 1000, in order to convert to msec granularity. The patch fixes it updating the time when across millisecond boundary. Fixes: 05f9e707e194 ("dpif-netdev: Use microsecond granularity.") Cc: Ilya Maximets Cc: Yi-Hung Wei Signed-off-by: William Tu --- lib/dpif-ne

[ovs-dev] [PATCH v5] netdev-afxdp: add new netdev type for AF_XDP.

2019-04-19 Thread William Tu
Documentation/intro/install/afxdp.rst Signed-off-by: William Tu Co-authored-by: Yi-Hung Wei Cc: Tim Rozet Cc: Eelco Chaudron --- Documentation/automake.mk | 1 + Documentation/index.rst | 1 + Documentation/intro/install/afxdp.rst | 299 +++ Documentation/intro

<    1   2   3   4   5   6   7   >