btw, remember to add "." at the end of the commit title.
so
"dpcls: enable cpu feature detection."
On Wed, Jun 10, 2020 at 3:47 AM Harry van Haaren
wrote:
>
> This commit implements a method to retrieve the CPU ISA capabilities.
> These ISA capabilities can be used in OVS to select a function
> i
On Wed, Jun 10, 2020 at 3:47 AM Harry van Haaren
wrote:
>
> This commit adds an AVX-512 dpcls lookup implementation.
> It uses the AVX-512 SIMD ISA to perform multiple miniflow
> operations in parallel.
>
> To run this implementation, the "avx512f" and "bmi2" ISAs are
> required. These ISA checks
On Wed, Jun 10, 2020 at 3:47 AM Harry van Haaren
wrote:
>
> This commit changes the way the core lib/* code is built.
> Before this commit, the lib/libopenvswitch_la target contains
> all the code, and is directly linked against by executable targets
> like ovs-vswitchd, ovsdb, tests etc.
>
> This
On Wed, Jun 10, 2020 at 3:47 AM Harry van Haaren
wrote:
>
> This commit adds a section to the dpdk/bridge.rst netdev documentation,
> detailing the added DPCLS functionality. The newely added commands are
typo: newly
> documented, and sample output is provided.
>
> Signed-off-by: Harry van Haaren
On Mon, Jun 8, 2020 at 7:01 AM Ilya Maximets wrote:
>
> On 5/14/20 4:11 PM, William Tu wrote:
> > The 'dpctl/dump-flows -m' only shows the number of 1-bit in the
> > miniflow map, the patch outputs additional miniflow bits after it.
> > The format will be
On Fri, May 29, 2020 at 2:39 AM wrote:
>
> From: Numan Siddique
>
> Signed-off-by: Numan Siddique
> ---
Acked-by: William Tu
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, May 29, 2020 at 4:47 AM Van Haaren, Harry
wrote:
>
> > -Original Message-
> > From: William Tu
> > Sent: Friday, May 29, 2020 2:19 AM
> > To: Van Haaren, Harry
> > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org
> > Subject: Re: [ovs-dev]
On Wed, May 27, 2020 at 12:21:43PM +, Van Haaren, Harry wrote:
> > -Original Message-
> > From: dev On Behalf Of Van Haaren, Harry
> > Sent: Tuesday, May 26, 2020 3:52 PM
> > To: William Tu
> > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org
> >
low match, the search for the flow with
LGTM above.
Acked-by: William Tu
But the blow is unrelated.
> diff --git a/manpages.mk b/manpages.mk
> index dc201484c637..54a3a82ad963 100644
> --- a/manpages.mk
> +++ b/manpages.mk
> @@ -104,7 +104,6 @@ utilities/bugtool/ovs-bugtool.8: \
>
On Mon, May 25, 2020 at 10:50 AM Ilya Maximets wrote:
>
> On 5/25/20 7:01 PM, Ilya Maximets wrote:
> > On 5/24/20 7:59 PM, William Tu wrote:
> >> On Thu, May 21, 2020 at 02:54:03PM -0700, Greg Rose wrote:
> >>> A patch backported to the Linux stable 4.14 tre
On Thu, May 21, 2020 at 02:54:03PM -0700, Greg Rose wrote:
> A patch backported to the Linux stable 4.14 tree and present in the
> latest stable 4.14.181 kernel breaks ipv6_stub usage.
>
> The commit is
> 8ab8786f78c3 ("net ipv6_stub: use ip6_dst_lookup_flow instead of
> ip6_dst_lookup").
>
> Cr
On Thu, May 21, 2020 at 6:04 AM Van Haaren, Harry
wrote:
>
> > -Original Message-
> > From: William Tu
> > Sent: Wednesday, May 20, 2020 4:15 PM
> > To: Van Haaren, Harry
> > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org
> > Subject: Re: [o
> > ovs-vsctl -- add-br br0 -- set Bridge br0 datapath_type=netdev
> > ovs-vsctl set Open_vSwitch . other_config:pmd-cpu-mask=0x3
> > ovs-vsctl --no-wait set Open_vSwitch . other_config:dpdk-init=true
> > ovs-ofctl add-flow br0 'actions=drop'
> > ovs-appctl dpif-netdev/subtable-lookup-set avx512_ga
On Sat, May 16, 2020 at 7:43 AM Toshiaki Makita
wrote:
>
> Hi William,
>
> On 2020/05/08 0:08, Toshiaki Makita wrote:
> > On 2020/05/05 23:29, William Tu wrote:
> >> On Tue, Apr 21, 2020 at 11:47:00PM +0900, Toshiaki Makita wrote:
> >>> This patch adds an XD
On Tue, May 19, 2020 at 09:33:05AM -0700, Gregory Rose wrote:
>
> On 5/14/2020 7:02 AM, William Tu wrote:
> >This patch adds 'ovs-appctl dpctl/dump-flows -m' to bugtool,
> >the output will include wildcarded fields and the miniflow bits,
> >such as 'dp-ex
On Mon, May 18, 2020 at 02:14:36PM -0700, Yifeng Sun wrote:
> Thanks William.
>
> Reviewed-by: Yifeng Sun
>
Thanks, applied to master.
William
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, May 19, 2020 at 04:00:07PM -0700, Han Zhou wrote:
> On Tue, May 19, 2020 at 3:01 PM Greg Rose wrote:
> >
> > The documentation matrix for OVS branches and which kernels they support
> > is out of date. Update it to show that since 2.10 the lowest kernel
> > that we test and support is Lin
> >0x561040e9 <+313>: kmovb %eax,%k4
> >0x561040ed <+317>: vpsrlq $0x4,%zmm0,%zmm2
> >0x561040f4 <+324>: vpandd %zmm3,%zmm0,%zmm0
> >0x561040fa <+330>: vpandd %zmm2,%zmm3,%zmm2
> >0x56104100 <+336>: vpshufb %zmm0,%zmm4,%zmm0
>
Hi Harry,
Thanks for your feedback!
> > > > On Wed, May 06, 2020 at 02:06:09PM +0100, Harry van Haaren wrote:
> > > > > This commit adds an AVX-512 dpcls lookup implementation.
> > > > > It uses the AVX-512 SIMD ISA to perform multiple miniflow
> > > > > operations in parallel.
>
>
>
> > Hi Harr
On Wed, May 20, 2020 at 3:35 AM Federico Iezzi wrote:
>
>
>
>
>
> On Wed, 20 May 2020 at 12:20, Van Haaren, Harry
> wrote:
>>
>> > -----Original Message-
>> > From: William Tu
>> > Sent: Wednesday, May 20, 2020 1:12 AM
>> > T
On Mon, May 18, 2020 at 9:12 AM Van Haaren, Harry
wrote:
>
> > -Original Message-
> > From: William Tu
> > Sent: Monday, May 18, 2020 3:58 PM
> > To: Van Haaren, Harry
> > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org
> > Subject: Re: [ovs-dev]
On Wed, May 06, 2020 at 02:06:09PM +0100, Harry van Haaren wrote:
> This commit adds an AVX-512 dpcls lookup implementation.
> It uses the AVX-512 SIMD ISA to perform multiple miniflow
> operations in parallel.
>
> To run this implementation, the "avx512f" and "bmi2" ISAs are
> required. These ISA
On Mon, May 18, 2020 at 4:34 AM Van Haaren, Harry
wrote:
>
> > -Original Message-
> > From: William Tu
> > Sent: Saturday, May 16, 2020 5:01 AM
> > To: Van Haaren, Harry
> > Cc: ovs-dev ; Ilya Maximets
> > Subject: Re: [ovs-dev] [PATCH v2 0/5] DPC
On Mon, May 18, 2020 at 4:48 AM Rohit kamble wrote:
>
> Hi All,
>
> Do we have GTP-U(GPRS Tunneling Protocol) support in OVS ?
> Current I am using lastest OVS version(v-2.12.0), I am not able to see
> GTP-U support.
> Is there any plan to support GTP in a future releases ?
>
Hi Rohit,
Yes, howe
Hi Harry,
Thanks for the patch, I learn a lot from them.
On Wed, May 6, 2020 at 6:05 AM Harry van Haaren
wrote:
>
> This patchset implements the changes as proposed during the
> OVS Conf '19, in the talk "Next steps for SW Datapath".
> Youtube link: https://youtu.be/x0bOpojnpmU
>
> The talk rais
references null datum.values.
ovsdb_idl_txn_write_clone(&row->header_, &ovsrec_open_vswitch_col
}
And with the following calls:
ovsdb_idl_txn_write_clone
ovsdb_idl_txn_write__
6. deref_parm_in_call: Function ovsdb_datum_destroy dereferences
datum->values
ovsdb_datum_destroy
On Thu, May 14, 2020 at 10:21:23AM -0700, Yi-Hung Wei wrote:
> On Thu, May 14, 2020 at 8:37 AM William Tu wrote:
> >
> > On Wed, May 13, 2020 at 01:11:17PM -0700, Yi-Hung Wei wrote:
> > > From man ovs-fields(7), the conntrack origin tuple fields
> > > ct_nw_src/ds
On Tue, May 12, 2020 at 04:31:58PM -0700, Yifeng Sun wrote:
> LGTM, thanks.
>
> Reviewed-by: Yifeng Sun
>
>
Applied, thanks.
William
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, May 13, 2020 at 01:11:17PM -0700, Yi-Hung Wei wrote:
> From man ovs-fields(7), the conntrack origin tuple fields
> ct_nw_src/dst, ct_ipv6_src/dst, and ct_tp_src/dst are supposed
> to be bitwise maskable, but they are not. This patch enables
> those fields to be maskable, and adds a regress
On Wed, May 13, 2020 at 09:31:31PM +0800, xiangxia.m@gmail.com wrote:
> From: Tonghao Zhang
>
> The patch set expand or shrink the meter table when necessary.
> and other patches fix bug or improve codes.
>
> Tonghao Zhang (4):
> dpif-netdev: Expand the meters supported number
> dpif-net
you have some case where you
keep seeing the flow_limit_hit frequently?
Acked-by: William Tu
> ofproto/ofproto-dpif-upcall.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
> index 5e08ef10d..a76532ec7 100644
&g
On Thu, May 14, 2020 at 01:42:21PM +0200, Ilya Maximets wrote:
> On 3/24/20 11:10 PM, William Tu wrote:
> > This patch enables TSO support for non-DPDK use cases, and
> > also add check-system-tso testsuite. Before TSO, we have to
> > disable checksum offload, allowing the ke
iflow_bits(4:0x30c0,1:0x400)
By searching the unique miniflow bits, we know the number of subtables,
and for earch subtables, the fields it matches on.
Cc: Emma Finn
Cc: Ian Stokes
Signed-off-by: William Tu
---
lib/dpif-netdev.c | 5 +++--
1 file changed, 3 insertions(+), 2
This patch adds 'ovs-appctl dpctl/dump-flows -m' to bugtool,
the output will include wildcarded fields and the miniflow bits,
such as 'dp-extra-info:miniflow_bits(4,1)'.
Cc: Emma Finn
Signed-off-by: William Tu
---
utilities/bugtool/plugins/network-status/openvswitch.xml |
On Mon, May 11, 2020 at 7:53 AM Toshiaki Makita
wrote:
>
> On 2020/05/09 0:05, William Tu wrote:
> > On Thu, May 7, 2020 at 7:56 AM Toshiaki Makita
> > wrote:
> >>
> >> On 2020/05/06 0:18, William Tu wrote:
> >>> On Tue, May 05, 2020 at 11:43:58AM
On Tue, May 12, 2020 at 8:44 AM William Tu wrote:
>
> Thanks for taking a look.
>
> On Tue, May 12, 2020 at 8:41 AM Ilya Maximets wrote:
> >
> > On 5/12/20 5:22 PM, William Tu wrote:
> > > When running fuzzer locally by doing
> > > $ ./configure CC=clan
On Mon, Apr 27, 2020 at 8:54 AM William Tu wrote:
>
> On Tue, Mar 24, 2020 at 3:11 PM William Tu wrote:
> >
> > This patch enables TSO support for non-DPDK use cases, and
> > also add check-system-tso testsuite. Before TSO, we have to
> > disable checksum o
Thanks for taking a look.
On Tue, May 12, 2020 at 8:41 AM Ilya Maximets wrote:
>
> On 5/12/20 5:22 PM, William Tu wrote:
> > When running fuzzer locally by doing
> > $ ./configure CC=clang CFLAGS="-g -O2 -fsanitize=fuzzer-no-link -Werror"
>
> Hmm... Why pass
On Sat, May 9, 2020 at 11:02 AM Yifeng Sun wrote:
>
> Thanks William, this patch looks good to me.
> Maybe code will be a little neater with the fixes below:
>
> @@ -1017,6 +1017,9 @@ static void
> free_data(enum ovsdb_atomic_type type,
>union ovsdb_atom *atoms, size_t n_atoms)
> {
>
Clang reports:
tests/oss-fuzz/miniflow_target.c:209:26: error: suggest braces around \
initialization of subobject
[-Werror,-Wmissing-braces]
struct flow flow2 = {0};
Fix it by using memset.
Cc: Bhargava Shastry
Cc: Yifeng Sun
Signed-off-by: William Tu
---
tests/oss-fuzz
quot; so the
binary under tests/oss-fuzz/ can be generated.
Cc: Bhargava Shastry
Cc: Yifeng Sun
Signed-off-by: William Tu
---
tests/oss-fuzz/automake.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/oss-fuzz/automake.mk b/tests/oss-fuzz/automake.mk
index 2b116e7a51a1..66a5c3037f5d
On Sun, May 10, 2020 at 7:12 PM Tonghao Zhang wrote:
>
> On Sat, May 9, 2020 at 11:26 PM William Tu wrote:
> >
> > On Sat, May 09, 2020 at 09:54:10AM +0800, Tonghao Zhang wrote:
> > > On Sat, May 9, 2020 at 7:23 AM William Tu wrote:
> > > >
> >
meter:m,output:p0
I'm just curious why you need so many 'unique' meters?
can you share the meter id if their settings are the same?
ex:
$ in_port=p0,ip,ip_dst=1.1.1.x action=meter:X ,output:p1
$ in_port=p1,ip,ip_src=1.1.1.x action=meter:X, output:p0
if both flows have the same m
On Sat, May 09, 2020 at 09:54:10AM +0800, Tonghao Zhang wrote:
> On Sat, May 9, 2020 at 7:23 AM William Tu wrote:
> >
> > On Thu, Apr 30, 2020 at 07:00:37PM +0800, xiangxia.m@gmail.com wrote:
> > > From: Tonghao Zhang
> > >
> > > For now, the mete
On Sat, May 09, 2020 at 08:46:56AM +0800, Tonghao Zhang wrote:
> On Sat, May 9, 2020 at 7:12 AM William Tu wrote:
> >
> > On Thu, Apr 30, 2020 at 07:00:38PM +0800, xiangxia.m@gmail.com wrote:
> > > From: Tonghao Zhang
> > >
> > > When setting the
On Thu, Apr 30, 2020 at 07:00:37PM +0800, xiangxia.m@gmail.com wrote:
> From: Tonghao Zhang
>
> For now, the meter of the userspace datapath, don't include
> the bucket burst size to buckets. This patch includes it now.
>
> Cc: Ilya Maximets
> Cc: William Tu
&
On Thu, Apr 30, 2020 at 07:00:38PM +0800, xiangxia.m@gmail.com wrote:
> From: Tonghao Zhang
>
> When setting the meter rate to 4+Gbps, there is an overflow, the
> meters don't work as expected.
>
> Cc: Ilya Maximets
> Cc: William Tu
> Cc: Jarno Rajahalme
>
On Fri, May 8, 2020 at 1:11 AM 姜立东 wrote:
>
> Oh, this is due to patch porting from 2.10.
> Between latest and 2.10, commit 42697ca77 is introduced to fix millisecond
> token insertion rate as below.
> /* All packets will hit the meter at the same time. */
> -long_delta_t = (now - meter-
On Wed, May 6, 2020 at 1:41 PM Vasu Dasari wrote:
>
> Thanks William. Does your statement mean, by network design, vxlan tunnel
> ports and underlay bridge ports should not be part of a single bridge domain?
>
I saw your second email is using two bridges and usually that's how
people use it.
http
On Thu, May 7, 2020 at 7:56 AM Toshiaki Makita
wrote:
>
> On 2020/05/06 0:18, William Tu wrote:
> > On Tue, May 05, 2020 at 11:43:58AM +0900, Toshiaki Makita wrote:
> >> On 2020/05/04 1:22, William Tu wrote:
> >>> On Tue, Apr 21, 2020 at 11:47:04PM +0900, Toshiaki
On Thu, May 7, 2020 at 7:40 AM Toshiaki Makita
wrote:
>
> On 2020/05/06 0:37, William Tu wrote:
> > On Tue, Apr 21, 2020 at 11:47:03PM +0900, Toshiaki Makita wrote:...
> >> +/* Convert odp_port to devmap_idx in output action */
> >> +static int
> >> +c
n the kernel
> source, and see what OVS does differently that would cause the failure.
>
> //Eelco
>
>
> On 7 May 2020, at 2:27, William Tu wrote:
>
> > Hi,
> >
> > We're testing afxdp on rhel8.x. We simply try to run 'make
> > check-afxdp' an
Hi,
We're testing afxdp on rhel8.x. We simply try to run 'make
check-afxdp' and see if it works.
We are doing:
$ yum install libbpf-devel numactl-devel
$ cd ovs; ./boot.sh ; ./configure --enable-afxdp; make check-afxdp
On rhel8.2, the basic ping works.
However on rhel8.0 and 8.1, all test cases f
On Sun, May 03, 2020 at 11:12:04PM -0400, Vasu Dasari wrote:
> Hi,
>
> I am trying a userspace vxlan test case scenario as follows. ap0, fp0, ap1
> and fp1 are namespaces where in packets from ap0 are sent to fp0 over vxlan
> tunnel and packets from ap1 to fp1 are sent over second vxlan tunnel. An
On Mon, Apr 27, 2020 at 01:48:42PM -0700, Yifeng Sun wrote:
> This patch provides essential fixes for OVS to build and package on RHEL8.0.
>
> The required package python3-sphinx can be installed by:
> $ ARCH=$( /bin/arch )
> $ subscription-manager repos --enable
> "codeready-builder-for-rhel-8-$
On Tue, Apr 21, 2020 at 11:47:03PM +0900, Toshiaki Makita wrote:
> This provider offloads classifier to software XDP.
>
> It works only when a custom XDP object is loaded by afxdp netdev.
> The BPF program needs to support classifier with array-of-maps for
> subtable hashmaps and arraymap for subt
On Tue, May 05, 2020 at 11:43:58AM +0900, Toshiaki Makita wrote:
> On 2020/05/04 1:22, William Tu wrote:
> >On Tue, Apr 21, 2020 at 11:47:04PM +0900, Toshiaki Makita wrote:
> >>This adds a reference program, flowtable_afxdp.o, which can be used to
> >>offload flows to
On Tue, May 5, 2020 at 1:48 AM Ilya Maximets wrote:
>
> On 5/5/20 3:08 AM, William Tu wrote:
> > On Mon, May 04, 2020 at 04:55:24PM -0700, Han Zhou wrote:
> >> On Mon, May 4, 2020 at 4:10 PM William Tu wrote:
> >>>
> >>> On Mon, May 04,
On Tue, May 05, 2020 at 11:50:38AM +0900, Toshiaki Makita wrote:
> On 2020/05/05 1:24, William Tu wrote:
> >On Tue, Apr 21, 2020 at 11:47:00PM +0900, Toshiaki Makita wrote:
> >>This patch adds an XDP-based flow cache using the OVS netdev-offload
> >>flow API provider.
On Tue, Apr 21, 2020 at 11:47:00PM +0900, Toshiaki Makita wrote:
> This patch adds an XDP-based flow cache using the OVS netdev-offload
> flow API provider. When an OVS device with XDP offload enabled,
> packets first are processed in the XDP flow cache (with parse, and
> table lookup implemented
On Mon, May 04, 2020 at 04:55:24PM -0700, Han Zhou wrote:
> On Mon, May 4, 2020 at 4:10 PM William Tu wrote:
> >
> > On Mon, May 04, 2020 at 09:55:41PM +0200, Ilya Maximets wrote:
> > > Function raft_command_initiate() returns correctly referenced command
> > >
On Mon, May 04, 2020 at 10:58:06AM -0700, Gregory Rose wrote:
>
> On 5/4/2020 9:28 AM, William Tu wrote:
> >When introducing the interrupt mode for netdev-afxdp, the netdev
> >init function is accidentally removed. Fix it by adding it back.
> >
> >Fixes: 5bf
oduce experimental support for clustered
> databases.")
> Signed-off-by: Ilya Maximets
Looks good to me, Coverity also detects this leak.
Acked-by: William Tu
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, May 01, 2020 at 02:40:41PM -0400, Vasu Dasari wrote:
> Thanks William for your comments.
>
>
> *Vasu Dasari*
>
>
> On Fri, May 1, 2020 at 11:52 AM William Tu wrote:
>
> > On Thu, Apr 30, 2020 at 08:42:04AM -0400, Vasu Dasari wrote:
> > > Hi,
On Fri, May 01, 2020 at 02:58:11PM -0400, Vasu Dasari wrote:
> William, My comments are inline. Thanks.
>
> On Fri, May 1, 2020 at 12:01 PM William Tu wrote:
>
> > On Thu, Apr 30, 2020 at 08:52:38AM -0400, Vasu Dasari wrote:
> > > This email is with the technical
When introducing the interrupt mode for netdev-afxdp, the netdev
init function is accidentally removed. Fix it by adding it back.
Fixes: 5bfc519fee499 ("netdev-afxdp: Add interrupt mode netdev class.")
Signed-off-by: William Tu
---
lib/netdev-linux.c | 1 +
1 file changed, 1 insertio
g function "bpf_program__get_type" which is not
> provided by libbpf from linux 5.3. Although we can use linux >= 5.5 to
> fix it, maybe it's time to switch to using libbpf standalone repository?
> - Fix a crash bug in patch 1 which has been reported by Eel
On Tue, Apr 21, 2020 at 11:47:04PM +0900, Toshiaki Makita wrote:
> This adds a reference program, flowtable_afxdp.o, which can be used to
> offload flows to XDP through netdev-offload-xdp.
> The program will be compiled when using --enable-bpf switch.
>
> Signed-off-by: Toshiaki Makita
Hi Toshia
datum,
&ovsrec_table_classes[OVSREC_TABLE_CT_ZONE]);
// CID 1420856 (#1 of 1): Resource leak (RESOURCE_LEAK)
// 6. leaked_storage: Variable datum going out of scope leaks the storage it
points to.
Fix it by freeing the datum.
Signed-off-by: William Tu
---
ovsdb/ovsdb-idlc.in | 1 +
1 file chang
ues = NULL;
ovsdb_idl_index_write(CONST_CAST(struct ovsdb_idl_row *,
// CID 1420891 (#1 of 1): Resource leak (RESOURCE_LEAK)
Fix it by moving the xmalloc to the true branch.
Signed-off-by: William Tu
---
ovsdb/ovsdb-idlc.in | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
d
estroy
And another possible NULL deref is at ovsdb_datum_equals(). Fix the
two by adding additional checks.
Signed-off-by: William Tu
---
lib/ovsdb-data.c | 8 ++--
lib/ovsdb-idl.c | 3 ++-
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/lib/ovsdb-data.c b/lib/ovsdb-data
The three patches fix around 350 memory-related defects reported
by Coverity. With this series applied, Coverity still shows
around 130 defetcs.
Travis: https://travis-ci.org/github/williamtu/ovs-travis/builds/682347632
William Tu (3):
ovsdb-idlc: Fix memory leak reported by Coverity.
ovsdb
On Thu, Apr 30, 2020 at 08:52:38AM -0400, Vasu Dasari wrote:
> This email is with the technical difficulty I am having with supporting
> above feature.
>
> I have implemented all infrastructure necessary to support the
> CLI, netdev-vport, netdev-native-tnl, etc, and currently debugging my way
> t
On Thu, Apr 30, 2020 at 08:42:04AM -0400, Vasu Dasari wrote:
> Hi,
>
> I am trying to implement a functionality, where in if user specifies port
> through which a VxLAN encapsulated packet can be sent out, then use that
> port rather than going through routing procedure.
>
> ovs-vsctl add-port br
Cc: Numan Siddique
Signed-off-by: William Tu
---
Documentation/faq/releases.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
index dbc1706dec57..3903e5922489 100644
--- a/Documentation/faq/releases.rst
+++ b/Documentation
On Thu, Apr 30, 2020 at 03:29:45PM -0700, Yi-Hung Wei wrote:
> On Wed, Apr 29, 2020 at 12:25 PM William Tu wrote:
> >
> > Commit 1f1613183733 ("ct-dpif, dpif-netlink: Add conntrack timeout
> > policy support") adds conntrack timeout policy for kernel datapath.
>
On Thu, Apr 30, 2020 at 10:36:20AM -0700, Gregory Rose wrote:
>
>
> On 4/29/2020 5:53 PM, William Tu wrote:
> >On Wed, Apr 29, 2020 at 2:41 PM Yi-Hung Wei wrote:
> >>
> >>The geneve/vxlan compat code base invokes ipv6_dst_lookup() which is
> >>recently
On Tue, Apr 21, 2020 at 11:47:02PM +0900, Toshiaki Makita wrote:
> The following commit will introduce another offload driver using XDP.
> When using afxdp netdev, either of TC or XDP will be supported, so let's
> add an other_config to specify which offload driver is preferable.
> When not specifi
On Thu, Apr 23, 2020 at 05:35:14AM +, 姜立东 via dev wrote:
> From df9ff3b67f11e467928ca0873031d81b87f3d0c5 Mon Sep 17 00:00:00 2001
> From: Jiang Lidong
> Date: Thu, 23 Apr 2020 11:07:28 +0800
> Subject: [PATCH] netdev-linux: remove sum of vport stats and kernel netdev
> stats
> When using
On Wed, Apr 29, 2020 at 10:42:41PM -0700, Pravin Shelar wrote:
> On Wed, Apr 29, 2020 at 11:07 AM William Tu wrote:
> >
> > On Tue, Apr 28, 2020 at 03:29:10AM +, 姜立东 wrote:
> > > Hi William,
> > >
> > > > -/* Use kernel netdev's pack
On Wed, Apr 29, 2020 at 2:41 PM Yi-Hung Wei wrote:
>
> The geneve/vxlan compat code base invokes ipv6_dst_lookup() which is
> recently replaced by ipv6_dst_lookup_flow() in the stable kernel tree.
>
> This causes travis build failure:
> * https://travis-ci.org/github/openvswitch/ovs/builds/681
r ICMP and UDP cases.
Signed-off-by: William Tu
---
v5: address feedback from Yi-Hung
- couple improvement for error handling
- travis: https://travis-ci.org/github/williamtu/ovs-travis/builds/681160951
- currently failed due to kernel issue
v4: address feedback from Yi-Hung
- move default
On Tue, Apr 28, 2020 at 11:11:00AM -0700, Yi-Hung Wei wrote:
> On Mon, Apr 27, 2020 at 8:42 AM William Tu wrote:
> >
> > Commit 1f1613183733 ("ct-dpif, dpif-netlink: Add conntrack timeout
> > policy support") adds conntrack timeout policy for kernel datapath.
>
ong
oh, I see your point. Then this looks good to me.
Add Pravin to see if he has some comments.
William
>
> -邮件原件-
> 发件人: William Tu
> 发送时间: 2020年4月27日 12:20
> 收件人: 姜立东
> 抄送: d...@openvswitch.org
> 主题: Re: 答复: [ovs-dev] [PATCH] netdev-linux: remove sum of vport st
:
RX:0
TX:0
Other: 1
Combined: 1
Some previous discussion:
https://mail.openvswitch.org/pipermail/ovs-dev/2020-January/366631.html
Signed-off-by: William Tu
---
utilities/bugtool/ovs-bugtool.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/utilities/bugtool/ovs
This helps debugging the tlv map issues.
Signed-off-by: William Tu
---
utilities/bugtool/plugins/network-status/openvswitch.xml | 1 +
1 file changed, 1 insertion(+)
diff --git a/utilities/bugtool/plugins/network-status/openvswitch.xml
b/utilities/bugtool/plugins/network-status
On Tue, Apr 28, 2020 at 10:59:31PM +0200, Ilya Maximets wrote:
> On 4/27/20 5:45 PM, William Tu wrote:
> > GTP-U support should be at OVS-2.14.
> >
> > Signed-off-by: William Tu
> > ---
>
> Acked-by: Ilya Maximets
Applied, thanks.
__
On Sun, Apr 19, 2020 at 07:17:57AM -0700, William Tu wrote:
> On Tue, Apr 14, 2020 at 01:33:28PM -0700, Yi-Hung Wei wrote:
> > This patch adds a new OpenFlow action, delete field, to delete a
> > field in packets. Currently, only the tun_metadata fields are
> > supported.
>
On Mon, Apr 27, 2020 at 11:54 AM Vasu Dasari wrote:
>
> Hi,
>
> I am running into an error when I try to run the system-traffic test case -
> "conntrack - floating IP". Actually, any test case which is using this in
> the testsuite is failing:
> ADD_VETH(p0, at_ns0, br0, "10.1.1.1/24", "f0:00:00:0
On Tue, Mar 24, 2020 at 3:11 PM William Tu wrote:
>
> This patch enables TSO support for non-DPDK use cases, and
> also add check-system-tso testsuite. Before TSO, we have to
> disable checksum offload, allowing the kernel to calculate the
> TCP/UDP packet checsum. With TSO,
On Tue, Apr 14, 2020 at 6:23 AM William Tu wrote:
>
> The patch adds a new netdev class 'afxdp-nonpmd' to enable afxdp
> interrupt mode. This is similar to 'type=afxdp', except that the
> is_pmd field is set to false. As a result, the packet processing
> is han
Signed-off-by: William Tu
---
AUTHORS.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/AUTHORS.rst b/AUTHORS.rst
index 61a3f6117900..5d83d309ccd5 100644
--- a/AUTHORS.rst
+++ b/AUTHORS.rst
@@ -60,6 +60,7 @@ Andy Zhou az...@ovn.org
Ankur Sharma
GTP-U support should be at OVS-2.14.
Signed-off-by: William Tu
---
Documentation/faq/releases.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
index b3507bd1c7fa..f170ebd3ff22 100644
--- a/Documentation/faq
r ICMP and UDP cases.
Signed-off-by: William Tu
---
v4: address feedback from Yi-Hung
- move default policy value to lib/conntrack-tp.c
- separate icmp bug patch
- refactor and fix include issues
- fix the clang lock analysis annotation
- keep clean interval to 5 seconds
- improve tests
ICMP conntrack state should be ICMPS_REPLY after seeing both
side of ICMP traffic.
Signed-off-by: William Tu
---
lib/conntrack-icmp.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/conntrack-icmp.c b/lib/conntrack-icmp.c
index 63246f0124d0..6cbf9656dd93 100644
On Tue, Apr 21, 2020 at 03:09:05PM -0700, Yi-Hung Wei wrote:
> ovsdb_function_from_string() and ovsdb_function_to_string() are defined
> both in ovsdb/condition.c and lib/ovsdb-condidtion.c with the same function
> definition. Remove the one in ovsdb/condition.c to avoid duplication.
>
> This als
On Tue, Apr 21, 2020 at 08:57:04AM -0700, William Tu wrote:
> On Tue, Apr 21, 2020 at 09:24:38AM +0100, anton.iva...@cambridgegreys.com
> wrote:
> > From: Anton Ivanov
> >
> > Avoid grabbing any mutexes if the log levels specify that
> > no logging is to take
On Tue, Apr 21, 2020 at 05:24:01PM +0100, Anton Ivanov wrote:
>
> On 21/04/2020 17:04, William Tu wrote:
> >On Tue, Apr 21, 2020 at 09:23:57AM +0100, anton.iva...@cambridgegreys.com
> >wrote:
> >>From: Anton Ivanov
> >>
> >>We do not check metada
On Mon, Apr 27, 2020 at 09:02:16AM +0530, Martin Varghese wrote:
> On Sat, Apr 25, 2020 at 06:40:18AM -0700, William Tu wrote:
> > On Fri, Apr 24, 2020 at 02:54:00PM +0530, Martin Varghese wrote:
> > > On Fri, Apr 24, 2020 at 01:06:21AM -0700, Pravin Shelar wrote:
> > >
tats->tx_dropped += dev_stats.tx_dropped;
> stats->multicast += dev_stats.multicast;
> stats->collisions += dev_stats.collisions;
> stats->rx_length_errors+= dev_stats.rx_length_errors;
>
> BR,
> Lidong
>
>
201 - 300 of 1254 matches
Mail list logo
