Thanks William for your comments.
Some replies inline.
-Antonio
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of William Tu
> Sent: Wednesday, January 3, 2018 1:32 AM
> To: Wang, Yipeng1
> Cc: d...@openvswitch.org; Tai,
Sure, that's perfect.
Thanks, Antonio
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Friday, December 15, 2017 7:23 PM
> To: Fischetti, Antonio ;
> d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v3 2/5] conntrack: add commands
Thanks Darrell and Stephen for your suggestions.
I'll rework accordingly in v4.
Antonio
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Monday, December 11, 2017 6:02 PM
> To: Fischetti, Antonio ;
> d...@openvswitch.org
> Subject: Re:
-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Monday, December 11, 2017 6:44 PM
> To: Fischetti, Antonio ;
> d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v3 2/5] conntrack: add commands to r/w CT
> parameters.
>
> One extra note inline
>
> Thanks Darre
LGTM,
Acked-by: Antonio Fischetti
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy
> Sent: Friday, December 8, 2017 12:04 PM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH v6 7/8] Documen
I think this needs a trivial rebase, other than that it's ok.
Acked-by: Antonio Fischetti
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy
> Sent: Friday, December 8, 2017 12:04 PM
> To: d...@ope
LGTM,
Tested-by: Antonio Fischetti
Acked-by: Antonio Fischetti
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy
> Sent: Friday, December 8, 2017 12:04 PM
> To: d...@openvswitch.org
> Subject: [o
LGTM,
Tested-by: Antonio Fischetti
Acked-by: Antonio Fischetti
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy
> Sent: Friday, December 8, 2017 12:04 PM
> To: d...@openvswitch.org
> Subject: [o
LGTM,
Tested-by: Antonio Fischetti
Acked-by: Antonio Fischetti
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy
> Sent: Friday, December 8, 2017 12:04 PM
> To: d...@openvswitch.org
> Subject: [
LGTM,
Tested-by: Antonio Fischetti
Acked-by: Antonio Fischetti
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy
> Sent: Friday, December 8, 2017 12:04 PM
> To: d...@openvswitch.org
> Subject: [o
LGTM,
Tested-by: Antonio Fischetti
Acked-by: Antonio Fischetti
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy
> Sent: Friday, December 8, 2017 12:04 PM
> To: d...@openvswitch.org
> Subject: [o
LGTM,
Tested-by: Antonio Fischetti
Acked-by: Antonio Fischetti
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy
> Sent: Friday, December 8, 2017 12:04 PM
> To: d...@openvswitch.org
> Subject: [o
Hi Bhanu,
I've tested v6 and LGTM, works as expected.
To check the behavior I blocked one or more of the PMD with the trick of
attaching cgdb. So with
utilities/ovs-appctl keepalive/pmd-health-show
I could see for example 2 of the 3 PMDs - those I intentionally blocked -
correctly reported
Still LGTM, please add
Acked-by: Antonio Fischetti
> -Original Message-
> From: Kavanagh, Mark B
> Sent: Monday, December 11, 2017 4:37 PM
> To: Ilya Maximets ; ovs-dev@openvswitch.org
> Cc: Heetae Ahn ; Fischetti, Antonio
> ; Loftus, Ciara ;
> Stokes, Ian ; W
ime.coque...@redhat.com; jan.scheur...@ericsson.com; Mooney, Sean
> K ; Fischetti, Antonio
> ; Bie, Tiwei ;
> Mcnamara, John ; Guoshuai Li
> ; ktray...@redhat.com; Loftus, Ciara
> ; Yuanhan Liu
> Subject: RE: [ovs-dev] [PATCH V4 2/2] netdev-dpdk: vHost IOMMU support
>
> >
Thanks, LGTM.
-Antonio
Acked-by: Antonio Fischetti
> -Original Message-
> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
> Sent: Tuesday, October 31, 2017 3:18 PM
> To: ovs-dev@openvswitch.org
> Cc: Heetae Ahn ; Fischetti, Antonio
> ; Loftus, Ciara ;
> Kava
ctober 31, 2017 11:35 AM
> To: ovs-dev@openvswitch.org
> Cc: Heetae Ahn ; Fischetti, Antonio
> ; Loftus, Ciara ;
> Kavanagh, Mark B ; Stokes, Ian
> ; Wojciechowicz, RobertX
> ; Ilya Maximets
> Subject: [PATCH 2/2] netdev-dpdk: Add debug appctl to get mempool information.
&g
LGTM
Acked-by: Antonio Fischetti
> -Original Message-
> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
> Sent: Tuesday, October 31, 2017 11:35 AM
> To: ovs-dev@openvswitch.org
> Cc: Heetae Ahn ; Fischetti, Antonio
> ; Loftus, Ciara ;
> Kavanagh,
ya Maximets [mailto:i.maxim...@samsung.com]
> Sent: Monday, October 30, 2017 12:53 PM
> To: ovs-dev@openvswitch.org
> Cc: Heetae Ahn ; Fischetti, Antonio
> ; Loftus, Ciara ;
> Kavanagh, Mark B ; Stokes, Ian
> ; Wojciechowicz, RobertX
> ; Ilya Maximets
> Subject: [PATCH 4/4] netdev-dpdk:
Thanks Ilya, it's a good rework especially for netdev_dpdk_mempool_configure()
fn.
LGTM
Acked-by: Antonio Fischetti
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
LGTM
Acked-by: Antonio Fischetti
> -Original Message-
> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
> Sent: Monday, October 30, 2017 12:53 PM
> To: ovs-dev@openvswitch.org
> Cc: Heetae Ahn ; Fischetti, Antonio
> ; Loftus, Ciara ;
> Kavanagh,
LGTM, makes the code more readable.
Acked-by: Antonio Fischetti
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
> On Behalf Of Kevin Traynor
> Sent: Friday, October 20, 2017 11:37 AM
> To: Darrell Ball ; d...@openvswitch.org;
> i.max
> -Original Message-
> From: Kavanagh, Mark B
> Sent: Friday, October 20, 2017 9:44 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Cc: Darrell Ball ; Loftus, Ciara ;
> Kevin Traynor ; Aaron Conole
> Subject: RE: [PATCH v8 6/6] netdev-dpdk: Rename dpdk_m
> -Original Message-
> From: Kavanagh, Mark B
> Sent: Friday, October 20, 2017 10:28 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Cc: Darrell Ball ; Loftus, Ciara ;
> Kevin Traynor ; Aaron Conole
> Subject: RE: [PATCH v8 4/6] netdev-dpdk: manage fa
> -Original Message-
> From: Stokes, Ian
> Sent: Thursday, October 19, 2017 6:22 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH v8 0/6] netdev-dpdk: Fix mempool management and
> other cleanup.
>
> > Patch #1, #2 and #4 c
> -Original Message-
> From: Stokes, Ian
> Sent: Thursday, October 19, 2017 6:23 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH v8 4/6] netdev-dpdk: manage failure in mempool
> name creation.
>
> > In case a mempool name c
nal Message-
> From: Kevin Traynor [mailto:ktray...@redhat.com]
> Sent: Thursday, October 19, 2017 11:33 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Cc: Kavanagh, Mark B ; Aaron Conole
>
> Subject: Re: [PATCH v7 2/6] netdev-dpdk: Fix mempool names to reflect socket
> i
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
> On Behalf Of Fischetti, Antonio
> Sent: Wednesday, October 18, 2017 10:43 AM
> To: Kavanagh, Mark B ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v6 1/5
> -Original Message-
> From: Kavanagh, Mark B
> Sent: Tuesday, October 17, 2017 10:14 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Cc: Kevin Traynor ; Aaron Conole ;
> Darrell Ball
> Subject: RE: [PATCH v6 1/5] netdev-dpdk: fix management of pre-existing
&
Thanks Mark, comments inline.
-Antonio
> -Original Message-
> From: Kavanagh, Mark B
> Sent: Tuesday, October 17, 2017 2:36 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Cc: Darrell Ball ; Loftus, Ciara ;
> Kevin Traynor ; Aaron Conole
> Subject: RE: [PATC
Thanks Mark for your suggestions, I'll rework accordingly.
-Antonio
> -Original Message-
> From: Kavanagh, Mark B
> Sent: Tuesday, October 17, 2017 2:35 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Cc: Darrell Ball ; Loftus, Ciara ;
> Kevin Traynor ; Aaro
> -Original Message-
> From: Kavanagh, Mark B
> Sent: Tuesday, October 17, 2017 2:34 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Cc: Darrell Ball ; Loftus, Ciara ;
> Kevin Traynor ; Aaron Conole
> Subject: RE: [PATCH v6 2/5] netdev-dpdk: skip init
Thanks Mark, comments inline.
-Antonio
> -Original Message-
> From: Kavanagh, Mark B
> Sent: Tuesday, October 17, 2017 2:34 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Cc: Kevin Traynor ; Aaron Conole ;
> Darrell Ball
> Subject: RE: [PATCH v6 1/5] netdev-dp
Any comment on v2?
Thanks,
Antonio
> -Original Message-
> From: Fischetti, Antonio
> Sent: Tuesday, September 26, 2017 10:45 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH v2] dpctl: manage ret value when dumping CT
> entries.
>
&
Thanks Mark for your review, some comment inline.
-Antonio
> -Original Message-
> From: Kavanagh, Mark B
> Sent: Friday, October 13, 2017 3:46 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH v5 0/6] netdev-dpdk: Fix management of
> -Original Message-
> From: Kavanagh, Mark B
> Sent: Friday, October 13, 2017 3:48 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH v5 5/6] netdev-dpdk: Reword mp_size as n_mbufs.
>
> >From: ovs-dev-boun...@openvswitch.org
Thanks Mark for your review, I've added my answers inline.
-Antonio
> -Original Message-
> From: Kavanagh, Mark B
> Sent: Friday, October 13, 2017 4:56 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH v5 1/6] netdev-dpdk: f
+ CC Darrell to the loop because we already discussed about this.
> -Original Message-
> From: Kavanagh, Mark B
> Sent: Friday, October 13, 2017 5:07 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH v5 4/6] netdev-dpdk: assert mempool na
> -Original Message-
> From: Kavanagh, Mark B
> Sent: Friday, October 13, 2017 3:47 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH v5 4/6] netdev-dpdk: assert mempool names.
>
> >From: ovs-dev-boun...@openvswitch.org
Hi Bhanu,
a couple of minor comments below.
-Antonio
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
> On Behalf Of Bhanuprakash Bodireddy
> Sent: Friday, September 15, 2017 5:40 PM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATC
A couple of minor comments inline.
-Antonio
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
> On Behalf Of Bhanuprakash Bodireddy
> Sent: Friday, September 15, 2017 5:40 PM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH v5 05/1
Hi Bhanu,
a couple of minor comments inline.
-Antonio
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
> On Behalf Of Bhanuprakash Bodireddy
> Sent: Friday, September 15, 2017 5:40 PM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PAT
> -Original Message-
> From: Kevin Traynor [mailto:ktray...@redhat.com]
> Sent: Wednesday, October 11, 2017 2:37 PM
> To: Fischetti, Antonio ; Róbert Mulik
> ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v3 1/5] netdev-dpdk: fix mempool management with
> v
> -Original Message-
> From: Kevin Traynor [mailto:ktray...@redhat.com]
> Sent: Wednesday, October 11, 2017 11:40 AM
> To: Fischetti, Antonio ; Róbert Mulik
> ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v3 1/5] netdev-dpdk: fix mempool management with
> v
hed some
light?
I may have missed some detail as I didn't follow this implementation since the
very beginning.
Antonio
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
> On Behalf Of Fischetti, Antonio
> Sent: Wednesd
Thanks Robert for reporting this and for all the clear details you provided.
I'll look into this and get back to you.
Antonio
> -Original Message-
> From: Róbert Mulik [mailto:robert.mu...@ericsson.com]
> Sent: Tuesday, October 10, 2017 4:19 PM
> To: Fisch
Thanks Kevin, I'll rework a v3.
Antonio
> -Original Message-
> From: Kevin Traynor [mailto:ktray...@redhat.com]
> Sent: Tuesday, October 3, 2017 11:11 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v2 0/4] Conntrack: add commands to
Thanks Ciara, will respin a v4. Comments inline.
Antonio
> -Original Message-
> From: Loftus, Ciara
> Sent: Friday, October 6, 2017 11:40 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH v3 1/5] netdev-dpdk: fix mempool management wi
I'll rework this patch and post a V3.
Thanks,
Antonio
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
> On Behalf Of Fischetti, Antonio
> Sent: Tuesday, October 3, 2017 4:25 PM
> To: Kevin Traynor ; d...@openvswit
Thanks Kevin for your feedback.
Below some details on what happens, how to replicate the issue and
some comments inline.
-Antonio
> -Original Message-
> From: Kevin Traynor [mailto:ktray...@redhat.com]
> Sent: Monday, October 2, 2017 6:38 PM
> To: Fischetti,
Thanks Kevin, comments inline.
-Antonio
> -Original Message-
> From: Kevin Traynor [mailto:ktray...@redhat.com]
> Sent: Monday, October 2, 2017 11:46 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Tuesday, September 26, 2017 9:22 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 3/4] netdev-dpdk: log an err message when a
> mempool name is empty.
>
>
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Tuesday, September 26, 2017 9:02 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 2/4] netdev-dpdk: if mempool already exists
> don't
> reinit packet ar
Thanks Darrell, replies inline.
-Antonio
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Tuesday, September 26, 2017 9:04 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 1/4] netdev-dpdk: fix mempool managem
Actually I forgot to add in the commit message
Reviewed-by: Greg Rose
Can this please be added later?
Thanks, Antonio
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
> On Behalf Of antonio.fische...@intel.com
> Sent: Tuesday, Septem
Thanks Darrell, comments inline. I'll post a v2 based on your suggestions.
-Antonio
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Monday, September 25, 2017 8:31 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-de
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Monday, September 25, 2017 8:35 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 2/2] dpctl: init CT entry variable.
>
>
>
> On 9/25/17, 2:51 AM,
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Friday, September 22, 2017 9:26 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 2/2] dpctl: init CT entry variable.
>
>
>
> On 9/13
.@vmware.com]
> Sent: Friday, September 22, 2017 8:42 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 1/2] dpctl: manage ret value when dumping CT
> entries.
>
> Few comments Antonio
>
> Darrell
>
> On 9/13/17, 5:37 AM, &qu
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Thursday, September 21, 2017 7:56 PM
> To: Fischetti, Antonio ; Darrell Ball
> ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [patch v2 4/5] conntrack: Add function
> print_conn_info().
>
Looks a good improvement to report on an intentional exploit, or
other issues.
LGTM, just one comment. Now this new print fn is called just from
create_un_nat_conn but in the future it could potentially be called
from any other CT function. As the function call could affect the
performance, espe
e-
> From: Kevin Traynor [mailto:ktray...@redhat.com]
> Sent: Tuesday, September 19, 2017 2:11 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 1/5] conntrack: add commands to r/w conntrack
> parameters.
>
> On 09/18/2017 11:21 AM, antonio.
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Tuesday, September 19, 2017 9:28 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 3/5] conntrack: r/w clean-up interval.
>
> Hi Antonio
>
> What is th
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Tuesday, September 19, 2017 9:05 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 2/5] conntrack: r/w upper limit value for
> connections.
>
>
>
>
Thanks Darrell for your comments, I'll re-spin a V2 based on your feedback.
Other details inline below.
-Antonio
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Tuesday, September 19, 2017 8:50 AM
> To: Fischetti, Antonio ; d...@openvswitch.
Comments inline.
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
> On Behalf Of Bhanuprakash Bodireddy
> Sent: Tuesday, August 22, 2017 10:41 AM
> To: d...@openvswitch.org
> Cc: i.maxim...@samsung.com
> Subject: [ovs-dev] [PATCH v4 7/7]
Comments inline.
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
> On Behalf Of Bhanuprakash Bodireddy
> Sent: Tuesday, August 22, 2017 10:41 AM
> To: d...@openvswitch.org
> Cc: i.maxim...@samsung.com
> Subject: [ovs-dev] [PATCH v4 5/7]
Comments inline.
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
> On Behalf Of Bhanuprakash Bodireddy
> Sent: Tuesday, August 22, 2017 10:41 AM
> To: d...@openvswitch.org
> Cc: i.maxim...@samsung.com
> Subject: [ovs-dev] [PATCH v4 2/7]
Hi Bhanu,
I added some comments on patches #2, 5 and 7.
Besides that LGTM. I applied this patch series to
commit 84d2723305064e25402cb89a16bf7ad1aa2cda70
and it works as expected.
-Antonio
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.o
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Saturday, August 26, 2017 1:45 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v4] dpif-netdev: Avoid reading RSS hash when EMC
> is disabled
>
>
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Friday, August 25, 2017 6:19 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v4] dpif-netdev: Avoid reading RSS hash when EMC
> is disabled
>
> Hi Anton
Sure Darrell, I'll do that.
Thanks!
Antonio
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Friday, August 25, 2017 9:59 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v3 2/4] dpif-netdev: Avoid reading
> -Original Message-
> From: Kevin Traynor [mailto:ktray...@redhat.com]
> Sent: Tuesday, August 22, 2017 7:58 PM
> To: Aaron Conole ; Fischetti, Antonio
>
> Cc: Wojciechowicz, RobertX ;
> d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v3] netdev-dpdk: Cre
> -Original Message-
> From: Jan Scheurich [mailto:jan.scheur...@ericsson.com]
> Sent: Thursday, August 17, 2017 1:42 PM
> To: Fischetti, Antonio ; Darrell Ball
> ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH v3 1/4] dpif-netdev: Skip EMC lookup/insert fo
Hi Kevin, pls see comments inline.
I'm going to rebase and rework this patch on behalf of Robert.
Thanks,
Antonio
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
> On Behalf Of Kevin Traynor
> Sent: Tuesday, April 11, 2017 9:37 AM
>
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Monday, August 14, 2017 7:34 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v3 4/4] dp-packet: Use memcpy on dp_packet
> elements.
>
> Could you show
increases the probability again to probe for changed
> traffic patterns.
>
> Once we have that I think the same dynamic probability could be possible to
> use
> also for probabilistic EMC insertion.
>
> BR, Jan
>
> > -Original Message-
> > From: ovs-dev-boun...@o
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Wednesday, August 16, 2017 9:09 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v3 1/4] dpif-netdev: Skip EMC lookup/insert for
> recirc packets
>
>
&g
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Monday, August 14, 2017 7:27 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v3 1/4] dpif-netdev: Skip EMC lookup/insert for
> recirc packets
>
>
&g
Any comment on this patchset?
Adding Jan in CC.
In one of the last bi-weekly meeting there was some interest in testing
this patchset in conjunction with the patch to avoid using EMC for
recirculated packets - this is contained inside the patchset
https://mail.openvswitch.org/pipermail/ovs-dev/20
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Tuesday, August 8, 2017 8:16 AM
> To: Fischetti, Antonio ; Ilya Maximets
> ; ovs-dev@openvswitch.org
> Cc: Heetae Ahn
> Subject: Re: [ovs-dev] [PATCH v2 2/2] dpif-netdev: Fix emc replac
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Tuesday, August 8, 2017 8:12 AM
> To: Ilya Maximets ; Wang, Yipeng1
> ; ovs-dev@openvswitch.org
> Cc: Heetae Ahn ; Kevin Traynor
> ;
> Loftus, Ciara ; Fischetti, Antonio
>
> Su
LGTM
Acked-by: Antonio Fischetti
> -Original Message-
> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
> Sent: Friday, August 4, 2017 3:17 PM
> To: ovs-dev@openvswitch.org
> Cc: Heetae Ahn ; Darrell Ball ;
> Wang, Yipeng1 ; Kevin Traynor ;
> Loftus, Ciara
My reply inline.
Acked-by: Antonio Fischetti
> -Original Message-
> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
> Sent: Friday, August 4, 2017 12:38 PM
> To: Fischetti, Antonio ; ovs-dev@openvswitch.org
> Cc: Heetae Ahn ; Loftus, Ciara
>
> Subject: Re: [o
LGTM,
just wondering if a further comment would help,
eg something like
+/* random_uint32() returns a value in the [0; UINT32_MAX] range.
+ For our checking to be correct we would need instead a random value
+ in the range [0; UINT32_MAX - 1]. To avoid further computation
+ we use a decre
LGTM.
I think this patch could work fine in conjunction with the one I posted
https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/335940.html
where I'm targeting a congestion usecase with recirculated packets.
The goal is still to limit thrashing and the criteria is to avoid
EMC lookup and i
> -Original Message-
> From: O Mahony, Billy
> Sent: Tuesday, August 1, 2017 3:15 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH v2 5/5] dp-packet: Use memcpy on dp_packet
> elements.
>
> Hi Antonio,
>
> > -Origin
> -Original Message-
> From: O Mahony, Billy
> Sent: Tuesday, August 1, 2017 11:51 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH v2 3/5] dpif-netdev: Skip EMC lookup/insert for
> recirc packets.
>
> Hi Antonio,
>
LGTM thanks Darrell.
-Antonio
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Wednesday, August 2, 2017 5:16 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v5] dpctl: Add new 'ct-bkts' command.
>
> -Original Message-
> From: O Mahony, Billy
> Sent: Monday, July 31, 2017 5:22 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH v2 2/5] dpif-netdev: Avoid reading RSS hash when
> EMC is disabled.
>
> Hi Antonio,
>
> This
> -Original Message-
> From: O Mahony, Billy
> Sent: Monday, July 31, 2017 4:33 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH v2 1/5] dpif-netdev: move pkt metadata init out
> of emc_processing.
>
> There is also a referen
> -Original Message-
> From: Aaron Conole [mailto:acon...@redhat.com]
> Sent: Sunday, July 30, 2017 4:19 PM
> To: Darrell Ball
> Cc: d...@openvswitch.org; Fischetti, Antonio ;
> Ilya Maximets
> Subject: Re: [ovs-dev] [patch_v2] dpdk: Fix device cleanup.
>
LGTM I agree with this safe approach.
I did some basic testing with a Niantic NIC but I couldn't
replicate the issue. Below some details on my testing.
To cause the issue I killed and restarted vswitchd only, so
that it could find and run with an existing database with
the devices already bound
https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/335938.html
-Antonio
> -Original Message-
> From: O Mahony, Billy
> Sent: Wednesday, July 26, 2017 9:55 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH RFC 2/4] dpif-netdev: Skip EMC lookup/inser
Hi Darrell, I posted a v5 at http://patchwork.ozlabs.org/patch/792723/
where I added all your suggestions.
Thanks,
-Antonio
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Fischetti, Antonio
> Sent: Mon
Thanks Darrell, I will apply your suggetions.
-Antonio
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Sunday, July 23, 2017 6:28 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v4] dpctl: Add new &#
Thanks Darrell, I agree with all your suggestions.
I'll rework and post a new version.
-Antonio
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Friday, July 21, 2017 8:12 AM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re:
Thanks Sugesh for your comments, pls see replies inline.
-Antonio
> -Original Message-
> From: Chandran, Sugesh
> Sent: Friday, June 23, 2017 4:20 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH RFC v2] Conntrack: Avoid recirculation fo
t; From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Fischetti, Antonio
> Sent: Friday, June 23, 2017 10:53 PM
> To: O Mahony, Billy ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 1/4] dpif-netdev: Avoid reading RSS hash
> when
Thanks Darrel for your feedback, I'll post a v3 soon.
Antonio
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Monday, July 17, 2017 6:03 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v2] dpctl: Add n
1 - 100 of 128 matches
Mail list logo
