[ovs-dev] [PATCH v4] dpdk: Update to use v22.11.1.

of the original commits to 'dpdk-latest' with the above changes have been added as co-authors for this commit Signed-off-by: David Marchand Co-authored-by: David Marchand Signed-off-by: Sunil Pai G Co-authored-by: Sunil Pai G Signed-off-by: Ian Stokes --- v3 -> v4 * Rebase to master. * Update to use D

[ovs-dev] [PATCH v3] dpdk: Update to use v22.11.

-authored-by: Sunil Pai G Signed-off-by: Ian Stokes --- v2 -> v3 * Remove RFC status. * Update debian control to use 22.11. v1 -> v2 * Updated to use DPDK 22.11 rc4. * Please Note: Although DPDK documentation has been updated in this patch the resource has not been updated on the DPDK site as

[ovs-dev] [RFC PATCH v2] dpdk: Update to use v22.11.

-authored-by: Sunil Pai G Signed-off-by: Ian Stokes --- v1 -> v2 * Updated to use DPDK 22.11 rc4. * Please Note: Although DPDK documentation has been updated in this patch the resource has not been updated on the DPDK site as of yet, this will be expected as part of DPDK 22.11 final rele

[ovs-dev] [RFC PATCH] dpdk: Update to use v22.11.

-authored-by: Sunil Pai G Signed-off-by: Ian Stokes --- 1. Please Note: Although DPDK documentation has been updated in this patch the resource has not been updated on the DPDK site as of yet, this will be expected as part of DPDK RC4. --- .ci/linux-build.sh | 9

[ovs-dev] [PATCH] ci: Update meson requirement for DPDK.

] https://git.dpdk.org/dpdk/commit/?id=909ad7b80e5e Signed-off-by: Ian Stokes Reviewed-by: David Marchand --- .ci/linux-prepare.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/linux-prepare.sh b/.ci/linux-prepare.sh index 16a7aec0b..11d75a6d5 100755 --- a/.ci/linux

[ovs-dev] [PATCH dpdk-latest] ci: Update meson requirement for DPDK 22.11.

A recent change [1] in DPDK bumped requirements on meson to 0.53.2. [1] https://git.dpdk.org/dpdk/commit/?id=909ad7b80e5e Signed-off-by: Ian Stokes --- .ci/linux-prepare.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/linux-prepare.sh b/.ci/linux-prepare.sh index

[ovs-dev] [PATCH v2 1/1] dpdk: Update to use DPDK v21.11.

-authored-by: David Marchand Reviewed-by: Maxime Coquelin Signed-off-by: Ian Stokes --- v1 -> v2 * Modified openvswitch-fedora.spec.in instead of generated files. RFC -> V1 * Add telemetry warning to OVS DPDK unit tests. * Update TSO documentation link to 21.11. * Update fedora spec to use

[ovs-dev] [PATCH v1 1/1] dpdk: Update to use DPDK v21.11.

-authored-by: David Marchand Reviewed-by: Maxime Coquelin Signed-off-by: Ian Stokes --- RFC -> V1 * Add telemetry warning to OVS DPDK unit tests. * Update TSO documentation link to 21.11. * Update fedora spec to use 21.11. --- .ci/linux-build.sh | 6 +- .ci/li

[ovs-dev] [RFC PATCH 1/1] dpdk: Update to use DPDK v21.11.

/openvswitch/list/?series=271040=* For credit all authors of the original commits to 'dpdk-latest' with the above changes have been added as co-authors for this commit. Signed-off-by: David Marchand Co-authored-by: David Marchand Signed-off-by: Ian Stokes --- .ci/linux-build.sh

[ovs-dev] [PATCH v1 branch-2.13 2/2] acinclude: Strip out -mno-avx512f provided by DPDK.

and it's very unpredictable. Reported-at: openvswitch/ovs-issues#201 Signed-off-by: Ilya Maximets Co-authored-by: Ilya Maximets Signed-off-by: Ian Stokes --- acinclude.m4 | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index 9922c69b0..4033e28eb

[ovs-dev] [PATCH v1 branch-2.13 1/2] acinclude: Strip out -march provided by DPDK.

DPDK flags may include -march. Forcing -march could be considered too heavy a requirement when users compile OVS from source and could override user provided options. Resolve this by stripping -march from provided DPDK flags. Signed-off-by: Ian Stokes --- acinclude.m4 | 3 +++ 1 file changed

[ovs-dev] [PATCH v1 branch-2.14 2/2] acinclude: Strip out -mno-avx512f provided by DPDK.

and it's very unpredictable. Reported-at: openvswitch/ovs-issues#201 Signed-off-by: Ilya Maximets Co-authored-by: Ilya Maximets Signed-off-by: Ian Stokes --- acinclude.m4 | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index 14fe4218a..5710f5da8

[ovs-dev] [PATCH v1 branch-2.14 1/2] acinclude: Strip out -march provided by DPDK.

DPDK flags may include -march. Forcing -march could be considered too heavy a requirement when users compile OVS from source and could override user provided options. Resolve this by stripping -march from provided DPDK flags. Signed-off-by: Ian Stokes --- acinclude.m4 | 3 +++ 1 file changed

[ovs-dev] [PATCH v5 1/1] dpdk: Update to use DPDK v20.11.

Haaren Tested-by: Govindharajan, Hariprasad Tested-by: Tonghao Zhang Signed-off-by: Ian Stokes --- v4 -> v5 * Fixed indentation for pkg-config error message. * Removed typo from pkg-config error message. * Removed whitespace splitting comment. --- .ci/linux-build.sh |

[ovs-dev] [PATCH v3 1/1] dpdk: Update to use DPDK v20.11.

Haaren Tested-by: Govindharajan, Hariprasad Signed-off-by: Ian Stokes --- v2 -> v3 * Remove GHA others write removal. * Strip march from pkg-config h=which is forced by DPDK. RFC v1 -> v2 * Removed RFC tag. * Rebased to head of master. * Modified GHA build scripts to install required

[ovs-dev] [PATCH v2 1/1] dpdk: Update to use DPDK v20.11.

commits to 'dpdk-latest' with the above changes have been added as co-authors for this commit. Signed-off-by: David Marchand Co-authored-by: David Marchand Signed-off-by: Sunil Pai G Co-authored-by: Sunil Pai G Signed-off-by: Eli Britstein Co-authored-by: Eli Britstein Signed-off-by: Ian

[ovs-dev] [RFC PATCH v1 1/1] dpdk: Update to use DPDK v20.11.

commits to 'dpdk-latest' with the above changes have been added as co-authors for this commit. Signed-off-by: David Marchand Co-authored-by: David Marchand Signed-off-by: Sunil Pai G Co-authored-by:Sunil Pai G Signed-off-by: Eli Britstein Co-authored-by: Eli Britstein Signed-off-by: Ian Stokes

[ovs-dev] [PATCH v1 1/1] dpif-netdev: Fix typo in copyright header.

Reported-by: David Marchand Fixes: 352b6c7116cd ("dpif-lookup: add avx512 gather implementation.") Fixes: f5ace7cd8a85 ("dpif-netdev: Move dpcls lookup structures to .h") Cc: Harry Van Haaren Signed-off-by: Ian Stokes --- lib/dpif-netdev-lookup-avx512-gather.c | 2 +- lib/d

[ovs-dev] [PATCH v2 1/1] DPDK: Remove support for vhost-user zero-copy.

by commit [2] As such remove support from OVS. [1] 715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode") [2] d21003c9dafa ("doc: announce removal of vhost zero-copy dequeue") Signed-off-by: Ian Stokes --- v1 -> v2 * Remove reference to zero

[ovs-dev] [PATCH v1 1/1] DPDK: Remove support for vhost-user zero-copy.

Support for vhost-user dequeue zero-copy was deprecated in OVS 2.14 with the aim of removing it for OVS 2.15. Support for zero-copy will also be removed from DPDK 20.11. As such remove support from OVS. Signed-off-by: Ian Stokes --- Documentation/topics/dpdk/vhost-user.rst | 72

[ovs-dev] [PATCH v3 1/1] netdev-offload-dpdk: Fix for broken ethernet matching HWOL for XL710NIC.

Co-authored-by: Eli Britstein Tested-by: Ian Stokes --- lib/netdev-offload-dpdk.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index de6101e4d..2d668275a 100644 --- a/lib/netdev-offload

[ovs-dev] [PATCH 1/1] netdev-dpdk: linear buffer check with zero-copy

From: Sivaprasad Tummala As of DPDK 19.11, in order to use dequeue-zero-copy in DPDK Vhost library, the application has to disable the linear buffer option. Hence dequeue-zero-copy is not supported for vhost application that requires linear buffers. An alternative DPDK based approach to disable

[ovs-dev] [PATCH 1/1] releases: Add OVS 2.14 to DPDK mapping.

Add an entry for OVS 2.14 to map to the validated DPDK release. Signed-off-by: Ian Stokes --- Documentation/faq/releases.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index ac93e6e97..9a7a6444c 100644 --- a/Documentation

[ovs-dev] [PATCH 1/1] dpdk: Deprecate vhost-user dequeue zero-copy.

with its removal expected in the next OVS release. [1] 715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode") [2] http://mails.dpdk.org/archives/dev/2020-August/177236.html Signed-off-by: Ian Stokes --- Documentation/topics/dpdk/vhost-user.rst | 5 +

[ovs-dev] [PATCH v2 1/1] dpdk: Use DPDK 19.11.2 release.

Modify travis linux build script to use DPDK 19.11.2 stable release and update docs to reference 19.11.2 stable release. Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +- Documentation/faq/releases.rst | 2 +- Documentation/intro/install/dpdk.rst | 8

[ovs-dev] [PATCH branch-2.10 v1 1/1] dpdk:Use DPDK 17.11.10 release.

Modify travis linux build script to use the latest DPDK stable release. Update docs for latest DPDK stable releases. Note 17.11.10 is the final support release for the 17.11 series, no further support releases for 17.11 series are expected. Signed-off-by: Ian Stokes --- .travis/linux-build.sh

[ovs-dev] [PATCH branch-2.13 v2 1/1] dpdk: Use DPDK 19.11.2 release.

Modify travis linux build script to use DPDK 19.11.2 stable release and update docs to reference 19.11.2 stable release. Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +- Documentation/faq/releases.rst | 2 +- Documentation/intro/install/dpdk.rst | 8

[ovs-dev] [PATCH branch-2.11 v1 1/1] dpdk: Use DPDK 18.11.9 release.

Modify travis linux build script to use the latest DPDK stable release. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +- Documentation/faq/releases.rst | 2 +- Documentation/intro/install/dpdk.rst | 8

[ovs-dev] [PATCH branch-2.12 v1 1/1] dpdk: Use DPDK 18.11.9 release.

Modify travis linux build script to use the latest DPDK stable release. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +- Documentation/faq/releases.rst | 4 ++-- Documentation/intro/install/dpdk.rst | 8

[ovs-dev] [PATCH branch-2.9 v1 1/1] dpdk:Use DPDK 17.11.10 release.

Modify travis linux build script to use the latest DPDK stable release. Update docs for latest DPDK stable releases. Note 17.11.10 is the final support release for the 17.11 series, no further support releases for 17.11 series are expected. Signed-off-by: Ian Stokes --- .travis/linux-build.sh

[ovs-dev] [PATCH v1 1/1] dpdk: Use DPDK 19.11.2 release.

Modify travis linux build script to use DPDK 19.11.2 stable release and update docs to reference 19.11.2 stable release. Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +- Documentation/faq/releases.rst | 2 +- Documentation/intro/install/dpdk.rst | 8

[ovs-dev] [PATCH branch-2.13 v1 1/1] dpdk: Use DPDK 19.11.2 release.

Modify travis linux build script to use DPDK 19.11.2 stable release and update docs to reference 19.11.2 stable release. Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +- Documentation/faq/releases.rst | 2 +- Documentation/intro/install/dpdk.rst | 8

[ovs-dev] [PATCH v2 1/1] dpdk: Update to use DPDK 19.11.

-authored-by: David Marchand Signed-off-by: Ilya Maximets Co-authored-by: Ilya Maximets Signed-off-by: Ophir Munk Co-authored-by: Ophir Munk Signed-off-by: Ian Stokes --- v1 -> v2 * Correct email for Ilya on sign off and co author tags. * Use 19.11 specific address for DPDK guide links. *

[ovs-dev] [PATCH v1 1/1] dpdk: Update to use DPDK 19.11.

-authored-by: David Marchand Signed-off-by: Ilya Maximets Co-authored-by: Ilya Maximets Signed-off-by: Ophir Munk Co-authored-by: Ophir Munk Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +- Documentation/intro/install/dpdk.rst | 10 +- Documentation/topics

[ovs-dev] [PATCH branch-2.11 1/1] dpdk: Use DPDK 18.11.5 release.

Modify travis linux build script to use the latest DPDK stable release 18.11.5. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +- Documentation/faq/releases.rst | 2 +- Documentation/intro/install/dpdk.rst

[ovs-dev] [PATCH branch-2.12 1/1] dpdk: Use DPDK 18.11.5 release.

Modify travis linux build script to use the latest DPDK stable release 18.11.5. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +- Documentation/faq/releases.rst | 4 ++-- Documentation/intro/install/dpdk.rst

[ovs-dev] [PATCH v1 1/1] dpdk: Use DPDK 18.11.5 release.

Modify travis linux build script to use the latest DPDK stable release 18.11.5. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +- Documentation/faq/releases.rst | 2 +- Documentation/intro/install/dpdk.rst

Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations

ions On 19.07.2019 11:27, Ian Stokes wrote: On 7/19/2019 9:08 AM, Ilya Maximets wrote: On 19.07.2019 9:58, Ian Stokes wrote: On 7/18/2019 3:30 PM, Ian Stokes wrote: On 7/18/2019 2:03 PM, Harry van Haaren wrote: Hey Folks, Here a v14 of the DPCLS Function Pointer patchset, as has been presented at OVS

Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations

On 7/19/2019 9:08 AM, Ilya Maximets wrote: On 19.07.2019 9:58, Ian Stokes wrote: On 7/18/2019 3:30 PM, Ian Stokes wrote: On 7/18/2019 2:03 PM, Harry van Haaren wrote: Hey Folks, Here a v14 of the DPCLS Function Pointer patchset, as has been presented at OVS Conf in Nov '18, and discussed

Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations

On 7/18/2019 3:30 PM, Ian Stokes wrote: On 7/18/2019 2:03 PM, Harry van Haaren wrote: Hey Folks, Here a v14 of the DPCLS Function Pointer patchset, as has been presented at OVS Conf in Nov '18, and discussed on the ML since then. I'm aware of the soft-freeze for 2.12, I feel this patchset has

Re: [ovs-dev] [PATCH v14 0/5] dpcls func ptrs & optimizations

On 7/18/2019 2:03 PM, Harry van Haaren wrote: Hey Folks, Here a v14 of the DPCLS Function Pointer patchset, as has been presented at OVS Conf in Nov '18, and discussed on the ML since then. I'm aware of the soft-freeze for 2.12, I feel this patchset has had enough reviews/versions/testing to be

Re: [ovs-dev] [PATCH v2] doc: Remove experimental tag for SMC cache.

On 7/18/2019 12:56 PM, Ilya Maximets wrote: On 17.07.2019 23:25, Ian Stokes wrote: On 7/17/2019 12:38 PM, Yipeng Wang wrote: SMC cache was introduced in 2.10 with experimental tag. SMC cache is a layer of software cache located after EMC cache. The purpose is to improve the performance of use

Re: [ovs-dev] [PATCH v2] doc: Remove experimental tag for SMC cache.

On 7/17/2019 12:38 PM, Yipeng Wang wrote: SMC cache was introduced in 2.10 with experimental tag. SMC cache is a layer of software cache located after EMC cache. The purpose is to improve the performance of use cases that many flows missing the EMC cache. One can enable SMC cache using

Re: [ovs-dev] [PATCH v13 0/5] dpcls func ptrs & optimizations

On 7/17/2019 7:21 PM, Harry van Haaren wrote: Hey Folks, Here a v13 of the DPCLS Function Pointer patchset, as has been presented at OVS Conf in Nov '18, and discussed on the ML since then. I'm aware of the soft-freeze for 2.12, I feel this patchset has had enough reviews/versions/testing to be

Re: [ovs-dev] [PATCH v11 5/5] dpif-netdev: Add specialized generic scalar functions

On 7/17/2019 11:29 AM, Van Haaren, Harry wrote: -Original Message- From: Stokes, Ian Sent: Tuesday, July 16, 2019 10:07 PM To: Van Haaren, Harry ; d...@openvswitch.org Cc: echau...@redhat.com; i.maxim...@samsung.com; malvika.gu...@arm.com Subject: Re: [PATCH v11 5/5] dpif-netdev: Add

Re: [ovs-dev] [PATCH v11 5/5] dpif-netdev: Add specialized generic scalar functions

On 7/15/2019 5:36 PM, Harry van Haaren wrote: This commit adds a number of specialized functions, that handle common miniflow fingerprints. This enables compiler optimization, resulting in higher performance. Below a quick description of how this optimization actually works; "Specialized

Re: [ovs-dev] [PATCH v11 0/5] dpcls func ptrs & optimizations

On 7/15/2019 5:36 PM, Harry van Haaren wrote: Hey Folks, Here a v11 of the DPCLS Function Pointer patchset, as has been presented at OVS Conf in Nov '18, and discussed on the ML since then. I'm aware of the soft-freeze for 2.12, I feel this patchset has had enough reviews/versions/testing to be

Re: [ovs-dev] [PATCH v10 4/5] dpif-netdev: refactor generic implementation

On 7/9/2019 1:34 PM, Harry van Haaren wrote: This commit refactors the generic implementation. The goal of this refactor is to simply the code to enable 'simply' -> 'simplify'? "specialization" of the functions at compile time. Given compile-time optimizations, the compiler is able to unroll

[ovs-dev] OVS-DPDK public meeting

Next meeting July 24th 1700 UTC July 10th minutes Attendees: Ian, Aaron, Eelco, Fouad, Johann, Scott, Simon. === GENERAL === - OVS 2.12 (Ian) -- Dates --- Soft Freeze entered 7th July. Will remain until the 22nd of July. Hard freeze from the 22nd of July onwards. Only bug fixes

Re: [ovs-dev] [PATCH v10 3/5] dpif-netdev: split out generic lookup function

On 7/9/2019 1:34 PM, Harry van Haaren wrote: This commit splits the generic hash-lookup-verify function to its own file. In doing so, we must move some MACRO definitions to dpif-netdev.h Signed-off-by: Harry van Haaren Tested-by: Malvika Gupta Thanks Harry, some feedback below. --- v10:

Re: [ovs-dev] [PATCH v10 1/5] dpif-netdev: implement function pointers/subtable

On 7/10/2019 4:40 PM, Van Haaren, Harry wrote: -Original Message- From: Stokes, Ian Sent: Wednesday, July 10, 2019 4:30 PM To: Van Haaren, Harry ; d...@openvswitch.org Cc: i.maxim...@samsung.com; malvika.gu...@arm.com Subject: Re: [PATCH v10 1/5] dpif-netdev: implement function

Re: [ovs-dev] [PATCH v10 2/5] dpif-netdev: move dpcls lookup structures to .h

On 7/9/2019 1:34 PM, Harry van Haaren wrote: This commit moves some data-structures to be available in the dpif-netdev.h header. This allows specific implementations of the subtable lookup function to include just that header file, and not require that the code exists in dpif-netdev.c

Re: [ovs-dev] [PATCH v10 1/5] dpif-netdev: implement function pointers/subtable

On 7/9/2019 1:34 PM, Harry van Haaren wrote: This allows plugging-in of different subtable hash-lookup-verify routines, and allows special casing of those functions based on known context (eg: # of bits set) of the specific subtable. Signed-off-by: Harry van Haaren Tested-by: Malvika Gupta

Re: [ovs-dev] [PATCH v4 0/5] Quicker pmd threads reloads

On 7/10/2019 10:03 AM, Ilya Maximets wrote: On 09.07.2019 19:19, David Marchand wrote: We have been testing the rebalance code in different situations while having traffic going through OVS. Those tests have shown that part of the observed packets losses is due to some time wasted in

Re: [ovs-dev] [PATCH] dpif-netdev: Clarify PMD reloading scheme.

On 7/10/2019 12:50 PM, Ilya Maximets wrote: It became more complicated, hence needs to be documented. Signed-off-by: Ilya Maximets Thanks for taking care of this Ilya, very valuable info. Looks fine to me. I was just getting ready to push the quicker PMD reload series, I'll add this as

Re: [ovs-dev] [PATCH v4 0/3] vhost tx retry updates

On 7/2/2019 1:32 AM, Kevin Traynor wrote: v4: - 1/2 New patch: Move vhost tx retries doc to a seperate section (David) - 2/3 -- Changed tx_retries to be a custom stat for vhost (Ilya) -- Added back in MIN() that was dropped in v2, as in retesting I saw it is needed when the retry limit is

Re: [ovs-dev] [PATCH v4 2/3] netdev-dpdk: Add custom stat for vhost tx retries.

On 7/4/2019 4:15 PM, Ilya Maximets wrote: On 04.07.2019 18:13, Ian Stokes wrote: On 7/4/2019 12:18 PM, Ilya Maximets wrote: On 04.07.2019 14:06, David Marchand wrote: On Thu, Jul 4, 2019 at 12:42 PM Ilya Maximets mailto:i.maxim...@samsung.com>> wrote: On 03.07.2019 18:03, Ian

Re: [ovs-dev] [PATCH v4 2/3] netdev-dpdk: Add custom stat for vhost tx retries.

On 7/4/2019 12:18 PM, Ilya Maximets wrote: On 04.07.2019 14:06, David Marchand wrote: On Thu, Jul 4, 2019 at 12:42 PM Ilya Maximets mailto:i.maxim...@samsung.com>> wrote: On 03.07.2019 18:03, Ian Stokes wrote: > On 7/2/2019 1:32 AM, Kevin Traynor wrote: >> vhost

Re: [ovs-dev] [PATCH v4 2/3] netdev-dpdk: Add custom stat for vhost tx retries.

On 7/4/2019 12:18 PM, Ilya Maximets wrote: On 04.07.2019 14:06, David Marchand wrote: On Thu, Jul 4, 2019 at 12:42 PM Ilya Maximets mailto:i.maxim...@samsung.com>> wrote: On 03.07.2019 18:03, Ian Stokes wrote: > On 7/2/2019 1:32 AM, Kevin Traynor wrote: >> vhost

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Enable vhost-tx-retries config.

On 7/4/2019 12:15 PM, Ilya Maximets wrote: Few comments inline. Probably, could be fixed while applying the patch. Ok, these look reasonable to me. I can apply them this evening before committing. If I add these will I had an ACK for you Ilya? Regards Ian On 02.07.2019 3:32, Kevin

Re: [ovs-dev] [PATCH v1] doc: Remove experimental tag for SMC cache.

On 7/4/2019 11:12 AM, Ilya Maximets wrote: On 03.07.2019 19:58, Ian Stokes wrote: On 6/27/2019 12:44 PM, Yipeng Wang wrote: SMC cache was introduced in 2.10 with experimental tag. SMC cache is a layer of software cache located after EMC cache. The purpose is to improve the performance of use

Re: [ovs-dev] [PATCH v1] doc: Remove experimental tag for SMC cache.

On 6/27/2019 12:44 PM, Yipeng Wang wrote: SMC cache was introduced in 2.10 with experimental tag. SMC cache is a layer of software cache located after EMC cache. The purpose is to improve the performance of use cases that many flows missing the EMC cache. One can enable SMC cache using

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Enable vhost-tx-retries config.

On 7/2/2019 1:32 AM, Kevin Traynor wrote: vhost tx retries can provide some mitigation against dropped packets due to a temporarily slow guest/limited queue size for an interface, but on the other hand when a system is fully loaded those extra cycles retrying could mean packets are dropped

Re: [ovs-dev] [PATCH v4 2/3] netdev-dpdk: Add custom stat for vhost tx retries.

On 7/2/2019 1:32 AM, Kevin Traynor wrote: vhost tx retries may occur, and it can be a sign that the guest is not optimally configured. Add a custom stat so a user will know if vhost tx retries are occurring and hence give a hint that guest config should be examined. Thanks Kevin, tests ok

Re: [ovs-dev] [PATCH v4 1/3] doc: Move vhost tx retry info to separate section.

On 7/2/2019 1:32 AM, Kevin Traynor wrote: vhost tx retry is applicable to vhost-user and vhost-user-client, but was in the section that compares them. Also, moved further down the doc as prefer to have more fundamental info about vhost nearer the top. Fixes: 6d6513bfc657 ("doc: Add info on

Re: [ovs-dev] criteria/benchmarks for an improved userspace datapath classifier?

On 7/2/2019 6:00 PM, Ben Pfaff wrote: Hi Ilya and Ian. Please allow me to introduce Michal Orsak, a grad student currently looking at packet classifiers. He's implemented a novel classifier that is faster than the one already in OVS in the benchmarks that he's run. His classifier is

Re: [ovs-dev] [PATCH v9 1/5] dpif-netdev: implement function pointers/subtable

/15/2019 6:02 PM, Ian Stokes wrote: On 5/8/2019 4:13 PM, Harry van Haaren wrote: This allows plugging-in of different subtable hash-lookup-verify routines, and allows special casing of those functions based on known context (eg: # of bits set) of the specific subtable. Signed-off-by: Harry van

Re: [ovs-dev] [PATCH v9 1/5] dpif-netdev: implement function pointers/subtable

On 5/15/2019 6:02 PM, Ian Stokes wrote: On 5/8/2019 4:13 PM, Harry van Haaren wrote: This allows plugging-in of different subtable hash-lookup-verify routines, and allows special casing of those functions based on known context (eg: # of bits set) of the specific subtable. Signed-off-by: Harry

Re: [ovs-dev] [PATCH v3 4/4] netdev-dpdk: Enable vhost-tx-retries config.

On 6/27/2019 12:12 PM, Kevin Traynor wrote: vhost tx retries can provide some mitigation against dropped packets due to a temporarily slow guest/limited queue size for an interface, but on the other hand when a system is fully loaded those extra cycles retrying could mean packets are dropped

Re: [ovs-dev] [PATCH v3 2/4] doc: Add info on vhost tx retries.

On 6/27/2019 12:12 PM, Kevin Traynor wrote: Add documentation about vhost tx retries and external configuration that can help reduce/avoid them. Signed-off-by: Kevin Traynor Acked-by: Eelco Chaudron Acked-by: Flavio Leitner --- Documentation/topics/dpdk/vhost-user.rst | 36

Re: [ovs-dev] [PATCH v2 1/4] netdev-dpdk: Fix additional vhost tx retry.

On 6/28/2019 10:22 AM, Ian Stokes wrote: On 6/25/2019 3:57 PM, Kevin Traynor wrote: Fix minor issue of one possible additional retry. Fixes: c6ec9d176dbf ("netdev-dpdk: Fix vHost stats.") Signed-off-by: Kevin Traynor Acked-by: Eelco Chaudron ---   lib/netdev-dpdk.c | 2 +-   1 file

Re: [ovs-dev] [PATCH v2 1/4] netdev-dpdk: Fix additional vhost tx retry.

On 6/25/2019 3:57 PM, Kevin Traynor wrote: Fix minor issue of one possible additional retry. Fixes: c6ec9d176dbf ("netdev-dpdk: Fix vHost stats.") Signed-off-by: Kevin Traynor Acked-by: Eelco Chaudron --- lib/netdev-dpdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Reset queue number for vhost devices on vm shutdown.

On 6/27/2019 3:51 PM, Ilya Maximets wrote: On 27.06.2019 17:17, Ian Stokes wrote: On 6/27/2019 10:43 AM, David Marchand wrote: Rather than poll all disabled queues and waste some memory for vms that have been shutdown, we can reconfigure when receiving a destroy connection notification from

Re: [ovs-dev] [PATCH v3 2/4] doc: Add info on vhost tx retries.

On 6/27/2019 1:02 PM, 0-day Robot wrote: Bleep bloop. Greetings Kevin Traynor, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Reset queue number for vhost devices on vm shutdown.

On 6/27/2019 10:43 AM, David Marchand wrote: Rather than poll all disabled queues and waste some memory for vms that have been shutdown, we can reconfigure when receiving a destroy connection notification from the vhost library. $ while true; do ovs-appctl dpif-netdev/pmd-rxq-show |awk '

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

On 6/27/2019 8:26 AM, David Marchand wrote: Hello Ian, On Wed, Jun 26, 2019 at 11:10 PM Ian Stokes <mailto:ian.sto...@intel.com>> wrote: On 4/18/2019 3:44 PM, Ilya Maximets wrote: > On 18.04.2019 17:05, David Marchand wrote: >> Ok, how should I proceed ?

Re: [ovs-dev] [PATCH v2 branch-2.11] dpdk: Use DPDK 18.11.2 release.

On 6/27/2019 9:21 AM, Kevin Traynor wrote: On 26/06/2019 22:06, Ian Stokes wrote: Modify travis linux build script to use the latest DPDK stable release 18.11.2. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- Acked-by: Kevin Traynor Thanks for the review

Re: [ovs-dev] [PATCH v2] dpdk: Use DPDK 18.11.2 release.

On 6/27/2019 9:17 AM, Kevin Traynor wrote: On 26/06/2019 22:06, Ian Stokes wrote: Modify travis linux build script to use the latest DPDK stable release 18.11.2. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- Acked-by: Kevin Traynor Thasnk all for the reviews

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

On 4/18/2019 3:44 PM, Ilya Maximets wrote: On 18.04.2019 17:05, David Marchand wrote: On Thu, Apr 18, 2019 at 1:51 PM Ilya Maximets mailto:i.maxim...@samsung.com>> wrote: On 18.04.2019 14:26, David Marchand wrote: > On Wed, Apr 17, 2019 at 4:27 PM Kevin Traynor

[ovs-dev] [PATCH v2 branch-2.11] dpdk: Use DPDK 18.11.2 release.

Modify travis linux build script to use the latest DPDK stable release 18.11.2. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- V1 -> V2 * Remove DPDK 18.11.2 minimum requirement notice from NEWS and commit message. --- .travis/linux-build.sh

[ovs-dev] [PATCH v2] dpdk: Use DPDK 18.11.2 release.

Modify travis linux build script to use the latest DPDK stable release 18.11.2. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- V1 -> V2 * Remove DPDK minimum requirement 18.11.2 notice in NEWS. * Remove DPDK minimum requirement 18.11.2 from commit mess

Re: [ovs-dev] [PATCH v3 2/3] netdev-dpdk: Avoid reconfiguration on VIRTIO_NET_F_MQ changes.

On 4/25/2019 4:22 PM, David Marchand wrote: At the moment, a malicious guest might negotiate VIRTIO_NET_F_MQ and !VIRTIO_NET_F_MQ in a loop which would be seen as qp_num going from 1 to n and n to 1 continuously, triggering datapath reconfigurations at each transition. Limit this by only

Re: [ovs-dev] [PATCH v3 1/3] dpif-netdev: Only poll enabled vhost queues.

On 4/25/2019 4:22 PM, David Marchand wrote: We currently poll all available queues based on the max queue count exchanged with the vhost peer and rely on the vhost library in DPDK to check the vring status beneath. This can lead to some overhead when we have a lot of unused queues. To enhance

Re: [ovs-dev] [PATCH 5/5] dpif-netdev: Catch reloads faster.

On 5/23/2019 3:23 PM, David Marchand wrote: Looking at the reload flag only every 1024 loops can be a long time under load, since we might be handling 32 packets per polled rxq, per iteration, which means up to poll_cnt * 32 * 1024 packets. Look at the flag every loop, no major performance

Re: [ovs-dev] [PATCH 4/5] dpif-netdev: Only reload static tx qid when needed.

On 5/23/2019 3:23 PM, David Marchand wrote: pmd->static_tx_qid is allocated under a mutex by the different pmd threads. Unconditionally reallocating it will make those pmd threads sleep when contention occurs. During "normal" reloads like for rebalancing queues between pmd threads, this can make

Re: [ovs-dev] [PATCH 3/5] dpif-netdev: Do not sleep when swapping queues.

On 6/20/2019 3:31 PM, David Marchand wrote: On Wed, Jun 19, 2019 at 3:40 PM Ian Stokes <mailto:ian.sto...@intel.com>> wrote: On 5/23/2019 3:23 PM, David Marchand wrote: > When swapping queues from a pmd thread to another (q0 polled by pmd0/q1 > polled by pm

[ovs-dev] [PATCH v1 1/1] dpdk: Use DPDK 18.11.2 release.

18.11.1 and below are no longer supported. [1] 2b4e951cc341 ("vhost: fix passing destroyed device to destroy callback") Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +- Documentation/faq/releases.rst | 2 +- Documentation/intro/install/dpdk.r

[ovs-dev] [PATCH branch-2.11 1/1] dpdk: Use DPDK 18.11.2 release.

18.11.1 and below are no longer supported. [1] 2b4e951cc341 ("vhost: fix passing destroyed device to destroy callback") Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +- Documentation/faq/releases.rst | 2 +- Documentation/intro/install/dpdk.r

Re: [ovs-dev] [PATCH 2/5] dpif-netdev: Trigger parallel pmd reloads.

On 5/23/2019 3:23 PM, David Marchand wrote: pmd reloads are currently serialised in each steps calling reload_affected_pmds. Any pmd processing packets, waiting on a mutex etc... will make other pmd threads wait for a delay that can be undeterministic when syscalls adds up. Switch to a little

Re: [ovs-dev] [PATCH 3/5] dpif-netdev: Do not sleep when swapping queues.

On 5/23/2019 3:23 PM, David Marchand wrote: When swapping queues from a pmd thread to another (q0 polled by pmd0/q1 polled by pmd1 -> q1 polled by pmd0/q0 polled by pmd1), the current "Step 5" puts both pmds to sleep waiting for the control thread to wake them up later. Prefer to make them spin

Re: [ovs-dev] [PATCH 1/5] dpif-netdev: Convert exit latch to flag.

On 5/23/2019 3:23 PM, David Marchand wrote: No need for a latch here since we don't have to wait. A simple boolean flag is enough. The memory order on the reload flag is changed to rel-acq ordering to serve as a synchronisation point between the pmd threads and the control thread that asks for

Re: [ovs-dev] [PATCH] Docs: Refer to 18.11.1 dpdk version.

On 6/12/2019 2:01 PM, David Marchand wrote: On Wed, Jun 12, 2019 at 2:55 PM Ian Stokes <mailto:ian.sto...@intel.com>> wrote: On 6/12/2019 12:49 PM, David Marchand wrote: > This section is about checking dpdk, we can focus on just its version. > Then upd

Re: [ovs-dev] [PATCH] Docs: Refer to 18.11.1 dpdk version.

On 6/12/2019 12:49 PM, David Marchand wrote: This section is about checking dpdk, we can focus on just its version. Then update the version to 18.11.1 in the commands output. Fixes: 03f3f9c0faf8 ("dpdk: Update to use DPDK 18.11.") Fixes: b5355b0d6e66 ("dpdk: Use DPDK 18.11.1 release.")

Re: [ovs-dev] [PATCH v2] travis: Don't install kernel for DPDK checks.

On 6/11/2019 6:13 PM, David Marchand wrote: On Tue, Jun 11, 2019 at 5:32 PM Ilya Maximets > wrote: We don't need to build DPDK kernel modules to test build with OVS. And we don't need to build OVS datapath modules for checking userspace with DPDK.

Re: [ovs-dev] [dpdk-latest PATCH] netdev-dpdk: Prefix network structures with rte_.

On 6/11/2019 3:40 PM, Aaron Conole wrote: Ian Stokes writes: On 6/10/2019 3:57 PM, Ian Stokes wrote: On 6/6/2019 12:36 PM, David Marchand wrote: On Thu, Jun 6, 2019 at 1:25 PM Ian Stokes mailto:ian.sto...@intel.com>> wrote:     On 6/4/2019 12:14 PM, David Marchand wrote: &g

Re: [ovs-dev] [dpdk-latest PATCH] netdev-dpdk: Prefix network structures with rte_.

On 6/10/2019 3:57 PM, Ian Stokes wrote: On 6/6/2019 12:36 PM, David Marchand wrote: On Thu, Jun 6, 2019 at 1:25 PM Ian Stokes <mailto:ian.sto...@intel.com>> wrote:     On 6/4/2019 12:14 PM, David Marchand wrote: > On Tue, Jun 4, 2019 at 11:29 AM David Marchand > mai

Re: [ovs-dev] [dpdk-latest PATCH] netdev-dpdk: Prefix network structures with rte_.

On 6/6/2019 12:36 PM, David Marchand wrote: On Thu, Jun 6, 2019 at 1:25 PM Ian Stokes <mailto:ian.sto...@intel.com>> wrote: On 6/4/2019 12:14 PM, David Marchand wrote: > On Tue, Jun 4, 2019 at 11:29 AM David Marchand > mailto:david.march...@redhat.com> &

Re: [ovs-dev] [dpdk-latest PATCH] netdev-dpdk: Prefix network structures with rte_.

On 6/4/2019 12:14 PM, David Marchand wrote: On Tue, Jun 4, 2019 at 11:29 AM David Marchand mailto:david.march...@redhat.com>> wrote: Following a rework of dpdk network structures names [1], update the concerned parts. Ran Olivier script: sh prefix-net-rte.sh $(find -name

Re: [ovs-dev] [PATCH v9 3/5] dpif-netdev: split out generic lookup function

On 5/8/2019 4:13 PM, Harry van Haaren wrote: This commit splits the generic hash-lookup-verify function to its own file. In doing so, we must move some MACRO definitions to dpif-netdev.h Signed-off-by: Harry van Haaren --- v6: - Fixup some checkpatch warnings on whitespace with MACROs (Ilya)

Re: [ovs-dev] [PATCH v9 2/5] dpif-netdev: move dpcls lookup structures to .h

On 5/8/2019 4:13 PM, Harry van Haaren wrote: This commit moves some data-structures to be available in the dpif-netdev.h header. This allows specific implementations of the subtable lookup function to include just that header file, and not require that the code exists in dpif-netdev.c

  1   2   3   4   >