Re: [ovs-dev] [PATCH v1 1/2] userspace datapath: Add GTP-U tunnel support

2018-03-05 Thread Jiannan Ouyang
On 3/4/18, 6:55 PM, "Yang, Yi" wrote: GTP-C is for control path, so I don't think it makes sense for OVS to handle this, in addition GTP-C used different UDP port from GTP-U's, so we must have different tunnel ports to handle them respectively. I don't know if

Re: [ovs-dev] [PATCH v1 0/2] Add GTP vport based on upstream datapath

2017-07-13 Thread Jiannan Ouyang
Hi Joe, > It's neat to see new tunnel implementations being introduced, and also > quite cool that it doesn't require significant code changes to OVS to > make this happen. Thanks for looking into this :-) Thanks :) > I mentioned on the netdev thread that we should work towards using the >

Re: [ovs-dev] [PATCH net-next v1 2/3] gtp: Support creating flow-based gtp net_device

2017-07-13 Thread Jiannan Ouyang
Hi Harald, > On 7/13/17, 12:35 AM, "Harald Welte" wrote: > > > +static int gtp_dev_open(struct net_device *dev) > > +{ > > + struct gtp_dev *gtp = netdev_priv(dev); > > + struct net *net = gtp->net; > > + struct socket *sock1u; > > + struct socket *sock0; > > +

Re: [ovs-dev] [PATCH net-next v1 1/3] gtp: refactor to support flow-based gtp encap and decap

2017-07-13 Thread Jiannan Ouyang
Hi Harald, > On 7/13/17, 12:26 AM, "Harald Welte" wrote: >· > > static inline void gtp_set_pktinfo_ipv4(struct gtp_pktinfo *pktinfo, > > struct sock *sk, struct iphdr *iph, > > - struct pdp_ctx *pctx, struct rtable *rt, > > - struct flowi4 *fl4, >

Re: [ovs-dev] [PATCH net-next v1 0/3] Flow Based GTP Tunneling

2017-07-13 Thread Jiannan Ouyang
Hi Harald and Jeo, Thank you for the code review. They are really helpful! > On 7/13/17, 11:14 AM, "Joe Stringer" wrote: > > On 13 July 2017 at 00:12, Harald Welte wrote: >> I'm not familiar with the details here, but does this imply that you >>

[ovs-dev] [PATCH v1 1/2] datapath: add vport-gtp for GPRS Tunneling Protocol

2017-07-12 Thread Jiannan Ouyang
Add vport-gtp which uses gtp_create_flow_based_dev exported by the Linux GTP module to create a flow based net_device Signed-off-by: Jiannan Ouyang <ouya...@fb.com> --- datapath/Modules.mk | 2 + datapath/linux/Modules.mk | 1 + da

[ovs-dev] [PATCH v1 2/2] userspace: Add L3 tunnel type GTP

2017-07-12 Thread Jiannan Ouyang
Userspace support for L3 vport type OVS_VPORT_TYPE_GTP Signed-off-by: Jiannan Ouyang <ouya...@fb.com> --- lib/dpif-netlink.c | 5 + lib/netdev-vport.c | 14 -- ofproto/ofproto-dpif-ipfix.c | 6 ++ ofproto/ofproto-dpif-sflow.c | 6 +- vs

[ovs-dev] [PATCH v1 0/2] Add GTP vport based on upstream datapath

2017-07-12 Thread Jiannan Ouyang
ff:ff:ff->eth_dst,LOCAL" ovs-ofctl add-flow br0 \ "in_port=LOCAL,actions=set_tunnel:888, \ set_field:192.168.60.141->tun_dst,2" arp -s 10.1.1.122 02:00:00:00:00:00 Jiannan Ouyang (2): datapath: add vport-gtp for GPRS Tunneling Protocol userspace: Add L3 tunnel t

[ovs-dev] [PATCH net-next v1 0/3] Flow Based GTP Tunneling

2017-07-12 Thread Jiannan Ouyang
0.141,tun_id=123, \ actions=set_field:02:00:00:00:00:00->eth_src, \ set_field:ff:ff:ff:ff:ff:ff->eth_dst,LOCAL" ovs-ofctl add-flow br0 \ "in_port=LOCAL,actions=set_tunnel:888, \ set_field:192.168.60.141->tun_dst,2" arp -s 10.1.1.122 02:00:00:00:00:00 Jianna

[ovs-dev] [PATCH net-next v1 3/3] openvswitch: Add GPRS Tunnel Protocol (GTP) vport support

2017-07-12 Thread Jiannan Ouyang
Add OVS_VPORT_TYPE_GTP type and vport-gtp support. Signed-off-by: Jiannan Ouyang <ouya...@fb.com> --- include/uapi/linux/openvswitch.h | 1 + net/openvswitch/Kconfig | 10 +++ net/openvswitch/Makefile | 1 + net/openvswitch/vport-gtp.c

[ovs-dev] [PATCH net-next v1 1/3] gtp: refactor to support flow-based gtp encap and decap

2017-07-12 Thread Jiannan Ouyang
to the skb. - for TX, pdp lookup is bypassed. Packets are encapsulated following instructions specified in metadata_dst. Signed-off-by: Jiannan Ouyang <ouya...@fb.com> --- drivers/net/gtp.c | 162 ++ 1 file changed, 102 insertions(+), 60 del

[ovs-dev] vport-gtp: add metadata_dst support result in "netlink: Unexpected mask"

2017-04-27 Thread Jiannan Ouyang
Hi, I’m experimenting with attaching metadata_dst to skb in the gtp recv path. The goal is to let ovs to meter the gtp traffic. However, I encountered the following error in ovs_flow_cmd_new : [ 411.462443] openvswitch: netlink: Unexpected mask (mask=110058, allowed=41980cc) Seems the