Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-11-02 Thread Ben Pfaff
On Fri, Nov 02, 2018 at 08:31:06AM -0700, Gregory Rose wrote: > On 11/2/2018 4:45 AM, Jaime Caamaño Ruiz wrote: > >Upstream commit: > > commit 46ebe2834ba5b541f28ee72e556a3fed42c47570 > > Author: Jaime Caamaño Ruiz > > Date: Wed Oct 31 18:52:03 2018 +0100 > > > > openvswitch:

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-11-02 Thread Ben Pfaff
On Fri, Nov 02, 2018 at 01:57:08PM -0700, Gregory Rose wrote: > On 11/2/2018 1:46 PM, Ben Pfaff wrote: > >On Fri, Nov 02, 2018 at 08:31:06AM -0700, Gregory Rose wrote: > >>On 11/2/2018 4:45 AM, Jaime Caamaño Ruiz wrote: > >>>Upstream commit: > >>> commit

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-11-02 Thread Gregory Rose
On 11/2/2018 1:46 PM, Ben Pfaff wrote: On Fri, Nov 02, 2018 at 08:31:06AM -0700, Gregory Rose wrote: On 11/2/2018 4:45 AM, Jaime Caamaño Ruiz wrote: Upstream commit: commit 46ebe2834ba5b541f28ee72e556a3fed42c47570 Author: Jaime Caamaño Ruiz Date: Wed Oct 31 18:52:03 2018

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-11-02 Thread Gregory Rose
On 11/2/2018 4:45 AM, Jaime Caamaño Ruiz wrote: Upstream commit: commit 46ebe2834ba5b541f28ee72e556a3fed42c47570 Author: Jaime Caamaño Ruiz Date: Wed Oct 31 18:52:03 2018 +0100 openvswitch: Fix push/pop ethernet validation When there are both pop and push ethernet

[ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-11-02 Thread Jaime Caamaño Ruiz
Upstream commit: commit 46ebe2834ba5b541f28ee72e556a3fed42c47570 Author: Jaime Caamaño Ruiz Date: Wed Oct 31 18:52:03 2018 +0100 openvswitch: Fix push/pop ethernet validation When there are both pop and push ethernet header actions among the actions to be applied to a

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-11-01 Thread Gregory Rose
o: Yi-Hung Wei Cc: ovs dev , jcaam...@suse.de Subject: Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation Date: Wed, 31 Oct 2018 10:10:18 -0700 On 10/31/2018 9:56 AM, Yi-Hung Wei wrote: On Wed, Oct 31, 2018 at 9:44 AM Gregory Rose wrote: On 10/31/2018 9:08 AM, Jaime Caamaño

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-10-31 Thread Ben Pfaff
On Wed, Oct 31, 2018 at 10:40:36AM -0700, Gregory Rose wrote: > On 10/31/2018 10:32 AM, Ben Pfaff wrote: > >On Wed, Oct 31, 2018 at 08:35:13AM -0700, Gregory Rose wrote: > >>The order of tags should be: > >>Reported-at: > >>Fixes: > >>Signed-off-by: > >I agree that's the most common order but do

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-10-31 Thread Jaime Caamaño Ruiz
First go at it https://www.spinics.net/lists/netdev/msg531328.html Changed the commit message to something a bit more verbose. BR Jaime. -Original Message- From: Gregory Rose To: Yi-Hung Wei Cc: ovs dev , jcaam...@suse.de Subject: Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-10-31 Thread Gregory Rose
On 10/31/2018 10:32 AM, Ben Pfaff wrote: On Wed, Oct 31, 2018 at 08:35:13AM -0700, Gregory Rose wrote: The order of tags should be: Reported-at: Fixes: Signed-off-by: I agree that's the most common order but do we have anything that says so? (Should we?) Uh - good point.  I don't know of

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-10-31 Thread Ben Pfaff
On Wed, Oct 31, 2018 at 08:35:13AM -0700, Gregory Rose wrote: > The order of tags should be: > Reported-at: > Fixes: > Signed-off-by: I agree that's the most common order but do we have anything that says so? (Should we?) ___ dev mailing list

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-10-31 Thread Gregory Rose
On 10/31/2018 9:08 AM, Jaime Caamaño Ruiz wrote: When validating push/pop ethernet actions, mac_proto is not being reset correctly. Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047554.html Fixes: 6fcecb85ab ("datapath: add Ethernet push and pop actions")

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-10-31 Thread Yi-Hung Wei
On Wed, Oct 31, 2018 at 9:44 AM Gregory Rose wrote: > > On 10/31/2018 9:08 AM, Jaime Caamaño Ruiz wrote: > > When validating push/pop ethernet actions, mac_proto is not being reset > > correctly. > > > > Reported-at: > > https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047554.html

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-10-31 Thread Gregory Rose
On 10/31/2018 9:56 AM, Yi-Hung Wei wrote: On Wed, Oct 31, 2018 at 9:44 AM Gregory Rose wrote: On 10/31/2018 9:08 AM, Jaime Caamaño Ruiz wrote: When validating push/pop ethernet actions, mac_proto is not being reset correctly. Reported-at:

[ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-10-31 Thread Jaime Caamaño Ruiz
When validating push/pop ethernet actions, mac_proto is not being reset correctly. Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047554.html Fixes: 6fcecb85ab ("datapath: add Ethernet push and pop actions") Signed-off-by: Jaime Caamaño Ruiz ---

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-10-31 Thread Gregory Rose
On 10/31/2018 8:30 AM, Jaime Caamaño Ruiz wrote: When validating push/pop ethernet actions, mac_proto is not being reset correctly. Signed-off-by: Jaime Caamaño Ruiz Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047554.html Fixes: 6fcecb85ab ("datapath: add

[ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-10-31 Thread Jaime Caamaño Ruiz
When validating push/pop ethernet actions, mac_proto is not being reset correctly. Signed-off-by: Jaime Caamaño Ruiz Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/047554.html Fixes: 6fcecb85ab ("datapath: add Ethernet push and pop actions") ---

Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-10-31 Thread Gregory Rose
On 10/31/2018 5:35 AM, Jaime Caamaño Ruiz wrote: When validating push/pop ethernet actions, mac_proto is not being reset correctly. Signed-off-by: Jaime Caamaño Ruiz The patch looks good Jaime, I also suggest the following tags: Reported-at:

[ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

2018-10-31 Thread Jaime Caamaño Ruiz
When validating push/pop ethernet actions, mac_proto is not being reset correctly. Signed-off-by: Jaime Caamaño Ruiz --- datapath/flow_netlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c index c3f1baa05..ee0c18422