Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Fix ovs_geneve probing after restart

2017-11-02 Thread William Tu
On Wed, Nov 1, 2017 at 8:29 AM, Eric Garver wrote: > On Mon, Oct 30, 2017 at 10:36:29AM -0700, William Tu wrote: >> Thanks for the review. >> >> Guru and I had some offline discussion. We have concern about possible >> packet lost when unconditionally remove the interface and bring

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Fix ovs_geneve probing after restart

2017-11-01 Thread Eric Garver
On Mon, Oct 30, 2017 at 10:36:29AM -0700, William Tu wrote: > Thanks for the review. > > Guru and I had some offline discussion. We have concern about possible > packet lost when unconditionally remove the interface and bring it > again. Currently if the userspace ovs-vswitchd dies, since the

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Fix ovs_geneve probing after restart

2017-10-30 Thread William Tu
Thanks for the review. Guru and I had some offline discussion. We have concern about possible packet lost when unconditionally remove the interface and bring it again. Currently if the userspace ovs-vswitchd dies, since the kernel datapath module still remains, packets can still go through. If

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Fix ovs_geneve probing after restart

2017-10-26 Thread Eric Garver
On Thu, Oct 26, 2017 at 12:31:03PM -0700, William Tu wrote: > When using the out-of-tree (openvswitch compat) geneve module, > the first time oot tunnel probing returns true (correct). > Without unloading the geneve module, if the userspace ovs-vswitchd > restarts, because the 'geneve_sys_6081'

[ovs-dev] [PATCH] dpif-netlink-rtnl: Fix ovs_geneve probing after restart

2017-10-26 Thread William Tu
When using the out-of-tree (openvswitch compat) geneve module, the first time oot tunnel probing returns true (correct). Without unloading the geneve module, if the userspace ovs-vswitchd restarts, because the 'geneve_sys_6081' still exists, the probing incorrectly returns false and loads the

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Fix ovs_geneve probing after restart

2017-10-26 Thread William Tu
On Thu, Oct 26, 2017 at 11:15 AM, Eric Garver wrote: > On Thu, Oct 26, 2017 at 09:12:14AM -0700, William Tu wrote: >> On Wed, Oct 25, 2017 at 10:39 AM, Eric Garver wrote: >> > On Tue, Oct 24, 2017 at 02:43:31PM -0700, William Tu wrote: >> > >> > Hi William, >> >

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Fix ovs_geneve probing after restart

2017-10-26 Thread William Tu
On Wed, Oct 25, 2017 at 10:39 AM, Eric Garver wrote: > On Tue, Oct 24, 2017 at 02:43:31PM -0700, William Tu wrote: > > Hi William, > Thanks for taking a look at this. > >> When using the out-of-tree (openvswitch compat) geneve module, >> the first time oot tunnel probing returns

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Fix ovs_geneve probing after restart

2017-10-25 Thread Eric Garver
On Tue, Oct 24, 2017 at 02:43:31PM -0700, William Tu wrote: Hi William, Thanks for taking a look at this. > When using the out-of-tree (openvswitch compat) geneve module, > the first time oot tunnel probing returns true (correct). > Without unloading the geneve module, if the userspace

[ovs-dev] [PATCH] dpif-netlink-rtnl: Fix ovs_geneve probing after restart

2017-10-24 Thread William Tu
When using the out-of-tree (openvswitch compat) geneve module, the first time oot tunnel probing returns true (correct). Without unloading the geneve module, if the userspace ovs-vswitchd restarts, because the 'geneve_sys_6081' still exists, the probing incorrectly returns false and loads the