Re: [ovs-dev] [PATCH 2/2] ofproto: Add ref counting for variable length mf_fields.

2017-03-10 Thread Joe Stringer
On 10 March 2017 at 11:34, Joe Stringer wrote: > On 9 March 2017 at 10:22, Yi-Hung Wei wrote: >> On Wed, Mar 8, 2017 at 11:40 AM, Joe Stringer wrote: > diff --git a/lib/meta-flow.c b/lib/meta-flow.c > index e844008f6294..bef5aad768a3 100644 >

Re: [ovs-dev] [PATCH 2/2] ofproto: Add ref counting for variable length mf_fields.

2017-03-09 Thread Yi-Hung Wei
Thanks for review Joe! Please find my response below. Patch v2 will be in the following e-mail. On Wed, Mar 8, 2017 at 11:40 AM, Joe Stringer wrote: > On 7 March 2017 at 09:39, Yi-Hung Wei wrote: > > Currently, a controller may potentially trigger a

Re: [ovs-dev] [PATCH 2/2] ofproto: Add ref counting for variable length mf_fields.

2017-03-08 Thread Joe Stringer
On 7 March 2017 at 09:39, Yi-Hung Wei wrote: > Currently, a controller may potentially trigger a segmentation fault if it > accidentally removes a TLV mapping that is still used by an active flow. > To resolve this issue, in this patch, we maintain reference counting for

[ovs-dev] [PATCH 2/2] ofproto: Add ref counting for variable length mf_fields.

2017-03-07 Thread Yi-Hung Wei
Currently, a controller may potentially trigger a segmentation fault if it accidentally removes a TLV mapping that is still used by an active flow. To resolve this issue, in this patch, we maintain reference counting for each dynamically allocated variable length mf_fields, so that vswitchd can