Thanks Ilya and kevin.
Regards,
Sriram.
-Original Message-
From: Ilya Maximets
Sent: 12 November 2019 00:08
To: Ilya Maximets ; Kevin Traynor ;
Sriram Vatala ; ovs-dev@openvswitch.org
Subject: Re: [PATCH v11 2/3] netdev-dpdk : Detailed packet drop statistics
On 11.11.2019 17:11, Ilya
On 11.11.2019 17:11, Ilya Maximets wrote:
>>> I'm not sure if clang annotations will work with rte_spinlock.
>>> DPDK doesn't have proper annotations for locking functions.
>>>
>>
>> Ah, good point, I didn't check the lock type. In that case nevermind,
>> patch+incremental LGTM as is.
>>
>>
On 11.11.2019 17:06, Kevin Traynor wrote:
> On 11/11/2019 15:59, Ilya Maximets wrote:
>> On 11.11.2019 16:55, Kevin Traynor wrote:
>>> On 10/11/2019 23:20, Ilya Maximets wrote:
On 29.10.2019 15:50, Sriram Vatala wrote:> @@ -2388,12 +2412,16 @@
__netdev_dpdk_vhost_send(struct netdev
On 11/11/2019 15:59, Ilya Maximets wrote:
> On 11.11.2019 16:55, Kevin Traynor wrote:
>> On 10/11/2019 23:20, Ilya Maximets wrote:
>>> On 29.10.2019 15:50, Sriram Vatala wrote:> @@ -2388,12 +2412,16 @@
>>> __netdev_dpdk_vhost_send(struct netdev *netdev, int qid,
}
}
On 11.11.2019 16:55, Kevin Traynor wrote:
> On 10/11/2019 23:20, Ilya Maximets wrote:
>> On 29.10.2019 15:50, Sriram Vatala wrote:> @@ -2388,12 +2412,16 @@
>> __netdev_dpdk_vhost_send(struct netdev *netdev, int qid,
>>> }
>>> } while (cnt && (retries++ < max_retries));
>>>
>>>
On 10/11/2019 23:20, Ilya Maximets wrote:
> On 29.10.2019 15:50, Sriram Vatala wrote:> @@ -2388,12 +2412,16 @@
> __netdev_dpdk_vhost_send(struct netdev *netdev, int qid,
>> }
>> } while (cnt && (retries++ < max_retries));
>>
>> +tx_failure = cnt;
>>
Hi Ilya,
Thanks for the review. I agree with your proposal to move the stats update
code to existing special functions. Thanks for the incremental patch, it looks
good to me. Will wait for Kevin's taught on this.
Thanks & Regards,
Sriram.
-Original Message-
From: Ilya Maximets
Sent:
On 11.11.2019 0:44, Ilya Maximets wrote:
> Sorry if you've received incremental patch with shifted lines.
> Thunderbird behaves weirdly. For some reason it adds a single
> space for every line that starts with a space. I'm not sure
> how to fix that. I could re-send incremental patch with some
Sorry if you've received incremental patch with shifted lines.
Thunderbird behaves weirdly. For some reason it adds a single
space for every line that starts with a space. I'm not sure
how to fix that. I could re-send incremental patch with some
different tool (git-send-email) if needed.
On 29.10.2019 15:50, Sriram Vatala wrote:> @@ -2388,12 +2412,16 @@
__netdev_dpdk_vhost_send(struct netdev *netdev, int qid,
}
} while (cnt && (retries++ < max_retries));
+tx_failure = cnt;
rte_spinlock_unlock(>tx_q[qid].tx_lock);
OVS may be unable to transmit packets for multiple reasons on
the userspace datapath and today there is a single counter to
track packets dropped due to any of those reasons. This patch
adds custom software stats for the different reasons packets
may be dropped during tx/rx on the userspace
11 matches
Mail list logo
