Re: [ovs-dev] [PATCH v2] netlink: removed incorrect optimization

2021-06-04 Thread Gregory Rose
On 6/2/2021 3:00 PM, Toms Atteka wrote: This optimization caused FLOW_TNL_F_UDPIF flag not to be used in hash calculation for geneve tunnel when revalidating flows which resulted in different cache hash values and incorrect behaviour. Added test to prevent regression. Reported-at:

Re: [ovs-dev] [PATCH v2] netlink: removed incorrect optimization

2021-06-02 Thread 0-day Robot
Bleep bloop. Greetings Toms Atteka, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has trailing whitespace #28 FILE: lib/tun-metadata.c:831: } else { Lines

[ovs-dev] [PATCH v2] netlink: removed incorrect optimization

2021-06-02 Thread Toms Atteka
This optimization caused FLOW_TNL_F_UDPIF flag not to be used in hash calculation for geneve tunnel when revalidating flows which resulted in different cache hash values and incorrect behaviour. Added test to prevent regression. Reported-at: https://github.com/vmware-tanzu/antrea/issues/897