Re: [ovs-dev] [PATCH v6] ofproto-dpif-upcall: Wait for valid hw flow stats before applying min-revalidate-pps
On 8 Mar 2023, at 13:53, Ilya Maximets wrote: > On 3/8/23 13:23, Eelco Chaudron wrote: >> Depending on the driver implementation, it can take from 0.2 seconds >> up to 2 seconds before offloaded flow statistics are updated. This is >> true for both TC and rte_flow-based offloading. This is causing a >> problem with min-revalidate-pps, as old statistic values are used >> during this period. >> >> This fix will wait for at least 2 seconds, by default, before assuming no >> packets where received during this period. >> >> Reviewed-by: Simon Horman >> Signed-off-by: Eelco Chaudron >> --- >> >> Changes: >> - v2: Use existing ukey->offloaded so the revalidate_missed_dp_flow case is >> also covered. >> - v3: Added OVS_REQUIRES(ukey->mutex) to should_revalidate() to keep >> thread-safety-analysis happy. >> - v4: Add a configurable option. >> After looking at multiple vendor implementation for both TC and >> rte_flow I came to the conclusion that the delay is roughly between >> 0.2 and 2 seconds. Updated commit message. >> - v5: Rebased on latest upstream master. >> Made the key parameter const in should_revalidate(). >> - v6: Updated comments and documentation to be more clear. >> >> ofproto/ofproto-dpif-upcall.c | 26 -- >> ofproto/ofproto-provider.h|5 + >> ofproto/ofproto.c | 10 ++ >> ofproto/ofproto.h |2 ++ >> vswitchd/bridge.c |3 +++ >> vswitchd/vswitch.xml | 13 + >> 6 files changed, 49 insertions(+), 10 deletions(-) > > Hi, Eelco. This patch is not applicable to current master. > Needs a rebase. Yes, the robot just told me ;) A v7 is out right now… //Eelco ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v6] ofproto-dpif-upcall: Wait for valid hw flow stats before applying min-revalidate-pps
On 3/8/23 13:23, Eelco Chaudron wrote: > Depending on the driver implementation, it can take from 0.2 seconds > up to 2 seconds before offloaded flow statistics are updated. This is > true for both TC and rte_flow-based offloading. This is causing a > problem with min-revalidate-pps, as old statistic values are used > during this period. > > This fix will wait for at least 2 seconds, by default, before assuming no > packets where received during this period. > > Reviewed-by: Simon Horman > Signed-off-by: Eelco Chaudron > --- > > Changes: > - v2: Use existing ukey->offloaded so the revalidate_missed_dp_flow case is > also covered. > - v3: Added OVS_REQUIRES(ukey->mutex) to should_revalidate() to keep > thread-safety-analysis happy. > - v4: Add a configurable option. > After looking at multiple vendor implementation for both TC and > rte_flow I came to the conclusion that the delay is roughly between > 0.2 and 2 seconds. Updated commit message. > - v5: Rebased on latest upstream master. > Made the key parameter const in should_revalidate(). > - v6: Updated comments and documentation to be more clear. > > ofproto/ofproto-dpif-upcall.c | 26 -- > ofproto/ofproto-provider.h|5 + > ofproto/ofproto.c | 10 ++ > ofproto/ofproto.h |2 ++ > vswitchd/bridge.c |3 +++ > vswitchd/vswitch.xml | 13 + > 6 files changed, 49 insertions(+), 10 deletions(-) Hi, Eelco. This patch is not applicable to current master. Needs a rebase. Best regards, Ilya Maximets. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v6] ofproto-dpif-upcall: Wait for valid hw flow stats before applying min-revalidate-pps
Bleep bloop. Greetings Eelco Chaudron, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 ofproto-dpif-upcall: Wait for valid hw flow stats before applying min-revalidate-pps When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH v6] ofproto-dpif-upcall: Wait for valid hw flow stats before applying min-revalidate-pps
Depending on the driver implementation, it can take from 0.2 seconds
up to 2 seconds before offloaded flow statistics are updated. This is
true for both TC and rte_flow-based offloading. This is causing a
problem with min-revalidate-pps, as old statistic values are used
during this period.
This fix will wait for at least 2 seconds, by default, before assuming no
packets where received during this period.
Reviewed-by: Simon Horman
Signed-off-by: Eelco Chaudron
---
Changes:
- v2: Use existing ukey->offloaded so the revalidate_missed_dp_flow case is
also covered.
- v3: Added OVS_REQUIRES(ukey->mutex) to should_revalidate() to keep
thread-safety-analysis happy.
- v4: Add a configurable option.
After looking at multiple vendor implementation for both TC and
rte_flow I came to the conclusion that the delay is roughly between
0.2 and 2 seconds. Updated commit message.
- v5: Rebased on latest upstream master.
Made the key parameter const in should_revalidate().
- v6: Updated comments and documentation to be more clear.
ofproto/ofproto-dpif-upcall.c | 26 --
ofproto/ofproto-provider.h|5 +
ofproto/ofproto.c | 10 ++
ofproto/ofproto.h |2 ++
vswitchd/bridge.c |3 +++
vswitchd/vswitch.xml | 13 +
6 files changed, 49 insertions(+), 10 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index fc94078cb..60c273a1d 100644
--- a/ofproto/ofproto-dpif-upcall.c
+++ b/ofproto/ofproto-dpif-upcall.c
@@ -2100,10 +2100,12 @@ ukey_delete(struct umap *umap, struct udpif_key *ukey)
}
static bool
-should_revalidate(const struct udpif *udpif, uint64_t packets,
- long long int used)
+should_revalidate(const struct udpif *udpif, const struct udpif_key *ukey,
+ uint64_t packets)
+OVS_REQUIRES(ukey->mutex)
{
long long int metric, now, duration;
+long long int used = ukey->stats.used;
if (!ofproto_min_revalidate_pps) {
return true;
@@ -2134,8 +2136,12 @@ should_revalidate(const struct udpif *udpif, uint64_t
packets,
duration = now - used;
metric = duration / packets;
-if (metric < 1000 / ofproto_min_revalidate_pps) {
-/* The flow is receiving more than min-revalidate-pps, so keep it. */
+if (metric < 1000 / ofproto_min_revalidate_pps ||
+(ukey->offloaded && duration < ofproto_offloaded_stats_delay)) {
+/* The flow is receiving more than min-revalidate-pps, so keep it.
+ * Or it's a hardware offloaded flow that might take up to X seconds
+ * to update its statistics. Until we are sure the statistics had a
+ * chance to be updated, also keep it. */
return true;
}
return false;
@@ -2339,7 +2345,7 @@ static enum reval_result
revalidate_ukey(struct udpif *udpif, struct udpif_key *ukey,
const struct dpif_flow_stats *stats,
struct ofpbuf *odp_actions, uint64_t reval_seq,
-struct recirc_refs *recircs, bool offloaded)
+struct recirc_refs *recircs)
OVS_REQUIRES(ukey->mutex)
{
bool need_revalidate = ukey->reval_seq != reval_seq;
@@ -2358,7 +2364,7 @@ revalidate_ukey(struct udpif *udpif, struct udpif_key
*ukey,
: 0);
if (need_revalidate) {
-if (should_revalidate(udpif, push.n_packets, ukey->stats.used)) {
+if (should_revalidate(udpif, ukey, push.n_packets)) {
if (!ukey->xcache) {
ukey->xcache = xlate_cache_new();
} else {
@@ -2374,7 +2380,7 @@ revalidate_ukey(struct udpif *udpif, struct udpif_key
*ukey,
/* Stats for deleted flows will be attributed upon flow deletion. Skip. */
if (result != UKEY_DELETE) {
-xlate_push_stats(ukey->xcache, , offloaded);
+xlate_push_stats(ukey->xcache, , ukey->offloaded);
ukey->stats = *stats;
ukey->reval_seq = reval_seq;
}
@@ -2774,6 +2780,7 @@ revalidate(struct revalidator *revalidator)
continue;
}
+ukey->offloaded = f->attrs.offloaded;
already_dumped = ukey->dump_seq == dump_seq;
if (already_dumped) {
/* The flow has already been handled during this flow dump
@@ -2805,8 +2812,7 @@ revalidate(struct revalidator *revalidator)
result = UKEY_DELETE;
} else {
result = revalidate_ukey(udpif, ukey, , _actions,
- reval_seq, ,
- f->attrs.offloaded);
+ reval_seq, );
}
ukey->dump_seq = dump_seq;
@@ -2891,7 +2897,7 @@ revalidator_sweep__(struct revalidator *revalidator, bool
purge)
COVERAGE_INC(revalidate_missed_dp_flow);
memcpy(, >stats, sizeof stats);
